Re: [PATCH 1/1] usb: chipidea: udc: delete td from req's td list at ep_dequeue

2014-06-30 Thread Andrzej Pietrasiewicz
Hello Peter, W dniu 30.06.2014 06:15, Peter Chen pisze: We need to delete un-finished td from current request's td list at ep_dequeue API, otherwise, this non-user td will be remained at td list before this request is freed. So if we do ep_queue-> ep_dequeue->ep_queue sequence, when the complete

Re: [PATCH 1/2] usb: host: Kconfig: Select PHY drivers for Exynos EHCI/OHCI

2014-06-30 Thread Sachin Kamat
On Fri, Jun 27, 2014 at 10:23 PM, Olof Johansson wrote: > On Fri, Jun 27, 2014 at 9:32 AM, Doug Anderson wrote: >> Felipe, >> >> On Fri, Jun 27, 2014 at 8:59 AM, Felipe Balbi wrote: I'll admit to not having been involved with the previous discussions, but this seems strange to me. Are

[PATCHv2] usb: gadget: serial: replace hardcoded ttyGS with PREFIX

2014-06-30 Thread Richard Leitner
Replaces all hardcoded ttyGS strings with the PREFIX macro. Due to the fact the strings are spread over different source files the PREFIX definition is moved to u_serial.h Signed-off-by: Richard Leitner --- v2: removed checkpatch.pl resovling (will be in a separate patch) --- drivers/usb/gadget/

RE: [PATCH v2] USB: ehci-pci: USB host controller support for Intel Quark X1000

2014-06-30 Thread Chen, Alvin
> > The EHCI packet buffer in/out threshold is programmable for Intel > > Quark X1000 USB host controller, and the default value is 0x20 dwords. > > The in/out threshold can be programmed to 0x80 dwords, but only when > > isochronous/interrupt transactions are not initiated by the USB host > > cont

RE: [PATCHv2] usb: gadget: serial: replace hardcoded ttyGS with PREFIX

2014-06-30 Thread David Laight
From: Of Richard Leitner > Replaces all hardcoded ttyGS strings with the PREFIX macro. > Due to the fact the strings are spread over different source files the > PREFIX definition is moved to u_serial.h Lots of changes like: > - DBG(cdev, "acm ttyGS%d completion, err %d\n", > -

Re: [PATCH v2 2/3] usb: gadget: pxa27x_udc device-tree documentation

2014-06-30 Thread Mark Rutland
On Sun, Jun 29, 2014 at 10:29:49AM +0100, Robert Jarzmik wrote: > Mark Rutland writes: > > > On Wed, Jun 25, 2014 at 08:54:01PM +0100, Robert Jarzmik wrote: > >> > The name of the clock input doesn't make sense. > >> I don't understand. With [1] does it make any more sense ? If not you'll > >> h

Re: [PATCHv2] usb: gadget: serial: replace hardcoded ttyGS with PREFIX

2014-06-30 Thread Richard Leitner
Hi, On Mon, 30 Jun 2014 08:41:18 + David Laight wrote: > From: Of Richard Leitner > > Replaces all hardcoded ttyGS strings with the PREFIX macro. > > Due to the fact the strings are spread over different source files the > > PREFIX definition is moved to u_serial.h > > Lots of changes like:

[PATCH 1/1] usb: dwc3: Kconfig: Fix dependency for Exynos DWC3

2014-06-30 Thread Sachin Kamat
Make the config depend on ARCH_EXYNOS5 instead of ARCH_EXYNOS as this IP is available only on Exynos5 platforms. Signed-off-by: Sachin Kamat --- drivers/usb/dwc3/Kconfig |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig ind

RE: [PATCHv2] usb: gadget: serial: replace hardcoded ttyGS with PREFIX

2014-06-30 Thread David Laight
From: Richard Leitner > On Mon, 30 Jun 2014 08:41:18 + > David Laight wrote: > > > From: Of Richard Leitner > > > Replaces all hardcoded ttyGS strings with the PREFIX macro. > > > Due to the fact the strings are spread over different source files the > > > PREFIX definition is moved to u_ser

[PATCH v3] USB: ehci-pci: USB host controller support for Intel Quark X1000

2014-06-30 Thread Chen, Alvin
From: Bryan O'Donoghue The EHCI packet buffer in/out threshold is programmable for Intel Quark X1000 USB host controller, and the default value is 0x20 dwords. The in/out threshold can be programmed to 0x80 dwords (512 Bytes) to maximize the perfomrance, but only when isochronous/interrupt transa

[PATCH v3] USB: ehci-pci: Add support for Intel Quark X1000 USB

2014-06-30 Thread Chen, Alvin
From: "Alvin (Weike) Chen" Hi, Intel Quark X1000 consists of one USB host controller which can be PCI enumerated. And the exsiting EHCI-PCI framework supports it with the default packet buffer in/out threshold. We reconfigure the in/out threshold as maximal as possible to maximize the performanc

Re: [RFC PATCH 3/3] usb: phy: msm: Do not do runtime pm if the phy is not idle

2014-06-30 Thread Srinivas Kandagatla
Hi Felipe, On 27/06/14 16:54, Felipe Balbi wrote: Hi, On Wed, Jun 18, 2014 at 06:01:08PM +0100, Srinivas Kandagatla wrote: Use case is when the phy is configured in host mode and a usb device is attached to board before bootup. On bootup, with the existing code and runtime pm enabled, the driv

Re: [PATCH 2/2 v3] HID: leds: move led_mode attribute to led-class devices in MSI GT683R driver

2014-06-30 Thread Johan Hovold
On Wed, Jun 25, 2014 at 09:13:09PM +0300, Janne Kanniainen wrote: > Move led_mode attribute from HID device to led-class devices and rename it > msi_mode. This will also fix race condition by using attribute-groups. > > Signed-off-by: Janne Kanniainen > --- > > Changes in v3: > - Style fix

Re: [PATCH 2/2 v2] HID: leds: Use attribute-groups in MSI GT683R driver

2014-06-30 Thread Johan Hovold
On Wed, Jun 25, 2014 at 03:55:10PM -0700, Bryan Wu wrote: > On Wed, Jun 25, 2014 at 12:09 PM, Jiri Kosina wrote: > > On Wed, 25 Jun 2014, Johan Hovold wrote: > > > >> Did you see the attribute-race series I posted? Not sure how best to > >> handle the dependency, as those patches should probably g

[PATCH 2/3] phy: omap-usb2: Add PHY regulator to DT binding documentation

2014-06-30 Thread Roger Quadros
The PHY driver can manage a regulator that supplies power to the USB2 PHY. Add DT binding information for that. Signed-off-by: Roger Quadros --- Documentation/devicetree/bindings/phy/ti-phy.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/phy/ti-phy.txt

[PATCH 3/3] ARM: dts: dra7-evm: Add regulator information to USB2 PHYs

2014-06-30 Thread Roger Quadros
The ldousb_reg regulator provides power to the USB1 and USB2 High Speed PHYs. Signed-off-by: Roger Quadros --- arch/arm/boot/dts/dra7-evm.dts | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm/boot/dts/dra7-evm.dts b/arch/arm/boot/dts/dra7-evm.dts index 4adc280..fd96ced 100644

[PATCH 0/3] PHY: ti-pipe3: Manage 3.3V PHY regulator

2014-06-30 Thread Roger Quadros
Hi, On some SoCs e.g. J6 the 3.3V supply to the USB2 PHY can be powered down when the PHY is not in use. Add regulator management code to control this power line. cheers, -roger --- Roger Quadros (3): phy: omap-usb2: Manage PHY 3.3V supply regulator phy: omap-usb2: Add PHY regulator to DT bi

[PATCH 1/3] phy: omap-usb2: Manage PHY 3.3V supply regulator

2014-06-30 Thread Roger Quadros
On some SoCs e.g. J6 the 3.3V supply to the USB2 PHY can be powered down when the PHY is not in use. Add regulator management code to control this power line. Signed-off-by: Roger Quadros --- drivers/phy/phy-omap-usb2.c | 25 + include/linux/phy/omap_usb.h | 1 + 2 file

[PATCH 0/2] BUGFIX: usb: musb: dsps: fix the base address for accessing the mode register

2014-06-30 Thread Lothar Waßmann
The first patch cleans up the coding style of the register accessor functions which made my eyes sore. The second patch makes the function added in commit 943c13971c08 "usb: musb: dsps: implement ->set_mode()" actually functional by using the correct base address for the register accesses. -- To

[PATCH 2/2] usb: musb: dsps: fix the base address for accessing the mode register

2014-06-30 Thread Lothar Waßmann
commit 943c13971c08 "usb: musb: dsps: implement ->set_mode()" should have made it possible to use the driver with boards that have the USBID pin unconnected. This doesn't actually work, since the driver uses the wrong base address to access the mode register. Furthermore it uses different base addr

[PATCH 1/2] usb: musb: dsps: coding style cleanup

2014-06-30 Thread Lothar Waßmann
There is no reason for the register accessor functions not to adhere to the CodingStyle rules. Signed-off-by: Lothar Waßmann --- drivers/usb/musb/musb_dsps.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb/mu

Re: [PATCHv2] usb: gadget: serial: replace hardcoded ttyGS with PREFIX

2014-06-30 Thread Richard Leitner
Hi, On Mon, 30 Jun 2014 09:08:01 + David Laight wrote: > > > From: Of Richard Leitner > > > > Replaces all hardcoded ttyGS strings with the PREFIX macro. > > > > Due to the fact the strings are spread over different source files the > > > > PREFIX definition is moved to u_serial.h > > > > >

Re: [PATCH 2/2 v2] HID: leds: Use attribute-groups in MSI GT683R driver

2014-06-30 Thread Jiri Kosina
On Mon, 30 Jun 2014, Johan Hovold wrote: > > I think the better place is HID/input tree, since this patch depends > > on the initial one which is not in my tree. > > I'm going to merge Johan's whole patchset and this patch probably > > depends Johan's work too. > > Dmitry has ACKed the input-patc

Re: [PATCH 1/1] usb: chipidea: udc: delete td from req's td list at ep_dequeue

2014-06-30 Thread Michael Grzeschik
On Mon, Jun 30, 2014 at 12:15:03PM +0800, Peter Chen wrote: > We need to delete un-finished td from current request's td list > at ep_dequeue API, otherwise, this non-user td will be remained > at td list before this request is freed. So if we do ep_queue-> > ep_dequeue->ep_queue sequence, when the

Re: [PATCH 1/1] usb: chipidea: udc: delete td from req's td list at ep_dequeue

2014-06-30 Thread Peter Chen
On Mon, Jun 30, 2014 at 02:19:04PM +0200, Michael Grzeschik wrote: > On Mon, Jun 30, 2014 at 12:15:03PM +0800, Peter Chen wrote: > > We need to delete un-finished td from current request's td list > > at ep_dequeue API, otherwise, this non-user td will be remained > > at td list before this request

Re: [PATCH 1/1] usb: chipidea: udc: delete td from req's td list at ep_dequeue

2014-06-30 Thread Peter Chen
On Mon, Jun 30, 2014 at 09:11:11AM +0200, Andrzej Pietrasiewicz wrote: > Hello Peter, > > W dniu 30.06.2014 06:15, Peter Chen pisze: > >We need to delete un-finished td from current request's td list > >at ep_dequeue API, otherwise, this non-user td will be remained > >at td list before this reque

Re: [PATCH v3] USB: ehci-pci: USB host controller support for Intel Quark X1000

2014-06-30 Thread Sergei Shtylyov
Hello. On 06/30/2014 09:06 PM, Chen, Alvin wrote: From: Bryan O'Donoghue The EHCI packet buffer in/out threshold is programmable for Intel Quark X1000 USB host controller, and the default value is 0x20 dwords. The in/out threshold can be programmed to 0x80 dwords (512 Bytes) to maximize the

Re: [PATCH v2 07/12] usb: chipidea: add a generic driver

2014-06-30 Thread Antoine Ténart
Peter, On Fri, Jun 27, 2014 at 11:25:07AM +0800, Peter Chen wrote: > On Tue, Jun 24, 2014 at 12:35:16PM +0200, Antoine Ténart wrote: > > > > ifneq ($(CONFIG_OF),) > > obj-$(CONFIG_USB_CHIPIDEA) += usbmisc_imx.o ci_hdrc_imx.o > > + obj-$(CONFIG_USB_CHIPIDEA) += ci_hdrc_generic.o

Re: [PATCH v2 07/12] usb: chipidea: add a generic driver

2014-06-30 Thread Antoine Ténart
Hello, On Tue, Jun 24, 2014 at 07:51:01PM +0900, Jingoo Han wrote: > On Tuesday, June 24, 2014 7:35 PM, Antoine Tenart wrote: > > > > Add a generic ChipIdea driver, with optional PHY and clock, to support > > ChipIdea controllers that doesn't need specific functions. > > s/doesn't/don't > > >

Re: [usb-storage] Re: External USB3 disk fails with "Invalid field in cdb"

2014-06-30 Thread Michael Büsch
On Fri, 27 Jun 2014 21:52:35 +0200 Michael Büsch wrote: > On Fri, 27 Jun 2014 15:23:42 -0400 (EDT) > Alan Stern wrote: > > Does the patch below do what you and James want? > > Yes, this does work. Thanks! > > You can add my > Tested-by: Michael Büsch Does somebody pick this up for inclusion

Re: XHCI, "brain-dead scanner", and microframe rounding

2014-06-30 Thread Mathias Nyman
On 06/30/2014 12:02 AM, Mike Mammarella wrote: > recently got a computer [1] with USB3 ports, and plugged my Fujitsu Scansnap > S1500 scanner into one of them. It turns out this doesn't work, and after a > lot of searching the web and tinkering with it I've discovered that it has > something to

Re: [usb-storage] Re: External USB3 disk fails with "Invalid field in cdb"

2014-06-30 Thread James Bottomley
On Fri, 2014-06-27 at 15:23 -0400, Alan Stern wrote: > On Fri, 27 Jun 2014, Michael Büsch wrote: > > > On Fri, 27 Jun 2014 14:42:01 -0400 (EDT) > > Alan Stern wrote: > > > > > Michael, can you post the "lsusb -v" output for this device? I see it > > > is made by JMicron; they are notorious for

Re: [usb-storage] Re: External USB3 disk fails with "Invalid field in cdb"

2014-06-30 Thread Alan Stern
On Mon, 30 Jun 2014, James Bottomley wrote: > > Does the patch below do what you and James want? > > Yes, that's the usual annoying additions to our blacklist. You can add > my acked-by and could you cc stable? Will do. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe l

Re: [PATCH v3] USB: ehci-pci: USB host controller support for Intel Quark X1000

2014-06-30 Thread Alan Stern
On Mon, 30 Jun 2014, Chen, Alvin wrote: > From: Bryan O'Donoghue > > The EHCI packet buffer in/out threshold is programmable for Intel Quark X1000 > USB host controller, and the default value is 0x20 dwords. The in/out > threshold > can be programmed to 0x80 dwords (512 Bytes) to maximize the p

Re: XHCI, "brain-dead scanner", and microframe rounding

2014-06-30 Thread Alan Stern
On Mon, 30 Jun 2014, Mathias Nyman wrote: > xhci specs says it needs the interval rounded to nearest 2^(X) value, > which would be 256, not 128. I'll take a look at that. Doesn't the spec says it needs the interval rounded _down_ to a power of 2? Alan Stern -- To unsubscribe from this list: sen

Re: [PATCHv2] usb: gadget: serial: replace hardcoded ttyGS with PREFIX

2014-06-30 Thread Greg Kroah-Hartman
On Mon, Jun 30, 2014 at 01:23:27PM +0200, Richard Leitner wrote: > Hi, > > On Mon, 30 Jun 2014 09:08:01 + > David Laight wrote: > > > > > From: Of Richard Leitner > > > > > Replaces all hardcoded ttyGS strings with the PREFIX macro. > > > > > Due to the fact the strings are spread over diffe

Re: [PATCH v2 05/12] usb: phy: add the Berlin USB PHY driver

2014-06-30 Thread Antoine Ténart
Felipe, On Fri, Jun 27, 2014 at 06:04:33PM -0500, Felipe Balbi wrote: > On Fri, Jun 27, 2014 at 06:05:57PM +0200, Antoine Ténart wrote: > > Hi Felipe, > > > > On Fri, Jun 27, 2014 at 10:56:22AM -0500, Felipe Balbi wrote: > > > On Tue, Jun 24, 2014 at 12:35:14PM +0200, Antoine Ténart wrote: > > >

[PATCH] usb-storage/SCSI: Add broken_fua blacklist flag

2014-06-30 Thread Alan Stern
Some buggy JMicron USB-ATA bridges don't know how to translate the FUA bit in READs or WRITEs. This patch adds an entry in unusual_devs.h and a blacklist flag to tell the sd driver not to use FUA. Signed-off-by: Alan Stern Reported-by: Michael Büsch Tested-by: Michael Büsch Acked-by: James Bot

Re: [PATCH] usb: host: ohci-tmio: Use managed interfaces for resource allocation

2014-06-30 Thread Alan Stern
On Sun, 29 Jun 2014, Himangi Saraogi wrote: > This patch moves resources allocated using ioremap or > dma_declare_coherent_memory to the corresponding managed interface. The > function calls to free the allocated resources are removed in the probe > and remove functions as they are no longer requi

Re: [PATCH] usb-storage/SCSI: Add broken_fua blacklist flag

2014-06-30 Thread Alan Stern
On Mon, 30 Jun 2014, Alan Stern wrote: > Some buggy JMicron USB-ATA bridges don't know how to translate the FUA > bit in READs or WRITEs. This patch adds an entry in unusual_devs.h > and a blacklist flag to tell the sd driver not to use FUA. > > Signed-off-by: Alan Stern > Reported-by: Michael

Re: [PATCH] usb: host: ohci-tmio: Use managed interfaces for resource allocation

2014-06-30 Thread Julia Lawall
On Mon, 30 Jun 2014, Alan Stern wrote: > On Sun, 29 Jun 2014, Himangi Saraogi wrote: > > > This patch moves resources allocated using ioremap or > > dma_declare_coherent_memory to the corresponding managed interface. The > > function calls to free the allocated resources are removed in the probe

[Patch v7 2/3] usb: phy: Add Qualcomm DWC3 HS/SS PHY drivers

2014-06-30 Thread Andy Gross
From: "Ivan T. Ivanov" These drivers handles control and configuration of the HS and SS USB PHY transceivers. They are part of the driver which manage Synopsys DesignWare USB3 controller stack inside Qualcomm SoC's. Signed-off-by: Ivan T. Ivanov Signed-off-by: Andy Gross --- drivers/usb/phy/K

[Patch v7 3/3] usb: dwc3: qcom: Add device tree binding

2014-06-30 Thread Andy Gross
From: "Ivan T. Ivanov" QCOM USB3.0 core wrapper consist of USB3.0 IP from Synopsys (SNPS) and HS, SS PHY's control and configuration registers. It could operate in device mode (SS, HS, FS) and host mode (SS, HS, FS, LS). Signed-off-by: Ivan T. Ivanov Signed-off-by: Andy Gross --- .../devicet

[Patch v7 1/3] usb: dwc3: Add Qualcomm DWC3 glue layer driver

2014-06-30 Thread Andy Gross
From: "Ivan T. Ivanov" DWC3 glue layer is hardware layer around Synopsys DesignWare USB3 core. Its purpose is to supply Synopsys IP with required clocks, voltages and interface it with the rest of the SoC. Signed-off-by: Ivan T. Ivanov Signed-off-by: Andy Gross --- drivers/usb/dwc3/Kconfig

[Patch v7 0/3] DWC3 USB support for Qualcomm platform

2014-06-30 Thread Andy Gross
These patches add basic support for USB3.0 controllers found on MSM platforms. USB3.0 core is based on Synopsys DesignWare SuperSpeed IP. This work was started by Ivan Ivanov and went through a number of iterations. I picked these patches up and did a little rework to get them working. Changes

Re: [PATCH] usb: host: ohci-tmio: Use managed interfaces for resource allocation

2014-06-30 Thread Alan Stern
On Mon, 30 Jun 2014, Julia Lawall wrote: > > > @@ -215,30 +213,31 @@ static int ohci_hcd_tmio_drv_probe(struct > > > platform_device *dev) > > > > > > spin_lock_init(&tmio->lock); > > > > > > - tmio->ccr = ioremap(config->start, resource_size(config)); > > > + tmio->ccr = devm_ioremap(&dev->dev

Re: [PATCH] usb-storage/SCSI: Add broken_fua blacklist flag

2014-06-30 Thread Greg KH
On Mon, Jun 30, 2014 at 11:16:51AM -0400, Alan Stern wrote: > On Mon, 30 Jun 2014, Alan Stern wrote: > > > Some buggy JMicron USB-ATA bridges don't know how to translate the FUA > > bit in READs or WRITEs. This patch adds an entry in unusual_devs.h > > and a blacklist flag to tell the sd driver n

Re: [PATCH 1/1] usb: dwc3: Kconfig: Fix dependency for Exynos DWC3

2014-06-30 Thread Felipe Balbi
On Mon, Jun 30, 2014 at 02:33:14PM +0530, Sachin Kamat wrote: > Make the config depend on ARCH_EXYNOS5 instead of ARCH_EXYNOS > as this IP is available only on Exynos5 platforms. > > Signed-off-by: Sachin Kamat > --- > drivers/usb/dwc3/Kconfig |2 +- > 1 file changed, 1 insertion(+), 1 delet

Re: [Patch v7 1/3] usb: dwc3: Add Qualcomm DWC3 glue layer driver

2014-06-30 Thread Felipe Balbi
Hi, On Mon, Jun 30, 2014 at 11:03:51AM -0500, Andy Gross wrote: > +static int dwc3_qcom_probe(struct platform_device *pdev) > +{ > + struct device_node *node = pdev->dev.of_node; > + struct dwc3_qcom *qdwc; > + int ret = 0; > + > + qdwc = devm_kzalloc(&pdev->dev, sizeof(*qdwc), GFP

Re: [Patch v7 2/3] usb: phy: Add Qualcomm DWC3 HS/SS PHY drivers

2014-06-30 Thread Felipe Balbi
Hi, first of all, since this is a brand new PHY driver, could you guys use the generic phy framework instead ? (drivers/phy) On Mon, Jun 30, 2014 at 11:03:52AM -0500, Andy Gross wrote: > diff --git a/drivers/usb/phy/phy-qcom-hsusb.c > b/drivers/usb/phy/phy-qcom-hsusb.c > new file mode 100644 > i

Re: [PATCH 1/3] phy: omap-usb2: Manage PHY 3.3V supply regulator

2014-06-30 Thread Felipe Balbi
Hi, On Mon, Jun 30, 2014 at 02:00:36PM +0300, Roger Quadros wrote: > On some SoCs e.g. J6 the 3.3V supply to the USB2 PHY can be > powered down when the PHY is not in use. Add regulator > management code to control this power line. > > Signed-off-by: Roger Quadros Reviewed-by: Felipe Balbi >

Re: [RFC PATCH 0/3] ehci_msm fixes for APQ8064 USB host support.

2014-06-30 Thread Felipe Balbi
Hi, On Wed, Jun 18, 2014 at 06:00:01PM +0100, Srinivas Kandagatla wrote: > While testing usb host on Qualcomm APQ8064, I encountered few issues. > These patches fixes those issues. > > Without these patches USB is not functional on AQ8064. > All the patches are tested on IFC6410. please resend w

Re: [RFC PATCH 3/3] usb: phy: msm: Do not do runtime pm if the phy is not idle

2014-06-30 Thread Felipe Balbi
On Mon, Jun 30, 2014 at 11:23:43AM +0100, Srinivas Kandagatla wrote: > Hi Felipe, > > On 27/06/14 16:54, Felipe Balbi wrote: > >Hi, > > > >On Wed, Jun 18, 2014 at 06:01:08PM +0100, Srinivas Kandagatla wrote: > >>Use case is when the phy is configured in host mode and a usb device is > >>attached t

Re: [RFC PATCH 0/3] ehci_msm fixes for APQ8064 USB host support.

2014-06-30 Thread Srinivas Kandagatla
Thanks Felipe, On 30/06/14 18:13, Felipe Balbi wrote: Hi, On Wed, Jun 18, 2014 at 06:00:01PM +0100, Srinivas Kandagatla wrote: While testing usb host on Qualcomm APQ8064, I encountered few issues. These patches fixes those issues. Without these patches USB is not functional on AQ8064. All th

Re: [PATCH v6 1/1] usb: host: xhci-plat: add support for the R-Car H2 and M2 xHCI controllers

2014-06-30 Thread Felipe Balbi
On Sun, Jun 29, 2014 at 11:33:52PM +0900, Magnus Damm wrote: > On Sat, Jun 28, 2014 at 12:40 AM, Felipe Balbi wrote: > > On Wed, Jun 18, 2014 at 02:15:42PM +0900, Magnus Damm wrote: > >> Hi Felipe, > >> > >> On Fri, Jun 13, 2014 at 11:25 PM, Felipe Balbi wrote: > >> > Hi, > >> > > >> > On Fri, Ju

Re: [PATCH v4 1/7] dma: cppi41: handle 0-length packets

2014-06-30 Thread Felipe Balbi
On Mon, May 26, 2014 at 02:52:34PM +0200, Daniel Mack wrote: > When a 0-length packet is received on the bus, desc->pd0 yields 1, > which confuses the driver's users. This information is clearly wrong > and not in accordance to the datasheet, but it's been observed on an > AM335x board, very reprod

[PATCH v1 0/3] ehci_msm fixes for APQ8064 USB host support.

2014-06-30 Thread Srinivas Kandagatla
While testing usb host on Qualcomm APQ8064, I encountered few issues. These patches fixes those issues. Without these patches USB is not functional on AQ8064. All the patches are tested on IFC6410. Resending the patches by removing the RFC in the subject. Can you please consider these patches fo

[PATCH v1 1/3] usb: Kconfig: make EHCI_MSM selectable for QCOM SOCs

2014-06-30 Thread Srinivas Kandagatla
This patch makes the msm ehci driver available to use on QCOM SOCs, which have the same IP. Signed-off-by: Srinivas Kandagatla --- drivers/usb/host/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig index 61b7817..03314

[PATCH v1 2/3] usb: phy: msm: Make phy_reset clk and reset line optional.

2014-06-30 Thread Srinivas Kandagatla
This patch makes the phy reset clk and reset line optional as this clk is not available on boards like IFC6410 with APQ8064. Signed-off-by: Srinivas Kandagatla --- drivers/usb/phy/phy-msm-usb.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/usb/phy/phy-msm

[PATCH v1 3/3] usb: phy: msm: Do not do runtime pm if the phy is not idle

2014-06-30 Thread Srinivas Kandagatla
Use case is when the phy is configured in host mode and a usb device is attached to board before bootup. On bootup, with the existing code and runtime pm enabled, the driver would decrement the pm usage count without checking the current state of the phy. This pm usage count decrement would trigger

Re: [PATCH v6 0/5] Add support for SW babble Control

2014-06-30 Thread Felipe Balbi
Hi, On Mon, May 26, 2014 at 02:50:07PM +0530, George Cherian wrote: > Series add support for SW babble control logic found in > new silicon versions of AM335x. Runtime differentiation of > silicon version is done by checking the BABBLE_CTL register. > For newer silicon the register default value

Re: [Patch v7 3/3] usb: dwc3: qcom: Add device tree binding

2014-06-30 Thread Kumar Gala
On Jun 30, 2014, at 11:03 AM, Andy Gross wrote: > From: "Ivan T. Ivanov" > > QCOM USB3.0 core wrapper consist of USB3.0 IP from Synopsys > (SNPS) and HS, SS PHY's control and configuration registers. > > It could operate in device mode (SS, HS, FS) and host > mode (SS, HS, FS, LS). > > Signe

Re: [PATCH v3 4/4] usb: gadget: pxa27x_udc: use devm_* helpers

2014-06-30 Thread Felipe Balbi
On Mon, Jun 30, 2014 at 12:31:19AM +0400, Sergei Shtylyov wrote: > Hello. > > On 06/29/2014 06:01 PM, Robert Jarzmik wrote: > > >Use devm_* helpers in the probe function to simplify the error path and > >the remove path. > > >Signed-off-by: Robert Jarzmik > >Cc: Sergei Shtylyov > > >--- > >Si

Re: [PATCH v1 1/3] usb: Kconfig: make EHCI_MSM selectable for QCOM SOCs

2014-06-30 Thread Felipe Balbi
On Mon, Jun 30, 2014 at 06:29:34PM +0100, Srinivas Kandagatla wrote: > This patch makes the msm ehci driver available to use on QCOM SOCs, > which have the same IP. > > Signed-off-by: Srinivas Kandagatla Alan, this is ok to me: Acked-by: Felipe Balbi > --- > drivers/usb/host/Kconfig | 2 +- >

Re: [PATCH v2 0/2] usb musb/cppi41: Address issues with isochronous audio endpoints

2014-06-30 Thread Felipe Balbi
Hi, On Fri, Jun 20, 2014 at 09:14:34AM +0530, George Cherian wrote: > On 6/20/2014 3:50 AM, Daniel Mack wrote: > >Hi, > > > >I've been debugging issues with musb in host mode and both full-speed > >and high-speed USB audio devices with cppi41 DMA mode enabled. > > > >The effect that was observed w

Re: [PATCH v1 3/3] usb: phy: msm: Do not do runtime pm if the phy is not idle

2014-06-30 Thread Felipe Balbi
On Mon, Jun 30, 2014 at 06:29:57PM +0100, Srinivas Kandagatla wrote: > Use case is when the phy is configured in host mode and a usb device is > attached to board before bootup. On bootup, with the existing code and > runtime pm enabled, the driver would decrement the pm usage count > without check

Re: [PATCH v1 3/3] usb: phy: msm: Do not do runtime pm if the phy is not idle

2014-06-30 Thread Srinivas Kandagatla
On 30/06/14 18:56, Felipe Balbi wrote: On Mon, Jun 30, 2014 at 06:29:57PM +0100, Srinivas Kandagatla wrote: Use case is when the phy is configured in host mode and a usb device is attached to board before bootup. On bootup, with the existing code and runtime pm enabled, the driver would decreme

Re: [PATCH v2][for 3.16 0/3] Gadget directory cleanup

2014-06-30 Thread Felipe Balbi
Hi, On Tue, Jun 17, 2014 at 02:19:14PM +0200, Andrzej Pietrasiewicz wrote: > This is a follow-up to this thread: > > http://www.spinics.net/lists/linux-usb/msg107611.html > > This refactoring has been accepted well, so I am sending it > once 3.16-rc1 is out in order to make it easy to apply it.

Re: [PATCH v1 1/3] usb: Kconfig: make EHCI_MSM selectable for QCOM SOCs

2014-06-30 Thread Alan Stern
On Mon, 30 Jun 2014, Felipe Balbi wrote: > On Mon, Jun 30, 2014 at 06:29:34PM +0100, Srinivas Kandagatla wrote: > > This patch makes the msm ehci driver available to use on QCOM SOCs, > > which have the same IP. > > > > Signed-off-by: Srinivas Kandagatla > > Alan, this is ok to me: > > Acked-b

Re: [Patch V3 0/2] usb: gadget: zero: Add support for interrupt EP

2014-06-30 Thread Felipe Balbi
Hi, On Mon, Jun 09, 2014 at 10:44:38AM +0530, Amit Virdi wrote: > Felipe, Alan, > > On 5/23/2014 12:01 PM, Amit VIRDI wrote: > >This patchset adds support for interrupt EP and the corresponding test cases > >to > >gadget zero. The code has been rebased and tested on Kernel v3.15-rc5 > > > >V2 ->

Re: [PATCH] usb: gadget: add claimed field in struct usb_ep

2014-06-30 Thread Felipe Balbi
On Tue, Jun 24, 2014 at 02:16:35PM +0200, Robert Baldyga wrote: > On 06/23/2014 08:27 PM, Felipe Balbi wrote: > > Hi, > > > > On Mon, Jun 23, 2014 at 08:07:43AM +0200, Robert Baldyga wrote: > >> On 06/19/2014 05:08 PM, Felipe Balbi wrote: > >>> On Mon, Jun 16, 2014 at 10:20:36AM +0200, Robert Bald

[GIT PULL] USB fixes for v3.16-rc4

2014-06-30 Thread Felipe Balbi
Hi Greg, Here's my second set of fixes. Note the revert of the patch Michal asked to revert. Please consider merging to your usb-linus branch. Let me know if you want any changes to this pull request. cheers The following changes since commit 5d881802c407d83c169c875dad88fe2bba066c33: usb: m

Re: [PATCH v2 05/12] usb: phy: add the Berlin USB PHY driver

2014-06-30 Thread Felipe Balbi
On Mon, Jun 30, 2014 at 04:52:11PM +0200, Antoine Ténart wrote: > Felipe, > > On Fri, Jun 27, 2014 at 06:04:33PM -0500, Felipe Balbi wrote: > > On Fri, Jun 27, 2014 at 06:05:57PM +0200, Antoine Ténart wrote: > > > Hi Felipe, > > > > > > On Fri, Jun 27, 2014 at 10:56:22AM -0500, Felipe Balbi wrote

Re: [RFC/PATCH] usb: musb: Prevent musb_am335x from being removed

2014-06-30 Thread Felipe Balbi
Hi, On Thu, May 08, 2014 at 02:27:40PM -0300, Ezequiel Garcia wrote: > At probe time, the musb_am335x driver registers its childs by > calling of_platform_populate(), which registers all childs in > the devicetree hierarchy recursively. > > On the other side, the driver's remove() function uses o

Re: [RFC/PATCH] usb: musb: Prevent musb_am335x from being removed

2014-06-30 Thread Ezequiel García
On 30 June 2014 15:44, Felipe Balbi wrote: > Hi, > > On Thu, May 08, 2014 at 02:27:40PM -0300, Ezequiel Garcia wrote: >> At probe time, the musb_am335x driver registers its childs by >> calling of_platform_populate(), which registers all childs in >> the devicetree hierarchy recursively. >> >> On

Re: [RFC/PATCH] usb: musb: Prevent musb_am335x from being removed

2014-06-30 Thread Felipe Balbi
On Mon, Jun 30, 2014 at 03:50:23PM -0300, Ezequiel García wrote: > On 30 June 2014 15:44, Felipe Balbi wrote: > > Hi, > > > > On Thu, May 08, 2014 at 02:27:40PM -0300, Ezequiel Garcia wrote: > >> At probe time, the musb_am335x driver registers its childs by > >> calling of_platform_populate(), whi

Re: [PATCH v2 0/2] usb musb/cppi41: Address issues with isochronous audio endpoints

2014-06-30 Thread Daniel Mack
On 06/30/2014 07:54 PM, Felipe Balbi wrote: > Hi, > > On Fri, Jun 20, 2014 at 09:14:34AM +0530, George Cherian wrote: >> On 6/20/2014 3:50 AM, Daniel Mack wrote: >>> Hi, >>> >>> I've been debugging issues with musb in host mode and both full-speed >>> and high-speed USB audio devices with cppi41 D

[PATCH] usb: gadget: s3c2410: Move to clk_prepare_enable/clk_disable_unprepare

2014-06-30 Thread Vasily Khoruzhick
Use clk_prepare_enable/clk_disable_unprepare to make the driver work properly with common clock framework. Signed-off-by: Vasily Khoruzhick --- drivers/usb/gadget/s3c2410_udc.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/usb/gadget/s3c2410_udc.c b/drivers/

Re: [PATCH v4 1/7] dma: cppi41: handle 0-length packets

2014-06-30 Thread Daniel Mack
Hi Felipe, Glad to see you find some time for this patch set :) On 06/30/2014 07:19 PM, Felipe Balbi wrote: > On Mon, May 26, 2014 at 02:52:34PM +0200, Daniel Mack wrote: >> When a 0-length packet is received on the bus, desc->pd0 yields 1, >> which confuses the driver's users. This information i

Re: [PATCH v4 1/7] dma: cppi41: handle 0-length packets

2014-06-30 Thread Felipe Balbi
Hi, On Mon, Jun 30, 2014 at 09:19:08PM +0200, Daniel Mack wrote: > Hi Felipe, > > Glad to see you find some time for this patch set :) yeah, have been quite busy lately. > On 06/30/2014 07:19 PM, Felipe Balbi wrote: > > On Mon, May 26, 2014 at 02:52:34PM +0200, Daniel Mack wrote: > >> When a 0-

Re: [PATCH v2 0/2] usb musb/cppi41: Address issues with isochronous audio endpoints

2014-06-30 Thread Felipe Balbi
On Mon, Jun 30, 2014 at 09:16:01PM +0200, Daniel Mack wrote: > On 06/30/2014 07:54 PM, Felipe Balbi wrote: > > Hi, > > > > On Fri, Jun 20, 2014 at 09:14:34AM +0530, George Cherian wrote: > >> On 6/20/2014 3:50 AM, Daniel Mack wrote: > >>> Hi, > >>> > >>> I've been debugging issues with musb in hos

Re: [PATCH v4 1/7] dma: cppi41: handle 0-length packets

2014-06-30 Thread Daniel Mack
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06/30/2014 09:26 PM, Felipe Balbi wrote: > On Mon, Jun 30, 2014 at 09:19:08PM +0200, Daniel Mack wrote: >> I also asked Vinod to pick this single patch for his tree, but >> there was no answer yet. > > cool. hopefully we can get a better v3.17. U

Re: [PATCH 00/10] net2280: Support for PLX USB338x and cleanout code

2014-06-30 Thread Ricardo Ribalda Delgado
Hello Felipe Any comment on this patchset? Shall I resend it rebased on v3.16-rc2? Regards On Tue, Jun 10, 2014 at 10:19 PM, Ricardo Ribalda Delgado wrote: > Ping... > > On Tue, May 20, 2014 at 6:30 PM, Ricardo Ribalda Delgado > wrote: >> The USB 3380 is a PCI Express Gen 2 to USB 3.0 SuperSp

Re: [PATCH v4 1/7] dma: cppi41: handle 0-length packets

2014-06-30 Thread Felipe Balbi
Hi, On Mon, Jun 30, 2014 at 09:29:10PM +0200, Daniel Mack wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 06/30/2014 09:26 PM, Felipe Balbi wrote: > > On Mon, Jun 30, 2014 at 09:19:08PM +0200, Daniel Mack wrote: > > >> I also asked Vinod to pick this single patch for his tree, bu

Re: [PATCH 00/10] net2280: Support for PLX USB338x and cleanout code

2014-06-30 Thread Felipe Balbi
On Mon, Jun 30, 2014 at 09:30:49PM +0200, Ricardo Ribalda Delgado wrote: > Hello Felipe > > Any comment on this patchset? Shall I resend it rebased on v3.16-rc2? they are all in my 'testing/next' branch. Should be available on 'next' next week if nothing wrong is found. cheers -- balbi signa

Re: [PATCH v4 1/7] dma: cppi41: handle 0-length packets

2014-06-30 Thread Daniel Mack
On 06/30/2014 09:31 PM, Felipe Balbi wrote: > On Mon, Jun 30, 2014 at 09:29:10PM +0200, Daniel Mack wrote: >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA1 >> >> On 06/30/2014 09:26 PM, Felipe Balbi wrote: >>> On Mon, Jun 30, 2014 at 09:19:08PM +0200, Daniel Mack wrote: >> I also asked Vino

Re: [PATCH v3 4/4] usb: gadget: pxa27x_udc: use devm_* helpers

2014-06-30 Thread Robert Jarzmik
Felipe Balbi writes: >> >@@ -28,12 +28,11 @@ >> > #include >> > >> > #include >> >-#include >> > >> > #include >> > #include >> > #include >> >-#include >> >+#include >> > >> > #include "pxa27x_udc.h" >> > >> >>These seem like unrelated changes that should be in a separate patc

Re: [PATCH 2/2 v2] HID: leds: Use attribute-groups in MSI GT683R driver

2014-06-30 Thread Bryan Wu
On Mon, Jun 30, 2014 at 4:33 AM, Jiri Kosina wrote: > On Mon, 30 Jun 2014, Johan Hovold wrote: > >> > I think the better place is HID/input tree, since this patch depends >> > on the initial one which is not in my tree. >> > I'm going to merge Johan's whole patchset and this patch probably >> > de

RE: [PATCH v3] USB: ehci-pci: USB host controller support for Intel Quark X1000

2014-06-30 Thread Chen, Alvin
> > /* > > -*/ > > +#define PCI_DEVICE_ID_INTEL_QUARK_X1000_SOC0x0939 > > +static inline bool is_intel_quark_x1000(struct pci_dev *pdev) { > > + return pdev->vendor == PCI_VENDOR_ID_INTEL && > > + pd

RE: [PATCH v3] USB: ehci-pci: USB host controller support for Intel Quark X1000

2014-06-30 Thread Chen, Alvin
> > > > /* > > -*/ > > +#define PCI_DEVICE_ID_INTEL_QUARK_X1000_SOC0x0939 > > +static inline bool is_intel_quark_x1000(struct pci_dev *pdev) { > > + return pdev->vendor == PCI_VENDOR_ID_INTEL && > > +

Re: [PATCH v2 07/12] usb: chipidea: add a generic driver

2014-06-30 Thread Peter Chen
On Mon, Jun 30, 2014 at 03:33:13PM +0200, Antoine Ténart wrote: > Peter, > > On Fri, Jun 27, 2014 at 11:25:07AM +0800, Peter Chen wrote: > > On Tue, Jun 24, 2014 at 12:35:16PM +0200, Antoine Ténart wrote: > > > > > > ifneq ($(CONFIG_OF),) > > > obj-$(CONFIG_USB_CHIPIDEA) += usbmisc_imx.o

Re: [PATCH 1/1] usb: dwc3: Kconfig: Fix dependency for Exynos DWC3

2014-06-30 Thread Sachin Kamat
On Mon, Jun 30, 2014 at 10:19 PM, Felipe Balbi wrote: > On Mon, Jun 30, 2014 at 02:33:14PM +0530, Sachin Kamat wrote: >> Make the config depend on ARCH_EXYNOS5 instead of ARCH_EXYNOS >> as this IP is available only on Exynos5 platforms. >> >> Signed-off-by: Sachin Kamat >> --- >> drivers/usb/dwc

RE: [PATCH 0/6] usb: gadget: Delete __init marker for probe

2014-06-30 Thread Peter Chen
> On Sun, May 18, 2014 at 03:19:01PM +0800, Peter Chen wrote: > > The probe function may be probed deferal and called after .init > > section has freed. > > > > Peter Chen (6): > > usb: gadget: atmel_usba_udc: delete __init marker for probe > > usb: gadget: fsl_udc_core: delete __init marker

RE: [PATCH 0/5] usb: gadget: cleanup gadget driver .unbind usage at udc driver

2014-06-30 Thread Peter Chen
> -Original Message- > From: Peter Chen [mailto:peter.c...@freescale.com] > Sent: Saturday, June 21, 2014 9:41 PM > To: ba...@ti.com > Cc: linux-usb@vger.kernel.org > Subject: Re: [PATCH 0/5] usb: gadget: cleanup gadget driver .unbind usage > at udc driver > > On Wed, May 21, 2014 at 09:

Re: [GIT PULL] USB fixes for v3.16-rc4

2014-06-30 Thread Greg KH
On Mon, Jun 30, 2014 at 01:40:35PM -0500, Felipe Balbi wrote: > Hi Greg, > > Here's my second set of fixes. Note the revert of the patch Michal > asked to revert. > > Please consider merging to your usb-linus branch. Let me know if you > want any changes to this pull request. > > cheers > > >

Re: [Patch v7 3/3] usb: dwc3: qcom: Add device tree binding

2014-06-30 Thread Rob Herring
On Mon, Jun 30, 2014 at 11:03 AM, Andy Gross wrote: > From: "Ivan T. Ivanov" Please copy the right lists and maintainers. > > QCOM USB3.0 core wrapper consist of USB3.0 IP from Synopsys > (SNPS) and HS, SS PHY's control and configuration registers. > > It could operate in device mode (SS, HS, F

Re: [PATCH v4 1/7] dma: cppi41: handle 0-length packets

2014-06-30 Thread Vinod Koul
On Mon, Jun 30, 2014 at 09:40:06PM +0200, Daniel Mack wrote: > On 06/30/2014 09:31 PM, Felipe Balbi wrote: > > On Mon, Jun 30, 2014 at 09:29:10PM +0200, Daniel Mack wrote: > >> -BEGIN PGP SIGNED MESSAGE- > >> Hash: SHA1 > >> > >> On 06/30/2014 09:26 PM, Felipe Balbi wrote: > >>> On Mon, Jun

Re: [PATCH] usb: gadget: add claimed field in struct usb_ep

2014-06-30 Thread Robert Baldyga
On 06/30/2014 08:33 PM, Felipe Balbi wrote: > On Tue, Jun 24, 2014 at 02:16:35PM +0200, Robert Baldyga wrote: >> On 06/23/2014 08:27 PM, Felipe Balbi wrote: >>> Hi, >>> >>> On Mon, Jun 23, 2014 at 08:07:43AM +0200, Robert Baldyga wrote: On 06/19/2014 05:08 PM, Felipe Balbi wrote: > On Mon,

Re: XHCI, "brain-dead scanner", and microframe rounding

2014-06-30 Thread Mike Mammarella
Hi Can you add xhci debugging by enabling CONFIG_DYNAMIC_DEBUG, and run `echo -n 'module xhci_hcd =p' > /sys/kernel/debug/dynamic_debug/control` as root, and send me the output of dmesg. Without debugging info it's hard to guess what's going on. The microframe rounding look a bit suspicious: [1

Re: [PATCH v4 1/7] dma: cppi41: handle 0-length packets

2014-06-30 Thread Vinod Koul
On Mon, May 26, 2014 at 02:52:34PM +0200, Daniel Mack wrote: > When a 0-length packet is received on the bus, desc->pd0 yields 1, > which confuses the driver's users. This information is clearly wrong > and not in accordance to the datasheet, but it's been observed on an > AM335x board, very reprod

  1   2   >