[PATCH v2] usb: phy: msm: reset controller is mandatory now

2014-05-13 Thread Arnd Bergmann
Commit a27345434134 "usb: phy: msm: Use reset framework for LINK and PHY resets" introduced a mandatory call to reset_control_get into the msm usb phy driver, which means we have to add a Kconfig dependency on the API to avoid this build error: phy/phy-msm-usb.c: In function 'msm_otg_read_dt': phy

Re: [PATCH 4/8] usb: phy: fix isp1301-omap dependency on tps65010

2014-05-13 Thread Arnd Bergmann
On Tuesday 13 May 2014 10:26:31 Felipe Balbi wrote: > On Thu, May 08, 2014 at 03:52:17PM +0200, Arnd Bergmann wrote: > > The isp1301-omap driver cannot be built-in if the tps65010 driver > > is a module, otherwise we get a link error from the reference to > > the tps65010_set_vbus_draw function. >

Re: [PATCH 4/8] usb: phy: fix isp1301-omap dependency on tps65010

2014-05-13 Thread Felipe Balbi
Hi, On Tue, May 13, 2014 at 09:48:27PM +0200, Arnd Bergmann wrote: > On Tuesday 13 May 2014 10:26:31 Felipe Balbi wrote: > > On Thu, May 08, 2014 at 03:52:17PM +0200, Arnd Bergmann wrote: > > > The isp1301-omap driver cannot be built-in if the tps65010 driver > > > is a module, otherwise we get a

Re: [PATCH 6/8] usb: xhci: avoid warning for !PM_SLEEP

2014-05-13 Thread Felipe Balbi
On Tue, May 13, 2014 at 09:39:37PM +0200, Arnd Bergmann wrote: > On Tuesday 13 May 2014 10:28:29 Felipe Balbi wrote: > > > diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c > > > index 151901c..3473296 100644 > > > --- a/drivers/usb/host/xhci-plat.c > > > +++ b/drivers/usb/ho

RE: [RFC 0/3] Gadget directory cleanup

2014-05-13 Thread Paul Zimmerman
> From: linux-usb-ow...@vger.kernel.org > [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Felipe Balbi > Sent: Tuesday, May 13, 2014 8:08 AM > > On Tue, May 13, 2014 at 10:45:15AM +0200, Andrzej Pietrasiewicz wrote: > > Dear All - in general, > > @Felipe - in particular, > > > > I would lik

[PATCH] separate usb_address0 mutexes for each host

2014-05-13 Thread Todd E Brandt
This patch creates a separate instance of the usb_address0 mutex for each host controller, and attaches it to the host controller device struct. This allows devices on separate hosts to be enumerated in parallel; saving time. In the current code, there is a single, global instance of the usb_addre

re: usb: phy: msm: Migrate to Managed Device Resource allocation

2014-05-13 Thread Dan Carpenter
Hello Ivan T. Ivanov, The patch 6b99c68ec1f9: "usb: phy: msm: Migrate to Managed Device Resource allocation" from Apr 28, 2014, leads to the following static checker warning: drivers/usb/phy/phy-msm-usb.c:1590 msm_otg_probe() warn: 'motg->regs' isn't an ERR_PTR drivers/usb/phy/ph

Re: ehci-hcd.c causes: irq : nobody cared

2014-05-13 Thread Dr. Werner Fink
On Tue, May 13, 2014 at 06:10:46PM +0200, Dr. Werner Fink wrote: > On Tue, May 13, 2014 at 11:59:38AM -0400, Alan Stern wrote: > > > > What about something like this instead? > > > > masked_status = status & (INTR_MASK | STS_FLR); > > > > /* Shared IRQ? */ > > if (!masked_status ||

Re: [PATCH] [resend] net: get rid of SET_ETHTOOL_OPS

2014-05-13 Thread David Miller
From: Wilfried Klaebe Date: Sun, 11 May 2014 00:12:32 + > net: get rid of SET_ETHTOOL_OPS > > Dave Miller mentioned he'd like to see SET_ETHTOOL_OPS gone. > This does that. > > Mostly done via coccinelle script: > @@ > struct ethtool_ops *ops; > struct net_device *dev; > @@ > - SET_ET

Re: [PATCH net-next v2 0/4] cdc_mbim: cleanups and new features

2014-05-13 Thread David Miller
From: Bjørn Mork Date: Sun, 11 May 2014 10:47:11 +0200 > This series depends on commit 6b5eeb7f874b ("net: cdc_mbim: handle > unaccelerated VLAN tagged frames"), which is currently in "net" but > not yet in "net-next". Series applied, thanks a lot. -- To unsubscribe from this list: send the line

Re: [PATCH 1/1] Add support for GPIOs for SMSC LAN95xx chips.

2014-05-13 Thread David Miller
From: Evgeny Boger Date: Sun, 11 May 2014 17:34:14 +0400 > There might be 11 GPIOs in total. Last three GPIOs (offsets 8-11, 0-based) > are shared > with FDX, LNKA, SPD LEDs respectively. The LEDs are driven by chip by default > at startup time. Once the corresponding GPIO is requested, the chi

Re: [PATCH] separate usb_address0 mutexes for each host

2014-05-13 Thread Greg KH
On Tue, May 13, 2014 at 12:58:23PM -0700, Todd E Brandt wrote: > This patch creates a separate instance of the usb_address0 mutex for each host > controller, and attaches it to the host controller device struct. This allows > devices on separate hosts to be enumerated in parallel; saving time. > >

disable VBUS?

2014-05-13 Thread Grant
Can I disable VBUS while keeping the rest of USB functional for a device that does not require bus power? - Grant -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-i

Re: disable VBUS?

2014-05-13 Thread Felipe Balbi
Hi, On Tue, May 13, 2014 at 05:34:31PM -0700, Grant wrote: > Can I disable VBUS while keeping the rest of USB functional for a > device that does not require bus power? unfortunately not, your device would see a disconnection. The reason is that even though you don't really put any load on the bu

Re: disable VBUS?

2014-05-13 Thread Rajaram R
On Wed, May 14, 2014 at 6:04 AM, Grant wrote: > Can I disable VBUS while keeping the rest of USB functional for a > device that does not require bus power? Can you please elaborate the question of why VBus should go off ? Is this question in the context of any new USB specification ? > > - Gran

Re: [PATCH] USB: Add LVS Test device driver

2014-05-13 Thread Pratyush Anand
Hi Alan, PS: For all other comments, will do as you suggested. On Tue, May 13, 2014 at 10:28:11PM +0800, Alan Stern wrote: > On Tue, 13 May 2014, Pratyush Anand wrote: > > > > The biggest bug may not be an obvious one. Suppose the lvstest driver > > > has been built into the kernel. When the ke

Re: [PATCH v3 0/5] Add support for SW babble Control

2014-05-13 Thread George Cherian
On 5/14/2014 12:07 AM, Bin Liu wrote: Hi, On Tue, May 13, 2014 at 8:24 AM, George Cherian wrote: Hi Daniel, On 5/13/2014 6:44 PM, Daniel Mack wrote: Hi George, On 05/13/2014 02:57 PM, George Cherian wrote: I never enabled the MUSB_BABBLE_SW_SESSION_CTRL in the MUSB_BABBLE_CTL reg. can you

Re: [PATCH 1/5] usb: dwc3: dwc3-omap: Add dwc3_omap_map_offset function

2014-05-13 Thread George Cherian
On 5/13/2014 9:32 PM, Felipe Balbi wrote: Hi, On Thu, May 08, 2014 at 03:03:03PM +0530, George Cherian wrote: Calculate the wrapper register offsets in a seperate function. Improve code readability, decrease the dwc3_probe() size. Signed-off-by: George Cherian --- drivers/usb/dwc3/dwc3-omap

Re: [PATCH RESEND v4 3/8] phy: sunxi: Rework phy initialization

2014-05-13 Thread Kishon Vijay Abraham I
Hi, On Tuesday 13 May 2014 09:14 PM, Maxime Ripard wrote: > Move the phy initialization and variables declaration to the loop itself, > since > it is where it really belongs. Also remove all the temporary variables, we can > use the structure members directly. > > Signed-off-by: Maxime Ripard >

Re: [PATCH 5/5] usb: dwc3: dwc3-omap: Disable/Enable core interrupts in Suspend/Resume

2014-05-13 Thread George Cherian
On 5/13/2014 9:20 PM, Felipe Balbi wrote: Hi, On Thu, May 08, 2014 at 03:03:07PM +0530, George Cherian wrote: Enabling the core interrupts in complete is too late for XHCI, and stops xhci from proper operation. So remove prepare and complete and disable/enable isn't this a bug in xhci ? I mean

RE: [PATCH 1/1] usb: core: Kconfig: refine the description for CONFIG_USB_OTG

2014-05-13 Thread Peter Chen
> > On Tue, May 13, 2014 at 01:11:44PM +0200, Greg KH wrote: > > On Tue, May 13, 2014 at 10:19:27AM +0800, Peter Chen wrote: > > > the user should only select it when the board supports HNP and SRP, > > > it should NOT be selected if the board only supports dual-role > > > switch through ID pin.

Re: [PATCH 8/8] usb: dwc3: gadget: always enable IOC on bulk/interrupt transfers

2014-05-13 Thread Pratyush Anand
Hi Balbi, On Tue, May 13, 2014 at 11:17:02PM +0800, Felipe Balbi wrote: > Hi, > > On Fri, May 09, 2014 at 11:25:46AM +0530, Pratyush Anand wrote: > > On Tue, May 06, 2014 at 02:22:12PM +0800, Amit VIRDI wrote: > > > On 5/6/2014 12:56 AM, Felipe Balbi wrote: > > > >> I understand that enabling Xfe

Re: [PATCH V3 4/5] dwc3: host: Enable USB3 LPM capability

2014-05-13 Thread Pratyush Anand
Hi Paul/Felip, On Wed, May 07, 2014 at 11:15:33AM +0530, Pratyush Anand wrote: > Hi Paul, > > On Tue, May 06, 2014 at 11:54:19AM +0800, Pratyush ANAND wrote: > > All dwc3 based xhci host controller supports USB3.0 LPM functionality. > > Therefore enable it in platform data for all dwc3 based xhci

Re: [PATCH] USB: Add LVS Test device driver

2014-05-13 Thread Bjørn Mork
Pratyush Anand writes: > If that is not true, may be I can do what Bjørn Mork is suggesting. > But that would require change in drivers/base/bus.c:driver_(un)bind. > > -- Add a new field manual_binding in struct device_driver. > -- set this flag in drivers_bind before calling driver_probe_device.

Re: [PATCH RESEND v4 3/8] phy: sunxi: Rework phy initialization

2014-05-13 Thread Maxime Ripard
On Wed, May 14, 2014 at 11:18:51AM +0530, Kishon Vijay Abraham I wrote: > Hi, > > On Tuesday 13 May 2014 09:14 PM, Maxime Ripard wrote: > > Move the phy initialization and variables declaration to the loop itself, > > since > > it is where it really belongs. Also remove all the temporary variable

Re: [PATCH] usb: phy: msm: make it depend on RESET_CONTROLLER

2014-05-13 Thread Ivan T. Ivanov
On Tue, 2014-05-13 at 12:07 -0400, Alan Stern wrote: > On Tue, 13 May 2014, Bird, Tim wrote: > > > I don't think so. I haven't tested, but I believe the driver now relies > > on operational (not stub) resets. I think this comment is a bit off. > > I think it would be better to just say that the

<    1   2