Re: [PATCH v4 2/2] usb: dwc3: adapt dwc3 core to use Generic PHY Framework

2014-01-22 Thread Roger Quadros
On 01/22/2014 08:04 AM, Vivek Gautam wrote: > Hi, > > > On Tue, Jan 21, 2014 at 7:30 PM, Roger Quadros wrote: >> Hi Kishon, >> >> On 01/21/2014 12:11 PM, Kishon Vijay Abraham I wrote: >>> Adapted dwc3 core to use the Generic PHY Framework. So for init, exit, >>> power_on and power_off the follow

RE: [PATCH 3.12 033/118] usb: xhci: Link TRB must not occur within a USB payload burst [NEW HARDWARE]

2014-01-22 Thread David Laight
From: walt > On 01/21/2014 01:51 AM, David Laight wrote: > > From: Sarah Sharp > >> On Mon, Jan 20, 2014 at 11:21:14AM +, David Laight wrote: > > ... > >>> A guess... > >>> > >>> In queue_bulk_sg_tx() try calling xhci_v1_0_td_remainder() instead > >>> of xhci_td_remainder(). > >> > David, I tri

[PATCH v3 4/5] usb: gadget: f_fs: add poll for endpoint 0

2014-01-22 Thread Robert Baldyga
This patch adds poll function for file representing ep0. Ability of read from or write to ep0 file is related with actual state of ffs: - When desctiptors or strings are not written yet, POLLOUT flag is set. - If there is any event to read, POLLIN flag is set. - If setup request was read, POLLIN a

[PATCH v3 2/5] usb: gadget: functionfs: replace FFS_SETUP_STATUS with an inline function

2014-01-22 Thread Robert Baldyga
From: Michal Nazarewicz The FFS_SETUP_STATUS macro could be trivialy replaced with an static inline function but more importantly its name was tad confusing. The name suggested it was a simple accessor macro but it actually did change the state of the ffs_data structure perfomring a FFS_SETUP_CAN

[PATCH v3 3/5] usb: gadget: f_fs: fix setup request handling

2014-01-22 Thread Robert Baldyga
This patch fixes __ffs_ep0_queue_wait() function, which now returns number of bytes transferred in USB request or error code in case of failure. This is needed by ffs_ep0_read() function, when read data is copied to userspace. It also cleans up code by removing usused variable ep0req_status. Sign

[PATCH v3 0/5] usb: gadget: f_fs: add asynchronous I/O support

2014-01-22 Thread Robert Baldyga
Hello, This is third version of patches containing improvements for FunctionFS which allows to use it with asynchronous I/O interface. It also adds poll function for ep0, to make it usable without creating additional thread, needed by blocking I/O. >From last version I have fixed few style proble

[PATCH v3 1/5] usb: gadget: functionfs: fix typo in the enum variable

2014-01-22 Thread Robert Baldyga
From: Michal Nazarewicz Since “cancelled” is spelled with two “l”s, rename FFS_SETUP_CANCELED to FFS_SETUP_CANCELLED. Signed-off-by: Michal Nazarewicz Signed-off-by: Robert Baldyga --- drivers/usb/gadget/f_fs.c | 16 drivers/usb/gadget/u_fs.h | 12 ++-- 2 files ch

[PATCH v3 5/5] usb: gadget: f_fs: add aio support

2014-01-22 Thread Robert Baldyga
This patch adds asynchronous I/O support for FunctionFS endpoint files. It adds ffs_epfile_aio_write() and ffs_epfile_aio_read() functions responsible for preparing AIO operations. It also modifies ffs_epfile_io() function, adding aio handling code. Instead of extending list of parameters of this

RE: [PATCH v2] xhci: Don't trace all short/incomplete receives

2014-01-22 Thread David Laight
From: Sarah Sharp > On Tue, Jan 21, 2014 at 12:02:56PM +, David Laight wrote: > > Don't trace short receives if URB_SHORT_NOT_OK is set. > > Short receives are normal for USB ethernet devices. > > > > Don't trace unexpected incomplete receives if XHCI_TRUST_TX_LENGTH is set. > > Ratelimit the

Regression on next-20140116 [Was: [PATCH 3/3 v4] usb: chipidea: hw_phymode_configure moved before ci_usb_phy_init]

2014-01-22 Thread Uwe Kleine-König
Hello, On Tue, Dec 03, 2013 at 04:01:50PM +0800, Chris Ruehl wrote: > usb: chipidea: hw_phymode_configure moved before ci_usb_phy_init > hw_phymode_configure configures the PORTSC registers and allow the > following phy_inits to operate on the right parameters. This fix a problem > where the UPLI

Re: [PATCH v4 2/2] usb: dwc3: adapt dwc3 core to use Generic PHY Framework

2014-01-22 Thread Kishon Vijay Abraham I
On Wednesday 22 January 2014 01:29 PM, Roger Quadros wrote: > On 01/22/2014 08:04 AM, Vivek Gautam wrote: >> Hi, >> >> >> On Tue, Jan 21, 2014 at 7:30 PM, Roger Quadros wrote: >>> Hi Kishon, >>> >>> On 01/21/2014 12:11 PM, Kishon Vijay Abraham I wrote: Adapted dwc3 core to use the Generic PHY

Re: FunctionFS: Provide device and configdescriptor from user mode application?

2014-01-22 Thread Marco Zamponi
Thanks for your reply! I am passing kernel arguments now to set the desired info. Another question though: I noticed, when I run the USB Chapter 9 tests on my host, there is not one "FUNCTIONFS_SETUP" event sent. I am trying to move from gadgetfs to functionfs with my device, and with gadgetfs my

RE: 174c:5106 1 TB External USB 3.0 Drive Fails to Automount through USB 3.0 dock with XHCI Enabled

2014-01-22 Thread David Laight
From: Jay S > [2.] I have a 1 TB Western Digital drive in a USB 3.0 HDD dock that will > not automount while XHCI is enabled in the BIOS. If I disable XHCI in > the BIOS, it automounts normally. I've tried an external USB 3.0 > enclosure and two different brands of USB 3.0 HDD docks (that use > dif

RE: [PATCH] usb: host: xhci: fix HALTED endpoint handling

2014-01-22 Thread David Laight
From: Sarah Sharp ... > If it really matters that a driver be able to get an immediate -EPIPE > response back from a device when the endpoint is halted, I can rip the > code out of xhci_endpoint_reset() and make the driver manually clean up > the ring at the time of the stall, like it does for cont

[PATCH v5 0/4] libusbg: clean up and error handling

2014-01-22 Thread Stanislaw Wadas
In reference to the message sent by Andrzej Pietrasiewicz (about libusbg (formerly libgadget)) I would like to propose some changes to libusbg. Creating directories is now performed after successful memory allocation and gadget function creation. Hard coded values are replaced with constants. Erro

[PATCH v5 2/4] libusbg: Add fputs()/fgets() error handling

2014-01-22 Thread Stanislaw Wadas
Add error handling to fputs()/fgets() functions. Signed-off-by: Stanislaw Wadas --- src/usbg.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/src/usbg.c b/src/usbg.c index cb7f172..2fc618f 100644 --- a/src/usbg.c +++ b/src/usbg.c @@ -93,6 +93,11 @@ static char

[PATCH v5 1/4] libusbg: Replace array lengths with defines

2014-01-22 Thread Stanislaw Wadas
Replace hard coded value of 256 by two constant defines, MAX_LENGTH and MAX_PATH_LENGTH Signed-off-by: Stanislaw Wadas --- include/usbg/usbg.h | 27 +++ src/usbg.c | 46 +++--- 2 files changed, 38 insertions(+), 35 dele

[PATCH v5 3/4] libusbg: Move mkdir functions

2014-01-22 Thread Stanislaw Wadas
Call mkdir() function after successful memory allocation and gadget function creation. Signed-off-by: Stanislaw Wadas --- src/usbg.c | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/src/usbg.c b/src/usbg.c index 2fc618f..37741f5 100644

[PATCH v5 4/4] libusbg: Add inline to gadget_write_string().

2014-01-22 Thread Stanislaw Wadas
Add inline to gadget_write_string(). Signed-off-by: Stanislaw Wadas --- src/usbg.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/usbg.c b/src/usbg.c index 37741f5..c961bea 100644 --- a/src/usbg.c +++ b/src/usbg.c @@ -162,7 +162,7 @@ static void usbg_write_int(char *p

Re: [PATCH v5 1/4] libusbg: Replace array lengths with defines

2014-01-22 Thread Matt Porter
On Wed, Jan 22, 2014 at 02:56:20PM +0100, Stanislaw Wadas wrote: > Replace hard coded value of 256 by two constant > defines, MAX_LENGTH and MAX_PATH_LENGTH > > Signed-off-by: Stanislaw Wadas > --- > include/usbg/usbg.h | 27 +++ > src/usbg.c | 46 +++

RE: [PATCH v5 1/4] libusbg: Replace array lengths with defines

2014-01-22 Thread David Laight
From: Stanislaw Wadas > Replace hard coded value of 256 by two constant > defines, MAX_LENGTH and MAX_PATH_LENGTH Neither of those names is really very good. They probably ought to be prefixed with USBG_ Mind you the rest of the file isn't much better. There are also some 'char name[40];' And co

Re: [RFT] xhci: Fix resume issues on Renesas chips in Samsung laptops

2014-01-22 Thread Prarit Bhargava
> Don Zickus writes: > > Some co-workers of mine bought Samsung laptops that had mostly usb3 ports. > Those ports did not resume correctly (the driver would timeout communicating > and fail). This led to frustration as suspend/resume is a common use for > laptops. > > Poking around, I applied

RE: [PATCH v5 1/4] libusbg: Replace array lengths with defines

2014-01-22 Thread Krzysztof Opasiak
> -Original Message- > From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb- > ow...@vger.kernel.org] On Behalf Of David Laight > Sent: Wednesday, January 22, 2014 3:16 PM > To: Stanislaw Wadas; matt.por...@linaro.org > Cc: linux-usb@vger.kernel.org; Piotr Bereza; > myungjoo@samsung.

Re: [PATCH v3 4/5] usb: gadget: f_fs: add poll for endpoint 0

2014-01-22 Thread Michal Nazarewicz
On Wed, Jan 22 2014, Robert Baldyga wrote: > This patch adds poll function for file representing ep0. > > Ability of read from or write to ep0 file is related with actual state of ffs: > - When desctiptors or strings are not written yet, POLLOUT flag is set. > - If there is any event to read, POLL

Re: [PATCH v3 5/5] usb: gadget: f_fs: add aio support

2014-01-22 Thread Michal Nazarewicz
On Wed, Jan 22 2014, Robert Baldyga wrote: > This patch adds asynchronous I/O support for FunctionFS endpoint files. > It adds ffs_epfile_aio_write() and ffs_epfile_aio_read() functions responsible > for preparing AIO operations. > > It also modifies ffs_epfile_io() function, adding aio handling co

Re: [PATCH v3 03/10] usb: find internal hub tier mismatch via acpi

2014-01-22 Thread Alan Stern
On Tue, 21 Jan 2014, Dan Williams wrote: > >> I think we agree that khubd needs to not look at the portstatus while > >> the port is down. pm runtime synchronization takes care of that and > >> prevents khubd from starting while the port is inactive. With that in > >> place we can now make reque

RE: [PATCH v2] xhci: Allocate the td array and urb_priv together.

2014-01-22 Thread David Laight
From: Sarah> Sharp > On Wed, Dec 18, 2013 at 11:24:47AM -, David Laight wrote: > > This saves a kzalloc() call on every transfer and some memory > > indirections. > > ... > Hi David, > > The patch looks good in general and applies fine. However, in testing > this with a USB mass storage devic

Re: [PATCH v5 1/4] libusbg: Replace array lengths with defines

2014-01-22 Thread Matt Porter
On Wed, Jan 22, 2014 at 03:29:10PM +0100, Krzysztof Opasiak wrote: > > -Original Message- > > From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb- > > ow...@vger.kernel.org] On Behalf Of David Laight > > Sent: Wednesday, January 22, 2014 3:16 PM > > To: Stanislaw Wadas; matt.por...@lina

Re: [PATCH v3 03/10] usb: find internal hub tier mismatch via acpi

2014-01-22 Thread Dan Williams
On Wed, Jan 22, 2014 at 6:48 AM, Alan Stern wrote: > On Tue, 21 Jan 2014, Dan Williams wrote: > >> >> I think we agree that khubd needs to not look at the portstatus while >> >> the port is down. pm runtime synchronization takes care of that and >> >> prevents khubd from starting while the port i

[PATCH v6 3/4] libusbg: Move mkdir functions

2014-01-22 Thread Stanislaw Wadas
Call mkdir() function after successful memory allocation and gadget function creation. Signed-off-by: Stanislaw Wadas --- src/usbg.c | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/src/usbg.c b/src/usbg.c index c673be9..babe067 100644

[PATCH v6 2/4] libusbg: Add fputs()/fgets() error handling

2014-01-22 Thread Stanislaw Wadas
Add error handling to fputs()/fgets() functions. Signed-off-by: Stanislaw Wadas --- src/usbg.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/src/usbg.c b/src/usbg.c index 198b504..c673be9 100644 --- a/src/usbg.c +++ b/src/usbg.c @@ -93,6 +93,11 @@ static char

[PATCH v6 1/4] libusbg: Replace array lengths with defines

2014-01-22 Thread Stanislaw Wadas
Replace hard coded value of 256 by two constant defines, USBG_MAX_STR_LENGTH and USBG_MAX_PATH_LENGTH Define USBG_MAX_NAME_LENGTH for name[] array Signed-off-by: Stanislaw Wadas --- include/usbg/usbg.h | 36 src/usbg.c | 46 ++

[PATCH v6 4/4] libusbg: Add inline to gadget_write_string().

2014-01-22 Thread Stanislaw Wadas
Add inline to gadget_write_string(). Signed-off-by: Stanislaw Wadas --- src/usbg.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/usbg.c b/src/usbg.c index babe067..e648f0f 100644 --- a/src/usbg.c +++ b/src/usbg.c @@ -162,7 +162,7 @@ static void usbg_write_int(char *p

[PATCH v6 0/4] libusbg: clean up and error handling

2014-01-22 Thread Stanislaw Wadas
In reference to the message sent by Andrzej Pietrasiewicz (about libusbg (formerly libgadget)) I would like to propose some changes to libusbg. Creating directories is now performed after successful memory allocation and gadget function creation. Hard coded values are replaced with constants. Erro

[PATCH v4 04/12] libusbg: Move directory creation before writing attributes.

2014-01-22 Thread Krzysztof Opasiak
Change order of gadget creation and attribute writting to fix No such file or directory error while creating new gadget. Change-Id: Ibf36f7350b4e9fe38c31edb1fffbaebaf4697530 Signed-off-by: Krzysztof Opasiak --- src/usbg.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff

[PATCH v4 03/12] libusbg: Fix gadget-acm-ecm example to cleanup at exit.

2014-01-22 Thread Krzysztof Opasiak
Make use of previously unused variable ret to cleanup after successful gadget creation. Signed-off-by: Krzysztof Opasiak --- examples/gadget-acm-ecm.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/examples/gadget-acm-ecm.c b/examples/gadget-acm-ecm.

[PATCH v4 00/12] libusbg: Cleanup, bug fix and refactoring.

2014-01-22 Thread Krzysztof Opasiak
Dear Matt, Please excuse me my passivity after discussuon about libusbg some time ago. I had to close some other issues before taking up this one. Recently I looked into code of libusbg, build it and found some errors which are fixed in attached patches. Moreover I have done some clean up and min

[PATCH v4 05/12] libusbg: Fix memory leak when unable to create directory.

2014-01-22 Thread Krzysztof Opasiak
Free the memory allocated for gadget/config/function structure when faild to create suitable directory. Signed-off-by: Krzysztof Opasiak --- src/usbg.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/src/usbg.c b/src/usbg.c index e222392..a7f8780 100644 --- a/src/usbg.c +++ b/src/usbg.

[PATCH v4 01/12] libusbg: Surround header with include guards.

2014-01-22 Thread Krzysztof Opasiak
Surround header with include guards to protect against multiple inclusion. Change-Id: I6c6c78d7d3e17844592d3c22ea04f1205adcff63 Signed-off-by: Krzysztof Opasiak --- include/usbg/usbg.h |4 1 file changed, 4 insertions(+) diff --git a/include/usbg/usbg.h b/include/usbg/usbg.h index 319c

[PATCH v4 02/12] libusbg: Add missing return statement in non-void functions.

2014-01-22 Thread Krzysztof Opasiak
Add return 0 in functions which return non-void to suppress compiler complaint. Signed-off-by: Krzysztof Opasiak --- src/usbg.c |4 1 file changed, 4 insertions(+) diff --git a/src/usbg.c b/src/usbg.c index e648f0f..51722a1 100644 --- a/src/usbg.c +++ b/src/usbg.c @@ -223,6 +223,8 @@ s

[PATCH v4 06/12] libusbg: Add error handling to gadget_read_string().

2014-01-22 Thread Krzysztof Opasiak
Add error handling when gadget_read_buf() returns NULL. If read of string fails, the string should be set as empty. Change-Id: I56367c3820e3efae89f533639225e59f86a77d2b Signed-off-by: Krzysztof Opasiak --- src/usbg.c | 24 +--- 1 file changed, 17 insertions(+), 7 deletions(

[PATCH v4 10/12] libusbg: Move symlink creation after memory allocation.

2014-01-22 Thread Krzysztof Opasiak
Move creation of symlink after memory allocation for binding structure. Fix missing initialization of parent. Signed-off-by: Krzysztof Opasiak --- src/usbg.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/src/usbg.c b/src/usbg.c index 0df2f7d..71317f4 100644 -

[PATCH v4 12/12] libusbg: Replace directory names with defines.

2014-01-22 Thread Krzysztof Opasiak
Replace strings, functions, configs strings placed everywhere in code with macro defintions STRINGS_DIR, FUNCTIONS_DIR and CONFIGS_DIR. Change-Id: Ic507ff4c325289454a6032acfacdeb293eba5371 Signed-off-by: Krzysztof Opasiak --- src/usbg.c | 39 --- 1 file chan

[PATCH v4 08/12] libusbg: Separate parsing gadget attributes and strings.

2014-01-22 Thread Krzysztof Opasiak
Gadget attributes and strings are logically independent, so they should be initialized in separate functions. Signed-off-by: Krzysztof Opasiak --- src/usbg.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/src/usbg.c b/src/usbg.c index 341af61..baeb86f 100644 --

[PATCH v4 11/12] libusbg: Replace memcpy with structure assignment.

2014-01-22 Thread Krzysztof Opasiak
Use the assign operator for structure instead of using memcpy with hard coded size. Signed-off-by: Krzysztof Opasiak --- src/usbg.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/usbg.c b/src/usbg.c index 71317f4..ac01e56 100644 --- a/src/usbg.c +++ b/src/usbg

[PATCH v4 07/12] libusbg: Add missing config attrs parsing while new config creation.

2014-01-22 Thread Krzysztof Opasiak
Afther creation of configuration its attributes left uninitialized. Config attrs should be initialized with default values provided by kernel. Change-Id: Iec65db1123bfe9aef81d42539fa0f6427383cfbc Signed-off-by: Krzysztof Opasiak --- src/usbg.c |2 ++ 1 file changed, 2 insertions(+) diff --g

Re: [PATCH v3 03/10] usb: find internal hub tier mismatch via acpi

2014-01-22 Thread Alan Stern
On Wed, 22 Jan 2014, Dan Williams wrote: > > That's not what I meant. > > > > Sending a request to khubd means doing something like this: > > > > set_bit(port1, hub->resume_child_bits); > > kick_khubd(hub); > > > > khubd may start running even before kick_khubd returns. If it does

[PATCH v4 09/12] libusbg: Initialize gadget attributes and strings while gadget creation.

2014-01-22 Thread Krzysztof Opasiak
Fix gadget_create_gadget function to initialize gadget attributes and strings with default values provided by kernel. Change-Id: I8086c575fae0a122d3ff7053defa592dba5369ea Signed-off-by: Krzysztof Opasiak --- src/usbg.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/s

30 sec boot delay and logitech mouse disconnection

2014-01-22 Thread glphvgacs
i have feeling that there is protocol/netiquette that i'm not following. (a pointer is appreciate). and also to add to the info i'm adding lsusb -vv's output to msg. please let me know if you need more info/log. thanks Bus 002 Device 004: ID 413c:2107 Dell Computer Corp. Device Descriptor: bL

RE: [PATCH v6 2/4] libusbg: Add fputs()/fgets() error handling

2014-01-22 Thread David Laight
From: Stanislaw Wadas > Add error handling to fputs()/fgets() functions. ... > - fputs(buf, fp); > + if (fputs(buf, fp) == EOF) { > + ERROR("write error"); > + fclose(fp); > + return; > + } Pointless... Most code that looks at the return value of fpu

RE: [PATCH v6 4/4] libusbg: Add inline to gadget_write_string().

2014-01-22 Thread David Laight
From: Of Stanislaw Wadas > Add inline to gadget_write_string(). ... > -static void usbg_write_string(char *path, char *name, char *file, char *buf) > +static inline void usbg_write_string(char *path, char *name, char *file, > char *buf) > { > usbg_write_buf(path, name, file, buf); > } Why

Re: USB-PATA bridge inic-1511. It is not possible to read a lot of audio disks

2014-01-22 Thread Alan Stern
Please use Reply-To-All so that your email gets sent to the mailing list as well as to me. On Wed, 22 Jan 2014, Andrey Karpenko wrote: > Hi Alan > > Please, find attached usbmon trace. > I have used 3.13 kernel. > > Thanks Please don't top-post. > On Mon, 2014-01-20 at 21:13 -0500, Alan Ster

[PATCH] staging/usbip: Fix vhci_hcd attach failure error message to be informative

2014-01-22 Thread Shuah Khan
When attach fails due to unsupported and/or invalid bus speed, the message vhci_hcd prints out doesn't include any useful information as to what caused the failure. Change the message to be informative and use usb_speed_string() to get the right speed string from usb common. Signed-off-by: Shuah K

Re: 174c:5106 1 TB External USB 3.0 Drive Fails to Automount through USB 3.0 dock with XHCI Enabled

2014-01-22 Thread Jay S
Actually, the USB3 device I'm using, a Unitek Y-1072 HDD dock, works fine with a WD 500 GB drive using XHCI, so it seems like it's something to do with the larger drive. I have also tried with a Rosewill RX35-AT-SU3 external enclosure and a Rosewill RX-DU300 HDD dock. All failed with the 1 TB

Re: 30 sec boot delay and logitech mouse disconnection

2014-01-22 Thread Alan Stern
On Tue, 21 Jan 2014, glphvgacs wrote: > hello, > could you please have look at the attached file for two perhaps related > problems. > 1. a 30 sec delay while booting > 30-sec-delay.log > > 2. repeating block of 'USB disconnected' msg while running the machine > repeating-usb-msg.log > > the who

Re: Fwd: Re: [alsa-devel] no reset_resume for driver snd-usb-audio for logitech headset H600

2014-01-22 Thread baumber
On 2014-01-20 17:07, Takashi Iwai wrote: At Mon, 20 Jan 2014 09:45:58 +0100, Takashi Iwai wrote: At Sun, 19 Jan 2014 21:30:58 +0100, wrote: Hello, there must be a misunderstanding; There is a functional change, because with the line/patch ".reset_resume = usb_audio_resume," the mixer of t

Re: Fwd: Re: [alsa-devel] no reset_resume for driver snd-usb-audio for logitech headset H600

2014-01-22 Thread Takashi Iwai
At Wed, 22 Jan 2014 18:12:45 +0100, wrote: > > On 2014-01-20 17:07, Takashi Iwai wrote: > > At Mon, 20 Jan 2014 09:45:58 +0100, > > Takashi Iwai wrote: > >> > >> At Sun, 19 Jan 2014 21:30:58 +0100, > >> wrote: > >>> > >>> Hello, > >>> > >>> there must be a misunderstanding; > >>> > >>> There is

USB Device stops working after 200001 interrupts

2014-01-22 Thread Josh Bendavid
I have a usb infrared remote receiver (Windows media center variety) which works correctly at boot, but stops working sometime later. Kernel gives: [ 1101.490321] irq 21: nobody cared (try booting with the "irqpoll" option) [ 1101.490328] CPU: 0 PID: 0 Comm: swapper/0 Tainted: P O 3.13.0-rc8 #1 [

[PATCH] staging/usbip: Change userspace to use linux include for usb_device_speed enum

2014-01-22 Thread Shuah Khan
Remove usb_device_speed enum define from usbip_common.h and change it to include linux/usb/ch9.h instead. Signed-off-by: Shuah Khan --- drivers/staging/usbip/userspace/libsrc/usbip_common.h | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/staging/usbip/userspace

Re: [usb-storage] Re: usb disk recognized but fails

2014-01-22 Thread Milan Svoboda
Here is the usbmon log. The disk works with TV and Windows. No error messages. Could it be under-powered? Thanks, Milan 88020e734600 2269960175 S Ci:3:001:0 s a3 00 0001 0004 4 < 88020e734600 2269960196 C Ci:3:001:0 0 4 = 0001 88020e734600 2269960200 S Ci:3:001:0 s a3 00

Re: [PATCH 2/2] ehci-platform: Add support for controllers with big-endian regs / descriptors

2014-01-22 Thread Hans de Goede
Hi, On 01/21/2014 08:39 PM, Florian Fainelli wrote: 2014/1/21 Hans de Goede : This uses the already documented devicetree booleans for this. (I would greatly appreciate if you could CC people who gave you feedback on this before) Will do. A more informative commit message would be welcome

[PATCH v8 4/4] ehci-platform: Add support for controllers with big-endian regs / descriptors

2014-01-22 Thread Hans de Goede
This uses the already documented devicetree booleans for this, see: Documentation/devicetree/bindings/usb/usb-ehci.txt Signed-off-by: Hans de Goede --- drivers/usb/host/ehci-platform.c | 33 +++-- 1 file changed, 31 insertions(+), 2 deletions(-) diff --git a/drivers/

[PATCH v8 2/4] ehci-platform: Add support for clks and phy passed through devicetree

2014-01-22 Thread Hans de Goede
Currently ehci-platform is only used in combination with devicetree when used with some Via socs. By extending it to (optionally) get clks and a phy from devicetree, and enabling / disabling those on power_on / off, it can be used more generically. Specifically after this commit it can be used for

[PATCH v8 0/4] ohci and ehci-platform clks, phy, be and dt support

2014-01-22 Thread Hans de Goede
Hi All, Although v7 was intended as the final version here is a v8, compared to v7 this contains 2 small fixes to the dt-bindings documentation so that the examples there match the dt-node naming rules. Besides that I've also rolled v2 of my patches to also add support for specifying controller e

[PATCH v8 1/4] ohci-platform: Add support for devicetree instantiation

2014-01-22 Thread Hans de Goede
Add support for ohci-platform instantiation from devicetree, including optionally getting clks and a phy from devicetree, and enabling / disabling those on power_on / off. This should allow using ohci-platform from devicetree in various cases. Specifically after this commit it can be used for the

[PATCH v8 3/4] ohci-platform: Add support for controllers with big-endian regs / descriptors

2014-01-22 Thread Hans de Goede
Note this commit uses the same devicetree booleans for this as the ones already existing in the usb-ehci bindings, see: Documentation/devicetree/bindings/usb/usb-ehci.txt Signed-off-by: Hans de Goede --- Documentation/devicetree/bindings/usb/usb-ohci.txt | 3 +++ drivers/usb/host/ohci-platform.

Re: [PATCH v8 3/4] ohci-platform: Add support for controllers with big-endian regs / descriptors

2014-01-22 Thread Sergei Shtylyov
Hello. On 01/22/2014 10:32 PM, Hans de Goede wrote: Note this commit uses the same devicetree booleans for this as the ones already existing in the usb-ehci bindings, see: Documentation/devicetree/bindings/usb/usb-ehci.txt Signed-off-by: Hans de Goede [...] diff --git a/drivers/usb/host/

[PATCH] staging/usbip: Add missing speeds to userspace speed_strings array

2014-01-22 Thread Shuah Khan
Add speed strings for usb wireless and 3.0 to speed_strings array. Signed-off-by: Shuah Khan --- drivers/staging/usbip/userspace/libsrc/usbip_common.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/usbip/userspace/libsrc/usbip_common.c b/drivers/staging/usbip/userspace/li

Re: [usb-storage] Re: usb disk recognized but fails

2014-01-22 Thread Alan Stern
On Wed, 22 Jan 2014, Milan Svoboda wrote: > Here is the usbmon log. The disk works with TV and Windows. No error messages. > Could it be under-powered? That's possible, but not if it works under Windows on the same computer. The first reset occurred when the disk failed to respond correctly to

Re: USB Device stops working after 200001 interrupts

2014-01-22 Thread Alan Stern
On Wed, 22 Jan 2014, Josh Bendavid wrote: > I have a usb infrared remote receiver (Windows media center variety) which > works correctly at boot, but stops working sometime later. > > Kernel gives: > [ 1101.490321] irq 21: nobody cared (try booting with the "irqpoll" option) > [ 1101.490328] CPU:

Re: [PATCH 2/2] ehci-platform: Add support for controllers with big-endian regs / descriptors

2014-01-22 Thread Jonas Gorski
Hi, On Wed, 22 Jan 2014 20:28:26 +0100 Hans de Goede wrote: > Hi, > > On 01/21/2014 08:39 PM, Florian Fainelli wrote: > > 2014/1/21 Hans de Goede : > >> This uses the already documented devicetree booleans for this. > > > > (I would greatly appreciate if you could CC people who gave you > > feed

Re: USB-PATA bridge inic-1511. It is not possible to read a lot of audio disks

2014-01-22 Thread Andrey Karpenko
Hi Alan, I hope 'Group Reply' does the same as 'Reply-To-All' ;) With USB 2.0 the same results. Please, find it in the attachment. If you need I can do it with 'Good' disk too. Thanks On Wed, 2014-01-22 at 11:30 -0500, Alan Stern wrote: > Please use Reply-To-All so that your email gets sent to

Re: [PATCH 2/2] ehci-platform: Add support for controllers with big-endian regs / descriptors

2014-01-22 Thread Hans de Goede
Hi, On 01/22/2014 09:34 PM, Jonas Gorski wrote: Hi, On Wed, 22 Jan 2014 20:28:26 +0100 Hans de Goede wrote: Hi, On 01/21/2014 08:39 PM, Florian Fainelli wrote: 2014/1/21 Hans de Goede : This uses the already documented devicetree booleans for this. (I would greatly appreciate if you coul

Re: [PATCH 1/5] xhci: Don't change the ownership of LINK TRB until all the TRB are written

2014-01-22 Thread Sarah Sharp
Hi David, I've been thinking about this some more, and I'd like to propose a much simpler solution. The TD fragment rules didn't go into the xHCI specification until the 1.0 revision. The code that follows those rules only seems to trigger issues for 0.96 ASMedia hosts, while Intel 1.0 hosts ben

Re: [PATCH 2/2] ehci-platform: Add support for controllers with big-endian regs / descriptors

2014-01-22 Thread Hans de Goede
Hi, On 01/22/2014 09:52 PM, Hans de Goede wrote: Hi, On 01/22/2014 09:34 PM, Jonas Gorski wrote: Hi, On Wed, 22 Jan 2014 20:28:26 +0100 Hans de Goede wrote: Hi, On 01/21/2014 08:39 PM, Florian Fainelli wrote: 2014/1/21 Hans de Goede : This uses the already documented devicetree booleans

Re: [usb-storage] Re: usb disk recognized but fails

2014-01-22 Thread Milan Svoboda
> >> 8801fdbb2c00 2290129737 S Bo:3:004:2 -115 31 = 55534243 5f00 >> 0010 8a28 004a856e af08 00 >> 8801fdbb2c00 2290129782 C Bo:3:004:2 0 31 > >> 8800d4a51b40 2290129803 S Bi:3:004:1 -115 4096 < >> 8800d4a51b40 2301288990 C Bi:3:004:1 -32 512 =

Re: [RFC/PATCH 1/3] pm: make PM macros more smart

2014-01-22 Thread David Cohen
On Tue, Jan 14, 2014 at 02:42:11PM -0800, David Cohen wrote: > On Fri, Dec 20, 2013 at 12:23:36PM -0800, David Cohen wrote: > > On Fri, Dec 20, 2013 at 08:55:27PM +0100, Pavel Machek wrote: > > > On Sun 2013-12-15 11:25:08, David Cohen wrote: > > > > On Sun, Dec 15, 2013 at 06:51:12PM +0100, Pavel

Re: [PATCH 2/2] ehci-platform: Add support for controllers with big-endian regs / descriptors

2014-01-22 Thread Alan Stern
On Wed, 22 Jan 2014, Jonas Gorski wrote: > If it's safe to set ehci->big_endian_{desc,mmio} from the _probe() > routine, then maybe the pdata sets in _reset() should be moved into here > instead of adding extra cludges/checks into _reset(). Why? What difference would it make? Alan Stern -- To

[PATCH] staging/usbip: Change vhci_hcd store_attach() device information message to include speed string

2014-01-22 Thread Shuah Khan
Change vhci_hcd store_attach() routine to include speed string in its device information message. The current call to dev_info() prints out speed number which is the enum number. Change to call usb_speed_string() to print speed string in addition to the number. Signed-off-by: Shuah Khan --- driv

Re: USB-PATA bridge inic-1511. It is not possible to read a lot of audio disks

2014-01-22 Thread Alan Stern
On Wed, 22 Jan 2014, Andrey Karpenko wrote: > Hi Alan, > I hope 'Group Reply' does the same as 'Reply-To-All' ;) > > With USB 2.0 the same results. > > Please, find it in the attachment. > > If you need I can do it with 'Good' disk too. There's no apparent reason for the problem. This time th

Re: [usb-storage] Re: usb disk recognized but fails

2014-01-22 Thread Alan Stern
On Wed, 22 Jan 2014, Milan Svoboda wrote: > >This continued a few more times until the computer gave up. Maybe > >there is something wrong with one particular block at that address on > >the disk. > > I tried to run fdisk /dev/sdb which obivously failed but it tried to access > sectors 0, 1, 2,

Re: Regression on next-20140116 [Was: [PATCH 3/3 v4] usb: chipidea: hw_phymode_configure moved before ci_usb_phy_init]

2014-01-22 Thread Uwe Kleine-König
Hello, On Wed, Jan 22, 2014 at 10:49:51AM +0100, Uwe Kleine-König wrote: > On Tue, Dec 03, 2013 at 04:01:50PM +0800, Chris Ruehl wrote: > > usb: chipidea: hw_phymode_configure moved before ci_usb_phy_init > > hw_phymode_configure configures the PORTSC registers and allow the > > following phy_init

Re: [RFT] xhci: Fix resume issues on Renesas chips in Samsung laptops

2014-01-22 Thread Sarah Sharp
On Wed, Jan 22, 2014 at 09:18:27AM -0500, Prarit Bhargava wrote: > > > > Don Zickus writes: > > > > Some co-workers of mine bought Samsung laptops that had mostly usb3 ports. > > Those ports did not resume correctly (the driver would timeout communicating > > and fail). This led to frustration

Re: USB-PATA bridge inic-1511. It is not possible to read a lot of audio disks

2014-01-22 Thread Andrey Karpenko
Hi Alan, I thought the same way. But this drive has the separate power supply and it doesn't take power from USB port! I have checked the power lines with oscilloscope. If you need to be sure I can send the pictures. I have rebooted my inspiron to Windows 8. I have checked it again with the same

Re: [RFT] xhci: Fix resume issues on Renesas chips in Samsung laptops

2014-01-22 Thread Don Zickus
On Wed, Jan 22, 2014 at 02:04:19PM -0800, Sarah Sharp wrote: > On Wed, Jan 22, 2014 at 09:18:27AM -0500, Prarit Bhargava wrote: > > > > > > > Don Zickus writes: > > > > > > Some co-workers of mine bought Samsung laptops that had mostly usb3 ports. > > > Those ports did not resume correctly (the

Re: [RFT] usb: Don't enable USB 3.0 LPM for non-Intel hosts.

2014-01-22 Thread Sarah Sharp
On Sat, Jan 18, 2014 at 04:59:12AM +0400, Sergey Galanov wrote: > Hi Sarah. > It works. I applied the patch to 3.13rc8 (I had to modify it a little > bit because in my version xhci_readl is called rather than readl). > lsusb I've sent included the dock info. It's 'JMicron Technology' > device. At l

Re: [BUG] FL1009: xHCI host not responding to stop endpoint command.

2014-01-22 Thread Arnaud Ebalard
Hi Sarah, Sarah Sharp writes: > On Sat, Jan 18, 2014 at 10:49:17PM +0100, Arnaud Ebalard wrote: >> Hi, >> >> I have added Thomas in the recipients, because I guess he may be of some >> help debugging the issue further. Thomas, the beginning of the thread is >> here: http://thread.gmane.org/gman

Re: [BUG] FL1009: xHCI host not responding to stop endpoint command.

2014-01-22 Thread Jason Cooper
On Wed, Jan 22, 2014 at 11:23:23PM +0100, Arnaud Ebalard wrote: > With the patch applied on top of 3.13.0 kernel recompiled w/ > CONFIG_PCI_MSI enabled, I cannot reproduce the bug. I guess > you can add my: > > Reported-and-tested-By: Arnaud Ebalard > > Since you'll have to push the patch to -s

Re: 30 sec boot delay and logitech mouse disconnection

2014-01-22 Thread glphvgacs
On Wed, Jan 22, 2014 at 11:37:46AM -0500, Alan Stern wrote: > Let's start with the disconnecting mouse. Collect a usbmon trace for > bus 1, over a time period long enough to show a few of those > disconnects. (See the instructions in Documentation/usb/usbmon.txt.) > We'll see what shows up. >

Re: [BUG] FL1009: xHCI host not responding to stop endpoint command.

2014-01-22 Thread Arnaud Ebalard
Hi Jason, Jason Cooper writes: > On Wed, Jan 22, 2014 at 11:23:23PM +0100, Arnaud Ebalard wrote: >> With the patch applied on top of 3.13.0 kernel recompiled w/ >> CONFIG_PCI_MSI enabled, I cannot reproduce the bug. I guess >> you can add my: >> >> Reported-and-tested-By: Arnaud Ebalard >> >

Re: [PATCH 2/2] ehci-platform: Add support for controllers with big-endian regs / descriptors

2014-01-22 Thread Jonas Gorski
On Wed, 22 Jan 2014 16:17:42 -0500 (EST) Alan Stern wrote: > On Wed, 22 Jan 2014, Jonas Gorski wrote: > > > If it's safe to set ehci->big_endian_{desc,mmio} from the _probe() > > routine, then maybe the pdata sets in _reset() should be moved into here > > instead of adding extra cludges/checks i

Re: [PATCH 1/5] xhci: Don't change the ownership of LINK TRB until all the TRB are written

2014-01-22 Thread walt
On 01/22/2014 12:56 PM, Sarah Sharp wrote: > Walt, can you turn on xHCI debugging and look for whether the NEC host > that worked with David's patch is a 1.0 host? You'll see a line like: > > // @%p = 0x%x (CAPLENGTH AND HCIVERSION) Hi Sarah. This is from the NEC host controller, *not* the ASMe

Re: segate external USB3.0 HD cannot work

2014-01-22 Thread Sarah Sharp
On Sun, Jan 12, 2014 at 09:08:40PM +0800, yoma sophian wrote: > I can see the HD mounted when I change to NO CONFIG_PM kernel. > > Would you please tell me where we can get the conclusion that failure > comes from this device has some problem with runtime power > management? Oliver was looking a

[RFT] usb: Disable Link PM if setting device-initiated timeout fails.

2014-01-22 Thread Sarah Sharp
If the control transfer to set the device-initiated timeout fails for a particular link state (U1 or U2), disable that state. This may solve issues with a Seagate drive connected to an Intel Panther Point host controller: [ 432.191560] usb 4-1: Set SEL for device-initiated U2 failed. [ 432.1916

Re: [BUG] FL1009: xHCI host not responding to stop endpoint command.

2014-01-22 Thread Sarah Sharp
On Wed, Jan 22, 2014 at 11:43:16PM +0100, Arnaud Ebalard wrote: > Hi Jason, > > Jason Cooper writes: > > > On Wed, Jan 22, 2014 at 11:23:23PM +0100, Arnaud Ebalard wrote: > >> With the patch applied on top of 3.13.0 kernel recompiled w/ > >> CONFIG_PCI_MSI enabled, I cannot reproduce the bug. I

Re: [PATCH 1/5] xhci: Don't change the ownership of LINK TRB until all the TRB are written

2014-01-22 Thread Sarah Sharp
On Wed, Jan 22, 2014 at 03:22:53PM -0800, walt wrote: > On 01/22/2014 12:56 PM, Sarah Sharp wrote: > > Walt, can you turn on xHCI debugging and look for whether the NEC host > > that worked with David's patch is a 1.0 host? You'll see a line like: > > > > // @%p = 0x%x (CAPLENGTH AND HCIVERSION)

Re: [PATCH] usb: host: xhci: fix HALTED endpoint handling

2014-01-22 Thread Sarah Sharp
On Tue, Jan 21, 2014 at 05:19:13PM -0500, Alan Stern wrote: > On Tue, 21 Jan 2014, Sarah Sharp wrote: > > > Ah, I think I see what's happening. > > > > The xHCI driver is not designed to execute transfers after a stall on a > > non-control endpoint until xhci_endpoint_reset is called and the driv

Max. libusb bulk send/receive values lowered with xhci?

2014-01-22 Thread Jérôme Carretero
Hi Sarah, I was happily using big (10MB) buffers before, and with recent kernels, when using USB3, I had to reduce the size of my buffers a lot. By the way, I couldn't find any information on a maximum size for the bulk transfers using libusb, maybe you know about that also ? So, using v3.13, th

Re: Regression on next-20140116 [Was: [PATCH 3/3 v4] usb: chipidea: hw_phymode_configure moved before ci_usb_phy_init]

2014-01-22 Thread Peter Chen
On Wed, Jan 22, 2014 at 10:41:33PM +0100, Uwe Kleine-König wrote: > Hello, > > On Wed, Jan 22, 2014 at 10:49:51AM +0100, Uwe Kleine-König wrote: > > On Tue, Dec 03, 2013 at 04:01:50PM +0800, Chris Ruehl wrote: > > > usb: chipidea: hw_phymode_configure moved before ci_usb_phy_init > > > hw_phymode_

Re: Regression on next-20140116 [Was: [PATCH 3/3 v4] usb: chipidea: hw_phymode_configure moved before ci_usb_phy_init]

2014-01-22 Thread Chris Ruehl
On Thursday, January 23, 2014 09:22 AM, Peter Chen wrote: On Wed, Jan 22, 2014 at 10:41:33PM +0100, Uwe Kleine-König wrote: Hello, On Wed, Jan 22, 2014 at 10:49:51AM +0100, Uwe Kleine-König wrote: On Tue, Dec 03, 2013 at 04:01:50PM +0800, Chris Ruehl wrote: usb: chipidea: hw_phymode_configure

  1   2   >