Re: [PATCH v3] kconfig/symbol.c: handle choice_values that depend on 'm' symbols

2013-11-05 Thread Sebastian Andrzej Siewior
On 11/04/2013 09:46 PM, Yann E. MORIN wrote: > Sebastian, All, Hi Yann, >> Still solves the issue for me :) > > Should I consider this as: > Tested-by: > ? Yes, please. Tested-by: Sebastian Andrzej Siewior > > Regards, > Yann E. MORIN. > Sebastian -- To unsubscribe from this list: sen

Re: [PATCH RFC 1/4] phy: Add new Exynos5 USB 3.0 PHY driver

2013-11-05 Thread Tomasz Figa
On Tuesday 05 of November 2013 12:50:18 Vivek Gautam wrote: > Hi Kishon, > > On Mon, Nov 4, 2013 at 6:42 PM, Kishon Vijay Abraham I wrote: > > Hi, > > > > On Monday 04 November 2013 03:45 PM, Kamil Debski wrote: > >> Hi Kishon, > >> > >>> From: Kishon Vijay Abraham I [mailto:kis...@ti.com] > >

RE: [PATCH RFC 1/4] phy: Add new Exynos5 USB 3.0 PHY driver

2013-11-05 Thread Kamil Debski
Hi, > From: Vivek Gautam [mailto:gautamvivek1...@gmail.com] > Sent: Tuesday, November 05, 2013 8:20 AM > To: Kishon Vijay Abraham I > Cc: Kamil Debski; Vivek Gautam; Linux USB Mailing List; linux-samsung- > s...@vger.kernel.org; linux-ker...@vger.kernel.org; > devicet...@vger.kernel.org; linux-arm

Re: FW: [PATCH] Fix ring expansion on BE hosts.

2013-11-05 Thread Sarah Sharp
On Fri, Nov 01, 2013 at 05:10:17PM -, David Laight wrote: > Sarah, > > The patch below is a real bug that will hit BE systems, so probably > ought to be a candidate for 3.12 even though it is late in the cycle. Thanks for catching this bug. However, it's too late to make it into 3.12. Greg

[PATCH] USB: ftdi_sio: fixed handling of unsupported CSIZE setting

2013-11-05 Thread Colin Leitner
FTDI UARTs support only 7 or 8 data dits. Until now the ftdi_sio driver would only report this limitation for CS6 to dmesg and fail to reflect this fact to tcgetattr. This patch reverts the unsupported CSIZE setting and reports the fact with less severance to dmesg for both CS5 and CS6. To test t

[PATCHv2] USB: serial: option: blacklist intf1 for Huawei E173s-6

2013-11-05 Thread Gustavo Zacarias
Interface 1 on this device isn't for option to bind to otherwise an oops on usb_wwan with log flooding will happen when accessing the port: tty_release: ttyUSB1: read/write wait queue active! It doesn't seem to respond to QMI if it's added to qmi_wwan so don't add it there. Signed-off-by: Gustav

Re: [PATCH v3 0/0] usb: musb bugfixes

2013-11-05 Thread Markus Pargmann
Hi Felipe, On Wed, Oct 16, 2013 at 02:51:08PM +0200, Markus Pargmann wrote: > Hi, > > the series contains two bugfixes and some debugfs file operations for dsps > similar to the musb core regdump debugfs file. Do you have some time to look at these patches? Thanks, Markus Pargmann -- Pengutr

Re: [PATCH RFC 1/4] phy: Add new Exynos5 USB 3.0 PHY driver

2013-11-05 Thread Jingoo Han
On Tuesday, November 05, 2013 6:37 PM, Kamil Debski wrote: > On Tuesday, November 05, 2013 8:20 AM, Vivek Gautam wrote: > > On Mon, Nov 4, 2013 at 6:42 PM, Kishon Vijay Abraham I > > wrote: > > > On Monday 04 November 2013 03:45 PM, Kamil Debski wrote: > > >> On Monday, November 04, 2013 7:55 AM,

Re: [PATCH] USB: ftdi_sio: fixed handling of unsupported CSIZE setting

2013-11-05 Thread Johan Hovold
On Tue, Nov 05, 2013 at 11:10:29AM +0100, Colin Leitner wrote: > FTDI UARTs support only 7 or 8 data dits. Until now the ftdi_sio driver would s/dits/bits/ > only report this limitation for CS6 to dmesg and fail to reflect this fact to > tcgetattr. > > This patch reverts the unsupported CSIZE set

Re: [PATCH RFC 1/4] phy: Add new Exynos5 USB 3.0 PHY driver

2013-11-05 Thread Jingoo Han
On Tuesday, November 05, 2013 8:13 PM, Jingoo Han wrote: > On Tuesday, November 05, 2013 6:37 PM, Kamil Debski wrote: > > On Tuesday, November 05, 2013 8:20 AM, Vivek Gautam wrote: > > > On Mon, Nov 4, 2013 at 6:42 PM, Kishon Vijay Abraham I > > > wrote: > > > > On Monday 04 November 2013 03:45 P

Re: [PATCH] USB: ftdi_sio: fixed handling of unsupported CSIZE setting

2013-11-05 Thread Colin Leitner
> Comment style should be > > /* >* ... >*/ I tried sticking to the style of the rest of the code but I'll keep that in mind from now on. Wouldn't that be something checkpatch.pl could check? > But I'm not sure you need to be that verbose in this case. You can > probably ju

Re: [PATCH 1/4] usb/gadget: composite: redirect setup requests

2013-11-05 Thread Michal Nazarewicz
On Mon, Nov 04 2013, Andrzej Pietrasiewicz wrote: > If there are setup requests not directed to an endpont or an interface, > current config's setup() has been attempted so far. > This patch, in case the above fails, adds code which tries the setup() of > configuration's function if there is only o

Re: [PATCH 2/4] usb/gadget: factor out alloc_ep_req

2013-11-05 Thread Michal Nazarewicz
On Mon, Nov 04 2013, Andrzej Pietrasiewicz wrote: > alloc_ep_req() is a function repeated in several modules. > Make a common implementation and use it. > > Signed-off-by: Andrzej Pietrasiewicz > Signed-off-by: Kyungmin Park Acked-by: Michal Nazarewicz -- Best regards,

RE: [PATCH net v2 2/3] r8152: modify the tx flow

2013-11-05 Thread hayeswang
David Miller [mailto:da...@davemloft.net] > Sent: Tuesday, November 05, 2013 4:53 AM > To: Hayeswang > Cc: net...@vger.kernel.org; nic_swsd; > linux-ker...@vger.kernel.org; linux-usb@vger.kernel.org > Subject: Re: [PATCH net v2 2/3] r8152: modify the tx flow [...] > The more TX work you push int

[PATCH v3 0/2] libusbg: clean up and error handling

2013-11-05 Thread Stanislaw Wadas
In reference to the message sent by Andrzej Pietrasiewicz (about libusbg (formerly libgadget)) I would like to propose some changes to libusbg. Creating directories is now performed after successful memory allocation and gadget function creation. Hard coded values are replaced with constants. Erro

[PATCH v3 2/2] libusbg: added fputs()/fgets() error handling

2013-11-05 Thread Stanislaw Wadas
Error handling was added to fputs()/fgets() functions. Signed-off-by: Stanislaw Wadas --- Changes since v2: - fixed code indentation - removed unused variable ret Changes since v1: - fixed typos in MAX_LENGTH throughout src/gadget.c | 11 ++- 1 file changed,

[PATCH v3 1/2] libusbg: Moved mkdir functions, added MAX_LENGTH & MAX_PATH_LENGTH

2013-11-05 Thread Stanislaw Wadas
mkdir() function is now performed after successful memory allocation and gadget function creation. Added inline to gadget_write_string(). 256 hard coded value has been replaced by two defined constants MAX_LENGTH and MAX_PATH_LENGTH Signed-off-by: Stanislaw Wadas --- Changes since v1: - f

[PATCH] usb: xhci: Optimise setup of isochronous transfers

2013-11-05 Thread David Laight
Close inspection shows that xhci_queue_isoc_tx() can only fail if prepare_transfer() gets an error from usb_hcd_link_urb_to_ep() for the first TD. The call to prepare_ring() cannot fail because an initial check is made to ensure the ring has enough space for all the TD. The check for 'num_tds' be

Re: [PATCH] USB: ftdi_sio: fixed handling of unsupported CSIZE setting

2013-11-05 Thread Johan Hovold
On Tue, Nov 05, 2013 at 01:14:29PM +0100, Colin Leitner wrote: > > Comment style should be > > > > /* > > * ... > > */ > > I tried sticking to the style of the rest of the code but I'll keep that > in mind from now on. Wouldn't that be something checkpatch.pl could check? You'd thi

Re: [PATCH 2/2](fix) added fputs() fgets() error handling

2013-11-05 Thread Stanislaw Wadas
On 04.11.2013 17:22, Matt Porter wrote: On Mon, Nov 04, 2013 at 04:09:39PM +0100, Stanislaw Wadas wrote: Change-Id: I787380dda981c7cee6508a4ff566d7ca9fb273cf Signed-off-by: Stanislaw Wadas Need a commit log entry for this one. Can you please follow kernel conventions when posting/reposting?

Re: [PATCH v4 2/4] usb: gadget: add quirk_ep_out_aligned_size field to struct usb_gadget

2013-11-05 Thread Alan Stern
On Mon, 4 Nov 2013, David Cohen wrote: > Due to USB controllers may have different restrictions, usb gadget layer > needs to provide a generic way to inform gadget functions to complain > with non-standard requirements. > > This patch adds 'quirk_ep_out_aligned_size' field to struct usb_gadget >

Re: [PATCH v4 3/4] usb: ffs: check quirk to pad epout buf size when not aligned to maxpacketsize

2013-11-05 Thread Alan Stern
On Mon, 4 Nov 2013, David Cohen wrote: > Check gadget.quirk_ep_out_aligned_size to decide if buffer size requires > to be aligned to maxpacketsize of an out endpoint. ffs_epfile_io() needs > to pad epout buffer to match above condition if quirk is found. > > Signed-off-by: David Cohen > --- > d

Re: Large USB HID transfers

2013-11-05 Thread Alan Stern
On Mon, 4 Nov 2013, Cliff Brake wrote: > On Mon, Nov 4, 2013 at 11:51 AM, Alan Stern wrote: > > On Mon, 4 Nov 2013, Cliff Brake wrote: > > >> We have the same system running on a older PXA270 version of the > >> product (vs the current TI DM3730). It has an older OHCI 12Mbit USB > >> host contr

Re: [PATCH 5/7] IBM Akebono: Add support to the EHCI platform driver for Akebono

2013-11-05 Thread Alan Stern
On Tue, 5 Nov 2013, Alistair Popple wrote: > The IBM Akebono board has an EHCI compliant USB host interface. This > patch adds support for it to the EHCI platform driver. > > Signed-off-by: Alistair Popple > Cc: Alan Stern > Cc: linux-usb@vger.kernel.org > --- > drivers/usb/host/ehci-platform.

Re: [PATCH 4/7] IBM Akebono: Add support to the OHCI platform driver for Akebono

2013-11-05 Thread Alan Stern
On Tue, 5 Nov 2013, Alistair Popple wrote: > The IBM Akebono board has a OHCI compliant USB host interface. This > patch adds support for it to the OHCI platform driver. > > As we use device tree to pass platform specific data instead of > platform data we remove the check for platform data and i

Re: [PATCH v4 3/4] usb: ffs: check quirk to pad epout buf size when not aligned to maxpacketsize

2013-11-05 Thread David Cohen
On 11/05/2013 06:52 AM, Alan Stern wrote: > On Mon, 4 Nov 2013, David Cohen wrote: > >> Check gadget.quirk_ep_out_aligned_size to decide if buffer size requires >> to be aligned to maxpacketsize of an out endpoint. ffs_epfile_io() needs >> to pad epout buffer to match above condition if quirk is f

Re: [PATCH v4 2/4] usb: gadget: add quirk_ep_out_aligned_size field to struct usb_gadget

2013-11-05 Thread David Cohen
On 11/05/2013 06:50 AM, Alan Stern wrote: > On Mon, 4 Nov 2013, David Cohen wrote: > >> Due to USB controllers may have different restrictions, usb gadget layer >> needs to provide a generic way to inform gadget functions to complain >> with non-standard requirements. >> >> This patch adds 'quirk_

Re: [PATCH v4 2/4] usb: gadget: add quirk_ep_out_aligned_size field to struct usb_gadget

2013-11-05 Thread David Cohen
On 11/05/2013 06:50 AM, Alan Stern wrote: > On Mon, 4 Nov 2013, David Cohen wrote: > >> Due to USB controllers may have different restrictions, usb gadget layer >> needs to provide a generic way to inform gadget functions to complain >> with non-standard requirements. >> >> This patch adds 'quirk_

Re: [PATCH v4 3/4] usb: ffs: check quirk to pad epout buf size when not aligned to maxpacketsize

2013-11-05 Thread Cohen, David A
On 11/05/2013 06:52 AM, Alan Stern wrote: > On Mon, 4 Nov 2013, David Cohen wrote: > >> Check gadget.quirk_ep_out_aligned_size to decide if buffer size requires >> to be aligned to maxpacketsize of an out endpoint. ffs_epfile_io() needs >> to pad epout buffer to match above condition if quirk is f

Re: Need testers for long-standing xHCI clear halt bug

2013-11-05 Thread Bálint Sipter
Hi! We also did the testing and it's working for us too with only patch1 applied. Regards Bálint 2013/10/15 Sarah Sharp : > On Sat, Oct 12, 2013 at 09:25:17AM +0200, Marcus Meissner wrote: >> Hi Sarah, >> >> I built: >> >> - current kernel git with SUSE config >> - libgphoto2 with the clear_halt

Re: [PATCH v4 3/4] usb: ffs: check quirk to pad epout buf size when not aligned to maxpacketsize

2013-11-05 Thread Alan Stern
On Tue, 5 Nov 2013, David Cohen wrote: > >> + /* > >> + * Controller requires buffer size to be aligned to > >> + * maxpacketsize of an out endpoint. > >> + */ > >> + if (gadget->quirk_ep_out_aligned_size && read) { > >> + /* > >> +

Re: [PATCH v4 2/4] usb: gadget: add quirk_ep_out_aligned_size field to struct usb_gadget

2013-11-05 Thread Alan Stern
On Tue, 5 Nov 2013, David Cohen wrote: > >> +static inline size_t usb_ep_align_maxpacketsize(struct usb_ep *ep, size_t > >> len) > >> +{ > >> + int aligned; > >> + > >> + if (ep->desc->bmAttributes & USB_ENDPOINT_XFER_INT) > >> + /* > >> + * Interrupt eps don't need max packe

[PATCH v3 1/3] phy: Add new Exynos USB PHY driver

2013-11-05 Thread Kamil Debski
Add a new driver for the Exynos USB PHY. The new driver uses the generic PHY framework. The driver includes support for the Exynos 4x10 and 4x12 SoC families. Signed-off-by: Kamil Debski Signed-off-by: Kyungmin Park --- .../devicetree/bindings/phy/samsung-usbphy.txt | 52 drivers/phy

[PATCH v3 0/3] phy: Add new Exynos USB 2.0 PHY driver

2013-11-05 Thread Kamil Debski
Hi, This is the third version of the patchset adding the new Exynos USB 2.0 PHY driver, which uses the Generic PHY Framework. It contains numerous fixes and cleanups, which are the results of the feedback to the second version. Best wishes, Kamil Debski Changes from v2: - rebas

[PATCH v3 2/3] usb: ehci-s5p: Change to use phy provided by the generic phy framework

2013-11-05 Thread Kamil Debski
Change the phy provider used from the old usb phy specific to a new one using the generic phy framework. Signed-off-by: Kamil Debski Signed-off-by: Kyungmin Park --- drivers/usb/host/ehci-exynos.c | 34 +++--- 1 file changed, 11 insertions(+), 23 deletions(-) diff

[PATCH v3 3/3] usb: s3c-hsotg: Use the new Exynos USB phy driver with the generic phy framework

2013-11-05 Thread Kamil Debski
Change the used phy driver to the new Exynos USB phy driver that uses the generic phy framework. Signed-off-by: Kamil Debski Signed-off-by: Kyungmin Park --- drivers/usb/gadget/s3c-hsotg.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/usb/gadget/s3c-

[PATCH-v2] USB: ftdi_sio: fixed handling of unsupported CSIZE setting

2013-11-05 Thread Colin Leitner
FTDI UARTs support only 7 or 8 data bits. Until now the ftdi_sio driver would only report this limitation for CS6 to dmesg and fail to reflect this fact to tcgetattr. This patch reverts the unsupported CSIZE setting and reports the fact with less severance to dmesg for both CS5 and CS6. To test t

Re: [PATCH v3 1/2] libusbg: Moved mkdir functions, added MAX_LENGTH & MAX_PATH_LENGTH

2013-11-05 Thread Matt Porter
On Tue, Nov 05, 2013 at 03:22:53PM +0100, Stanislaw Wadas wrote: > mkdir() function is now performed after successful memory allocation > and gadget function creation. > Added inline to gadget_write_string(). > 256 hard coded value has been replaced by two defined > constants MAX_LENGTH and MAX_PAT

Re: [PATCH v3 2/2] libusbg: added fputs()/fgets() error handling

2013-11-05 Thread Matt Porter
On Tue, Nov 05, 2013 at 03:22:54PM +0100, Stanislaw Wadas wrote: > Error handling was added to fputs()/fgets() functions. > > Signed-off-by: Stanislaw Wadas > --- > Changes since v2: > - fixed code indentation > - removed unused variable ret > > Changes since v1: > - fixed typ

Re: [PATCH-v2] USB: ftdi_sio: fixed handling of unsupported CSIZE setting

2013-11-05 Thread Johan Hovold
On Tue, Nov 05, 2013 at 05:38:33PM +0100, Colin Leitner wrote: > FTDI UARTs support only 7 or 8 data bits. Until now the ftdi_sio driver would > only report this limitation for CS6 to dmesg and fail to reflect this fact to > tcgetattr. > > This patch reverts the unsupported CSIZE setting and repor

Re: [PATCH-v3] USB: ftdi_sio: fixed handling of unsupported CSIZE setting

2013-11-05 Thread Colin Leitner
FTDI UARTs support only 7 or 8 data bits. Until now the ftdi_sio driver would only report this limitation for CS6 to dmesg and fail to reflect this fact to tcgetattr. This patch reverts the unsupported CSIZE setting and reports the fact with less severance to dmesg for both CS5 and CS6. To test t

Re: [PATCH] usb: xhci: Optimise setup of isochronous transfers

2013-11-05 Thread Andiry Xu
On Tue, Nov 5, 2013 at 6:21 AM, David Laight wrote: > > Close inspection shows that xhci_queue_isoc_tx() can only fail if > prepare_transfer() gets an error from usb_hcd_link_urb_to_ep() for > the first TD. The call to prepare_ring() cannot fail because an initial > check is made to ensure the rin

Re: [PATCH RFC 1/4] phy: Add new Exynos5 USB 3.0 PHY driver

2013-11-05 Thread Vivek Gautam
Hi Kamil, On Tue, Nov 5, 2013 at 3:06 PM, Kamil Debski wrote: > Hi, > >> From: Vivek Gautam [mailto:gautamvivek1...@gmail.com] >> Sent: Tuesday, November 05, 2013 8:20 AM >> To: Kishon Vijay Abraham I >> Cc: Kamil Debski; Vivek Gautam; Linux USB Mailing List; linux-samsung- >> s...@vger.kernel.o

Re: [PATCH RFC 1/4] phy: Add new Exynos5 USB 3.0 PHY driver

2013-11-05 Thread Vivek Gautam
On Tue, Nov 5, 2013 at 5:33 PM, Jingoo Han wrote: > On Tuesday, November 05, 2013 8:13 PM, Jingoo Han wrote: >> On Tuesday, November 05, 2013 6:37 PM, Kamil Debski wrote: >> > On Tuesday, November 05, 2013 8:20 AM, Vivek Gautam wrote: >> > > On Mon, Nov 4, 2013 at 6:42 PM, Kishon Vijay Abraham I

Re: [PATCH] USB: pl2303: fixed handling of CS5 setting

2013-11-05 Thread Greg KH
On Mon, Nov 04, 2013 at 08:13:55PM +0100, Johan Hovold wrote: > On Mon, Nov 04, 2013 at 07:40:43PM +0100, Colin Leitner wrote: > > This patch fixes the CS5 setting on the PL2303 USB-to-serial devices. CS5 > > has a > > value of 0 and the CSIZE setting has been skipped altogether by the > > enclos

Re: [PATCH v2 1/7] usb: dwc3: get "usb_phy" only if the platform indicates the presence of PHY's

2013-11-05 Thread Vivek Gautam
Dear Kishon, Roger On Wed, Oct 16, 2013 at 6:40 PM, Kishon Vijay Abraham I wrote: > Hi roger, > > On Wednesday 16 October 2013 06:33 PM, Roger Quadros wrote: >> Hi Kishon, Apologies for missing this thread for so long. >> >> On 10/15/2013 10:54 PM, Kishon Vijay Abraham I wrote: >>> There can b

Re: [PATCH v2 1/7] usb: dwc3: get "usb_phy" only if the platform indicates the presence of PHY's

2013-11-05 Thread Vivek Gautam
On Tue, Nov 5, 2013 at 11:41 PM, Vivek Gautam wrote: > Dear Kishon, Roger > > > On Wed, Oct 16, 2013 at 6:40 PM, Kishon Vijay Abraham I wrote: >> Hi roger, >> >> On Wednesday 16 October 2013 06:33 PM, Roger Quadros wrote: >>> Hi Kishon, > > Apologies for missing this thread for so long. > >>> >>>

Re: [PATCH v4 3/4] usb: ffs: check quirk to pad epout buf size when not aligned to maxpacketsize

2013-11-05 Thread David Cohen
Hi Alan, On 11/05/2013 07:38 AM, Alan Stern wrote: > On Tue, 5 Nov 2013, David Cohen wrote: > + /* + * Controller requires buffer size to be aligned to + * maxpacketsize of an out endpoint. + */ + if (gadget->quirk_ep_out_al

Re: [PATCH v4 2/4] usb: gadget: add quirk_ep_out_aligned_size field to struct usb_gadget

2013-11-05 Thread David Cohen
On 11/05/2013 07:41 AM, Alan Stern wrote: > On Tue, 5 Nov 2013, David Cohen wrote: > +static inline size_t usb_ep_align_maxpacketsize(struct usb_ep *ep, size_t len) +{ + int aligned; + + if (ep->desc->bmAttributes & USB_ENDPOINT_XFER_INT) + /* +

Re: [PATCH v4 3/4] usb: ffs: check quirk to pad epout buf size when not aligned to maxpacketsize

2013-11-05 Thread Alan Stern
On Tue, 5 Nov 2013, David Cohen wrote: > Hi Alan, > > On 11/05/2013 07:38 AM, Alan Stern wrote: > > On Tue, 5 Nov 2013, David Cohen wrote: > > > +/* > + * Controller requires buffer size to be aligned to > + * maxpacketsize of an out

Re: [PATCH 5/7] IBM Akebono: Add support to the EHCI platform driver for Akebono

2013-11-05 Thread Benjamin Herrenschmidt
On Tue, 2013-11-05 at 10:04 -0500, Alan Stern wrote: > On Tue, 5 Nov 2013, Alistair Popple wrote: > > > The IBM Akebono board has an EHCI compliant USB host interface. This > > patch adds support for it to the EHCI platform driver. > > > > Signed-off-by: Alistair Popple > > Cc: Alan Stern > > C

Re: [PATCH] usb: phy: Move R-Car Gen2 driver registration to postcore_inictall

2013-11-05 Thread Valentine
On 11/01/2013 07:55 PM, Alan Stern wrote: On Fri, 1 Nov 2013, Valentine wrote: The USB HDC PCI deferred probing could be used on R-Car. But I'm not sure how to make a particular PCI USB HDC device attached to a particular PCI host controller on a particular SoC defer its probing while waiting

Re: [PATCH net-next v6 0/3] The huawei_cdc_ncm driver

2013-11-05 Thread David Miller
From: Bjørn Mork Date: Mon, 4 Nov 2013 09:50:46 +0100 > Enrico has been kind enough to let me repost his driver with the changes > requested by Oliver Neukum during the last review of this series. > > The changes I have made from Enricos original v5 series to this version > are: > > v6: > - f

re: USB: EHCI: create per-TT bandwidth tables

2013-11-05 Thread Dan Carpenter
Hello Alan Stern, The patch b35c5009bbf6: "USB: EHCI: create per-TT bandwidth tables" from Oct 11, 2013, leads to the following static checker warning: "drivers/usb/host/ehci-sched.c:1377 reserve_release_iso_bandwidth() error: 'tt' dereferencing possible ERR_PTR()" drivers/usb/host/ehc

[RFC PATCH 1/2] usb: hcd: Remove USB phy if needed

2013-11-05 Thread Valentine Barshak
This adds remove_phy flag to the HCD structure. If the flag is set and if hcd->phy is valid, the phy is shutdown and released whenever usb_add_hcd fails or usb_hcd_remove is called. This can be used by the HCD drivers to auto-remove the external USB phy when it is no longer needed. Signed-off-by:

[RFC PATCH 2/2] usb: hcd: Introduce CONFIG_USB_HCD_EXTERNAL_PHY option

2013-11-05 Thread Valentine Barshak
This adds external USB phy support to USB HCD driver that allows to find and initialize external USB phy, bound to the HCD when the HCD is added. The usb_add_hcd function returns -EPROBE_DEFER if the USB phy, bound to the HCD, is not ready. If no USB phy is bound, the HCD is initialized as usual.

[RFC PATCH 0/2] Defer HCD init until the external PHY, bound to the HCD is ready

2013-11-05 Thread Valentine Barshak
This adds remove_phy flag to the HCD structure. If the flag is set and if hcd->phy is valid, the phy is shutdown and released whenever usb_add_hcd fails or usb_hcd_remove is called. This also adds CONFIG_USB_HCD_EXTERNAL_PHY option that allows the HCD driver to search for a USB phy, bound to the HC

Re: [PATCH v3 08/11] usb: phy-mxs: Enable IC fixes for related SoCs

2013-11-05 Thread Michał Mirosław
2013/11/5 Peter Chen > > Some PHY bugs are fixed by IC logic, but these bits are not > enabled by default, so we enable them at driver. > > Signed-off-by: Peter Chen > --- > drivers/usb/phy/phy-mxs-usb.c | 32 ++-- > 1 files changed, 30 insertions(+), 2 deletions(-)

CDC-ACM device issue

2013-11-05 Thread Luke-Jr
I am trying to interface with the "HEX" devices sold by http://technobit.eu/ which appear as CDC-ACM devices, but give an I/O error whenever I try to open them, with some rather unclear error description in dmesg: [10526714.860052] usb 5-2: new full-speed USB device number 4 using uhci_hcd [1052

Re: [PATCH v4 2/4] usb: gadget: add quirk_ep_out_aligned_size field to struct usb_gadget

2013-11-05 Thread David Cohen
On 11/05/2013 10:13 AM, David Cohen wrote: On 11/05/2013 07:41 AM, Alan Stern wrote: On Tue, 5 Nov 2013, David Cohen wrote: +static inline size_t usb_ep_align_maxpacketsize(struct usb_ep *ep, size_t len) +{ + int aligned; + + if (ep->desc->bmAttributes & USB_ENDPOINT_XFER_INT) +

Re: Large USB HID transfers

2013-11-05 Thread Cliff Brake
On Tue, Nov 5, 2013 at 9:57 AM, Alan Stern wrote: > On Mon, 4 Nov 2013, Cliff Brake wrote: > >> >> I assume interrupts are disabled during both ohci_irq() and ehci_irq(). > > Currently they are. This will change somewhat in the not-too-distant > future. Are there any patches available yet for t

Re: [PATCH v3] kconfig/symbol.c: handle choice_values that depend on 'm' symbols

2013-11-05 Thread Yann E. MORIN
Dirk, All, On 2013-11-01 00:39 +0100, Dirk Gouders spake thusly: > If choices consist of choice_values that depend on symbols set to 'm', > those choice_values are not set to 'n' if the choice is changed from > 'm' to 'y' (in which case only one active choice_value is allowed). > Those values are

[PATCH v4.1 2/4] usb: gadget: add quirk_ep_out_aligned_size field to struct usb_gadget

2013-11-05 Thread David Cohen
Due to USB controllers may have different restrictions, usb gadget layer needs to provide a generic way to inform gadget functions to complain with non-standard requirements. This patch adds 'quirk_ep_out_aligned_size' field to struct usb_gadget to inform when controller's epout requires buffer si

Re: [PATCH RFC 1/4] phy: Add new Exynos5 USB 3.0 PHY driver

2013-11-05 Thread Jingoo Han
On Wednesday, November 06, 2013 2:58 AM, Vivek Gautam wrote: > On Tue, Nov 5, 2013 at 5:33 PM, Jingoo Han wrote: [.] >> USB3.0 PHY consists of two blocks such as 3.0 block and 2.0 block. >> This USB3.0 PHY can support UTMI+ and PIPE3 interface for 3.0 block >> and 2.0 block, respectively. >>

Re: [PATCH v3 1/3] phy: Add new Exynos USB PHY driver

2013-11-05 Thread Jingoo Han
On Wednesday, November 06, 2013 1:13 AM, Kamil Debski wrote: > > Add a new driver for the Exynos USB PHY. The new driver uses the generic > PHY framework. The driver includes support for the Exynos 4x10 and 4x12 > SoC families. > > Signed-off-by: Kamil Debski > Signed-off-by: Kyungmin Park > --

Re: [PATCH v3 2/3] usb: ehci-s5p: Change to use phy provided by the generic phy framework

2013-11-05 Thread Jingoo Han
On Wednesday, November 06, 2013 1:13 AM, Kamil Debski wrote: > > Change the phy provider used from the old usb phy specific to a new one > using the generic phy framework. > > Signed-off-by: Kamil Debski > Signed-off-by: Kyungmin Park > --- > drivers/usb/host/ehci-exynos.c | 34 +++--

[PATCH] usb: ohci-exynos: Change to use phy provided by the generic phy framework

2013-11-05 Thread Jingoo Han
Change the phy provider used from the old usb phy specific to a new one using the generic phy framework. Signed-off-by: Jingoo Han Cc: Kamil Debski --- Exynos OHCI driver also uses Exynos USB2.0 PHY. Thus, I make this patch based-on Kamil Debski's patchset for adding Exynos USB 2.0 PHY driver. (

Re: [PATCH 5/7] IBM Akebono: Add support to the EHCI platform driver for Akebono

2013-11-05 Thread Alistair Popple
On Wed, 6 Nov 2013 06:52:13 Benjamin Herrenschmidt wrote: [snip] > > Why ? Do we need to add an entry for every platform in there ? Besides, > it probably should be the SoC name not the platform here > > Why not simply a generic compatible "usb-ehci" ? It's a standard > programming interfac

Re: [PATCH 5/7] IBM Akebono: Add support to the EHCI platform driver for Akebono

2013-11-05 Thread Benjamin Herrenschmidt
On Wed, 2013-11-06 at 14:50 +1100, Alistair Popple wrote: > Actually a grep of "usb-ehci" turns up the ehci-ppc-of driver which I somehow > missed. This driver works and uses .compatible = "usb-ehci" so I can use that > instead if that is preferable? > > However it is basically the same as the e

[RFC PATCH] ehci-platform: Merge ppc-of EHCI driver into the ehci-platform driver

2013-11-05 Thread Alistair Popple
Currently the ppc-of driver uses the compatibility string "usb-ehci". This means platforms that use device-tree and implement an EHCI compatible interface have to either use the ppc-of driver or add a compatible line to the ehci-platform driver. It would be more appropriate for the platform driver

Re: [PATCH v3 08/11] usb: phy-mxs: Enable IC fixes for related SoCs

2013-11-05 Thread Peter Chen
On Tue, Nov 05, 2013 at 10:02:35PM +0100, Michał Mirosław wrote: > 2013/11/5 Peter Chen > > > > Some PHY bugs are fixed by IC logic, but these bits are not > > enabled by default, so we enable them at driver. > > > > Signed-off-by: Peter Chen > > --- > > drivers/usb/phy/phy-mxs-usb.c | 32