[PATCH] usb/hcd: remove unnecessary local_irq_save

2013-10-13 Thread Michael Opdenacker
Remove the use of local_irq_save() and IRQF_DISABLED, no longer needed since interrupt handlers are always run with interrupts disabled on the current CPU. Tested successfully with 3.12.0-rc4 on my PC. Didn't find any issue because of this change. Signed-off-by: Michael Opdenacker --- drivers/u

Re: how to trigger function in usb_device_pm_ops

2013-10-13 Thread yoma sophian
hi alan: 2013/10/7 Alan Stern : > On Mon, 7 Oct 2013, yoma sophian wrote: > >> >> 1. When will platform register dev_pm_ops be called? Is it called >> >> before or after usb_device_pm_ops ? >> > >> > The platform suspend routine is called after the USB suspend routine. >> > The platform resume rou

Re: LTE vodafone K5150 (hilink) 12d1 1f16 ; 12d1 1575 cdc_ether mbim?

2013-10-13 Thread Thomas Schäfer
Am Mittwoch, 9. Oktober 2013, 23:29:49 schrieb Bjørn Mork: > >> will show you a number of interesting debug sites which can be enabled > >> without rebuilding anything. See Documentation/dynamic-debug-howto.txt > >> for details on how to use this. > I played a little bit with it, but there are

Re: LTE vodafone K5150 (hilink) 12d1 1f16 ; 12d1 1575 cdc_ether mbim?

2013-10-13 Thread Bjørn Mork
Thomas Schäfer writes: > Am Samstag, 12. Oktober 2013, 13:46:19 schrieben Sie: >> So the questions still are: Do you see those solicitatins going from the >> driver to the IP layer? And do you see any Neighbor Advertisement >> replies from the IP layer? If the respective answers are yes/no, the

Re: how to trigger function in usb_device_pm_ops

2013-10-13 Thread Alan Stern
On Sun, 13 Oct 2013, yoma sophian wrote: > >> if so, how driver decide to use which hcd when Super/Non-Super speed > >> devices plug in? > > > > Simple: When a SuperSpeed device plugs in, the driver uses the > > SuperSpeed hcd. When a non-SuperSpeed device plugs in, the driver uses > > the non-Su

Re: [PATCH] usb/hcd: remove unnecessary local_irq_save

2013-10-13 Thread Alan Stern
On Sun, 13 Oct 2013, Michael Opdenacker wrote: > Remove the use of local_irq_save() and IRQF_DISABLED, no longer needed since > interrupt handlers are always run with interrupts disabled on the > current CPU. > > Tested successfully with 3.12.0-rc4 on my PC. Didn't find > any issue because of thi

Re: LTE vodafone K5150 (hilink) 12d1 1f16 ; 12d1 1575 cdc_ether mbim?

2013-10-13 Thread Bjørn Mork
Bjørn Mork writes: > I see no answers to the NS there, so I assume that's the reason this > does not work. Stupid me. My testing was bogus because I switched on/off the IFF_NOARP without adding/deleting addresses. Reading the code is better... We are not supposed to answer these solictiations

Re: LTE vodafone K5150 (hilink) 12d1 1f16 ; 12d1 1575 cdc_ether mbim?

2013-10-13 Thread Bjørn Mork
Bjørn Mork writes: > void addrconf_join_solict(struct net_device *dev, const struct in6_addr *addr) > { > struct in6_addr maddr; > > if (dev->flags&(IFF_LOOPBACK|IFF_NOARP)) > return; > > addrconf_addr_solict_mult(addr, &maddr); > ipv6_dev_mc_inc(dev, &maddr)

[PATCH V3] USB: ohci-exynos: Remove non-DT support

2013-10-13 Thread Jingoo Han
The non-DT for EXYNOS SoCs is not supported from v3.11. Thus, there is no need to support non-DT for Exynos OHCI driver. The 'include/linux/platform_data/usb-ohci-exynos.h' file has been used for non-DT support. Thus, the 'usb-ohci-exynos.h' file can be removed. Signed-off-by: Jingoo Han --- - r

Re: [PATCH 10/11] usb: chipidea: imx: add binding for supporting runtime pm

2013-10-13 Thread Peter Chen
On Sat, Oct 12, 2013 at 10:40:37AM -0400, Alan Stern wrote: > On Sat, 12 Oct 2013, Peter Chen wrote: > > > Add property for supporting runtime power management > > > > Signed-off-by: Peter Chen > > --- > > .../devicetree/bindings/usb/ci13xxx-imx.txt|2 ++ > > 1 files changed, 2 inse

Re: [PATCH 10/11] usb: chipidea: imx: add binding for supporting runtime pm

2013-10-13 Thread Marek Vasut
Dear Peter Chen, > On Sat, Oct 12, 2013 at 10:40:37AM -0400, Alan Stern wrote: > > On Sat, 12 Oct 2013, Peter Chen wrote: > > > Add property for supporting runtime power management > > > > > > Signed-off-by: Peter Chen > > > --- > > > > > > .../devicetree/bindings/usb/ci13xxx-imx.txt|

Re: [PATCH 02/12] usb: phy-mxs: Enable IC fixes for mx6 SoC serial

2013-10-13 Thread Peter Chen
On Sat, Oct 12, 2013 at 11:38:16AM +0200, Marek Vasut wrote: > Hi, > > > After adding IC fixes bits, some PHY bugs are fixed by > > IC logic. > > Can you please elaborate what those bits do exactly ? They seem like a magic > stuff to me thus far, which is not exactly helpful . I can't find them

Re: [PATCH 10/11] usb: chipidea: imx: add binding for supporting runtime pm

2013-10-13 Thread Peter Chen
On Mon, Oct 14, 2013 at 03:39:36AM +0200, Marek Vasut wrote: > Dear Peter Chen, > > > On Sat, Oct 12, 2013 at 10:40:37AM -0400, Alan Stern wrote: > > > On Sat, 12 Oct 2013, Peter Chen wrote: > > > > Add property for supporting runtime power management > > > > > > > > Signed-off-by: Peter Chen >

Re: [PATCH 05/12] usb: phy-mxs: Add implementation of nofity_suspend and notify_resume

2013-10-13 Thread Peter Chen
On Sat, Oct 12, 2013 at 11:42:06AM +0200, Marek Vasut wrote: > Dear Peter Chen, > > > Add notify_suspend and notify_resume according to different SoCs. > > > > Signed-off-by: Peter Chen > > --- > > drivers/usb/phy/phy-mxs-usb.c | 73 > > + 1 files change

Re: [PATCH 07/12] usb: phy-mxs: Add implementation of set_wakeup

2013-10-13 Thread Peter Chen
On Sat, Oct 12, 2013 at 11:44:59AM +0200, Marek Vasut wrote: > > > +static int mxs_phy_set_wakeup(struct usb_phy *x, bool enabled) > > +{ > > + struct mxs_phy *mxs_phy = to_mxs_phy(x); > > + u32 value = BM_USBPHY_CTRL_ENVBUSCHG_WKUP | > > + BM_USBPHY_CTRL_ENDPDMCHG_WKUP | > >

Re: [PATCH 11/12] usb: phy-mxs: update binding for adding disconnect line property

2013-10-13 Thread Peter Chen
On Sat, Oct 12, 2013 at 11:47:06AM +0200, Marek Vasut wrote: > Dear Peter Chen, > > > This property is used to disconnect line between USB PHY and > > USB controller. > > > > Signed-off-by: Peter Chen > > --- > > Documentation/devicetree/bindings/usb/mxs-phy.txt |4 > > 1 files changed

Re: [PATCH 11/12] usb: phy-mxs: update binding for adding disconnect line property

2013-10-13 Thread Peter Chen
On Sat, Oct 12, 2013 at 05:05:23PM +0200, Thomas Petazzoni wrote: > Dear Peter Chen, > > On Sat, 12 Oct 2013 17:09:45 +0800, Peter Chen wrote: > > This property is used to disconnect line between USB PHY and > > USB controller. > > > > Signed-off-by: Peter Chen > > --- > > Documentation/devicet

Re: [PATCH 02/12] usb: phy-mxs: Enable IC fixes for mx6 SoC serial

2013-10-13 Thread Marek Vasut
Dear Peter Chen, > On Sat, Oct 12, 2013 at 11:38:16AM +0200, Marek Vasut wrote: > > Hi, > > > > > After adding IC fixes bits, some PHY bugs are fixed by > > > IC logic. > > > > Can you please elaborate what those bits do exactly ? They seem like a > > magic stuff to me thus far, which is not exa

Re: [PATCH 05/12] usb: phy-mxs: Add implementation of nofity_suspend and notify_resume

2013-10-13 Thread Marek Vasut
Dear Peter Chen, > On Sat, Oct 12, 2013 at 11:42:06AM +0200, Marek Vasut wrote: > > Dear Peter Chen, > > > > > Add notify_suspend and notify_resume according to different SoCs. > > > > > > Signed-off-by: Peter Chen > > > --- > > > > > > drivers/usb/phy/phy-mxs-usb.c | 73 > > > > > > ++

Re: [PATCH 02/12] usb: phy-mxs: Enable IC fixes for mx6 SoC serial

2013-10-13 Thread Peter Chen
On Mon, Oct 14, 2013 at 04:07:10AM +0200, Marek Vasut wrote: > Dear Peter Chen, > > > On Sat, Oct 12, 2013 at 11:38:16AM +0200, Marek Vasut wrote: > > > Hi, > > > > > > > After adding IC fixes bits, some PHY bugs are fixed by > > > > IC logic. > > > > > > Can you please elaborate what those bits

Re: [PATCH] usb/hcd: remove unnecessary local_irq_save

2013-10-13 Thread Michael Opdenacker
Hi Alan, On 10/13/2013 05:35 PM, Alan Stern wrote: > On Sun, 13 Oct 2013, Michael Opdenacker wrote: > >> Remove the use of local_irq_save() and IRQF_DISABLED, no longer needed since >> interrupt handlers are always run with interrupts disabled on the >> current CPU. >> >> Tested successfully with