Re: [PATCH 3/5] USB: ehci-exynos: Remove non-DT support

2013-10-10 Thread Jingoo Han
On Thursday, October 10, 2013 3:49 PM, Sachin Kamat wrote: > On 10 October 2013 12:01, Jingoo Han wrote: > > The non-DT for EXYNOS SoCs is not supported from v3.11. > > Thus, there is no need to support non-DT for Exynos EHCI driver. > > > > The 'include/linux/platform_data/usb-ehci-exynos.h' file

[PATCH V2 0/5] USB: host: Remove non-DT support for Exynos EHCI and OHCI

2013-10-10 Thread Jingoo Han
This patchset removes non-DT support for Exynos EHCI and OHCI from arch and driver directories, because the non-DT for EXYNOS SoCs is not supported from v3.11. Also, missing usb_put_hcd() is added to prevent memory leak. In order to keep the consistency, ehci-s5p.c is changed to ehci-exynos.c. So,

[PATCH V2 1/5] ARM: SAMSUNG: Remove unused s5p_device_ehci

2013-10-10 Thread Jingoo Han
Since commit ca91435 "ARM: EXYNOS: Remove unused board files", s5p_device_ehci is not used anymore. Thus, s5p_device_ehci can be removed. Also, unnecessary S5P_DEV_USB_EHCI option is removed. Signed-off-by: Jingoo Han Reviewed-by: Sylwester Nawrocki --- arch/arm/plat-samsung/Kconfig

[PATCH V2 3/5] USB: ohci-exynos: Remove non-DT support

2013-10-10 Thread Jingoo Han
The non-DT for EXYNOS SoCs is not supported from v3.11. Thus, there is no need to support non-DT for Exynos OHCI driver. The 'include/linux/platform_data/usb-ohci-exynos.h' file has been used for non-DT support. Thus, the 'usb-ohci-exynos.h' file can be removed. Signed-off-by: Jingoo Han --- dr

Re: Cannot load snd-usb-audio on 3.12-rc2

2013-10-10 Thread Takashi Iwai
At Wed, 9 Oct 2013 13:01:08 -0700, Sarah Sharp wrote: > > On Thu, Sep 26, 2013 at 10:36:29AM +0200, Takashi Iwai wrote: > > At Mon, 23 Sep 2013 16:41:07 -0700, > > Sarah Sharp wrote: > > > > > > The snd-usb-audio driver no longer loads properly on 3.12-rc2 when I > > > plug in my USB headset. It

[PATCH V2 2/5] USB: ehci-s5p: Remove non-DT support

2013-10-10 Thread Jingoo Han
The non-DT for EXYNOS SoCs is not supported from v3.11. Thus, there is no need to support non-DT for Exynos EHCI driver. The 'include/linux/platform_data/usb-ehci-s5p.h' file has been used for non-DT support. Thus, the 'usb-ehci-s5p.h' file can be removed. Signed-off-by: Jingoo Han --- drivers/

[PATCH V2 5/5] USB: host: Rename ehci-s5p to ehci-exynos

2013-10-10 Thread Jingoo Han
Currently, Samsung is using 'EXYNOS' as the name of Samsung SoCs. Thus, ehci-exynos is preferred than ehci-s5p. Signed-off-by: Jingoo Han --- drivers/usb/host/Kconfig |5 +- drivers/usb/host/Makefile |2 +- drivers/usb/host/{ehci-s5p.c => ehci-e

[PATCH V2 4/5] USB: ohci-exynos: Add missing usb_put_hcd()

2013-10-10 Thread Jingoo Han
When devm_usb_get_phy() fails, usb_put_hcd() should be called to prevent memory leak. Signed-off-by: Jingoo Han --- drivers/usb/host/ohci-exynos.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/host/ohci-exynos.c b/drivers/usb/host/ohci-exynos.c index 5c877bf..aa50e18 100644

Re: LTE vodafone K5150 (hilink) 12d1 1f16 ; 12d1 1575 cdc_ether mbim?

2013-10-10 Thread Thomas Schäfer
> OK, so it didn't switch at all. Then we are back to usb_modeswitch > failure (or more likely: missing config for this device). > > You could test switching it manually: > > echo 2 > /sys/bus/usb/devices/1-2/bConfigurationValue This was the point! [ 4007.213187] usb 1-2: new high-speed US

Re: [PATCH v3] usb-serial: Moxa UPORT 12XX/14XX/16XX driver

2013-10-10 Thread Johan Hovold
On Wed, Oct 09, 2013 at 09:54:54PM +0200, Andrew Lunn wrote: > On Wed, Oct 09, 2013 at 07:27:42PM +0200, Johan Hovold wrote: > > This should probably remain a device-specific parameter. We already have > > the MOXA mxser-driver with similar configuration options. This one uses > > a custom ioctl t

Re: [PATCH v2 5/6] Revert "ARM: OMAP2+: Provide alias to USB PHY clock"

2013-10-10 Thread Roger Quadros
On 10/09/2013 06:15 PM, Tony Lindgren wrote: > * Roger Quadros [131009 00:19]: >> Hi Tony, >> >> On 10/08/2013 01:06 PM, Roger Quadros wrote: >>> This reverts commit 741532c4a995be11815cb72d4d7a48f442a22fea. >>> >>> The proper clock reference is provided in device tree so we >>> no longer need thi

Re: [PATCH v2 6/6] mfd: omap-usb: prepare/unprepare clock while enable/disable

2013-10-10 Thread Roger Quadros
Hi Samuel, Could you please pick this one for 3.13 if OK? Thanks. cheers, -roger On 10/08/2013 01:06 PM, Roger Quadros wrote: > This should fix the following warning at boot on OMAP5 uEVM > [8.783155] WARNING: CPU: 0 PID: 1 at drivers/clk/clk.c:883 > __clk_enable+0x94/0xa4() > > CC: Samuel

Re: LTE vodafone K5150 (hilink) 12d1 1f16 ; 12d1 1575 cdc_ether mbim?

2013-10-10 Thread Bjørn Mork
Thomas Schäfer writes: > hpmini:~ # sudo mbimcli -d /dev/cdc-wdm0 --basic-connect-query-device-services > [/dev/cdc-wdm0] Device services retrieved: > Max DSS sessions: '5' OK... > Max DSS instances: 0 but no services support DSS. This is exactly like the E367. Seems

Re: [PATCH 2/7] usb: dwc3: adapt dwc3 core to use Generic PHY Framework

2013-10-10 Thread Kishon Vijay Abraham I
On Thursday 12 September 2013 03:57 PM, Vivek Gautam wrote: > On Thu, Sep 12, 2013 at 3:40 PM, Kishon Vijay Abraham I wrote: >> On Thursday 12 September 2013 02:57 PM, Vivek Gautam wrote: >>> Hi Kishon, >>> >>> >>> On Mon, Sep 2, 2013 at 9:13 PM, Kishon Vijay Abraham I >>> wrote: Adapted dw

Re: [PATCH] usbnet: smsc95xx: Add device tree input for MAC address

2013-10-10 Thread Dan Murphy
Ming On 10/07/2013 06:42 AM, Ming Lei wrote: > On Mon, Oct 7, 2013 at 1:31 AM, Dan Murphy wrote: >> On 10/06/2013 10:05 AM, Ming Lei wrote: >>> On Sat, Oct 5, 2013 at 2:25 AM, Dan Murphy wrote: If the smsc95xx does not have a valid MAC address stored within the eeprom then a random num

Re: [PATCH] usbnet: smsc95xx: Add device tree input for MAC address

2013-10-10 Thread Ming Lei
On Thu, Oct 10, 2013 at 8:08 PM, Dan Murphy wrote: > > You are correct I don't expect a match for PnP devices only devices that are > hard wired. > > After thinking of it I should move the OF code below the EEPROM code as the > EEPROM should take preference over the DT code. > > I will need to p

Re: [PATCH] usbnet: smsc95xx: Add device tree input for MAC address

2013-10-10 Thread Dan Murphy
On 10/10/2013 07:39 AM, Ming Lei wrote: > On Thu, Oct 10, 2013 at 8:08 PM, Dan Murphy wrote: >> You are correct I don't expect a match for PnP devices only devices that are >> hard wired. >> >> After thinking of it I should move the OF code below the EEPROM code as the >> EEPROM should take pref

Re: [PATCH 1/2] xhci: fix reset for not halted endpoints

2013-10-10 Thread Xenia Ragiadakou
On 10/07/2013 06:52 PM, Xenia Ragiadakou wrote: [snip] +static int xhci_reset_ep0(struct xhci_hcd *xhci, struct usb_device *udev, + struct usb_host_endpoint *ep) +{ + struct xhci_virt_device *vdev; + struct xhci_input_control_ctx *ctrl_ctx; + struct xhci_slot_ctx

Re: Switching OMAP2430 MUSB between host and device mode

2013-10-10 Thread Felipe Balbi
On Tue, Oct 08, 2013 at 10:28:29AM -0400, Alan Stern wrote: > Felipe: > > I've got an Android device that uses the omap2430 musb driver. It's > configured to go into device mode when it starts up, which I guess is > the normal thing for Android devices to do. > > Can you explain how to switch th

Re: [PATCH 1/3] usb: phy: Add RCAR Gen2 USB phy

2013-10-10 Thread Felipe Balbi
On Wed, Oct 09, 2013 at 10:32:12PM +0200, Laurent Pinchart wrote: > Hi Valentine, > > Thank you for the patch. > > On Tuesday 08 October 2013 23:43:25 Valentine Barshak wrote: > > This adds RCAR Gen2 USB phy support. The driver configures > > USB channels 0/2 which are shared between PCI USB host

Re: [PATCH 1/3] usb: phy: Add RCAR Gen2 USB phy

2013-10-10 Thread Felipe Balbi
Hi, On Thu, Oct 10, 2013 at 01:21:27AM +0400, Valentine wrote: > On 10/10/2013 12:32 AM, Laurent Pinchart wrote: > >Hi Valentine, > > > > Hi Laurent, > > >Thank you for the patch. > > > >On Tuesday 08 October 2013 23:43:25 Valentine Barshak wrote: > >>This adds RCAR Gen2 USB phy support. The dri

Re: [PATCH 1/3] usb: phy: Add RCAR Gen2 USB phy

2013-10-10 Thread Felipe Balbi
Hi, On Thu, Oct 10, 2013 at 01:47:26AM +0400, Valentine wrote: > >>>I would use either > >>> > >>> depends on ARM > >>> > >>>or > >>> > >>> depends on ARCH_R8A7790 || ARCH_R8A7791 || COMPILE_TEST > >>> > >>>(assuming the driver can compile on non-ARM platforms, otherwise the above > >>>line co

Re: [PATCH 1/3] usb: phy: Add RCAR Gen2 USB phy

2013-10-10 Thread Felipe Balbi
Hi, On Thu, Oct 10, 2013 at 02:14:45AM +0400, Valentine Barshak wrote: > This adds RCAR Gen2 USB phy support. The driver configures > USB channels 0/2 which are shared between PCI USB hosts and > USBHS/USBSS devices. It also controls internal USBHS phy. > > Signed-off-by: Valentine Barshak > ---

Re: [PATCH 2/5] usb: gadget: s3c-hsotg: support configurable UTMI PHY width

2013-10-10 Thread Felipe Balbi
On Mon, Oct 07, 2013 at 06:12:29AM -0400, Matt Porter wrote: > Extend dwc2 binding with an optional utmi phy width property. > Enable the s3c-hsotg.c driver to use standard dwc2 binding > and enable configuration of the UTMI phy width based on the > property. > > Signed-off-by: Matt Porter > Revi

Re: [PATCH 3/5] usb: phy: add Broadcom Kona USB control driver

2013-10-10 Thread Felipe Balbi
Hi, On Mon, Oct 07, 2013 at 06:12:30AM -0400, Matt Porter wrote: > Broadcom BCM281xx parts have a PHY control block that > operates in conjunction with the DWC2 USB OTG. This driver > exposes an API that allows control of power/reset for a > connected USB PHY. > > Signed-off-by: Matt Porter > Re

Re: [PATCH] ARM: dts: omap3-beagle: Adapt USB OTG to generic PHY framework

2013-10-10 Thread Felipe Balbi
On Mon, Oct 07, 2013 at 01:46:50PM +0300, Roger Quadros wrote: > The generic PHY framewrok expects different properties than the > old USB PHY framework. Supply those properties. > > Fixes USB OTG port on beagle after the Generic PHY framework was > merged in greg/usb-next. [1] > > [1] - https://

Re: [PATCH 1/1] ARM: dts: omap3: Adapt USB OTG to generic PHY framework

2013-10-10 Thread Felipe Balbi
On Mon, Oct 07, 2013 at 04:28:13PM +0300, Roger Quadros wrote: > The generic PHY framewrok expects different properties than the > old USB PHY framework. Supply those properties. > > Fixes USB OTG port on GAT04 and N900 after the Generic PHY framework was > merged in greg/usb-next. [1] > > [1] -

Re: [PATCH] usb: gadget: Add UDC driver for Aeroflex Gaisler GRUSBDC

2013-10-10 Thread Felipe Balbi
Hi, On Wed, Oct 02, 2013 at 10:52:06AM +0200, Andreas Larsson wrote: > >hmm, there are two ways to look at this. > > > >a) we have KERN_CONT to continue printing messages > >b) you might prefer using debugfs and seq_puts() for dumping large(-ish) > >amounts of debugging data ;-) > > I just found

Re: [PATCH 2/4] usb: musb: add a type to each dma engine

2013-10-10 Thread Felipe Balbi
Hi, sorry for the delay... On Wed, Oct 02, 2013 at 03:07:25PM +0200, Sebastian Andrzej Siewior wrote: > > On Tue, Aug 13, 2013 at 07:49:43PM +0200, Sebastian Andrzej Siewior > > wrote: > >> This patch defines four types of current supported DMA engines > >> and assignes them to each dma engine. T

Re: Switching OMAP2430 MUSB between host and device mode

2013-10-10 Thread Huang Rui
Hi Felipe, On Thu, Oct 10, 2013 at 10:10:52AM -0500, Felipe Balbi wrote: > On Tue, Oct 08, 2013 at 10:28:29AM -0400, Alan Stern wrote: > > Felipe: > > > > I've got an Android device that uses the omap2430 musb driver. It's > > configured to go into device mode when it starts up, which I guess is

Re: Switching OMAP2430 MUSB between host and device mode

2013-10-10 Thread Alan Stern
On Thu, 10 Oct 2013, Felipe Balbi wrote: > On Tue, Oct 08, 2013 at 10:28:29AM -0400, Alan Stern wrote: > > Felipe: > > > > I've got an Android device that uses the omap2430 musb driver. It's > > configured to go into device mode when it starts up, which I guess is > > the normal thing for Androi

Re: [PATCH v3] USB: gadget: s3c-hsotg: add isochronous transfers support

2013-10-10 Thread Felipe Balbi
Hi, On Wed, Oct 09, 2013 at 08:41:57AM +0200, Robert Baldyga wrote: > @@ -2616,14 +2630,19 @@ static int s3c_hsotg_ep_enable(struct usb_ep *ep, > s3c_hsotg_set_ep_maxpacket(hsotg, hs_ep->index, mps); > > /* default, set to non-periodic */ > + hs_ep->isochronous = 0; > hs_ep

Re: Switching OMAP2430 MUSB between host and device mode

2013-10-10 Thread Felipe Balbi
Hi, On Thu, Oct 10, 2013 at 11:49:17AM -0400, Alan Stern wrote: > On Thu, 10 Oct 2013, Felipe Balbi wrote: > > > On Tue, Oct 08, 2013 at 10:28:29AM -0400, Alan Stern wrote: > > > Felipe: > > > > > > I've got an Android device that uses the omap2430 musb driver. It's > > > configured to go into

Re: Switching OMAP2430 MUSB between host and device mode

2013-10-10 Thread Felipe Balbi
HI, On Thu, Oct 10, 2013 at 11:45:47PM +0800, Huang Rui wrote: > On Thu, Oct 10, 2013 at 10:10:52AM -0500, Felipe Balbi wrote: > > On Tue, Oct 08, 2013 at 10:28:29AM -0400, Alan Stern wrote: > > > Felipe: > > > > > > I've got an Android device that uses the omap2430 musb driver. It's > > > confi

[PATCH 1/2] usb: musb: cancel work on removal

2013-10-10 Thread Sebastian Andrzej Siewior
So I captured this: |WARNING: CPU: 0 PID: 2078 at /home/bigeasy/work/new/TI/linux/lib/debugobjects.c:260 debug_print_object+0x94/0xc4() |ODEBUG: free active (active state 0) object type: work_struct hint: musb_irq_work+0x0/0x38 [musb_hdrc] |CPU: 0 PID: 2078 Comm: rmmod Not tainted 3.12.0-rc4+ #

[RFC 2/2] usb: musb: start musb on the udc side, too

2013-10-10 Thread Sebastian Andrzej Siewior
I have am335x-evm with one port running in OTG mode. Since commit fe4cb09 ("usb: musb: gadget: remove hcd initialization") the loaded gadget does non pop up on the host. All I see is |usb 4-5: new high-speed USB device number 52 using ehci-pci |usb 4-5: device descriptor read/64, error -110 A few

Re: [PATCH 1/3] usb: phy: Add RCAR Gen2 USB phy

2013-10-10 Thread Valentine
On 10/10/2013 07:23 PM, Felipe Balbi wrote: Hi, On Thu, Oct 10, 2013 at 02:14:45AM +0400, Valentine Barshak wrote: This adds RCAR Gen2 USB phy support. The driver configures USB channels 0/2 which are shared between PCI USB hosts and USBHS/USBSS devices. It also controls internal USBHS phy. Si

Re: [PATCH 1/3] usb: phy: Add RCAR Gen2 USB phy

2013-10-10 Thread Felipe Balbi
Hi, On Thu, Oct 10, 2013 at 08:29:43PM +0400, Valentine wrote: > On 10/10/2013 07:23 PM, Felipe Balbi wrote: > >Hi, > > > >On Thu, Oct 10, 2013 at 02:14:45AM +0400, Valentine Barshak wrote: > >>This adds RCAR Gen2 USB phy support. The driver configures > >>USB channels 0/2 which are shared between

Re: [RFC 2/2] usb: musb: start musb on the udc side, too

2013-10-10 Thread Felipe Balbi
Hi, On Thu, Oct 10, 2013 at 06:28:32PM +0200, Sebastian Andrzej Siewior wrote: > I have am335x-evm with one port running in OTG mode. Since commit > fe4cb09 ("usb: musb: gadget: remove hcd initialization") the loaded > gadget does non pop up on the host. All I see is > |usb 4-5: new high-speed USB

[PATCH 1/3] usb: phy: Add RCAR Gen2 USB phy

2013-10-10 Thread Valentine Barshak
This adds RCAR Gen2 USB phy support. The driver configures USB channels 0/2 which are shared between PCI USB hosts and USBHS/USBSS devices. It also controls internal USBHS phy. Signed-off-by: Valentine Barshak --- drivers/usb/phy/Kconfig | 13 ++ drivers/usb/phy/Makefile

Re: [RFC 2/2] usb: musb: start musb on the udc side, too

2013-10-10 Thread Daniel Mack
On 10.10.2013 18:33, Felipe Balbi wrote: > Hi, > > On Thu, Oct 10, 2013 at 06:28:32PM +0200, Sebastian Andrzej Siewior wrote: >> I have am335x-evm with one port running in OTG mode. Since commit >> fe4cb09 ("usb: musb: gadget: remove hcd initialization") the loaded >> gadget does non pop up on the

"1 lock held by file-storage" while in idle thread

2013-10-10 Thread Sebastian Andrzej Siewior
Since commit 0f9548ca1 ("lockdep: check that no locks held at freeze time") I see the following backtrace in the file storage gadget [0]: |= |[ BUG: file-storage/662 still has locks held! ] |3.12.0-rc4+ #2 Not tainted |- |1 loc

Re: [RFC 2/2] usb: musb: start musb on the udc side, too

2013-10-10 Thread Sebastian Andrzej Siewior
* Daniel Mack | 2013-10-10 18:37:38 [+0200]: >>> This patch fixes the problem for me. My question how do we do a pretty >>> version of this hack? > >Sebastian: thanks for addressing this. It has bugged quite some people >already. You're welcome. >> then perhaps musb_start() should be moved out of

Re: [PATCH 2/5] usb: gadget: s3c-hsotg: support configurable UTMI PHY width

2013-10-10 Thread Matt Porter
On 10/10/2013 11:29 AM, Felipe Balbi wrote: On Mon, Oct 07, 2013 at 06:12:29AM -0400, Matt Porter wrote: Extend dwc2 binding with an optional utmi phy width property. Enable the s3c-hsotg.c driver to use standard dwc2 binding and enable configuration of the UTMI phy width based on the property.

Re: [RFC 2/2] usb: musb: start musb on the udc side, too

2013-10-10 Thread Sebastian Andrzej Siewior
On 10/10/2013 06:37 PM, Daniel Mack wrote: > Other than that, please make sure not to call that function more than > once for dual role mode. A small hint please. We need it once in the hub code. So the host mode works if no gadget is loaded. And we need once in musb_gadget_start() so it executed

Re: [RFC 2/2] usb: musb: start musb on the udc side, too

2013-10-10 Thread Daniel Mack
On 10.10.2013 19:03, Sebastian Andrzej Siewior wrote: > On 10/10/2013 06:37 PM, Daniel Mack wrote: >> Other than that, please make sure not to call that function more than >> once for dual role mode. > > A small hint please. We need it once in the hub code. So the host mode > works if no gadget is

Re: "1 lock held by file-storage" while in idle thread

2013-10-10 Thread Alan Stern
On Thu, 10 Oct 2013, Sebastian Andrzej Siewior wrote: > Since commit 0f9548ca1 ("lockdep: check that no locks held at freeze > time") I see the following backtrace in the file storage gadget [0]: > |= > |[ BUG: file-storage/662 still has locks held! ] > |3.12.0-

Re: Switching OMAP2430 MUSB between host and device mode

2013-10-10 Thread Alan Stern
On Thu, 10 Oct 2013, Felipe Balbi wrote: > IIRC the debugfs interface is suppposedly a little better. > > /me goes check the code > > here it goes, just wrote "force host" to > /sys/kernel/debug/musb*/testmode > > Hopefully they have that enabled :-) Thanks for the information. I'll try it ou

Re: Switching OMAP2430 MUSB between host and device mode

2013-10-10 Thread Huang Rui
On Thu, Oct 10, 2013 at 11:26:47AM -0500, Felipe Balbi wrote: > HI, > > On Thu, Oct 10, 2013 at 11:45:47PM +0800, Huang Rui wrote: > > On Thu, Oct 10, 2013 at 10:10:52AM -0500, Felipe Balbi wrote: > > > On Tue, Oct 08, 2013 at 10:28:29AM -0400, Alan Stern wrote: > > > > I also have a question for

Re: how to add zte 3g/4g Wireless Modem pid to option.c

2013-10-10 Thread Greg KH
On Thu, Oct 10, 2013 at 03:22:32PM +0800, zhang.y...@zte.com.cn wrote: > > Hi, Greg KH: > > Now we have 3g/4g wireless modem product and many linux users use this product > on their system, so > > we want to add these product's pid to usb serial driver option.c. > > How to do this? You can eit

Re: Switching OMAP2430 MUSB between host and device mode

2013-10-10 Thread Felipe Balbi
Hi, On Fri, Oct 11, 2013 at 01:13:57AM +0800, Huang Rui wrote: > On Thu, Oct 10, 2013 at 11:26:47AM -0500, Felipe Balbi wrote: > > HI, > > > > On Thu, Oct 10, 2013 at 11:45:47PM +0800, Huang Rui wrote: > > > On Thu, Oct 10, 2013 at 10:10:52AM -0500, Felipe Balbi wrote: > > > > On Tue, Oct 08, 201

Re: [PATCH 2/5] usb: gadget: s3c-hsotg: support configurable UTMI PHY width

2013-10-10 Thread Felipe Balbi
Hi, On Thu, Oct 10, 2013 at 12:54:40PM -0400, Matt Porter wrote: > On 10/10/2013 11:29 AM, Felipe Balbi wrote: > >On Mon, Oct 07, 2013 at 06:12:29AM -0400, Matt Porter wrote: > >>Extend dwc2 binding with an optional utmi phy width property. > >>Enable the s3c-hsotg.c driver to use standard dwc2 bi

Re: [PATCH v5 1/1] usb/gadget: acm_ms: convert to new interface of f_mass_storage

2013-10-10 Thread Michal Nazarewicz
On Wed, Oct 09 2013, Andrzej Pietrasiewicz wrote: > Convert the legacy acm_ms gadget to use the new function interface > of f_mass_storage, so that later the compatibility layer in > f_mass_storage can be removed. > > Signed-off-by: Andrzej Pietrasiewicz > Signed-off-by: Kyungmin Park Acked-by:

Re: [PATCH v6 11/14] usb/gadget: mass_storage: convert to new interface of f_mass_storage

2013-10-10 Thread Michal Nazarewicz
On Wed, Oct 09 2013, Andrzej Pietrasiewicz wrote: > Convert old mass_storage gadget to use the new interface of f_mass_storage > so that later the compatibility layer in f_mass_storage can be removed. > > struct fsg_common is not known to mass_storage.c, so a setter method > is added to f_mass_stor

Re: [PATCH v6 12/14] usb/gadget: storage_common: make attribute operations more generic

2013-10-10 Thread Michal Nazarewicz
On Wed, Oct 09 2013, Andrzej Pietrasiewicz wrote: > Show/store methods for sysfs attributes contain code which can be used > also by configfs. Make them abstract the source the lun and rw_semaphore > are taken from. > > Signed-off-by: Andrzej Pietrasiewicz > Signed-off-by: Kyungmin Park Ackedy-b

RE: [PATCH 2/5] usb: gadget: s3c-hsotg: support configurable UTMI PHY width

2013-10-10 Thread Paul Zimmerman
> From: Felipe Balbi [mailto:ba...@ti.com] > Sent: Thursday, October 10, 2013 10:46 AM > > On Thu, Oct 10, 2013 at 12:54:40PM -0400, Matt Porter wrote: > > On 10/10/2013 11:29 AM, Felipe Balbi wrote: > > >On Mon, Oct 07, 2013 at 06:12:29AM -0400, Matt Porter wrote: > > >>Extend dwc2 binding with a

Re: [PATCH v6 13/14] usb/gadget: storage_common: add methods to show/store 'cdrom' and 'removable'

2013-10-10 Thread Michal Nazarewicz
On Wed, Oct 09 2013, Andrzej Pietrasiewicz wrote: > This will be required by configfs integration. > > Signed-off-by: Andrzej Pietrasiewicz > Signed-off-by: Kyungin Park > --- > drivers/usb/gadget/storage_common.c | 42 > +++ > drivers/usb/gadget/storage_common

Re: [PATCH 2/5] usb: gadget: s3c-hsotg: support configurable UTMI PHY width

2013-10-10 Thread Felipe Balbi
Hi, On Thu, Oct 10, 2013 at 05:57:54PM +, Paul Zimmerman wrote: > > From: Felipe Balbi [mailto:ba...@ti.com] > > Sent: Thursday, October 10, 2013 10:46 AM > > > > On Thu, Oct 10, 2013 at 12:54:40PM -0400, Matt Porter wrote: > > > On 10/10/2013 11:29 AM, Felipe Balbi wrote: > > > >On Mon, Oct

RE: [PATCH 2/5] usb: gadget: s3c-hsotg: support configurable UTMI PHY width

2013-10-10 Thread Paul Zimmerman
> From: Felipe Balbi [mailto:ba...@ti.com] > Sent: Thursday, October 10, 2013 11:07 AM > > On Thu, Oct 10, 2013 at 05:57:54PM +, Paul Zimmerman wrote: > > > From: Felipe Balbi [mailto:ba...@ti.com] > > > Sent: Thursday, October 10, 2013 10:46 AM > > > > > > On Thu, Oct 10, 2013 at 12:54:40PM -

Re: [PATCH 2/2] xhci: fix last valid endpoint when dropping an endpoint

2013-10-10 Thread Sarah Sharp
Hi Xenia, On Mon, Oct 07, 2013 at 06:52:39PM +0300, Xenia Ragiadakou wrote: > The previous patch on the endpoint reset uses the already implemented function > xhci_drop_endpoint() to reduce code duplication. However, the way that xhci > updates the last valid endpoint in the Input Slot Context, wh

Re: LTE vodafone K5150 (hilink) 12d1 1f16 ; 12d1 1575 cdc_ether mbim?

2013-10-10 Thread Thomas Schäfer
Hi Bjørn, I can't answer your Questions. Do you recommend / know a usb-sniffer for Win8? In the meantime, I have got the first ipv4-connection: hpmini:~ # mbim-network /dev/cdc-wdm0 start Loading profile... APN: internet.telekom Querying subscriber ready status 'mbimcli -d /dev/cdc-wdm0 --

[PATCH] extcon: palmas: Handle ID interrupt properly using USB_ID_INT_SRC

2013-10-10 Thread George Cherian
Always cross check with the ID state and the source of interrupt. Also add a case in which ID Source is ID_GND but LATCH state is set wrongly. This uses the previous Link stat to determine the new state. Signed-off-by: George Cherian --- drivers/extcon/extcon-palmas.c | 15 --- 1 fil

Re: [PATCH 2/5] usb: gadget: s3c-hsotg: support configurable UTMI PHY width

2013-10-10 Thread Felipe Balbi
Hi, On Thu, Oct 10, 2013 at 06:14:19PM +, Paul Zimmerman wrote: > > From: Felipe Balbi [mailto:ba...@ti.com] > > Sent: Thursday, October 10, 2013 11:07 AM > > > > On Thu, Oct 10, 2013 at 05:57:54PM +, Paul Zimmerman wrote: > > > > From: Felipe Balbi [mailto:ba...@ti.com] > > > > Sent: Thu

Re: [PATCH 0/6] xhci: Multiple fixes for usb bulk streams

2013-10-10 Thread Sarah Sharp
On Fri, Oct 04, 2013 at 12:29:43AM +0200, Hans de Goede wrote: > Hi All, Hi Hans, > After spending 1.5 weeks debugging issues with xhci streams which would > hard-freeze my machine every 5 minutes, I'm very happy to present this > patch set, with which usb 3 streams are fully stable for me, inclu

Re: [PATCH 2/5] usb: gadget: s3c-hsotg: support configurable UTMI PHY width

2013-10-10 Thread Matt Porter
On 10/10/2013 01:57 PM, Paul Zimmerman wrote: From: Felipe Balbi [mailto:ba...@ti.com] Sent: Thursday, October 10, 2013 10:46 AM On Thu, Oct 10, 2013 at 12:54:40PM -0400, Matt Porter wrote: On 10/10/2013 11:29 AM, Felipe Balbi wrote: On Mon, Oct 07, 2013 at 06:12:29AM -0400, Matt Porter wrote:

Re: [PATCH 0/6] xhci: Multiple fixes for usb bulk streams

2013-10-10 Thread Hans de Goede
Hi, On 10/10/2013 09:04 PM, Sarah Sharp wrote: On Fri, Oct 04, 2013 at 12:29:43AM +0200, Hans de Goede wrote: Hi All, Hi Hans, After spending 1.5 weeks debugging issues with xhci streams which would hard-freeze my machine every 5 minutes, I'm very happy to present this patch set, with which

When USB PHY framework should be used?

2013-10-10 Thread Arokux X
Hi, recently I have been working on mainlining a simple bus glue driver for the USB EHCI for the Allwinner family of the ARM SoCs aka sunxi. The patches are almost ready and can be found at [1] and will be submitted once completely ready. The most interesting patch is [2] which is a driver itself.

Re: LTE vodafone K5150 (hilink) 12d1 1f16 ; 12d1 1575 cdc_ether mbim?

2013-10-10 Thread Bjørn Mork
Thomas Schäfer writes: > Do you recommend / know a usb-sniffer for Win8? http://desowin.org/usbpcap/ Using the wireshark layered dissectors is really nice. I am just lazy, waiting for someone to make a MBIM dissector :-) > In the meantime, I have got the first ipv4-connection: Yes, that sho

linux-next: manual merge of the usb-gadget tree

2013-10-10 Thread Mark Brown
Today's linux-next merge of the usb-gadget tree got conflicts in drivers/usb/musb/davinci.c caused by an add in ea78201e2 (usb: musb: davinci: fix resources passed to MUSB driver for DM6467) adjacent to the modification of the device registration in 4c9ad1059 (DMA-API: usb: musb: use platform_devic

Re: linux-next: manual merge of the usb-gadget tree

2013-10-10 Thread Felipe Balbi
Hi, On Thu, Oct 10, 2013 at 10:20:30PM +0100, Mark Brown wrote: > Today's linux-next merge of the usb-gadget tree got conflicts in > drivers/usb/musb/davinci.c caused by an add in ea78201e2 (usb: musb: > davinci: fix resources passed to MUSB driver for DM6467) adjacent to > the modification of the

[PATCH 6/6] drivers: usb: core: devio.c: Else should be on closing braces

2013-10-10 Thread Matthias Beyer
moved else keyword of if-else construct to closing braces. Signed-off-by: Matthias Beyer --- drivers/usb/core/devio.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c index 215d882..adbdea3 100644 --- a/drivers/usb/core

[PATCH 5/6] drivers: usb: core: devio.c: Braces around switch

2013-10-10 Thread Matthias Beyer
Added braces around switch statement as the styleguide tells us. Indented the switch-block for it and split a function call (driver->unlocked_ioctl() on line 1876) arguments to several lines to fit the 80-column convention. Signed-off-by: Matthias Beyer --- drivers/usb/core/devio.c | 60

[PATCH 2/6] drivers: usb: core: file.c: moved asterisk to variable name

2013-10-10 Thread Matthias Beyer
Signed-off-by: Matthias Beyer --- drivers/usb/core/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/core/file.c b/drivers/usb/core/file.c index 903c7ef..3bdfbf8 100644 --- a/drivers/usb/core/file.c +++ b/drivers/usb/core/file.c @@ -27,7 +27,7 @@ static const

[PATCH 3/6] drivers: usb: core: hub.c: Comments shouldnt be C99 // comment style

2013-10-10 Thread Matthias Beyer
Signed-off-by: Matthias Beyer --- drivers/usb/core/hub.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c index e5fdf4b..5e9fc21 100644 --- a/drivers/usb/core/hub.c +++ b/drivers/usb/core/hub.c @@ -2488,7 +2488,7 @@ error_devi

[PATCH 1/6] drivers: usb: core: {file,hub,sysfs,usb}.c: Whitespace fixes

2013-10-10 Thread Matthias Beyer
including: - removing of trailing whitespace - removing spaces before array indexing (foo [] to foo[]) - reindention of a switch-case block - spaces to tabs Signed-off-by: Matthias Beyer --- drivers/usb/core/file.c | 6 +-- drivers/usb/core/hub.c | 111 +++--

[PATCH 4/6] drivers: usb: core: devio.c: Coding style fixes

2013-10-10 Thread Matthias Beyer
Whitespace fixes, including: - Whitespace after if-keyword - Spaces to Tabs Other coding style fixes: - Added braces for if-else blocks where missing Signed-off-by: Matthias Beyer --- drivers/usb/core/devio.c | 39 --- 1 file changed, 20 insertions(+), 19 d

[PATCH 0/6] drivers: usb: core: Adapt source to styleguide

2013-10-10 Thread Matthias Beyer
Hi, I patches several files in drivers/usb/core/ to adapt them to the kernel styleguide. Most of these patches are whitespace/indention fixes. As these patches are only style-patches, I just compiled the kernel, no compile errors or warnings. So I think everything seems to be okay! Note: I did

Need testers for long-standing xHCI clear halt bug

2013-10-10 Thread Sarah Sharp
Hi Sipter and Marcus, Xenia has a potential fix for a long-standing bug in the xHCI driver, and I need your help testing it. You ran into that bug back in Feb 2013: http://sourceforge.net/mailarchive/forum.php?thread_name=CAGjSPUAQ8phZFu9dj60wt9zZpoghcQMVUAwgd2y3NvLmiAZH7Q%40mail.gmail.com&forum

[PATCH] xhci: Ensure a command structure points to the correct trb on the command ring

2013-10-10 Thread xiao jin
From: Mathias Nyman If a command on the command ring needs to be cancelled before it is handled it can be turned to a no-op operation when the ring is stopped. We want to store the command ring enqueue pointer in the command structure when the command in enqueued for the cancellation case. Some

[PATCH v2] xhci: correct the usage of USB_CTRL_SET_TIMEOUT

2013-10-10 Thread xiao jin
The usage of USB_CTRL_SET_TIMEOUT in xhci is incorrect. The definition of USB_CTRL_SET_TIMEOUT is 5000ms. The input timeout to wait_for_completion_interruptible_timeout is jiffies. That makes the timeout be longer than what we want, such as 50s in some platform. The patch is to use XHCI_CMD_DEFAUL

Re: [PATCH] usbnet: smsc95xx: Add device tree input for MAC address

2013-10-10 Thread Ming Lei
On Thu, Oct 10, 2013 at 8:47 PM, Dan Murphy wrote: > > Is there a board that has 2 built in smsc devices? I don't know, maybe there isn't, but driver should be generic enough, and as I said it is a generic problem, and people are discussing it, so suggest to read previous discussions first before

Re: When USB PHY framework should be used?

2013-10-10 Thread Peter Chen
On Thu, Oct 10, 2013 at 09:21:36PM +0200, Arokux X wrote: > Hi, > > recently I have been working on mainlining a simple bus glue driver > for the USB EHCI for the Allwinner family of the ARM SoCs aka sunxi. > The patches are almost ready and can be found at [1] and will be > submitted once complet

Re: [PATCH 2/5] usb: gadget: s3c-hsotg: support configurable UTMI PHY width

2013-10-10 Thread Matt Porter
On 10/10/2013 03:07 PM, Matt Porter wrote: On 10/10/2013 01:57 PM, Paul Zimmerman wrote: From: Felipe Balbi [mailto:ba...@ti.com] Sent: Thursday, October 10, 2013 10:46 AM On Thu, Oct 10, 2013 at 12:54:40PM -0400, Matt Porter wrote: On 10/10/2013 11:29 AM, Felipe Balbi wrote: On Mon, Oct 07,

[PATCH 1/1] support new huawei devices in option.c

2013-10-10 Thread Fangxiaozhi (Franko)
1. Add new supporting declarations to option.c, to support Huawei new devices with new bInterfaceSubClass value. Signed-off-by: fangxiaozhi --- linux-3.11.4-orig/drivers/usb/serial/option.c 2013-10-10 16:13:25.443072876 +0800 +++ linux-3.11.4/drivers/usb/serial/o

Re: Switching OMAP2430 MUSB between host and device mode

2013-10-10 Thread Huang Rui
Hi Felipe, On Thu, Oct 10, 2013 at 12:44:05PM -0500, Felipe Balbi wrote: > Hi, > > On Fri, Oct 11, 2013 at 01:13:57AM +0800, Huang Rui wrote: > > On Thu, Oct 10, 2013 at 11:26:47AM -0500, Felipe Balbi wrote: > > > HI, > > > > > > On Thu, Oct 10, 2013 at 11:45:47PM +0800, Huang Rui wrote: > > > >

[PATCH] usb: gadget: Make VERBOSE_DEBUG enableable via Kconfig

2013-10-10 Thread Andreas Larsson
Signed-off-by: Andreas Larsson --- drivers/usb/gadget/Kconfig | 14 ++ drivers/usb/gadget/Makefile |3 ++- 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig index 48cddf3..922a04d 100644 --- a/drivers/usb/gadg

Re: When USB PHY framework should be used?

2013-10-10 Thread Kishon Vijay Abraham I
On Friday 11 October 2013 12:51 AM, Arokux X wrote: > Hi, > > recently I have been working on mainlining a simple bus glue driver > for the USB EHCI for the Allwinner family of the ARM SoCs aka sunxi. > The patches are almost ready and can be found at [1] and will be > submitted once completely re

Re: [PATCH v3] USB: gadget: s3c-hsotg: add isochronous transfers support

2013-10-10 Thread Robert Baldyga
Hello, On 10/10/2013 06:04 PM, Felipe Balbi wrote: > Hi, > > On Wed, Oct 09, 2013 at 08:41:57AM +0200, Robert Baldyga wrote: >> @@ -2616,14 +2630,19 @@ static int s3c_hsotg_ep_enable(struct usb_ep *ep, >> s3c_hsotg_set_ep_maxpacket(hsotg, hs_ep->index, mps); >> >> /* default, set to n