On Wed, Aug 7, 2013 at 7:51 PM, Fabio Estevam wrote:
> From: Fabio Estevam
>
> Using SIMPLE_DEV_PM_OPS can make the code simpler and cleaner.
>
> Signed-off-by: Fabio Estevam
> ---
> drivers/usb/dwc3/dwc3-pci.c | 15 +--
> 1 file changed, 5 insertions(+), 10 deletions(-)
>
> diff --
On 12/08/2013 22:42, boris brezillon :
Hello Nicolas,
On 12/08/2013 15:52, Nicolas Ferre wrote:
On 01/08/2013 08:18, Boris BREZILLON :
The AT91 PMC (Power Management Controller) provides an USB clock used by
USB Full Speed host (ohci) and USB Full Speed device (udc).
The usb drivers (ohci and
On 08/09/2013 10:30 PM, Sergei Shtylyov wrote:
> Hello.
Hi Sergei,
>> +if (musb->port_mode == MUSB_PORT_MODE_HOST) {
>> +val = USBMODE_IDDIG_A;
>> +val |= USBMODE_ID_MUX_REG;
>
>Why not do the above in one line and save on {} {}? It will look more
> aesthetically pleasing
Hi,
On Fri, 2013-08-09 at 10:31 -0500, Kumar Gala wrote:
> On Aug 9, 2013, at 4:53 AM, Ivan T. Ivanov wrote:
>
> > From: "Ivan T. Ivanov"
> >
> > MSM USB3.0 core wrapper consist of USB3.0 IP (SNPS)
>
> probably good to spell out Synopsys rather than SNPS
I could make it look like this? Syn
Enable tx checksum.
Signed-off-by: Hayes Wang
---
drivers/net/usb/r8152.c | 63 +
1 file changed, 58 insertions(+), 5 deletions(-)
diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
index c6c5aa2..5d9d949 100644
--- a/drivers/net/usb/r
Enable the tx/rx aggregation which could contain one or more packets
for each bulk in/out. This could reduce the loading of the host
controller by sending less bulk transfer.
The rx packets in the bulk in buffer should be 8-byte aligned, and
the tx packets in the bulk out buffer should be 4-byte a
Use the interrupt transfer to replace polling link status. Delay
to update the link down status, because some of them result from
the change of speed.
Signed-off-by: Hayes Wang
---
drivers/net/usb/r8152.c | 134 ++--
1 file changed, 107 insertions(+),
Hi,
On Mon, 2013-08-12 at 13:04 -0500, Felipe Balbi wrote:
> On Fri, Aug 09, 2013 at 10:31:58AM -0500, Kumar Gala wrote:
> >
> > On Aug 9, 2013, at 4:53 AM, Ivan T. Ivanov wrote:
> >
> > > From: "Ivan T. Ivanov"
> > >
> > > MSM USB3.0 core wrapper consist of USB3.0 IP (SNPS)
> >
> > probab
If usb auto suspend is enabled or system run in to suspend/resume
cycle ath9k-htc adapter will stop to response. It is reproducible on xhci HCs.
Host part of problem:
XHCI do timing calculation based on Transfer Type and bInterval,
immediately after device was detected. Ath9k-htc try to overwrite
On 12 July 2013 12:27, Felipe Balbi wrote:
> Hi,
>
> On Wed, Jul 10, 2013 at 10:42:27AM -0700, Julius Werner wrote:
>> Hi Felipe,
>>
>> This is intended to pull down a reset signal line, not to switch power
>> to the device. I could implement that with the regulator framework
>> too, but I think t
On Tue, 2013-08-13 at 15:28 +0800, Hayes Wang wrote:
> +
> +static void rx_bottom(struct r8152 *tp)
> +{
> + struct net_device_stats *stats;
> + struct net_device *netdev;
> + struct rx_agg *agg;
> + struct rx_desc *rx_desc;
> + unsigned long lockflags;
> + struc
Stephen Rothwell reported that this driver does not compile on PowerPC
due to this missing include. One could argue why this driver is enabled
on PowerPC in the first place but it sure isn't wrong to include headers
for used function instead of to rely that they sneak in.
Reported-by: Stephen Roth
Hi,
I had no problem with a USB 3.0 port in my Asus N43SN since I bought a
laptop (~2 years). Recently I replaced a motherboard to the new one
(N43SL.413 looks the same as the first one) due to a problem with a
graphical chipset and after that a USB3 controller stopped to be even
detected.
$ lspc
No functional change. Used devm_kzalloc and devm_clk_get instead of
kzalloc and clk_get.
Signed-off-by: Kishon Vijay Abraham I
---
only *compile* tested.
drivers/usb/musb/am35x.c | 40 ++--
drivers/usb/musb/blackfin.c |8 ++--
drivers/usb/musb/
musb glue have to pass either 2 resources or 3 resources to the musb
core (musb core irq number, dma irq number and a memory
resource). So allocated *resource* for musb core in glue (based on the number
of resources in glue), copy all the resources from glue to core before creating
the musb core de
Hi,
On Wednesday 31 July 2013 11:45 AM, Felipe Balbi wrote:
> Hi,
>
> On Wed, Jul 31, 2013 at 11:14:32AM +0530, Kishon Vijay Abraham I wrote:
>>> IMHO we need a lookup method for PHYs, just like for clocks,
>>> regulators, PWMs or even i2c busses because there are complex cases
>>> wh
Fengguang Wu' bot noticed that dsps won't compile without of_irq*
available. I limit this to OF_IRQ for that reason.
Signed-off-by: Sebastian Andrzej Siewior
---
drivers/usb/musb/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/musb/Kconfig b/drivers/usb/musb/Kconfig
index
The parallel-port code of the drivers used a stack allocated
control-request buffer for asynchronous (and possibly deferred) control
requests. This not only violates the no-DMA-from-stack requirement but
could also lead to corrupt control requests being submitted.
Cc: sta...@vger.kernel.org
Signed
Make sure serial DMA-buffers are allocated separately from containing
structure to prevent potential memory corruption on non-cache-coherent
systems.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/keyspan.c | 40
1 file changed, 36 insertions(+), 4 de
Make sure to fail properly if the device is not accepted during attach
in order to avoid null-pointer derefs (of missing interface private
data) at disconnect or release.
Cc: sta...@vger.kernel.org
Signed-off-by: Johan Hovold
---
drivers/usb/serial/keyspan.c | 2 +-
1 file changed, 1 insertion(+
Make sure serial DMA-buffers are allocated separately from containing
structure to prevent potential memory corruption on non-cache-coherent
systems.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/quatech2.c | 21 +++--
1 file changed, 15 insertions(+), 6 deletions(-)
diff -
Make sure port DMA-buffers are allocated separately from containing
structure to prevent potential memory corruption on non-cache-coherent
systems.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/keyspan.c | 64 ++--
1 file changed, 56 insertions(+), 8
Make sure the USB control request is allocated separately from
containing structure to prevent potential memory corruption on
non-cache-coherent systems.
Signed-off-by: Johan Hovold
---
drivers/usb/misc/uss720.c | 24 +++-
1 file changed, 15 insertions(+), 9 deletions(-)
dif
Greg,
Here's a bunch of fixes for v3.11 and (possibly) v3.12.
The first two I think should go into v3.11 whereas the remaining patches
could wait for v3.12, unless you think otherwise.
I don't have access to these devices so have only done minimal testing
of the serial ones using the dynamic-id
Make sure serial DMA-buffers are allocated separately from containing
structure to prevent potential memory corruption on non-cache-coherent
systems.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/quatech2.c | 14 --
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/
On Tuesday 13 of August 2013 16:14:44 Kishon Vijay Abraham I wrote:
> Hi,
>
> On Wednesday 31 July 2013 11:45 AM, Felipe Balbi wrote:
> > Hi,
> >
> > On Wed, Jul 31, 2013 at 11:14:32AM +0530, Kishon Vijay Abraham I wrote:
> >>> IMHO we need a lookup method for PHYs, just like for clocks,
> >>
Am 13.08.2013 10:09, schrieb Oleksij Rempel:
If usb auto suspend is enabled or system run in to suspend/resume
cycle ath9k-htc adapter will stop to response. It is reproducible on xhci HCs.
Host part of problem:
XHCI do timing calculation based on Transfer Type and bInterval,
immediately after d
On Tuesday 13 August 2013 05:07 PM, Tomasz Figa wrote:
> On Tuesday 13 of August 2013 16:14:44 Kishon Vijay Abraham I wrote:
>> Hi,
>>
>> On Wednesday 31 July 2013 11:45 AM, Felipe Balbi wrote:
>>> Hi,
>>>
>>> On Wed, Jul 31, 2013 at 11:14:32AM +0530, Kishon Vijay Abraham I wrote:
> IMHO we
On 08/12/2013 05:54 PM, Peter Wu wrote:
On Thursday 18 July 2013 16:28:01 Peter Hurley wrote:
Before we revert to using the workaround, I'd like to suggest that
this new "hidden" problem may be an interaction with the xhci_hcd host
controller driver only.
Looking at the related bug, the OP indi
Oliver Neukum [mailto:oneu...@suse.de]
> Sent: Tuesday, August 13, 2013 4:49 PM
> To: Hayeswang
> Cc: net...@vger.kernel.org; linux-ker...@vger.kernel.org;
> linux-usb@vger.kernel.org
> Subject: Re: [PATCH net-next 1/3] net/usb/r8152: support aggregation
>
[...]
> > + len_used = 0
dsps_suspend() and dsps_resume() are called with the device that has the
glue assigned as drvdata. Using dev->parent seems wrong and causes a
NULL pointer exception on an AM33xx board.
The code was introduced by commit c68bb4c6 ("usb: musb: dsps: control
module handling (quirk)") but I wonder whet
On Tue, Aug 13, 2013 at 3:59 AM, Peter Chen wrote:
> It seems .pm is not NULL if CONFIG_PM_SLEEP is not defined
> which is not the same with former code.
With SIMPLE_DEV_PM_OPS macro we don't need to define the NULL function variants.
Take a look at include/linux/pm.h to get a clear picture.
--
Sebastian,
On Tue, Aug 13, 2013 at 2:14 AM, Sebastian Andrzej Siewior
wrote:
> On 08/09/2013 10:30 PM, Sergei Shtylyov wrote:
>> Hello.
>
> Hi Sergei,
>
>>> +if (musb->port_mode == MUSB_PORT_MODE_HOST) {
>>> +val = USBMODE_IDDIG_A;
>>> +val |= USBMODE_ID_MUX_REG;
>>
>>Why
On 08/13/2013 03:03 PM, Bin Liu wrote:
> Sebastian,
Hi Bin,
+if (musb->port_mode == MUSB_PORT_MODE_HOST) {
+val = USBMODE_IDDIG_A;
+val |= USBMODE_ID_MUX_REG;
>>>
> I am going to so some tests today for this. I don't object to use the
> mode register, but am won
On Mon, Aug 12, 2013 at 07:05:53PM +0100, Felipe Balbi wrote:
> On Fri, Aug 09, 2013 at 01:42:15PM -0500, Kumar Gala wrote:
> >
> > On Aug 9, 2013, at 11:28 AM, Mark Rutland wrote:
> >
> > > On Fri, Aug 09, 2013 at 04:40:32PM +0100, Kumar Gala wrote:
> > >> The binding spec wasn't clear that the
On 08/13/2013 03:33 PM, Bin Liu wrote:
> Sebastian,
Hi Bin,
>> I've been looking at the wiki page and it did not mention the ID pin
>> for the second port. If it is grounded then this piece can be removed
> I thought you have already tried that without setting the mode
> register the session bit
Sebastian,
On Tue, Aug 13, 2013 at 8:17 AM, Sebastian Andrzej Siewior
wrote:
> On 08/13/2013 03:03 PM, Bin Liu wrote:
>> Sebastian,
>
> Hi Bin,
>
> +if (musb->port_mode == MUSB_PORT_MODE_HOST) {
> +val = USBMODE_IDDIG_A;
> +val |= USBMODE_ID_MUX_REG;
>> I am g
Sebastian,
On Tue, Aug 13, 2013 at 8:44 AM, Sebastian Andrzej Siewior
wrote:
> This was a misunderstanding then. Sorry. I understood that the bin has
> to be unset and then the controller set it once a device there.
You meant ID pin? I think it should be set all the time since the
driver initiali
On Tue, Aug 13, 2013 at 8:59 PM, Fabio Estevam wrote:
> On Tue, Aug 13, 2013 at 3:59 AM, Peter Chen wrote:
>
>> It seems .pm is not NULL if CONFIG_PM_SLEEP is not defined
>> which is not the same with former code.
>
> With SIMPLE_DEV_PM_OPS macro we don't need to define the NULL function
> varia
On Mon, 12 Aug 2013, Jack Pham wrote:
> commit 9841f37a1c ("usb: ehci: Add support for SINGLE_STEP_SET_FEATURE
> test of EHSET") added additional code to the EHCI hub driver but it is
> anticipated to only have a limited audience (e.g. embedded silicon
> vendors and integrators). Avoid subjecting
On Tue, 13 Aug 2013, Oleksij Rempel wrote:
> If usb auto suspend is enabled or system run in to suspend/resume
> cycle ath9k-htc adapter will stop to response. It is reproducible on xhci HCs.
>
> Host part of problem:
> XHCI do timing calculation based on Transfer Type and bInterval,
> immediatel
On Tue, Aug 13, 2013 at 11:05 AM, Peter Chen wrote:
> But what I see is the &dwc3_pci_dev_pm_ops is not NULL if CONFIG_PM_SLEEP
> is not defined.
The point of this macro is that we do not need to provide the .suspend
and .resume NULL version when !CONFIG_PM_SLEEP because the macro takes
care of
On 08/13/2013 04:01 PM, Bin Liu wrote:
> Sebastian,
Hi Bin,
> On Tue, Aug 13, 2013 at 8:44 AM, Sebastian Andrzej Siewior
> wrote:
>> This was a misunderstanding then. Sorry. I understood that the bin has
>> to be unset and then the controller set it once a device there.
> You meant ID pin? I thi
Sebastian,
On Tue, Aug 13, 2013 at 9:23 AM, Sebastian Andrzej Siewior
wrote:
> Where is my memory going? So now I have a beagle bone in front of me
> and I see a micro USB port a standard A connector. My memory was
> different.
> The micro USB is the UART and standard is most likely the first mus
Hello.
On 08/13/2013 11:28 AM, Hayes Wang wrote:
Enable tx checksum.
Signed-off-by: Hayes Wang
---
drivers/net/usb/r8152.c | 63 +
1 file changed, 58 insertions(+), 5 deletions(-)
diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8
On Tue, 2013-08-13 at 20:32 +0800, hayeswang wrote:
> Oliver Neukum [mailto:oneu...@suse.de]
> > Sent: Tuesday, August 13, 2013 4:49 PM
> > To: Hayeswang
> > Cc: net...@vger.kernel.org; linux-ker...@vger.kernel.org;
> > linux-usb@vger.kernel.org
> > Subject: Re: [PATCH net-next 1/3] net/usb/r815
On Mon, Aug 12, 2013 at 02:52:33PM -0400, Alan Stern wrote:
> On Mon, 12 Aug 2013, Felipe Balbi wrote:
>
> > > > maybe a single callback for supporting 'testmodes' ? which receives the
> > > > test mode as argument ?
> > >
> > > I don't have a clear picture of how you would apply such an approach
Hi,
On Tue, Aug 13, 2013 at 01:10:59PM +0200, Sebastian Andrzej Siewior wrote:
> Fengguang Wu' bot noticed that dsps won't compile without of_irq*
> available. I limit this to OF_IRQ for that reason.
>
> Signed-off-by: Sebastian Andrzej Siewior
I sent this patch yesterday.
--
balbi
signatur
On Tue, Aug 13, 2013 at 02:40:30PM +0200, Daniel Mack wrote:
> dsps_suspend() and dsps_resume() are called with the device that has the
> glue assigned as drvdata. Using dev->parent seems wrong and causes a
> NULL pointer exception on an AM33xx board.
>
> The code was introduced by commit c68bb4c6
On Tuesday 13 August 2013 08:13:17 Peter Hurley wrote:
> On 08/12/2013 05:54 PM, Peter Wu wrote:
> > On Thursday 18 July 2013 16:28:01 Peter Hurley wrote:
> >> Before we revert to using the workaround, I'd like to suggest that
> >> this new "hidden" problem may be an interaction with the xhci_hcd h
On 08/13/2013 05:36 PM, Felipe Balbi wrote:
> Hi,
Hi,
> I sent this patch yesterday.
And how did you know about zhis yesterday? The bot reached me today.
>
Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
Mo
On 13.08.2013 17:37, Felipe Balbi wrote:
> On Tue, Aug 13, 2013 at 02:40:30PM +0200, Daniel Mack wrote:
>> diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb/musb_dsps.c
>> index 5233804..f20218e 100644
>> --- a/drivers/usb/musb/musb_dsps.c
>> +++ b/drivers/usb/musb/musb_dsps.c
>> @@ -69
dsps_suspend() and dsps_resume() are called with the device that has the
glue assigned as drvdata. Using dev->parent seems wrong and causes a
NULL pointer exception on an AM33xx board.
The code was introduced by commit c68bb4c6 ("usb: musb: dsps: control
module handling (quirk)") but I wonder whet
On 08/13/2013 11:42 AM, Peter Wu wrote:
On Tuesday 13 August 2013 08:13:17 Peter Hurley wrote:
On 08/12/2013 05:54 PM, Peter Wu wrote:
On Thursday 18 July 2013 16:28:01 Peter Hurley wrote:
Before we revert to using the workaround, I'd like to suggest that
this new "hidden" problem may be an in
When the HWA encounters a STALL on a control endpoint, it should clear the
RPIPE_STALL feature on the RPIPE before processing the next transfer
request. Otherwise, all transfer requests on that endpoint after the
first STALL will fail because the RPIPE is still in the halted state.
Signed-off-
On Tue, Aug 13, 2013 at 09:44:26AM +0200, Florian Wolter wrote:
> Patch to Fix Problem with not cleared halted endpoint.
>
> See Bugtracker Bug 60699
Hi Florian,
You need to send your patch inline, not as an attachment.
Thanks,
Sarah Sharp
--
To unsubscribe from this list: send the line "unsubs
On Tue, 13 Aug 2013, Felipe Balbi wrote:
> > That's not what I meant. Yes, the test-device driver knows what test
> > it wants to run, based on the VID/PID. I was asking how it would
> > communicate this knowledge to the HCD.
> >
> > For example, it doesn't make sense to have a callback that me
On 13.08.2013 18:45, Sarah Sharp wrote:
On Tue, Aug 13, 2013 at 09:44:26AM +0200, Florian Wolter wrote:
Patch to Fix Problem with not cleared halted endpoint.
See Bugtracker Bug 60699
Hi Florian,
You need to send your patch inline, not as an attachment.
Thanks,
Sarah Sharp
Hi Sarah,
Sorr
Good eye, I completely missed the first goto. I'll update the patch and resend
it. Thanks Greg!
-Sean
> -Original Message-
> From: Greg Kroah-Hartman [mailto:gre...@linuxfoundation.org]
> Sent: Monday, August 12, 2013 5:28 PM
> To: Stalley, Sean
> Cc: linux-usb@vger.kernel.org; Sarah Sha
On Tuesday 13 August 2013 12:01 PM, Alexandre Demers wrote:
lsusb gives me the following:
sudo lsusb --verbose -t
/: Bus 13.Port 1: Dev 1, Class=root_hub, Driver=xhci_hcd/2p, 5000M
/: Bus 12.Port 1: Dev 1, Class=root_hub, Driver=xhci_hcd/2p, 480M
/: Bus 11.Port 1: Dev 1, Class=root_hub, Driver=x
This patch seriese mostly contains coding style fixes & removes unneeded
variable initialization.
Dan Carpenter (1):
staging: ozwpan: Separate success & failure case for
oz_hcd_pd_arrived()
Rupesh Gujare (9):
staging: ozwpan: Add a blank line between declaraction and code.
staging: ozwp
Making code simpler for readability.
Reported-by: Dan Carpenter
Signed-off-by: Rupesh Gujare
---
drivers/staging/ozwpan/ozhcd.c |9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/ozwpan/ozhcd.c b/drivers/staging/ozwpan/ozhcd.c
index 5a417c8..4b658d4
This patch adds a blank line between global declarations &
functions for readability.
Signed-off-by: Rupesh Gujare
---
drivers/staging/ozwpan/ozcdev.c| 17
drivers/staging/ozwpan/ozeltbuf.c | 12 ++
drivers/staging/ozwpan/ozhcd.c | 68 +
Put spaces around math operations.
Reported-by: Dan Carpenter
Signed-off-by: Rupesh Gujare
---
drivers/staging/ozwpan/ozhcd.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/ozwpan/ozhcd.c b/drivers/staging/ozwpan/ozhcd.c
index 4b658d4..2be15f4 100644
This patch adds blank line between declaration &
code for readability.
Signed-off-by: Rupesh Gujare
---
drivers/staging/ozwpan/ozcdev.c|6 ++
drivers/staging/ozwpan/ozeltbuf.c |7 +++
drivers/staging/ozwpan/ozhcd.c | 28
drivers
Hello.
On 08/13/2013 08:52 PM, Florian Wolter wrote:
Patch to Fix Problem with not cleared halted endpoint.
See Bugtracker Bug 60699
Hi Florian,
You need to send your patch inline, not as an attachment.
Thanks,
Sarah Sharp
Hi Sarah,
Sorry now the Patch is in-lined.
Subject: [
We are already checking "ep" earlier in function. Do not
need to check again.
Reported-by: Dan Carpenter
Signed-off-by: Rupesh Gujare
---
drivers/staging/ozwpan/ozhcd.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ozwpan/ozhcd.c b/drivers/staging/ozwpan
From: Dan Carpenter
This patch separates success & failure block along with fixing
following issues:-
1. The way oz_hcd_pd_arrived() looks now it's easy to think we free "ep" but
actually we do this spaghetti thing of setting it to NULL on success.
2. It is hard to read it because there are unl
Swap arguments of oz_ep_alloc() to match kmalloc() for better readability.
Signed-off-by: Rupesh Gujare
---
drivers/staging/ozwpan/ozhcd.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/ozwpan/ozhcd.c b/drivers/staging/ozwpan/ozhcd.c
index 0fd3fea..0
Remove variable initialization wherever it is not required.
Signed-off-by: Rupesh Gujare
---
drivers/staging/ozwpan/ozeltbuf.c |2 +-
drivers/staging/ozwpan/ozhcd.c| 18 +-
drivers/staging/ozwpan/ozpd.c |4 ++--
3 files changed, 12 insertions(+), 12 deletions(-)
oz_hcd_pd_departed() takes struct oz_port pointer instead of
void *, change function declaration to avoid ambiguity.
Reported-by: Dan Carpenter
Signed-off-by: Rupesh Gujare
---
drivers/staging/ozwpan/ozhcd.c |4 ++--
drivers/staging/ozwpan/ozhcd.h |2 +-
2 files changed, 3 insertions(+)
oz_hcd_pd_arrived returns struct oz_port *, change function
declaration to avoid ambiguity.
Reported-by: Dan Carpenter
Signed-off-by: Rupesh Gujare
---
drivers/staging/ozwpan/ozhcd.c |4 ++--
drivers/staging/ozwpan/ozhcd.h |2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --
Hello.
On 08/13/2013 09:29 PM, Rupesh Gujare wrote:
oz_hcd_pd_departed() takes struct oz_port pointer instead of
void *, change function declaration to avoid ambiguity.
Reported-by: Dan Carpenter
Signed-off-by: Rupesh Gujare
---
drivers/staging/ozwpan/ozhcd.c |4 ++--
drivers/stagin
On Tue, 2013-08-13 at 18:29 +0100, Rupesh Gujare wrote:
> Swap arguments of oz_ep_alloc() to match kmalloc() for better readability.
[]
> diff --git a/drivers/staging/ozwpan/ozhcd.c b/drivers/staging/ozwpan/ozhcd.c
[]
> -static struct oz_endpoint *oz_ep_alloc(gfp_t mem_flags, int buffer_size)
> +st
Since dma_map_single() may fail it is good to actually check the return
code to see if it succeeded.
Signed-off-by: Sebastian Andrzej Siewior
---
drivers/usb/musb/musb_gadget.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/musb/musb_gadget.c b/drivers/
rh_call_control() contains a buffer, tbuf, which it uses to hold
USB descriptors. These discriptors are eventually copied into the
transfer_buffer in the URB. The buffer in the URB is dynamically
defined and is always large enough to hold the amount of data it
requests.
tbuf is currently staticall
Hi,
tested a little with g_ncm on amm35x-evm.
Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Since the musb-gadget code now calls the dma engine properly it is
possible to enable it for the TX path in device mode.
AM335x Advisory 1.0.13 says that we may lose the toggle bit on multiple
RX transfers. There is a workaround in host mode but none in device mode
and therefore RX transfers are di
This patch makes use of the two function is_cppi_enabled() and
tusb_dma_omap() instead of the ifdef for the proper DMA implementation
setup code. It basically shifts the code right by one indention level
and adds a few line breaks once the chars are crossed.
Signed-off-by: Sebastian Andrzej Siewio
On 13/08/13 18:35, Sergei Shtylyov wrote:
Hello.
On 08/13/2013 09:29 PM, Rupesh Gujare wrote:
oz_hcd_pd_departed() takes struct oz_port pointer instead of
void *, change function declaration to avoid ambiguity.
Reported-by: Dan Carpenter
Signed-off-by: Rupesh Gujare
---
drivers/staging/
On Sat, Aug 10, 2013 at 04:04:02AM +, Paul Zimmerman wrote:
> > From: linux-usb-ow...@vger.kernel.org
> > [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Alexandra Yates
> > Sent: Friday, August 09, 2013 12:21 PM
>
> Hi Alexandra,
>
>
>
> >
> > +/* USB 2.0 BOS descriptor and a capab
On 08/13/2013 09:40 PM, Rupesh Gujare wrote:
oz_hcd_pd_departed() takes struct oz_port pointer instead of
void *, change function declaration to avoid ambiguity.
Reported-by: Dan Carpenter
Signed-off-by: Rupesh Gujare
---
drivers/staging/ozwpan/ozhcd.c |4 ++--
drivers/staging/ozwpan
Now pass the dma_controller to the macro that checks if a given dma
engine is available.
For consistency the all the macros start if is_dma_. The mentor and TUSB
is added and will be used later.
Signed-off-by: Sebastian Andrzej Siewior
---
drivers/usb/musb/davinci.c | 2 +-
drivers/usb/musb
If we check the use_dma before calling ->channel_program() then in case
of use_dma is 0 we don't have to remove the MUSB_TXCSR_DMAENAB bit
because we never set it.
Signed-off-by: Sebastian Andrzej Siewior
---
drivers/usb/musb/musb_gadget.c | 8
1 file changed, 4 insertions(+), 4 deletio
Hi,
the musb dma engine abstraction is basically hidden behind ifdefs and set
at compile time. This little incomplete series tries to push this check
to runtime time so we could enable more than one at compile time.
Any comments?
Sebastian
--
To unsubscribe from this list: send the line "unsubs
Signed-off-by: Sebastian Andrzej Siewior
---
drivers/usb/musb/musb_gadget.c | 76 --
1 file changed, 36 insertions(+), 40 deletions(-)
diff --git a/drivers/usb/musb/musb_gadget.c b/drivers/usb/musb/musb_gadget.c
index c685905..05a59d0 100644
--- a/drivers/
This patch defines four types of current supported DMA engines and
assignes them to each dma engine. This should get rid of a few ifdefs
later on.
Signed-off-by: Sebastian Andrzej Siewior
---
drivers/usb/musb/cppi_dma.c | 1 +
drivers/usb/musb/musb_cppi41.c | 1 +
drivers/usb/musb/musb_dm
Sebastian,
On Tue, Aug 13, 2013 at 12:38 PM, Sebastian Andrzej Siewior
wrote:
> Since the musb-gadget code now calls the dma engine properly it is
> possible to enable it for the TX path in device mode.
> AM335x Advisory 1.0.13 says that we may lose the toggle bit on multiple
> RX transfers. Ther
On Tue, Aug 13, 2013 at 10:07:58AM -0400, Alan Stern wrote:
> On Mon, 12 Aug 2013, Jack Pham wrote:
>
> > commit 9841f37a1c ("usb: ehci: Add support for SINGLE_STEP_SET_FEATURE
> > test of EHSET") added additional code to the EHCI hub driver but it is
> > anticipated to only have a limited audienc
On Tuesday 13 August 2013 19:27:52 Sergei Shtylyov wrote:
> Hello.
>
> On 08/13/2013 08:52 PM, Florian Wolter wrote:
> >>> Patch to Fix Problem with not cleared halted endpoint.
> >>>
> >>> See Bugtracker Bug 60699
> >>
> >> Hi Florian,
> >>
> >> You need to send your patch inline, not as an at
On Tue, Aug 13, 2013 at 11:18:24AM +0200, Marcin Zajączkowski wrote:
> Hi,
>
> I had no problem with a USB 3.0 port in my Asus N43SN since I bought a
> laptop (~2 years). Recently I replaced a motherboard to the new one
> (N43SL.413 looks the same as the first one) due to a problem with a
> graphi
On Mon, Aug 12, 2013 at 01:56:40PM +0200, Andreas Lillebø Holm wrote:
> When communicating with AT90USB1287, at random intervals (1/25 boots)
> the linux hid_output_field Oopses and kills the communicating thread.
> The AT90USB1287 microcontroller uses LUFA library for usb/hid
> communication. It
On 08/01/2013 09:00 AM, Tuomas Tynkkynen wrote:
> Hi all,
>
> Here's the device tree changes required for USB Host support on Tegra30 and
> Tegra114. This enables USB Host on the Cardhu's dock connector port and on the
> single built-in A-ports on Dalmore and Beaver.
I've applied this series to T
On Tue, 13 Aug 2013, Greg Kroah-Hartman wrote:
> On Tue, Aug 13, 2013 at 10:07:58AM -0400, Alan Stern wrote:
> > On Mon, 12 Aug 2013, Jack Pham wrote:
> >
> > > commit 9841f37a1c ("usb: ehci: Add support for SINGLE_STEP_SET_FEATURE
> > > test of EHSET") added additional code to the EHCI hub drive
Hi Alan,
Do you know if there's a chance that any USB drivers (or userspace)
would try to clear an endpoint halt when there are active URBs that have
not completed on for the endpoint?
I ask because in order to handle the case where userspace wants to reset
the toggles with a clear halt control t
Hi,
On Mon, Aug 05, 2013 at 03:41:57PM +, Wang, Yu Y wrote:
> Hi Balbi,
>
> Please check the attached logs. The kernel base one kernel3.10.
you didn't take the regdump after xHCI :-( I need to check if erst_base
is being mirrored to DEPCMDPAR*
--
balbi
signature.asc
Description: Digital
On Tue, Aug 13, 2013 at 01:11:47PM -0500, Bin Liu wrote:
> Sebastian,
>
> On Tue, Aug 13, 2013 at 12:38 PM, Sebastian Andrzej Siewior
> wrote:
> > Since the musb-gadget code now calls the dma engine properly it is
> > possible to enable it for the TX path in device mode.
> > AM335x Advisory 1.0.1
Hi,
On Mon, Aug 12, 2013 at 09:43:24AM +0800, Qiao Zhou wrote:
> On 08/02/2013 03:31 PM, Felipe Balbi wrote:
> >Hi,
> >
> >On Fri, Aug 02, 2013 at 01:15:33PM +0800, Qiao Zhou wrote:
> >>On 08/01/2013 06:21 PM, Qiao Zhou wrote:
> >>>v2->v1:
> >>>stop pcm stream instead of wake up the sleep thread,
Hi Greg,
Here's my pull request for v3.12 merge window. I know there are a bunch
of patches pending in the mailing list but I won't have time to fully
review them before merging so I decided that it's best to delay a merge
window than it is to cause a bunch of regressions.
Oh yeah, the patches un
On Tue, Aug 13, 2013 at 02:41:25PM -0500, Felipe Balbi wrote:
> Hi Greg,
>
> Here's my pull request for v3.12 merge window. I know there are a bunch
> of patches pending in the mailing list but I won't have time to fully
> review them before merging so I decided that it's best to delay a merge
> w
1 - 100 of 158 matches
Mail list logo
