Re: [PATCH v12 10/13] usb: chipidea: add wait vbus lower than OTGSC_BSV before role starts

On 07/11/2013 08:27 AM, Peter Chen wrote: > When the gadget role starts, we need to make sure the vbus is lower > than OTGSC_BSV, or there will be an vbus interrupt since we use > B_SESSION_VALID as vbus interrupt to indicate connect and disconnect. > When the host role starts, it may not be useful

Re: [PATCH] usb: gadget: fotg210-udc: Remove bogus __init/__exit annotations

On Wed, Jul 10, 2013 at 11:52 PM, Sergei Shtylyov wrote: > On 07/11/2013 01:45 AM, Geert Uytterhoeven wrote: > >> When builtin (CONFIG_USB_FOTG210_UDC=y): > >>LD drivers/usb/gadget/built-in.o >> WARNING: drivers/usb/gadget/built-in.o(.data+0xbf8): Section mismatch in >> reference from the

Re: [PATCH 5/6] USB: Support wakeup IRQ for suspended controllers

On 07/10/2013 10:08 PM, Alan Stern wrote: > On Wed, 10 Jul 2013, Roger Quadros wrote: > >> Some platforms e.g. ehci-omap can generate an interrupt >> (i.e. remote wakeup) even when the controller is suspended i.e. >> HW_ACCESSIBLE is cleared. >> >> Introduce a flag "has_wakeup_irq" in struct usb_h

Re: [PATCH 5/6] USB: Support wakeup IRQ for suspended controllers

On 07/10/2013 09:45 PM, Alan Stern wrote: > On Wed, 10 Jul 2013, Roger Quadros wrote: > >> Some platforms e.g. ehci-omap can generate an interrupt >> (i.e. remote wakeup) even when the controller is suspended i.e. >> HW_ACCESSIBLE is cleared. >> >> Introduce a flag "has_wakeup_irq" in struct usb_h

Re: Linux USB file storage gadget with new UDC

Hi, >> May i know which part of the do_set_config() or do_set_interface() has >> to be run in process context? > > Well, it's not exactly true that the routine has to run in process > context. More accurately, it has to run at a time when the main thread > isn't using any of the endpoints or requ

Re: [PATCH] usb: USB host support should depend on HAS_DMA

On Thu, Jul 11, 2013 at 3:01 AM, Alan Stern wrote: > On Thu, 11 Jul 2013, Arnd Bergmann wrote: > >> On Wednesday 10 July 2013, Alan Stern wrote: >> > This isn't right. There are USB host controllers that use PIO, not >> > DMA. The HAS_DMA dependency should go with the controller driver, not >> >

Re: [PATCH 6/6] USB: ehci-omap: Implement suspend/resume

On 07/10/2013 10:04 PM, Alan Stern wrote: > On Wed, 10 Jul 2013, Roger Quadros wrote: > >> Call ehci_suspend/resume() during runtime suspend/resume >> as well as system suspend/resume. >> >> Use a flag "bound" to indicate that the HCD structures are valid. >> This is only true between usb_add_hcd(

Re: Video corruption varies by system load

On Wed, Jul 10, 2013 at 09:13:09PM -0400, Alan Stern wrote: > On Wed, 10 Jul 2013, Devin Heitmueller wrote: > > > So one might ask: why is the em28xx device sending a microframe with > > corrupt bytes? One thing I've noticed is immediately prior to any > > microframe containing corruption, there

[PATCH 01/50] USB: devio: spin_lock in complete() cleanup

Complete() will be run with interrupt enabled, so change to spin_lock_irqsave(). Cc: Alan Stern Signed-off-by: Ming Lei --- drivers/usb/core/devio.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c index 0598650..21e

[PATCH 00/50] USB: cleanup spin_lock in URB->complete()

Hi, As we are going to run URB->complete() in tasklet context[1][2], and hard interrupt may be enabled when running URB completion handler[3], so we might need to disable interrupt when acquiring one lock in the completion handler for the below reasons: - URB->complete() holds a subsystem wide lo

[PATCH 07/50] USB: ldusb: spin_lock in complete() cleanup

Complete() will be run with interrupt enabled, so change to spin_lock_irqsave(). Signed-off-by: Ming Lei --- drivers/usb/misc/ldusb.c |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/usb/misc/ldusb.c b/drivers/usb/misc/ldusb.c index ac76229..8bae18e 100644 --

[PATCH 28/50] USBNET: kaweth: spin_lock in complete() cleanup

Complete() will be run with interrupt enabled, so change to spin_lock_irqsave(). Cc: net...@vger.kernel.org Signed-off-by: Ming Lei --- drivers/net/usb/kaweth.c |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/usb/kaweth.c b/drivers/net/usb/kaweth.c index

[PATCH 17/50] USB: serial: sierra: spin_lock in complete() cleanup

Complete() will be run with interrupt enabled, so change to spin_lock_irqsave(). Cc: Johan Hovold Signed-off-by: Ming Lei --- drivers/usb/serial/sierra.c |9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/usb/serial/sierra.c b/drivers/usb/serial/sierra.c ind

[PATCH 14/50] USB: serial: mos7720: spin_lock in complete() cleanup

Complete() will be run with interrupt enabled, so change to spin_lock_irqsave(). Cc: Johan Hovold Signed-off-by: Ming Lei --- drivers/usb/serial/mos7720.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/usb/serial/mos7720.c b/drivers/usb/serial/mos7720.c inde

[PATCH 24/50] input: cm109: spin_lock in complete() cleanup

Complete() will be run with interrupt enabled, so change to spin_lock_irqsave(). Cc: Dmitry Torokhov Cc: linux-in...@vger.kernel.org Signed-off-by: Ming Lei --- drivers/input/misc/cm109.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/input/misc/cm109.c

[PATCH 30/50] wireless: ath9k: spin_lock in complete() cleanup

Complete() will be run with interrupt enabled, so change to spin_lock_irqsave(). Cc: "Luis R. Rodriguez" Cc: "John W. Linville" Cc: linux-wirel...@vger.kernel.org Cc: net...@vger.kernel.org Signed-off-by: Ming Lei --- drivers/net/wireless/ath/ath9k/hif_usb.c | 29 ++-

[PATCH 21/50] hid: usbhid: spin_lock in complete() cleanup

Complete() will be run with interrupt enabled, so change to spin_lock_irqsave(). Cc: Jiri Kosina Cc: linux-in...@vger.kernel.org Signed-off-by: Ming Lei --- drivers/hid/usbhid/hid-core.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/hid/usbhid/hid-core.c b/

[PATCH 20/50] USB: serial: usb_wwan: spin_lock in complete() cleanup

Complete() will be run with interrupt enabled, so change to spin_lock_irqsave(). Cc: Johan Hovold Signed-off-by: Ming Lei --- drivers/usb/serial/usb_wwan.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/usb/serial/usb_wwan.c b/drivers/usb/serial/usb_wwan.c i

[PATCH 16/50] USB: serial: quatech2: spin_lock in complete() cleanup

Complete() will be run with interrupt enabled, so change to spin_lock_irqsave(). Cc: Johan Hovold Signed-off-by: Ming Lei --- drivers/usb/serial/quatech2.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/usb/serial/quatech2.c b/drivers/usb/serial/quatech2.c i

[PATCH 11/50] USB: serial: digi_acceleportldusb: spin_lock in complete() cleanup

Complete() will be run with interrupt enabled, so change to spin_lock_irqsave(). Cc: Peter Berger Cc: Al Borchers Signed-off-by: Ming Lei --- drivers/usb/serial/digi_acceleport.c | 23 +-- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/drivers/usb/serial/

[PATCH 19/50] USB: serial: ti_usb_3410_5052: spin_lock in complete() cleanup

Complete() will be run with interrupt enabled, so change to spin_lock_irqsave(). Cc: Johan Hovold Signed-off-by: Ming Lei --- drivers/usb/serial/ti_usb_3410_5052.c |9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/usb/serial/ti_usb_3410_5052.c b/drivers/us

[PATCH 46/50] Sound: usb: ua101: spin_lock in complete() cleanup

Complete() will be run with interrupt enabled, so disable local interrupt before holding a global lock which is held without irqsave. Cc: Clemens Ladisch Cc: Jaroslav Kysela Cc: Takashi Iwai Cc: alsa-de...@alsa-project.org Signed-off-by: Ming Lei --- sound/usb/misc/ua101.c | 14

[PATCH 12/50] USB: serial: io_edgeport: spin_lock in complete() cleanup

Complete() will be run with interrupt enabled, so change to spin_lock_irqsave(). Cc: Johan Hovold Signed-off-by: Ming Lei --- drivers/usb/serial/io_edgeport.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/usb/serial/io_edgeport.c b/drivers/usb/seri

[PATCH 35/50] media: usb: cx231xx: spin_lock in complete() cleanup

Complete() will be run with interrupt enabled, so change to spin_lock_irqsave(). Cc: Mauro Carvalho Chehab Cc: Hans Verkuil Cc: linux-me...@vger.kernel.org Signed-off-by: Ming Lei --- drivers/media/usb/cx231xx/cx231xx-audio.c |6 ++ drivers/media/usb/cx231xx/cx231xx-core.c | 10

[PATCH 18/50] USB: serial: symbolserial: spin_lock in complete() cleanup

Complete() will be run with interrupt enabled, so change to spin_lock_irqsave(). Cc: Johan Hovold Signed-off-by: Ming Lei --- drivers/usb/serial/symbolserial.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/usb/serial/symbolserial.c b/drivers/usb/serial/sym

[PATCH 42/50] media: usb: tlg2300: spin_lock in complete() cleanup

Complete() will be run with interrupt enabled, so disable local interrupt before holding a global lock which is held without irqsave. Cc: Mauro Carvalho Chehab Cc: linux-me...@vger.kernel.org Signed-off-by: Ming Lei --- drivers/media/usb/tlg2300/pd-alsa.c |3 +++ 1 file changed, 3 insertion

[PATCH 40/50] media: dvb-core: spin_lock in complete() cleanup

Complete() will be run with interrupt enabled, so change to spin_lock_irqsave(). These functions may be called inside URB->complete(), so use spin_lock_irqsave(). Cc: Mauro Carvalho Chehab Cc: linux-me...@vger.kernel.org Signed-off-by: Ming Lei --- drivers/media/dvb-core/dvb_demux.c | 17 +++

[PATCH 33/50] wireless: libertas: spin_lock in complete() cleanup

Complete() will be run with interrupt enabled, so change to spin_lock_irqsave(). Cc: "John W. Linville" Cc: libertas-...@lists.infradead.org Cc: linux-wirel...@vger.kernel.org Cc: net...@vger.kernel.org Signed-off-by: Ming Lei --- drivers/net/wireless/libertas/if_usb.c |5 +++-- 1 file chan

[PATCH 48/50] staging: bcm: spin_lock in complete() cleanup

Complete() will be run with interrupt enabled, so change to spin_lock_irqsave(). Cc: de...@driverdev.osuosl.org Signed-off-by: Ming Lei --- drivers/staging/bcm/InterfaceRx.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/bcm/InterfaceRx.c b/drivers/s

[PATCH 25/50] ISDN: hfcsusb: spin_lock in complete() cleanup

Complete() will be run with interrupt enabled, so change to spin_lock_irqsave(). Cc: Karsten Keil Cc: "David S. Miller" Cc: net...@vger.kernel.org Signed-off-by: Ming Lei --- drivers/isdn/hardware/mISDN/hfcsusb.c | 36 ++--- 1 file changed, 20 insertions(+), 16 de

[PATCH 09/50] USB: usbtest: spin_lock in complete() cleanup

Complete() will be run with interrupt enabled, so change to spin_lock_irqsave(). Signed-off-by: Ming Lei --- drivers/usb/misc/usbtest.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/usb/misc/usbtest.c b/drivers/usb/misc/usbtest.c index 8b4ca1c..5c73df5

[PATCH 50/50] staging: vt6656: spin_lock in complete() cleanup

Complete() will be run with interrupt enabled, so change to spin_lock_irqsave(). Cc: de...@driverdev.osuosl.org Signed-off-by: Ming Lei --- drivers/staging/vt6656/usbpipe.c |9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/staging/vt6656/usbpipe.c b/drivers/

RE: question on skel_read func of usb_skeleton.c‏

Thank you, Oliver. I'm getting to understand your code :) > From: oneu...@suse.de > To: unicorn_w...@outlook.com > CC: linux-usb@vger.kernel.org > Subject: Re: question on skel_read func of usb_skeleton.c‏ > Date: Tue, 9 Jul 2013 12:01:19 +0200 > > On Tuesda

[PATCH 13/50] USB: serial: io_ti: spin_lock in complete() cleanup

Complete() will be run with interrupt enabled, so change to spin_lock_irqsave(). Cc: Johan Hovold Signed-off-by: Ming Lei --- drivers/usb/serial/io_ti.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/usb/serial/io_ti.c b/drivers/usb/serial/io_ti.c index 6005

[PATCH 38/50] media: usb: tlg2300: spin_lock in complete() cleanup

Complete() will be run with interrupt enabled, so change to spin_lock_irqsave(). Cc: Mauro Carvalho Chehab Cc: linux-me...@vger.kernel.org Signed-off-by: Ming Lei --- drivers/media/usb/tlg2300/pd-video.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/media/u

[PATCH 15/50] USB: serial: mos77840: spin_lock in complete() cleanup

Complete() will be run with interrupt enabled, so change to spin_lock_irqsave(). Cc: Johan Hovold Signed-off-by: Ming Lei --- drivers/usb/serial/mos7840.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/usb/serial/mos7840.c b/drivers/usb/serial/mos7840.c inde

[PATCH 04/50] USB: adutux: spin_lock in complete() cleanup

Complete() will be run with interrupt enabled, so change to spin_lock_irqsave(). Cc: Lisa Nguyen Signed-off-by: Ming Lei --- drivers/usb/misc/adutux.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/usb/misc/adutux.c b/drivers/usb/misc/adutux.c index eb3

[PATCH 10/50] USB: serial: cyberjack: spin_lock in complete() cleanup

Complete() will be run with interrupt enabled, so change to spin_lock_irqsave(). Cc: Matthias Bruestle and Harald Welte Signed-off-by: Ming Lei --- drivers/usb/serial/cyberjack.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/usb/serial/cyberjack.c

[PATCH 27/50] USBNET: hso: spin_lock in complete() cleanup

Complete() will be run with interrupt enabled, so change to spin_lock_irqsave(). Cc: net...@vger.kernel.org Signed-off-by: Ming Lei --- drivers/net/usb/hso.c | 38 ++ 1 file changed, 22 insertions(+), 16 deletions(-) diff --git a/drivers/net/usb/hso.c b/dri

[PATCH 23/50] BT: bfusb: read_lock in complete() cleanup

Complete() will be run with interrupt enabled, so change to read_lock_irqsave(). Cc: Marcel Holtmann Cc: Gustavo Padovan Cc: Johan Hedberg Cc: linux-blueto...@vger.kernel.org Signed-off-by: Ming Lei --- drivers/bluetooth/bfusb.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletion

[PATCH 05/50] USB: misc: uss720: spin_lock in complete() cleanup

Complete() will be run with interrupt enabled, so change to spin_lock_irqsave(). Signed-off-by: Ming Lei --- drivers/usb/misc/uss720.c |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/usb/misc/uss720.c b/drivers/usb/misc/uss720.c index e129cf6..f7d15e8 100644 -

[PATCH 34/50] wireless: libertas_tf: spin_lock in complete() cleanup

Complete() will be run with interrupt enabled, so change to spin_lock_irqsave(). Cc: "John W. Linville" Cc: libertas-...@lists.infradead.org Cc: linux-wirel...@vger.kernel.org Cc: net...@vger.kernel.org Signed-off-by: Ming Lei --- drivers/net/wireless/libertas_tf/if_usb.c |6 -- 1 file

[PATCH 31/50] wireless: zd1211rw: spin_lock in complete() cleanup

Complete() will be run with interrupt enabled, so change to spin_lock_irqsave(). Cc: Daniel Drake Cc: Ulrich Kunitz Cc: "John W. Linville" Cc: linux-wirel...@vger.kernel.org Cc: net...@vger.kernel.org Signed-off-by: Ming Lei --- drivers/net/wireless/zd1211rw/zd_usb.c | 21 --

[PATCH 37/50] media: usb: sn9x102: spin_lock in complete() cleanup

Complete() will be run with interrupt enabled, so change to spin_lock_irqsave(). Cc: Mauro Carvalho Chehab Cc: linux-me...@vger.kernel.org Signed-off-by: Ming Lei --- drivers/media/usb/sn9c102/sn9c102_core.c |7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/m

[PATCH 47/50] staging: btmtk_usb: spin_lock in complete() cleanup

Complete() will be run with interrupt enabled, so change to spin_lock_irqsave(). Cc: de...@driverdev.osuosl.org Signed-off-by: Ming Lei --- drivers/staging/btmtk_usb/btmtk_usb.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/btmtk_usb/btmtk_usb.c b/d

[PATCH 36/50] media: usb: em28xx: spin_lock in complete() cleanup

Complete() will be run with interrupt enabled, so change to spin_lock_irqsave(). Cc: Mauro Carvalho Chehab Cc: linux-me...@vger.kernel.org Signed-off-by: Ming Lei --- drivers/media/usb/em28xx/em28xx-core.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/media

[PATCH 08/50] USB: legousbtower: spin_lock in complete() cleanup

Complete() will be run with interrupt enabled, so change to spin_lock_irqsave(). Cc: Juergen Stuber Signed-off-by: Ming Lei --- drivers/usb/misc/legousbtower.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/usb/misc/legousbtower.c b/drivers/usb/misc/legousbt

[PATCH 29/50] USBNET: rtl8150: spin_lock in complete() cleanup

Complete() will be run with interrupt enabled, so change to spin_lock_irqsave(). Cc: net...@vger.kernel.org Signed-off-by: Ming Lei --- drivers/net/usb/rtl8150.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/usb/rtl8150.c b/drivers/net/usb/rtl8150.c inde

[PATCH 26/50] USBNET: cdc-phonet: spin_lock in complete() cleanup

Complete() will be run with interrupt enabled, so change to spin_lock_irqsave(). Cc: net...@vger.kernel.org Signed-off-by: Ming Lei --- drivers/net/usb/cdc-phonet.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/usb/cdc-phonet.c b/drivers/net/usb/cdc-phon

[PATCH 41/50] media: usb: em28xx: make sure irq disabled before acquiring lock

Complete() will be run with interrupt enabled, so add local_irq_save() before acquiring the lock without irqsave(). Cc: Mauro Carvalho Chehab Cc: linux-me...@vger.kernel.org Signed-off-by: Ming Lei --- drivers/media/usb/em28xx/em28xx-audio.c |3 +++ 1 file changed, 3 insertions(+) diff --g

[PATCH 22/50] BT: btusb: spin_lock in complete() cleanup

Complete() will be run with interrupt enabled, so change to spin_lock_irqsave(). Cc: Marcel Holtmann Cc: Gustavo Padovan Cc: Johan Hedberg Cc: linux-blueto...@vger.kernel.org Signed-off-by: Ming Lei --- drivers/bluetooth/btusb.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) d

[PATCH 44/50] sound: usb: caiaq: spin_lock in complete() cleanup

Complete() will be run with interrupt enabled, so change to spin_lock_irqsave(). Cc: Daniel Mack Cc: Jaroslav Kysela Cc: Takashi Iwai Cc: alsa-de...@alsa-project.org Signed-off-by: Ming Lei --- sound/usb/caiaq/audio.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a

[PATCH 45/50] sound: usb: usx2y: spin_lock in complete() cleanup

Complete() will be run with interrupt enabled, so change to spin_lock_irqsave(). Cc: Jaroslav Kysela Cc: Takashi Iwai Cc: alsa-de...@alsa-project.org Signed-off-by: Ming Lei --- sound/usb/usx2y/usbusx2yaudio.c |4 1 file changed, 4 insertions(+) diff --git a/sound/usb/usx2y/usbusx2ya

[PATCH 39/50] media: usb: tm6000: spin_lock in complete() cleanup

Complete() will be run with interrupt enabled, so change to spin_lock_irqsave(). Cc: Mauro Carvalho Chehab Cc: linux-me...@vger.kernel.org Signed-off-by: Ming Lei --- drivers/media/usb/tm6000/tm6000-video.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/medi

[PATCH 49/50] staging: ced1401: spin_lock in complete() cleanup

Complete() will be run with interrupt enabled, so change to spin_lock_irqsave(). Cc: de...@driverdev.osuosl.org Signed-off-by: Ming Lei --- drivers/staging/ced1401/usb1401.c | 35 +++ 1 file changed, 19 insertions(+), 16 deletions(-) diff --git a/drivers/stagin

[PATCH 43/50] sound: usb: midi: spin_lock in complete() cleanup

Complete() will be run with interrupt enabled, so change to spin_lock_irqsave(). Cc: Jaroslav Kysela Cc: Takashi Iwai Cc: Clemens Ladisch Cc: alsa-de...@alsa-project.org Signed-off-by: Ming Lei --- sound/usb/midi.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/so

[PATCH 06/50] USB: iowarrior: spin_lock in complete() cleanup

Complete() will be run with interrupt enabled, so change to spin_lock_irqsave(). Signed-off-by: Ming Lei --- drivers/usb/misc/iowarrior.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/usb/misc/iowarrior.c b/drivers/usb/misc/iowarrior.c index d36f34e..010ed6d

[RFC] ux500 dma & short transfers on MUSB

Hello, following scenario: you attach an UART-TO-USB adapter to your musb port running ux500-dma code. The USB UARt driver queues 1x RX URB with the size of 256 bytes (example) and the max packet size is 64. The other side sends only one byte because it is mean. Now, the way I understand it is, y

[PATCH 32/50] wireless: ath: carl9170: spin_lock in complete() cleanup

Complete() will be run with interrupt enabled, so change to spin_lock_irqsave(). Cc: Christian Lamparter Cc: "John W. Linville" Cc: linux-wirel...@vger.kernel.org Cc: net...@vger.kernel.org Signed-off-by: Ming Lei --- drivers/net/wireless/ath/carl9170/rx.c |5 +++-- 1 file changed, 3 inser

[PATCH 03/50] USB: usblp: spin_lock in complete() cleanup

Complete() will be run with interrupt enabled, so change to spin_lock_irqsave(). Cc: Pete Zaitcev Signed-off-by: Ming Lei --- drivers/usb/class/usblp.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/usb/class/usblp.c b/drivers/usb/class/usblp.c index d4

Re: [PATCH v12 10/13] usb: chipidea: add wait vbus lower than OTGSC_BSV before role starts

On Thu, Jul 11, 2013 at 09:24:56AM +0200, Marc Kleine-Budde wrote: > On 07/11/2013 08:27 AM, Peter Chen wrote: > > When the gadget role starts, we need to make sure the vbus is lower > > than OTGSC_BSV, or there will be an vbus interrupt since we use > > B_SESSION_VALID as vbus interrupt to indicat

[PATCH 02/50] USB: cdc-wdm: spin_lock in complete() cleanup

Complete() will be run with interrupt enabled, so change to spin_lock_irqsave(). Cc: Oliver Neukum Signed-off-by: Ming Lei --- drivers/usb/class/cdc-wdm.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/usb/class/cdc-wdm.c b/drivers/usb/class/cdc-

Re: [PATCH v12 10/13] usb: chipidea: add wait vbus lower than OTGSC_BSV before role starts

On 07/11/2013 11:25 AM, Peter Chen wrote: > On Thu, Jul 11, 2013 at 09:24:56AM +0200, Marc Kleine-Budde wrote: >> On 07/11/2013 08:27 AM, Peter Chen wrote: >>> When the gadget role starts, we need to make sure the vbus is lower >>> than OTGSC_BSV, or there will be an vbus interrupt since we use >>>

Announcing libusbx-1.0.16 final

Hi All, I'm very happy to announce the official libusbx-1.0.16 release! Highlights of changes since 1.0.15: --- * As Nathan Hjelm already announced in his "libusb and libusbx merging" mail, Nathan has taken over libusb maintenance and this release is a combined ef

Re: [PATCH 05/50] USB: misc: uss720: spin_lock in complete() cleanup

Hello. On 11-07-2013 13:05, Ming Lei wrote: Complete() will be run with interrupt enabled, so change to spin_lock_irqsave(). Signed-off-by: Ming Lei --- drivers/usb/misc/uss720.c |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/usb/misc/uss720.c b/dri

Re: [PATCH 08/50] USB: legousbtower: spin_lock in complete() cleanup

Hello. On 11-07-2013 13:05, Ming Lei wrote: Complete() will be run with interrupt enabled, so change to spin_lock_irqsave(). Cc: Juergen Stuber Signed-off-by: Ming Lei --- drivers/usb/misc/legousbtower.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drive

[PATCH] staging: dwc2: fix value used in dwc2_set_all_params

From: Julien Delacou This fix uses 'value' parameter as it should be instead of hardcoded -1. Signed-off-by: Julien Delacou Acked-by: Paul Zimmerman --- drivers/staging/dwc2/hcd.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/dwc2/hcd.c b/drivers/stagi

Re: [PATCH 08/50] USB: legousbtower: spin_lock in complete() cleanup

On Thursday 11 July 2013 16:18:17 Sergei Shtylyov wrote: > I don't think this patch passes checkpatch.pl. This series is a mechanical replacement in dozens of drivers. We cannot demand nice formatting. If you want to do something productive, check the locking in the driver. Regards

Re: [PATCH 08/50] USB: legousbtower: spin_lock in complete() cleanup

On Thu, Jul 11, 2013 at 8:18 PM, Sergei Shtylyov wrote: > Hello. > > > On 11-07-2013 13:05, Ming Lei wrote: > >> Complete() will be run with interrupt enabled, so change to >> spin_lock_irqsave(). > > >> Cc: Juergen Stuber >> Signed-off-by: Ming Lei >> --- >> drivers/usb/misc/legousbtower.c |

Re: [PATCH 36/50] media: usb: em28xx: spin_lock in complete() cleanup

On Thu, Jul 11, 2013 at 5:05 AM, Ming Lei wrote: > Complete() will be run with interrupt enabled, so change to > spin_lock_irqsave(). > > Cc: Mauro Carvalho Chehab > Cc: linux-me...@vger.kernel.org > Signed-off-by: Ming Lei > --- > drivers/media/usb/em28xx/em28xx-core.c |5 +++-- > 1 file c

Re: [PATCH 17/50] USB: serial: sierra: spin_lock in complete() cleanup

Hello. On 11-07-2013 13:05, Ming Lei wrote: Complete() will be run with interrupt enabled, so change to spin_lock_irqsave(). Cc: Johan Hovold Signed-off-by: Ming Lei --- drivers/usb/serial/sierra.c |9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers

Re: [PATCH 45/50] sound: usb: usx2y: spin_lock in complete() cleanup

On 11-07-2013 13:06, Ming Lei wrote: Complete() will be run with interrupt enabled, so change to spin_lock_irqsave(). Changelog doesn't match the patch. Cc: Jaroslav Kysela Cc: Takashi Iwai Cc: alsa-de...@alsa-project.org Signed-off-by: Ming Lei --- sound/usb/usx2y/usbusx2yaudio.c |

Re: [PATCH 44/50] sound: usb: caiaq: spin_lock in complete() cleanup

On 11-07-2013 13:06, Ming Lei wrote: Complete() will be run with interrupt enabled, so change to spin_lock_irqsave(). Cc: Daniel Mack Cc: Jaroslav Kysela Cc: Takashi Iwai Cc: alsa-de...@alsa-project.org Signed-off-by: Ming Lei --- sound/usb/caiaq/audio.c |5 +++-- 1 file changed, 3

Re: [PATCH 46/50] Sound: usb: ua101: spin_lock in complete() cleanup

On 11-07-2013 13:06, Ming Lei wrote: Here the subject doesn't match the patch. Complete() will be run with interrupt enabled, so disable local interrupt before holding a global lock which is held without irqsave. Cc: Clemens Ladisch Cc: Jaroslav Kysela Cc: Takashi Iwai Cc: alsa-de...@a

Re: [PATCH 42/50] media: usb: tlg2300: spin_lock in complete() cleanup

On 11-07-2013 13:06, Ming Lei wrote: Subject doesn't match the patch. Complete() will be run with interrupt enabled, so disable local interrupt before holding a global lock which is held without irqsave. Cc: Mauro Carvalho Chehab Cc: linux-me...@vger.kernel.org Signed-off-by: Ming Lei --

Re: [PATCH 08/50] USB: legousbtower: spin_lock in complete() cleanup

Hello. On 11-07-2013 16:36, Oliver Neukum wrote: I don't think this patch passes checkpatch.pl. This series is a mechanical replacement in dozens of drivers. That mechanicity shows too much in some patches. We cannot demand nice formatting. If you want to do something productive

Re: [PATCH 45/50] sound: usb: usx2y: spin_lock in complete() cleanup

At Thu, 11 Jul 2013 17:08:30 +0400, Sergei Shtylyov wrote: > > On 11-07-2013 13:06, Ming Lei wrote: > > > Complete() will be run with interrupt enabled, so change to > > spin_lock_irqsave(). > > Changelog doesn't match the patch. Yep, but moreover... > > Cc: Jaroslav Kysela > > Cc: Takash

[PATCH 5/6] usb: gadget: USB_MV_U3D should depend on HAS_DMA

If NO_DMA=y: drivers/built-in.o: In function `mv_u3d_done': drivers/usb/gadget/mv_u3d_core.c:206: undefined reference to `dma_pool_free' drivers/usb/gadget/mv_u3d_core.c:209: undefined reference to `dma_unmap_single' drivers/built-in.o: In function `mv_u3d_build_trb_one': drivers/usb/gadget/mv_u3d

[PATCH 3/6] usb: gadget: USB_MV_UDC should depend on HAS_DMA

If NO_DMA=y: drivers/built-in.o: In function `done': drivers/usb/gadget/mv_udc_core.c:239: undefined reference to `dma_pool_free' drivers/built-in.o: In function `build_dtd': drivers/usb/gadget/mv_udc_core.c:371: undefined reference to `dma_pool_alloc' drivers/built-in.o: In function `udc_prime_st

[PATCH 6/6] [RFC] usb: gadget: USB_GADGET should depend on HAS_DMA

If NO_DMA=y: drivers/built-in.o: In function `dma_set_coherent_mask': include/linux/dma-mapping.h:93: undefined reference to `dma_supported' include/linux/dma-mapping.h:93: undefined reference to `dma_supported' drivers/built-in.o: In function `usb_gadget_unmap_request': drivers/usb/gadget/udc-cor

[PATCH 1/6] usb: dwc3: USB_DWC3 should depend on HAS_DMA

If NO_DMA=y: drivers/built-in.o: In function `dwc3_free_one_event_buffer': drivers/usb/dwc3/core.c:132: undefined reference to `dma_free_coherent' drivers/built-in.o: In function `dwc3_alloc_one_event_buffer': drivers/usb/dwc3/core.c:154: undefined reference to `dma_alloc_coherent' drivers/built-i

[PATCH 4/6] usb: gadget: USB_FOTG210_UDC should depend on HAS_DMA

If NO_DMA=y: drivers/built-in.o: In function `fotg210_start_dma': drivers/usb/gadget/fotg210-udc.c:354: undefined reference to `dma_map_single' drivers/usb/gadget/fotg210-udc.c:357: undefined reference to `dma_mapping_error' drivers/usb/gadget/fotg210-udc.c:362: undefined reference to `dma_sync_s

[PATCH 2/6] usb: chipidea: USB_CHIPIDEA_UDC should depend on HAS_DMA

If NO_DMA=y: drivers/built-in.o: In function `dma_set_coherent_mask': include/linux/dma-mapping.h:93: undefined reference to `dma_supported' drivers/built-in.o: In function `destroy_eps': drivers/usb/chipidea/udc.c:1598: undefined reference to `dma_pool_free' drivers/built-in.o: In function `free_

Re: [PATCH 17/50] USB: serial: sierra: spin_lock in complete() cleanup

On Thu, Jul 11, 2013 at 9:02 PM, Sergei Shtylyov wrote: > Hello. > > > On 11-07-2013 13:05, Ming Lei wrote: > >> Complete() will be run with interrupt enabled, so change to >> spin_lock_irqsave(). > > >> Cc: Johan Hovold >> Signed-off-by: Ming Lei >> --- >> drivers/usb/serial/sierra.c |9 +

Re: [PATCH 44/50] sound: usb: caiaq: spin_lock in complete() cleanup

On 11.07.2013 11:06, Ming Lei wrote: > Complete() will be run with interrupt enabled, so change to > spin_lock_irqsave(). > > Cc: Daniel Mack > Cc: Jaroslav Kysela > Cc: Takashi Iwai > Cc: alsa-de...@alsa-project.org > Signed-off-by: Ming Lei Sound right to me, thanks. Acked-by: Daniel Mack

Re: [PATCH 45/50] sound: usb: usx2y: spin_lock in complete() cleanup

On Thu, Jul 11, 2013 at 9:50 PM, Takashi Iwai wrote: > At Thu, 11 Jul 2013 17:08:30 +0400, > Sergei Shtylyov wrote: >> >> On 11-07-2013 13:06, Ming Lei wrote: >> >> > Complete() will be run with interrupt enabled, so change to >> > spin_lock_irqsave(). >> >> Changelog doesn't match the patch.

Re: [PATCH 45/50] sound: usb: usx2y: spin_lock in complete() cleanup

At Thu, 11 Jul 2013 22:13:35 +0800, Ming Lei wrote: > > On Thu, Jul 11, 2013 at 9:50 PM, Takashi Iwai wrote: > > At Thu, 11 Jul 2013 17:08:30 +0400, > > Sergei Shtylyov wrote: > >> > >> On 11-07-2013 13:06, Ming Lei wrote: > >> > >> > Complete() will be run with interrupt enabled, so change to >

Re: [PATCH 45/50] sound: usb: usx2y: spin_lock in complete() cleanup

On Thu, Jul 11, 2013 at 10:34 PM, Takashi Iwai wrote: > At Thu, 11 Jul 2013 22:13:35 +0800, > Ming Lei wrote: >> >> On Thu, Jul 11, 2013 at 9:50 PM, Takashi Iwai wrote: >> > At Thu, 11 Jul 2013 17:08:30 +0400, >> > Sergei Shtylyov wrote: >> >> >> >> On 11-07-2013 13:06, Ming Lei wrote: >> >> >> >

Re: Audio I/O parameters

On Thu, 11 Jul 2013, James Stone wrote: > Hi Clemens, > > On Mon, Jul 8, 2013 at 2:12 PM, James Stone wrote: > > >> Acquire audio card Audio0 > >> creating alsa driver ... hw:USB,0|-|64|2|44100|0|0|nomon|swmeter|-|16bit > >> Using ALSA driver USB-Audio running on card 0 - Focusrite Scarlett 2i4

Re: Linux USB file storage gadget with new UDC

On Thu, 11 Jul 2013, Victor Yeo wrote: > Thanks. The USBCV test has tight timing requirement. Once Set-Config > request is sent out, USBCV sends out Get-Config request to get the > config value immediately. At that time, gadget driver has not yet done > the handle_exception. So Get-Config request

Re: [PATCH] usb: USB host support should depend on HAS_DMA

On Thu, 11 Jul 2013, Geert Uytterhoeven wrote: > On Thu, Jul 11, 2013 at 3:01 AM, Alan Stern wrote: > > On Thu, 11 Jul 2013, Arnd Bergmann wrote: > > > >> On Wednesday 10 July 2013, Alan Stern wrote: > >> > This isn't right. There are USB host controllers that use PIO, not > >> > DMA. The HAS_D

Re: [PATCH 6/6] USB: ehci-omap: Implement suspend/resume

On Thu, 11 Jul 2013, Roger Quadros wrote: > > The other two problems are both related to the interaction between > > system PM and runtime PM. Suppose the controller is already runtime > > suspended when the system goes to sleep. Because it is runtime > > suspended, it is enabled for wakeup. Bu

Re: Video corruption varies by system load

On Thu, 11 Jul 2013, Johannes Stezenbach wrote: > I took a peek at the usbmon log, and there is one thing I don't get. > > $ grep "C Zi:1:005:2" em28xx_usbmon.log | less -S > > There are several cases where the isoc descriptor actual length is > short (< 2892, e.g. 0, 552 or 1928), yet the act

Re: [PATCH v12 06/13] usb: chipidea: add otg_cap attribute for otg capable

Dear Peter Chen, > Since we need otgsc to know vbus's status at some chipidea > controllers even it is peripheral-only mode. Besides, some > SoCs (eg, AR9331 SoC) don't have otgsc register even > the DCCPARAMS_DC and DCCPARAMS_HC are both 1 at CAP_DCCPARAMS. > We inroduce otg_cap attribute to indi

Re: [PATCH 03/50] USB: usblp: spin_lock in complete() cleanup

On Thu, 11 Jul 2013 17:05:26 +0800 Ming Lei wrote: > Complete() will be run with interrupt enabled, so change to > spin_lock_irqsave(). > > Cc: Pete Zaitcev > Signed-off-by: Ming Lei Signed-off-by: Pete Zaitcev Good luck with that, Ming. I think the spin_lock_irqsave thing should've been do

Re: [PATCH 6/6] [RFC] usb: gadget: USB_GADGET should depend on HAS_DMA

On Thu, 11 Jul 2013, Geert Uytterhoeven wrote: > If NO_DMA=y: > > drivers/built-in.o: In function `dma_set_coherent_mask': > include/linux/dma-mapping.h:93: undefined reference to `dma_supported' > include/linux/dma-mapping.h:93: undefined reference to `dma_supported' > drivers/built-in.o: In fun

Re: Video corruption varies by system load

On Thu, Jul 11, 2013 at 11:28:38AM -0400, Alan Stern wrote: > On Thu, 11 Jul 2013, Johannes Stezenbach wrote: > > > Can you confirm that in the error case there is no IN token at all? > > That's what the analyzer log showed. Of course, it's possible that the > analyzer itself was faulty, but I d

Help adding trace events to xHCI

On Mon, Jul 08, 2013 at 09:17:59PM +0300, Xenia Ragiadakou wrote: > Hi Sarah, Hi Xenia, Comments below. (Mentors and wireless folks, we're struggling a bit with adding trace events to the xHCI USB host controller driver. I'm trying to look at the ath6kl driver trace events as an example. We co

Re: [PATCH] staging: dwc2: fix value used in dwc2_set_all_params

On Thu, Jul 11, 2013 at 02:24:10PM +0200, Julien Delacou wrote: > From: Julien Delacou > > This fix uses 'value' parameter as it should be instead > of hardcoded -1. Woops! > Signed-off-by: Julien Delacou > Acked-by: Paul Zimmerman Reviewed-by: Matthijs Kooijman > --- > drivers/staging/dwc2

Re: inconsistent {IN-HARDIRQ-W} -> {HARDIRQ-ON-W} usage with hcd_urb_list_lock

On Sat, Jul 06, 2013 at 04:48:47PM -0400, Alan Stern wrote: > On Sat, 6 Jul 2013, Maarten Lankhorst wrote: > > > I didn't even know I still had lockdep on. > > The following lockdep splat happened when I plugged in a usb bluetooth > > dongle, using > > the pre-rc1 3.11 kernel at HEAD b2c311075db

  1   2   >