Hi,
>> f59e13c0 3246885432 S Bo:2:046:1 -115 31 = 55534243 0c00 0010
>> 8a28 0008 00
>> f59e13c0 3246885582 C Bo:2:046:1 0 31 >
>> f59e15c0 3246885594 S Bi:2:046:1 -115 4096 <
>> f59e15c0 3247150217 C Bi:2:046:1 -75 0
>
> This is the problem. -75 is -EOVERFLO
On Friday 29 March 2013 05:24:27 B, Ravi wrote:
> On Thu, Mar 28, 2013 at 9:27 PM, Felipe Balbi wrote:
> On Thu, Mar 28, 2013 at 03:23:46PM +0200, Felipe Balbi wrote:
> > On Thu, Mar 28, 2013 at 08:53:03PM +0800, Ming Lei wrote:
> > > On Thu, Mar 28, 2013 at 8:30 PM, B, Ravi wrote:
> > > > For exa
Laurent
> > > On Thu, Mar 28, 2013 at 08:53:03PM +0800, Ming Lei wrote:
> > > > On Thu, Mar 28, 2013 at 8:30 PM, B, Ravi wrote:
> > > > > For example, in one iteration I have observed, the time taken by
> > > > > uvc_video_decode_isoc() was 2175 usec. In this maximum amount of
> > > > > time was
>
> Laurent
>
> > > > On Thu, Mar 28, 2013 at 08:53:03PM +0800, Ming Lei wrote:
> > > > > On Thu, Mar 28, 2013 at 8:30 PM, B, Ravi wrote:
> > > > > > For example, in one iteration I have observed, the time taken by
> > > > > > uvc_video_decode_isoc() was 2175 usec. In this maximum amount of
> >
Laurent
> > > > Since the uvc_video_complete() callback handler called from
> interrupt
> > > > context, video post processing or memcpy can be deferred to tasklet
> or
> > > > bottom half, rather than doing it in interrupt context.
> > >
> > > If that's the only way to fix the issue, yes. Howeve
On Thu, 28 Mar 2013, Arnd Bergmann wrote:
> Patch 4d053fdac3 "usb: ehci: unlink_empty_async_suspended() only used
> with CONFIG_PM" tried to hide the unlink_empty_async_suspended function
> inside of an #ifdef to work around an unused function warning.
>
> Unfortunately that had the effect of int
On Fri, 29 Mar 2013, Tony Prisk wrote:
> On 29/03/13 10:16, Arnd Bergmann wrote:
> > On Thursday 28 March 2013, Arnd Bergmann wrote:
> >> Patch 4d053fdac3 "usb: ehci: unlink_empty_async_suspended() only used
> >> with CONFIG_PM" tried to hide the unlink_empty_async_suspended function
> >> inside o
On Fri, 29 Mar 2013, Lan Tianyu wrote:
> Actually, I exposed pm qos flags for usb port via dev_pm_qos_expose_flags().
> It creates power/pm_qos_no_power_off under usb port sysfs directory.
> User can echo 0 > pm_qos_no_power_off to power off the empty port.
Before it's too late, we should conside
Laurent/Ming Lei
>
> > > > > Since the uvc_video_complete() callback handler called from
> > interrupt
> > > > > context, video post processing or memcpy can be deferred to
> tasklet
> > or
> > > > > bottom half, rather than doing it in interrupt context.
> > > >
> > > > If that's the only way to
On Fri, 29 Mar 2013, victor yeo wrote:
> Thanks. Working on this problem now. Another problem observed for
> SCSI_READ_10 command, when reading from the SD card, the gadget driver
> never sends the MBR address, the FAT boot record address, the start of FAT
> address, and the start of FAT cluster a
Svetoslav Neykov writes:
> Hi Michael,
>
> On Thu, March 28, 2013 4:13 PM Michael Grzeschik wrote:
>>On Thu, Mar 28, 2013 at 11:28:32AM +0200, Alexander Shishkin wrote:
>>> Svetoslav Neykov writes:
>>>
>>> > Convert between big-endian and little-endian format when accessing the
> usb controlle
Svetoslav Neykov writes:
> Alexander Shishkin wrote:
>> Svetoslav Neykov writes:
>>
>>> Convert between big-endian and little-endian format when accessing the
> usb controller structures which are little-endian by specification.
>>> Fix cases where the little-endian memory layout is taken for gr
Michael Grzeschik writes:
> This patch changes the read of the td status to one atomic operation to
> analyse coherent bits.
>
> Signed-off-by: Michael Grzeschik
> ---
> drivers/usb/chipidea/udc.c | 8 +---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/usb/chipi
Michael Grzeschik writes:
> This patch reworks the cap value from several read
> and write operations to one single operation.
>
> Signed-off-by: Michael Grzeschik
> Reviewed-by: Felipe Balbi
> ---
> drivers/usb/chipidea/udc.c | 17 -
> 1 file changed, 8 insertions(+), 9 deleti
Michael Grzeschik writes:
> The prepared memory for the qhead needs to be contiguos and 2K aligned.
> We change the code from allocating extra buffer for every ep qhead to
> one big area. This patch lowers the amount of code to prepare the
> memory.
>
> Signed-off-by: Michael Grzeschik
> ---
>
Hi,
I am currently looking into a seeming regression in ehci-hub.c where a change
triggered by the behaviour of the MAX4967 USB power supply chip has broken the
handling of the MPC8349 USB controller at that point. I'd like to come up
with a patch solving the issue for both chips and would appreci
Michael Grzeschik writes:
> Hi,
Hi,
> this series contains simples fixes and cleanup patches for
> the chipidea udc. It is based on Alexander Shishkins ci-for-greg.
This is not really true, since your 7/8 relied on the alignment fix,
which didn't make it anywhere yet.
Some other problems I fo
Hi,
>> Thanks. Working on this problem now. Another problem observed for
>> SCSI_READ_10 command, when reading from the SD card, the gadget driver
>> never sends the MBR address, the FAT boot record address, the start of FAT
>> address, and the start of FAT cluster address to the SD card driver.
>
Hi,
I have massaged some more patches into the chipidea tree and rebased it
on top of updated usb-next. Currently we have 26 patches:
* reworked debugging,
* a ton of fixes from Michael and some from others,
* usbmisc updates, added quirks for imx25 and imx53,
* support for big-endian cpus
Greg KH writes:
> If I don't hear back from you by Wednesday this week, with a specific
> plan for how to get all of these fixes to me by the end of this week,
> I'm going to assume that you are missing, and will just start taking
> chipidea patches directly myself, sorry.
Actually it looks like
On Fri, Mar 29, 2013 at 06:00:36PM +0200, Alexander Shishkin wrote:
> Greg KH writes:
>
> > If I don't hear back from you by Wednesday this week, with a specific
> > plan for how to get all of these fixes to me by the end of this week,
> > I'm going to assume that you are missing, and will just s
On Fri, 29 Mar 2013, Christian Engelmayer wrote:
> Hi,
>
> I am currently looking into a seeming regression in ehci-hub.c where a change
> triggered by the behaviour of the MAX4967 USB power supply chip has broken the
> handling of the MPC8349 USB controller at that point. I'd like to come up
> w
Hi Alexander,
On Fri, Mar 29, 2013 at 05:32:59PM +0200, Alexander Shishkin wrote:
> Michael Grzeschik writes:
> > usb: chipidea: udc: don't truncate requests to single tds
> > usb: chipidea: udc: move _ep_queue into an unlocked function
> > usb: chipidea: udc: prepare qhead with dma_alloc_c
On Fri, Mar 29, 2013 at 02:37:24PM +0800, Lan Tianyu wrote:
> On 2013/3/29 6:43, Sarah Sharp wrote:
> >On Thu, Mar 28, 2013 at 05:00:23PM -0400, Alan Stern wrote:
> >>On Thu, 28 Mar 2013, Sarah Sharp wrote:
> >>>On Thu, Mar 28, 2013 at 01:11:02AM +0800, Lan Tianyu wrote:
> >Now I'm a bit confused a
Hi guys,
This is a resend (and v3) of my patch:
http://permalink.gmane.org/gmane.linux.usb.general/67238
At this moment it has been successfully tested and
used on top of 3.0 and 3.4 kernels on omap4 devices
so it would be great to have it in upstream too.
Regards,
Ruslan
v3: Implementation has
MUSB controller cannot work in DMA mode with misaligned buffers,
switching in PIO mode.
HCD core has hooks that allow to override the default DMA
mapping and unmapping routines for host controllers that have
special DMA requirements, such as alignment constraints.
It is observed that work in PIO
On Fri, 29 Mar 2013, Sarah Sharp wrote:
> However, what happens if you echo 0 to pm_qos_no_power_off, the
> power/control is set to auto, and there's a suspended USB device
> attached to the port with remote wakeup enabled? Will the port be
> powered off? I don't think it will with the current p
On Thu, 28 Mar 2013, Arnd Bergmann wrote:
> From: Manjunath Goudar
>
> Separate the Orion host controller driver from ehci-hcd host
> code into its own driver module because of following reason.
...
On the whole this patch is good.
> --- a/drivers/usb/host/Kconfig
> +++ b/drivers/usb/host/Kcon
On Thu, 28 Mar 2013, Arnd Bergmann wrote:
> From: Manjunath Goudar
>
> Separate the SPEAr host controller driver from ehci-hcd host code
> so that it can be built as a separate driver module.
> This work is part of enabling multi-platform kernels on ARM;
> however, note that other changes are st
On Fri, Mar 29, 2013 at 01:23:14PM -0400, Alan Stern wrote:
> On Fri, 29 Mar 2013, Sarah Sharp wrote:
>
> > However, what happens if you echo 0 to pm_qos_no_power_off, the
> > power/control is set to auto, and there's a suspended USB device
> > attached to the port with remote wakeup enabled? Wil
From: Dan Williams
Date: Thu, 28 Mar 2013 11:30:07 -0500
> + if (test_bit (EVENT_DEV_ASLEEP, &dev->flags))
> + return -EINVAL;
> +
> + mutex_lock (&dev->interrupt_mutex);
Please do not put a space between a function name and the openning
parenthesis in the call.
These are no
Please respin this along with patch #1 when you fix the coding
style issues I mentioned, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, 28 Mar 2013, Arnd Bergmann wrote:
> From: Manjunath Goudar
>
> Separate the Samsung S5P/EXYNOS host controller driver from ehci-hcd
> host code so that it can be built as a separate driver module.
> This work is part of enabling multi-platform kernels on ARM;
> however, note that other
On Thu, 28 Mar 2013, Arnd Bergmann wrote:
> The ehci_shutdown function is used by the platform specific ehci backends
> for at91, tegra and ps3. In order to turn any of these into separate
> modules, we need to make this function globally visible and export it.
Actually, I think this is not neces
On Thu, 28 Mar 2013, Arnd Bergmann wrote:
> From: Manjunath Goudar
>
> Separate the Atmel host controller driver from ehci-hcd host code
> so that it can be built as a separate driver module.
> This work is part of enabling multi-platform kernels on ARM;
> however, note that other changes are st
On Thu, 28 Mar 2013, Arnd Bergmann wrote:
> From: Manjunath Goudar
>
> Separate the Qualcomm QSD/MSM on-chip host controller driver from
> ehci-hcd host code so that it can be built as a separate driver module.
> This work is part of enabling multi-platform kernels on ARM;
> however, note that
On Thu, 28 Mar 2013, Arnd Bergmann wrote:
> Like the EHCI driver, OHCI supports a large number of different platform
> glue drivers by directly including them, which causes problems with
> conflicting macro definitions in some cases. As more ARM architecture
> specific back-ends are required to co
On Fri, 29 Mar 2013, Sarah Sharp wrote:
> > Also, bear in mind that the proposed patch does not give userspace a
> > way to power off ports via usbfs. What the new code does is a
> > power-off reset -- it turns off power to the port, waits a short time,
> > and then turns power back on.
>
> I
Hello Florian,
On Tue, 26 Mar 2013 19:06:14 +0100
Florian Fainelli wrote:
...
> diff --git a/arch/powerpc/platforms/52xx/Kconfig
> b/arch/powerpc/platforms/52xx/Kconfig
> index 90f4496..65232cb 100644
> --- a/arch/powerpc/platforms/52xx/Kconfig
> +++ b/arch/powerpc/platforms/52xx/Kconfig
> @@ -3
Hi Ryan,
Small world, uh?
On Tue, Mar 26, 2013 at 02:55:48PM -0700, Ryan Press wrote:
> I'm working to get the 3.9-rc1 kernel working on the Globalscale
> Mirabox
> http://www.globalscaletechnologies.com/p-58-mirabox-development-kit.aspx.
> The PCIe driver by Thomas Petazzoni is not in mainline
Remove an unneeded call to ehci_shutdown() in ps3_ehci_remove().
This removal will allow for a loadable ehci driver.
Cc: Arnd Bergmann
Signed-off-by: Geoff Levand
---
drivers/usb/host/ehci-ps3.c |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/host/ehci-ps3.c b/drivers/usb/host
Hi Alan,
> Actually, I think this is not necessary. Instead those three glue
> files ought to be changed. They should not need to call
> ehci_shutdown() directly.
I sent out a separate patch that removes the ehci_shutdown()
call in ps3_ehci_remove(). I tested it by removing and
installing the
Hi Greg,
This is an update for chipidea usb controller driver for
usb-next. Some of these patches, though mostly mine, date as far back
as november 2012.
So here we have 27 patches, which
* are coccinelle, smatch and sparse clean, save for the
devm_ioremap_resource,
* improve the core drive
debug.c is carrying a lot of includes that aren't needed there, although
they implicitly include the ones that are actually needed. Replace the
former with the latter.
Signed-off-by: Alexander Shishkin
---
drivers/usb/chipidea/debug.c | 17 +++--
1 file changed, 3 insertions(+), 14
Some headers included in the chipidea controller core are not needed,
remove them.
Signed-off-by: Alexander Shishkin
---
drivers/usb/chipidea/core.c |3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c
index 57cae1f..77963b6 100644
--
Currently, we have a bunch of files in sysfs that display all sorts of
debugging information for the device controller, so they have to move to
debugfs where they belong. The "registers" interface have been removed,
since it doesn't fit into the current driver design as is and it's hardly
a good id
Manual role switching function is there for debugging purposes, so has
to move to debugfs.
Signed-off-by: Alexander Shishkin
---
drivers/usb/chipidea/core.c | 39 --
drivers/usb/chipidea/debug.c | 54 ++
2 files changed, 54
Some headers included in udc core code are not actually needed, remove
them and add irqreturn.h, which was implicitly included via irq.h.
Signed-off-by: Alexander Shishkin
---
drivers/usb/chipidea/udc.c |8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/usb/chi
Create and remove debugfs entries in hdrc probe/remove instead of
start/stop of the device controller. Gadget specific will not export
anything while the controller is in host mode.
Signed-off-by: Alexander Shishkin
---
drivers/usb/chipidea/core.c |6 +-
drivers/usb/chipidea/udc.c |
The driver also has interrupt counters and another ring buffer for keeping
track of the order in which they arrive. This patch converts these counters
to trace points. Userspace tools such as perf can provide information on both
order and stats of the interrupts.
Signed-off-by: Alexander Shishkin
From: Dan Carpenter
The intent here was to have parenthesis around the (ci->hw_ep_max / 2)
so that it counts like "0 1 2 0 1 2". In the current code, the mod
operation happens first so it counts like "0 0 1 1 2 2".
Signed-off-by: Dan Carpenter
[rebased on top of debug.c changes]
Signed-off-by:
As part of the legacy from the original driver design, we retain home-grown
tracing infrastructure, complete with own ring buffer and timestamps. While
it is useful for debugging certain cases, it's a lot of extra code, which
these days is rather redundant.
This patch replaces local tracing functi
From: Felipe Balbi
chipidea's ffs_nr() is pretty much what __ffs() does.
Use that one instead.
Signed-off-by: Felipe Balbi
[rebased on top of debug infrastructure rework]
Signed-off-by: Alexander Shishkin
---
drivers/usb/chipidea/ci.h | 15 +--
drivers/usb/chipidea/core.c |
From: Felipe Balbi
switch over to the newly added devm_ioremap_resource
which provides more consistent error messages.
Signed-off-by: Felipe Balbi
Signed-off-by: Alexander Shishkin
---
drivers/usb/chipidea/core.c |8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/d
From: Michael Grzeschik
This driver will be used for every Freescale SoC which has this misc
memory layout to control the basic usb handling. So better name this
driver, function and struct names in a more generic way.
Reported-by: Fabio Estevam
Signed-off-by: Michael Grzeschik
Signed-off-by:
From: Marc Kleine-Budde
The probe function checks usbmisc to be NULL in the beginning. Without
this patch the can only be loaded once.
Signed-off-by: Marc Kleine-Budde
Signed-off-by: Michael Grzeschik
Signed-off-by: Alexander Shishkin
---
drivers/usb/chipidea/usbmisc_imx.c |1 +
1 file c
From: Marc Kleine-Budde
This fixes a potential race condition where the ci13xxx_imx glue code
could be fast enough to call one of the usbmisc_ops before he got a
valid value on the static usbmisc pointer. To fix that we first set
usbmisc, then call usbmisc_set_ops().
Signed-off-by: Marc Kleine-B
From: Michael Grzeschik
This adds a post handling routine which is called after
ci13xxx_add_device was called. The first user is the mx25, which has to
disable the external-vbus-divider after the udc has started.
Signed-off-by: Michael Grzeschik
Signed-off-by: Marc Kleine-Budde
[Alex: also fix
From: Michael Grzeschik
This adds mx53 as the next user of the usbmisc driver and makes it
possible to disable the overcurrent-detection of the internal phy.
Signed-off-by: Michael Grzeschik
Signed-off-by: Marc Kleine-Budde
[Alex: fixed another set of line-too-long and void pointer cast]
Signe
From: Marc Kleine-Budde
This attaches the usbmisc_ops to the of_device_id data and
makes it possible to define special functions per soc.
Signed-off-by: Marc Kleine-Budde
Signed-off-by: Michael Grzeschik
[Alex: fixed one case of line-too-long and one bogus cast to void ptr]
Signed-off-by: Alex
PCI chipideas' platform datas are not static as all such things should
be. Fix it.
Reported-by: Marc Kleine-Budde
Signed-off-by: Alexander Shishkin
---
drivers/usb/chipidea/ci13xxx_pci.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/chipidea/ci13xxx_pc
From: Svetoslav Neykov
Convert between big-endian and little-endian format when accessing the usb
controller structures which are little-endian by specification.
Fix cases where the little-endian memory layout is taken for granted.
The patch doesn't have any effect on the already supported little
From: Michael Grzeschik
The datasheet of the synopsys core describes only to overwrite the
active and halted bits in the qhead before priming any endpoint.
Signed-off-by: Michael Grzeschik
Reviewed-by: Felipe Balbi
[Alex: fixed a case of line-too-long]
Signed-off-by: Alexander Shishkin
---
d
From: Michael Grzeschik
This patch reworks the cap value from several read
and write operations to one single operation.
Signed-off-by: Michael Grzeschik
Reviewed-by: Felipe Balbi
[Alex: removed useless isoc-related bit of code]
Signed-off-by: Alexander Shishkin
---
drivers/usb/chipidea/udc.
From: Michael Grzeschik
Its not necessary and also not specified in the datasheet to change the
ZLT flag before every ep_prime. This patch moves this to the ep_enable
and applies it only for non configuration endpoints.
Signed-off-by: Michael Grzeschik
Reviewed-by: Felipe Balbi
Signed-off-by:
From: Michael Grzeschik
It is not safe to truncate requests to the maximum possible size the
controller can handle with one td and to keep working. That patch fixes
that with proper error handling instead.
Reported-by: Felipe Balbi
Signed-off-by: Michael Grzeschik
Signed-off-by: Alexander Shis
From: Michael Grzeschik
This patch changes the read of the td status to one atomic operation to
analyse coherent bits.
Signed-off-by: Michael Grzeschik
[Alex: fixed backwards endianness conversion]
Signed-off-by: Alexander Shishkin
---
drivers/usb/chipidea/udc.c |8 +---
1 file change
From: Michael Grzeschik
There is no need to call ep_queue unlocked inside the own driver. We
move its functionionality into an unlocked version.
This patch removes potential unlocked timeslots inside
isr_setup_status_phase and isr_get_status_response, in which the lock
got released just before a
From: Michael Grzeschik
A static count of transfer descriptors was used everywhere in the driver
with the fixed number 5. This patch adds a define, named TD_PAGE_COUNT,
and replaces all users of this value. This way its possible to have only
one parameter to change and limit the amount of buffer
From: Peter Chen
There are several problems with this patch:
+ in introduces a sparse warning for a condition that's always negative,
+ and because of that, it actually doesn't do anything useful,
+ and vbus detection belongs to otg, not device function anyway.
This reverts commit 8c4fc031
We were testing hsotg pointer for null after we had already
dereferenced it
Reported-by: Fengguang Wu
Signed-off-by: Paul Zimmerman
---
drivers/staging/dwc2/hcd_ddma.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/dwc2/hcd_ddma.c b/drivers/stagin
On Fri, 29 Mar 2013, Geoff Levand wrote:
> Hi Alan,
>
> > Actually, I think this is not necessary. Instead those three glue
> > files ought to be changed. They should not need to call
> > ehci_shutdown() directly.
>
> I sent out a separate patch that removes the ehci_shutdown()
> call in ps3_e
I'm having trouble with unexpected characters being sent on a USB port with the
cdc_acm driver. What makes this all the more perplexing is that the code runs
fine on Ubuntu 12.04 (3.2 kernel) but fails (the subject of this question) on
Centos 6 (3.6 kernel)
The USB device is a Bluegiga BLED112
On Sat, Mar 30, 2013 at 02:46:20AM +0200, Alexander Shishkin wrote:
> As part of the legacy from the original driver design, we retain home-grown
> tracing infrastructure, complete with own ring buffer and timestamps. While
> it is useful for debugging certain cases, it's a lot of extra code, which
On Sat, Mar 30, 2013 at 02:46:21AM +0200, Alexander Shishkin wrote:
> The driver also has interrupt counters and another ring buffer for keeping
> track of the order in which they arrive. This patch converts these counters
> to trace points. Userspace tools such as perf can provide information on b
Hi Ezequiel,
Thanks so much for replying, I worried my call for help would just
become more buried.
On Fri, Mar 29, 2013 at 3:34 PM, Ezequiel Garcia
wrote:
> Hi Ryan,
>
> Small world, uh?
>
> On Tue, Mar 26, 2013 at 02:55:48PM -0700, Ryan Press wrote:
>> I'm working to get the 3.9-rc1 kernel wor
On Sat, Mar 30, 2013 at 02:46:25AM +0200, Alexander Shishkin wrote:
> From: Dan Carpenter
>
> The intent here was to have parenthesis around the (ci->hw_ep_max / 2)
> so that it counts like "0 1 2 0 1 2". In the current code, the mod
> operation happens first so it counts like "0 0 1 1 2 2".
>
On Sat, Mar 30, 2013 at 02:46:26AM +0200, Alexander Shishkin wrote:
> From: Felipe Balbi
>
> chipidea's ffs_nr() is pretty much what __ffs() does.
>
> Use that one instead.
>
> Signed-off-by: Felipe Balbi
> [rebased on top of debug infrastructure rework]
Again, can you rebase this so I can ta
On Sat, Mar 30, 2013 at 02:46:28AM +0200, Alexander Shishkin wrote:
> From: Michael Grzeschik
>
> This driver will be used for every Freescale SoC which has this misc
> memory layout to control the basic usb handling. So better name this
> driver, function and struct names in a more generic way.
On Sat, Mar 30, 2013 at 02:46:16AM +0200, Alexander Shishkin wrote:
> Hi Greg,
>
> This is an update for chipidea usb controller driver for
> usb-next. Some of these patches, though mostly mine, date as far back
> as november 2012.
Why would you hold onto patches for that long? That's not ok for
80 matches
Mail list logo
