On Fri, 29 Mar 2013, Lan Tianyu wrote:

> Actually, I exposed pm qos flags for usb port via dev_pm_qos_expose_flags().
> It creates power/pm_qos_no_power_off under usb port sysfs directory.
> User can echo 0 > pm_qos_no_power_off to power off the empty port.

Before it's too late, we should consider changing the flag's name.  
Writing 0 to a file named pm_qos_no_power_off is a double negative, 
which is always awkward to think about.

Instead, how about calling the file pm_qos_allow_power_off?  Will the
PM-QOS system allow something like that, i.e., something that is the
opposite of a constraint?

If not, how about naming it pm_qos_keep_power_on?

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to