"req->length" is a capped version of "data->length".
Signed-off-by: Dan Carpenter
---
Static analysis. I have not tested this.
diff --git a/drivers/usb/gadget/uvc_v4l2.c b/drivers/usb/gadget/uvc_v4l2.c
index 2ca9386..8770cf0 100644
--- a/drivers/usb/gadget/uvc_v4l2.c
+++ b/drivers/usb/gadget/uv
Hi Alex and all,
Currently, we have two problems to block chipidea driver coming
development.
As there are so many chipidea versions, we impossible to collect
all to make a decision, it is better to cover most of the cases,
and using device tree (or platform data) to cover exceptions
if they exis
On 03/14/2013 09:34 AM, Peter Chen wrote:
> Hi Alex and all,
>
> Currently, we have two problems to block chipidea driver coming
> development.
>
> As there are so many chipidea versions, we impossible to collect
> all to make a decision, it is better to cover most of the cases,
> and using devic
Hi folks,
after these patches there are only 3 drivers (plus
usbcore) making references to DMA_ADDR_INVALID.
Those UDC drivers need to be converted to usb_gadget_map/unmap_request
before we can remove DMA_ADDR_INVALID.
Please review these patches carefully. I have compile-tested
what I could wit
DMA_ADDR_INVALID isn't (and shouldn't) be used
anymore, let's remove it.
Signed-off-by: Felipe Balbi
---
drivers/usb/gadget/atmel_usba_udc.h | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/usb/gadget/atmel_usba_udc.h
b/drivers/usb/gadget/atmel_usba_udc.h
index 9791259..d65a618
DMA_ADDR_INVALID isn't used anymore, it's safe
to remove it.
Signed-off-by: Felipe Balbi
---
drivers/usb/gadget/net2280.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/usb/gadget/net2280.c b/drivers/usb/gadget/net2280.c
index e5f2ef1..691cc65 100644
--- a/drivers/usb/gadget/net2
gadget drivers shouldn't touch req->dma at all,
since UDC drivers are the ones required to handle
mapping and unmapping of the request buffer.
Remove references to DMA_ADDR_INVALID so we don't
creat false expectations to gadget driver writers.
Signed-off-by: Felipe Balbi
---
drivers/usb/gadget/
DMA_ADDR_INVALID isn't used anymore, it's safe
to remove it.
Signed-off-by: Felipe Balbi
---
drivers/usb/renesas_usbhs/fifo.c | 1 -
drivers/usb/renesas_usbhs/fifo.h | 2 --
2 files changed, 3 deletions(-)
diff --git a/drivers/usb/renesas_usbhs/fifo.c b/drivers/usb/renesas_usbhs/fifo.c
index 95
DMA_ADDR_INVALID isn't used anymore, it's safe
to remove it.
Signed-off-by: Felipe Balbi
---
drivers/usb/gadget/net2272.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/usb/gadget/net2272.c b/drivers/usb/gadget/net2272.c
index 8dcbe77..03e4104 100644
--- a/drivers/usb/gadget/net227
instead of defining our own DMA_ADDR_INVALID
mess, we can use dma_mapping_error() as a check
for kicking or not DMA. This allows us to remove
all references to DMA_ADDR_INVALID from MUSB
driver.
Signed-off-by: Felipe Balbi
---
drivers/usb/musb/musb_dma.h| 2 --
drivers/usb/musb/musb_gadget.c
Hi,
On Thu, Mar 14, 2013 at 01:50:42PM +0800, Peter Chen wrote:
> - If there is no vbus control to indicate connection.
> and disconnect, we can pullup dp when we load gadget module.
> - If we have vbus control logic, the dp is better pull up
> when there is a vbus session.
>
> Signed-off-by: Pet
On 03/14/2013 09:56 AM, Felipe Balbi :
> DMA_ADDR_INVALID isn't (and shouldn't) be used
> anymore, let's remove it.
>
> Signed-off-by: Felipe Balbi
> ---
> drivers/usb/gadget/atmel_usba_udc.h | 6 --
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/usb/gadget/atmel_usba_udc.h
> b/
On Thursday 14 March 2013 12:13:59 Ming Lei wrote:
> On Wed, Mar 13, 2013 at 11:15 PM, Oliver Neukum wrote:
> > On Wednesday 13 March 2013 23:02:32 Ming Lei wrote:
> >> On Wed, Mar 13, 2013 at 10:55 PM, Oliver Neukum wrote:
> >> >
> >> > But it will be run when the next read() call is made. The q
From: Mikhail Kshevetskiy
Commit 032ec49f5351e9cb242b1a1c367d14415043ab95 (usb: musb: drop useless
board_mode usage) introduced a typo that breaks the build.
There were no replies on my first mail, so I would like to draw your attention
to this patch again as it fixes a build breakage (the brea
On Thu, Mar 14, 2013 at 09:53:55AM +0100, Marc Kleine-Budde wrote:
> On 03/14/2013 09:34 AM, Peter Chen wrote:
> > Hi Alex and all,
> >
> > Currently, we have two problems to block chipidea driver coming
> > development.
> >
> > As there are so many chipidea versions, we impossible to collect
> >
On Thu, Mar 14, 2013 at 11:00:05AM +0200, Felipe Balbi wrote:
> Hi,
>
> On Thu, Mar 14, 2013 at 01:50:42PM +0800, Peter Chen wrote:
> > - If there is no vbus control to indicate connection.
> > and disconnect, we can pullup dp when we load gadget module.
> > - If we have vbus control logic, the dp
Hi,
On Thu, Mar 14, 2013 at 10:01:30AM +0100, Nicolas Ferre wrote:
> On 03/14/2013 09:56 AM, Felipe Balbi :
> > DMA_ADDR_INVALID isn't (and shouldn't) be used
> > anymore, let's remove it.
> >
> > Signed-off-by: Felipe Balbi
> > ---
> > drivers/usb/gadget/atmel_usba_udc.h | 6 --
> > 1 file
On Fri, Mar 08, 2013 at 05:56:11PM +0200, Felipe Balbi wrote:
> Hi,
>
> On Fri, Mar 08, 2013 at 08:37:00PM +0800, Peter Chen wrote:
> > On Fri, Mar 08, 2013 at 01:30:52PM +0200, Felipe Balbi wrote:
> > > this method will be used to enable or disable
> > > the charge pump.
> > >
> > > Whenever we
On Thu, Mar 14, 2013 at 5:04 PM, Oliver Neukum wrote:
>>
>> OK, got it, so how about INIT_COMPLETION(&dev->bulk_in_completion)
>> in case of !ongoing_read? That means replacing 'if (!dev->processed_urb)'
>> with INIT_COMPLETION(&dev->bulk_in_completion).
>
> It is possible, if you also change lock
Hi,
On Thu, Mar 14, 2013 at 05:38:03PM +0800, Peter Chen wrote:
> > > > @@ -160,6 +163,24 @@ usb_phy_shutdown(struct usb_phy *x)
> > > > x->shutdown(x);
> > > > }
> > > >
> > > > +static inline int
> > > > +usb_phy_vbus_on(struct usb_phy *x)
> > > > +{
> > > > + if (!x->se
On Thursday 14 March 2013 18:07:29 Ming Lei wrote:
> > But then it makes no sense and you'd be better of with a waitqueue
> > instead of a completion.
>
> Maybe we can do it in another patch.
Part of the locking changes would need to be reverted.
It is less work to convert now.
Regards
Hi,
On Thu, Mar 14, 2013 at 05:24:39PM +0800, Peter Chen wrote:
> > > @@ -278,7 +278,10 @@ static int udc_bind_to_driver(struct usb_udc *udc,
> > > struct usb_gadget_driver *dri
> > > driver->unbind(gadget);
> > > goto err1;
> > > }
> > > - usb_gadget_connect(gadget);
> > >
Peter Chen writes:
> Hi Alex and all,
>
> Currently, we have two problems to block chipidea driver coming
> development.
>
> As there are so many chipidea versions, we impossible to collect
> all to make a decision, it is better to cover most of the cases,
> and using device tree (or platform dat
Moving register and structure definitions to header file,
and keeping the generic functions to be used across
multiple PHYs in common phy helper driver under SAMSUNG_USBPHY,
and moving USB 2.0 PHY driver under SAMSUNG_USB2PHY.
Also allowing samsung PHY drivers be built as modules.
Signed-off-by:
Adding PHY driver support for USB 3.0 controller for Samsung's
SoCs.
Signed-off-by: Vivek Gautam
Signed-off-by: Felipe Balbi
Acked-by: Kukjin Kim
---
.../devicetree/bindings/usb/samsung-usbphy.txt | 54 +++
drivers/usb/phy/Kconfig|7 +
drivers/usb/phy/Make
Changes from v6:
- Changing the file names accordingly as per
[PATCH] usb: phy: rename all phy drivers to phy-$name.c
- Using devm_clk_get for PHY ref clocks "ext_xtal" and "xusbxti"
- Adding the bindings documentation for separate USB 2.0 phy and
USB 3.0 phy.
Based on 'usb-next' plus Fel
On 03/14/2013 11:31 AM, Alexander Shishkin wrote:
> Peter Chen writes:
>
>> Hi Alex and all,
>>
>> Currently, we have two problems to block chipidea driver coming
>> development.
>>
>> As there are so many chipidea versions, we impossible to collect
>> all to make a decision, it is better to cove
On Thu, Mar 14, 2013 at 6:19 PM, Oliver Neukum wrote:
> On Thursday 14 March 2013 18:07:29 Ming Lei wrote:
>> > But then it makes no sense and you'd be better of with a waitqueue
>> > instead of a completion.
>>
>> Maybe we can do it in another patch.
>
> Part of the locking changes would need to
This patch fixes the wrong OTG_EVT,OTG_EVTEN and OTG_STS register
offsets.
Signed-off-by: George Cherian
---
drivers/usb/dwc3/core.h| 5 +++--
drivers/usb/dwc3/debugfs.c | 1 +
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
in
On 03/14/2013 09:56 AM, Felipe Balbi :
> DMA_ADDR_INVALID isn't (and shouldn't) be used
> anymore, let's remove it.
>
> Signed-off-by: Felipe Balbi
Acked-by: Nicolas Ferre
Thanks Felipe. Bye.
> ---
> drivers/usb/gadget/atmel_usba_udc.h | 6 --
> 1 file changed, 6 deletions(-)
>
> diff -
Hello guys,
This is v2 of my patch https://patchwork.kernel.org/patch/1232871/
rebased on v3.9-rc2. Removes deprecated flags and structures
and saves few bytes of memory.
Regards,
Ruslan
Ruslan Bilovol (1):
omap: usb: host: remove deprecated flags and structures
include/linux/platform_data/u
These flags and structures are deprecated and there is
no anymore users of them, so it's safe to remove them.
Signed-off-by: Ruslan Bilovol
---
include/linux/platform_data/usb-omap.h | 20
1 file changed, 20 deletions(-)
diff --git a/include/linux/platform_data/usb-omap.h
Used of_platform_populate() to create dwc3 core platform_device
from device tree data. Additionally some cleanup is also done.
Signed-off-by: Vivek Gautam
CC: Felipe Balbi
CC: Kukjin Kim
---
drivers/usb/dwc3/dwc3-exynos.c | 46 +---
1 files changed, 15 ins
Convert clk_enable/clk_disable to clk_prepare_enable/clk_disable_unprepare
calls as required by common clock framework.
Signed-off-by: Vivek Gautam
CC: Felipe Balbi
CC: Kukjin Kim
---
drivers/usb/dwc3/dwc3-exynos.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/d
This patch-set modifies dwc3-exynos as per latest bindings
available for dwc3. Now the dwc3 core also has device support,
there's no need to add platform device for core in glue layers.
This change has come as a result of discussion happened in:
[PATCH RFC] usb: dwc3: Get PHY from platform specific
Hi,
On Thu, Mar 14, 2013 at 04:14:57PM +0530, Vivek Gautam wrote:
> @@ -170,7 +155,6 @@ static int dwc3_exynos_remove(struct platform_device
> *pdev)
> {
> struct dwc3_exynos *exynos = platform_get_drvdata(pdev);
>
> - platform_device_unregister(exynos->dwc3);
don't you want to
Hi,
On Thu, Mar 14, 2013 at 04:14:58PM +0530, Vivek Gautam wrote:
> Convert clk_enable/clk_disable to clk_prepare_enable/clk_disable_unprepare
> calls as required by common clock framework.
>
> Signed-off-by: Vivek Gautam
> CC: Felipe Balbi
> CC: Kukjin Kim
> ---
> drivers/usb/dwc3/dwc3-exyno
On Fri, Mar 08, 2013 at 11:37:17AM -0700, Stephen Warren wrote:
> On 03/08/2013 11:26 AM, Felipe Balbi wrote:
> > On Fri, Mar 08, 2013 at 10:14:11AM -0700, Stephen Warren wrote:
> >> On 03/08/2013 12:14 AM, Felipe Balbi wrote:
> >>> Hi,
> >>>
> >>> On Thu, Mar 07, 2013 at 02:20:36PM -0700, Stephen
commit bd329e1 ("net: cdc_ncm: do not bind to NCM compatible MBIM devices")
introduced a new policy, preferring MBIM for dual NCM/MBIM functions if
the cdc_mbim driver was enabled. This caused a regression for users
wanting to use NCM.
Devices implementing NCM backwards compatibility according to
On Fri, Mar 08, 2013 at 12:15:19AM +0800, Ming Lei wrote:
> This patch kills traffic even though type->suspend returns
> failure inside usb_serial_suspend from system sleep context
> because USB core ignores the failiure and lets system sleep
> go ahread, so the serial URB traffic need to be killed
On 14.03.2013, at 05:19, Thomas Abraham wrote:
> On 14 March 2013 05:29, Alexander Graf wrote:
>> On my Exynos 5 based Arndale system, I need to pull the reset line down
>> and then let it go up again to actually perform a reset. Without that
>> reset, I can't find any USB hubs on my bus, render
On 14.03.2013, at 04:38, Doug Anderson wrote:
> Alexander,
>
> On Wed, Mar 13, 2013 at 4:59 PM, Alexander Graf wrote:
>> On my Exynos 5 based Arndale system, I need to pull the reset line down
>> and then let it go up again to actually perform a reset. Without that
>> reset, I can't find any US
On Thu, Mar 14, 2013 at 4:21 PM, Felipe Balbi wrote:
> Hi,
>
> On Thu, Mar 14, 2013 at 04:14:57PM +0530, Vivek Gautam wrote:
>> @@ -170,7 +155,6 @@ static int dwc3_exynos_remove(struct platform_device
>> *pdev)
>> {
>> struct dwc3_exynos *exynos = platform_get_drvdata(pdev);
>>
>> -
Used of_platform_populate() to create dwc3 core platform_device
from device tree data. Additionally some cleanup is also done.
Signed-off-by: Vivek Gautam
CC: Felipe Balbi
CC: Kukjin Kim
---
Changes from v1:
- Added method to unregister dwc3 core from dwc3_exynos_remove()
using device_for_
Hi Felipe,
Thank you for the patch.
On Thursday 14 March 2013 10:56:09 Felipe Balbi wrote:
> gadget drivers shouldn't touch req->dma at all,
> since UDC drivers are the ones required to handle
> mapping and unmapping of the request buffer.
>
> Remove references to DMA_ADDR_INVALID so we don't
>
On Thu, Mar 14, 2013 at 12:41:13PM +0200, Ruslan Bilovol wrote:
> These flags and structures are deprecated and there is
> no anymore users of them, so it's safe to remove them.
>
> Signed-off-by: Ruslan Bilovol
Acked-by: Felipe Balbi
--
balbi
signature.asc
Description: Digital signature
On Thu, Mar 14, 2013 at 11:53:55AM +0530, Kishon Vijay Abraham I wrote:
> This series has some misc cleanup and fixes. The fix solves the cold
> plug issue in omap3 which some have reported. Developed these patches on
> fixes-for-v3.9-rc3 after applying
> http://www.spinics.net/lists/linux-usb/msg
Hi Alan,
On Wed, Mar 13, 2013 at 05:53:04PM +0800, Chen Gang wrote:
> Hello Felipe Balbi:
>
> I have communicate with related member of net2272 and net2280.
> net2272 and net2280 belong to PLX Tech Corporation.
> they say: "PLX is not longer maintain these drivers".
> (it means: t
On Thu, Mar 07, 2013 at 06:51:45PM +0530, Kishon Vijay Abraham I wrote:
> From: Graeme Gregory
>
> This is the driver for the OTG transceiver built into the Palmas chip. It
> handles the various USB OTG events that can be generated by cable
> insertion/removal.
>
> Signed-off-by: Graeme Gregory
On Thu, Mar 07, 2013 at 06:51:46PM +0530, Kishon Vijay Abraham I wrote:
> No functional change. Replace *_* with *-* in property names of otg to
> follow the general convention.
>
> Signed-off-by: Kishon Vijay Abraham I
this has been pending for quite a while, since nobody complained, I'm
taking
our global '_omap' pointer wasn't marked
static. This patch solves the following sparse
warning:
warning: symbol '_omap' was not declared. \
Should it be static?
Signed-off-by: Felipe Balbi
---
drivers/usb/dwc3/dwc3-omap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
d
On Tue, Mar 12, 2013 at 12:25:37PM +0200, Roger Quadros wrote:
> The helper functions omap_usbhs_rev1_hostconfig()
> and omap_usbhs_rev2_hostconfig() don't write into
> the hostconfig register. Make sure that we write
> the return value into the hostconfig register.
>
> Signed-off-by: Roger Quadro
On Tue, Mar 12, 2013 at 11:57:56AM -0400, Alan Stern wrote:
> On Tue, 12 Mar 2013, Roger Quadros wrote:
>
> > Even when not in PHY mode, the USB device on the port (e.g. HUB)
> > might need resources like RESET which can be modelled as a PHY
> > device. So try to get the PHY device in any case.
>
Hi Dan,
Thanks for the patch.
On Thursday 14 March 2013 11:01:05 Dan Carpenter wrote:
> "req->length" is a capped version of "data->length".
>
> Signed-off-by: Dan Carpenter
Good catch.
Acked-by: Laurent Pinchart
Felipe, could you please pick this one up (I can of course send you a pull
re
On Mon, Mar 11, 2013 at 09:14:41PM +0100, Paul Bolle wrote:
> The Kconfig option MACH_OMAP_H4_OTG was already considered dead as of
> v2.6.36, as can be seen in commit
> 267ecec95f7d215d2da38252640b06198515acc3 ("Removing dead
> MACH_OMAP_H4_OTG"). Remove its last trace now.
>
> Signed-off-by: Pau
On Thu, Mar 14, 2013 at 03:09:46PM +0100, Laurent Pinchart wrote:
> Hi Dan,
>
> Thanks for the patch.
>
> On Thursday 14 March 2013 11:01:05 Dan Carpenter wrote:
> > "req->length" is a capped version of "data->length".
> >
> > Signed-off-by: Dan Carpenter
>
> Good catch.
>
> Acked-by: Laurent
Hello.
On 14-03-2013 4:51, Kuninori Morimoto wrote:
Thank you for pointing it
0x ===
EHCI
--
0x0094 PHY
0x009C PHY
--
EHCI
0x0400 ==
...
0x0800 --
On Thursday 14 March 2013 07:03 PM, Felipe Balbi wrote:
On Thu, Mar 14, 2013 at 11:53:55AM +0530, Kishon Vijay Abraham I wrote:
This series has some misc cleanup and fixes. The fix solves the cold
plug issue in omap3 which some have reported. Developed these patches on
fixes-for-v3.9-rc3 after a
On Thu, Mar 14, 2013 at 08:15:00PM +0530, kishon wrote:
> On Thursday 14 March 2013 07:03 PM, Felipe Balbi wrote:
> >On Thu, Mar 14, 2013 at 11:53:55AM +0530, Kishon Vijay Abraham I wrote:
> >>This series has some misc cleanup and fixes. The fix solves the cold
> >>plug issue in omap3 which some ha
On Thursday 14 March 2013 08:17 PM, Felipe Balbi wrote:
On Thu, Mar 14, 2013 at 08:15:00PM +0530, kishon wrote:
On Thursday 14 March 2013 07:03 PM, Felipe Balbi wrote:
On Thu, Mar 14, 2013 at 11:53:55AM +0530, Kishon Vijay Abraham I wrote:
This series has some misc cleanup and fixes. The fix s
On Thu, 2013-03-14 at 16:13 +0200, Felipe Balbi wrote:
> On Mon, Mar 11, 2013 at 09:14:41PM +0100, Paul Bolle wrote:
> > diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig
> > index 5a0c541..c65b5e2 100644
> > --- a/drivers/usb/gadget/Kconfig
> > +++ b/drivers/usb/gadget/Kconfig
>
On Wed, 13 Mar 2013, Jiri Kosina wrote:
> OK, this is a "me too", on Thinkpad x200s.
>
> [4.116847] irq 16: nobody cared (try booting with the "irqpoll" option)
> [4.116849] Pid: 1, comm: systemd Not tainted 3.9.0-rc2-00188-g6c23cbb #186
> [4.116850] Call Trace:
> [4.116860][]
On Thursday 14 March 2013 07:26 PM, Felipe Balbi wrote:
On Thu, Mar 07, 2013 at 06:51:45PM +0530, Kishon Vijay Abraham I wrote:
From: Graeme Gregory
This is the driver for the OTG transceiver built into the Palmas chip. It
handles the various USB OTG events that can be generated by cable
inser
On Thu, 14 Mar 2013, Alan Stern wrote:
> > [4.116847] irq 16: nobody cared (try booting with the "irqpoll" option)
> > [4.116849] Pid: 1, comm: systemd Not tainted 3.9.0-rc2-00188-g6c23cbb
> > #186
> > [4.116850] Call Trace:
> > [4.116860][] __report_bad_irq+0x38/0xf0
> > [
On 14 March 2013 17:31, Alexander Graf wrote:
>
> On 14.03.2013, at 05:19, Thomas Abraham wrote:
>
>> On 14 March 2013 05:29, Alexander Graf wrote:
>>> On my Exynos 5 based Arndale system, I need to pull the reset line down
>>> and then let it go up again to actually perform a reset. Without that
On Thu, 14 Mar 2013, Peter Chen wrote:
> /home/b29397/work/code/git/linus/linux-2.6/drivers/usb/host/xhci-ring.c: In
> function ‘handle_port_status’:
> /home/b29397/work/code/git/linus/linux-2.6/drivers/usb/host/xhci-ring.c:1580:
> warning: ‘hcd’ may be used uninitialized in this function
>
> S
On Thu, 14 Mar 2013, Felipe Balbi wrote:
> Hi Alan,
>
> On Wed, Mar 13, 2013 at 05:53:04PM +0800, Chen Gang wrote:
> > Hello Felipe Balbi:
> >
> > I have communicate with related member of net2272 and net2280.
> > net2272 and net2280 belong to PLX Tech Corporation.
> > they say: "PLX i
On Thu, 14 Mar 2013, Felipe Balbi wrote:
> > > if (IS_ERR(phy) || !phy) {
> > > + /* Don't bail out if PHY is not absolutely necessary */
> > > + if (pdata->port_mode[i] != OMAP_EHCI_PORT_MODE_PHY)
> > > + continue;
> > > +
> > >
On 13-02-27 02:57 PM, Paul Gortmaker wrote:
> On 13-02-27 02:51 PM, Felipe Balbi wrote:
>> HI,
>>
>> On Wed, Feb 27, 2013 at 02:08:39PM -0500, Paul Gortmaker wrote:
>>> commit 57f6ce072e35770a63be0c5d5e82f90d8da7d665 ("usb: phy:
>>> add a new driver for usb3 phy") added the new Kconfig option
>>> O
On Thu, 14 Mar 2013, Jiri Kosina wrote:
> On Thu, 14 Mar 2013, Alan Stern wrote:
>
> > > [4.116847] irq 16: nobody cared (try booting with the "irqpoll"
> > > option)
> > > [4.116849] Pid: 1, comm: systemd Not tainted 3.9.0-rc2-00188-g6c23cbb
> > > #186
> > > [4.116850] Call Trace:
This is a resend of the remaining part of the USB-disconnect series
[ Greg, you said you could handle it. ;) ] rebased on Linus tree of
today (c41b3810c09) and the two since then broken-out series:
USB: fixes for 3.9-rc
USB: serial: fix TIOCMIWAIT and disconnect
Apart from a typo-
Remove redundant comments and fix some minor coding style issues.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/usb-serial.c | 20 +---
1 file changed, 5 insertions(+), 15 deletions(-)
diff --git a/drivers/usb/serial/usb-serial.c b/drivers/usb/serial/usb-serial.c
index a5e8
Remove redundant port number from debug output (already printed as part
of device name).
Signed-off-by: Johan Hovold
---
drivers/usb/serial/usb-serial.c | 39 ---
1 file changed, 20 insertions(+), 19 deletions(-)
diff --git a/drivers/usb/serial/usb-serial.c b
Rename the tty-port callbacks using a common prefix to more clearly
separate them from the tty and usb driver callbacks.
Rename serial_down to serial_port_shutdown to match the callback name.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/usb-serial.c | 18 +-
1 file changed
Switch to the generic TIOCMIWAIT implementation.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/ssu100.c | 47 ++---
1 file changed, 2 insertions(+), 45 deletions(-)
diff --git a/drivers/usb/serial/ssu100.c b/drivers/usb/serial/ssu100.c
index 0965b02.
Remove kill of interrupt-in urb on close as it has never been submitted.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/kl5kusb105.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/usb/serial/kl5kusb105.c b/drivers/usb/serial/kl5kusb105.c
index 769d910..57fd001 100644
--- a/dri
Remove bogus (and unnecessary) test for serial->dev being NULL in close.
The device is never cleared, and close is never called after a completed
disconnect anyway.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/iuu_phoenix.c | 13 +
1 file changed, 5 insertions(+), 8 deletions(
Remove redundant port number from debug output (already printed as part
of device name).
Signed-off-by: Johan Hovold
---
drivers/usb/serial/generic.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/usb/serial/generic.c b/drivers/usb/serial/generic.c
index 4
Remove bogus (and unnecessary) test for serial->dev being NULL in close.
The device is never cleared, and close is never called after a completed
disconnect anyway.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/sierra.c | 39 +--
1 file changed, 17 inser
Switch to the generic get_icount implementation.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/ftdi_sio.c | 24 +---
1 file changed, 1 insertion(+), 23 deletions(-)
diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c
index 478f2b4..4f9bfe5 100644
Remove bogus (and unnecessary) test for serial->dev being NULL in
dtr_rts.
The device is never cleared, and disconnect is handled for dtr_rts in
usb-serial core anyway.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/keyspan_pda.c | 10 --
1 file changed, 4 insertions(+), 6 deletions
Use interface rather than usb-serial device for debugging interface
related operations. This gives more descriptive messages, such as
[ 905.669436] pl2303 1-4.1:1.0: 0x40:0x1:0x8:0x0 0
rather than
[ 341.943535] usb 1-4.1: 0x40:0x1:0x8:0x0 0
Signed-off-by: Johan Hovold
---
drivers/usb/seri
Remove the port data refcounting and release the private data
explicitly at port remove.
The port data refcounting was used to make sure the port data was not
freed until the last tty reference was closed. Since moving over to tty
ports, the underlying assumptions are no longer valid as close is n
Remove kill of interrupt-in urb on close as it has never been submitted.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/iuu_phoenix.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/serial/iuu_phoenix.c b/drivers/usb/serial/iuu_phoenix.c
index ff77027..a3bfcb3 100644
--- a/dri
Make sure we return 0 or a negative error number appropriate for
userspace on errors.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/pl2303.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c
index 4b709585..8
Most USB serial drivers are, and should be, using as much of the generic
implementation as possible.
Rename the fixup_generic function to a more descriptive name.
Reword the related debug message in a more neutral tone (and remember to
add the missing newline).
Finally, move the operations initial
Always try to disable the uart on close.
Since the switch to tty ports, close will be called as part of shutdown
before disconnect returns. Hence there is no need to check the
disconnected flag, and we can put devices in disabled states also on
driver unbind.
Signed-off-by: Johan Hovold
---
dri
Hi,
On Thu, Mar 14, 2013 at 7:58 AM, Thomas Abraham
wrote:
>> I can see your point, but as I mentioned earlier there seems to be some
>> timing issue here. By simply doing the reset a few ms earlier (in the first
>> probe, before the driver detects that it needs to defer probing), I already
>>
On 14.03.2013, at 15:58, Thomas Abraham wrote:
> On 14 March 2013 17:31, Alexander Graf wrote:
>>
>> On 14.03.2013, at 05:19, Thomas Abraham wrote:
>>
>>> On 14 March 2013 05:29, Alexander Graf wrote:
On my Exynos 5 based Arndale system, I need to pull the reset line down
and then l
On Thu, 14 Mar 2013, Alan Stern wrote:
> > > Can you try to do a git bisect for this? Is the sluggish system
> > > response clear enough that you can tell reliably when it is present and
> > > when it isn't?
> >
> > That was my first thought, but unfortunately I am afraid there will be
> > po
The generic close operation will be used if the close field is left
uninitialised.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/ssu100.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/usb/serial/ssu100.c b/drivers/usb/serial/ssu100.c
index 8bb8579..adbca36 100644
--- a/dr
Remove broken TIOCMIWAIT support.
This drivers appears to implement TIOCMIWAIT but has no means of
receiving modem-status interrupts.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/spcp8x5.c | 71
1 file changed, 71 deletions(-)
diff --git a/dri
Remove SMP memory barriers from icount handling and rely on the barriers
implied by wait_event, sleep and locks, while using the port lock to
guarantee atomicity.
This is a step in moving over to the generic icount implementations.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/mos7840.c |
Switch to the generic get_icount implementation.
Note that the interrupt counters will no longer be reset at open which
is in accordance with which how the other drivers work.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/io_edgeport.c | 45 +++-
drivers
Remove bogus (and unnecessary) test for serial->dev being NULL in close.
The device is never cleared, and close is never called after a completed
disconnect anyway.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/keyspan_pda.c | 9 ++---
1 file changed, 2 insertions(+), 7 deletions(-)
d
Clean up modem status retrieval.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/spcp8x5.c | 18 +++---
1 file changed, 7 insertions(+), 11 deletions(-)
diff --git a/drivers/usb/serial/spcp8x5.c b/drivers/usb/serial/spcp8x5.c
index 5779dd8..e0093dd 100644
--- a/drivers/usb/serial
Break out TIOCMIWAIT handling from custom ioctl operation and use
tiocmiwait operation field instead.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/pl2303.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c
Add tiocmiwait operation to struct usb_serial_driver.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/usb-serial.c | 15 +++
include/linux/usb/serial.h | 1 +
2 files changed, 12 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/serial/usb-serial.c b/drivers/usb/serial
Remove disconnected test from close which did not protect any device IO
at all.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/cypress_m8.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/usb/serial/cypress_m8.c b/drivers/usb/serial/cypress_m8.c
index 5b6d286..827aad0 10064
Switch to the generic TIOCMIWAIT implementation.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/quatech2.c | 48 ++-
1 file changed, 2 insertions(+), 46 deletions(-)
diff --git a/drivers/usb/serial/quatech2.c b/drivers/usb/serial/quatech2.c
index 34d4
1 - 100 of 229 matches
Mail list logo
