Hi,
sorry for the delay
On Mon, Jan 28, 2013 at 07:06:56PM +0530, Vivek Gautam wrote:
> Hi Felipe,
>
>
> On Mon, Jan 28, 2013 at 5:15 PM, Felipe Balbi wrote:
> > On Mon, Jan 28, 2013 at 05:12:26PM +0530, Vivek Gautam wrote:
> >> The current code in the dwc3 probe effectively disables runtime p
On Wed, Feb 27, 2013 at 09:55:10AM +0200, Felipe Balbi wrote:
> Hi,
>
> On Wed, Feb 27, 2013 at 02:33:17PM +0800, Peter Chen wrote:
> > - For host, the vbus should always be on.
> > - For otg, the vbus is off defaultly, the vbus needs to be
> > turned on/off when usb role switches.
> >
> > Signed
Hi,
On Mon, Feb 11, 2013 at 09:51:07PM +0300, Sergei Shtylyov wrote:
> Hello.
>
> On 12/06/2012 08:42 AM, Supriya Karanth wrote:
>
> > From: supriya karanth
>
> > The TXMAXP register is not set correctly for full speed bulk case
> > when the can_bulk_split() is used. Without this PIO transfers
On Tuesday, February 26, 2013 7:27 PM Sebastian Andrzej Siewior wrote:
> >> e.g. f_mass_storage_usb.ko, f_ss_lb_usb.ko, f_rndis_usb.ko etc.
> >
> > IMHO each function should be a separate module, so this f_ss_lb_usb.ko
> > is wrong. We should have f_sourcesink.ko and f_loopback.ko.
>
> This is tr
On Thu, Feb 14, 2013 at 07:43:54PM +0100, Sascha Hauer wrote:
> On Thu, Feb 14, 2013 at 08:00:11PM +0200, Felipe Balbi wrote:
> > Hi,
> >
> > On Thu, Feb 14, 2013 at 05:23:37PM +0100, Sascha Hauer wrote:
> > > On Thu, Feb 14, 2013 at 12:37:29PM +0200, Felipe Balbi wrote:
> > > > Hi,
> > > >
> > >
On Wed, Feb 27, 2013 at 09:07:35AM +0100, Sascha Hauer wrote:
> On Wed, Feb 27, 2013 at 09:55:10AM +0200, Felipe Balbi wrote:
> > Hi,
> >
> > On Wed, Feb 27, 2013 at 02:33:17PM +0800, Peter Chen wrote:
> > > - For host, the vbus should always be on.
> > > - For otg, the vbus is off defaultly, the
Hi,
On Fri, Jan 18, 2013 at 02:30:21PM +0530, Praveen Paneri wrote:
> Changes from v8:
> Resending this patch series after rebasing to the latest usb-next branch.
> Rewording inline comments for better readability.
> Removed IS_ENABLED(CONFIG_OF) as pdev->dev.of_node is enough to check for dt
> s
On Wed, Feb 27, 2013 at 03:54:18PM +0800, Yingchun Li wrote:
> Hi, Felipe
> Does the following patch still break your editor? I have fix the patch
> and resend it again, but I didn't find the patch in your 'big patch
> bomb' for v3.10,
> should I fix something?
patching file drivers/usb/musb/
On Sat, Feb 02, 2013 at 03:48:54PM +0800, Chen Gang wrote:
>
> for NUL terminated string, better notice '\0' in the end.
>
> Signed-off-by: Chen Gang
Laurent, are you taking this patch or should I ?
--
balbi
signature.asc
Description: Digital signature
Hi Balbi,
On Wed, Feb 27, 2013 at 1:45 PM, Felipe Balbi wrote:
> Hi,
>
> On Fri, Jan 18, 2013 at 02:30:21PM +0530, Praveen Paneri wrote:
>> Changes from v8:
>> Resending this patch series after rebasing to the latest usb-next branch.
>> Rewording inline comments for better readability.
>> Remove
On Wed, Feb 27, 2013 at 02:00:25PM +0530, Vivek Gautam wrote:
> Hi Balbi,
>
>
> On Wed, Feb 27, 2013 at 1:45 PM, Felipe Balbi wrote:
> > Hi,
> >
> > On Fri, Jan 18, 2013 at 02:30:21PM +0530, Praveen Paneri wrote:
> >> Changes from v8:
> >> Resending this patch series after rebasing to the latest
Hi Darius,
On Wed, Feb 27, 2013 at 04:13:14PM +0800, Peter Chen wrote:
> On Wed, Feb 27, 2013 at 09:07:35AM +0100, Sascha Hauer wrote:
> > On Wed, Feb 27, 2013 at 09:55:10AM +0200, Felipe Balbi wrote:
> > > Hi,
> > >
> > > On Wed, Feb 27, 2013 at 02:33:17PM +0800, Peter Chen wrote:
> > > > - For
On Wednesday 27 of February 2013 14:00:25 Vivek Gautam wrote:
> Hi Balbi,
>
> On Wed, Feb 27, 2013 at 1:45 PM, Felipe Balbi wrote:
> > Hi,
> >
> > On Fri, Jan 18, 2013 at 02:30:21PM +0530, Praveen Paneri wrote:
> >> Changes from v8:
> >> Resending this patch series after rebasing to the latest u
On Wed, Feb 27, 2013 at 11:10:03AM +0800, Peter Chen wrote:
> On Tue, Feb 26, 2013 at 08:21:41PM +0200, Felipe Balbi wrote:
> > Hi,
> >
> > On Sun, Feb 17, 2013 at 11:09:53AM +0800, Peter Chen wrote:
> > > @@ -1373,6 +1375,8 @@ static int ci13xxx_vbus_session(struct usb_gadget
> > > *_gadget, int
Hi Felipe,
On Wed, Feb 27, 2013 at 1:36 PM, Felipe Balbi wrote:
> Hi,
>
> sorry for the delay
>
That's alright ;-)
> On Mon, Jan 28, 2013 at 07:06:56PM +0530, Vivek Gautam wrote:
>> Hi Felipe,
>>
>>
>> On Mon, Jan 28, 2013 at 5:15 PM, Felipe Balbi wrote:
>> > On Mon, Jan 28, 2013 at 05:12:26P
Hi,
On Tue, Feb 26, 2013 at 07:23:01PM -0800, Paul Zimmerman wrote:
> Add a usb_otg_state_string() routine to print the OTG state for
> debugging
>
> Signed-off-by: Paul Zimmerman
> ---
> drivers/usb/usb-common.c | 26 ++
> include/linux/usb/phy.h | 8
> 2 fil
On Tue, Feb 26, 2013 at 07:23:06PM -0800, Paul Zimmerman wrote:
> Add the DWC2 Kconfig and Makefile, and modify the USB Kconfig and
> Makefile to include them
>
> Signed-off-by: Paul Zimmerman
thanks:
Acked-by: Felipe Balbi
--
balbi
signature.asc
Description: Digital signature
> > > > } else {
> > > > + if (ci->driver)
> > > > + ci->driver->disconnect(&ci->gadget);
> > >
> > > This looks wrong. Why do you need to call ->disconnect() here ?
> >
> > When we disconnect usb cable from the host, we need to
Hi,
On Tue, Feb 26, 2013 at 07:23:02PM -0800, Paul Zimmerman wrote:
> The core code provides basic services for accessing and managing
> the DWC_otg hardware. These services are used by both the Host
> Controller Driver and (in future) the Peripheral Controller Driver.
>
> Signed-off-by: Paul Zim
David Miller writes:
>> Applied, thanks Glen.
>
> Actually, I had to revert, this doesn't even compile against
> current sources:
>
> CC [M] drivers/net/usb/asix_devices.o
> drivers/net/usb/asix_devices.c:941:14: error: ‘asix_rx_fixup’ undeclared here
> (not in a function)
> make[1]: *** [dri
Hi,
On Tue, Feb 26, 2013 at 07:23:04PM -0800, Paul Zimmerman wrote:
> + qh->n_bytes = kzalloc(sizeof(u32) * dwc2_max_desc_num(qh), flags);
> + if (!qh->n_bytes) {
> + dev_err(hsotg->dev,
> + "%s: Failed to allocate array for descriptors' size
> actual value
Hi,
On Tue, Feb 26, 2013 at 07:23:05PM -0800, Paul Zimmerman wrote:
> + retval = dwc2_hcd_init(&dev->dev, hsotg, dev->irq, &dwc2_module_params);
> + if (retval)
still leaving pci device enabled.
> + return retval;
> +
> + /*
> + * WARNING: dwc2_hcd_init() calls usb_c
Hi Paul,
On Tue, Feb 26, 2013 at 07:23:00PM -0800, Paul Zimmerman wrote:
> Here is v5 of the DWC2 patch set. I think I made all of the changes we
> agreed on after your last review.
>
> You'll be happy to hear that I removed all of the module parameters. I
> realized it is easy enough for me to m
On 02/27/2013 09:10 AM, Felipe Balbi wrote:
> On Thu, Feb 14, 2013 at 07:43:54PM +0100, Sascha Hauer wrote:
>> On Thu, Feb 14, 2013 at 08:00:11PM +0200, Felipe Balbi wrote:
>>> Hi,
>>>
>>> On Thu, Feb 14, 2013 at 05:23:37PM +0100, Sascha Hauer wrote:
On Thu, Feb 14, 2013 at 12:37:29PM +0200, F
Oliver Neukum writes:
> On Tuesday 26 February 2013 14:59:23 Bjørn Mork wrote:
>> Oliver Neukum writes:
>>
>> > @@ -185,9 +187,17 @@ static void wdm_in_callback(struct urb *urb)
>> >}
>> >
>> >desc->rerr = status;
>> > - desc->reslength = urb->actual_length;
>> > - memmove(desc->ubu
From: Oliver Neukum
The buffer for responses must not overflow.
If this would happen, set a flag, drop the data and return
an error after user space has read all remaining data.
Signed-off-by: Oliver Neukum
CC: sta...@kernel.org
---
drivers/usb/class/cdc-wdm.c | 23 ---
1
On Wednesday 27 February 2013 10:27:32 Bjørn Mork wrote:
> I believe we could drop the reslength field altogether, avoiding this
> confusion. The field is only use to test for a 0 length read in a
> context where desc->length is known to be 0. In fact, we are really
> interested in the total desc
Hi,
re http://article.gmane.org/gmane.linux.usb.general/71002 I was
wondering if any progress have been made and if those log were OK.
Thanks,
Michal
On 09/20/2012 11:44 PM, Sarah Sharp wrote:
> On Wed, Sep 12, 2012 at 04:36:53PM -0700, Sarah Sharp wrote:
>> Would you be willing to run some test
On 02/14/2013 02:07 PM, Alexander Shishkin wrote:
> Sascha Hauer writes:
>
>> From: Michael Grzeschik
>>
>> This patch makes it possible to configure the PTW and PTS bits inside
>> the portsc register for host and device mode before the driver starts
>> and the phy can be addressed as hardware i
On 02/22/2013 03:09 AM, Peter Chen wrote:
> On Mon, Feb 04, 2013 at 02:24:32PM +0100, Sascha Hauer wrote:
>> Even if a chipidea core is otg capable the board may not. This allows
>> to explicitly set the core to host/peripheral mode. Without these
>> flags the driver falls back to the old behaviour
There's no reason not to allow samsung PHY
drivers be built as modules. This patch changes
Kconfig to allow that.
Signed-off-by: Felipe Balbi
---
Hi,
I will take your patches but I'm planning to add this on top
as there is no reason not to allow these drivers being built
as modules.
cheers
d
Hi,
On Wed, Feb 06, 2013 at 10:04:24AM +0800, Fengguang Wu wrote:
> Greetings,
>
> I got the below warning and the first bad commit is
can you send a fixup patch ?
--
balbi
signature.asc
Description: Digital signature
On Fri, Feb 08, 2013 at 01:59:41PM +0530, Supriya Karanth wrote:
> From: supriya karanth
>
> Generic changes for enabling DMA Mode1.
> Cleanup of rxtsate function making programming
> same for all platforms
>
> Handles:
> 1) Known transfer length
> a) Non multiple of packet size
> b)
Oliver Neukum writes:
> On Wednesday 27 February 2013 10:27:32 Bjørn Mork wrote:
>
>> I believe we could drop the reslength field altogether, avoiding this
>> confusion. The field is only use to test for a 0 length read in a
>> context where desc->length is known to be 0. In fact, we are really
>
>> Maybe I can try this with the mouse.
>> As far as I know, most HDD and pendrive do not use periodic tranfer.
>> So they can not produce the issue.
>
> few emails back you said it had nothing to do with periodic
> transfers. -ECONFUSED
>
I try two experiment,
1. Test it on general desktop, t
Hi Felipe,
On Wed, Feb 27, 2013 at 4:18 PM, Felipe Balbi wrote:
> There's no reason not to allow samsung PHY
> drivers be built as modules. This patch changes
> Kconfig to allow that.
>
> Signed-off-by: Felipe Balbi
> ---
>
> Hi,
>
> I will take your patches but I'm planning to add this on top
From: Freddy Xin
This is a resubmission.
Fixed endianness issue on big endian systems and verified this driver on iBook
G4.
Removed steps that change net->features in ax88179_set_features function.
Added "const" to ethtool_ops structure and fixed the coding style of
AX88179_BULKIN_SIZE array.
F
Hi,
On Wed, Feb 27, 2013 at 10:22:03AM +0800, Peter Chen wrote:
> On Tue, Feb 26, 2013 at 11:42:34AM +0200, Felipe Balbi wrote:
> > On Sun, Feb 17, 2013 at 05:24:42PM +0800, Peter Chen wrote:
> > > If the probe fails, the ci13xxx_add_device will not return error,
> > > (bus_probe_device doesn't ha
Hi,
On Wed, Feb 27, 2013 at 05:31:53PM +0530, Vivek Gautam wrote:
> Hi Felipe,
>
>
> On Wed, Feb 27, 2013 at 4:18 PM, Felipe Balbi wrote:
> > There's no reason not to allow samsung PHY
> > drivers be built as modules. This patch changes
> > Kconfig to allow that.
> >
> > Signed-off-by: Felipe B
On Wed, Feb 27, 2013 at 5:43 PM, Felipe Balbi wrote:
> Hi,
>
> On Wed, Feb 27, 2013 at 05:31:53PM +0530, Vivek Gautam wrote:
>> Hi Felipe,
>>
>>
>> On Wed, Feb 27, 2013 at 4:18 PM, Felipe Balbi wrote:
>> > There's no reason not to allow samsung PHY
>> > drivers be built as modules. This patch cha
On Wed, Feb 27, 2013 at 05:47:29PM +0530, Vivek Gautam wrote:
> On Wed, Feb 27, 2013 at 5:43 PM, Felipe Balbi wrote:
> > Hi,
> >
> > On Wed, Feb 27, 2013 at 05:31:53PM +0530, Vivek Gautam wrote:
> >> Hi Felipe,
> >>
> >>
> >> On Wed, Feb 27, 2013 at 4:18 PM, Felipe Balbi wrote:
> >> > There's no
From: Sascha Hauer
The dr_mode devicetree property allows to explicitly specify the
host/peripheral/otg mode. This is necessary for boards without proper
ID pin handling.
Reviewed-by: Peter Chen
Signed-off-by: Sascha Hauer
Signed-off-by: Marc Kleine-Budde
---
Documentation/devicetree/binding
From: Michael Grzeschik
This patch removes the limitation of having only one instance of the
ci13xxx-imx platformdata and makes different configurations possible.
Reviewed-by: Peter Chen
Signed-off-by: Michael Grzeschik
Signed-off-by: Sascha Hauer
Signed-off-by: Marc Kleine-Budde
---
driver
From: Sascha Hauer
This patch replaces the hand crafted code to retrieve the phy's phandle from
the DT by the helper function devm_usb_get_phy_by_phandle() which has been
added in commit:
"5d3c28b usb: otg: add device tree support to otg library"
Reviewed-by: Kishon Vijay Abraham I
Reviewe
From: Michael Grzeschik
This patch makes it possible to configure the PTW and PTS bits inside
the portsc register for host and device mode before the driver starts
and the phy can be addressed as hardware implementation is designed.
Signed-off-by: Michael Grzeschik
Signed-off-by: Sascha Hauer
From: Sascha Hauer
We now have usb_add_phy_dev(), so use it to register with the framework
to be able to find the phy from the USB driver.
Reviewed-by: Kishon Vijay Abraham I
Reviewed-by: Peter Chen
Acked-by: Felipe Balbi
Signed-off-by: Sascha Hauer
Signed-off-by: Marc Kleine-Budde
---
dri
From: Sascha Hauer
Even if a chipidea core is otg capable the board may not. This allows
to explicitly set the core to host/peripheral mode. Without these
flags the driver falls back to the old behaviour.
Signed-off-by: Sascha Hauer
Signed-off-by: Marc Kleine-Budde
---
drivers/usb/chipidea/co
In patch "5d3c28b usb: otg: add device tree support to otg library"
devm_usb_get_phy_by_phandle() was added. It uses try_module_get() to lock the
phy driver in memory. The corresponding module_put() is missing in that patch.
This patch adds try_module_get() to usb_get_phy() and usb_get_phy_dev().
From: Sascha Hauer
Most of otg/otg.c is not otg specific, but phy specific, so move it
to the phy directory.
Cc: Felipe Balbi
Reported-by: Kishon Vijay Abraham I
Signed-off-by: Sascha Hauer
Signed-off-by: Marc Kleine-Budde
---
drivers/usb/otg/otg.c| 427
Hello, this is the 5th round of Sascha's patch series, rebased to Greg's
usb-next.
Please consider to apply.
regards,
Marc
changes since v4:
- add support for USB_DR_MODE_DUAL_ROLE in dt helper
changes since v3:
- add phy patches (which were accidently already part of v2)
- Use OP_DEVLC instea
From: Michael Grzeschik
This adds two little devicetree helper functions for determining the dr_mode
(host, peripheral, otg, dual-role) and phy_type (utmi, ulpi,...) from the
devicetree.
Cc: Felipe Balbi
Signed-off-by: Michael Grzeschik
Signed-off-by: Sascha Hauer
Signed-off-by: Marc Kleine-B
On 02/27/2013 01:27 PM, Marc Kleine-Budde wrote:
> From: Sascha Hauer
>
> Most of otg/otg.c is not otg specific, but phy specific, so move it
> to the phy directory.
>
> Cc: Felipe Balbi
> Reported-by: Kishon Vijay Abraham I
> Signed-off-by: Sascha Hauer
> Signed-off-by: Marc Kleine-Budde
F
On 02/27/2013 01:27 PM, Marc Kleine-Budde wrote:
> From: Michael Grzeschik
>
> This adds two little devicetree helper functions for determining the dr_mode
> (host, peripheral, otg, dual-role) and phy_type (utmi, ulpi,...) from the
> devicetree.
>
> Cc: Felipe Balbi
> Signed-off-by: Michael Grz
On Wed, Feb 27, 2013 at 01:29:40PM +0100, Marc Kleine-Budde wrote:
> On 02/27/2013 01:27 PM, Marc Kleine-Budde wrote:
> > From: Sascha Hauer
> >
> > Most of otg/otg.c is not otg specific, but phy specific, so move it
> > to the phy directory.
> >
> > Cc: Felipe Balbi
> > Reported-by: Kishon Vij
On Wed, Feb 27, 2013 at 01:27:07PM +0100, Marc Kleine-Budde wrote:
> In patch "5d3c28b usb: otg: add device tree support to otg library"
> devm_usb_get_phy_by_phandle() was added. It uses try_module_get() to lock the
> phy driver in memory. The corresponding module_put() is missing in that patch.
>
On Wed, Feb 27, 2013 at 01:27:09PM +0100, Marc Kleine-Budde wrote:
> From: Michael Grzeschik
>
> This adds two little devicetree helper functions for determining the dr_mode
it looks to me that "mode" is enough. s/dr_mode/mode/
--
balbi
signature.asc
Description: Digital signature
On Wed, Feb 27, 2013 at 01:31:02PM +0100, Marc Kleine-Budde wrote:
> On 02/27/2013 01:27 PM, Marc Kleine-Budde wrote:
> > From: Michael Grzeschik
> >
> > This adds two little devicetree helper functions for determining the dr_mode
> > (host, peripheral, otg, dual-role) and phy_type (utmi, ulpi,..
Hello Matthew Dharm,
This is an old warning but it looks like it might be valid.
The patch 34008dbfe8c0: "[PATCH] USB Storage: add support for Maxtor
One-Touch button" from Jul 28, 2005, leads to the following Smatch
warning:
"drivers/usb/storage/onetouch.c:248 onetouch_connect_input()
On 02/27/2013 01:32 PM, Felipe Balbi wrote:
> On Wed, Feb 27, 2013 at 01:27:09PM +0100, Marc Kleine-Budde wrote:
>> From: Michael Grzeschik
>>
>> This adds two little devicetree helper functions for determining the dr_mode
>
> it looks to me that "mode" is enough. s/dr_mode/mode/
There already i
Hello.
On 27-02-2013 10:33, Peter Chen wrote:
If the core's probe fails, the platform layer may not get core's
private data, if the platform tries to use struct ci13xxx, it will
use uninitialized pointer. Besides, if the core's probe fails,
the platform layer should know it, and let its probe f
On 02/27/2013 01:31 PM, Felipe Balbi wrote:
> On Wed, Feb 27, 2013 at 01:27:07PM +0100, Marc Kleine-Budde wrote:
>> In patch "5d3c28b usb: otg: add device tree support to otg library"
>> devm_usb_get_phy_by_phandle() was added. It uses try_module_get() to lock the
>> phy driver in memory. The corre
On Wed, Feb 27, 2013 at 01:38:41PM +0100, Marc Kleine-Budde wrote:
> On 02/27/2013 01:32 PM, Felipe Balbi wrote:
> > On Wed, Feb 27, 2013 at 01:27:09PM +0100, Marc Kleine-Budde wrote:
> >> From: Michael Grzeschik
> >>
> >> This adds two little devicetree helper functions for determining the
> >>
Hi,
On Wed, Feb 27, 2013 at 01:40:51PM +0100, Marc Kleine-Budde wrote:
> On 02/27/2013 01:31 PM, Felipe Balbi wrote:
> > On Wed, Feb 27, 2013 at 01:27:07PM +0100, Marc Kleine-Budde wrote:
> >> In patch "5d3c28b usb: otg: add device tree support to otg library"
> >> devm_usb_get_phy_by_phandle() wa
On 02/27/2013 01:43 PM, Felipe Balbi wrote:
> Hi,
>
> On Wed, Feb 27, 2013 at 01:40:51PM +0100, Marc Kleine-Budde wrote:
>> On 02/27/2013 01:31 PM, Felipe Balbi wrote:
>>> On Wed, Feb 27, 2013 at 01:27:07PM +0100, Marc Kleine-Budde wrote:
In patch "5d3c28b usb: otg: add device tree support to
On Wed, Feb 27, 2013 at 01:46:21PM +0100, Marc Kleine-Budde wrote:
> On 02/27/2013 01:43 PM, Felipe Balbi wrote:
> > Hi,
> >
> > On Wed, Feb 27, 2013 at 01:40:51PM +0100, Marc Kleine-Budde wrote:
> >> On 02/27/2013 01:31 PM, Felipe Balbi wrote:
> >>> On Wed, Feb 27, 2013 at 01:27:07PM +0100, Marc
My patch bomb of yesterday is hardly managable. I'm resending the fixes
separately now and then the remaining usb-next patches that depend on them once
the fixes are in.
I apologise for the noise,
Johan
Johan Hovold (5):
USB: cdc-acm: fix device unregistration
USB: ftdi_sio: fix use after fr
Remove bogus disconnect test introduced by 95bef012e ("USB: more serial
drivers writing after disconnect") which prevented queued data from
being freed on disconnect.
The possible IO it was supposed to prevent is long gone.
Cc: stable
Signed-off-by: Johan Hovold
---
drivers/usb/serial/garmin_g
Unregister tty device in disconnect as is required by the USB stack.
By deferring unregistration to when the last tty reference is dropped,
the parent interface device can get unregistered before the child
resulting in broken hotplug events being generated when the tty is
finally closed:
KERNEL[2
Make sure to check the serial disconnected flag before accessing port
private data after waking up.
This fixes a use after free in the ftdi_sio introduced by commit
876ae50d94b ("USB: ftdi_sio: fix race condition in TIOCMIWAIT, and abort
of TIOCMIWAIT when the device is removed").
When switching
Make sure the interface is not released before our serial device.
Note that drivers are still not allowed to access the interface in
any way that may interfere with another driver that may have gotten
bound to the same interface after disconnect returns.
Cc: stable
Signed-off-by: Johan Hovold
-
Add missing get_icount field to two-port driver.
The two-port driver was not updated when switching to the new icount
interface in commit 0bca1b913aff ("tty: Convert the USB drivers to the
new icount interface").
Cc: stable
Signed-off-by: Johan Hovold
---
drivers/usb/serial/io_ti.c | 1 +
1 fi
On 02/27/2013 01:47 PM, Felipe Balbi wrote:
> On Wed, Feb 27, 2013 at 01:46:21PM +0100, Marc Kleine-Budde wrote:
>> On 02/27/2013 01:43 PM, Felipe Balbi wrote:
>>> Hi,
>>>
>>> On Wed, Feb 27, 2013 at 01:40:51PM +0100, Marc Kleine-Budde wrote:
On 02/27/2013 01:31 PM, Felipe Balbi wrote:
> O
Tag all Huawei NCM devices as WWAN modems, as we don't know of any which
are not. This is necessary for userspace clients to know that the device
requires further setup on e.g. an AT-capable serial ports before
connectivity is available.
Signed-off-by: Bjørn Mork
---
drivers/net/usb/cdc_ncm.c |
On Wednesday 27 February 2013 13:52:26 Johan Hovold wrote:
> Unregister tty device in disconnect as is required by the USB stack.
>
> By deferring unregistration to when the last tty reference is dropped,
> the parent interface device can get unregistered before the child
> resulting in broken hot
Hi,
On Wed, Feb 27, 2013 at 01:55:35PM +0100, Marc Kleine-Budde wrote:
> On 02/27/2013 01:47 PM, Felipe Balbi wrote:
> > On Wed, Feb 27, 2013 at 01:46:21PM +0100, Marc Kleine-Budde wrote:
> >> On 02/27/2013 01:43 PM, Felipe Balbi wrote:
> >>> Hi,
> >>>
> >>> On Wed, Feb 27, 2013 at 01:40:51PM +010
On 02/27/2013 02:42 PM, Felipe Balbi wrote:
>> That'll be these 3 branches then:
>>
>> otg-for-v3.9 (bugfix for v3.9):
>> 6bef020 USB otg: use try_module_get in all usb_get_phy functions and add
>> missing module_put
>>
>> otg-for-v3.10 (depends on otg-for-v3.9):
>> a0e17f5 USB: move bulk of otg/o
Hi Samuel,
One of my patch that I sent for 3.9 introduces a bug that fails to
update the port mode hostconfig register. Because of that, the port modes will
always be 0 (i.e. EHCI PHY mode) and other modes will not work. PHY mode will
work, so beagle/panda have no issues.
Since my hardware setup
There seem to be an "infinite" number of these devices. Replacing
the individual device entry with a vendor rule to catch them all,
adding a safeguard test to the probe function in case the same
vendor ID is used for e.g. RNDIS devices.
This adds support for the Huawei E5331 and an unknown number
In patch "5d3c28b usb: otg: add device tree support to otg library"
devm_usb_get_phy_by_phandle() was added. It uses try_module_get() to lock the
phy driver in memory. The corresponding module_put() is missing in that patch.
This patch adds try_module_get() to usb_get_phy() and usb_get_phy_dev().
Hello,
this patch is intended for v3.9 and applies to Greg's usb/master tree. If fixes
the use of try_module_get() and module_put() in all usb_get_phy functions.
regards,
Marc
The following changes since commit 74e1a2a39355b2d3ae8c60c78d8add162c6d7183:
Merge tag 'usb-3.9-rc1' of
git://git.k
Hi,
Trying to compile 'usb-next' branch with exynos_defconfig, but hit
upon compilation error.
arch/arm/plat-samsung/dma-ops.c: In function 'samsung_dmadev_request':
arch/arm/plat-samsung/dma-ops.c:39: error: implicit declaration of
function 'dma_request_slave_channel'
make[1]: *** [arch/arm/pla
Hello,
this series depends on the bugfix patch "USB otg: use try_module_get in all
usb_get_phy functions and add missing module_put" (a.k.a tags/otg-for-v3.9-v1)
posted earlier and is inteded for v3.10. It separates the phy from the otg code
and adds DT helper functions. Further mxs-phy uses the n
From: Michael Grzeschik
This adds two little devicetree helper functions for determining the dr_mode
(host, peripheral, otg, dual-role) and phy_type (utmi, ulpi,...) from the
devicetree.
Cc: Felipe Balbi
Signed-off-by: Michael Grzeschik
Signed-off-by: Sascha Hauer
Signed-off-by: Marc Kleine-B
From: Sascha Hauer
Most of otg/otg.c is not otg specific, but phy specific, so move it
to the phy directory.
Cc: Felipe Balbi
Reported-by: Kishon Vijay Abraham I
Signed-off-by: Sascha Hauer
Signed-off-by: Marc Kleine-Budde
---
drivers/usb/otg/otg.c| 427
From: Sascha Hauer
We now have usb_add_phy_dev(), so use it to register with the framework
to be able to find the phy from the USB driver.
Reviewed-by: Kishon Vijay Abraham I
Reviewed-by: Peter Chen
Acked-by: Felipe Balbi
Signed-off-by: Sascha Hauer
Signed-off-by: Marc Kleine-Budde
---
dri
Bjørn Mork writes:
> + * CDC ACM with vendor specific protocol may signify RNDIS or
> + * serial or something else. A number of Huawei devices use
> + * it for serial functions having only 2 endpoints,
Arrgh. Please drop this patch.
I thought I had verified this over and over a
From: Michael Grzeschik
This patch makes it possible to configure the PTW and PTS bits inside
the portsc register for host and device mode before the driver starts
and the phy can be addressed as hardware implementation is designed.
Signed-off-by: Michael Grzeschik
Signed-off-by: Sascha Hauer
From: Sascha Hauer
The dr_mode devicetree property allows to explicitly specify the
host/peripheral/otg mode. This is necessary for boards without proper
ID pin handling.
Reviewed-by: Peter Chen
Signed-off-by: Sascha Hauer
Signed-off-by: Marc Kleine-Budde
---
Documentation/devicetree/binding
Hello,
this series depends on the series "[PATCH 0/3] otg-for-v3.10-v1: separate phy
code and add DT helper" (a.k.a. tags/otg-for-v3.10-v1) posted earlier and is
intended for v3.10. The chipidea driver is converted to make use of the DT
helper functions.
regards,
Marc
The following changes sinc
From: Michael Grzeschik
This patch removes the limitation of having only one instance of the
ci13xxx-imx platformdata and makes different configurations possible.
Reviewed-by: Peter Chen
Signed-off-by: Michael Grzeschik
Signed-off-by: Sascha Hauer
Signed-off-by: Marc Kleine-Budde
---
driver
From: Sascha Hauer
This patch replaces the hand crafted code to retrieve the phy's phandle from
the DT by the helper function devm_usb_get_phy_by_phandle() which has been
added in commit:
"5d3c28b usb: otg: add device tree support to otg library"
Reviewed-by: Kishon Vijay Abraham I
Reviewe
From: Sascha Hauer
Even if a chipidea core is otg capable the board may not. This allows
to explicitly set the core to host/peripheral mode. Without these
flags the driver falls back to the old behaviour.
Signed-off-by: Sascha Hauer
Signed-off-by: Marc Kleine-Budde
---
drivers/usb/chipidea/co
On 02/27/2013 02:55 PM, Marc Kleine-Budde wrote:
> On 02/27/2013 02:42 PM, Felipe Balbi wrote:
>>> That'll be these 3 branches then:
>>>
>>> otg-for-v3.9 (bugfix for v3.9):
>>> 6bef020 USB otg: use try_module_get in all usb_get_phy functions and add
>>> missing module_put
>>>
>>> otg-for-v3.10 (de
This USB ethernet adapter was purchased in anodyne packaging
from the computer store adjacent to linux.conf.au 2013 in
Canberra (Australia). A web search shows other recent
purchasers in Lancaster (UK) and Seattle (USA). Just like an
emergent virus, our age of e-commerce and airmail allows
underdoc
Hi balbi,
actually no. I don't work with this hardware any more and don't have
free time to support it.
Please feel free to remove it if it breaks other things.
Darius.
On Wed, Feb 27, 2013 at 10:36 AM, Felipe Balbi wrote:
> Hi Darius,
>
> On Wed, Feb 27, 2013 at 04:13:14PM +0800, Peter Chen w
Based on 'usb-next'
Changes from v5:
- Squashed the following change from Felipe in this patch-set:
[PATCH] usb: phy: samsung: let it be built as a module
- Using EXPORT_SYMBOL_GPL() to export symbols in "samsung-usbphy.c"
to allow module builds of these samsung PHY drivers.
Vivek Gautam
Moving register and structure definitions to header file,
and keeping the generic functions to be used across
multiple PHYs in common phy helper driver under SAMSUNG_USBPHY,
and moving USB 2.0 PHY driver under SAMSUNG_USB2PHY.
Also allowing samsung PHY drivers be built as modules.
Signed-off-by:
Adding PHY driver support for USB 3.0 controller for Samsung's
SoCs.
Signed-off-by: Vivek Gautam
Signed-off-by: Felipe Balbi
Acked-by: Kukjin Kim
---
drivers/usb/phy/Kconfig |8 +
drivers/usb/phy/Makefile |1 +
drivers/usb/phy/samsung-usb3phy.c | 349 +++
Another device using CDC ACM with vendor specific protocol to mark
serial functions.
Cc: stable
Signed-off-by: Bjørn Mork
---
This replaces the patch titled
'USB: option: use vendor match for Huawei "ACM" devices'
by adding a new device specific entry instead.
I still think we should create
Hi,
I noticed that USB host is no longer functional on mx28evk running 3.8
kernel. It worked well until 3.7.9:
3.7.9 kernel:
[1.19] usbcore: registered new interface driver usb-storage
[1.20] USB Mass Storage support registered.
[1.20] imx_usb 8008.usb: pinctrl get/se
1 - 100 of 172 matches
Mail list logo
