Re: usb_wwan_write() called while device still being resumed

2013-02-15 Thread Alex Courbot
Hi Bjørn, thanks for the reply! On 02/15/2013 02:41 AM, Bjørn Mork wrote: I believe the usb_autopm_get_interface_async() failing is OK in this case, but that should not cause the modem to stop working. Wonder if this patch solves the problem? : From: =?UTF-8?q?Bj=C3=B8rn=20Mork?= Date: Thu, 1

Re: [PATCH v2] USB: cdc-wdm: fix read buffer overflow

2013-02-15 Thread Oliver Neukum
On Friday 15 February 2013 08:53:28 Bjørn Mork wrote: > Oliver Neukum writes: > > We have to let user space recover. To do so we need to indicate when > > exactly we dropped data. > > The problem with that is that this is likely to happen when a client > just doesn't care. It will just continue

[V2 0/8] usb: ehci: more bus glues as separate modules

2013-02-15 Thread Manjunath Goudar
Separate the SOC On-Chip host controller driver from ehci-hcd host code into its own driver module V2: Modified the patches, based on the first version review comments Manjunath Goudar (8): USB: EHCI: make ehci-spear a separate driver USB: EHCI: make ehci-atmel a separate driver USB: EHCI

[V2 1/8] USB: EHCI: make ehci-spear a separate driver

2013-02-15 Thread Manjunath Goudar
Separate the SPEAr host controller driver from ehci-hcd host code into its own driver module. In V2: Replaced spear as SPEAr everywhere, leaving functions/variables/config options. Signed-off-by: Manjunath Goudar Signed-off-by: Deepak Saxena Cc: Greg KH Cc: Alan Stern Acked-by: Viresh Kumar

[V2 2/8] USB: EHCI: make ehci-atmel a separate driver

2013-02-15 Thread Manjunath Goudar
Separate the Atmel host controller driver from ehci-hcd host code into its own driver module. In V2: Resolved below compiler error. drivers/usb/host/ehci-atmel.c: In function 'ehci_atmel_drv_remove': drivers/usb/host/ehci-atmel.c:167: error: implicit declaration of function 'ehci_shutdown' Signe

[V2 3/8] USB: EHCI: make ehci-s5p a separate driver

2013-02-15 Thread Manjunath Goudar
Separate the s5p host controller driver from ehci-hcd host code into its own driver module. In V2: Tegra patch related changes removed from this patch. Signed-off-by: Manjunath Goudar Acked-by: Jingoo Han Cc: Greg KH Cc: Alan Stern Cc: Kukjin Kim Cc: Kyungmin Park Cc: Grant Likely Cc: Rob

[V2 4/8] USB: EHCI: make ehci-mv as separate static driver

2013-02-15 Thread Manjunath Goudar
Separate the mv host controller driver from ehci-hcd host code into its own static driver module. In V2: No changes only Cc list changed in this patch. Signed-off-by: Manjunath Goudar Cc: Greg KH Cc: Alan Stern Cc: Eric Miao Cc: Haojian Zhuang Cc: Russell King Cc: linux-usb@vger.kernel.org

[V2 8/8] USB: EHCI: make ehci-orion a separate driver

2013-02-15 Thread Manjunath Goudar
Separate the Orion host controller driver from ehci-hcd host code into its own static driver module. In V2: Tegra patch related changes removed from this patch. Signed-off-by: Manjunath Goudar Cc: Greg KH Cc: Alan Stern Cc: Jason Cooper Cc: Andrew Lunn Cc: Russell King Cc: linux-arm-ker...@

[V2 6/8] USB: EHCI: make ehci-msm a separate driver

2013-02-15 Thread Manjunath Goudar
Separate the Qualcomm On-Chip host controller driver from ehci-hcd host code into its own driver module. In V2: Tegra patch related changes removed from this patch. Signed-off-by: Manjunath Goudar Cc: Greg KH Cc: Alan Stern Cc: David Brown Cc: Daniel Walker Cc: Bryan Huntsman Cc: Brian Swet

Re: [patch] USB: chipidea: fix & vs | bug

2013-02-15 Thread Dan Carpenter
On Fri, Sep 14, 2012 at 02:58:20PM +0800, Richard Zhao wrote: > On Fri, Sep 14, 2012 at 09:50:56AM +0300, Dan Carpenter wrote: > > There is a '&' vs '|' typo in the original code so the condition is > > never true and we don't queue the work. > > > > Signed-off-by: Dan Carpenter > > --- > > > >

[V2 7/8] USB: EHCI: make ehci-w90X900 a separate driver

2013-02-15 Thread Manjunath Goudar
Separate the Nuvoton On-Chip host controller driver from ehci-hcd host code into its own static driver module. In V2: No changes. Signed-off-by: Manjunath Goudar Cc: Greg KH Cc: Alan Stern Cc: Wan ZongShun Cc: linux-usb@vger.kernel.org Cc: linux-ker...@vger.kernel.org --- drivers/usb/host/Kc

[V2 5/8] USB: EHCI: make ehci-vt8500 a separate driver

2013-02-15 Thread Manjunath Goudar
Separate the vt8500 host controller driver from ehci-hcd host code into its own driver module. In V2: Change the GPL to GPL v2 MODULE_LICENSE Signed-off-by: Manjunath Goudar Cc: Greg KH Cc: Alan Stern Cc: Tony Prisk Cc: Alexey Charkov Cc: linux-usb@vger.kernel.org Cc: linux-ker...@vger.kern

Re: [PATCH 3/9] USB: add devicetree helpers for determining dr_mode and phy_type

2013-02-15 Thread Sascha Hauer
On Thu, Feb 14, 2013 at 09:36:26PM +0200, Felipe Balbi wrote: > Hi, > > On Thu, Feb 14, 2013 at 07:30:26PM +0100, Sascha Hauer wrote: > > > > > yeah, this is why I said we should ignore dr_mode (or bail out) when > > > > > !OTG. > > > > > > > > Ok, that's what the patch effectively does. We have

Re: usb_wwan_write() called while device still being resumed

2013-02-15 Thread Bjørn Mork
Alex Courbot writes: > Unfortunately it does not, and fails the same way. On the other hand, > I do not see the issue when doing the following: > > diff --git a/drivers/usb/serial/usb_wwan.c b/drivers/usb/serial/usb_wwan.c > index e4fad5e..1490029 100644 > --- a/drivers/usb/serial/usb_wwan.c > ++

Re: [patch] USB: chipidea: fix & vs | bug

2013-02-15 Thread Dan Carpenter
On Fri, Feb 15, 2013 at 01:26:29PM +0300, Dan Carpenter wrote: > On Fri, Sep 14, 2012 at 02:58:20PM +0800, Richard Zhao wrote: > > On Fri, Sep 14, 2012 at 09:50:56AM +0300, Dan Carpenter wrote: > > > There is a '&' vs '|' typo in the original code so the condition is > > > never true and we don't q

Re: [PATCH v4 05/11] usb: dwc3: core: add power management support

2013-02-15 Thread Vivek Gautam
Hi Felipe, On Tue, Feb 12, 2013 at 2:17 PM, Felipe Balbi wrote: > Add support for basic power management on > the dwc3 driver. While there is still lots > to improve for full PM support, this minimal > patch will already make sure that we survive > suspend-to-ram and suspend-to-disk without > ma

Re: [PATCH v2] USB: cdc-wdm: fix read buffer overflow

2013-02-15 Thread Bjørn Mork
Oliver Neukum writes: > On Friday 15 February 2013 08:53:28 Bjørn Mork wrote: >> Oliver Neukum writes: > >> > We have to let user space recover. To do so we need to indicate when >> > exactly we dropped data. >> >> The problem with that is that this is likely to happen when a client >> just does

Re: [patch] USB: chipidea: fix & vs | bug

2013-02-15 Thread Alexander Shishkin
Dan Carpenter writes: > On Fri, Feb 15, 2013 at 01:26:29PM +0300, Dan Carpenter wrote: >> On Fri, Sep 14, 2012 at 02:58:20PM +0800, Richard Zhao wrote: >> > On Fri, Sep 14, 2012 at 09:50:56AM +0300, Dan Carpenter wrote: >> > > There is a '&' vs '|' typo in the original code so the condition is >>

Re: [PATCH v4 05/11] usb: dwc3: core: add power management support

2013-02-15 Thread Felipe Balbi
Hi, On Fri, Feb 15, 2013 at 04:40:43PM +0530, Vivek Gautam wrote: > Hi Felipe, > > > On Tue, Feb 12, 2013 at 2:17 PM, Felipe Balbi wrote: > > Add support for basic power management on > > the dwc3 driver. While there is still lots > > to improve for full PM support, this minimal > > patch will

Re: [patch] USB: chipidea: fix & vs | bug

2013-02-15 Thread Dan Carpenter
On Fri, Feb 15, 2013 at 02:54:56PM +0200, Alexander Shishkin wrote: > Dan Carpenter writes: > > > On Fri, Feb 15, 2013 at 01:26:29PM +0300, Dan Carpenter wrote: > >> On Fri, Sep 14, 2012 at 02:58:20PM +0800, Richard Zhao wrote: > >> > On Fri, Sep 14, 2012 at 09:50:56AM +0300, Dan Carpenter wrote:

Re: [patch] USB: chipidea: fix & vs | bug

2013-02-15 Thread Alexander Shishkin
Dan Carpenter writes: > On Fri, Feb 15, 2013 at 02:54:56PM +0200, Alexander Shishkin wrote: >> Dan Carpenter writes: >> >> > On Fri, Feb 15, 2013 at 01:26:29PM +0300, Dan Carpenter wrote: >> >> On Fri, Sep 14, 2012 at 02:58:20PM +0800, Richard Zhao wrote: >> >> > On Fri, Sep 14, 2012 at 09:50:5

Re: [PATCH v4 05/11] usb: dwc3: core: add power management support

2013-02-15 Thread Vivek Gautam
On Fri, Feb 15, 2013 at 6:45 PM, Felipe Balbi wrote: > Hi, > > On Fri, Feb 15, 2013 at 04:40:43PM +0530, Vivek Gautam wrote: >> Hi Felipe, >> >> >> On Tue, Feb 12, 2013 at 2:17 PM, Felipe Balbi wrote: >> > Add support for basic power management on >> > the dwc3 driver. While there is still lots >

Re: [V2 0/8] usb: ehci: more bus glues as separate modules

2013-02-15 Thread Arnd Bergmann
On Friday 15 February 2013, Manjunath Goudar wrote: > Separate the SOC On-Chip host controller driver from ehci-hcd > host code into its own driver module > > V2: > Modified the patches, based on the first version review comments > The series looks good to me now, great work! Please add my 'A

Re: [V2 0/8] usb: ehci: more bus glues as separate modules

2013-02-15 Thread Ezequiel Garcia
Hi Manjunath, Nice job! On Fri, Feb 15, 2013 at 03:54:05PM +0530, Manjunath Goudar wrote: > Separate the SOC On-Chip host controller driver from ehci-hcd > host code into its own driver module > > V2: > Modified the patches, based on the first version review comments > If at all possible, I'

Re: io_edgeport problem - Digi Edgeport/4r with 3.2.0 linux

2013-02-15 Thread simon
> Wow, that's really bad. Something is keeping the io_edgeport driver > from being loaded. It should be automatically found and bound to this > device when you plug it in. > > I don't know what to suggest at this point in time other than to file a > bug with Ubuntu, sorry. I happen to have an Ed

Consistant naming for LED class USB devices?

2013-02-15 Thread simon
No word from 'linux-input' so cross posting to 'linux-usb', Simon -- Hi, I'm after naming suggestions for USB devices which use the LED class. On one gaming wheel (Steelseries SWR-S1) I was able to use the serial number, how

Re: [V2 0/8] usb: ehci: more bus glues as separate modules

2013-02-15 Thread Greg KH
On Fri, Feb 15, 2013 at 04:10:52PM +, Arnd Bergmann wrote: > On Friday 15 February 2013, Manjunath Goudar wrote: > > Separate the SOC On-Chip host controller driver from ehci-hcd > > host code into its own driver module > > > > V2: > > Modified the patches, based on the first version review co

Re: Consistant naming for LED class USB devices?

2013-02-15 Thread Greg KH
On Fri, Feb 15, 2013 at 01:05:38PM -0500, si...@mungewell.org wrote: > No word from 'linux-input' so cross posting to 'linux-usb', > Simon > > -- > > Hi, > I'm after naming suggestions for USB devices which use the LED class.

Re: io_edgeport problem - Digi Edgeport/4r with 3.2.0 linux

2013-02-15 Thread Doug Minett
Simon: Thanks for checking it out in your environment. I think that your Xubuntu (11.10) is based on an earlier Ubuntu Kernel than I'm using (12.04 LTS). I appreciate the link to your Debian image and will check it out - but that is yet another kernel.. Greg: Any idea why Simon's Xubuntu seems

Re: io_edgeport problem - Digi Edgeport/4r with 3.2.0 linux

2013-02-15 Thread Greg KH
On Fri, Feb 15, 2013 at 01:21:48PM -0500, Doug Minett wrote: > Greg: Any idea why Simon's Xubuntu seems to work while also _not_ > loading io_edgeport - or would you guess that it is a earlier variant > on the bug that I am experiencing? I've filed a bug report with > Ubuntu. I have no idea, sorry

[PATCH] staging/usbip: Mark local functions as static (fix sparse warnings)

2013-02-15 Thread Peter Huewe
sparse complains about these functions: usbip/stub_dev.c:529:5: warning: symbol 'stub_pre_reset' was not declared. Should it be static? usbip/stub_dev.c:535:5: warning: symbol 'stub_post_reset' was not declared. Should it be static? -> add static keyword to silence the warning and make sparse ha

->drop_endpoint being called for disabled endpoints

2013-02-15 Thread Felipe Balbi
Cc: Linux USB Mailing List Bcc: Subject: usbcore calling ->drop_endpoint() for disabled eps Reply-To: ba...@ti.com Hi all, I keep seeing the following messages when transferring data to any USB3 mass storage I have (tried 3 different ones already): [618002.014556] xhci_hcd :03:00.0: xHCI x

Re: [PATCH v2 3/3] arm: mvebu: Update defconfig to select USB support

2013-02-15 Thread Jason Cooper
On Wed, Jan 23, 2013 at 12:26:32PM -0300, Ezequiel Garcia wrote: > Cc: Lior Amsalem > Cc: Thomas Petazzoni > Cc: Gregory CLEMENT > Tested-by: Nobuhiro Iwamatsu > Tested-by: Florian Fainelli > Signed-off-by: Ezequiel Garcia > --- > arch/arm/configs/mvebu_defconfig |5 - > 1 files chan

Re: [PATCH v2 1/3] arm: mvebu: Add support for USB host controllers in Armada 370/XP

2013-02-15 Thread Jason Cooper
On Wed, Jan 23, 2013 at 12:26:30PM -0300, Ezequiel Garcia wrote: > The Armada 370 and Armada XP SoC has an Orion EHCI USB controller. > This patch adds support for this controller in Armada 370 > and Armada XP SoC common device tree files. > > Cc: Lior Amsalem > Cc: Thomas Petazzoni > Tested-by:

Re: [PATCH v2 2/3] arm: mvebu: Enable USB controllers on Armada 370/XP boards

2013-02-15 Thread Jason Cooper
On Wed, Jan 23, 2013 at 12:26:31PM -0300, Ezequiel Garcia wrote: > This patch activates every USB port provided by each SoC. > Except for Armada XP Openblocks AX3-4 board, > where we enable only the first two USB ports > until we have more information on the third one usage. > > Cc: Lior Amsalem

Re: [PATCH v4 05/11] usb: dwc3: core: add power management support

2013-02-15 Thread Felipe Balbi
Hi, On Fri, Feb 15, 2013 at 09:11:33PM +0530, Vivek Gautam wrote: > On Fri, Feb 15, 2013 at 6:45 PM, Felipe Balbi wrote: > > Hi, > > > > On Fri, Feb 15, 2013 at 04:40:43PM +0530, Vivek Gautam wrote: > >> Hi Felipe, > >> > >> > >> On Tue, Feb 12, 2013 at 2:17 PM, Felipe Balbi wrote: > >> > Add su

Re: [PATCH v4 05/11] usb: dwc3: core: add power management support

2013-02-15 Thread Felipe Balbi
On Fri, Feb 15, 2013 at 09:11:33PM +0530, Vivek Gautam wrote: > On Fri, Feb 15, 2013 at 6:45 PM, Felipe Balbi wrote: > > Hi, > > > > On Fri, Feb 15, 2013 at 04:40:43PM +0530, Vivek Gautam wrote: > >> Hi Felipe, > >> > >> > >> On Tue, Feb 12, 2013 at 2:17 PM, Felipe Balbi wrote: > >> > Add support

Re: [V2 0/8] usb: ehci: more bus glues as separate modules

2013-02-15 Thread Arnd Bergmann
On Friday 15 February 2013, Greg KH wrote: > > Alan, Greg: I realize that it's too late to take the entire series for > > 3.9, but with the move of more ARM platforms to CONFIG_ARCH_MULTIPLATFORM, > > it is now possible to enable OMAP, VT8500 and ORION concurrently, along > > with the ones that are

Re: Resend: Donated code: xHCI debug capability driver

2013-02-15 Thread Sarah Sharp
On Tue, Jan 29, 2013 at 07:40:38PM +, Paul Zimmerman wrote: > Resending with updated xhci.h and signed-off-by added. > > Hi Sarah, > > We (Synopsys) would like to donate the attached code for driving the debug > capability of the xHCI controller. > > We used this code to test the debug capab

[PATCH 2/2] USB: EHCI: make ehci-orion a separate driver

2013-02-15 Thread Arnd Bergmann
From: Manjunath Goudar With the multiplatform changes in arm-soc tree, it becomes possible to enable the mvebu platform (which uses ehci-orion) at the same time as other platforms that require a conflicting EHCI bus glue. At the moment, this results in a warning like drivers/usb/host/ehci-hcd.c:

[PATCH 1/2] USB: EHCI: make ehci-vt8500 a separate driver

2013-02-15 Thread Arnd Bergmann
From: Manjunath Goudar With the multiplatform changes in arm-soc tree, it becomes possible to enable the vt8500 platform at the same time as other platforms that require a conflicting EHCI bus glue. At the moment, this results in a warning like drivers/usb/host/ehci-hcd.c:1277:0: warning: "PLATF

Re: [PATCH 1/2] USB: EHCI: make ehci-vt8500 a separate driver

2013-02-15 Thread Tony Prisk
On Fri, 2013-02-15 at 23:12 +0100, Arnd Bergmann wrote: > From: Manjunath Goudar > > With the multiplatform changes in arm-soc tree, it becomes > possible to enable the vt8500 platform at the same time > as other platforms that require a conflicting EHCI bus > glue. At the moment, this results in

RE: Resend: Donated code: xHCI debug capability driver

2013-02-15 Thread Paul Zimmerman
> From: Sarah Sharp [mailto:sarah.a.sh...@linux.intel.com] > Sent: Friday, February 15, 2013 2:05 PM > > On Tue, Jan 29, 2013 at 07:40:38PM +, Paul Zimmerman wrote: > > Resending with updated xhci.h and signed-off-by added. > > > > Hi Sarah, > > > > We (Synopsys) would like to donate the attac

Re: io_edgeport problem - Digi Edgeport/4r with 3.2.0 linux

2013-02-15 Thread Doug Minett
I did some followup on another machine at my disposal running a Debian 2.6.32-5-686-bigmem on the same hardware as the Ubuntu box - Dell Poweredge T110 II I plugged Digi in and had the same response as with the Ubuntu box - io_edgeport was not loaded/no new devices/same dmesg report. Then I ma

Re: io_edgeport problem - Digi Edgeport/4r with 3.2.0 linux

2013-02-15 Thread Greg KH
On Fri, Feb 15, 2013 at 06:25:00PM -0500, Doug Minett wrote: > I did some followup on another machine at my disposal running a Debian > 2.6.32-5-686-bigmem on the same hardware as the Ubuntu box - Dell Poweredge > T110 II > > I plugged Digi in and had the same response as with the Ubuntu box -

Re: [usb-storage + sd] Driver fails to read e-reader av (autovision) 606

2013-02-15 Thread Matthew Dharm
Ronald -- A quick review on the verbose log shows a few interesting things: 1) The device claims to use the USB Mass Storage Class, so it should work with usb-storage. 2) The device identifies itself to the SCSI layer as "rockchip rk28 sdk demo" -- a string like that is not very encouraging to m

Re: io_edgeport problem - Digi Edgeport/4r with 3.2.0 linux

2013-02-15 Thread Doug Minett
ah hah.. I'll give it try later. Eating and drinking.. On 2013-02-15, at 6:29 PM, Greg KH wrote: > On Fri, Feb 15, 2013 at 06:25:00PM -0500, Doug Minett wrote: >> I did some followup on another machine at my disposal running a Debian >> 2.6.32-5-686-bigmem on the same hardware as the Ubuntu box

Re: [PATCH 2/2] USB: EHCI: make ehci-orion a separate driver

2013-02-15 Thread Jason Cooper
On Fri, Feb 15, 2013 at 11:12:29PM +0100, Arnd Bergmann wrote: > From: Manjunath Goudar > > With the multiplatform changes in arm-soc tree, it becomes > possible to enable the mvebu platform (which uses > ehci-orion) at the same time as other platforms that require > a conflicting EHCI bus glue.