[PATCH] usb: dwc3: debugfs: convert our regdump to use regsets

2013-01-18 Thread Felipe Balbi
regset is a generic implementation of regdump utility through debugfs. Signed-off-by: Felipe Balbi --- Hi Greg, would you take the patch below to debugfs ? I don't think debugfs should ever change whatever's passed through struct debugfs_reg32 anyway. struct debugfs_regset32 { - struct d

[PATCH] esd_usb2: Do not do dma on the stack

2013-01-18 Thread Olivier Sobrie
smatch reports the following warnings: drivers/net/can/usb/esd_usb2.c:640 esd_usb2_start() error: doing dma on the stack (&msg) drivers/net/can/usb/esd_usb2.c:846 esd_usb2_close() error: doing dma on the stack (&msg) drivers/net/can/usb/esd_usb2.c:855 esd_usb2_close() error: doing dma on the sta

Re: [patch] USB: c67x00-ll-hpi.c: signedness bug in ll_recv_msg()

2013-01-18 Thread Peter Korsgaard
> "Dan" == Dan Carpenter writes: Dan> The callers expect this function to return zero on success or -EIO if it Dan> times out. The type should be int instead of unsigned short. Dan> Signed-off-by: Dan Carpenter Acked-by: Peter Korsgaard Dan> diff --git a/drivers/usb/c67x00/c67x00-l

[RESEND PATCH v9 0/2] usb: phy: samsung: Introducing usb phy driver for samsung SoCs

2013-01-18 Thread Praveen Paneri
Changes from v8: Resending this patch series after rebasing to the latest usb-next branch. Rewording inline comments for better readability. Removed IS_ENABLED(CONFIG_OF) as pdev->dev.of_node is enough to check for dt support. Using of_match_ptr to add of_match_table to platform_driver structure.

[RESEND PATCH v9 1/2] usb: phy: samsung: Introducing usb phy driver for hsotg

2013-01-18 Thread Praveen Paneri
This driver uses usb_phy interface to interact with s3c-hsotg. Supports phy_init and phy_shutdown functions to enable/disable usb phy. Support will be extended to host controllers and more Samsung SoCs. Signed-off-by: Praveen Paneri Acked-by: Heiko Stuebner Acked-by: Kyungmin Park --- .../devi

[RESEND PATCH v9 2/2] usb: s3c-hsotg: Adding phy driver support

2013-01-18 Thread Praveen Paneri
Adding the transceiver to hsotg driver. Keeping the platform data for continuing the smooth operation for boards which still uses it Signed-off-by: Praveen Paneri Acked-by: Kyungmin Park --- drivers/usb/gadget/s3c-hsotg.c | 37 +++-- 1 files changed, 27 inserti

Re: Wake on LAN for USB ethernet?

2013-01-18 Thread Petko Manolov
The code in the driver is based on the specs from ADMTek (later, Infineon). Since i never suspend my machines this feature has not been tested by me. However, if the proposed patch is the right thing to do i'd be happy to see it applied. cheers, Petko On Fri, 18 Jan 2013, Ming Lei wrote:

[PATCH 1/4] drivers: usb: phy: add a new driver for usb part of control module

2013-01-18 Thread Kishon Vijay Abraham I
Added a new driver for the usb part of control module. This has an API to power on the USB2 phy and an API to write to the mailbox depending on whether MUSB has to act in host mode or in device mode. Writing to control module registers for doing the above task which was previously done in omap glu

[PATCH 0/4] usb: musb: add driver for control module

2013-01-18 Thread Kishon Vijay Abraham I
Added a new driver for the usb part of control module. This has an API to power on the USB2 phy and an API to write to the mailbox depending on whether MUSB has to act in host mode or in device mode. Writing to control module registers for doing the above task which was previously done in omap glu

[PATCH 4/4] drivers: usb: start using the control module driver

2013-01-18 Thread Kishon Vijay Abraham I
Start using the control module driver for powering on the PHY and for writing to the mailbox instead of writing to the control module registers on their own. Signed-off-by: Kishon Vijay Abraham I --- Documentation/devicetree/bindings/usb/omap-usb.txt |4 ++ Documentation/devicetree/bindings/

[PATCH 3/4] ARM: OMAP2: MUSB: Specify omap4 has mailbox

2013-01-18 Thread Kishon Vijay Abraham I
Added has_mailbox to the musb platform data to specify that omap uses an external mailbox (in control module) to communicate with the musb core during device connect and disconnect. Signed-off-by: Kishon Vijay Abraham I --- arch/arm/mach-omap2/usb-musb.c |3 +++ include/linux/usb/musb.h

[PATCH 2/4] ARM: OMAP: devices: create device for usb part of control module

2013-01-18 Thread Kishon Vijay Abraham I
A seperate driver has been added to handle the usb part of control module. A device for the above driver is created here, using the register address information to be used by the driver for powering on the PHY and for writing to the mailbox. Signed-off-by: Kishon Vijay Abraham I --- arch/arm/mac

Re: [PATCH v7 01/22] mfd: omap-usb-host: Consolidate OMAP USB-HS platform data

2013-01-18 Thread Roger Quadros
On 01/17/2013 06:59 PM, Tony Lindgren wrote: > * Alan Stern [130117 07:19]: >> On Thu, 17 Jan 2013, Roger Quadros wrote: >> >>> Let's have a single platform data structure for the OMAP's High-Speed >>> USB host subsystem instead of having 3 separate ones i.e. one for >>> board data, one for USB Ho

[PATCH 0/3] ARM: dts: omap: add dt data for MUSB

2013-01-18 Thread Kishon Vijay Abraham I
This patch series adds dt data to get MUSB working in omap4 and omap3. Long time back a patch series with the same title was sent but only a part of it got merged. The rest of it wasn't merged because of adding omap control usb data to glue and usb phy. Now there exists a separate driver for contr

[PATCH 3/3] ARM: dts: omap: Add usb_otg and glue data

2013-01-18 Thread Kishon Vijay Abraham I
Add usb otg data node in omap4/omap3 device tree file. Also update the node with board specific setting in omapx-.dts file. The dt data specifies among others the interface type (ULPI or UTMI), mode which is mostly OTG, power that specifies the amount of power this can supply when in host mode. Ac

[PATCH 1/3] ARM: dts: omap: Add omap control usb data

2013-01-18 Thread Kishon Vijay Abraham I
Add omap control usb data in omap4 device tree file. This will have the register address of registers to power on the PHY and to write to mailbox. Signed-off-by: Kishon Vijay Abraham I --- arch/arm/boot/dts/omap4.dtsi |8 1 file changed, 8 insertions(+) diff --git a/arch/arm/boot/d

[PATCH 2/3] ARM: dts: omap: Add omap-usb2 dt data

2013-01-18 Thread Kishon Vijay Abraham I
Add omap-usb2 data node in omap4 device tree file. Since omap-usb2 is connected to ocp2scp, omap-usb2 dt data is added as a child node of ocp2scp. Acked-by: Felipe Balbi Signed-off-by: Kishon Vijay Abraham I --- arch/arm/boot/dts/omap4.dtsi |4 1 file changed, 4 insertions(+) diff --g

Re: [PATCH v7 0/6] solve deadlock caused by memory allocation with I/O

2013-01-18 Thread Ming Lei
On Fri, Jan 18, 2013 at 5:57 AM, Andrew Morton wrote: > > Fair enough, thanks. > > I grabbed the patches for 3.9-rc1. It is good that the page > allocator's newly-added test of current->flags is not on the fastpath. > Andrew, great thanks, :-) Also thank Alan, Oliver, Minchan, Rafael, Greg and

Re: [PATCH 2/2] usb: chipidea: imx: Add system suspend/resume API

2013-01-18 Thread Russell King - ARM Linux
On Fri, Jan 18, 2013 at 10:50:28AM +0800, Peter Chen wrote: > +#ifdef CONFIG_PM > +static int ci13xxx_imx_suspend(struct device *dev) > +{ > + struct ci13xxx_imx_data *data = > + platform_get_drvdata(to_platform_device(dev)); Is there a reason not to use dev_get_drvdata() here? Hi

Re: usb3.0 device recognized as usb2.1

2013-01-18 Thread kishon
Hi, On Friday 18 January 2013 03:25 AM, Richard Genoud wrote: Hi, I've got an usb3.0 HDD dock ( http://www.icydock.com/goods.php?id=130 ) wich uses JMicron JMS539 chipset and an USB3.0 board based on VIA VL800 B3 ( http://www.ldlc.com/fiche/PB00130847.html ) When I plug the dock in an UBS3.0 por

[LINKING BREAKAGE] mv_udc_core has unmet dependencies

2013-01-18 Thread Felipe Balbi
Hi Chao, You latest patches caused another breakage for x86. Please fix it asap or I will have to drop all your changes from my pull request. ERROR: "mv_usb2_unregister_notifier" [drivers/usb/gadget/mv_udc.ko] undefined! ERROR: "mv_usb2_register_notifier" [drivers/usb/gadget/mv_udc.ko] undefined!

Re: [Resend PATCH V4 0/10] usb: usb port power off mechanism anc expose usb port connect type

2013-01-18 Thread Lan Tianyu
On 2013年01月16日 23:45, Alan Stern wrote: > On Tue, 15 Jan 2013, Lan Tianyu wrote: > >> Hi Greg&Alan: >> Do you have some more comments about this patchset? Thanks. > > I don't have any more comments at this point. It looks okay to me. > > Acked-by: Alan Stern > > By the way, have you chec

[PATCH] usb: gadget: fix two sparse warnings

2013-01-18 Thread Felipe Balbi
drivers/usb/gadget/u_serial.c:1291:5: sparse: symbol \ 'userial_init' was not declared. Should it be static? drivers/usb/gadget/zero.c:66:25: sparse: symbol \ 'gzero_options' was not declared. Should it be static? Reported-by: Fengguang Wu Signed-off-by: Felipe Balbi --- drivers

[PATCH V2] usb/dwc3: fix ep->maxburst for ep0

2013-01-18 Thread Pratyush Anand
dwc3_gadget_set_ep_config expects maxburst as incremented by 1. So, by default initialize ep->maxburst to 1 for ep0. Signed-off-by: Pratyush Anand --- drivers/usb/dwc3/gadget.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/g

Re: [RFC PATCH 0/7] usb: musb: add driver for control module

2013-01-18 Thread Felipe Balbi
Hi, On Tue, Jan 15, 2013 at 02:12:51PM +0530, Kishon Vijay Abraham I wrote: > Added a new driver for the usb part of control module. This has an API > to power on the USB2 phy and an API to write to the mailbox depending on > whether MUSB has to act in host mode or in device mode. > > Writing to

Re: [RFC PATCH 1/6] usb: otg: Add an API to bind the USB controller and PHY

2013-01-18 Thread Felipe Balbi
On Thu, Jan 17, 2013 at 04:44:52PM +0530, kishon wrote: > >>@@ -171,6 +188,11 @@ static inline void devm_usb_put_phy(struct device > >>*dev, struct usb_phy *x) > >> { > >> } > >> > >>+static inline struct usb_phy_bind *usb_bind_phy(const char *dev_name, u8 > >>index, > >>+

Re: [RFC PATCH 0/6] USB: Add multiple PHYs of same type

2013-01-18 Thread Felipe Balbi
On Wed, Jan 16, 2013 at 08:30:56PM +0530, Kishon Vijay Abraham I wrote: > New platforms are being added which has multiple PHY's (of same type) and > which has multiple USB controllers. The binding information has to be > present in the PHY library (otg.c) in order for it to return the > appropriat

[balbi-usb:gadget 19/61] drivers/usb/gadget/mv_udc_core.c:1124:16: error: 'struct mv_usb_platform_data' has no member named 'phy_init'

2013-01-18 Thread kbuild test robot
tree: git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git gadget head: 7620f5f22e9317ab26c0fdbdd15c5e9ed972ef89 commit: 84b140524c107fb4f4fe618509bc067245c9d878 [19/61] usb: phy: mv_usb2: add PHY driver for marvell usb2 controller config: make ARCH=x86_64 allmodconfig All error/warnin

Re: [RFC PATCH 0/6] USB: Add multiple PHYs of same type

2013-01-18 Thread kishon
On Friday 18 January 2013 05:18 PM, Felipe Balbi wrote: On Wed, Jan 16, 2013 at 08:30:56PM +0530, Kishon Vijay Abraham I wrote: New platforms are being added which has multiple PHY's (of same type) and which has multiple USB controllers. The binding information has to be present in the PHY libra

Re: [PATCH 1/4] drivers: usb: phy: add a new driver for usb part of control module

2013-01-18 Thread Felipe Balbi
Hi, On Fri, Jan 18, 2013 at 03:10:42PM +0530, Kishon Vijay Abraham I wrote: > Added a new driver for the usb part of control module. This has an API > to power on the USB2 phy and an API to write to the mailbox depending on > whether MUSB has to act in host mode or in device mode. > > Writing to

[balbi-usb:gadget 29/61] drivers/usb/gadget/mv_udc_core.c:2097:17: error: 'struct mv_usb_platform_data' has no member named 'vbus'

2013-01-18 Thread kbuild test robot
tree: git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git gadget head: 7620f5f22e9317ab26c0fdbdd15c5e9ed972ef89 commit: 3dfa070934a431a14cf5469b4729fe17f0b87980 [29/61] usb: phy: mv_usb2_phy: add externel chip support config: make ARCH=x86_64 allmodconfig Note: the balbi-usb/gadget HE

Re: [PATCH 2/4] ARM: OMAP: devices: create device for usb part of control module

2013-01-18 Thread Felipe Balbi
On Fri, Jan 18, 2013 at 03:10:43PM +0530, Kishon Vijay Abraham I wrote: > A seperate driver has been added to handle the usb part of control > module. A device for the above driver is created here, using the register > address information to be used by the driver for powering on the PHY and > for w

Re: [PATCH 4/4] drivers: usb: start using the control module driver

2013-01-18 Thread Felipe Balbi
Hi, On Fri, Jan 18, 2013 at 03:10:45PM +0530, Kishon Vijay Abraham I wrote: > Start using the control module driver for powering on the PHY and for > writing to the mailbox instead of writing to the control module > registers on their own. > > Signed-off-by: Kishon Vijay Abraham I > --- > Docum

Re: [balbi-usb:gadget 19/61] drivers/usb/gadget/mv_udc_core.c:1124:16: error: 'struct mv_usb_platform_data' has no member named 'phy_init'

2013-01-18 Thread Felipe Balbi
On Fri, Jan 18, 2013 at 07:48:14PM +0800, kbuild test robot wrote: > tree: git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git gadget > head: 7620f5f22e9317ab26c0fdbdd15c5e9ed972ef89 > commit: 84b140524c107fb4f4fe618509bc067245c9d878 [19/61] usb: phy: mv_usb2: > add PHY driver for marv

[balbi-usb:gadget 43/61] make[4]: *** No rule to make target `drivers/usb/gadget/functions.o', needed by `drivers/usb/gadget/libcomposite.o'.

2013-01-18 Thread kbuild test robot
tree: git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git gadget head: 7620f5f22e9317ab26c0fdbdd15c5e9ed972ef89 commit: 2f06f18d080955b07c05cb2792708250f1f522e4 [43/61] usb: gadget: add some infracture to register/unregister functions config: make ARCH=x86_64 allmodconfig Note: the ba

Re: usb3.0 device recognized as usb2.1

2013-01-18 Thread Oliver Neukum
On Friday 18 January 2013 16:36:29 kishon wrote: > > Bus 001 Device 004: ID 152d:2509 JMicron Technology Corp. / JMicron > > USA Technology Corp. JMS539 SuperSpeed SATA II 3.0G Bridge > > Device Descriptor: > > You are connecting to the wrong port. > > Try connecting to bus2 which seems to have u

Re: [PATCH 1/4] drivers: usb: phy: add a new driver for usb part of control module

2013-01-18 Thread kishon
Hi, On Friday 18 January 2013 05:29 PM, Felipe Balbi wrote: Hi, On Fri, Jan 18, 2013 at 03:10:42PM +0530, Kishon Vijay Abraham I wrote: Added a new driver for the usb part of control module. This has an API to power on the USB2 phy and an API to write to the mailbox depending on whether MUSB h

Re: [PATCH 4/4] drivers: usb: start using the control module driver

2013-01-18 Thread kishon
On Friday 18 January 2013 05:32 PM, Felipe Balbi wrote: Hi, On Fri, Jan 18, 2013 at 03:10:45PM +0530, Kishon Vijay Abraham I wrote: Start using the control module driver for powering on the PHY and for writing to the mailbox instead of writing to the control module registers on their own. Sign

RE: [PATCH 2/2] usb: chipidea: imx: Add system suspend/resume API

2013-01-18 Thread Chen Peter-B29397
> > On Fri, Jan 18, 2013 at 10:50:28AM +0800, Peter Chen wrote: > > +#ifdef CONFIG_PM > > +static int ci13xxx_imx_suspend(struct device *dev) > > +{ > > + struct ci13xxx_imx_data *data = > > + platform_get_drvdata(to_platform_device(dev)); > > Is there a reason not to use dev_get_dr

Re: [PATCH 1/4] drivers: usb: phy: add a new driver for usb part of control module

2013-01-18 Thread Felipe Balbi
Hi, On Fri, Jan 18, 2013 at 05:40:04PM +0530, kishon wrote: > >>+void omap_control_usb_host_mode(struct device *dev) > >>+{ > >>+ u32 val; > >>+ struct omap_control_usb *control_usb = dev_get_drvdata(dev); > >>+ > >>+ val = AVALID | VBUSVALID; > >>+ > >>+ writel(val, control_usb->otghs_con

[PATCH v8 14/22] mfd: omap-usb-host: override number of ports from platform data

2013-01-18 Thread Roger Quadros
Both OMAP4 and 5 exhibit the same revision ID in the REVISION register but they have different number of ports i.e. 2 and 3 respectively. So we can't rely on REVISION register for number of ports on OMAP5 and depend on platform data (or device tree) instead. Signed-off-by: Roger Quadros Reviewed-

[PATCH v8 20/22] ARM: OMAP4: clock data: get rid of unused USB host clock aliases

2013-01-18 Thread Roger Quadros
We don't need multiple aliases for the OMAP USB host clocks so remove them. CC: Paul Walmsley CC: Rajendra Nayak CC: Benoit Cousson CC: Mike Turquette Signed-off-by: Roger Quadros Reviewed-by: Felipe Balbi Acked-by: Paul Walmsley --- arch/arm/mach-omap2/cclock44xx_data.c |7 --- 1

[PATCH v8 18/22] mfd: omap-usb-host: clean up omap_usbhs_init()

2013-01-18 Thread Roger Quadros
We split initializing revision 1 and revision 2 into different functions. Initialization is now done dynamically so that only the number of ports available on the system are initialized. Signed-off-by: Roger Quadros Reviewed-by: Felipe Balbi --- drivers/mfd/omap-usb-host.c | 129 ++

[PATCH v8 21/22] mfd: omap-usb-host: Don't spam console on clk_set_parent failure

2013-01-18 Thread Roger Quadros
clk_set_parent is expected to fail on OMAP3 platforms. We don't consider that as fatal so don't spam console. Signed-off-by: Roger Quadros Reviewed-by: Felipe Balbi --- drivers/mfd/omap-usb-host.c | 18 +- 1 files changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/

[PATCH v8 22/22] mdf: omap-usb-host: get rid of build warning

2013-01-18 Thread Roger Quadros
Fixes the below build warning when driver is built-in. drivers/mfd/omap-usb-host.c:750:12: warning: ‘usbhs_omap_remove’ defined but not used [-Wunused-function] Signed-off-by: Roger Quadros Reviewed-by: Felipe Balbi --- drivers/mfd/omap-usb-host.c |2 +- 1 files changed, 1 insertions(+), 1

[PATCH v8 19/22] ARM: OMAP3: clock data: get rid of unused USB host clock aliases and dummies

2013-01-18 Thread Roger Quadros
We don't need multiple aliases for the OMAP USB host clocks and neither the dummy clocks so remove them. CC: Paul Walmsley CC: Rajendra Nayak CC: Benoit Cousson CC: Mike Turquette Signed-off-by: Roger Quadros Reviewed-by: Felipe Balbi Acked-by: Paul Walmsley --- arch/arm/mach-omap2/cclock

[PATCH v8 15/22] mfd: omap-usb-host: cleanup clock management code

2013-01-18 Thread Roger Quadros
All ports have similarly named port clocks so we can bunch them into a port data structure and use for loop to enable/disable the clocks. Dynamically allocate and get clocks based on number of ports available on the platform Signed-off-by: Roger Quadros Reviewed-by: Felipe Balbi --- drivers/mf

[PATCH v8 17/22] mfd: omap-usb-host: Get rid of unnecessary spinlock

2013-01-18 Thread Roger Quadros
The driver does not have an interrupt handler and we don't really need a spinlock, so get rid of it. Signed-off-by: Roger Quadros Reviewed-by: Felipe Balbi --- drivers/mfd/omap-usb-host.c | 16 1 files changed, 0 insertions(+), 16 deletions(-) diff --git a/drivers/mfd/omap-u

[PATCH v8 16/22] mfd: omap-usb-host: Manage HSIC clocks for HSIC mode

2013-01-18 Thread Roger Quadros
Enable the optional HSIC clocks (60MHz and 480MHz) for the ports that are configured in HSIC mode. Signed-off-by: Roger Quadros Reviewed-by: Felipe Balbi --- drivers/mfd/omap-usb-host.c | 97 -- 1 files changed, 83 insertions(+), 14 deletions(-) diff -

[PATCH v8 13/22] mfd: omap-usb-host: know about number of ports from revision register

2013-01-18 Thread Roger Quadros
The revision register should tell us how many ports are present. Signed-off-by: Roger Quadros Reviewed-by: Felipe Balbi --- drivers/mfd/omap-usb-host.c | 33 - 1 files changed, 28 insertions(+), 5 deletions(-) diff --git a/drivers/mfd/omap-usb-host.c b/drivers

[PATCH v8 07/22] mfd: omap-usb-tll: Check for missing platform data in probe

2013-01-18 Thread Roger Quadros
No need to check for missing platform data in runtime_suspend/resume as it makes more sense to do it in the probe function. Signed-off-by: Roger Quadros Reviewed-by: Felipe Balbi --- drivers/mfd/omap-usb-tll.c | 15 +-- 1 files changed, 5 insertions(+), 10 deletions(-) diff --git

[PATCH v8 11/22] mfd: omap_usb_host: Avoid missing platform data checks in suspend/resume

2013-01-18 Thread Roger Quadros
Get rid of the unnecessary missing platform data checks in runtime_suspend/resume. We are already checking for missing platform data in probe. Signed-off-by: Roger Quadros Reviewed-by: Felipe Balbi --- drivers/mfd/omap-usb-host.c | 10 -- 1 files changed, 0 insertions(+), 10 deletions

[PATCH v8 12/22] mfd: omap-usb-host: Use devm_kzalloc() and devm_request_and_ioremap()

2013-01-18 Thread Roger Quadros
Use devm_ variants of kzalloc and ioremap. Also clean up error path. Signed-off-by: Roger Quadros Reviewed-by: Felipe Balbi --- drivers/mfd/omap-usb-host.c | 38 +++--- 1 files changed, 11 insertions(+), 27 deletions(-) diff --git a/drivers/mfd/omap-usb-host.c

[PATCH v8 10/22] mfd: omap-usb-tll: Add OMAP5 revision and HSIC support

2013-01-18 Thread Roger Quadros
The TLL module on OMAP5 has 3 channels. HSIC mode requires the TLL channel to be in Transparent UTMI mode. Signed-off-by: Roger Quadros Reviewed-by: Felipe Balbi --- drivers/mfd/omap-usb-tll.c | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/drivers/mfd/oma

[PATCH v8 01/22] USB: ehci-omap: Don't free gpios that we didn't request

2013-01-18 Thread Roger Quadros
This driver does not request any gpios so don't free them. Fixes L3 bus error on multiple modprobe/rmmod of ehci_hcd with ehci-omap in use. Without this patch, EHCI will break on repeated insmod/rmmod of ehci_hcd for all OMAP2+ platforms that use EHCI and set 'phy_reset = true' in usbhs_omap_board

[PATCH v8 02/22] mfd: omap-usb-host: Consolidate OMAP USB-HS platform data

2013-01-18 Thread Roger Quadros
Let's have a single platform data structure for the OMAP's High-Speed USB host subsystem instead of having 3 separate ones i.e. one for board data, one for USB Host (UHH) module and one for USB-TLL module. This makes the code much simpler and avoids creating multiple copies of platform data. CC:

[PATCH v8 09/22] mfd: omap-usb-tll: serialize access to TLL device

2013-01-18 Thread Roger Quadros
Get rid of the unnecessary spin_lock_irqsave/restore() as there is no interrupt handler for this driver. Instead we serialize access to tll_dev using a global spinlock. Signed-off-by: Roger Quadros Reviewed-by: Felipe Balbi --- drivers/mfd/omap-usb-tll.c | 53 ++---

[PATCH v8 06/22] mfd: omap-usb-tll: introduce and use mode_needs_tll()

2013-01-18 Thread Roger Quadros
This is a handy macro to check if the port requires the USB TLL module or not. Use it to Enable the TLL module and manage the clocks. Signed-off-by: Roger Quadros Reviewed-by: Felipe Balbi --- drivers/mfd/omap-usb-tll.c | 20 1 files changed, 12 insertions(+), 8 deletions

[PATCH v8 08/22] mfd: omap-usb-tll: Fix error message

2013-01-18 Thread Roger Quadros
omap_enable/disable_tll() can fail if TLL device is not initialized. It could be due to multiple reasons and not only due to missing platform data. Also make local variables static and use 'struct device *' instead of 'struct platform_device *' for global reference. Signed-off-by: Roger Quadros

[PATCH v8 05/22] mfd: omap-usb-tll: Clean up clock handling

2013-01-18 Thread Roger Quadros
Every channel has a functional clock that is similarly named. It makes sense to use a for loop to manage these clocks as OMAPs can come with up to 3 channels. Dynamically allocate and get channel clocks depending on the number of clocks avaiable on the platform. Signed-off-by: Roger Quadros Revi

[PATCH v8 03/22] mfd: omap-usb-tll: Fix channel count detection

2013-01-18 Thread Roger Quadros
Fix channel count detecion for REV2. Also, don't give up if we don't recognize the IP Revision. We assume the default number of channels (i.e. 3) for unrecognized IPs. Signed-off-by: Roger Quadros Reviewed-by: Felipe Balbi --- drivers/mfd/omap-usb-tll.c | 20 +++- 1 files chan

[PATCH v8 04/22] mfd: omap-usb-tll: Use devm_kzalloc/ioremap and clean up error path

2013-01-18 Thread Roger Quadros
Use devm_ variants of kzalloc() and ioremap(). Simplify the error path. Signed-off-by: Roger Quadros Reviewed-by: Felipe Balbi --- drivers/mfd/omap-usb-tll.c | 38 -- 1 files changed, 12 insertions(+), 26 deletions(-) diff --git a/drivers/mfd/omap-usb-tll.

[PATCH v8 00/22] OMAP USB Host cleanup

2013-01-18 Thread Roger Quadros
Hi, This patchset addresses the following - Consolidate USB Host platform data. - Avoid addressing clocks one by one by name and use a for loop + bunch of cleanups. - Get number of channels/ports dynamically either from revision register or from platform data. Avoids getting clocks that are n

Re: [PATCH v8 01/22] USB: ehci-omap: Don't free gpios that we didn't request

2013-01-18 Thread Roger Quadros
On 01/18/2013 02:17 PM, Roger Quadros wrote: > This driver does not request any gpios so don't free them. > Fixes L3 bus error on multiple modprobe/rmmod of ehci_hcd > with ehci-omap in use. > > Without this patch, EHCI will break on repeated insmod/rmmod > of ehci_hcd for all OMAP2+ platforms tha

[PATCH v8 01/22] USB: ehci-omap: Don't free gpios that we didn't request

2013-01-18 Thread Roger Quadros
This driver does not request any gpios so don't free them. Fixes L3 bus error on multiple modprobe/rmmod of ehci_hcd with ehci-omap in use. Without this patch, EHCI will break on repeated insmod/rmmod of ehci_hcd for all OMAP2+ platforms that use EHCI and set 'phy_reset = true' in usbhs_omap_board

Re: usb3.0 device recognized as usb2.1

2013-01-18 Thread Richard Genoud
2013/1/18 Oliver Neukum : > The question is, what goes wrong, if indeed the device is SS. > > In this particular case a usbmon trace is likely not as useful as usually. > Could you compile a kernel with DEBUG for USB and XHCI enabled? no problem, I'll do that tomorrow (not at home until then). Th

Re: Wake on LAN for USB ethernet?

2013-01-18 Thread Ming Lei
On Fri, Jan 18, 2013 at 4:53 PM, Petko Manolov wrote: > The code in the driver is based on the specs from ADMTek (later, Infineon). > Since i never suspend my machines this feature has not been tested by me. > > However, if the proposed patch is the right thing to do i'd be happy to see > it appli

Re: [PATCH 0/2] ARM: Exynos5250: Enabling samsung usb phy

2013-01-18 Thread Felipe Balbi
Hi, On Tue, Dec 18, 2012 at 09:09:40PM +0530, Vivek Gautam wrote: > This patch-set enables the samsung-usbphy driver on exynos5250, > which enables the support for USB2 type and USB3 type phys. > The corresponding phy driver patches are available at: > 1) https://lkml.org/lkml/2012/12/18/201 > 2

Re: [PATCH 0/2] ARM: Exynos5250: Enabling samsung usb phy

2013-01-18 Thread Felipe Balbi
On Fri, Jan 18, 2013 at 03:10:13PM +0200, Felipe Balbi wrote: > Hi, > > On Tue, Dec 18, 2012 at 09:09:40PM +0530, Vivek Gautam wrote: > > This patch-set enables the samsung-usbphy driver on exynos5250, > > which enables the support for USB2 type and USB3 type phys. > > The corresponding phy driver

Re: [PATCH v6 3/4] USB: ehci-s5p: Add phy driver support

2013-01-18 Thread Felipe Balbi
On Fri, Jan 11, 2013 at 08:32:29PM +0530, Vivek Gautam wrote: > Adding the phy driver to ehci-s5p. Keeping the platform data > for continuing the smooth operation for boards which still uses it > > Signed-off-by: Vivek Gautam > Acked-by: Jingoo Han Missing Alan's Acked-by here. -- balbi sig

Re: [PATCH v7 2/4] usb: phy: samsung: Add host phy support to samsung-phy driver

2013-01-18 Thread Felipe Balbi
Hi, On Mon, Jan 14, 2013 at 05:52:15PM +0530, Vivek Gautam wrote: > This patch adds host phy support to samsung-usbphy driver and > further adds support for samsung's exynos5250 usb-phy. > > Signed-off-by: Praveen Paneri > Signed-off-by: Vivek Gautam Missing Kukjim's Acked-by here -- balbi

Re: ehci-hcd compile error

2013-01-18 Thread Roger Quadros
On 01/17/2013 06:10 PM, Alan Stern wrote: > On Thu, 17 Jan 2013, Roger Quadros wrote: > >> Alan, >> >> What tree is your patch based off? > > Roughly speaking, 3.7 plus Greg KH's usb-next branch as of the 3.7 > release. This should be pretty much the same as 3.8-rc1 as far as the > USB stack is

Re: [PATCH v7 2/4] usb: phy: samsung: Add host phy support to samsung-phy driver

2013-01-18 Thread Vivek Gautam
Hi Felipe, On Fri, Jan 18, 2013 at 6:46 PM, Felipe Balbi wrote: > Hi, > > On Mon, Jan 14, 2013 at 05:52:15PM +0530, Vivek Gautam wrote: >> This patch adds host phy support to samsung-usbphy driver and >> further adds support for samsung's exynos5250 usb-phy. >> >> Signed-off-by: Praveen Paneri

Re: [PATCH v7 2/4] usb: phy: samsung: Add host phy support to samsung-phy driver

2013-01-18 Thread Felipe Balbi
On Fri, Jan 18, 2013 at 07:51:08PM +0530, Vivek Gautam wrote: > Hi Felipe, > > > On Fri, Jan 18, 2013 at 6:46 PM, Felipe Balbi wrote: > > Hi, > > > > On Mon, Jan 14, 2013 at 05:52:15PM +0530, Vivek Gautam wrote: > >> This patch adds host phy support to samsung-usbphy driver and > >> further adds

[PATCH v10] usb_8dev: Add support for USB2CAN interface from 8 devices

2013-01-18 Thread Bernd Krumboeck
Add device driver for USB2CAN interface from "8 devices" (http://www.8devices.com). changes since v9: * fixed syslog messages * fixed crc error number * increased MAX_RX_URBS and MAX_TX_URBS changes since v8: * remove all sysfs files changes since v7: * add sysfs documentation * fix minor styli

[PATCH net] net: cdc_ncm: workaround for missing CDC Union

2013-01-18 Thread Bjørn Mork
Adding support for the MBIM mode in some Sierra Wireless devices. Some Sierra Wireless firmwares support CDC MBIM but have no CDC Union funtional descriptor. This violates the MBIM specification, but we can easily work around the bug by looking at the Interface Association Descriptor instead. Thi

[PATCH net] net: qmi_wwan: add ONDA MT8205 4G LTE

2013-01-18 Thread Bjørn Mork
The driver description files gives these names to the vendor specific functions on this modem: Diag VID_19D2&PID_0265&MI_00 NMEA VID_19D2&PID_0265&MI_01 AT cmd VID_19D2&PID_0265&MI_02 Modem VID_19D2&PID_0265&MI_03 NetVID_19D2&PID_0265&MI_04 Signed-off-by: Bjørn Mork --- drivers/ne

Re: [PATCH v7 2/4] usb: phy: samsung: Add host phy support to samsung-phy driver

2013-01-18 Thread Vivek Gautam
HI Balbi, On Fri, Jan 18, 2013 at 7:52 PM, Felipe Balbi wrote: > On Fri, Jan 18, 2013 at 07:51:08PM +0530, Vivek Gautam wrote: >> Hi Felipe, >> >> >> On Fri, Jan 18, 2013 at 6:46 PM, Felipe Balbi wrote: >> > Hi, >> > >> > On Mon, Jan 14, 2013 at 05:52:15PM +0530, Vivek Gautam wrote: >> >> This

Re: [PATCH v6 3/4] USB: ehci-s5p: Add phy driver support

2013-01-18 Thread Vivek Gautam
Hi Alan, On Fri, Jan 18, 2013 at 6:46 PM, Felipe Balbi wrote: > On Fri, Jan 11, 2013 at 08:32:29PM +0530, Vivek Gautam wrote: >> Adding the phy driver to ehci-s5p. Keeping the platform data >> for continuing the smooth operation for boards which still uses it >> >> Signed-off-by: Vivek Gautam >

Re: [PATCH v9] usb_8dev: Add support for USB2CAN interface from 8 devices

2013-01-18 Thread Bernd Krumböck
> On 16.01.2013 09:07, "Bernd Krumböck" wrote: > >> Hi Oliver! >> >>> When detaching the device from the CAN bus when sending/receiving CAN traffic >>> i got these dmesg infos: >>> >>> [ 960.047130] usb_8dev 2-1.4:1.0 can2: Unknown status/error message (0) >>> [ 976.544343] usb_8dev 2-1.4:1.0 can

Re: [PATCH v8 05/22] mfd: omap-usb-tll: Clean up clock handling

2013-01-18 Thread Russell King - ARM Linux
On Fri, Jan 18, 2013 at 02:17:08PM +0200, Roger Quadros wrote: > + tll->ch_clk = devm_kzalloc(dev, sizeof(struct clk * [tll->nch]), > + GFP_KERNEL); > + if (!tll->ch_clk) { > + ret = -ENOMEM; > + dev_err(dev, "Couldn't allo

Re: [PATCH v8 06/22] mfd: omap-usb-tll: introduce and use mode_needs_tll()

2013-01-18 Thread Russell King - ARM Linux
On Fri, Jan 18, 2013 at 02:17:09PM +0200, Roger Quadros wrote: > +/* only PHY and UNUSED modes don't need TLL */ > +#define omap_usb_mode_needs_tll(x) ((x != OMAP_USBHS_PORT_MODE_UNUSED) &&\ > + (x != OMAP_EHCI_PORT_MODE_PHY)) Growl. These parens do not make

Re: [PATCH v8 05/22] mfd: omap-usb-tll: Clean up clock handling

2013-01-18 Thread Roger Quadros
On 01/18/2013 04:59 PM, Russell King - ARM Linux wrote: > On Fri, Jan 18, 2013 at 02:17:08PM +0200, Roger Quadros wrote: >> +tll->ch_clk = devm_kzalloc(dev, sizeof(struct clk * [tll->nch]), >> +GFP_KERNEL); >> +if (!tll->ch_clk) { >> +

Re: [PATCH v7 2/4] usb: phy: samsung: Add host phy support to samsung-phy driver

2013-01-18 Thread Felipe Balbi
On Fri, Jan 18, 2013 at 07:59:52PM +0530, Vivek Gautam wrote: > HI Balbi, > > > On Fri, Jan 18, 2013 at 7:52 PM, Felipe Balbi wrote: > > On Fri, Jan 18, 2013 at 07:51:08PM +0530, Vivek Gautam wrote: > >> Hi Felipe, > >> > >> > >> On Fri, Jan 18, 2013 at 6:46 PM, Felipe Balbi wrote: > >> > Hi, >

Re: [PATCH v8 06/22] mfd: omap-usb-tll: introduce and use mode_needs_tll()

2013-01-18 Thread Roger Quadros
On 01/18/2013 05:02 PM, Russell King - ARM Linux wrote: > On Fri, Jan 18, 2013 at 02:17:09PM +0200, Roger Quadros wrote: >> +/* only PHY and UNUSED modes don't need TLL */ >> +#define omap_usb_mode_needs_tll(x) ((x != OMAP_USBHS_PORT_MODE_UNUSED) &&\ >> + (x !=

Re: [PATCH v3 4/4] usb: Add APIs to access host registers from Tegra PHY

2013-01-18 Thread Alan Stern
On Fri, 18 Jan 2013, Venu Byravarasu wrote: > As Tegra PHY driver needs to access one of the Host registers, > added few APIs. > > Signed-off-by: Venu Byravarasu > --- > delta from v2: > Renamed USB_PORTSC1 to TEGRA_USB_PORTSC1. > Removed tegra_ehci_set_wakeon_events() and its references. > Used

Re: [PATCH v6 3/4] USB: ehci-s5p: Add phy driver support

2013-01-18 Thread Alan Stern
On Fri, 11 Jan 2013, Vivek Gautam wrote: > Adding the phy driver to ehci-s5p. Keeping the platform data > for continuing the smooth operation for boards which still uses it > > Signed-off-by: Vivek Gautam > Acked-by: Jingoo Han Acked-by: Alan Stern -- To unsubscribe from this list: send the

Re: [PATCH v6 4/4] USB: ohci-exynos: Add phy driver support

2013-01-18 Thread Alan Stern
On Fri, 11 Jan 2013, Vivek Gautam wrote: > Adding the phy-driver to ohci-exynos. Keeping the platform data > for continuing the smooth operation for boards which still uses it > > Signed-off-by: Vivek Gautam > Acked-by: Jingoo Han Acked-by: Alan Stern -- To unsubscribe from this list: send t

Re: [PATCH v6 3/4] USB: ehci-s5p: Add phy driver support

2013-01-18 Thread Alan Stern
On Fri, 18 Jan 2013, Vivek Gautam wrote: > Hi Alan, > > > On Fri, Jan 18, 2013 at 6:46 PM, Felipe Balbi wrote: > > On Fri, Jan 11, 2013 at 08:32:29PM +0530, Vivek Gautam wrote: > >> Adding the phy driver to ehci-s5p. Keeping the platform data > >> for continuing the smooth operation for boards

[Rebase PATCH] usb: Using correct way to clear usb3.0 device's remote wakeup feature.

2013-01-18 Thread Lan Tianyu
Usb3.0 device defines function remote wakeup which is only for interface recipient rather than device recipient. This is different with usb2.0 device's remote wakeup feature which is defined for device recipient. According usb3.0 spec 9.4.5, the function remote wakeup can be modified by the SetFeat

Re: [Resend PATCH V4 0/10] usb: usb port power off mechanism anc expose usb port connect type

2013-01-18 Thread Alan Stern
On Fri, 18 Jan 2013, Lan Tianyu wrote: > > By the way, have you checked whether the auto-power-off mechanism works > > correctly when you do a system suspend? > > > Thanks for reminder. I test this today and find an issue. If usb device > was powered off during runtime, pm_runtime_get_sync() in

Re: "config x has an invalid interface number: y but max is z"

2013-01-18 Thread Alan Stern
On Thu, 17 Jan 2013, Bjørn Mork wrote: > Peter Stuge writes: > > Alan Stern wrote: > >> > Is this useful to anyone? > >> > >> In theory it would be useful to somebody developing firmware for a USB > >> device. If only such people would test their firmwares under Linux... > > > > Some do. Maybe

Re: "config x has an invalid interface number: y but max is z"

2013-01-18 Thread Peter Stuge
Alan Stern wrote: > > >> > Should we just drop those warnings? > > >> > > >> No opinion. > > > > > > I think they should stay. > > > > OK, but how about demoting them to debug messages instead of warnings? > > If you want to make that change, I don't mind. I prefer that they stay visible by def

[PATCH v2 1/3] usb: add find_raw_port_number callback to struct hc_driver()

2013-01-18 Thread Lan Tianyu
xhci driver divides the root hub into two logical hubs which work respectively for usb 2.0 and usb 3.0 devices. They are independent devices in the usb core. But in the ACPI table, it's one device node and all usb2.0 and usb3.0 ports are under it. Binding usb port with its acpi node needs the raw p

[PATCH v2 2/3] usb/acpi: binding xhci root hub usb port with ACPI

2013-01-18 Thread Lan Tianyu
This patch is to bind xhci root hub usb port with its acpi node. The port num in the acpi table matches with the sequence in the xhci extended capabilities table. So call usb_hcd_find_raw_port_number() to transfer hub port num into raw port number which associates with the sequence in the xhci exte

[PATCH v2 3/3] usb/xhci: refactor xhci_find_real_port_number()

2013-01-18 Thread Lan Tianyu
This patch is to optimize xhci_find_realport_number(). Call xhci_find_raw_port_number() to get real index in the HW port status registers instead of scanning through the xHCI roothub port array. Signed-off-by: Lan Tianyu --- drivers/usb/host/xhci-mem.c | 36

Re: [PATCH 3/4] USB: PHY: Tegra: Get rid of instance number to differentiate PHY type

2013-01-18 Thread Stephen Warren
On 01/16/2013 06:30 AM, Venu Byravarasu wrote: > Tegra20 USB has 3 PHY instances: > Instance 1 and 3 are UTMI. Instance 2 is ULPI. > > As instance number was used to differentiate ULPI from UTMI, > used DT param to get this info and processed accordingly. > diff --git a/include/linux/usb/tegra_us

[GIT PULL] USB: fixes for v3.8-rc5

2013-01-18 Thread Felipe Balbi
Hi Greg, Here are my latest fixes for this -rc cycle. Unless something extremely important shows up, we should be ready for a final v3.8 ;-) Hopefully no surprises will come. ps: You will notice a few changes on arch/arm/mach-imx/ but they're needed to make fsl build and work again. We _do_ have

Re: [PATCH 3/4] USB: PHY: Tegra: Get rid of instance number to differentiate PHY type

2013-01-18 Thread Stephen Warren
On 01/18/2013 10:04 AM, Stephen Warren wrote: > On 01/16/2013 06:30 AM, Venu Byravarasu wrote: >> Tegra20 USB has 3 PHY instances: >> Instance 1 and 3 are UTMI. Instance 2 is ULPI. >> >> As instance number was used to differentiate ULPI from UTMI, >> used DT param to get this info and processed acc

Re: [PATCH v3 4/4] usb: Add APIs to access host registers from Tegra PHY

2013-01-18 Thread Stephen Warren
On 01/18/2013 08:30 AM, Alan Stern wrote: > On Fri, 18 Jan 2013, Venu Byravarasu wrote: > >> As Tegra PHY driver needs to access one of the Host registers, >> added few APIs. >> >> Signed-off-by: Venu Byravarasu >> --- >> delta from v2: >> Renamed USB_PORTSC1 to TEGRA_USB_PORTSC1. >> Removed tegr

  1   2   >