On 01/18/2013 05:02 PM, Russell King - ARM Linux wrote: > On Fri, Jan 18, 2013 at 02:17:09PM +0200, Roger Quadros wrote: >> +/* only PHY and UNUSED modes don't need TLL */ >> +#define omap_usb_mode_needs_tll(x) ((x != OMAP_USBHS_PORT_MODE_UNUSED) &&\ >> + (x != OMAP_EHCI_PORT_MODE_PHY)) > > Growl. > > These parens do not make anything safer at all - they just obfuscate. The > safe version of the above macro would have been: > > #define omap_usb_mode_needs_tll(x) ((x) != OMAP_USBHS_PORT_MODE_UNUSED &&\ > (x) != OMAP_EHCI_PORT_MODE_PHY) > > If you're going to use a macro argument in an expression, it needs parens. > Simple expressions like a != b && c != d do _not_ need parens. >
Yikes, that was brain dead stuff from me ;). Will fix. cheers, -roger -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
