[PATCH v2 4/4] usb: Add APIs to access host registers from Tegra PHY

2013-01-17 Thread Venu Byravarasu
As Tegra PHY driver need to access one of the Host registers, added few APIs to ehci tegra driver. Signed-off-by: Venu Byravarasu --- delta from v1: Taken care of RWC bits, while accessing PORTSC register. drivers/usb/host/ehci-tegra.c | 70 - drivers/u

Re: [PATCH v2 4/4] usb: Add APIs to access host registers from Tegra PHY

2013-01-17 Thread Felipe Balbi
Hi, On Thu, Jan 17, 2013 at 01:58:12PM +0530, Venu Byravarasu wrote: > As Tegra PHY driver need to access one of the Host registers, > added few APIs to ehci tegra driver. > > Signed-off-by: Venu Byravarasu Stephen is this another of those patches you're gonna take care of yourself ? > --- > d

Re: [V3 PATCH 11/25] arm: mmp2: change the defintion of usb devices

2013-01-17 Thread Felipe Balbi
On Tue, Jan 15, 2013 at 01:19:04AM -0500, Chao Xie wrote: > add the udc/otg/ehci devices for mmp2 > > Signed-off-by: Chao Xie Haojian, can I get an Acked-by for this patch or will you carry it yourself ? Likewise for all other arch/arm/* patches in this series -- balbi signature.asc Descrip

Re: [PATCH v6 03/22] mfd: omap-usb-tll: Use devm_kzalloc/ioremap and clean up error path

2013-01-17 Thread Roger Quadros
On 01/16/2013 09:37 PM, Sergei Shtylyov wrote: > Hello. > > On 01/16/2013 05:43 PM, Roger Quadros wrote: > >> Use devm_ variants of kzalloc() and ioremap(). Simplify the error path. > >> Signed-off-by: Roger Quadros >> --- >> drivers/mfd/omap-usb-tll.c | 36 +++---

Re: [PATCH v5 1/3] usb: fsl-mxc-udc: replace cpu_is_xxx() with platform_device_id

2013-01-17 Thread Felipe Balbi
On Wed, Jan 16, 2013 at 09:48:25AM +0800, Peter Chen wrote: > On Tue, Jan 15, 2013 at 10:03:46PM +0800, Shawn Guo wrote: > > On Tue, Jan 15, 2013 at 10:29:33AM +0800, Peter Chen wrote: > > > As mach/hardware.h is deleted, we need to use platform_device_id to > > > differentiate SoCs. Besides, one c

Re: [PATCH v5 1/3] usb: fsl-mxc-udc: replace cpu_is_xxx() with platform_device_id

2013-01-17 Thread Peter Chen
On Thu, Jan 17, 2013 at 11:14:22AM +0200, Felipe Balbi wrote: > On Wed, Jan 16, 2013 at 09:48:25AM +0800, Peter Chen wrote: > > On Tue, Jan 15, 2013 at 10:03:46PM +0800, Shawn Guo wrote: > > > On Tue, Jan 15, 2013 at 10:29:33AM +0800, Peter Chen wrote: > > > > As mach/hardware.h is deleted, we need

Re: [PATCH v5 1/3] usb: fsl-mxc-udc: replace cpu_is_xxx() with platform_device_id

2013-01-17 Thread Felipe Balbi
Hi, On Thu, Jan 17, 2013 at 05:28:30PM +0800, Peter Chen wrote: > > > > From what I understand balbi's comment, he dislikes this full list of > > > > device id. Instead, he prefers to something like below. > > > > > > > > static const struct platform_device_id fsl_udc_devtype[] = { > > > >

[PATCH, resubmit] ax88179_178a: ASIX AX88179_178A USB 3.0/2.0 to gigabit ethernet adapter driver

2013-01-17 Thread Freddy Xin
This is a resubmission. The _nopm version usb functions were added to access register in suspend and resume functions. Serveral variables allocted dynamically were removed and replaced by stack variables. ax88179_get_eeprom were modified from asix_get_eeprom in asix_common. This patch adds a dr

Re: [RFC PATCH 1/6] usb: otg: Add an API to bind the USB controller and PHY

2013-01-17 Thread Roger Quadros
On 01/16/2013 05:00 PM, Kishon Vijay Abraham I wrote: > New platforms are added which has multiple PHY's (of same type) and > which has multiple USB controllers. The binding information has to be > present in the PHY library (otg.c) in order for it to return the > appropriate PHY whenever the USB c

Re: [RFC PATCH 2/6] ARM: OMAP: USB: Add phy binding information

2013-01-17 Thread Roger Quadros
On 01/16/2013 05:00 PM, Kishon Vijay Abraham I wrote: > This is in preparation for the changes in PHY library to support adding > and getting multiple PHYs of the same type. In the new design, the > binding information between the PHY and the USB controller should be > specified in the platform spe

Re: [PATCH v7 0/6] solve deadlock caused by memory allocation with I/O

2013-01-17 Thread Oliver Neukum
On Thursday 17 January 2013 09:28:14 Ming Lei wrote: > - we still need some synchronization to avoid accessing the storage >between sys_sync and device suspend, just like system sleep case, >pm_restrict_gfp_mask is needed even sys_sync has been done >inside enter_state(

Re: [V3 PATCH 11/25] arm: mmp2: change the defintion of usb devices

2013-01-17 Thread Haojian Zhuang
On Thu, Jan 17, 2013 at 5:12 PM, Felipe Balbi wrote: > On Tue, Jan 15, 2013 at 01:19:04AM -0500, Chao Xie wrote: >> add the udc/otg/ehci devices for mmp2 >> >> Signed-off-by: Chao Xie > > Haojian, can I get an Acked-by for this patch or will you carry it > yourself ? > > Likewise for all other ar

[PATCH v6 0/3] *** SUBJECT HERE ***

2013-01-17 Thread Peter Chen
Changes for v6: - Only using imx-udc-mx27 and imx-udc-mx51 stands for all kinds of i.mx udc - Fix below build error for platform_device_id at fsl_udc_core.c drivers/usb/gadget/fsl_usb2_udc: struct platform_device_id is 24 bytes.? The last of 5 is: | 0x69 0x6d 0x78 0x2d 0x75 0x64 0x63 0x2d 0x6d 0x7

[PATCH v6 1/3] usb: fsl-mxc-udc: replace cpu_is_xxx() with platform_device_id

2013-01-17 Thread Peter Chen
As mach/hardware.h is deleted, we need to use platform_device_id to differentiate SoCs. Besides, one cpu_is_mx35 is useless as it has already used pdata to differentiate runtime Meanwhile we update the platform code accordingly. Signed-off-by: Peter Chen --- arch/arm/mach-imx/devices/devices-co

[PATCH v6 3/3] ARM: i.MX clock: Change the connection-id for fsl-usb2-udc

2013-01-17 Thread Peter Chen
As we use platform_device_id for fsl-usb2-udc driver, it needs to change clk connection-id, or the related devm_clk_get will be failed. Signed-off-by: Peter Chen --- arch/arm/mach-imx/clk-imx25.c |6 +++--- arch/arm/mach-imx/clk-imx27.c |6 +++--- arch/arm/mach-imx/clk-imx31.

[PATCH v6 2/3] usb: fsl_mxc_udc: replace MX35_IO_ADDRESS to ioremap

2013-01-17 Thread Peter Chen
As mach/hardware.h is deleted, we can't visit platform code at driver. It has no phy driver to combine with this controller, so it has to use ioremap to map phy address as a workaround. Signed-off-by: Peter Chen --- drivers/usb/gadget/fsl_mxc_udc.c | 30 +++--- drivers

[PATCH v6 0/3] Fix the Build error for fsl_mxc_udc.c

2013-01-17 Thread Peter Chen
Changes for v6: - Only using imx-udc-mx27 and imx-udc-mx51 stands for all kinds of i.mx udc - Fix below build error for platform_device_id at fsl_udc_core.c drivers/usb/gadget/fsl_usb2_udc: struct platform_device_id is 24 bytes.? The last of 5 is: | 0x69 0x6d 0x78 0x2d 0x75 0x64 0x63 0x2d 0x6d 0x7

[PATCH v6 2/3] usb: fsl_mxc_udc: replace MX35_IO_ADDRESS to ioremap

2013-01-17 Thread Peter Chen
As mach/hardware.h is deleted, we can't visit platform code at driver. It has no phy driver to combine with this controller, so it has to use ioremap to map phy address as a workaround. Signed-off-by: Peter Chen --- drivers/usb/gadget/fsl_mxc_udc.c | 30 +++--- drivers

[PATCH v6 1/3] usb: fsl-mxc-udc: replace cpu_is_xxx() with platform_device_id

2013-01-17 Thread Peter Chen
As mach/hardware.h is deleted, we need to use platform_device_id to differentiate SoCs. Besides, one cpu_is_mx35 is useless as it has already used pdata to differentiate runtime Meanwhile we update the platform code accordingly. Signed-off-by: Peter Chen --- arch/arm/mach-imx/devices/devices-co

[PATCH v6 3/3] ARM: i.MX clock: Change the connection-id for fsl-usb2-udc

2013-01-17 Thread Peter Chen
As we use platform_device_id for fsl-usb2-udc driver, it needs to change clk connection-id, or the related devm_clk_get will be failed. Signed-off-by: Peter Chen --- arch/arm/mach-imx/clk-imx25.c |6 +++--- arch/arm/mach-imx/clk-imx27.c |6 +++--- arch/arm/mach-imx/clk-imx31.

Re: [PATCH v6 03/22] mfd: omap-usb-tll: Use devm_kzalloc/ioremap and clean up error path

2013-01-17 Thread Roger Quadros
On 01/17/2013 11:12 AM, Roger Quadros wrote: > On 01/16/2013 09:37 PM, Sergei Shtylyov wrote: >> Hello. >> >> On 01/16/2013 05:43 PM, Roger Quadros wrote: >> >>> Use devm_ variants of kzalloc() and ioremap(). Simplify the error path. >> >>> Signed-off-by: Roger Quadros >>> --- >>> drivers/mfd/oma

Re: [PATCH] usb: musb: ux500: use clk_prepare_enable and clk_disable_unprepare

2013-01-17 Thread Linus Walleij
On Thu, Jan 10, 2013 at 2:38 PM, Fabio Baltieri wrote: > On Thu, Jan 10, 2013 at 12:23:32PM +0100, Linus Walleij wrote: >> On Mon, Jan 7, 2013 at 5:47 PM, Fabio Baltieri >> wrote: >> >> > This patch converts the module to use clk_prepare_enable and >> > clk_disable_unprepare variants as required

Re: [PATCH] usb: musb: ux500: use clk_prepare_enable and clk_disable_unprepare

2013-01-17 Thread Felipe Balbi
On Thu, Jan 17, 2013 at 11:46:30AM +0100, Linus Walleij wrote: > On Thu, Jan 10, 2013 at 2:38 PM, Fabio Baltieri > wrote: > > On Thu, Jan 10, 2013 at 12:23:32PM +0100, Linus Walleij wrote: > >> On Mon, Jan 7, 2013 at 5:47 PM, Fabio Baltieri > >> wrote: > >> > >> > This patch converts the module t

[PATCH V3 1/5] usb: gadget/uvc: Fix VS_INPUT_HEADER.bEndpointAddress and Video Streaming.bEndpointAddress values

2013-01-17 Thread Bhupesh Sharma
This patch corrects the VS_INPUT_HEADER.bEndpointAddress and Video Streaming.bEndpointAddress values which were incorrectly set to 0 in UVC function driver. As 'usb_ep_autoconfig' function returns an un-claimed usb_ep, and modifies the endpoint descriptor's bEndpointAddress, so there is no need to

[PATCH V3 0/5] UVC webcam gadget related changes

2013-01-17 Thread Bhupesh Sharma
This patchset tries to enhance the UVC webcam gadget driver and is based on Laurent's git tree available here (head uvc-gadget): git://linuxtv.org/pinchartl/uvcvideo.git Note that to ease review and integration of these patches, I have rebased them on Laurent's repo and all the relevant patches af

[PATCH V3 2/5] usb: gadget/uvc: Make video streaming buffer size compliant to USB3.0 SS specs

2013-01-17 Thread Bhupesh Sharma
As per the USB3.0 specs, the bandwidth requirements of a UVC's video streaming endpoint will change to support super-speed. These changes will be dependent on whether the UVC video streaming endpoint is Bulk or Isochronous: - If video streaming endpoint is Isochronous: As per Section 4.4.8.2 (Is

[PATCH V3 4/5] usb: gadget/uvc: Add support for 'USB_GADGET_DELAYED_STATUS' response for a set_intf(alt-set 1) command

2013-01-17 Thread Bhupesh Sharma
This patch adds the support in UVC webcam gadget design for providing USB_GADGET_DELAYED_STATUS in response to a set_interface(alt setting 1) command issue by the Host. The current UVC webcam gadget design generates a STREAMON event corresponding to a set_interface(alt setting 1) command from the

[PATCH] usb/dwc3: fix ep->maxburst for ep0

2013-01-17 Thread Pratyush Anand
dwc3_gadget_set_ep_config expects maxburst as incremented by 1. So, by default initialize ep->maxburst to 0 for ep0. Signed-off-by: Pratyush Anand --- drivers/usb/dwc3/gadget.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/g

[PATCH V3 5/5] usb: gadget/uvc: Add support for 'get_unmapped_area' for MMUless architectures

2013-01-17 Thread Bhupesh Sharma
This patch adds the support for 'get_unmapped_area' in UVC gadget which is called when the 'mmap' system call is executed on MMUless architectures. Signed-off-by: Bhupesh Sharma --- drivers/usb/gadget/uvc_queue.c | 18 ++ drivers/usb/gadget/uvc_queue.h |5 + drivers/usb

[PATCH V3 3/5] usb: gadget/uvc: Port UVC webcam gadget to use videobuf2 framework

2013-01-17 Thread Bhupesh Sharma
This patch reworks the videobuffer management logic present in the UVC webcam gadget and ports it to use the "more apt" videobuf2 framework for video buffer management. To support routing video data captured from a real V4L2 video capture device with a "zero copy" operation on videobuffers (as the

Re: [PATCH] usb/dwc3: fix ep->maxburst for ep0

2013-01-17 Thread Felipe Balbi
On Thu, Jan 17, 2013 at 04:14:38PM +0530, Pratyush Anand wrote: > dwc3_gadget_set_ep_config expects maxburst as incremented by 1. So, by > default initialize ep->maxburst to 0 for ep0. to 0 or to 1 ? -- balbi signature.asc Description: Digital signature

Re: [PATCH v6 3/3] ARM: i.MX clock: Change the connection-id for fsl-usb2-udc

2013-01-17 Thread Felipe Balbi
On Thu, Jan 17, 2013 at 06:03:17PM +0800, Peter Chen wrote: > As we use platform_device_id for fsl-usb2-udc driver, it needs to > change clk connection-id, or the related devm_clk_get will be failed. > > Signed-off-by: Peter Chen do I get Acked-by for this one ? -- balbi signature.asc Descri

Re: [usb:usb-next 4/10] drivers/usb/misc/usb3503.c:238 usb3503_probe() error: we previously assumed 'pdata' could be null (see line 196)

2013-01-17 Thread Dongjin Kim
Hello Greg, Could you review my patch to fix the warning this? My patch is sent and registered as https://patchwork.kernel.org/patch/1969001 Thank you in advance. Dongjin. On Sat, Jan 12, 2013 at 12:01 PM, Fengguang Wu wrote: > Dongjin, > >> Do I need to send another patch on top of it to fix t

Re: [V3 PATCH 11/25] arm: mmp2: change the defintion of usb devices

2013-01-17 Thread Felipe Balbi
Hi, On Thu, Jan 17, 2013 at 05:59:20PM +0800, Haojian Zhuang wrote: > On Thu, Jan 17, 2013 at 5:12 PM, Felipe Balbi wrote: > > On Tue, Jan 15, 2013 at 01:19:04AM -0500, Chao Xie wrote: > >> add the udc/otg/ehci devices for mmp2 > >> > >> Signed-off-by: Chao Xie > > > > Haojian, can I get an Acke

Re: [PATCH v6 3/3] ARM: i.MX clock: Change the connection-id for fsl-usb2-udc

2013-01-17 Thread Shawn Guo
On Thu, Jan 17, 2013 at 12:58:33PM +0200, Felipe Balbi wrote: > On Thu, Jan 17, 2013 at 06:03:17PM +0800, Peter Chen wrote: > > As we use platform_device_id for fsl-usb2-udc driver, it needs to > > change clk connection-id, or the related devm_clk_get will be failed. > > > > Signed-off-by: Peter C

Re: [RFC PATCH 2/6] ARM: OMAP: USB: Add phy binding information

2013-01-17 Thread kishon
Hi, On Thursday 17 January 2013 03:09 PM, Roger Quadros wrote: On 01/16/2013 05:00 PM, Kishon Vijay Abraham I wrote: This is in preparation for the changes in PHY library to support adding and getting multiple PHYs of the same type. In the new design, the binding information between the PHY and

Re: [PATCH] usb/dwc3: fix ep->maxburst for ep0

2013-01-17 Thread Pratyush Anand
Hi Felip, On 1/17/2013 4:14 PM, Pratyush ANAND wrote: dwc3_gadget_set_ep_config expects maxburst as incremented by 1. So, by default initialize ep->maxburst to 0 for ep0. Although , this patch fixes issue of maxburst for default control endpoint. But, I could not understand purpose of follow

Re: [PATCH] usb/dwc3: fix ep->maxburst for ep0

2013-01-17 Thread Pratyush Anand
On 1/17/2013 4:27 PM, Felipe Balbi wrote: On Thu, Jan 17, 2013 at 04:14:38PM +0530, Pratyush Anand wrote: dwc3_gadget_set_ep_config expects maxburst as incremented by 1. So, by default initialize ep->maxburst to 0 for ep0. to 0 or to 1 ? ohh..yes to 1 ;) But do we really need it..or we sho

RE: [PATCH 0/6] UVC gadget cleanup

2013-01-17 Thread Bhupesh SHARMA
Hi Laurent, > > H Laurent, > > > Hi Felipe, > > > > On Tuesday 23 October 2012 16:52:31 Felipe Balbi wrote: > > > On Tue, Oct 23, 2012 at 09:50:10PM +0800, Bhupesh SHARMA wrote: > > > > On Tuesday, October 23, 2012 6:31 PM Laurent Pinchart wrote: > > > > > On Wednesday 01 August 2012 14:57:09 La

Re: [RFC PATCH 1/6] usb: otg: Add an API to bind the USB controller and PHY

2013-01-17 Thread kishon
Hi, On Thursday 17 January 2013 03:07 PM, Roger Quadros wrote: On 01/16/2013 05:00 PM, Kishon Vijay Abraham I wrote: New platforms are added which has multiple PHY's (of same type) and which has multiple USB controllers. The binding information has to be present in the PHY library (otg.c) in or

Re: [PATCH 17/30] usb/gadget: nokia: use function framework for ACM

2013-01-17 Thread Felipe Balbi
On Sun, Dec 23, 2012 at 09:10:11PM +0100, Sebastian Andrzej Siewior wrote: > This patch converts the acm_ms gadget to make use of the function > framework to request the ACM function. > > The "old" include interface for acm is now removed since nokia was the > last user of it (for ACM). > > Signe

Re: [PATCH 18/30] usb/gadget: move the global the_dev variable to their users

2013-01-17 Thread Felipe Balbi
On Sun, Dec 23, 2012 at 09:10:12PM +0100, Sebastian Andrzej Siewior wrote: > the u_ether.c file has a global variable named the_dev which keeps a > pointer to the network device after it has been created via > gether_setup_name(). It is only used internally by u_ether. This patches > moves the vari

Re: [PATCH v6 1/3] usb: fsl-mxc-udc: replace cpu_is_xxx() with platform_device_id

2013-01-17 Thread Lothar Waßmann
Hi, Fabio Estevam writes: > On Thu, Jan 17, 2013 at 8:01 AM, Peter Chen wrote: > > > /* make sure USB_CLK is running at 60 MHz +/- 1000 Hz */ > > - if (!cpu_is_mx51()) { > > + if (!strcmp(pdev->id_entry->name, "imx-udc-mx27")) {]] > > Shouldn't this be: > if (!strcmp(pdev->

Re: [PATCH 24/30] usb/gadget: push tty port allocation from gadget into f_acm

2013-01-17 Thread Felipe Balbi
On Sun, Dec 23, 2012 at 09:10:18PM +0100, Sebastian Andrzej Siewior wrote: > It possible to allocate the tty port number within the "instance" > structure of the function and there is no need to expose this > information within the gadget and therefore it is removed here. > This patch converts only

[PATCH v7 11/22] mfd: omap-usb-host: Use devm_kzalloc() and devm_request_and_ioremap()

2013-01-17 Thread Roger Quadros
Use devm_ variants of kzalloc and ioremap. Also clean up error path. Signed-off-by: Roger Quadros --- drivers/mfd/omap-usb-host.c | 38 +++--- 1 files changed, 11 insertions(+), 27 deletions(-) diff --git a/drivers/mfd/omap-usb-host.c b/drivers/mfd/omap-usb-hos

[PATCH v7 09/22] mfd: omap-usb-tll: Add OMAP5 revision and HSIC support

2013-01-17 Thread Roger Quadros
The TLL module on OMAP5 has 3 channels. HSIC mode requires the TLL channel to be in Transparent UTMI mode. Signed-off-by: Roger Quadros --- drivers/mfd/omap-usb-tll.c | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/drivers/mfd/omap-usb-tll.c b/drivers/mfd/o

[PATCH v7 22/22] mdf: omap-usb-host: get rid of build warning

2013-01-17 Thread Roger Quadros
Fixes the below build warning when driver is built-in. drivers/mfd/omap-usb-host.c:750:12: warning: ‘usbhs_omap_remove’ defined but not used [-Wunused-function] Signed-off-by: Roger Quadros --- drivers/mfd/omap-usb-host.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a

[PATCH v7 19/22] ARM: OMAP3: clock data: get rid of unused USB host clock aliases and dummies

2013-01-17 Thread Roger Quadros
We don't need multiple aliases for the OMAP USB host clocks and neither the dummy clocks so remove them. CC: Paul Walmsley CC: Rajendra Nayak CC: Benoit Cousson CC: Mike Turquette Signed-off-by: Roger Quadros Acked-by: Paul Walmsley --- arch/arm/mach-omap2/cclock3xxx_data.c | 11

[PATCH v7 08/22] mfd: omap-usb-tll: serialize access to TLL device

2013-01-17 Thread Roger Quadros
Get rid of the unnecessary spin_lock_irqsave/restore() as there is no interrupt handler for this driver. Instead we serialize access to tll_dev using a global spinlock. Signed-off-by: Roger Quadros --- drivers/mfd/omap-usb-tll.c | 53 ++- 1 files changed

[PATCH v7 18/22] USB: ehci-omap: Don't free gpios that we didn't request

2013-01-17 Thread Roger Quadros
This driver does not request any gpios so don't free them. Fixes L3 bus error on multiple modprobe/rmmod of ehci_hcd with ehci-omap in use. CC: Alan Stern Signed-off-by: Roger Quadros --- drivers/usb/host/ehci-omap.c |8 1 files changed, 0 insertions(+), 8 deletions(-) diff --git

[PATCH v7 07/22] mfd: omap-usb-tll: Fix error message

2013-01-17 Thread Roger Quadros
omap_enable/disable_tll() can fail if TLL device is not initialized. It could be due to multiple reasons and not only due to missing platform data. Also make local variables static and use 'struct device *' instead of 'struct platform_device *' for global reference. Signed-off-by: Roger Quadros

[PATCH v7 21/22] mfd: omap-usb-host: Don't spam console on clk_set_parent failure

2013-01-17 Thread Roger Quadros
clk_set_parent is expected to fail on OMAP3 platforms. We don't consider that as fatal so don't spam console. Signed-off-by: Roger Quadros --- drivers/mfd/omap-usb-host.c | 18 +- 1 files changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/mfd/omap-usb-host.c b/drive

RE: [PATCH] usb: musb: Double buffering issues in host mode TX

2013-01-17 Thread Supriya s KARANTH
Hi Felipe, > -Original Message- > From: Felipe Balbi [mailto:ba...@ti.com] > Subject: Re: [PATCH] usb: musb: Double buffering issues in host mode TX > > From: supriya karanth > > Whenever an URB is programmed for transfer, the TXFIFO is flushed. > > This results in valid packets of the pr

Re: [PATCH 30/30] usb/gadget: the start of the configfs interface

2013-01-17 Thread Felipe Balbi
Hi, On Sun, Dec 23, 2012 at 09:10:24PM +0100, Sebastian Andrzej Siewior wrote: > |# modprobe dummy_hcd num=2 > |# modprobe libcomposite > > |# lsmod > |Module Size Used by > |libcomposite 31648 0 > |dummy_hcd 19871 0 > > |# mkdir /sys/kernel/config/usb_

[PATCH v7 15/22] mfd: omap-usb-host: Manage HSIC clocks for HSIC mode

2013-01-17 Thread Roger Quadros
Enable the optional HSIC clocks (60MHz and 480MHz) for the ports that are configured in HSIC mode. Signed-off-by: Roger Quadros --- drivers/mfd/omap-usb-host.c | 77 +++--- 1 files changed, 71 insertions(+), 6 deletions(-) diff --git a/drivers/mfd/omap-usb-

[PATCH v7 10/22] mfd: omap_usb_host: Avoid missing platform data checks in suspend/resume

2013-01-17 Thread Roger Quadros
Get rid of the unnecessary missing platform data checks in runtime_suspend/resume. We are already checking for missing platform data in probe. Signed-off-by: Roger Quadros --- drivers/mfd/omap-usb-host.c | 10 -- 1 files changed, 0 insertions(+), 10 deletions(-) diff --git a/drivers/m

[PATCH v7 17/22] mfd: omap-usb-host: clean up omap_usbhs_init()

2013-01-17 Thread Roger Quadros
We split initializing revision 1 and revision 2 into different functions. Initialization is now done dynamically so that only the number of ports available on the system are initialized. Signed-off-by: Roger Quadros --- drivers/mfd/omap-usb-host.c | 122 +

[PATCH v7 20/22] ARM: OMAP4: clock data: get rid of unused USB host clock aliases

2013-01-17 Thread Roger Quadros
We don't need multiple aliases for the OMAP USB host clocks so remove them. CC: Paul Walmsley CC: Rajendra Nayak CC: Benoit Cousson CC: Mike Turquette Signed-off-by: Roger Quadros Acked-by: Paul Walmsley --- arch/arm/mach-omap2/cclock44xx_data.c |7 --- 1 files changed, 0 insertion

[PATCH v7 04/22] mfd: omap-usb-tll: Clean up clock handling

2013-01-17 Thread Roger Quadros
Every channel has a functional clock that is similarly named. It makes sense to use a for loop to manage these clocks as OMAPs can come with up to 3 channels. Dynamically allocate and get channel clocks depending on the number of clocks avaiable on the platform. Signed-off-by: Roger Quadros ---

[PATCH v7 06/22] mfd: omap-usb-tll: Check for missing platform data in probe

2013-01-17 Thread Roger Quadros
No need to check for missing platform data in runtime_suspend/resume as it makes more sense to do it in the probe function. Signed-off-by: Roger Quadros --- drivers/mfd/omap-usb-tll.c | 15 +-- 1 files changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/mfd/omap-usb-tll

[PATCH v7 01/22] mfd: omap-usb-host: Consolidate OMAP USB-HS platform data

2013-01-17 Thread Roger Quadros
Let's have a single platform data structure for the OMAP's High-Speed USB host subsystem instead of having 3 separate ones i.e. one for board data, one for USB Host (UHH) module and one for USB-TLL module. This makes the code much simpler and avoids creating multiple copies of platform data. CC:

[PATCH v7 16/22] mfd: omap-usb-host: Get rid of unnecessary spinlock

2013-01-17 Thread Roger Quadros
The driver does not have an interrupt handler and we don't really need a spinlock, so get rid of it. Signed-off-by: Roger Quadros --- drivers/mfd/omap-usb-host.c | 16 1 files changed, 0 insertions(+), 16 deletions(-) diff --git a/drivers/mfd/omap-usb-host.c b/drivers/mfd/oma

[PATCH v7 14/22] mfd: omap-usb-host: cleanup clock management code

2013-01-17 Thread Roger Quadros
All ports have similarly named port clocks so we can bunch them into a port data structure and use for loop to enable/disable the clocks. Dynamically allocate and get clocks based on number of ports available on the platform Signed-off-by: Roger Quadros --- drivers/mfd/omap-usb-host.c | 180 ++

[PATCH v7 00/22] OMAP USB Host cleanup

2013-01-17 Thread Roger Quadros
Hi, This patchset addresses the following - Consolidate USB Host platform data. - Avoid addressing clocks one by one by name and use a for loop + bunch of cleanups. - Get number of channels/ports dynamically either from revision register or from platform data. Avoids getting clocks that are n

[PATCH v7 02/22] mfd: omap-usb-tll: Fix channel count detection

2013-01-17 Thread Roger Quadros
Fix channel count detecion for REV2. Also, don't give up if we don't recognize the IP Revision. We assume the default number of channels (i.e. 3) for unrecognized IPs. Signed-off-by: Roger Quadros --- drivers/mfd/omap-usb-tll.c | 20 +++- 1 files changed, 11 insertions(+), 9 de

[PATCH v7 03/22] mfd: omap-usb-tll: Use devm_kzalloc/ioremap and clean up error path

2013-01-17 Thread Roger Quadros
Use devm_ variants of kzalloc() and ioremap(). Simplify the error path. Signed-off-by: Roger Quadros --- drivers/mfd/omap-usb-tll.c | 38 -- 1 files changed, 12 insertions(+), 26 deletions(-) diff --git a/drivers/mfd/omap-usb-tll.c b/drivers/mfd/omap-usb-tl

[PATCH v7 05/22] mfd: omap-usb-tll: introduce and use mode_needs_tll()

2013-01-17 Thread Roger Quadros
This is a handy macro to check if the port requires the USB TLL module or not. Use it to Enable the TLL module and manage the clocks. Signed-off-by: Roger Quadros --- drivers/mfd/omap-usb-tll.c | 20 1 files changed, 12 insertions(+), 8 deletions(-) diff --git a/drivers/m

[PATCH v7 12/22] mfd: omap-usb-host: know about number of ports from revision register

2013-01-17 Thread Roger Quadros
The revision register should tell us how many ports are present. Signed-off-by: Roger Quadros --- drivers/mfd/omap-usb-host.c | 33 - 1 files changed, 28 insertions(+), 5 deletions(-) diff --git a/drivers/mfd/omap-usb-host.c b/drivers/mfd/omap-usb-host.c index

[PATCH v7 13/22] mfd: omap-usb-host: override number of ports from platform data

2013-01-17 Thread Roger Quadros
Both OMAP4 and 5 exhibit the same revision ID in the REVISION register but they have different number of ports i.e. 2 and 3 respectively. So we can't rely on REVISION register for number of ports on OMAP5 and depend on platform data (or device tree) instead. Signed-off-by: Roger Quadros --- driv

Re: [PATCH v7 14/22] mfd: omap-usb-host: cleanup clock management code

2013-01-17 Thread Felipe Balbi
On Thu, Jan 17, 2013 at 01:30:23PM +0200, Roger Quadros wrote: > All ports have similarly named port clocks so we can > bunch them into a port data structure and use for loop > to enable/disable the clocks. > > Dynamically allocate and get clocks based on number of ports > available on the platfor

Re: [PATCH v7 15/22] mfd: omap-usb-host: Manage HSIC clocks for HSIC mode

2013-01-17 Thread Felipe Balbi
Hi, On Thu, Jan 17, 2013 at 01:30:24PM +0200, Roger Quadros wrote: > @@ -598,6 +639,24 @@ static int usbhs_omap_probe(struct platform_device *pdev) > clkname, PTR_ERR(pclk)); > else > omap->utmi_clk[i] = pclk; > + > + sn

Re: [PATCH v7 17/22] mfd: omap-usb-host: clean up omap_usbhs_init()

2013-01-17 Thread Felipe Balbi
Hi, On Thu, Jan 17, 2013 at 01:30:26PM +0200, Roger Quadros wrote: > + if (is_omap_usbhs_rev1(omap)) > + reg = omap_usbhs_rev1_hostconfig(omap, reg); > + else if (is_omap_usbhs_rev2(omap)) > + reg = omap_usbhs_rev2_hostconfig(omap, reg); Any way you could maybe: r

Re: [PATCH v7 18/22] USB: ehci-omap: Don't free gpios that we didn't request

2013-01-17 Thread Felipe Balbi
On Thu, Jan 17, 2013 at 01:30:27PM +0200, Roger Quadros wrote: > This driver does not request any gpios so don't free them. > Fixes L3 bus error on multiple modprobe/rmmod of ehci_hcd > with ehci-omap in use. > > CC: Alan Stern > > Signed-off-by: Roger Quadros should this go to stable ? -- b

Re: [PATCH v7 22/22] mdf: omap-usb-host: get rid of build warning

2013-01-17 Thread Felipe Balbi
On Thu, Jan 17, 2013 at 01:30:31PM +0200, Roger Quadros wrote: > Fixes the below build warning when driver is built-in. > > drivers/mfd/omap-usb-host.c:750:12: warning: > ‘usbhs_omap_remove’ defined but not used [-Wunused-function] > > Signed-off-by: Roger Quadros should this go to stable too ?

Re: [PATCH v7 00/22] OMAP USB Host cleanup

2013-01-17 Thread Felipe Balbi
Hi, On Thu, Jan 17, 2013 at 01:30:09PM +0200, Roger Quadros wrote: > Hi, > > This patchset addresses the following > > - Consolidate USB Host platform data. > - Avoid addressing clocks one by one by name and use a for loop + bunch > of cleanups. > - Get number of channels/ports dynamically eit

Re: [PATCH] usb/dwc3: fix ep->maxburst for ep0

2013-01-17 Thread Felipe Balbi
Hi, On Thu, Jan 17, 2013 at 04:34:45PM +0530, Pratyush Anand wrote: > Hi Felip, > > On 1/17/2013 4:14 PM, Pratyush ANAND wrote: > >dwc3_gadget_set_ep_config expects maxburst as incremented by 1. So, by > >default initialize ep->maxburst to 0 for ep0. > > > > Although , this patch fixes issue of

Re: [PATCH] usb: musb: Double buffering issues in host mode TX

2013-01-17 Thread Felipe Balbi
On Thu, Jan 17, 2013 at 12:32:12PM +0100, Supriya s KARANTH wrote: > Hi Felipe, > > > -Original Message- > > From: Felipe Balbi [mailto:ba...@ti.com] > > Subject: Re: [PATCH] usb: musb: Double buffering issues in host mode TX > > > From: supriya karanth > > > Whenever an URB is programme

Re: [PATCH v7 14/22] mfd: omap-usb-host: cleanup clock management code

2013-01-17 Thread Roger Quadros
On 01/17/2013 01:44 PM, Felipe Balbi wrote: > On Thu, Jan 17, 2013 at 01:30:23PM +0200, Roger Quadros wrote: >> All ports have similarly named port clocks so we can >> bunch them into a port data structure and use for loop >> to enable/disable the clocks. >> >> Dynamically allocate and get clocks b

Re: [PATCH v7 15/22] mfd: omap-usb-host: Manage HSIC clocks for HSIC mode

2013-01-17 Thread Roger Quadros
On 01/17/2013 01:45 PM, Felipe Balbi wrote: > Hi, > > On Thu, Jan 17, 2013 at 01:30:24PM +0200, Roger Quadros wrote: >> @@ -598,6 +639,24 @@ static int usbhs_omap_probe(struct platform_device >> *pdev) >> clkname, PTR_ERR(pclk)); >> else >>

Re: [RFC PATCH 2/6] ARM: OMAP: USB: Add phy binding information

2013-01-17 Thread Vivek Gautam
Hi Kishon, On Wed, Jan 16, 2013 at 8:30 PM, Kishon Vijay Abraham I wrote: > This is in preparation for the changes in PHY library to support adding > and getting multiple PHYs of the same type. In the new design, the > binding information between the PHY and the USB controller should be > specif

Re: [PATCH v7 17/22] mfd: omap-usb-host: clean up omap_usbhs_init()

2013-01-17 Thread Roger Quadros
On 01/17/2013 01:48 PM, Felipe Balbi wrote: > Hi, > > On Thu, Jan 17, 2013 at 01:30:26PM +0200, Roger Quadros wrote: >> +if (is_omap_usbhs_rev1(omap)) >> +reg = omap_usbhs_rev1_hostconfig(omap, reg); >> +else if (is_omap_usbhs_rev2(omap)) >> +reg = omap_usbhs_rev2_h

Re: [PATCH v7 15/22] mfd: omap-usb-host: Manage HSIC clocks for HSIC mode

2013-01-17 Thread Felipe Balbi
On Thu, Jan 17, 2013 at 02:10:18PM +0200, Roger Quadros wrote: > On 01/17/2013 01:45 PM, Felipe Balbi wrote: > > Hi, > > > > On Thu, Jan 17, 2013 at 01:30:24PM +0200, Roger Quadros wrote: > >> @@ -598,6 +639,24 @@ static int usbhs_omap_probe(struct platform_device > >> *pdev) > >>

Re: [RFC PATCH 2/6] ARM: OMAP: USB: Add phy binding information

2013-01-17 Thread kishon
Hi, On Thursday 17 January 2013 05:41 PM, Vivek Gautam wrote: Hi Kishon, On Wed, Jan 16, 2013 at 8:30 PM, Kishon Vijay Abraham I wrote: This is in preparation for the changes in PHY library to support adding and getting multiple PHYs of the same type. In the new design, the binding informati

RE: [PATCH v2 4/4] usb: Add APIs to access host registers from Tegra PHY

2013-01-17 Thread Venu Byravarasu
> -Original Message- > From: Felipe Balbi [mailto:ba...@ti.com] > Sent: Thursday, January 17, 2013 2:33 PM > To: Venu Byravarasu > Cc: gre...@linuxfoundation.org; st...@rowland.harvard.edu; > ba...@ti.com; linux-usb@vger.kernel.org; linux-ker...@vger.kernel.org; > swar...@wwwdotorg.org; lin

Re: [PATCH v7 15/22] mfd: omap-usb-host: Manage HSIC clocks for HSIC mode

2013-01-17 Thread Roger Quadros
On 01/17/2013 02:27 PM, Felipe Balbi wrote: > On Thu, Jan 17, 2013 at 02:10:18PM +0200, Roger Quadros wrote: >> On 01/17/2013 01:45 PM, Felipe Balbi wrote: >>> Hi, >>> >>> On Thu, Jan 17, 2013 at 01:30:24PM +0200, Roger Quadros wrote: @@ -598,6 +639,24 @@ static int usbhs_omap_probe(struct pla

Re: [PATCH v7 18/22] USB: ehci-omap: Don't free gpios that we didn't request

2013-01-17 Thread Roger Quadros
On 01/17/2013 01:48 PM, Felipe Balbi wrote: > On Thu, Jan 17, 2013 at 01:30:27PM +0200, Roger Quadros wrote: >> This driver does not request any gpios so don't free them. >> Fixes L3 bus error on multiple modprobe/rmmod of ehci_hcd >> with ehci-omap in use. >> >> CC: Alan Stern >> >> Signed-off-by

Re: [PATCH v7 15/22] mfd: omap-usb-host: Manage HSIC clocks for HSIC mode

2013-01-17 Thread Felipe Balbi
On Thu, Jan 17, 2013 at 02:45:16PM +0200, Roger Quadros wrote: > On 01/17/2013 02:27 PM, Felipe Balbi wrote: > > On Thu, Jan 17, 2013 at 02:10:18PM +0200, Roger Quadros wrote: > >> On 01/17/2013 01:45 PM, Felipe Balbi wrote: > >>> Hi, > >>> > >>> On Thu, Jan 17, 2013 at 01:30:24PM +0200, Roger Quad

Re: [balbi-usb:gadget 4/59] drivers/usb/gadget/f_uac2.c:263:20: warning: unused variable 'agdev'

2013-01-17 Thread Felipe Balbi
Hi, On Thu, Jan 17, 2013 at 08:46:06PM +0800, kbuild test robot wrote: > tree: git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git gadget > head: a95bf2624aecc790d8803995818038bb89a99e6c > commit: b642435333b23ab01d526bd854d118704434fc88 [4/59] usb: gadget: remove > unused variable in

Re: [PATCH] usb: musb: ux500: use clk_prepare_enable and clk_disable_unprepare

2013-01-17 Thread Fabio Baltieri
On Thu, Jan 17, 2013 at 12:51:04PM +0200, Felipe Balbi wrote: > > > Thanks for the ACK. This bug was here unnoticed since 3.6 merge window, > > > > Then it should have Cc: sta...@kernel.org.. > > just added to my tree. Hi Felipe, thanks for adding the stable tag to the patch, but I actually mad

Re: [RFC PATCH 2/6] ARM: OMAP: USB: Add phy binding information

2013-01-17 Thread Vivek Gautam
Hi Kishon, Thanks for the explanation. On Thu, Jan 17, 2013 at 6:01 PM, kishon wrote: > Hi, > > > On Thursday 17 January 2013 05:41 PM, Vivek Gautam wrote: >> >> Hi Kishon, >> >> >> On Wed, Jan 16, 2013 at 8:30 PM, Kishon Vijay Abraham I >> wrote: >>> >>> This is in preparation for the changes

Re: [PATCH] usb: musb: ux500: use clk_prepare_enable and clk_disable_unprepare

2013-01-17 Thread Felipe Balbi
Hi, On Thu, Jan 17, 2013 at 01:57:02PM +0100, Fabio Baltieri wrote: > On Thu, Jan 17, 2013 at 12:51:04PM +0200, Felipe Balbi wrote: > > > > Thanks for the ACK. This bug was here unnoticed since 3.6 merge window, > > > > > > Then it should have Cc: sta...@kernel.org.. > > > > just added to my tr

Re: [PATCH] usb: musb: ux500: use clk_prepare_enable and clk_disable_unprepare

2013-01-17 Thread Sergei Shtylyov
Hello. On 17-01-2013 14:46, Linus Walleij wrote: wrote: This patch converts the module to use clk_prepare_enable and clk_disable_unprepare variants as required by common clock framework. Without this the system crash during probe function. Signed-off-by: Fabio Baltieri Acked-by: L

Re: [PATCH v7 22/22] mdf: omap-usb-host: get rid of build warning

2013-01-17 Thread Roger Quadros
On 01/17/2013 01:50 PM, Felipe Balbi wrote: > On Thu, Jan 17, 2013 at 01:30:31PM +0200, Roger Quadros wrote: >> Fixes the below build warning when driver is built-in. >> >> drivers/mfd/omap-usb-host.c:750:12: warning: >> ‘usbhs_omap_remove’ defined but not used [-Wunused-function] >> >> Signed-off-

[PATCH] usb: gadget: f_uac2: fix compile warning

2013-01-17 Thread Felipe Balbi
this warning was introduced by previous patches, fix it. Reported-by: Fengguang Wu Signed-off-by: Felipe Balbi --- drivers/usb/gadget/f_uac2.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/gadget/f_uac2.c b/drivers/usb/gadget/f_uac2.c index 07fde05..c7468b6 100644 --- a/drivers

Re: [PATCH v2 4/4] usb: Add APIs to access host registers from Tegra PHY

2013-01-17 Thread Felipe Balbi
Hi, On Thu, Jan 17, 2013 at 06:07:56PM +0530, Venu Byravarasu wrote: > > > @@ -605,6 +615,53 @@ static const struct dev_pm_ops > > tegra_ehci_pm_ops = { > > > > > > #endif > > > > > > +/* Bits of PORTSC1, which will get cleared by writing 1 into them */ > > > +#define TEGRA_PORTSC_RWC_BITS (USB_P

[PATCH] USB: option: blacklist network interface on ONDA MT8205 4G LTE

2013-01-17 Thread Bjørn Mork
The driver description files gives these names to the vendor specific functions on this modem: Diag VID_19D2&PID_0265&MI_00 NMEA VID_19D2&PID_0265&MI_01 AT cmd VID_19D2&PID_0265&MI_02 Modem VID_19D2&PID_0265&MI_03 NetVID_19D2&PID_0265&MI_04 Signed-off-by: Bjørn Mork --- drivers/us

Re: [PATCH v6 1/3] usb: fsl-mxc-udc: replace cpu_is_xxx() with platform_device_id

2013-01-17 Thread Fabio Estevam
On Thu, Jan 17, 2013 at 9:25 AM, Lothar Waßmann wrote: > The equivalent of !cpu_is_mx51() would be > strcmp(pdev->id_entry->name, "imx-udc-mx51") (without the '!') meaning > id_entry->name is different from "imx-udc-mx51". Yes, agree. strcmp(pdev->id_entry->name, "imx-udc-mx51") is also better

Re: [PATCH] usb/dwc3: fix ep->maxburst for ep0

2013-01-17 Thread Pratyush Anand
Hi, On Thu, Jan 17, 2013 at 5:25 PM, Felipe Balbi wrote: > > Hi, > > On Thu, Jan 17, 2013 at 04:34:45PM +0530, Pratyush Anand wrote: > > Hi Felip, > > > > On 1/17/2013 4:14 PM, Pratyush ANAND wrote: > > >dwc3_gadget_set_ep_config expects maxburst as incremented by 1. So, by > > >default initializ

Re: [PATCH v2 4/4] usb: Add APIs to access host registers from Tegra PHY

2013-01-17 Thread Alan Stern
On Thu, 17 Jan 2013, Venu Byravarasu wrote: > As Tegra PHY driver need to access one of the Host registers, > added few APIs to ehci tegra driver. > > Signed-off-by: Venu Byravarasu > --- > delta from v1: > Taken care of RWC bits, while accessing PORTSC register. > > drivers/usb/host/ehci-tegr

Re: [PATCH v7 18/22] USB: ehci-omap: Don't free gpios that we didn't request

2013-01-17 Thread Alan Stern
On Thu, 17 Jan 2013, Roger Quadros wrote: > This driver does not request any gpios so don't free them. > Fixes L3 bus error on multiple modprobe/rmmod of ehci_hcd > with ehci-omap in use. > > CC: Alan Stern > > Signed-off-by: Roger Quadros Acked-by: Alan Stern > --- > drivers/usb/host/ehci

  1   2   >