Re: [PATCH 08/10] usb: add usb port auto power off mechanism

2012-12-14 Thread Lan Tianyu
On 2012年12月12日 23:56, Alan Stern wrote: > On Wed, 12 Dec 2012, Lan Tianyu wrote: > I tested a usb ssd which consumes about 1s to makes usb port status enter into connect status after powering off and powering on the port. So I set the tries 20 and the longest latency is larger than

Re: [PATCH 1/1]linux-usb: optimize to match the Huawei USB storage devices and support new switch command

2012-12-14 Thread Alan Cox
On Fri, 14 Dec 2012 03:01:24 + "Fangxiaozhi (Franko)" wrote: > Dear Alan: > > This prevents people getting access to the storage device if they want. > In our device, after its switching, it will keep the cdrom port > together with other ports (such as modem port). So you ca

Re: [PATCH 1/1]linux-usb: optimize to match the Huawei USB storage devices and support new switch command

2012-12-14 Thread Oliver Neukum
On Friday 14 December 2012 09:31:41 Alan Cox wrote: > On Fri, 14 Dec 2012 03:01:24 + > "Fangxiaozhi (Franko)" wrote: > > > Dear Alan: > > > > This prevents people getting access to the storage device if they want. > > In our device, after its switching, it will keep the cdrom por

Re: [PATCH 1/1]linux-usb: optimize to match rules in USB storage for Huawei dongles.

2012-12-14 Thread Felipe Balbi
On Fri, Dec 14, 2012 at 10:25:25AM +0800, fangxiaozhi 00110321 wrote: > From: fangxiaozhi > > 1. Add a new macro define for USB storage match rule. > 2. Optimize the match rules with new macro for Huawei USB storage devices, >to avoid to load USB storage driver for the modem interface >

Re: Linux USB file storage gadget with new UDC

2012-12-14 Thread Felipe Balbi
On Fri, Dec 14, 2012 at 01:58:03PM +0800, victor wrote: > Hi, > > > > > > > > > > > # ls /dev/mmc* > > > > > /dev/mmc0 /dev/mmc2 /dev/mmcblk0p1 > > > > > /dev/mmc1 /dev/mmcblk0/dev/mmcblk0p2 > > > > > > > > > > # mount /dev/mmcblk0 /mnt > > > > > # ls /mnt/ > > > > > initramf

MUSB-HDRC Gadget driving VBUS inappropriately

2012-12-14 Thread Ian Coolidge
Hi, We're using Linux 3.3 on DM3730 with TPS6595xx PMIC for an embedded product. For a particular board, we have musb-hdrc (RTL 1.4) configured in peripheral mode. We use the Ethernet gadget configured for cdc_eem to use Ethernet emulation over USB for this link, and the robustness of the link i

答复: [PATCH 1/1]linux-usb: optimize to match the Huawei USB storage devices and support new switch command

2012-12-14 Thread Fangxiaozhi (Franko)
> -邮件原件- > 发件人: Alan Cox [mailto:a...@lxorguk.ukuu.org.uk] > 发送时间: 2012年12月14日 17:32 > 收件人: Fangxiaozhi (Franko) > 抄送: linux-usb@vger.kernel.org; linux-ker...@vger.kernel.org; Xueguiying > (Zihan); Linlei (Lei Lin); g...@kroah.com; Yili (Neil); Wangyuhua (Roger, > Credit); Huqiao > 主题: Re

Re: MUSB-HDRC Gadget driving VBUS inappropriately

2012-12-14 Thread Felipe Balbi
Hi, On Fri, Dec 14, 2012 at 01:53:07AM -0800, Ian Coolidge wrote: > Hi, > > We're using Linux 3.3 on DM3730 with TPS6595xx PMIC for an embedded > product. > For a particular board, we have musb-hdrc (RTL 1.4) configured in peripheral > mode. > We use the Ethernet gadget configured for cdc_eem to

RE: Linux USB file storage gadget with new UDC

2012-12-14 Thread victor
Hi, > > > > > > # ls /dev/mmc* > > > > > > /dev/mmc0 /dev/mmc2 /dev/mmcblk0p1 > > > > > > /dev/mmc1 /dev/mmcblk0/dev/mmcblk0p2 > > > > > > > > > > > > # mount /dev/mmcblk0 /mnt > > > > > > # ls /mnt/ > > > > > > initramfs.gz > > > > > > # umount /mnt > > > > > > umounting 1 >

Re: Linux USB file storage gadget with new UDC

2012-12-14 Thread Felipe Balbi
Hi, On Fri, Dec 14, 2012 at 06:22:27PM +0800, victor wrote: > > > Thanks. The driver's probe() can be called. Now when insmod > > > g_file_storage.ko, it says the file-backed storage gadget failed to > > > start. I have defined the udc_start() function in usb_gadget_ops > > > structure and added t

RE: [PATCH 1/1]linux-usb: optimize to match the Huawei USB storage devices and support new switch command

2012-12-14 Thread Fangxiaozhi (Franko)
Dear Oliver: > -Original Message- > From: Oliver Neukum [mailto:oneu...@suse.de] > Sent: Friday, December 14, 2012 5:34 PM > To: Alan Cox > Cc: Fangxiaozhi (Franko); linux-usb@vger.kernel.org; > linux-ker...@vger.kernel.org; Xueguiying (Zihan); Linlei (Lei Lin); > g...@kroah.com; Yili (Nei

Re: [PATCH 1/1]linux-usb: optimize to match the Huawei USB storage devices and support new switch command

2012-12-14 Thread Oliver Neukum
On Friday 14 December 2012 10:28:31 Fangxiaozhi wrote: Hi, > > For such devices we should put the switching code into generic code, not a > > device driver so that we have a chance to do reset_resume() on those > > devices. > --Because in many embedded linux system, they don't include

[Suggestion] drivers/usb/host/uhci* : sprintf, need check len when use buf

2012-12-14 Thread Chen Gang
Hello Alan Stern: in drivers/usb/host/uhci-debug.c, for function uhci_sprint_schedule: we are not check the len of buf (not like another static functions in this file). the buffer len is MAX_OUTPUT: 64 * 1024 (line 491, line 517) the buffer may not be enough: we may loop UHCI_NUM

Re: [PATCH] cppi_dma: mark cppi_controller_create() and cppi_pool_init() as '__devinit'

2012-12-14 Thread Sergei Shtylyov
Hello. On 26-11-2012 23:14, Sergei Shtylyov wrote: WARNING: vmlinux.o(.devinit.text+0x24ac): Section mismatch in reference from the function dma_controller_create() to the function .init.text:cppi_controller_start() The function __devinit dma_controller_create() references a function __init c

Re: [PATCH v7] usb_8dev: Add support for USB2CAN interface from 8 devices

2012-12-14 Thread Marc Kleine-Budde
On 12/13/2012 07:40 PM, Bernd Krumboeck wrote: > Add device driver for USB2CAN interface from "8 devices" > (http://www.8devices.com). > > changes since v6: > * changed some variable types to big endian equivalent > * small cleanups > > changes since v5: > * unlock mutex on error > > changes si

Re: MUSB-HDRC Gadget driving VBUS inappropriately

2012-12-14 Thread Grazvydas Ignotas
On Fri, Dec 14, 2012 at 11:53 AM, Ian Coolidge wrote: > we find that with about a 2% chance, the gadget comes up in some kind of > firmware failed state, driving VBUS. > In this condition, we found that MUSB_DEVCTL_SESSION bit was set. > I understand this to be indicative of MUSB thinking it is i

Re: [RFC][PATCH] fs: configfs: programmatically create config groups

2012-12-14 Thread Sebastian Andrzej Siewior
On 12/08/2012 12:18 AM, Joel Becker wrote: Hey Guys, Hi Joel, you took quite some time to write this down. Please remember that configfs is not a "user" interface, it's a userspace<->kernelspace interface. Like sysfs, it's not required to be convenient for someone at a bash prompt.

Re: MUSB-HDRC Gadget driving VBUS inappropriately

2012-12-14 Thread Felipe Balbi
Hi, On Fri, Dec 14, 2012 at 02:13:07PM +0200, Grazvydas Ignotas wrote: > On Fri, Dec 14, 2012 at 11:53 AM, Ian Coolidge wrote: > > we find that with about a 2% chance, the gadget comes up in some kind of > > firmware failed state, driving VBUS. > > In this condition, we found that MUSB_DEVCTL_SE

Re: [PATCH] cppi_dma: mark cppi_controller_create() and cppi_pool_init() as '__devinit'

2012-12-14 Thread Felipe Balbi
Hi, On Fri, Dec 14, 2012 at 03:50:57PM +0400, Sergei Shtylyov wrote: > Hello. > > On 26-11-2012 23:14, Sergei Shtylyov wrote: > > >>WARNING: vmlinux.o(.devinit.text+0x24ac): Section mismatch in reference > >>from the function dma_controller_create() to the function > >>.init.text:cppi_controll

Re: [PATCH v7] usb_8dev: Add support for USB2CAN interface from 8 devices

2012-12-14 Thread Wolfgang Grandegger
On 12/13/2012 07:40 PM, Bernd Krumboeck wrote: > Add device driver for USB2CAN interface from "8 devices" > (http://www.8devices.com). > > changes since v6: > * changed some variable types to big endian equivalent > * small cleanups > > changes since v5: > * unlock mutex on error > > changes si

Re: [PATCHv2][RFC] smsc95xx: enable dynamic autosuspend

2012-12-14 Thread Steve Glendinning
On 11 December 2012 16:13, Ming Lei wrote: > On Tue, Dec 11, 2012 at 11:26 PM, Steve Glendinning > wrote: >> + >> + if (on) >> + usb_autopm_get_interface_no_resume(dev->intf); >> + else >> + usb_autopm_put_interface_no_suspend(dev->intf); > > The above line

Re: [PATCHv2][RFC] smsc95xx: enable dynamic autosuspend

2012-12-14 Thread Steve Glendinning
On 11 December 2012 16:27, Joe Perches wrote: > On Tue, 2012-12-11 at 15:26 +, Steve Glendinning wrote: > []> diff --git a/drivers/net/usb/smsc95xx.c b/drivers/net/usb/smsc95xx.c > [] >> + ret = smsc95xx_read_reg_nopm(dev, RX_FIFO_INF, &val); >> + if (ret < 0) { >> + netdev

Re: [PATCHv2][RFC] smsc95xx: enable dynamic autosuspend

2012-12-14 Thread Oliver Neukum
On Friday 14 December 2012 13:35:04 Steve Glendinning wrote: > Thanks Ming, I've updated this. Very good. Good catch Ming. > > IMO, it is better to keep smsc95xx_info.manage_power as NULL > > for devices without FEATURE_AUTOSUSPEND, so that fewer code > > and follow the current .mange_power usag

Re: [PATCH 1/1]linux-usb: optimize to match rules in USB storage for Huawei dongles.

2012-12-14 Thread Alan Stern
On Fri, 14 Dec 2012, fangxiaozhi 00110321 wrote: > From: fangxiaozhi > > 1. Add a new macro define for USB storage match rule. > 2. Optimize the match rules with new macro for Huawei USB storage devices, >to avoid to load USB storage driver for the modem interface >with Huawei devices.

Re: [PATCH 08/10] usb: add usb port auto power off mechanism

2012-12-14 Thread Alan Stern
On Fri, 14 Dec 2012, Lan Tianyu wrote: > Hi Alan: > debounce is still needed. If connect status was not stable, resume > operation will fail. So how about following? Actually, I'm not sure that a debounce is needed. Debouncing is used when a plug is physically inserted or removed, because

Re: [Suggestion] drivers/usb/host/uhci* : sprintf, need check len when use buf

2012-12-14 Thread Alan Stern
On Fri, 14 Dec 2012, Chen Gang wrote: > Hello Alan Stern: > > in drivers/usb/host/uhci-debug.c, for function uhci_sprint_schedule: > we are not check the len of buf (not like another static functions in this > file). > the buffer len is MAX_OUTPUT: 64 * 1024 (line 491, line 517) > the

Re: USB issue with kernel 3.6

2012-12-14 Thread Alan Stern
On Mon, 10 Dec 2012, Piergiorgio Sartor wrote: > > Here's an idea. This just occurred to me. Maybe when the driver is > > waiting for the async schedule to turn off, new QH's should not be > > added to the schedule. The driver could wait and add them after the > > schedule was off. I didn't do

Re: Need help for hardware bug in Intel's EHCI implementation

2012-12-14 Thread Alan Stern
On Wed, 12 Dec 2012, Alan Stern wrote: > > Nehalem seems to be a particular CPU from 2008. ICH9 came out in 2007. > > So I guess your hardware is a year older than what the devs are looking > > for. I would suggest you test on the newer box anyway. > > I just finished the test. The ICH9 system

Re: [PATCHv2][RFC] smsc95xx: enable dynamic autosuspend

2012-12-14 Thread Ming Lei
On Fri, Dec 14, 2012 at 10:22 PM, Oliver Neukum wrote: > > On second thought, I think that if a driver can do manage_power(), even > only for a subset of devices, it should implement it. Doctoring the table of > methods > is very, very ugly, Sorry, why is it very ugly? netdev_ops/ethtool_ops is

[PATCH v2] cppi_dma: drop '__init' annotation from cppi_controller_create() and cppi_pool_init()

2012-12-14 Thread Sergei Shtylyov
--- This patch is atop of 'musb' branch of Felipe's tree... -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH v2] cppi_dma: drop '__init' annotation from cppi_controller_create() and cppi_pool_init()

2012-12-14 Thread Sergei Shtylyov
This patch fixes the following: WARNING: vmlinux.o(.text+0x1e709c): Section mismatch in reference from the funct ion dma_controller_create() to the function .init.text:cppi_controller_start() The function dma_controller_create() references the function __init cppi_controller_start(). This is often

Re: [PATCH v2] cppi_dma: drop '__init' annotation from cppi_controller_create() and cppi_pool_init()

2012-12-14 Thread Sergei Shtylyov
Hello. On 12/14/2012 09:27 PM, Sergei Shtylyov wrote: > --- > This patch is atop of 'musb' branch of Felipe's tree... Sorry for the unfinished mail, hit the wrong button in KMail... WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message

Re: [PATCH v7] usb_8dev: Add support for USB2CAN interface from 8 devices

2012-12-14 Thread Bernd Krumböck
Hello Marc! > Looks good to me. Minor style issue inline. Please provide a > documentation for the sysfs entries and place it under: > Documentation/ABI/testing/sysfs-platform. Should I change the sysfs path to /sys/devices/platform/usb_8dev? At the moment the path is /sys/bus/usb/devices/:. reg

Re: [PATCH v4 16/23] ARM: OMAP2+: clock data: Merge utmi_px_gfclk into usb_host_hs_utmi_px_clk

2012-12-14 Thread Tony Lindgren
* Roger Quadros [121210 02:23]: > There is no such clock as utmi_p1_gfclk. It is only a clock selector > bit to select th the parent of usb_host_hs_utmi_p1_clk. > So we get rid of utmi_p1_gfclk and utmi_p2_gfclk by merging them into > usb_host_hs_utmi_p1_clk and usb_host_hs_utmi_p2_clk respectivel

Re: [PATCH v4 01/23] mfd: omap-usb-host: get rid of cpu_is_omap..() macros

2012-12-14 Thread Tony Lindgren
* Samuel Ortiz [121213 16:57]: > Hi Tony, > > On Thu, Dec 13, 2012 at 01:49:49PM -0800, Tony Lindgren wrote: > > Hi Samuel, > > > > * Roger Quadros [121210 02:23]: > > > Instead of using cpu_is_omap..() macros in the device driver we > > > rely on information provided in the platform data. > >

Re: [PATCH v7] usb_8dev: Add support for USB2CAN interface from 8 devices

2012-12-14 Thread Marc Kleine-Budde
On 12/14/2012 07:22 PM, "Bernd Krumböck" wrote: > Hello Marc! > >> Looks good to me. Minor style issue inline. Please provide a >> documentation for the sysfs entries and place it under: >> Documentation/ABI/testing/sysfs-platform. > > Should I change the sysfs path to /sys/devices/platform/usb_8

Re: MUSB-HDRC Gadget driving VBUS inappropriately

2012-12-14 Thread Tony Lindgren
* Ian Coolidge [121214 01:55]: > Hi, > > We're using Linux 3.3 on DM3730 with TPS6595xx PMIC for an embedded product. > For a particular board, we have musb-hdrc (RTL 1.4) configured in peripheral > mode. > We use the Ethernet gadget configured for cdc_eem to use Ethernet emulation > over USB f

Re: [PATCH v4 16/23] ARM: OMAP2+: clock data: Merge utmi_px_gfclk into usb_host_hs_utmi_px_clk

2012-12-14 Thread Paul Walmsley
Hi On Fri, 14 Dec 2012, Tony Lindgren wrote: > Paul, what about this patch? Looks like you've acked the other clock > patches in this series but not this one? I commented on it briefly here: https://patchwork.kernel.org/patch/1838111/ Maybe Benoît could comment here, but it looks to me (based

Re: Bug#677472: [3.1->3.2 regression] Immediate wake on suspend, associated with OHCI on MCP51

2012-12-14 Thread Alan Stern
On Thu, 13 Dec 2012, Frank Schäfer wrote: > I have the MCP61 (rev. A2) with id 10de:03f1. > > Further NVIDIA OHCI HCD IDs can be found at > http://openbenchmarking.org/linux/PCI/0c03. > But I'm not sure that we should blacklist them all. Maybe this bug has > been fixed in newer chipset revisions

[PATCH v8] usb_8dev: Add support for USB2CAN interface from 8 devices

2012-12-14 Thread Bernd Krumboeck
Add device driver for USB2CAN interface from "8 devices" (http://www.8devices.com). changes since v7: * add sysfs documentation * fix minor styling issue * fixed can state for passive mode * changed handling for crc errors changes since v6: * changed some variable types to big endian equivalent

Re: [Suggestion] drivers/usb/host/uhci* : sprintf, need check len when use buf

2012-12-14 Thread Chen Gang
于 2012年12月14日 23:46, Alan Stern 写道: > > The easiest fix is to increase MAX_OUTPUT. Can you figure out how > large it needs to be? > for me, it seems only increasing MAX_OUTPUT is not a good idea. maybe we can reference usb_device_dump: it processes the same thing in a simple way. i