Hi, at a closer look I see a few more issues:
Please use s/dev_warn(netdev->dev.parent,/netdev_warn(/ for dev_warn and
friends.
You can drop the do_set_bittiming callback if it's not needed. There is
no need for a dummy function, IIRC.
And please also drop the remaining sysfs files for firmware
On Fri, Nov 30, 2012 at 04:51:16PM +0200, Felipe Balbi wrote:
> On Tue, Nov 20, 2012 at 11:53:02PM +0100, Michal Nazarewicz wrote:
> > > * Felipe Balbi | 2012-11-20 14:14:47 [+0200]:
> > >> now this looks awfully wrong. Why don't you just expose the modules to
> > >> userland (in fact they already
| In file included from drivers/usb/gadget/acm_ms.c:43:
| f_mass_storage.c:2199:18: warning: comparison of unsigned expression >= 0 is
always true [-Wtautological-compare]
| if (common->lun >= 0 && common->lun < common->nluns)
| ~~~ ^ ~
common->lun is defined as "uns
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1085351
Quote:
D-Link DWA-125/B1 is a relatively new USB Wi-Fi adapter, using a
Ralink chipset supported by the rt2800usb driver. Currently, to work
around the problem (it's missing in all present kernel versions, up to
and including 3.7.x), I
On Thu, Nov 01, 2012 at 09:21:16AM +0200, Felipe Balbi wrote:
> then we can merge to net tree and handle the conflicts when merging to
> Linus, that'd be fine by me as long as people know how to solve the
> conflict properly ;-)
Felipe please drop this patch. I don't like this VLAIS patch and its
On 11/30/2012 05:04 PM, Felipe Balbi wrote:
Hi,
Hi,
# echo acm.2,obex.3,msc> \
/sys/kernel/config/usb_gadget/dwc3.0/gadget0/config0/functions
# echo ffs,sourcesink> \
/sys/kernel/config/usb_gadget/dwc3.0/gadget0/config1/functions
what is wrong with having the functions withi
Some touchscreens have buggy firmware which claims
remote wakeup to be enabled after a reset. They nevertheless
crash if the feature is cleared by the host.
Add a check for reset resume before checking for
an enabled remote wakeup feature. On compliant
devices the feature must be clear after a rese
On 11/30/2012 07:39 PM, Michal Nazarewicz wrote:
On Fri, Nov 30 2012, Sebastian Andrzej Siewior wrote:
That won't work. You can only symlink an instance to one UDC. It is an
instance after all. If you want two ACM ports you need two ACM folder
in your functions folder:
acm.ttyS0
acm.ttyS1
Ye
Greg KH пишет:
> Can you make a patch up by following the directions in
> Documentation/SubmittingPatches and send it to me and the mailing list,
> so that I can apply it and give you the proper credit for this?
Trying to following.
I still unsure about correct full vendor name for variable name,
Hi Kukjin,
On Thu, Nov 8, 2012 at 1:49 PM, Vivek Gautam wrote:
> Adding EHCI device tree node for Exynos5250 along with
> the device base adress and gpio line for vbus.
>
Any thoughts about this please ?
> Signed-off-by: Vivek Gautam
> Acked-by: Jingoo Han
> ---
> .../devicetree/bindings/usb
Hi Kukjin,
On Thu, Nov 8, 2012 at 1:51 PM, Vivek Gautam wrote:
> Adding OHCI device tree node for Exynos5250 along with
> the device base address.
>
Any thoughts about this please ?
> Signed-off-by: Vivek Gautam
> Acked-by: Jingoo Han
> ---
> .../devicetree/bindings/usb/exynos-usb.txt
I could finally find the commit which caused the regression I have:
b5153163ed580e00c67bdfecb02b2e3843817b3e
It looks to come from a merge. So I couldn't get any sources to check
for any diff.
For interested people here is the page of the bug:
https://bugzilla.kernel.org/show_bug.cgi?id=477
Hi Kukjin,
On Thu, Nov 8, 2012 at 2:02 PM, Vivek Gautam wrote:
> Adding DWC3 device tree node for Exynos5250 along with the
> device address and clock support needed for the controller.
>
Does this change needs looks fine?
Any thoughts about this please ?
> Signed-off-by: Vivek Gautam
> ---
>
On Mon, Dec 03 2012, Sebastian Andrzej Siewior wrote:
> | In file included from drivers/usb/gadget/acm_ms.c:43:
> | f_mass_storage.c:2199:18: warning: comparison of unsigned expression >= 0
> is always true [-Wtautological-compare]
> | if (common->lun >= 0 && common->lun < common->nluns)
On 12/03/2012 01:50 AM, krumbo...@universalnet.at wrote:
> Add device driver for USB2CAN interface from "8 devices"
> (http://www.8devices.com).
>
> Signed-off-by: Bernd Krumboeck
Please send your patch with git send-email, as with this one all tabs
are converted to spaces.
> ---
> drivers/net
| In file included from drivers/usb/gadget/acm_ms.c:43:
| f_mass_storage.c:2199:18: warning: comparison of unsigned expression >= 0 is
always true [-Wtautological-compare]
| if (common->lun >= 0 && common->lun < common->nluns)
| ~~~ ^ ~
common->lun is defined as "uns
On Mon, Dec 03, 2012 at 02:50:31PM +0100, Michal Nazarewicz wrote:
> While at it, could you also squash the following into your patch:
Done & re-sent but please note that your patch had spaces instead of tabs.
Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
th
On 11/30/2012 11:07 PM, Felipe Balbi wrote:
On Fri, Nov 30, 2012 at 08:09:38PM +0100, Sebastian Andrzej Siewior wrote:
On 11/30/2012 05:43 PM, Alan Stern wrote:
The iProduct,... names are already defined in the USB spec, and their
meanings are different from the way you are using them here. Si
On 12/02/2012 07:10 PM, Sergei Shtylyov wrote:
> Hello.
>
> On 28-11-2012 18:49, Roger Quadros wrote:
>
>> clk_set_parent is expected to fail on OMAP3 platforms. We don't
>> consider that as fatal so don't spam console.
>
>> Signed-off-by: Roger Quadros
>> ---
>> drivers/mfd/omap-usb-host.c |
On 12/03/2012 09:48 AM, Bjørn Mork wrote:
> Sergei Shtylyov writes:
>> On 28-11-2012 18:49, Roger Quadros wrote:
>>> ret = clk_set_parent(omap->utmi_clk[0],
>>> omap->xclk60mhsp1_ck);
>>> if (ret != 0)
>>> - dev_err(dev,
On 12/03/2012 03:45 PM, Sebastian Andrzej Siewior wrote:
then how about we drop the hungarian notation altogether ? Instead of
sManufacturer we follow the host stack and just call it manufacturer.
Likewise for all other fields ??
that would be manufacturer, product, serial. Fine by me. Anyone?
On 12/02/2012 07:14 PM, Sergei Shtylyov wrote:
> Hello.
>
> On 28-11-2012 18:49, Roger Quadros wrote:
>
>> Both OMAP4 and 5 exhibit the same revision ID in the REVISION register
>> but they have different number of ports i.e. 2 and 3 respectively.
>> So we can't rely on REVISION register for numb
On Mon, 3 Dec 2012, Sebastian Andrzej Siewior wrote:
> On 11/30/2012 11:07 PM, Felipe Balbi wrote:
> > On Fri, Nov 30, 2012 at 08:09:38PM +0100, Sebastian Andrzej Siewior wrote:
> >> On 11/30/2012 05:43 PM, Alan Stern wrote:
> >>> The iProduct,... names are already defined in the USB spec, and the
On Mon, 3 Dec 2012, Andy Green wrote:
> Unless someone NAKs it for sure already (if you're already sure you're
> going to, please do so to avoid wasting time), I'll issue a try#2 of my
> code later which demonstrates what I mean. At least I guess it's useful
> for comparative purposes.
Before
On Mon, 3 Dec 2012, Oliver Neukum wrote:
> Some touchscreens have buggy firmware which claims
> remote wakeup to be enabled after a reset. They nevertheless
> crash if the feature is cleared by the host.
> Add a check for reset resume before checking for
> an enabled remote wakeup feature. On comp
On Mon, 3 Dec 2012, Sebastian Andrzej Siewior wrote:
> I think I can make iteven more complicated: Everything on the gadget
> side uses language code 0x409 for en-us. The host-side on Linux takes
> the first available language code and falls back to 0x409 if it (the
> first reported) didn't work.
On Mon, 3 Dec 2012, dAgeCKo wrote:
>
> I could finally find the commit which caused the regression I have:
>
> b5153163ed580e00c67bdfecb02b2e3843817b3e
>
> It looks to come from a merge. So I couldn't get any sources to check
> for any diff.
Probably you found the wrong commit. A merge shoul
On Mon, Dec 03, 2012 at 01:55:38PM +0200, Anca Emanuel wrote:
> https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1085351
>
> Quote:
>
> D-Link DWA-125/B1 is a relatively new USB Wi-Fi adapter, using a
> Ralink chipset supported by the rt2800usb driver. Currently, to work
> around the problem
> On 11/30/2012 07:39 PM, Michal Nazarewicz wrote:
>> Yeah, but what Felipe just made me realise is that if that's the case,
>> than it makes no sense to have the functions directory outside of the
>> gadget. Instead we should have something like:
On Mon, Dec 03 2012, Sebastian Andrzej Siewior wr
> On Fri, Nov 30, 2012 at 07:40:31PM +0100, Michal Nazarewicz wrote:
>> IMO that's actually mute argument since it can be done regardless. You
>> can modprobe the module anyway.
On Fri, Nov 30 2012, Felipe Balbi wrote:
> fair enough, I just want to avoid doing any memory allocations, or HW
> init
On 12-12-03 12:57 PM, Sebastian Andrzej Siewior wrote:
On Thu, Nov 01, 2012 at 09:21:16AM +0200, Felipe Balbi wrote:
then we can merge to net tree and handle the conflicts when merging to
Linus, that'd be fine by me as long as people know how to solve the
conflict properly ;-)
Felipe please dro
It looks to come from a merge. So I couldn't get any sources to check
for any diff.
Probably you found the wrong commit. A merge should not cause any
bugs.
I bisected directly from drivers/usb. Could it be the reason ?
Here is below the log of the bisect. As you could see I got several
'b
The USB 2.0 specification says that bMaxPower is the maximum power
consumption expressed in 2 mA units and the USB 3.0 specification says
that it is expressed in 8 mA units.
This patch renames bMaxPower to MaxPower and the various /2 and *2 are
removed. Before reporting the config descriptor, the p
The USB 2.0 specification says that bMaxPower is the maximum power
consumption expressed in 2 mA units and the USB 3.0 specification says
that it is expressed in 8 mA units.
This patch adds a helper function usb_get_max_power() which computes the
value based on config & usb_device's speed value. Th
On Mon, 3 Dec 2012, dAgeCKo wrote:
>
> >> It looks to come from a merge. So I couldn't get any sources to check
> >> for any diff.
> >
> > Probably you found the wrong commit. A merge should not cause any
> > bugs.
>
> I bisected directly from drivers/usb. Could it be the reason ?
Yes, it coul
Hi Wolfgang!
And please also drop the remaining sysfs files for firmware and
hardware. I thinks it's enough that the versions are printed when the
device is probed.
Systemadministrators often use versions for configuration scripts.
If you insist I will remove.
+/*
+ * CAN driver for UAB "8
Hi Wolfgang!
The Script checkpatch.pl didn't like this comment style. I'll change it
again.
I'm confused. Could you please show the comment and the checkpatch.pl
message. I hope it does not argue against:
http://lxr.linux.no/#linux+v3.6.8/Documentation/CodingStyle#L446
...
/*
* Send comma
Hi Marc!
+/* Send open command to device */
+static int usb_8dev_cmd_open(struct usb_8dev *dev)
+{
+struct can_bittiming *bt = &dev->can.bittiming;
+struct usb_8dev_cmd_msg outmsg;
+struct usb_8dev_cmd_msg inmsg;
+u32 flags = 0;
+u32 beflags;
+u16 bebrp;
+u32 ctrlmod
On Sun, Dec 02, 2012 at 03:54:39PM -0500, Alan Stern wrote:
> On Sun, 2 Dec 2012, Piergiorgio Sartor wrote:
>
> > I'll give it another round, with dmesg
> >
> > How about the registers? Any hint there?
>
> No, not really. At least, not that I can tell at this point; maybe
> later on it will be
On Mon, Dec 03, 2012 at 08:07:06PM +0100, Sebastian Andrzej Siewior wrote:
> The USB 2.0 specification says that bMaxPower is the maximum power
> consumption expressed in 2 mA units and the USB 3.0 specification says
> that it is expressed in 8 mA units.
Thanks for catching this, Sebastian! Howev
On 12/03/2012 09:32 PM, krumbo...@universalnet.at wrote:
> Hi Wolfgang!
>
>>
>> And please also drop the remaining sysfs files for firmware and
>> hardware. I thinks it's enough that the versions are printed when the
>> device is probed.
>
> Systemadministrators often use versions for configurati
On Tue, 2012-11-27 at 19:01 +0100, Sebastian Andrzej Siewior wrote:
> Since commit 89c8d91e31f2 ("tty: localise the lock") I see a dead lock
> in one of my dummy_hcd + g_nokia test cases. The first run one was usually
> okay, the second often resulted in a splat by lockdep and the third was
> usual
On Tue, Nov 27, 2012 at 12:20:42PM -0500, Alan Stern wrote:
> The only thing that's strange is that there are so many dropped packets
> and that they seem to fall into a small number of patterns. This
> strongly suggests hardware issues. Daniel G., have you tried running
> your tests on a diff
On Mon, 3 Dec 2012, Sebastian Andrzej Siewior wrote:
> The USB 2.0 specification says that bMaxPower is the maximum power
> consumption expressed in 2 mA units and the USB 3.0 specification says
> that it is expressed in 8 mA units.
> This patch adds a helper function usb_get_max_power() which com
On Mon, 3 Dec 2012, Sarah Sharp wrote:
> On Mon, Dec 03, 2012 at 08:07:06PM +0100, Sebastian Andrzej Siewior wrote:
> > The USB 2.0 specification says that bMaxPower is the maximum power
> > consumption expressed in 2 mA units and the USB 3.0 specification says
> > that it is expressed in 8 mA uni
On Mon, Dec 3, 2012 at 12:52 PM, Andy Green wrote:
+static void ehci_hub_power_off(struct power_controller *pc, struct
device
*dev)
+{
+ gpio_set_value(GPIO_HUB_NRESET, 0);
+ gpio_set_value(GPIO_HUB_POWER, 0);
+}
+
+static struct usb_port_po
On Tue, Dec 4, 2012 at 1:09 AM, Alan Stern wrote:
> On Mon, 3 Dec 2012, Andy Green wrote:
>
>> Unless someone NAKs it for sure already (if you're already sure you're
>> going to, please do so to avoid wasting time), I'll issue a try#2 of my
>> code later which demonstrates what I mean. At least I
On 04/12/12 01:09, the mail apparently from Alan Stern included:
On Mon, 3 Dec 2012, Andy Green wrote:
Unless someone NAKs it for sure already (if you're already sure you're
going to, please do so to avoid wasting time), I'll issue a try#2 of my
code later which demonstrates what I mean. At le
On 04/12/12 10:39, the mail apparently from Ming Lei included:
On Mon, Dec 3, 2012 at 12:52 PM, Andy Green wrote:
+static void ehci_hub_power_off(struct power_controller *pc, struct
device
*dev)
+{
+ gpio_set_value(GPIO_HUB_NRESET, 0);
+ gpio_set_value(GPIO_HUB_POWER, 0);
+}
+
+stat
On Fri, Nov 30, 2012 at 10:10 PM, Felipe Balbi wrote:
> Hi,
>
> On Tue, Nov 27, 2012 at 10:05:59PM -0500, Chao Xie wrote:
>> The patches are divied into 4 parts
>> 1. bug fixes
>> usb: gadget: mv_udc: use udc_start and udc_stop functions
>> usb: gadget: mv_udc: use devm_xxx for probe
>> usb:
50 matches
Mail list logo
