On 11/14/2012 06:45 AM, Felipe Balbi wrote:
Hi,
Hi Felipe,
On Wed, Nov 14, 2012 at 01:47:23PM +0800, Wei Yongjun wrote:
From: Wei Yongjun
In the error handling case of tcm_usbg_drop_nexus(), the error code
is assigned to 'ret', but it is ignored. We'd better return 'ret'
instead of always r
On Wednesday, November 14, 2012 02:34:37 PM Lan Tianyu wrote:
> On 2012年11月14日 08:08, Rafael J. Wysocki wrote:
> > On Tuesday, November 13, 2012 04:00:02 PM Lan Tianyu wrote:
> >> This patch is to add runtime pm callback for usb port device.
> >> Set/clear PORT_POWER feature in the resume/suspend c
Changes from v7:
Rebased to the latest usb-next branch.
Separating arch patches from these driver patches.
Changes from v6:
Modified register definitions according to the existing ones.
Changed default PHY clk selection for SoCs.
Improved binding text and rebased to the latest usb-next.
Changes f
This driver uses usb_phy interface to interact with s3c-hsotg. Supports
phy_init and phy_shutdown functions to enable/disable usb phy. Support
will be extended to host controllers and more Samsung SoCs.
Signed-off-by: Praveen Paneri
Acked-by: Heiko Stuebner
Acked-by: Kyungmin Park
---
.../devi
Adding the transceiver to hsotg driver. Keeping the platform data
for continuing the smooth operation for boards which still uses it
Signed-off-by: Praveen Paneri
Acked-by: Kyungmin Park
---
drivers/usb/gadget/s3c-hsotg.c | 37 +++--
1 files changed, 27 inserti
This driver will be used for every Freescale SoC which has this misc
memory layout to control the basic usb handling. So better name this
driver, function and struct names in a more generic way.
Reported-by: Fabio Estevam
Signed-off-by: Michael Grzeschik
Signed-off-by: Marc Kleine-Budde
---
dr
This adds mx53 as the next user of the usbmisc driver and makes it
possible to disable the overcurrent-detection of the internal phy.
Signed-off-by: Michael Grzeschik
Signed-off-by: Marc Kleine-Budde
---
drivers/usb/chipidea/usbmisc_imx.c | 28
1 file changed, 28
From: Marc Kleine-Budde
This attaches the usbmisc_ops to the of_device_id data and
makes it possible to define special functions per soc.
Signed-off-by: Marc Kleine-Budde
Signed-off-by: Michael Grzeschik
---
drivers/usb/chipidea/usbmisc_imx.c | 11 ---
1 file changed, 8 insertions(+
From: Marc Kleine-Budde
This patch adds support for ahb, ipg and per clock, which is needed to support
imx53.
Signed-off-by: Marc Kleine-Budde
Signed-off-by: Michael Grzeschik
---
drivers/usb/chipidea/usbmisc_imx.c | 60 +++-
1 file changed, 45 insertions(+),
Nearly every SoC from Freescale has this non-core usb registers. This series
adds support for more users of this driver.
Marc Kleine-Budde (3):
usb: chipidea: usbmisc: unset global varibale usbmisc on driver
remove
usb: chipidea: usbmisc: prepare driver to handle more than one soc
usb: c
From: Marc Kleine-Budde
While there fix a potential race condition, first set usbmisc, then call
usbmisc_set_ops().
Signed-off-by: Marc Kleine-Budde
Signed-off-by: Michael Grzeschik
---
drivers/usb/chipidea/usbmisc_imx6q.c |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --
This adds a post handling routine which is called after
ci13xxx_add_device was called. The first user is the mx25, which has to
disable the external-vbus-divider after the ude has started.
Signed-off-by: Michael Grzeschik
Signed-off-by: Marc Kleine-Budde
---
.../devicetree/bindings/usb/ci13xxx-
Hi Michael,
On Wed, Nov 14, 2012 at 9:55 AM, Michael Grzeschik
wrote:
> This driver will be used for every Freescale SoC which has this misc
> memory layout to control the basic usb handling. So better name this
> driver, function and struct names in a more generic way.
>
> Reported-by: Fabio Est
于 2012/11/14 17:49, Rafael J. Wysocki 写道:
On Wednesday, November 14, 2012 02:34:37 PM Lan Tianyu wrote:
On 2012年11月14日 08:08, Rafael J. Wysocki wrote:
On Tuesday, November 13, 2012 04:00:02 PM Lan Tianyu wrote:
This patch is to add runtime pm callback for usb port device.
Set/clear PORT_POWER
Michael Grzeschik writes:
> From: Marc Kleine-Budde
>
> While there fix a potential race condition, first set usbmisc, then call
> usbmisc_set_ops().
This should be really two separate patches, both of which could use
more elaborate commit messages. That is, if you unset variable, what
kind of
Michael Grzeschik writes:
> This driver will be used for every Freescale SoC which has this misc
> memory layout to control the basic usb handling. So better name this
> driver, function and struct names in a more generic way.
>
> Reported-by: Fabio Estevam
> Signed-off-by: Michael Grzeschik
>
On Wed, Nov 14, 2012 at 03:25:30PM +0200, Alexander Shishkin wrote:
> Michael Grzeschik writes:
>
> > This driver will be used for every Freescale SoC which has this misc
> > memory layout to control the basic usb handling. So better name this
> > driver, function and struct names in a more gener
Michael Grzeschik writes:
> On Wed, Nov 14, 2012 at 03:25:30PM +0200, Alexander Shishkin wrote:
>> Michael Grzeschik writes:
>>
>> > This driver will be used for every Freescale SoC which has this misc
>> > memory layout to control the basic usb handling. So better name this
>> > driver, functi
Michael Grzeschik writes:
> From: Marc Kleine-Budde
>
> This patch adds support for ahb, ipg and per clock, which is needed to support
> imx53.
I would also suggest using a more elaborate wording here, some people
might also be interested what are the different clocks for (like,
interface, peri
于 2012/11/14 20:45, Lan Tianyu 写道:
于 2012/11/14 17:49, Rafael J. Wysocki 写道:
On Wednesday, November 14, 2012 02:34:37 PM Lan Tianyu wrote:
On 2012年11月14日 08:08, Rafael J. Wysocki wrote:
On Tuesday, November 13, 2012 04:00:02 PM Lan Tianyu wrote:
This patch is to add runtime pm callback for us
From: Haipeng YU
When a device is switched off by software, gserial_cleanup will
be called, and switch off will be blocked in this function
because wake_up_interruptible() in gs_close() can not wake_up
the wait_event() in gserial_cleanup(), it should be changed to
wake_up() to match the wait_even
Hi,
(please Cc myself for PHY-related questions ;-)
On Wed, Nov 14, 2012 at 10:35:42AM +0800, Chao Xie wrote:
> The USB controller in our SOC can support otg/ehci/udc, and there is a
> PHY around the controller. It means that when we want to enable otg or
> ehci or udc, we have to enable the PHY.
Commit 5c8a86e10a7c164f44537fabdc169fd8b4e7a440 (usb: musb: drop unneeded
musb_debug trickery) erroneously removed '\n' from the driver's banner.
Concatenate all the banner substrings while adding it back...
Signed-off-by: Sergei Shtylyov
Cc: sta...@vger.kernel.org # 3.0+
---
MUSB driver has bee
On Wed, Nov 14, 2012 at 06:49:50PM +0300, Sergei Shtylyov wrote:
> Commit 5c8a86e10a7c164f44537fabdc169fd8b4e7a440 (usb: musb: drop unneeded
> musb_debug trickery) erroneously removed '\n' from the driver's banner.
> Concatenate all the banner substrings while adding it back...
>
> Signed-off-by:
Hello.
On 11/14/2012 06:02 PM, Greg KH wrote:
>> Commit 5c8a86e10a7c164f44537fabdc169fd8b4e7a440 (usb: musb: drop unneeded
>> musb_debug trickery) erroneously removed '\n' from the driver's banner.
>> Concatenate all the banner substrings while adding it back...
>> Signed-off-by: Sergei Shtylyov
于 2012/11/14 20:45, Lan Tianyu 写道:
于 2012/11/14 17:49, Rafael J. Wysocki 写道:
On Wednesday, November 14, 2012 02:34:37 PM Lan Tianyu wrote:
On 2012年11月14日 08:08, Rafael J. Wysocki wrote:
On Tuesday, November 13, 2012 04:00:02 PM Lan Tianyu wrote:
This patch is to add runtime pm callback for us
On Wed, Nov 14, 2012 at 03:39:11PM +0200, Alexander Shishkin wrote:
> Michael Grzeschik writes:
>
> > From: Marc Kleine-Budde
> >
> > This patch adds support for ahb, ipg and per clock, which is needed to
> > support
> > imx53.
>
> I would also suggest using a more elaborate wording here, some
On Wed, Nov 14, 2012 at 09:57:50AM -0200, Fabio Estevam wrote:
> Hi Michael,
>
> On Wed, Nov 14, 2012 at 9:55 AM, Michael Grzeschik
> wrote:
> > This driver will be used for every Freescale SoC which has this misc
> > memory layout to control the basic usb handling. So better name this
> > driver
From: "Jason J. Herne"
Force large capacity (> 0x blocks) drives to use READ/WRITE(16) instead
of READ/WRITE(10). Some(most/all?) USB enclosures do not like READ(10) commands
when a large capacity drive is installed.
Signed-off-by: Jason J. Herne
---
drivers/scsi/sd.c |5 +
On Tue, 13 Nov 2012, Sarah Sharp wrote:
> Hi Alan,
>
> I've been working on the warm reset fix patch, and I've run into a
> couple questions. A draft patch is attached, but it's not in any way
> done. :)
This is indeed a difficult problem to get one's mind around.
> In hub_events, we check whe
This patch makes it possible to set the connection of the usbphy to the
soc. It is derived from the oftree bindings for the ethernetphy and adds
similar helperfunctions.
Signed-off-by: Michael Grzeschik
Signed-off-by: Marc Kleine-Budde
---
drivers/of/Kconfig|4
drivers/of/Makef
Marc Kleine-Budde (2):
usb: chipidea: pci: mark platformdata as static and __devinitdata
usb: chipidea: ci13xxx-imx: add "dr_mode" property to device tree bindings
Michael Grzeschik (7):
usb: chipidea: ci13xxx_imx: add 2nd and 3rd clock to support imx5x and newer
usb: chipidea: ci13xxx-imx
This patch makes it possible to set the chipidea udc
into full-speed only mode. It can be set by the oftree
property "force-full-speed".
Signed-off-by: Michael Grzeschik
Signed-off-by: Marc Kleine-Budde
---
drivers/usb/chipidea/bits.h |1 +
drivers/usb/chipidea/core.c |5 +
includ
The implementation is derived from the fsl_udc_core code in
fsl_ep_enable and makes basic iso handling possible.
Signed-off-by: Michael Grzeschik
Signed-off-by: Marc Kleine-Budde
---
drivers/usb/chipidea/udc.c | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/d
Its not nessecary to call ep_queue unlocked while in the
own driver. So we move the function to an unlocked version
and call it conditionaly.
Signed-off-by: Michael Grzeschik
Signed-off-by: Marc Kleine-Budde
---
drivers/usb/chipidea/udc.c | 115 +---
1 f
From: Marc Kleine-Budde
Signed-off-by: Marc Kleine-Budde
Signed-off-by: Michael Grzeschik
---
drivers/usb/chipidea/ci13xxx_pci.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/chipidea/ci13xxx_pci.c
b/drivers/usb/chipidea/ci13xxx_pci.c
index 918e149..
This patch removes the limitation of having only one instance of the
ci13xxx-imx platformdata and makes different configurations possible.
Signed-off-by: Michael Grzeschik
Signed-off-by: Marc Kleine-Budde
---
drivers/usb/chipidea/ci13xxx_imx.c | 27 ---
1 file changed,
This patch adds support for a second and third clock to the chipidea driver. On
modern freescale ARM cores like the imx51, imx53 and imx6q three clocks ("ahb",
"ipg" and "per") must be enabled in order to access the USB core.
In the original driver, the clock was requested without specifying the
c
This patch makes it possible to configure the PTW and PTS bits inside
the portsc register for host and device mode before the driver starts
and the phy can be addressed as hardware implementation is designed.
Signed-off-by: Michael Grzeschik
Signed-off-by: Marc Kleine-Budde
---
drivers/usb/chip
From: Marc Kleine-Budde
Its necessary to limit a hostonly soc to its single role, since
debugging has shown that reading on the "CAP_DCCPARAMS" register inside
a host-only port, what ci_hdrc_gadget_init does, can lead to an
instable behaviour of the IC.
This patch allows the device tree to limit
Hello Alan,
I have a similar issue and not sure if bind/unbind is the solution. I have
multiple devices plugged into a hub (gprs modem, webcam,rfid reader) which
connects to an SBC running linux 2.6.32.11. Each two of the devices work
together and function correctly. However when all three are con
On Tue, 13 Nov 2012 gre...@linuxfoundation.org wrote:
> From e592c5d0b7db94b485b4a2342db041a1882b7f75 Mon Sep 17 00:00:00 2001
> From: Greg Kroah-Hartman
> Date: Tue, 13 Nov 2012 10:52:52 -0800
> Subject: Revert "USB/host: Cleanup unneccessary irq disable code"
>
> This reverts commit 73d4066055
Hello.
On 11/14/2012 07:19 PM, Michael Grzeschik wrote:
> The implementation is derived from the fsl_udc_core code in
> fsl_ep_enable and makes basic iso handling possible.
> Signed-off-by: Michael Grzeschik
> Signed-off-by: Marc Kleine-Budde
> ---
> drivers/usb/chipidea/udc.c | 12
On Wed, 14 Nov 2012, Lan Tianyu wrote:
> >>> Hi Rafael and Alan:
> >>> This patch has a collaboration problem with pm qos. Since pm core
> >>> would
> >>> pm_runtime_get_sync/put(port_dev) if pm qos flags was changed and port's
> >>> suspend call_back() clear PORT_POWER feature without any ch
On 10/11/12 09:30 AM, Johan Hovold wrote:
Hi Johan,
There was a reference-count fix for the probe error path that went in to
v3.5. Haven't read all the details on how you trigger your leak, but at
the face of it, it could be related.
Have a look at 0658a3366db7e27fa ("usb: use usb_serial_put in
If we do have endpoints named like "ep-a" then bEndpointAddress is
counted internally by the gadget framework.
If we do have endpoints named like "ep-1" then bEndpointAddress is
assigned from the digit after "ep-".
If we do have both, then it is likely that after we used up the
"generic" endpoints
this is v3 of the gadget interface.
v1. first version
v2. converted all ACM users
v3. removed the "generic configuration". This will be added once we have
configfs.
Comments are greatly appreciated.
Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body
Lets assume nokia_bind() starts with "return -EINVAL". After loading the
gadget we end up with:
|udc dummy_udc.0: registering UDC driver [g_nokia]
|BUG: unable to handle kernel NULL pointer dereference at 0040
|IP: [] __list_add+0x25/0xf0
|Call Trace:
| [] rollback_registered+0x21/0x40
| [] un
This patch provides an infrastructure to register & unregister a USB
function. This allows to turn a function into a module and avoid the
'#include "f_.*.c"' magic and we get a clear API / cut between the bare
gadget and its functions.
The concept is simple:
Each function defines the DECLARE_USB_FU
This patch factors out the three possible functions into three possible
bind functions which are passed as an argument to usb_add_config(). This
will ease the step by step converting of the individual functions to the
new function registration method.
Signed-off-by: Sebastian Andrzej Siewior
---
Every user of u_serial has now to select the U_SERIAL symbol instead of
including the file.
There is one limition with this: ports and and gs_tty_driver are global
variables in u_serial. Since all users share them, there can be only one
user loaded at a time i.e. either g_serial or g_nokia.
Signed
This patch converts the f_sourcesink and f_loopback file to the USB-function
module. Both functions shares a few common utility functions which are
currently implemented in g_zero.c itself. This patch moves the common
code into the sourcesink file and creates one module out of the the two
functions
The significant part of this function was removed in 90f7976 ("USB:
Remove unsupported usb gadget drivers"). I would move this to function
bind time but I don't see the point in moving an empty function.
Therefore bye bye.
Signed-off-by: Sebastian Andrzej Siewior
---
drivers/usb/gadget/f_acm.c |
f_loopback should only include the bare function but it also includes
the config descriptor. This patch moves the config descriptor into
zero.c, the only user of this function.
Signed-off-by: Sebastian Andrzej Siewior
---
drivers/usb/gadget/f_loopback.c | 44 ++-
f_sourcesink should only include the bare function but it also includes
the config descriptor. This patch moves the config descriptor into
zero.c, the only user of this function.
Signed-off-by: Sebastian Andrzej Siewior
---
drivers/usb/gadget/f_sourcesink.c | 48 +++
The setup request can be sent to an interface/endpoint or to the device
itself. If it is sent to an interface / endpoint then we forward it to
the function that is mapped to that interface / endpoint.
If the device is the target of the setup request then we forward it to the
->setup() callback of t
the u_ether.c file has a global variable named the_dev which keeps a
pointer to the network device after it has been created via
gether_setup_name(). It is only used internally by u_ether. This patches
moves the variable to its users and passes it via the port.ioport where
it is saved later anyway.
This patch converts the acm_ms gadget to make use of the function
framework to request the ACM function.
With nokia beeing the last user of the include interface, it is gone
now.
Signed-off-by: Sebastian Andrzej Siewior
---
drivers/usb/gadget/Kconfig|1 +
drivers/usb/gadget/f_acm.c|
This patch converts f_acm into a module which uses the new function
interface. It also converts one of its users that is g_serial to make
use of it. The other users of it (g_nokia for instance) are still using
the old include file system and should not notice the change at all. So
they can be conve
This will be used to remove a single function from a given config. Right
now "ignore" that an error at ->bind() time and cleanup later during
composite_unbind() / remove_config().
Signed-off-by: Sebastian Andrzej Siewior
---
drivers/usb/gadget/composite.c | 12
include/linux/usb/c
This patch converts the acm_ms gadget to make use of the function
framework to request the ACM function.
Signed-off-by: Sebastian Andrzej Siewior
---
drivers/usb/gadget/Kconfig |1 +
drivers/usb/gadget/multi.c | 47 ++--
2 files changed, 38 insertion
This patch converts the acm_ms gadget to make use of the function
framework to request the ACM function.
Signed-off-by: Sebastian Andrzej Siewior
---
drivers/usb/gadget/Kconfig |1 +
drivers/usb/gadget/cdc2.c | 17 -
2 files changed, 13 insertions(+), 5 deletions(-)
diff
This patch converts the acm_ms gadget to make use of the function
framework to request the ACM function.
Signed-off-by: Sebastian Andrzej Siewior
---
drivers/usb/gadget/Kconfig |1 +
drivers/usb/gadget/acm_ms.c | 21 ++---
2 files changed, 15 insertions(+), 7 deletions(-)
On Wed, 14 Nov 2012, Graham wrote:
> Hello Alan,
>
> I have a similar issue and not sure if bind/unbind is the solution. I have
> multiple devices plugged into a hub (gprs modem, webcam,rfid reader) which
> connects to an SBC running linux 2.6.32.11. Each two of the devices work
> together and fu
Hi all again,
I would like just to re-state the issue and try
to rationalize a possible debugging strategy.
So my questions would be:
1) Is there any possibility, with a Fedora kernel,
to activate some run-time debugging/verbosity
option for the USB/ehci/usb-storage subsystem in
order to try to
On Wed, Nov 14, 2012 at 12:12:01PM -0500, Richard Retanubun wrote:
> On 10/11/12 09:30 AM, Johan Hovold wrote:
> Hi Johan,
>
> > There was a reference-count fix for the probe error path that went in to
> > v3.5. Haven't read all the details on how you trigger your leak, but at
> > the face of it,
On Wed, Oct 31, 2012 at 09:32:35PM +0100, Michal Nazarewicz wrote:
> From: Michal Nazarewicz
>
> The File-backed Storage Gadget (g_file_storage) gadget has been replaced
> with Mass Storage Gadget (g_mass_storage) which uses the composite
> framework. This commit removes g_file_storage (and most
Hello.
On 11/14/2012 06:49 PM, Sergei Shtylyov wrote:
> MUSB driver has been spoiling kernel output since 3.0 and nobody noticed --
> I wonder how good it's actually tested (especially given the face that
> loading DaVinci glue as module just hangs DM6446 EVM board).
Felipe, luckily, in-kerne
On Wed, 14 Nov 2012, Piergiorgio Sartor wrote:
> Hi all again,
>
> I would like just to re-state the issue and try
> to rationalize a possible debugging strategy.
>
> So my questions would be:
>
> 1) Is there any possibility, with a Fedora kernel,
> to activate some run-time debugging/verbosity
On Wed, Oct 31, 2012 at 09:32:37PM +0100, Michal Nazarewicz wrote:
> diff --git a/drivers/usb/gadget/f_mass_storage.c
> b/drivers/usb/gadget/f_mass_storage.c
> index 3433e43..5d027b3 100644
> --- a/drivers/usb/gadget/f_mass_storage.c
> +++ b/drivers/usb/gadget/f_mass_storage.c
> @@ -228,10 +228,6
On Wed, Oct 31, 2012 at 09:32:37PM +0100, Michal Nazarewicz wrote:
> diff --git a/drivers/usb/gadget/storage_common.c
> b/drivers/usb/gadget/storage_common.c
> index b381e0c..1b5bc69 100644
> --- a/drivers/usb/gadget/storage_common.c
> +++ b/drivers/usb/gadget/storage_common.c
> static __maybe_u
On Wed, Nov 14, 2012 at 10:57:44AM -0500, Alan Stern wrote:
> On Tue, 13 Nov 2012, Sarah Sharp wrote:
>
> > Hi Alan,
> >
> > I've been working on the warm reset fix patch, and I've run into a
> > couple questions. A draft patch is attached, but it's not in any way
> > done. :)
>
> This is indee
On Thu, Nov 01, 2012 at 02:46:56PM +0100, Michal Nazarewicz wrote:
>
> ie. f_mass_storage.c is the 5th biggest file in drivers/usb/gadget, so
> if anything, I would rather split it further into pieces than merge it
> with storage_common.c adding another 700 lines and producing the biggest
> file i
On Thu, Nov 08, 2012 at 01:01:43PM -0500, Alan Stern wrote:
> No. You shouldn't think of this as a USB problem any more; you should
> consider it a SCSI/ATA problem. Try asking the people on the
> linux-scsi and linux-ide mailing lists. But keep linux-usb in the CC:
> list just in case.
Coul
On Wed, Nov 14, 2012 at 12:55:13AM -0500, Jason J. Herne wrote:
> --- a/drivers/scsi/sd.c
> +++ b/drivers/scsi/sd.c
> @@ -887,7 +887,7 @@ static int sd_prep_fn(struct request_queue *q, struct
> request *rq)
> SCpnt->cmnd[29] = (unsigned char) (this_count >> 16) & 0xff;
>
On Wed, 14 Nov 2012, Sebastian Andrzej Siewior wrote:
> On Thu, Nov 08, 2012 at 01:01:43PM -0500, Alan Stern wrote:
> > No. You shouldn't think of this as a USB problem any more; you should
> > consider it a SCSI/ATA problem. Try asking the people on the
> > linux-scsi and linux-ide mailing li
On Tue, Nov 13, 2012 at 04:07:17PM +0800, Lan Tianyu wrote:
> + for (i = 1; i <= ports; i++) {
> + if (usb_get_hub_port_connect_type(
> + ehci_to_hcd(ehci)->self.root_hub, i)
> + == USB_PORT_CONNECT_TYPE_HARD_WIRED)
> +
On Wed, 14 Nov 2012, Sarah Sharp wrote:
> On a device connect, the port can go into either Compliance Mode or
> Inactive on various link failures. Also, the ports can change state
> into Inactive if the U1/U2 exit fails. So if we have Link PM enabled
> for a USB 3.0 device, the port can go into
On Tue, 13 Nov 2012, Lan Tianyu wrote:
> This patch is to create driver/usb/core/port.c and move usb port related
> code into it.
> @@ -1237,57 +1227,12 @@ static int hub_post_reset(struct usb_interface *intf)
> return 0;
> }
>
> -static void usb_port_device_release(struct device *dev)
>
From: "Jason J. Herne"
Force large capacity (> 0x blocks) drives to use READ/WRITE(16) instead
of READ/WRITE(10). Some(most/all?) USB enclosures do not like READ(10) commands
when a large capacity drive is installed. This issue was reported and discussed
here: http://marc.info/?l=linux-us
On Wed, 14 Nov 2012, Alan Stern wrote:
> This does not belong here; it belongs in your new port.c file. Maybe in
> drivers/usb/core/usb.h if necessary.
Better than usb.h would be to have a drivers/usb/core/hub.h file which
could contain stuff that has to be shared between hub.c and port.c but
On Wed, Nov 14, 2012 at 2:02 PM, Sebastian Andrzej Siewior
wrote:
> On Wed, Nov 14, 2012 at 12:55:13AM -0500, Jason J. Herne wrote:
>> }
>> }
>>
>> + /* Use read/write(16) for > 2TB disks */
>> + sdp->use_16_for_rw = (sdkp->capacity > 0x);
>
> The comment is poi
Hello.
On 15-11-2012 2:03, Jason J. Herne wrote:
From: "Jason J. Herne"
You have already posted Try #3. And preferrably, information about patch
version should be included with [PATCH] prefix like this [PATCH v4].
Force large capacity (> 0x blocks) drives to use READ/WRITE(16)
On Wed, Nov 14, 2012 at 5:22 PM, Sergei Shtylyov wrote:
> Hello.
>
>
> On 15-11-2012 2:03, Jason J. Herne wrote:
>
>> From: "Jason J. Herne"
>
>
> You have already posted Try #3. And preferrably, information about patch
> version should be included with [PATCH] prefix like this [PATCH v4].
>
>
Hi Greg,
As this serial includes both usb phy and usb core changes, can you
help to take over it? Both Felipe and Alan have added their
Acked-by. Thanks.
On Fri, Nov 09, 2012 at 09:44:41AM +0800, Peter Chen wrote:
>
> Signed-off-by: Peter Chen
> Acked-by: Felipe Balbi
> ---
--
Best Regards,
On Thu, Nov 15, 2012 at 11:30:22AM +0800, Peter Chen wrote:
> Hi Greg,
>
> As this serial includes both usb phy and usb core changes, can you
> help to take over it? Both Felipe and Alan have added their
> Acked-by. Thanks.
Ok, I'll queue them up in a day or so.
thanks,
greg k-h
--
To unsubscri
Hi,
On Wed, Nov 14, 2012 at 08:06:20PM -0500, Jason J. Herne wrote:
> On Wed, Nov 14, 2012 at 5:22 PM, Sergei Shtylyov wrote:
> > Hello.
> >
> >
> > On 15-11-2012 2:03, Jason J. Herne wrote:
> >
> >> From: "Jason J. Herne"
> >
> >
> > You have already posted Try #3. And preferrably, informatio
On Tue, Nov 13, 2012 at 02:25:59PM +0200, Alexander Shishkin wrote:
Alex, Thanks for review.
> > At new design, when role switch occurs, the gadget just calls
> > usb_gadget_vbus_disconnect/usb_gadget_vbus_connect as well as
> > reset controller, it will not free any device/gadget structure
>
>
88 matches
Mail list logo