Hi all,
On Thu, Nov 8, 2012 at 12:24 PM, Vivek Gautam wrote:
> Adding EHCI device tree node for Exynos5250 along with
> the device base adress and gpio line for vbus.
>
> Signed-off-by: Vivek Gautam
> Acked-by: Jingoo Han
> ---
> .../devicetree/bindings/usb/exynos-usb.txt | 25
> +++
Hi all,
On Thu, Nov 8, 2012 at 12:24 PM, Vivek Gautam wrote:
> Adding OHCI device tree node for Exynos5250 along with
> the device base address.
>
> Signed-off-by: Vivek Gautam
> Acked-by: Jingoo Han
> ---
> .../devicetree/bindings/usb/exynos-usb.txt | 15 +++
> arch/arm/
At Thu, 08 Nov 2012 08:31:35 +0100,
Daniel Mack wrote:
(snip)
> >> We can't simply stop both endpoints in the prepare callback.
> >
> > The new function doesn't stop the stream by itself but it just syncs
> > if the stream is being stopped beforehand. So, it's safe to call it
> > there.
> >
> >
Adding EHCI device tree node for Exynos5250 along with
the device base adress and gpio line for vbus.
Signed-off-by: Vivek Gautam
Acked-by: Jingoo Han
---
.../devicetree/bindings/usb/exynos-usb.txt | 25
arch/arm/boot/dts/exynos5250-smdk5250.dts |4 ++
Adding OHCI device tree node for Exynos5250 along with
the device base address.
Signed-off-by: Vivek Gautam
Acked-by: Jingoo Han
---
.../devicetree/bindings/usb/exynos-usb.txt | 15 +++
arch/arm/boot/dts/exynos5250.dtsi |6 ++
arch/arm/mach-exynos/
From: Wei Yongjun
Test for tegra and hcd in tegra_ehci_remove() look like potential
NULL pointer dereference, but in fact those tests are not needed,
so remove these pointless tests entirely.
Signed-off-by: Wei Yongjun
---
v1 -> v2: remove those tests entirely
---
drivers/usb/host/ehci-tegra.c
Changes from v1:
- Changed the device node name from 'dwc3' to 'usb@1200'.
- Added the documentation for device tree bindings for dwc3 controller.
Based on changes for USB 2.0:
'https://lists.ozlabs.org/pipermail/devicetree-discuss/2012-November/022046.html'
Tested with required driver DT p
Adding DWC3 device tree node for Exynos5250 along with the
device address and clock support needed for the controller.
Signed-off-by: Vivek Gautam
---
.../devicetree/bindings/usb/exynos-usb.txt | 14 +++
arch/arm/boot/dts/exynos5250.dtsi |6 +
arch/arm/
USB specs says that if an over-current is detected then a hub must switch off
all affected port, wait to cool down and then switch on.
There are few controllers, which does not follow it, and expects software
to switch off the port power.
This patch will add workaround for such controllers.
I th
If we do have endpoints named like "ep-a" then bEndpointAddress is
counted internally by the gadget framework.
If we do have endpoints named like "ep-1" then bEndpointAddress is
assigned from the digit after "ep-".
If we do have both, then it is likely that after we used up the
"generic" endpoints,
From: Fabio Estevam
Since commit c73cee7 (USB: EHCI: remove ehci_port_power() routine), the 'ehci'
variable is no longer used, so remove it and fix the following build warning:
drivers/usb/host/ehci-mxc.c:41:19: warning: unused variable 'ehci'
[-Wunused-variable]
Signed-off-by: Fabio Estevam
Julia,
On Thu, Nov 08, 2012 at 09:08:04AM +0100, Julia Lawall wrote:
> It's a false positive because check_warn_return does a return.
Right.
> But I wonder if there is a way that we can encourage people not to
> do things like that?
Well I suspect the memory leak bug 06a221be0 tries to fix migh
commit 380f0d2 (usb: dwc3: core: switch event
buffer allocation to devm_kzalloc()) was incomplete
leaving a trailing kfree(evt) in an error exit
path.
Fix this problem by removing the trailing kfree(evt).
Cc: Julia Lawall
Reported-by: Fengguang Wu
Signed-off-by: Felipe Balbi
---
this patch is
Hi,
On Wed, Nov 07, 2012 at 09:27:52PM -0500, David Miller wrote:
> From: Ian Coolidge
> Date: Wed, 7 Nov 2012 16:39:17 -0800
>
> > cdc_eem USB host driver and gadget driver both are broken in 1500 MTU
> > case while using 802.1Q VLANs. In both cases, this is due to the
> > assumption of standa
Hi,
On Wed, Nov 07, 2012 at 04:12:47PM -0500, Alan Stern wrote:
> This patch (as1630) cleans up a few minor items resulting from the
> split-up of the ehci-hcd driver:
>
> Remove the product_desc string from the ehci_driver_overrides
> structure. All drivers will use the generic "EHC
Hi,
(please, never top-post)
On Wed, Nov 07, 2012 at 02:14:00PM +0100, Dmytro Milinevskyy wrote:
> Unfortunately I have some issues with git send-email.
> I've attached the patch itself ..
I'll apply it like that this time, but try to figure out how to send
patches properly. We have some very he
Hi,
On Wed, Nov 07, 2012 at 07:23:49PM +0100, Sebastian Andrzej Siewior wrote:
> The setup request can be sent to an interface/endpoint or to the device
> itself. If it is sent to an interface then we forward it to the function
> that is mapped to that interface. The same is true if an endpoint is
Hi,
typo on $SUBJECT. s/infracture/infrastructure
On Wed, Nov 07, 2012 at 07:23:52PM +0100, Sebastian Andrzej Siewior wrote:
> This patch provides an infrastructure to register & unregister an USB
I guess it should 'a USB', not 'an USB'. Can some native speaker
confirm, please ?
IIRC it had som
Hi.
On Wed, Nov 07, 2012 at 07:23:53PM +0100, Sebastian Andrzej Siewior wrote:
missing commit log
> Signed-off-by: Sebastian Andrzej Siewior
> ---
> drivers/usb/gadget/Kconfig|4 +
> drivers/usb/gadget/Makefile |3 +
> drivers/usb/gadget/f_sourcesink.c | 193
> +
Hi,
On Wed, Nov 07, 2012 at 07:23:54PM +0100, Sebastian Andrzej Siewior wrote:
commit log.
> Signed-off-by: Sebastian Andrzej Siewior
[ snip ]
> @@ -129,10 +113,12 @@ static struct usb_otg_descriptor otg_descriptor = {
> .bmAttributes = USB_OTG_SRP | USB_OTG_HNP,
> };
>
> -co
On Wed, 7 Nov 2012, Jason J. Herne wrote:
>>> Most likely that's the answer. Of course, for a device to recognize
>>> READ(16) but not READ(10) is a violation of the SCSI spec.
>>>
I can confirm that the use of READ(10) instead of READ(16) is indeed
the problem here.
I hacked in some code that f
Linus Walleij writes:
> On Wed, Nov 7, 2012 at 12:28 AM, Bjørn Mork wrote:
>> Linus Walleij writes:
>
>>> So all MTP devices manufactured before that spec, and numerous produced
>>> after that spec came out, and several still being produced don't use the
>>> class code, i.e. they violate the spe
On Wed, Nov 07 2012, Sebastian Andrzej Siewior wrote:
> This patch provides an infrastructure to register & unregister an USB
> function. This allows to turn a function into a module and avoid the
> '#include "f_.*.c"' magic and we get a clear API / cut between the bare
> gadget and its functions.
From: Amardeep Rai
We used to get clk using con-id, but now we have device struct available for
these devices as they are probed using DT. And so must get clk using dev-id.
Signed-off-by: Amardeep Rai
Signed-off-by: Viresh Kumar
---
drivers/usb/host/ehci-spear.c | 13 +
drivers/us
This patch frees SPEAr ehci/ohci drivers from tension of freeing resources :)
devm_* derivatives of multiple routines are used while allocating resources,
which would be freed automatically by kernel.
Signed-off-by: Viresh Kumar
---
drivers/usb/host/ehci-spear.c | 37 +---
This patch (as1632b) fixes a bug in ehci-hcd. The USB core uses
urb->hcpriv to determine whether or not an URB is active; host
controller drivers are supposed to set this pointer to a non-NULL
value when an URB is queued. However ehci-hcd sets it to NULL for
isochronous URBs, which defeats the ch
On Thu, 8 Nov 2012, Felipe Balbi wrote:
> Hi,
>
> typo on $SUBJECT. s/infracture/infrastructure
>
> On Wed, Nov 07, 2012 at 07:23:52PM +0100, Sebastian Andrzej Siewior wrote:
> > This patch provides an infrastructure to register & unregister an USB
>
> I guess it should 'a USB', not 'an USB'. C
On Thu, 8 Nov 2012, Chen Peter-B29397 wrote:
> Hi Alan,
>
> Can you help add Ack of usb core related (3/4, 4/4) of this patches series,
> you have reivewed v4 patchset, if you can't find them, I can send again.
They look okay. You can add my Acked-by to both of those patches, for
the changes t
On Thu, 8 Nov 2012, Takashi Iwai wrote:
> At Thu, 08 Nov 2012 08:31:35 +0100,
> Daniel Mack wrote:
> (snip)
> > >> We can't simply stop both endpoints in the prepare callback.
> > >
> > > The new function doesn't stop the stream by itself but it just syncs
> > > if the stream is being stopped bef
At Thu, 8 Nov 2012 10:55:50 -0500 (EST),
Alan Stern wrote:
>
> On Thu, 8 Nov 2012, Takashi Iwai wrote:
>
> > At Thu, 08 Nov 2012 08:31:35 +0100,
> > Daniel Mack wrote:
> > (snip)
> > > >> We can't simply stop both endpoints in the prepare callback.
> > > >
> > > > The new function doesn't stop t
On Thu, 8 Nov 2012, Pratyush Anand wrote:
> USB specs says that if an over-current is detected then a hub must switch off
> all affected port, wait to cool down and then switch on.
>
> There are few controllers, which does not follow it, and expects software
> to switch off the port power.
Can y
On Thu, 8 Nov 2012, Wei Yongjun wrote:
> From: Wei Yongjun
>
> Test for tegra and hcd in tegra_ehci_remove() look like potential
> NULL pointer dereference, but in fact those tests are not needed,
> so remove these pointless tests entirely.
>
> Signed-off-by: Wei Yongjun
> ---
> v1 -> v2: remo
On Thu, 8 Nov 2012, Sebastian Andrzej Siewior wrote:
> If we do have endpoints named like "ep-a" then bEndpointAddress is
> counted internally by the gadget framework.
> If we do have endpoints named like "ep-1" then bEndpointAddress is
> assigned from the digit after "ep-".
> If we do have both,
On Thu, 8 Nov 2012, Felipe Balbi wrote:
> > Mark the *_overrides structures as __initdata.
>
> I just have one question here: What about all the ehci-*.c with their
> probe outside of .init.text ?
>
> $ git grep -e __devinit drivers/usb/host/ehci*.c
> drivers/usb/host/ehci-atmel.c:static int
On Thu, 8 Nov 2012, Fabio Estevam wrote:
> From: Fabio Estevam
>
> Since commit c73cee7 (USB: EHCI: remove ehci_port_power() routine), the 'ehci'
> variable is no longer used, so remove it and fix the following build warning:
>
> drivers/usb/host/ehci-mxc.c:41:19: warning: unused variable 'ehci
On 11/08/2012 03:53 PM, Michal Nazarewicz wrote:
The code looks promising, and definitely a step in right direction, but
I don't think this configuration structure is good solution for
ConfigFS.
Sure, many (most) functions have same static unstructured configuration
arguments which can be expres
On Thu, 8 Nov 2012, Jason J. Herne wrote:
> On Wed, 7 Nov 2012, Jason J. Herne wrote:
>
> >>> Most likely that's the answer. Of course, for a device to recognize
> >>> READ(16) but not READ(10) is a violation of the SCSI spec.
> >>>
>
> I can confirm that the use of READ(10) instead of READ(16)
On Thu, Nov 8, 2012 at 11:23 AM, Alan Stern wrote:
> I don't know how the ATA layer in Linux works. You'll have to ask
> someone else or figure it out yourself.
>
>> I know we get to sd_prep_fn even when the drive in connected directly
>> via Sata, just not
>> sure which READ is used. I could fin
On Thu, Nov 08, 2012 at 01:28:32PM +0330, A Sh wrote:
> what about xhci.ko?
The module got renamed from xhci.ko to xhci-hcd.ko in 2.6.34.
Sarah Sharp
>
>
> On Wed, Nov 7, 2012 at 10:09 PM, Sarah Sharp
> wrote:
>
> > On Wed, Nov 07, 2012 at 01:56:49PM +0330, A Sh wrote:
> > > 1. There is no xh
> https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1074169
>
>
> thinkpad edge 15 0319 model. ubuntu 12.10. tried on various kernels, only
> the play pause forward reverse(media keys) work, however brightness, sound,
> mute, wifi, etc keys do not work.
>
> xev | sed -n 's/^.*state \([0-9].*\),
Hello.
On 11/08/2012 07:05 PM, Alan Stern wrote:
>> USB specs says that if an over-current is detected then a hub must switch off
>> all affected port, wait to cool down and then switch on.
>> There are few controllers, which does not follow it, and expects software
>> to switch off the port pow
The Dell 5800 appears to be a simple rebrand of the Novatel E362.
Signed-off-by: Dan Williams
Cc: sta...@vger.kernel.org
---
drivers/usb/serial/option.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
index 5dee7d6..c25d3fd 100
Signed-off-by: Dan Williams
Cc: sta...@vger.kernel.org
---
drivers/usb/serial/option.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
index c25d3fd..edc64bb 100644
--- a/drivers/usb/serial/option.c
+++ b/drivers/usb/serial/option.c
On Thu, 8 Nov 2012, Sergei Shtylyov wrote:
> >> USB specs says that if an over-current is detected then a hub must switch
> >> off
> >> all affected port, wait to cool down and then switch on.
>
> >> There are few controllers, which does not follow it, and expects software
> >> to switch off the
On Thu, 8 Nov 2012, Jason J. Herne wrote:
> On Thu, Nov 8, 2012 at 11:23 AM, Alan Stern wrote:
> > I don't know how the ATA layer in Linux works. You'll have to ask
> > someone else or figure it out yourself.
> >
> >> I know we get to sd_prep_fn even when the drive in connected directly
> >> via
The Dell Wireless 5800 appears to be a Novatel E362 rebrand.
Signed-off-by: Dan Williams
Cc: sta...@vger.kernel.org
---
Greg: CC-ed to linux-usb@ for visibility but should go through davem
drivers/net/usb/cdc_ether.c | 15 +++
drivers/net/usb/qmi_wwan.c | 14 ++
2 files
Hi,
On Thu, Nov 08, 2012 at 11:11:37AM -0500, Alan Stern wrote:
> On Thu, 8 Nov 2012, Felipe Balbi wrote:
>
> > > Mark the *_overrides structures as __initdata.
> >
> > I just have one question here: What about all the ehci-*.c with their
> > probe outside of .init.text ?
> >
> > $ git grep -
On 11/08/2012 03:24 PM, Felipe Balbi wrote:
commit log.
added
| This patch converts the f_loopback file to the USB-function module.
Signed-off-by: Sebastian Andrzej Siewior
[ snip ]
@@ -129,10 +113,12 @@ static struct usb_otg_descriptor otg_descriptor = {
.bmAttributes =
On 11/08/2012 03:21 PM, Felipe Balbi wrote:
On Wed, Nov 07, 2012 at 07:23:53PM +0100, Sebastian Andrzej Siewior wrote:
missing commit log
added
|This patch converts the f_sourcesink file to the USB-function module.
|This patch also introduces a ss_check_param() function which checks if
|the c
On 11/08/2012 03:12 PM, Felipe Balbi wrote:
you need some rework on this commit log. Looks like there are a few
missing words here and there ;-)
usb/gadget: provide a wrapper around SourceSink's setup function
The setup request can be sent to an interface/endpoint or to the device
itself. If i
Hi,
On Tue, Nov 06, 2012 at 08:44:59PM +0530, Afzal Mohammed wrote:
> Hi Balbi,
>
> This is a resend of remaining changes to get am335x usb working. These
> were sent on 31 Oct with subject, "usb: musb: dsps: fixes for -rc.
there is no more time for this to reach -rc. Do we need it for v3.8
merg
Hello.
On 11/08/2012 08:58 PM, Alan Stern wrote:
USB specs says that if an over-current is detected then a hub must switch
off
all affected port, wait to cool down and then switch on.
There are few controllers, which does not follow it, and expects software
to switch of
the u_ether.c file has a global variable named the_dev which keeps a
pointer to the network device after it has been created via
gether_setup_name(). It is only used internally by u_ether. This patches
moves the variable to its users and passes it via the port.ioport where
it is saved later anyway.
On 11/08/2012 07:24 PM, Sebastian Andrzej Siewior wrote:
the u_ether.c file has a global variable named the_dev which keeps a
pointer to the network device after it has been created via
gether_setup_name(). It is only used internally by u_ether. This patches
moves the variable to its users and pa
On Tue, Nov 06, 2012 at 08:24:55PM +0530, Vivek Gautam wrote:
> Updating the names of usb-phy types to more generic names:
> USB_PHY_TYPE_DEIVCE & USB_PHY_TYPE_HOST; and further update its
> dependencies.
>
> Signed-off-by: Praveen Paneri
> Signed-off-by: Vivek Gautam
Kukjin, I need your ack on
Some devices (ex Nokia C7) simply don't respond at all when data is sent
to some of their USB interfaces. The data gets stuck in the TTYs queue
and sits there until close(2), which them blocks because closing_wait
defaults to 30 seconds (even though the fd is O_NONBLOCK). This is
rarely desired.
On Thu, Nov 08, 2012 at 12:45:21PM -0500, Joe Sweeney wrote:
> > https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1074169
> >
> >
> > thinkpad edge 15 0319 model. ubuntu 12.10. tried on various kernels, only
> > the play pause forward reverse(media keys) work, however brightness, sound,
> > mut
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 08/11/12 19:47, Dan Williams wrote:
> Some devices (ex Nokia C7) simply don't respond at all when data is
> sent to some of their USB interfaces. The data gets stuck in the
> TTYs queue and sits there until close(2), which them blocks because
> clo
On Thu, Nov 8, 2012 at 3:06 PM, Felipe Balbi wrote:
> Hi,
>
> (please, never top-post)
>
got it!
> On Wed, Nov 07, 2012 at 02:14:00PM +0100, Dmytro Milinevskyy wrote:
>> Unfortunately I have some issues with git send-email.
>> I've attached the patch itself ..
>
> I'll apply it like that this tim
On Thursday 08 November 2012 12:47:41 Dan Williams wrote:
> Some devices (ex Nokia C7) simply don't respond at all when data is sent
> to some of their USB interfaces. The data gets stuck in the TTYs queue
> and sits there until close(2), which them blocks because closing_wait
> defaults to 30 sec
Hi,
On Thu, Nov 08, 2012 at 08:07:57PM +0100, Dmytro Milinevskyy wrote:
> > On Wed, Nov 07, 2012 at 02:14:00PM +0100, Dmytro Milinevskyy wrote:
> >> Unfortunately I have some issues with git send-email.
> >> I've attached the patch itself ..
> >
> > I'll apply it like that this time, but try to fi
From: Felipe Balbi
Date: Thu, 8 Nov 2012 15:37:36 +0200
> Hi,
>
> On Wed, Nov 07, 2012 at 09:27:52PM -0500, David Miller wrote:
>> From: Ian Coolidge
>> Date: Wed, 7 Nov 2012 16:39:17 -0800
>>
>> > cdc_eem USB host driver and gadget driver both are broken in 1500 MTU
>> > case while using 802
Dan Williams writes:
> The Dell Wireless 5800 appears to be a Novatel E362 rebrand.
>
> Signed-off-by: Dan Williams
> Cc: sta...@vger.kernel.org
Acked-by: Bjørn Mork
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
Mo
> On 11/08/2012 03:53 PM, Michal Nazarewicz wrote:
>> The code looks promising, and definitely a step in right direction, but
>> I don't think this configuration structure is good solution for
>> ConfigFS.
>>
>> Sure, many (most) functions have same static unstructured configuration
>> arguments wh
The math in the link status reporting is wrong. The link state is in
bits 8:5 of the hub port status word, which is split across a char
array. Currently, if the link state is 0xb (Loopback mode), the status
char array will look something like this:
status[0] = 0110
status[1] = 0001
Th
This minor patch creates a more stricter conditional for the Z1 sytems for
applying
the Compliance Mode Patch, this to avoid the quirk to be applied to models that
contain a "Z1" in their dmi product string but are different from Z1 systems.
Signed-off-by: Alexis R. Cortes
---
drivers/usb/host/
Ulrich Eckhardt writes:
>
> Am 24.10.2012 22:18, schrieb Bjorn Helgaas:
> > On Tue, Oct 23, 2012 at 11:14 AM, Ulrich Eckhardt uli-eckhardt.de>
wrote:
> >> Am 23.10.2012 01:40, schrieb Sarah Sharp:
> >>> On Sun, Oct 21, 2012 at 06:03:24PM +0200, Ulrich Eckhardt wrote:
> >>
> I have tested i
On 11/8/2012 9:35 PM, Alan Stern wrote:
On Thu, 8 Nov 2012, Pratyush Anand wrote:
USB specs says that if an over-current is detected then a hub must switch off
all affected port, wait to cool down and then switch on.
There are few controllers, which does not follow it, and expects software
to
The real reason causes mx23 fail are:
- Calling mxs_phy_hw_init(mxs_phy) again at connection
- Error connect/disconnect nodity at hub.c
The coming patch will fix above two problems, Mike Thompson
tested his hardware works OK after commented out this delay
setting.
This reverts commit 363366cf61c
As phy is working, re-init phy may cause unexpected results
Signed-off-by: Peter Chen
Acked-by: Felipe Balbi
---
drivers/usb/otg/mxs-phy.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/usb/otg/mxs-phy.c b/drivers/usb/otg/mxs-phy.c
index c1a67cb..5b09f33 100644
At commit 925aa46ba963a4da6d8ee6ab1d04a02ffa8db62b, Richard Zhao
adds the phy notification callback
when port change occurs. In fact, this phy notification should
be added according to below rules:
1. Only set HW_USBPHY_CTRL.ENHOSTDISCONDETECT
during high speed host mode.
2. Do not set HW_USBPHY_
The old parameter "port" is useless for phy notify, as one usb
phy is only for one usb port. New parameter "speed" stands for
the device's speed which is on the port, this "speed" parameter
is needed at some platforms which will do some phy operations
according to device's speed.
Signed-off-by: Pe
>
> This patchset adds fully tested otg id switch function and
> vbus connect/disconnect detection for chipidea driver.
> The mainly design of id/vbus handling follows msm otg driver.
> I hope the msm usb maintainer can have a look of this patchset,
> and give some comments, and move the whol
Hi Balbi,
On Thu, Nov 08, 2012 at 23:47:08, Balbi, Felipe wrote:
> On Tue, Nov 06, 2012 at 08:44:59PM +0530, Afzal Mohammed wrote:
> > This is a resend of remaining changes to get am335x usb working. These
> > were sent on 31 Oct with subject, "usb: musb: dsps: fixes for -rc.
>
> there is no mor
From: Maulik Mankad
Date: Fri, 9 Nov 2012 12:28:17 +0530
> We don't need memset() here.
> May be command[2] = {0}; offset[2] = {0}; crc[4] = {0}; is enough.
The compiler can see this an will eliminate the unnecessary
clears.
So it's better to use memset and make the code much clearer
and easier
75 matches
Mail list logo
