[PATCH V2 1/2] usb/xhci: release xhci->lock during turning on/off usb port's acpi power resource and checking the existence of port's power resource

2012-10-15 Thread Lan Tianyu
When setting usb port's acpi power resource, there will be some xhci hub requests. This will cause dead lock since xhci->lock has been held before setting acpi power resource in the xhci_hub_control(). The usb_acpi_power_manageable() function might fall into sleep so release xhci->lock before in

[PATCH V2 2/2] usb/xhci: Remove (__force__ __u16) before assigning DeviceRemovable and assign directly.

2012-10-15 Thread Lan Tianyu
Struct usb_hub_descriptor.ss.DeviceRemovable has been defined as __le16 and (__force__ __u16) doesn't need. Signed-off-by: Lan Tianyu --- drivers/usb/host/xhci-hub.c |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/usb/host/xhci-hub.c b/drivers/usb/host/xhci-hu

Re: [balbi-usb:merge-result-for-greg 59/99] webcam.c:(.text+0x14afec): undefined reference to `config_ep_by_speed'

2012-10-15 Thread Sebastian Andrzej Siewior
On 10/12/2012 06:39 PM, Fengguang Wu wrote: Hi Sebastian, Hi Fengguang, FYI, kernel build failed on tree: git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git merge-result-for-greg head: 23953bde3e4d6aa8780dc054f6ad9882ac63f4f4 commit: 721e2e91945bc2520d57d795dfe1b502ecec567c [59

[PATCH RESEND V2] usb: musb: am35xx: drop spurious unplugging a device

2012-10-15 Thread Stefano Babic
On AM3517, tx and rx interrupt are detected together with the disconnect event. This generates a kernel panic in musb_interrupt, because rx / tx are handled after disconnect. This issue was seen on a Technexion's TAM3517 SOM. Unplugging a device, tx / rx interrupts together with disconnect are dete

Re: [RFC PATCH 3/3] USB: forbid memory allocation with I/O during bus reset if storage interface exits

2012-10-15 Thread Oliver Neukum
On Monday 15 October 2012 13:14:19 Ming Lei wrote: > If one storage interface exists in the device, memory allocation > with GFP_KERNEL during usb_device_reset() might trigger I/O transfer > on the storage interface itself and cause deadlock because the > 'us->dev_mutex' is held in .pre_reset() and

Re: [PATCH] usb: acm: fix the computation of the number of data bits

2012-10-15 Thread Oliver Neukum
On Sunday 14 October 2012 00:29:24 Nicolas Boullis wrote: > From: Nicolas Boullis > > The current code assumes that CSIZE is 060, which appears to be > wrong on some arches (such as powerpc). > > Signed-off-by: Nicolas Boullis Acked-by: Oliver Neukum -- To unsubscribe from this list: se

Re: [PATCH 01/12] usbnet: introduce usbnet 3 command helpers

2012-10-15 Thread Oliver Neukum
On Friday 12 October 2012 11:29:49 Alan Stern wrote: > On Fri, 12 Oct 2012, Oliver Neukum wrote: > > First we have workqueues. bas-gigaset is a good example. > > The driver kills a scheduled work in pre_reset(). If this is done > > synchronously > > the driver may need to wait for a memory alloca

[PATCH 0/2] USB-audio disconnection race fixes (v2)

2012-10-15 Thread Takashi Iwai
Hi, this is a series of fixes for the disconnection races in USB-audio. A couple of new patches to improve and cover more points since the previous patch set. Takashi -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org Mor

[PATCH 1/4] ALSA: PCM: Fix some races at disconnection

2012-10-15 Thread Takashi Iwai
Fix races at PCM disconnection: - while a PCM device is being opened or closed - while the PCM state is being changed without lock in prepare, hw_params, hw_free ops Signed-off-by: Takashi Iwai --- sound/core/pcm.c| 7 ++- sound/core/pcm_native.c | 16 2 files cha

[PATCH 2/4] ALSA: usb-audio: Fix races at disconnection (v2)

2012-10-15 Thread Takashi Iwai
Close some races at disconnection of a USB audio device by adding the chip->shutdown_mutex and chip->shutdown check at appropriate places. The spots to put bandaids are: - PCM prepare, hw_params and hw_free - where the usb device is accessed for communication or get speed, in mixer.c and others;

[PATCH 3/4] ALSA: usb-audio: Use rwsem for disconnect protection

2012-10-15 Thread Takashi Iwai
Replace mutex with rwsem for codec->shutdown protection so that concurrent accesses are allowed. Also add the protection to snd_usb_autosuspend() and snd_usb_autoresume(), too. Signed-off-by: Takashi Iwai --- sound/usb/card.c | 12 sound/usb/mixer.c| 12 ++-- sound/

[PATCH 4/4] ALSA: usb-audio: Fix races at disconnection in mixer_quirks.c

2012-10-15 Thread Takashi Iwai
Similar like the previous commit, cover with chip->shutdown_rwsem and chip->shutdown checks. Signed-off-by: Takashi Iwai --- sound/usb/mixer_quirks.c | 58 ++-- 1 file changed, 51 insertions(+), 7 deletions(-) diff --git a/sound/usb/mixer_quirks.c b/s

Re: FTDI USB-to-UART converters and tcdrain()

2012-10-15 Thread Jarkko Huijts
On Sat, 2012-10-13 at 17:33 +0200, Johan Hovold wrote: > Thanks for the patch Jarkko. Your solution is nice, but I think it could > implemented in a slightly better way. > > For starters, the subdrivers really shouldn't be poking around in the > generic driver's implementation details unless reall

Re: [RFC PATCH 3/3] USB: forbid memory allocation with I/O during bus reset if storage interface exits

2012-10-15 Thread Ming Lei
On Mon, Oct 15, 2012 at 5:34 PM, Oliver Neukum wrote: > > I think limiting this to devices which have a storage device is not > productive. What if you are using iSCSI or nbd? In the long run You mean other non-mass storage or non-uas usb interfaces may be involved in iSCSI or nbd? If not, the pa

Re: [PATCH 1/3] usb: dwc3: Add the suspend/resume functionality

2012-10-15 Thread Felipe Balbi
On Fri, Oct 12, 2012 at 07:24:33PM +0530, Vikas Sajjan wrote: > Hi kishon, > > On 12 October 2012 16:27, kishon wrote: > > Hi, > > > > > > On Wednesday 10 October 2012 07:35 PM, Vikas C Sajjan wrote: > >> > >> From: Vikas Sajjan > >> > >> Adding the suspend and resume funtionality to DWC3 core.

Re: [PATCH] usb: renesas_usbhs: return -EINVAL if scatter/gather type DMA

2012-10-15 Thread Felipe Balbi
Hi, On Wed, Oct 10, 2012 at 07:18:45PM -0700, Kuninori Morimoto wrote: > renesas_usbhs can't handle scatter/gather type DMA. > Thus, return -EINVAL is better than WARNING() on mod_gadget > > Signed-off-by: Kuninori Morimoto > --- > drivers/usb/renesas_usbhs/mod_gadget.c |3 ++- > 1 file cha

Re: [PATCH] usb: renesas_usbhs: fixup __usbhs_for_each_pipe 1st pos

2012-10-15 Thread Felipe Balbi
Hi, On Thu, Oct 11, 2012 at 07:02:07PM -0700, Kuninori Morimoto wrote: > 1st pos of __usbhs_for_each_pipe() was wrong. > Each pipe were pipe0, pipe2, pipe3 ... > This patch modifies it. > patch looks correct but I'm sure you can do much better on this commit log. cheers > Signed-off-by: Kunino

Re: [PATCH] usb: renesas_usbhs: fixup interrupt status clear method

2012-10-15 Thread Felipe Balbi
On Thu, Oct 11, 2012 at 09:49:38PM -0700, Kuninori Morimoto wrote: > When interrupt happened, renesas_usbhs driver gets irq status > by usbhs_status_get_each_irq(), and cleared all status by using 0. > But, this method is incorrect, > since extra interrupt might occur between them. > This patch cle

Re: [PATCH v2 1/3] usb: dwc3: Add the suspend/resume functionality

2012-10-15 Thread Felipe Balbi
On Sat, Oct 13, 2012 at 06:40:23PM +0530, Vikas Sajjan wrote: > Adding the suspend and resume funtionality to DWC3 core. typo -> functionality. Also this is quite lame as a commit log. I'm sure you can do better than this. > Signed-off-by: Abhilash Kesavan > Signed-off-by: Vikas C Sajjan > CC:

Re: [PATCH v2 2/3] usb: xhci: Add the suspend/resume functionality

2012-10-15 Thread Felipe Balbi
On Sat, Oct 13, 2012 at 06:40:24PM +0530, Vikas Sajjan wrote: > Adding the suspend and resume functionality for the XHCI driver please do better on your commit log. > Signed-off-by: Abhilash Kesavan > Signed-off-by: Vikas C Sajjan > CC: Doug Anderson > --- > drivers/usb/host/xhci-plat.c | 3

Re: [PATCH v2 1/3] usb: dwc3: Add the suspend/resume functionality

2012-10-15 Thread Felipe Balbi
On Sat, Oct 13, 2012 at 06:40:23PM +0530, Vikas Sajjan wrote: > Adding the suspend and resume funtionality to DWC3 core. > > Signed-off-by: Abhilash Kesavan > Signed-off-by: Vikas C Sajjan > CC: Doug Anderson > --- > drivers/usb/dwc3/core.c | 54 > +++

Re: [PATCH v2 3/3] exynos5: usb: dwc3: Add the suspend/resume functionality

2012-10-15 Thread Felipe Balbi
Hi, On Sat, Oct 13, 2012 at 06:40:25PM +0530, Vikas Sajjan wrote: > Adding the suspend and resume functionality to exynos dwc3 driver better commit log. > Signed-off-by: Abhilash Kesavan > Signed-off-by: Vikas C Sajjan > CC: Doug Anderson > --- > drivers/usb/dwc3/dwc3-exynos.c | 39 +++

Re: [PATCH] USB: DWC3: Shutdown usb_phy when removing the device

2012-10-15 Thread Felipe Balbi
On Sat, Oct 13, 2012 at 07:20:18PM +0530, Vivek Gautam wrote: > We do usb_phy_init() while doing core_init() in probe, > so adding usb_phy_shutdown() when we do core_exit() > while removing the device. > > Signed-off-by: Vivek Gautam I believe this needs to be sent to stable too for v3.6, right

Re: [PATCH 1/1] musb : remove generic_interrupt and have all drivers define the isr on their own. Remove some unneeded CONFIG_SOC_OMAP_3430 instances

2012-10-15 Thread Felipe Balbi
Hi, On Mon, Oct 08, 2012 at 09:34:51AM -0700, Tony Lindgren wrote: > * Philippe De Swert [121004 10:00]: > > This patch is based on the discussion of a previous patch to fix an issue > > where the omap2430 musb driver is not working for N9/N950. > > > > Moving all the interrupt handling to the d

Re: [PATCH] usb: renesas_usbhs: add DMAEngine support on mod_host

2012-10-15 Thread Felipe Balbi
Hi, On Wed, Oct 10, 2012 at 07:17:58PM -0700, Kuninori Morimoto wrote: > This patch enabled dma mapping, and used dma transfer handler > on mod_host > > Signed-off-by: Kuninori Morimoto > --- > Felipe > > I sent some patches before, and I guess it will go to v3.8 branch. > please let me know if

Re: [PATCH] usb:musb: Dequeue urbs on device unplug

2012-10-15 Thread Felipe Balbi
Hi, On Wed, Oct 10, 2012 at 10:06:03AM +0530, Virupax Sadashivpetimath wrote: > Flush queued urbs on receiving device disconnect > interrupt. This is required for successful disconnect > and successive enumeration of the device. > > In a failure case khubd hangs on usb-storage thread > for comple

Re: [RFC PATCH 3/3] USB: forbid memory allocation with I/O during bus reset if storage interface exits

2012-10-15 Thread Oliver Neukum
On Monday 15 October 2012 20:06:36 Ming Lei wrote: > On Mon, Oct 15, 2012 at 5:34 PM, Oliver Neukum wrote: > > > > I think limiting this to devices which have a storage device is not > > productive. What if you are using iSCSI or nbd? In the long run > > You mean other non-mass storage or non-uas

Re: [PATCH] usb: renesas_usbhs: gadget: add usb_gadget_ops :: pullup support

2012-10-15 Thread Felipe Balbi
On Thu, Oct 11, 2012 at 09:48:30PM -0700, Kuninori Morimoto wrote: no commit log, please resend with something properly written up ;-) > Signed-off-by: Kuninori Morimoto > --- > drivers/usb/renesas_usbhs/common.c |5 + > drivers/usb/renesas_usbhs/common.h |1 + > drivers/usb

Re: [PATCH v3 0/7] usb: dwc3-omap: add dt support

2012-10-15 Thread Felipe Balbi
Hi, On Mon, Oct 08, 2012 at 02:53:49PM +0530, Kishon Vijay Abraham I wrote: > This patch series adds dt support to dwc3 core and fixes few minor > stuff in dwc3-omap glue to get dwc3 working. > > While at that it also uses *of_platform* to create the child device > (dwc3-core) and fixes to use ru

[PATCH RESEND] usb: gadget: lpc32xx_udc: Disable setup request error

2012-10-15 Thread Alexandre Pereira da Silva
This message is an debugging message. It's useful for finding protocol details but it's not necessarily an error. Signed-off-by: Alexandre Pereira da Silva --- drivers/usb/gadget/lpc32xx_udc.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/lpc32xx_udc.c

[PATCH RESEND] usb: gadget: lpc32xx_udc: Fix compatibility with STOTG04

2012-10-15 Thread Alexandre Pereira da Silva
The STOTG04 is an replacement for ISP1301. Most of the registers on STOTG04 are the same as on ISP1301, but the register ISP1301_I2C_OTG_CONTROL_2 (address 0x10) doesn't exist on the ST part. This is a work around for this by using the interrupt source register that should behave the same on both

Re: [PATCH RESEND] usb: gadget: lpc32xx_udc: Fix compatibility with STOTG04

2012-10-15 Thread Felipe Balbi
Hi, On Mon, Oct 15, 2012 at 09:47:35AM -0300, Alexandre Pereira da Silva wrote: > The STOTG04 is an replacement for ISP1301. > > Most of the registers on STOTG04 are the same as on ISP1301, but the > register ISP1301_I2C_OTG_CONTROL_2 (address 0x10) doesn't exist on the > ST part. > > This is a

Re: [RFC PATCH 3/3] USB: forbid memory allocation with I/O during bus reset if storage interface exits

2012-10-15 Thread Ming Lei
On Mon, Oct 15, 2012 at 8:30 PM, Oliver Neukum wrote: > > All network devices? Good point, but I am wondering if there are guys who would like to bring up iSCSI over usb network dongle, which should be very slow at least with high speed. For super speed device, looks there are few network dongl

Re: [PATCH] USB: DWC3: Shutdown usb_phy when removing the device

2012-10-15 Thread Vivek Gautam
Hi Felipe, On Mon, Oct 15, 2012 at 5:44 PM, Felipe Balbi wrote: > On Sat, Oct 13, 2012 at 07:20:18PM +0530, Vivek Gautam wrote: >> We do usb_phy_init() while doing core_init() in probe, >> so adding usb_phy_shutdown() when we do core_exit() >> while removing the device. >> >> Signed-off-by: Vivek

[PATCH v4 0/7] usb: dwc3-omap: add dt support

2012-10-15 Thread Kishon Vijay Abraham I
This patch series adds dt support to dwc3 core and fixes few minor stuff in dwc3-omap glue to get dwc3 working. While at that it also uses *of_platform* to create the child device (dwc3-core) and fixes to use runtime API's to enable clock and write to SYSCONFIG register. Changes from v3: * rebase

[PATCH v4 1/7] usb: dwc3-omap: use device_for_each_child to handle child removal

2012-10-15 Thread Kishon Vijay Abraham I
Used device_for_each_child() to handle child device (dwc3 core) removal during devexit of dwc3 omap. Signed-off-by: Kishon Vijay Abraham I --- drivers/usb/dwc3/dwc3-omap.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/usb/dwc3/dwc3-omap.c b/drivers/usb

Re: [PATCH] USB: DWC3: Shutdown usb_phy when removing the device

2012-10-15 Thread Felipe Balbi
On Mon, Oct 15, 2012 at 06:56:13PM +0530, Vivek Gautam wrote: > Hi Felipe, > > On Mon, Oct 15, 2012 at 5:44 PM, Felipe Balbi wrote: > > On Sat, Oct 13, 2012 at 07:20:18PM +0530, Vivek Gautam wrote: > >> We do usb_phy_init() while doing core_init() in probe, > >> so adding usb_phy_shutdown() when

[PATCH v4 2/7] usb: dwc3-omap: use of_platform API to create dwc3 core pdev

2012-10-15 Thread Kishon Vijay Abraham I
Used of_platform_populate() to populate dwc3 core platform_device from device tree data. Since now the allocation of unique device id is handled by of_*, removed the call to dwc3_get_device_id. Signed-off-by: Kishon Vijay Abraham I --- drivers/usb/dwc3/dwc3-omap.c | 50 +---

[PATCH v4 6/7] usb: dwc3-omap: Minor fixes to get dt working

2012-10-15 Thread Kishon Vijay Abraham I
Includes few minor fixes in dwc3-omap like populating the compatible string in a correct way, extracting the utmi-mode property properly and changing the index of get_irq since irq of core is removed from hwmod entry. Also updated the documentation with dwc3-omap device tree binding information. S

[PATCH v4 3/7] usb: dwc3-omap: use runtime API's to enable clocks

2012-10-15 Thread Kishon Vijay Abraham I
Before accessing any register, runtime API's should be invoked to enable the clocks. runtime API's are added here to prevent abort during register access. Signed-off-by: Kishon Vijay Abraham I --- drivers/usb/dwc3/dwc3-omap.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/dri

[PATCH v4 5/7] usb: dwc3-omap: Add an API to write to dwc mailbox

2012-10-15 Thread Kishon Vijay Abraham I
Add an API in the omap glue layer to write to the mailbox register which can be used by comparator driver(twl). To pass the detection of the attached device (signified by VBUS, ID) to the dwc3 core, dwc3 glue has to write to the mailbox regiter. Signed-off-by: Kishon Vijay Abraham I --- drivers/

[PATCH v4 4/7] usb: dwc3-omap: Remove explicit writes to SYSCONFIG register

2012-10-15 Thread Kishon Vijay Abraham I
The runtime API's takes care of setting the SYSCONFIG register with appropriate values. Hence explicit writes to SYSCONFIG register is removed. Signed-off-by: Kishon Vijay Abraham I --- drivers/usb/dwc3/dwc3-omap.c | 26 -- 1 file changed, 26 deletions(-) diff --git a/

[PATCH v4 7/7] usb: dwc3: core: add dt support for dwc3 core

2012-10-15 Thread Kishon Vijay Abraham I
Added dwc3 support for dwc3 core and update the documentation with device tree binding information. Signed-off-by: Kishon Vijay Abraham I --- Documentation/devicetree/bindings/usb/dwc3.txt | 23 +++ drivers/usb/dwc3/core.c| 14 -- 2 fil

Re: [PATCH] usb: phy: samsung: Introducing usb phy driver for hsotg

2012-10-15 Thread Felipe Balbi
On Fri, Oct 12, 2012 at 03:45:34PM +0530, Praveen Paneri wrote: > platform_set_drvdata() required for driver's remove function, so adding > it back. > > From v6: > Added TODO for phy bindings with controller > Dropped platform_set_drvdata() from driver probe > > This driver uses usb_phy interface

Re: [PATCH v7] Enable USB peripheral mode on dm365 EVM

2012-10-15 Thread Felipe Balbi
Hi, On Thu, Oct 11, 2012 at 06:34:34PM +0200, Constantine Shulyupin wrote: > From: Constantine Shulyupin > > Sets USB PHY clock source to 24 MHz clock. > > Tested with OTG configuration, usb gadget g_zero on DM365 EVM connected to PC. > > To active the patch need to call davinci_setup_usb from

Re: PROBLEM: BUG: null pointer dereference when using garmin USB connection with 3.6.1 kernel

2012-10-15 Thread Johan Hovold
On Tue, Oct 09, 2012 at 01:05:46PM -0400, Alan Stern wrote: > On Tue, 9 Oct 2012, Greg KH wrote: > > > Ugh, that "simple" patch has turned up more bugs in drivers than > > anything I know of in recent history. > > It would be a good idea for someone to audit all the serial drivers. > The basic

Re: [PATCH] usb: phy: samsung: Introducing usb phy driver for hsotg

2012-10-15 Thread Kyungmin Park
+ Tomasz Figa, Acked-by: Kyungmin Park On Mon, Oct 15, 2012 at 10:28 PM, Felipe Balbi wrote: > On Fri, Oct 12, 2012 at 03:45:34PM +0530, Praveen Paneri wrote: >> platform_set_drvdata() required for driver's remove function, so adding >> it back. >> >> From v6: >> Added TODO for phy bindings wit

[PATCH 2/2] USB: pl2303: fix port-data memory leak

2012-10-15 Thread Johan Hovold
Fix port-data memory leak by allocating and freeing port data in port_probe/remove rather than in attach/release, and by introducing serial private data to store the device type which is interface rather than port specific. Since commit 0998d0631001288 (device-core: Ensure drvdata = NULL when no d

[PATCH 1/2] USB: cp210x: fix port-data memory leak

2012-10-15 Thread Johan Hovold
Fix port data memory leak by replacing port private data with serial private data. Since commit 0998d0631001288 (device-core: Ensure drvdata = NULL when no driver is bound) the port private data is no longer freed at release. The private data is used to store the control interface number, but as

Re: [PATCH] USB: DWC3: Shutdown usb_phy when removing the device

2012-10-15 Thread Vivek Gautam
Hi, On Mon, Oct 15, 2012 at 6:54 PM, Felipe Balbi wrote: > On Mon, Oct 15, 2012 at 06:56:13PM +0530, Vivek Gautam wrote: >> Hi Felipe, >> >> On Mon, Oct 15, 2012 at 5:44 PM, Felipe Balbi wrote: >> > On Sat, Oct 13, 2012 at 07:20:18PM +0530, Vivek Gautam wrote: >> >> We do usb_phy_init() while do

[PATCH 1/2] USB: cp210x: fix whitespace issues

2012-10-15 Thread Johan Hovold
Fix missing and superfluous whitespace. Fix misplaced brackets. Fix indentation. Signed-off-by: Johan Hovold --- drivers/usb/serial/cp210x.c | 31 ++- 1 file changed, 14 insertions(+), 17 deletions(-) diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp21

[PATCH 2/2] USB: cp210x: remove driver version

2012-10-15 Thread Johan Hovold
Remove driver version as it is the kernel version that matters. Signed-off-by: Johan Hovold --- drivers/usb/serial/cp210x.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c index 1264173..176d9d1 100644 --- a/drive

Re: [RFC PATCH 2/3] PM / Runtime: force memory allocation with no I/O during runtime_resume callbcack

2012-10-15 Thread Alan Stern
On Mon, 15 Oct 2012, Ming Lei wrote: > This patch applies the introduces tsk_memalloc_forbid_io() and > tsk_memalloc_allow_io() to force memory allocation with no I/O > during runtime_resume callback. > > Cc: Alan Stern > Cc: Oliver Neukum > Cc: Rafael J. Wysocki > Signed-off-by: Ming Lei > -

Re: [PATCH RESEND] usb: gadget: lpc32xx_udc: Fix compatibility with STOTG04

2012-10-15 Thread Roland Stigge
On 10/15/2012 02:47 PM, Alexandre Pereira da Silva wrote: > The STOTG04 is an replacement for ISP1301. > > Most of the registers on STOTG04 are the same as on ISP1301, but the > register ISP1301_I2C_OTG_CONTROL_2 (address 0x10) doesn't exist on the > ST part. > > This is a work around for this by

Re: [PATCH RESEND] usb: gadget: lpc32xx_udc: Disable setup request error

2012-10-15 Thread Roland Stigge
On 10/15/2012 02:47 PM, Alexandre Pereira da Silva wrote: > This message is an debugging message. It's useful for finding protocol > details but it's not necessarily an error. > > Signed-off-by: Alexandre Pereira da Silva Acked-by: Roland Stigge Was also confirmed by the NXP developers a while

Re: [PATCH 01/12] usbnet: introduce usbnet 3 command helpers

2012-10-15 Thread Alan Stern
On Mon, 15 Oct 2012, Oliver Neukum wrote: > On Friday 12 October 2012 11:29:49 Alan Stern wrote: > > On Fri, 12 Oct 2012, Oliver Neukum wrote: > > > > First we have workqueues. bas-gigaset is a good example. > > > The driver kills a scheduled work in pre_reset(). If this is done > > > synchronou

Re: [PATCH RESEND] usb: gadget: lpc32xx_udc: Fix compatibility with STOTG04

2012-10-15 Thread Roland Stigge
On 10/15/2012 03:01 PM, Felipe Balbi wrote: > On Mon, Oct 15, 2012 at 09:47:35AM -0300, Alexandre Pereira da > Silva wrote: >> The STOTG04 is an replacement for ISP1301. >> >> Most of the registers on STOTG04 are the same as on ISP1301, but >> the register ISP1301_I2C_OTG_CONTROL_2 (address 0x10)

Re: [RFC PATCH 1/3] mm: teach mm by current context info to not do I/O during memory allocation

2012-10-15 Thread Alan Stern
On Mon, 15 Oct 2012, Ming Lei wrote: > This patch introduces PF_MEMALLOC_NOIO on process flag('flags' field of > 'struct task_struct'), so that the flag can be set by one task > to avoid doing I/O inside memory allocation in the task's context. > > The patch trys to solve one deadlock problem cau

Re: [RFC PATCH 2/3] PM / Runtime: force memory allocation with no I/O during runtime_resume callbcack

2012-10-15 Thread Ming Lei
On Mon, Oct 15, 2012 at 10:14 PM, Alan Stern wrote: > On Mon, 15 Oct 2012, Ming Lei wrote: > >> This patch applies the introduces tsk_memalloc_forbid_io() and >> tsk_memalloc_allow_io() to force memory allocation with no I/O >> during runtime_resume callback. >> >> Cc: Alan Stern >> Cc: Oliver Ne

Re: [RFC PATCH 1/3] mm: teach mm by current context info to not do I/O during memory allocation

2012-10-15 Thread Ming Lei
On Mon, Oct 15, 2012 at 10:33 PM, Alan Stern wrote: > > Instead of allow/forbid, the API should be save/restore (like > local_irq_save and local_irq_restore). This makes nesting much easier. Good point. > Also, do we really the "p" argument? This is not at all likely to be > used with any task

problem with Roseweil eusb3 enclosure

2012-10-15 Thread covici
Hi. I am using linux-3.6.2 kernel with gentoo patches and I have been having problems with the usb3 enclosure made by Roseweil. If I boot with the drive plugged in, in this kernel, I cannot really boot because it spits out continuous error messages -- something about code -71 maybe cannot allocat

Re: [PATCH 1/2] ehci: fix Lucid nohandoff pci quirk to be more generic with BIOS versions

2012-10-15 Thread Anisse Astier
On Tue, 9 Oct 2012 13:00:23 -0400 (EDT), Alan Stern wrote : > On Tue, 9 Oct 2012, Anisse Astier wrote: > > > > How about matching any BIOS from Lucid, regardless of the board name? > > > > I was just being conservative. Lucid is a common english word, and you > > never know how another company

Re: [RFC PATCH 1/3] mm: teach mm by current context info to not do I/O during memory allocation

2012-10-15 Thread Minchan Kim
On Mon, Oct 15, 2012 at 01:14:17PM +0800, Ming Lei wrote: > This patch introduces PF_MEMALLOC_NOIO on process flag('flags' field of > 'struct task_struct'), so that the flag can be set by one task > to avoid doing I/O inside memory allocation in the task's context. > > The patch trys to solve one

Re: [RFC PATCH 3/3] USB: forbid memory allocation with I/O during bus reset if storage interface exits

2012-10-15 Thread Oliver Neukum
On Monday 15 October 2012 21:21:13 Ming Lei wrote: > On Mon, Oct 15, 2012 at 8:30 PM, Oliver Neukum wrote: > > > > > All network devices? > > Good point, but I am wondering if there are guys who would like to > bring up iSCSI over usb network dongle, which should be LTE, UMTS. Those people may

[PATCH 1/3] USB: ark3116: fix NULL-pointer dereference

2012-10-15 Thread Johan Hovold
Fix NULL-pointer dereference at release by replacing attach and release with port_probe and port_remove. Since commit 0998d0631001288 (device-core: Ensure drvdata = NULL when no driver is bound) the port private data is NULL when release is called. Compile-only tested. Cc: Signed-off-by: Johan

[PATCH 3/3] USB: cyberjack: fix port-data memory leak

2012-10-15 Thread Johan Hovold
Fix port-data memory leak by replacing attach and release with port_probe and port_remove. Since commit 0998d0631001288 (device-core: Ensure drvdata = NULL when no driver is bound) the port private data is no longer freed at release as it is no longer accessible. Note that the write waitqueue was

[PATCH 2/3] USB: belkin_sa: fix port-data memory leak

2012-10-15 Thread Johan Hovold
Fix port-data memory leak by replacing attach and release with port_probe and port_remove. Since commit 0998d0631001288 (device-core: Ensure drvdata = NULL when no driver is bound) the port private data is no longer freed at release as it is no longer accessible. Note that the write waitqueue was

Re: [balbi-usb:merge-result-for-greg 59/99] webcam.c:(.text+0x14afec): undefined reference to `config_ep_by_speed'

2012-10-15 Thread Greg KH
On Mon, Oct 15, 2012 at 09:49:20AM +0200, Sebastian Andrzej Siewior wrote: > On 10/12/2012 06:39 PM, Fengguang Wu wrote: > >Hi Sebastian, > > Hi Fengguang, > > >FYI, kernel build failed on > > > >tree: git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git > >merge-result-for-greg > >head

Re: [RFC PATCH 3/3] USB: forbid memory allocation with I/O during bus reset if storage interface exits

2012-10-15 Thread Greg Kroah-Hartman
On Mon, Oct 15, 2012 at 09:21:13PM +0800, Ming Lei wrote: > On Mon, Oct 15, 2012 at 8:30 PM, Oliver Neukum wrote: > > > > > All network devices? > > Good point, but I am wondering if there are guys who would like to > bring up iSCSI over usb network dongle, which should be > very slow at least w

Re: [RFC PATCH 3/3] USB: forbid memory allocation with I/O during bus reset if storage interface exits

2012-10-15 Thread Greg Kroah-Hartman
On Mon, Oct 15, 2012 at 08:06:36PM +0800, Ming Lei wrote: > On Mon, Oct 15, 2012 at 5:34 PM, Oliver Neukum wrote: > > > > I think limiting this to devices which have a storage device is not > > productive. What if you are using iSCSI or nbd? In the long run > > You mean other non-mass storage or

[PATCH] rename ccg init and exit functions to conventional names

2012-10-15 Thread Constantine Shulyupin
From: Constantine Shulyupin Previous names of init and exit functions "init" and "cleanup" are unconventional and are not friendly for source navigation with tags. New names "ccg_init" and "ccg_exit" are conveninal and source navigation friendly. Signed-off-by: Constantine Shulyupin --- driv

Re: Endpoint is not halted

2012-10-15 Thread Sarah Sharp
On Mon, Oct 15, 2012 at 11:28:34AM +0530, ankit patel wrote: > Hi Sarah, Hi Ankit, thanks for the bug report. >We have found some problems during inserting device. It shows the error > like > >- [ 85.694152] xhci_hcd :01:00.0: Endpoint 0x84 not halted, >refusing to reset.

Re: Possible bug: xhci driver prevents hibernation

2012-10-15 Thread Sarah Sharp
On Sat, Oct 13, 2012 at 03:27:00PM +0200, Sergio Callegari wrote: > Dear Sarah Sharp, > > please take my apologize in advance if this message should have > been sent elsewhere rather than your email. > From the 'Reporting bugs' doc I got the feeling that bugs should be > reported to subsystem

usbserial & ftdi_sio problem

2012-10-15 Thread Mostafa Kassem
Greetings, I am having a problem with usbserial and ftdi_sio kernel loadable modules. I am working on an embedded board using RHEL 6.0. The board has 2 FTDI chips each with quad serial interface for a total of 8 serial ports. In addition, we have a WiFi module that behaves as a USB to Serial conv

Usb Bugs

2012-10-15 Thread Nick Krause
Hey Linux Usb Forum , Do you have any bugs or work that a Linux kernel newbie can do?  Nick  -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.

Re: Usb Bugs

2012-10-15 Thread Greg KH
On Mon, Oct 15, 2012 at 05:09:12PM +, Nick Krause wrote: > > Hey Linux Usb Forum , > Do you have any bugs or work that a Linux kernel > newbie can do?  Do all of your USB devices work perfectly on Linux? If not, I recommend working on that, otherwise it might be hard to find something to wor

Re: usb audio race at disconnect time

2012-10-15 Thread Matthieu CASTET
Hi Takashi, Takashi Iwai a écrit : > At Fri, 12 Oct 2012 17:42:19 +0200, > Matthieu CASTET wrote: >> Hi, >> >> >> Takashi Iwai a écrit : >>> [Added Daniel and Clemens in the loop] >>> >>> >>> I don't think this is needed. >>> >>> So... the below is a quick hack I did without testing at all. >>> Ho

xhci_hcd and Canon Lide 110 not playing well together

2012-10-15 Thread Holger Freyther
Hi, I have some severe issues with USB on a new system. This is an Acer Aspire S5 (i7, Ivybridge) and the scanner can be mostly classified as non working. Symptoms: 1.) Start a scan application (e.g. simple-scan) 2.) Scan a page 3.) Exit the app 4.) Start a scan application (e.g. simple-scan) 5.)

Re: usbserial & ftdi_sio problem

2012-10-15 Thread Greg KH
On Mon, Oct 15, 2012 at 01:15:05PM -0400, Mostafa Kassem wrote: > Greetings, > > I am having a problem with usbserial and ftdi_sio kernel loadable modules. > > I am working on an embedded board using RHEL 6.0. Wait right there. If you are using RHEL, you need to get support from Red Hat for it,

[PATCH REPOST] usb: host: tegra remove include of

2012-10-15 Thread Stephen Warren
From: Stephen Warren Almost nothing from this file is used, and the file will hopefully be deleted soon. Copy the tiny portions that are used directly into ehci-tegra.c. I believe that Venu Byravarasu is working on cleaning up our USB driver, and those cleanups will remove the need for these cons

[PATCH REPOST] usb: phy: tegra remove include of

2012-10-15 Thread Stephen Warren
From: Stephen Warren Almost nothing from this file is used, and the file will hopefully be deleted soon. Copy the tiny portions that are used directly into tegra_usb_phy.c. I believe that Venu Byravarasu is working on cleaning up our USB driver, and those cleanups will remove the need for these c

Re: usbserial & ftdi_sio problem

2012-10-15 Thread Greg KH
On Mon, Oct 15, 2012 at 11:11:26AM -0700, Greg KH wrote: > On Mon, Oct 15, 2012 at 01:15:05PM -0400, Mostafa Kassem wrote: > > Greetings, > > > > I am having a problem with usbserial and ftdi_sio kernel loadable modules. > > > > I am working on an embedded board using RHEL 6.0. > > Wait right th

Re: xhci_hcd and Canon Lide 110 not playing well together

2012-10-15 Thread Alan Stern
On Mon, 15 Oct 2012, Holger Freyther wrote: > Hi, > > I have some severe issues with USB on a new system. This is > an Acer Aspire S5 (i7, Ivybridge) and the scanner can be mostly > classified as non working. > > Symptoms: > 1.) Start a scan application (e.g. simple-scan) > 2.) Scan a page > 3.)

Re: usb audio race at disconnect time

2012-10-15 Thread Takashi Iwai
At Mon, 15 Oct 2012 19:41:40 +0200, Matthieu CASTET wrote: > > Hi Takashi, > > Takashi Iwai a écrit : > > At Fri, 12 Oct 2012 17:42:19 +0200, > > Matthieu CASTET wrote: > >> Hi, > >> > >> > >> Takashi Iwai a écrit : > >>> [Added Daniel and Clemens in the loop] > >>> > >>> > >>> I don't think this

Re: xhci_hcd and Canon Lide 110 not playing well together

2012-10-15 Thread Holger Freyther
Alan Stern writes: > > What is the bugzilla report number? it is #48801. > It's notable that the pcap file does not show any data being sent from > the scanner to the computer, only from the computer to the scanner. Did I use usbmom/wireshark incorrectly? > The necessary support isn't

Re: [balbi-usb:merge-result-for-greg 59/99] webcam.c:(.text+0x14afec): undefined reference to `config_ep_by_speed'

2012-10-15 Thread Felipe Balbi
Hi, On Mon, Oct 15, 2012 at 09:29:14AM -0700, Greg KH wrote: > On Mon, Oct 15, 2012 at 09:49:20AM +0200, Sebastian Andrzej Siewior wrote: > > On 10/12/2012 06:39 PM, Fengguang Wu wrote: > > >Hi Sebastian, > > > > Hi Fengguang, > > > > >FYI, kernel build failed on > > > > > >tree: git://git.ker

Re: [PATCH REPOST] usb: phy: tegra remove include of

2012-10-15 Thread Felipe Balbi
hi, On Mon, Oct 15, 2012 at 12:16:36PM -0600, Stephen Warren wrote: > From: Stephen Warren > > Almost nothing from this file is used, and the file will hopefully be > deleted soon. Copy the tiny portions that are used directly into > tegra_usb_phy.c. I believe that Venu Byravarasu is working on

Re: Linux xHCI driver problems (reset ep)

2012-10-15 Thread Sarah Sharp
On Sat, Oct 13, 2012 at 12:18:57PM -0400, Alan Stern wrote: > On Fri, 12 Oct 2012, Yuliya T wrote: > > > Hi Alan, > > > > Thank you for the suggestion. We independently ended up with the same > > workaround, but still weren't happy with it. The problem is we don't > > want to relinquish access

Re: xhci_hcd and Canon Lide 110 not playing well together

2012-10-15 Thread Holger Freyther
Holger Freyther writes: > > Debian unstable switched to libusbx but kept the package name at > libusb. I have tested this with version 1.0.12.Okay, I see that there > has been some usb 3.0 changes in 1.0.13 and 1.0.14 and I am going to > test again. I have tested with 38e6eb86b2 (two commits a

Re: usbserial & ftdi_sio problem

2012-10-15 Thread Mostafa Kassem
On Mon, Oct 15, 2012 at 2:18 PM, Greg KH wrote: > On Mon, Oct 15, 2012 at 11:11:26AM -0700, Greg KH wrote: >> On Mon, Oct 15, 2012 at 01:15:05PM -0400, Mostafa Kassem wrote: >> > Greetings, >> > >> > I am having a problem with usbserial and ftdi_sio kernel loadable modules. >> > >> > I am working

Re: xhci_hcd and Canon Lide 110 not playing well together

2012-10-15 Thread Alan Stern
On Mon, 15 Oct 2012, Holger Freyther wrote: > Holger Freyther writes: > > > > > > Debian unstable switched to libusbx but kept the package name at > > libusb. I have tested this with version 1.0.12.Okay, I see that there > > has been some usb 3.0 changes in 1.0.13 and 1.0.14 and I am going to

Re: Linux xHCI driver problems (reset ep)

2012-10-15 Thread Alan Stern
On Mon, 15 Oct 2012, Sarah Sharp wrote: > I double checked, and calling usb_set_interface for the same alternate > setting that is currently installed will cause the xHCI driver to drop > and re-add the current endpoints. This should cause the toggle to be > reset for the endpoints. > > I suppos

uhci irq race before term_td is allocated

2012-10-15 Thread Don Zickus
Hi Alan, I am seeing an odd panic with uhci when a 160 cpu box panics and starts running a kdump kernel (which is the same exact image as the boot kernel) for our RHEL-6 (2.6.32) kernel. Now I understand 2.6.32 is not something upstream supports. However, my question is what is expected to happe

Re: [PATCH REPOST] usb: phy: tegra remove include of

2012-10-15 Thread Stephen Warren
On 10/15/2012 01:22 PM, Felipe Balbi wrote: > hi, > > On Mon, Oct 15, 2012 at 12:16:36PM -0600, Stephen Warren wrote: >> From: Stephen Warren >> >> Almost nothing from this file is used, and the file will >> hopefully be deleted soon. Copy the tiny portions that are used >> directly into tegra_u

musb/musb_dsps.c:533]: (error) Buffer is accessed out of bounds

2012-10-15 Thread David Binderman
hello there, I just ran the static analyser cppcheck over the source code of the linux kernel version 3.7-rc1 It said [linux-3.7-rc1/drivers/usb/musb/musb_dsps.c:533]: (error) Buffer is accessed out of bounds The source code is sprintf(res_name, "port%d-mode", id); but char res

Re: uhci irq race before term_td is allocated

2012-10-15 Thread Alan Stern
On Mon, 15 Oct 2012, Don Zickus wrote: > Hi Alan, > > I am seeing an odd panic with uhci when a 160 cpu box panics and starts > running a kdump kernel (which is the same exact image as the boot kernel) > for our RHEL-6 (2.6.32) kernel. Now I understand 2.6.32 is not something > upstream supports

Re: usbserial & ftdi_sio problem

2012-10-15 Thread Peter Stuge
Mostafa Kassem wrote: > the Wifi module is this one from connectone: > http://www.connectone.com/?page_id=233 This may be the dumbest USB wifi module I have seen. Have you already developed a software stack which depends on the proprietary vendor protocol that they call AT+i? If no, I would sugg

[PATCH] usb: acm: fix the computation of the number of data bits

2012-10-15 Thread Nicolas Boullis
From: Nicolas Boullis The current code assumes that CSIZE is 060, which appears to be wrong on some arches (such as powerpc). Signed-off-by: Nicolas Boullis Acked-by: Oliver Neukum --- diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c index 981f213..194fa8b 100644 ---

Re: usbserial & ftdi_sio problem

2012-10-15 Thread Greg KH
On Mon, Oct 15, 2012 at 11:47:23PM +0200, Peter Stuge wrote: > Mostafa Kassem wrote: > > the Wifi module is this one from connectone: > > http://www.connectone.com/?page_id=233 > > This may be the dumbest USB wifi module I have seen. > > Have you already developed a software stack which depends o

Re: usbserial & ftdi_sio problem

2012-10-15 Thread Peter Stuge
Greg KH wrote: > But, if Mostafa is stuck at RHEL 6, there's nothing that we can do > here to help out at all, sorry. Maybe he can help test a driver on an up-to-date kernel.org release, and then perhaps he can ask RH to backport the driver. It should also not be very much effort. > Mostafa, can

  1   2   >