Aleksander Morgado writes:
> Foxconn-branded Novatel E396, Gobi3k modem.
>
> Cc: Dan Williams
> Cc: Bjørn Mork
> Cc: Ben Chan
> Signed-off-by: Aleksander Morgado
> ---
> drivers/net/usb/qmi_wwan.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/n
On 08/29/2012 08:55 AM, Thomas Knauth wrote:
Now I'm looking for a switch to enable UAS. As far as I understand the
code in tcm_usb_gadget.c, BOT is the hard-coded default, right? In
usbg_setup you test for USBG_IS_BOT and bail out with an error if the
flag is not set. Would this be the place to
On 08/28/2012 11:45 PM, Michal Nazarewicz wrote:
+#define USB_GADGET_COMPOSITE_OPTIONS() \
+ static struct usb_composite_overwrite coverwrite; \
I would probably use something longer for the variable name, but that's
just me. :)
What do you
On 08/28/2012 11:47 PM, Michal Nazarewicz wrote:
--- a/include/linux/usb/composite.h
+++ b/include/linux/usb/composite.h
@@ -248,6 +248,12 @@ int usb_add_config(struct usb_composite_dev *,
void usb_remove_config(struct usb_composite_dev *,
struct usb_configuration *);
+/* prede
On 08/28/2012 11:54 PM, Michal Nazarewicz wrote:
--- a/include/linux/usb/composite.h
+++ b/include/linux/usb/composite.h
@@ -398,6 +398,7 @@ struct usb_composite_overwrite {
u16 idVendor;
u16 idProduct;
u16 bcdDevice;
+ char*iSerialNumber;
There was
>> Now I'm looking for a switch to enable UAS. As far as I understand the
>> code in tcm_usb_gadget.c, BOT is the hard-coded default, right? In
>> usbg_setup you test for USBG_IS_BOT and bail out with an error if the
>> flag is not set. Would this be the place to add another if-then-else
>> branch
On 08/29/2012 09:36 AM, Thomas Knauth wrote:
Ah, yes, that worked. Except for the fact that the usb3380 does not
support streams :( I just found that out browsing the device's data
book ... The syslog also contains warnings/errors mentioning streams
... so much for that.
The driver does not sup
Richard Zhao writes:
> i.MX usb controllers shares non-core registers, which may include
> SoC specific controls. We take it as a usbmisc device and usbmisc
> driver set operations needed by ci13xxx_imx driver.
>
> For example, Sabrelite board has bad over-current design, we can
> usbmisc to disa
>> Ah, yes, that worked. Except for the fact that the usb3380 does not
>> support streams :( I just found that out browsing the device's data
>> book ... The syslog also contains warnings/errors mentioning streams
>> ... so much for that.
>
>
> The driver does not support usb3 streams or the hardwa
Richard Zhao writes:
> On Tue, Aug 28, 2012 at 11:29:35AM +0300, Alexander Shishkin wrote:
>> Richard Zhao writes:
>>
>> > States in gadget are not needed any more, set it to zero.
>>
>> It's generally a good practice to mention in the commit message what is
>> it that you are fixing with this
On 08/29/2012 10:00 AM, Thomas Knauth wrote:
I'm afraid my kernel/driver hacking skills are not evolved enough to
do that. As a an alternative to BOT/UAS I'm thinking about some
rudimentary support to transfer blobs of data over USB. Don't know if
this will eventually be faster without the suppor
Richard Zhao writes:
> On Tue, Aug 28, 2012 at 11:38:23AM +0300, Alexander Shishkin wrote:
>> Richard Zhao writes:
>>
>> > One role failed, but the other role will possiblly still work.
>> > For example, when udc start failed, if plug in a host device,
>> > it works.
>>
>> If you're a host dev
On Wed, Aug 29, 2012 at 10:50:08AM +0300, Alexander Shishkin wrote:
> Richard Zhao writes:
>
> > i.MX usb controllers shares non-core registers, which may include
> > SoC specific controls. We take it as a usbmisc device and usbmisc
> > driver set operations needed by ci13xxx_imx driver.
> >
> >
On Wed, Aug 29, 2012 at 10:50:08AM +0300, Alexander Shishkin wrote:
> Richard Zhao writes:
>
> > i.MX usb controllers shares non-core registers, which may include
> > SoC specific controls. We take it as a usbmisc device and usbmisc
> > driver set operations needed by ci13xxx_imx driver.
> >
> >
On Wed, Aug 29, 2012 at 11:03:48AM +0300, Alexander Shishkin wrote:
> Richard Zhao writes:
>
> > On Tue, Aug 28, 2012 at 11:29:35AM +0300, Alexander Shishkin wrote:
> >> Richard Zhao writes:
> >>
> >> > States in gadget are not needed any more, set it to zero.
> >>
> >> It's generally a good p
On Wed, Aug 29, 2012 at 11:10:33AM +0300, Alexander Shishkin wrote:
> Richard Zhao writes:
>
> > On Tue, Aug 28, 2012 at 11:38:23AM +0300, Alexander Shishkin wrote:
> >> Richard Zhao writes:
> >>
> >> > One role failed, but the other role will possiblly still work.
> >> > For example, when udc
Richard Zhao writes:
> On Wed, Aug 29, 2012 at 11:03:48AM +0300, Alexander Shishkin wrote:
>> Richard Zhao writes:
>>
>> > On Tue, Aug 28, 2012 at 11:29:35AM +0300, Alexander Shishkin wrote:
>> >> Richard Zhao writes:
>> >>
>> >> > States in gadget are not needed any more, set it to zero.
>>
Richard Zhao writes:
> On Wed, Aug 29, 2012 at 11:10:33AM +0300, Alexander Shishkin wrote:
>> Richard Zhao writes:
>>
>> > On Tue, Aug 28, 2012 at 11:38:23AM +0300, Alexander Shishkin wrote:
>> >> Richard Zhao writes:
>> >>
>> >> > One role failed, but the other role will possiblly still work
If the number of ports present on the SoC/board is not the maximum
and that the platform data is not filled with all data, there is
an easy way to mess the PIO setup for this interface.
This quick fix addresses mis-configuration in USB host platform data
that is common in at91 boards since commit 0
Sascha Hauer writes:
> On Wed, Aug 29, 2012 at 10:50:08AM +0300, Alexander Shishkin wrote:
>> Richard Zhao writes:
>>
>> > i.MX usb controllers shares non-core registers, which may include
>> > SoC specific controls. We take it as a usbmisc device and usbmisc
>> > driver set operations needed b
On Wed, Aug 29, 2012 at 12:44:40PM +0300, Alexander Shishkin wrote:
> Richard Zhao writes:
>
> > On Wed, Aug 29, 2012 at 11:03:48AM +0300, Alexander Shishkin wrote:
> >> Richard Zhao writes:
> >>
> >> > On Tue, Aug 28, 2012 at 11:29:35AM +0300, Alexander Shishkin wrote:
> >> >> Richard Zhao wr
On Wed, Aug 29, 2012 at 12:48:15PM +0300, Alexander Shishkin wrote:
> Richard Zhao writes:
>
> > On Wed, Aug 29, 2012 at 11:10:33AM +0300, Alexander Shishkin wrote:
> >> Richard Zhao writes:
> >>
> >> > On Tue, Aug 28, 2012 at 11:38:23AM +0300, Alexander Shishkin wrote:
> >> >> Richard Zhao wr
On Wed, Aug 29, 2012 at 01:18:10PM +0300, Alexander Shishkin wrote:
> Sascha Hauer writes:
>
> > On Wed, Aug 29, 2012 at 10:50:08AM +0300, Alexander Shishkin wrote:
> >> Richard Zhao writes:
> >>
> >> > i.MX usb controllers shares non-core registers, which may include
> >> > SoC specific contro
On Wed, Aug 29, 2012 at 01:18:10PM +0300, Alexander Shishkin wrote:
> Sascha Hauer writes:
>
> > On Wed, Aug 29, 2012 at 10:50:08AM +0300, Alexander Shishkin wrote:
> >> Richard Zhao writes:
> >>
> >> > i.MX usb controllers shares non-core registers, which may include
> >> > SoC specific contro
> On 08/28/2012 11:45 PM, Michal Nazarewicz wrote:
>>> +#define USB_GADGET_COMPOSITE_OPTIONS()
>>> \
>>> + static struct usb_composite_overwrite coverwrite; \
>>
>> I would probably use something longer for the variable name, but that's
>> just m
>>> --- a/include/linux/usb/composite.h
>>> +++ b/include/linux/usb/composite.h
>>> @@ -398,6 +398,7 @@ struct usb_composite_overwrite {
>>> u16 idVendor;
>>> u16 idProduct;
>>> u16 bcdDevice;
>>> + char*iSerialNumber;
> On 08/28/2012 11:54 PM, Michal Nazarewicz wrote
Hello Joel,
On Monday, August 20, 2012 8:00 AM Joel Becker wrote:
> I think what you want here is a symlink. Create a directory high in
> the tree called 'ready' or 'available', and when you want to lock the
> device in place, symlink it into that directory. This will pin the item.
> Yo
On 08/29/2012 01:37 PM, Michal Nazarewicz wrote:
On 08/28/2012 11:45 PM, Michal Nazarewicz wrote:
+#define USB_GADGET_COMPOSITE_OPTIONS() \
+ static struct usb_composite_overwrite coverwrite; \
I would probably use something longer for the va
hi all:
I saw there are 2 trbs about bandwidth as below:
#define TRB_GET_BW 21
#define TRB_BANDWIDTH_EVENT 35
Would any one tell me where I can see driver use these 2 trbs for
bandwidth checking,
since I cannot grep the implementation in the driver.
--
Thanks for your help,
--
To u
On Tue, 28 Aug 2012, Gary E. Miller wrote:
> Yo Alan!
>
> On Tue, 28 Aug 2012 14:56:49 -0400 (EDT)
> Alan Stern wrote:
>
> > On Tue, 28 Aug 2012, Gary E. Miller wrote:
>
> > > I am now getting a lot of these in my logs:
> > > ehci_hcd :00:12.2: detected XactErr len 0/6 retry 28
>
> > They
On Wed, 29 Aug 2012, megha dey wrote:
> I am hitting a dead end at the rpm_resume function as opposed to
> rpm_suspend in the commit ID specified.Below is a diff of the
> file,wherein I have moved the wake_up_all() location,just above the
> failure case (schedule()) and this solves the issue.I wou
于 2012/8/27 23:00, Lan Tianyu 写道:
于 2012/8/27 22:20, Alan Stern 写道:
On Mon, 27 Aug 2012, Lan Tianyu wrote:
Now I see the problem. The code you're adding to ehci-hub.c relies on
the hub driver knowing about the root hub's ports beforehand. So
you've got a circular dependency:
ehci-hub.c
On Wed, 29 Aug 2012, Lan Tianyu wrote:
> Hi Alan:
> Do you have some advices on this patch? I current have two proposals.
> 1) Add a new routine to get port connection before port's device being
> created and being bound with ACPI. The routine first need to get port's acpi
> handle and
On Wed, 29 Aug 2012, megha dey wrote:
> I am hitting a dead end at the rpm_resume function as opposed to
> rpm_suspend in the commit ID specified.Below is a diff of the
> file,wherein I have moved the wake_up_all() location,just above the
> failure case (schedule()) and this solves the issue.I wou
Take g_ncm for instance. It enqueues a few BULK URBs on receive side and
an INTR URB. Now we remove the g_ncm module. This starts with
usb_gadget_disconnect() which disables the UDC. Now lets say the timer
expires and dummy_timer() is invoked. It can't find a pair between the
UDC endpoint and URB's
On Sat, Aug 25, 2012 at 08:20:46AM +0530, Pratyush Anand wrote:
> On 8/24/2012 7:01 PM, Pratyush Anand wrote:
> >On 8/24/2012 5:10 PM, Pratyush ANAND wrote:
> >>If xfernotready is received and there is no request in request_list then
> >>PENDING flag must be set, so that next request in ep queue is
Hi,
On Wed, Aug 29, 2012 at 10:00:30AM +0200, Thomas Knauth wrote:
> >> Ah, yes, that worked. Except for the fact that the usb3380 does not
> >> support streams :( I just found that out browsing the device's data
> >> book ... The syslog also contains warnings/errors mentioning streams
> >> ... so
Hi,
On Wed, Aug 29, 2012 at 10:49:58AM +0900, Chanho Park wrote:
> This patch changes default value of maxburst to 1. When a connection is
> established to highspeed, the maxburst is set to 0. So, we need to check and
> change default value of the maxburst before setting up burst size of ep.
>
>
On 8/29/2012 9:40 PM, Felipe Balbi wrote:
>Discard 5/5. I will send another.
All the others are fine then ? I'll start queueing once v3.6-rc4 is out.
Two patches were not working correctly with webcam. As off now I am
doing something else. Will test non working patches next week.
Just to a
On Wed, Aug 29, 2012 at 09:54:10PM +0530, Pratyush Anand wrote:
> On 8/29/2012 9:40 PM, Felipe Balbi wrote:
> >>>Discard 5/5. I will send another.
> >All the others are fine then ? I'll start queueing once v3.6-rc4 is out.
>
>
> Two patches were not working correctly with webcam. As off now I am
V2 removes patches which were not working with webcam gadget.
Pratyush Anand (3):
usb/dwc3:Move udelay within stop_active_transfe
usb/dwc3: Fix missed isoc
usb/dwc3: Fix Pedning isoc
drivers/usb/dwc3/core.h |1 -
drivers/usb/dwc3/gadget.c | 89 --
There are two reasons to generate missed isoc.
1. when the host does not poll for all the data.
2. because of application-side delays that prevent all the data from
being transferred in programmed microframe.
Current code was able to handle first case only. Now we take following
approach to hand
We need udelay(100) after every END TRANSFER, so it is better to keep it
within dwc3_stop_active_transfer.
Signed-off-by: Pratyush Anand
---
drivers/usb/dwc3/gadget.c | 42 +-
1 files changed, 21 insertions(+), 21 deletions(-)
diff --git a/drivers/usb/d
If xfernotready is received and there is no request in request_list then
PENDING flag must be set, so that next request in ep queue is executed.
In case of isoc transfer, if xfornotready is alreday elapsed and even first
request has not been queued to request_list, then issue END TRANSFER, so that
On 8/29/2012 9:53 PM, Felipe Balbi wrote:
On Wed, Aug 29, 2012 at 09:54:10PM +0530, Pratyush Anand wrote:
On 8/29/2012 9:40 PM, Felipe Balbi wrote:
Discard 5/5. I will send another.
All the others are fine then ? I'll start queueing once v3.6-rc4 is out.
Two patches were not working correct
On Wed, 29 Aug 2012, Sebastian Andrzej Siewior wrote:
> Take g_ncm for instance. It enqueues a few BULK URBs on receive side and
> an INTR URB.
You mean the host driver enqueues these things, not g_ncm, right?
> Now we remove the g_ncm module. This starts with
> usb_gadget_disconnect() which di
On Wed, Aug 29, 2012 at 12:31:15PM -0400, Alan Stern wrote:
> On Wed, 29 Aug 2012, Sebastian Andrzej Siewior wrote:
>
> > Take g_ncm for instance. It enqueues a few BULK URBs on receive side and
> > an INTR URB.
>
> You mean the host driver enqueues these things, not g_ncm, right?
Exactly.
> >
This series creates the libcomposite and is based on "Towords libcomposite, v2"
It addresses the review comments of "create libcomposite".
The numbers were gather from "size" on each gadget before and after series.
textdatabss dec diff filename
old
This patch moves USB_BUFSIZ into global header file as
USB_COMP_EP0_BUFSIZ. There is currently only one user (f_sourcesink)
besides composite which need it. Ideally f_sourcesink would have its
own ep0 buffer. Lets keep it that way it was for now.
Acked-by: Michal Nazarewicz
Signed-off-by: Sebasti
This patch adds epautoconf.c into libcomposite and updates all gadgets.
Acked-by: Michal Nazarewicz
Signed-off-by: Sebastian Andrzej Siewior
---
drivers/staging/ccg/ccg.c |1 -
drivers/usb/gadget/Makefile |2 +-
drivers/usb/gadget/acm_ms.c |1 -
drivers/usb
epautoconf has two global variables which count the endpoint number of
last assigned endpoint.
This patch removes the global variable and keeps it as per (UDC) gadget.
While here, the ifdef is removed and now the in and outpoint are
enumerated unconditionally. The dwc3 for instance supports 32 endp
Using usb_string_ids_tab() instead multiple calls of usb_string_id()
seems to be handy. It also allows to add string without many checks.
Acked-by: Michal Nazarewicz
Signed-off-by: Sebastian Andrzej Siewior
---
drivers/usb/gadget/acm_ms.c | 12 +++-
drivers/usb/gadget/audio.c | 12
This is a partly revert of 4fffd6e5 ("usb: gadget: composite: make
module parameters accessible at runtime").
It is not possible to change the VID or other property for a gadget
right now. This change has been made for Anrdoid gadget which has this
functionality in its copy of the file. This functi
The next step is to move composite.c into the library. Since the Android
gadget has its composite.c copy this make makes sure both symbols do not
clash by making the symbols static. The unused functions are removed.
This patch also provides a local copy of composite.h because the
prototype is now d
there is no read user of bufsiz, its content is available via
USB_COMP_EP0_BUFSIZ. Remove it.
Acked-by: Michal Nazarewicz
Signed-off-by: Sebastian Andrzej Siewior
---
drivers/usb/gadget/composite.c |1 -
include/linux/usb/composite.h |2 --
2 files changed, 3 deletions(-)
diff --git a
This patch aims to be simple. It removes #include usbstribgs.c line from each
gadget and creates libcomposite.ko which has only one member, that is
usbstribgs.c.
Acked-by: Michal Nazarewicz
Signed-off-by: Sebastian Andrzej Siewior
---
drivers/staging/ccg/Kconfig |1 +
drivers/stagin
This patch moves config.c into libcomposite and updates all gadgets.
Acked-by: Michal Nazarewicz
Signed-off-by: Sebastian Andrzej Siewior
---
drivers/staging/ccg/ccg.c |1 -
drivers/usb/gadget/Makefile |2 +-
drivers/usb/gadget/acm_ms.c |1 -
drivers/usb/ga
On 08/28/12 22:17, Venu Byravarasu wrote:
Stephen Warren wrote at Tuesday, August 28, 2012 7:37 PM:
On 08/28/2012 02:32 AM, Venu Byravarasu wrote:
In order to keep up with the USB driver files organization,
moving USB phy driver from mach-tegra to drivers/USB directory.
Signed-off-by: Venu Byr
On Wed, 29 Aug 2012, Sebastian Andrzej Siewior wrote:
> > > The BULK URBs usually don't make a scene. They re-submit the complete
> > > queue length in BH so we have a little time in between. The INTR URB is
> > > more evil because usbnet's intr_complete() causes to re-submitt it
> > > immediately
Hello.
On 08/29/2012 08:30 PM, Pratyush Anand wrote:
> If xfernotready is received and there is no request in request_list then
> PENDING flag must be set, so that next request in ep queue is executed.
> In case of isoc transfer, if xfornotready is alreday elapsed and even first
> request has no
This patch pushes the iSerialNumber module argument from composite into
each gadget. Once the user uses the module paramter, the string is
overwritten with the final value.
Signed-off-by: Sebastian Andrzej Siewior
---
drivers/usb/gadget/composite.c| 20 +---
drivers/usb/gad
The struct usb_composite_driver members iProduct, iSerial and
iManufacturer can be entered directly via the string array. There is no
need for them to appear here.
Signed-off-by: Sebastian Andrzej Siewior
---
drivers/usb/gadget/composite.c| 29 +++--
drivers/usb/gad
This was broken in 2e87edf49 ("usb: gadget: make g_printer use
composite").
The USB-strings were not setup properly and were not used. No function
was added which results in an empty USB config.
While fixing this, the interface number is now auto generated and not
hard coded to 0.
Signed-off-by: S
Some gadgets provide custom entry here. Some may override it with an
etntry that is also created by composite if there was no value sumbitted
at all.
This patch removes all "custom manufacturer" strings which are the same
as these which are created by composite. Then it moves the creation of
the de
This patch moves the module options idVendor, idProduct and bcdDevice
from composite.c into each gadgets. This ensures compatibility with
current gadgets and removes the global variable which brings me step
closer towards composite.c in libcomposite
Signed-off-by: Sebastian Andrzej Siewior
---
d
After I moved the function from the header file to the c file I see:
| $ size drivers/usb/gadget/gadget_chips.o
| textdata bss dec hex filename
| 1048 0 01048 418 drivers/usb/gadget/gadget_chips.o
That is almost a KiB which is removed from each user.
As Felipe
MODULE_VERSION and AUTHOR looks better in composite.c than in
usbstrings.c so I move it there.
I put David Brownell as the module Author as I belive he wrote most of
it.
Signed-off-by: Sebastian Andrzej Siewior
---
drivers/usb/gadget/composite.c |3 +++
drivers/usb/gadget/usbstring.c |1
This moves composite.c into libcomposite and updates all gadgets.
Finally!
Signed-off-by: Sebastian Andrzej Siewior
---
drivers/usb/gadget/Makefile |3 ++-
drivers/usb/gadget/acm_ms.c |2 +-
drivers/usb/gadget/audio.c | 11 +--
drivers/usb/gadget/cdc2.c
This patch pushes the iProduct module argument from composite
into each gadget.
Signed-off-by: Sebastian Andrzej Siewior
---
drivers/usb/gadget/composite.c | 21 +++--
include/linux/usb/composite.h |6 +-
2 files changed, 16 insertions(+), 11 deletions(-)
diff --git a
This patch pushes the iManufacturer module argument from composite into
each gadget. Once the user uses the module paramter, the string is
overwritten with the final value.
Signed-off-by: Sebastian Andrzej Siewior
---
drivers/usb/gadget/composite.c | 20 +++-
include/linux/usb/
I have no idea what I've been thinking while I was doing this in the first
place. Now the strings are initialized properly and reported by lsusb.
Signed-off-by: Sebastian Andrzej Siewior
---
drivers/usb/gadget/tcm_usb_gadget.c | 33 -
drivers/usb/gadget/tcm_usb_
The index in usb_string array is defined by the gadget. The gadget can
choose which index entry it assigns for the serial number and which the
product name. The gadget has just to ensure that the descriptor contains
the proper string id which is assigned by composite.
If the composite layer knows t
On Wed, Aug 29, 2012 at 07:13:45PM +0200, Sebastian Andrzej Siewior wrote:
> This series creates the libcomposite and is based on "Towords libcomposite,
> v2"
> It addresses the review comments of "create libcomposite".
>
> The numbers were gather from "size" on each gadget before and after serie
On Sun, Aug 19, 2012 at 02:31:12PM +, Luke-Jr wrote:
> https://bugzilla.kernel.org/show_bug.cgi?id=46201
>
> I have a device that uses a FTDI USB-to-serial chip identified by lsusb as:
> Bus 001 Device 051: ID 0403:6014 Future Technology Devices International, Ltd
>
> Only recently, within 2
On 08/29/2012 07:53 PM, Greg KH wrote:
Impressive numbers, nice job.
Thank you.
I'm guessing this will come to my trees eventually through Felipe's
tree?
Yes I hope so. I'm not sure what we should do about the ccg/Android
gadget. I think it would be best if this also goes in the same go (vi
On Wed, Aug 29, 2012 at 08:26:03PM +0200, Sebastian Andrzej Siewior wrote:
> On 08/29/2012 07:53 PM, Greg KH wrote:
> >I'm guessing this will come to my trees eventually through Felipe's
> >tree?
>
> Yes I hope so. I'm not sure what we should do about the ccg/Android
> gadget. I think it would be
On 08/29/2012 08:36 PM, Greg KH wrote:
I'd be glad to remove that code, if the Android people say they no
longer need it. Last I heard, their userspace code needed to be changed
over, and the Samsung developers were trying to accomplish that. It
would be great to find out how that effort is goi
On 08/21/2012 10:19 AM, Andrzej Pietrasiewicz wrote:
@Joel:
However, I am wondering if it would make sense to get rid of the "connect"
(or "ready", if you will) attribute altogether and instead use symlinks:
when a user wants to make the gadget ready, they do an ln -s, when they want
to unbind th
On 08/29/2012 01:01 PM, Sascha Hauer wrote:
> On Wed, Aug 29, 2012 at 01:18:10PM +0300, Alexander Shishkin wrote:
>> Sascha Hauer writes:
>>
>>> On Wed, Aug 29, 2012 at 10:50:08AM +0300, Alexander Shishkin wrote:
Richard Zhao writes:
> i.MX usb controllers shares non-core registers,
On 08/29/2012 05:14 AM, Richard Zhao wrote:
> On Tue, Aug 28, 2012 at 07:43:11PM +0530, ABRAHAM, KISHON VIJAY wrote:
>> Hi,
>>
>> On Tue, Aug 28, 2012 at 7:11 PM, Marc Kleine-Budde
>> wrote:
>>> On 08/24/2012 08:46 AM, Richard Zhao wrote:
>>> [...]
> /**
> + * devm_usb_get_phy_by_phandle
Yo Alan!
On Wed, 29 Aug 2012 10:07:41 -0400 (EDT)
Alan Stern wrote:
> > OK, fair enough, but does it need to keep flooding my logs? Can
> > we rate limit that a bit?
>
> Easy enough to do; simply disable CONFIG_USB_DEBUG.
Uh, not easy. This is a production machine. Acceptable downtime is
ve
Sebastian Andrzej Siewior writes:
> This patch moves the module options idVendor, idProduct and bcdDevice
> from composite.c into each gadgets. This ensures compatibility with
> current gadgets and removes the global variable which brings me step
> closer towards composite.c in libcomposite
>
> Si
Sebastian Andrzej Siewior writes:
> The index in usb_string array is defined by the gadget. The gadget can
> choose which index entry it assigns for the serial number and which the
> product name. The gadget has just to ensure that the descriptor contains
> the proper string id which is assigned b
Sebastian Andrzej Siewior writes:
> This patch pushes the iSerialNumber module argument from composite into
> each gadget. Once the user uses the module paramter, the string is
> overwritten with the final value.
>
> Signed-off-by: Sebastian Andrzej Siewior
Acked-by: Michal Nazarewicz
--
Best
Sebastian Andrzej Siewior writes:
> This patch pushes the iManufacturer module argument from composite into
> each gadget. Once the user uses the module paramter, the string is
> overwritten with the final value.
>
> Signed-off-by: Sebastian Andrzej Siewior
Acked-by: Michal Nazarewicz
--
Best
Sebastian Andrzej Siewior writes:
> This patch pushes the iProduct module argument from composite
> into each gadget.
>
> Signed-off-by: Sebastian Andrzej Siewior
Acked-by: Michal Nazarewicz
--
Best regards, _ _
.o. | Liege of Serenely Enlightened M
Sebastian Andrzej Siewior writes:
> The struct usb_composite_driver members iProduct, iSerial and
> iManufacturer can be entered directly via the string array. There is no
> need for them to appear here.
>
> Signed-off-by: Sebastian Andrzej Siewior
> diff --git a/drivers/usb/gadget/composite.c b
Sebastian Andrzej Siewior writes:
> Some gadgets provide custom entry here. Some may override it with an
> etntry that is also created by composite if there was no value sumbitted
> at all.
> This patch removes all "custom manufacturer" strings which are the same
> as these which are created by co
Sebastian Andrzej Siewior writes:
> This moves composite.c into libcomposite and updates all gadgets.
> Finally!
Awesome! :)
> Signed-off-by: Sebastian Andrzej Siewior
Acked-by: Michal Nazarewicz
--
Best regards, _ _
.o. | Liege of Serenely Enligh
Sebastian Andrzej Siewior writes:
> MODULE_VERSION and AUTHOR looks better in composite.c than in
> usbstrings.c so I move it there.
> I put David Brownell as the module Author as I belive he wrote most of
> it.
>
> Signed-off-by: Sebastian Andrzej Siewior
Acked-by: Michal Nazarewicz
> ---
>
On Wed, 29 Aug 2012, Gary E. Miller wrote:
> Yo Alan!
>
> On Wed, 29 Aug 2012 10:07:41 -0400 (EDT)
> Alan Stern wrote:
>
> > > OK, fair enough, but does it need to keep flooding my logs? Can
> > > we rate limit that a bit?
> >
> > Easy enough to do; simply disable CONFIG_USB_DEBUG.
>
> Uh, n
Yo Alan!
On Wed, 29 Aug 2012 17:08:43 -0400 (EDT)
Alan Stern wrote:
> > Uh, not easy. This is a production machine. Acceptable downtime is
> > very small. There should be a way to turn it off at runtime.
>
> No, there shouldn't. It's a debugging feature; while debugging we
> want to see al
Hi all. How can you associate a USB Bus:Device info with a /dev/entry?
Below I have copy/pasted lsusb and /sys/block entries for two drives
plugged into the same USB bus.
When there was only one USB key, I could simply take the Bus number
(with leading 0's trimmed off) and
ls -alh /sys/
Hi all. Could someone tell me how to associate a USB Bus:Device info
with a /dev/entry?
Below I have copy/pasted lsusb and /sys/block entries for two drives
plugged into the same USB bus.
When there was only one USB key, I could simply take the Bus number
(with leading 0's trimmed off) and
> -Original Message-
> From: Felipe Balbi [mailto:ba...@ti.com]
> Sent: Thursday, August 30, 2012 1:15 AM
> To: Chanho Park
> Cc: ba...@ti.com; linux-usb@vger.kernel.org; gre...@linuxfoundation.org;
> Kyungmin Park
> Subject: Re: [PATCH] usb: dwc3: correct default value of maxburst
>
> Hi,
This patch changes default value of maxburst to 1. When a connection is
established to highspeed not superspeed, the maxburst is set to 0.
So, we need to check and change default value of the maxburst before setting up
burst size of ep.
Signed-off-by: Chanho Park
Signed-off-by: Kyungmin Park
---
On 2012年08月29日 23:36, Alan Stern wrote:
> On Wed, 29 Aug 2012, Lan Tianyu wrote:
>
>> Hi Alan:
>> Do you have some advices on this patch? I current have two proposals.
>> 1) Add a new routine to get port connection before port's device being
>> created and being bound with ACPI. The rout
> -Original Message-
> From: linux-tegra-ow...@vger.kernel.org [mailto:linux-tegra-
> ow...@vger.kernel.org] On Behalf Of Stephen Warren
> Sent: Wednesday, August 29, 2012 11:01 PM
> To: Venu Byravarasu
> Cc: ccr...@android.com; o...@lixom.net; li...@arm.linux.org.uk;
> st...@rowland.harvar
On 8/29/2012 11:01 PM, Sergei Shtylyov wrote:
Hello.
On 08/29/2012 08:30 PM, Pratyush Anand wrote:
If xfernotready is received and there is no request in request_list then
PENDING flag must be set, so that next request in ep queue is executed.
In case of isoc transfer, if xfornotready is al
If xfernotready is received and there is no request in request_list then
PENDING flag must be set, so that next request in ep queue is executed.
In case of isoc transfer, if xfernotready is already elapsed and even first
request has not been queued to request_list, then issue END TRANSFER, so that
100 matches
Mail list logo
