Kernel NULL pointer deref. in musb_gadget on arm davinci omapl138 platform

2012-08-21 Thread Bastian . Ruppert
Hello, we use a custom board with a davinci omapl138 based on OMAP-L138 eXperimenter Kit. I added our board specific patches to a recent mainline linux kernel (version v3.6-rc2-223) to commit 9160338de92c0305329be5163a76f849806e83de. Using USB 2.0 with g_serial gadget driver results in kernel N

RE: [RFC 0/2] USB gadget - configfs

2012-08-21 Thread Andrzej Pietrasiewicz
Hello Sebastian, On Monday, August 20, 2012 1:01 PM Sebastian Andrzej Siewior wrote > > That would be something like > >$ ln -s /cfg/usb-function-gadget/G1 \ > /cfg/usb-function-gadget/udcs/udc1/ > > Where we "bind" the complete gadget (G1) including the mass storage > configura

[RFC PATCH 1/2] usb: usb port power off mechanism add "auto" option

2012-08-21 Thread Lan Tianyu
This patch is to add "auto" option to attribute portX/control. When echo "auto", the port's feature PORT_POWER would be clear if the port's connect type was mark not-used(connectability and visibility are both cleared) and with no device attached. Signed-off-by: Lan Tianyu --- drivers/usb/core/h

[RFC PATCH 2/2] USB: Set usb port's DevicerRemovable according acpi information in EHCI

2012-08-21 Thread Lan Tianyu
From: "Signed-off-by: Lan Tianyu" ACPI provide "_PLD" and "_UPC" aml methods to describe usb port visibility and connectability. This patch is to use those information to set usb port's DeviceRemovable. Signed-off-by: Lan Tianyu --- drivers/usb/core/hub.c |7 +++ drivers/usb/core/

Re: [RFC PATCH 2/2] USB: Set usb port's DevicerRemovable according acpi information in EHCI

2012-08-21 Thread Bjørn Mork
Lan Tianyu writes: > @@ -648,7 +649,14 @@ ehci_hub_descriptor ( > > /* two bitmaps: ports removable, and usb 1.0 legacy PortPwrCtrlMask */ > memset(&desc->u.hs.DeviceRemovable[0], 0, temp); > - memset(&desc->u.hs.DeviceRemovable[temp], 0xff, temp); > + memset(&desc->u.hs.De

Re: [RFC PATCH 2/2] USB: Set usb port's DevicerRemovable according acpi information in EHCI

2012-08-21 Thread Bjørn Mork
Bjørn Mork writes: > Lan Tianyu writes: > >> @@ -648,7 +649,14 @@ ehci_hub_descriptor ( >> >> /* two bitmaps: ports removable, and usb 1.0 legacy PortPwrCtrlMask */ >> memset(&desc->u.hs.DeviceRemovable[0], 0, temp); >> -memset(&desc->u.hs.DeviceRemovable[temp], 0xff, temp); >> +

Re: Re: Re: 3.0 device attached to USB 3.0 hub port doesn't respond address device command after resume

2012-08-21 Thread VIKAS SAJJAN C
Hi All, I was using the SS hub by VIA Labs,inc. what I found is that, there is a firmware update available for this SS HUB. When i went through the Release Notes, they say USB 3.0: Resolved issue with Intel USB 3.0 Host where devices were occasionally not properly re-enumerated after resumin

[PATCH] usb: dwc3: core: fix incorrect usage of resource pointer

2012-08-21 Thread Kishon Vijay Abraham I
Populate the resources for xhci afresh instead of directly using the *struct resource* of core. *resource* structure has parent, sibling, child pointers which should be filled only by resource API's. By directly using the *resource* pointer of core in xhci, these parent, sibling, child pointers are

Re: [PATCH] tusb6010: fix error path in tusb_probe()

2012-08-21 Thread Felipe Balbi
Hi, On Mon, Aug 20, 2012 at 10:31:41PM +0400, Sergei Shtylyov wrote: > On platform_device_add() failure, the TUSB6010 glue layer forgets to call > platform_device_put() -- probably due to a typo... > > Signed-off-by: Sergei Shtylyov wow.. I was just fixing this same issue today. Creepy. Will ap

[PATCH] usb: dwc3: debugfs: fixes debugfs regdump returning all zeros

2012-08-21 Thread Vikas Sajjan
Even though the mem region is requested from the Globals address space (DWC3_GLOBALS_REGS_START), the offsets are given from the starting of the xHCI address space. By subtracting DWC3_GLOBALS_REGS_START from the offset ( as done in dwc3_readl() and dwc3_writel() ) resolves the issue. Signed-off-

Re: [PATCH] tusb6010: fix error path in tusb_probe()

2012-08-21 Thread Sergei Shtylyov
Hello. On 21-08-2012 13:39, Felipe Balbi wrote: On platform_device_add() failure, the TUSB6010 glue layer forgets to call platform_device_put() -- probably due to a typo... Signed-off-by: Sergei Shtylyov wow.. I was just fixing this same issue today. Creepy. Will apply your patch :-)

Re: [PATCH 1/1] xhci: Unconditionally switch ports to xHCI on powerup

2012-08-21 Thread Sergei Shtylyov
Hello. On 21-08-2012 8:06, manoj.i...@canonical.com wrote: From: Manoj Iyer USB 3.0 devices show up as high-speed devices on powerup, after an s3 cycle they are correctly recognized as SuperSpeed. At powerup unconditionally switch the port to xHCI like we do when we resume from suspend.

Re: Re: USB device no longer recognized with kernel newer than 2.6

2012-08-21 Thread Andiry Xu
On Tue, Aug 21, 2012 at 3:46 AM, Arnaud René Ober wrote: > On 08/20/2012 09:39 PM, Alan Stern wrote: >> >> Please use Reply-To-All so that your messages get sent to the mailing >> list as well as to me. >> >> On Sun, 19 Aug 2012, Arnaud René Ober wrote: >> >>> On 08/19/2012 03:53 PM, Alan Stern wr

Re: [BUG] - USB3 bluetooth device not working properly?

2012-08-21 Thread Andiry Xu
Adding Linux-USB back.. On Tue, Aug 21, 2012 at 7:31 PM, Andiry Xu wrote: > On Mon, Aug 20, 2012 at 8:17 PM, Miroslav Sabljic > wrote: >> On 08/19/2012 03:29 PM, Andiry Xu wrote: >> >>> Thanks. The dmesg indicates the device does not respond the address >>> device command. The host reports a USB

Re: [PATCH] usb: gadget: bcm63xx UDC driver

2012-08-21 Thread Felipe Balbi
On Mon, Aug 20, 2012 at 08:48:11PM -0700, Kevin Cernekee wrote: > On Mon, Aug 20, 2012 at 12:40 AM, Felipe Balbi wrote: > > no workqueues, please either handle the IRQ here or use threaded_irqs. > > > > again, no workqueues. > > Felipe, > > I am seeing all sorts of deadlocks now, after removing

Re: [PATCH 1/1] xhci: Unconditionally switch ports to xHCI on powerup

2012-08-21 Thread Andiry Xu
On Tue, Aug 21, 2012 at 12:06 PM, wrote: > From: Manoj Iyer > > USB 3.0 devices show up as high-speed devices on powerup, after an > s3 cycle they are correctly recognized as SuperSpeed. At powerup > unconditionally switch the port to xHCI like we do when we resume > from suspend. > > BugLink: h

Re: Re: Re: 3.0 device attached to USB 3.0 hub port doesn't respond address device command after resume

2012-08-21 Thread Andiry Xu
Just have one question - how do you add suspend/resume support for DWC USB 3 controller? Where can I find the source code? Is it reusing the suspend/resume code of xhci.c? Thanks, Andiry On Tue, Aug 21, 2012 at 5:11 PM, VIKAS SAJJAN C wrote: > > Hi All, > > I was using the SS hub by VIA Labs,in

Re: Kernel NULL pointer deref. in musb_gadget on arm davinci omapl138 platform

2012-08-21 Thread Bastian . Ruppert
> > Hello, > > we use a custom board with a davinci omapl138 based on > OMAP-L138 eXperimenter Kit. > I added our board specific patches to a recent mainline linux > kernel (version v3.6-rc2-223) to commit > 9160338de92c0305329be5163a76f849806e83de. > Using USB 2.0 with g_serial gadget driver resu

Re: [RFC PATCH 2/2] USB: Set usb port's DevicerRemovable according acpi information in EHCI

2012-08-21 Thread Lan Tianyu
于 2012/8/21 17:07, Bjørn Mork 写道: Lan Tianyu writes: @@ -648,7 +649,14 @@ ehci_hub_descriptor ( /* two bitmaps: ports removable, and usb 1.0 legacy PortPwrCtrlMask */ memset(&desc->u.hs.DeviceRemovable[0], 0, temp); - memset(&desc->u.hs.DeviceRemovable[temp], 0xff, temp

Re: [PATCH 1/4] g_file_storage: implement ->reset method

2012-08-21 Thread Michal Nazarewicz
Alan Stern writes: > This patch (as1598) adds support for the new "reset" callback to the > g_file_storage driver. Resets are handled slightly differently from > disconnects, in that the driver doesn't sync the backing storage file > during a reset but does during a disconnect. > > The problem is

Re: [RFC PATCH 2/2] USB: Set usb port's DevicerRemovable according acpi information in EHCI

2012-08-21 Thread Oliver Neukum
On Tuesday 21 August 2012 21:52:43 Lan Tianyu wrote: > 于 2012/8/21 17:07, Bjørn Mork 写道: > > Lan Tianyu writes: > > > >> @@ -648,7 +649,14 @@ ehci_hub_descriptor ( > >> > >>/* two bitmaps: ports removable, and usb 1.0 legacy PortPwrCtrlMask */ > >>memset(&desc->u.hs.DeviceRemovable[0], 0,

Re: [PATCH 1/4] g_file_storage: implement ->reset method

2012-08-21 Thread Alan Stern
On Tue, 21 Aug 2012, Michal Nazarewicz wrote: > Alan Stern writes: > > This patch (as1598) adds support for the new "reset" callback to the > > g_file_storage driver. Resets are handled slightly differently from > > disconnects, in that the driver doesn't sync the backing storage file > > during

Re: [PATCH 2/2] powerpc/usb: fix bug of CPU hang when missing USB PHY clock

2012-08-21 Thread Alan Stern
On Mon, 20 Aug 2012, Kumar Gala wrote: > >> Subject: Re: [PATCH 2/2] powerpc/usb: fix bug of CPU hang when missing USB > >> PHY > >> clock > >> > >> > >> On Aug 10, 2012, at 5:48 AM, Shengzhou Liu wrote: > >> > >>> when missing USB PHY clock, kernel booting up will hang during USB > >>> initia

Re: [RFC PATCH 2/2] USB: Set usb port's DevicerRemovable according acpi information in EHCI

2012-08-21 Thread Alan Stern
On Tue, 21 Aug 2012, Lan Tianyu wrote: > From: "Signed-off-by: Lan Tianyu" What happened here? That's not right. > ACPI provide "_PLD" and "_UPC" aml methods to describe usb port > visibility and connectability. This patch is to use those information > to set usb port's DeviceRemovable. By th

Re: [RFC PATCH 1/2] usb: usb port power off mechanism add "auto" option

2012-08-21 Thread Alan Stern
On Tue, 21 Aug 2012, Lan Tianyu wrote: > This patch is to add "auto" option to attribute portX/control. > When echo "auto", the port's feature PORT_POWER would be clear > if the port's connect type was mark not-used(connectability and > visibility are both cleared) and with no device attached. >

Re: [PATCH] usb: gadget: bcm63xx UDC driver

2012-08-21 Thread Kevin Cernekee
On Tue, Aug 21, 2012 at 5:04 AM, Felipe Balbi wrote: > On Mon, Aug 20, 2012 at 08:48:11PM -0700, Kevin Cernekee wrote: >> On Mon, Aug 20, 2012 at 12:40 AM, Felipe Balbi wrote: >> > no workqueues, please either handle the IRQ here or use threaded_irqs. >> > >> > again, no workqueues. >> >> Felipe,

Re: [PATCH 1/2] usb/dummy_hcd: fixup error probe path

2012-08-21 Thread Alan Stern
On Sun, 19 Aug 2012, Sebastian Andrzej Siewior wrote: > If USB2 host controller probes fine but USB3 does not then we don't > remove the USB controller properly and lock up the system while the HUB > code will try to enumerate the USB2 controller and access memory which > is no longer available in

Re: [PATCH 2/2] usb/dummy_hcd: add support for USB_DT_BOS on rh

2012-08-21 Thread Alan Stern
On Sun, 19 Aug 2012, Sebastian Andrzej Siewior wrote: > Without a reply for USB_DT_BOS the USB3 mode does not work since > 448b6eb1 ("USB: Make sure to fetch the BOS desc for roothubs.). This is fine except for one little thing... > Cc: sta...@kernel.org #v3.5 > Signed-off-by: Sebastian Andrzej

Re: [PATCH 1/1] xhci: Unconditionally switch ports to xHCI on powerup

2012-08-21 Thread Manoj Iyer
Looks like in pci-quirks.c, we enter the do() while() loop, reach the end of extended capabilities and goto hc_init: label, skipping the switch. Probably moving the switch under the hc_init label might work? Currently we switch unconditionally on resume, so we could do the same at powerup as

Re: [PATCH 2/2] usb/dummy_hcd: add support for USB_DT_BOS on rh

2012-08-21 Thread Sebastian Andrzej Siewior
On Tue, Aug 21, 2012 at 11:26:30AM -0400, Alan Stern wrote: > > +/* usb 3.0 root hub device descriptor */ > > This is a BOS descriptor and a capability descriptor, combined. Not a > device descriptor. Oh. Mind if I drop the comment? > > +struct { > > + struct usb_bos_descriptor bos; > > +

Re: [PATCH 2/2] usb/dummy_hcd: add support for USB_DT_BOS on rh

2012-08-21 Thread Alan Stern
On Tue, 21 Aug 2012, Sebastian Andrzej Siewior wrote: > On Tue, Aug 21, 2012 at 11:26:30AM -0400, Alan Stern wrote: > > > +/* usb 3.0 root hub device descriptor */ > > > > This is a BOS descriptor and a capability descriptor, combined. Not a > > device descriptor. > > Oh. Mind if I drop the co

[PATCH] musb_core: fix kernel-doc of musb_init_controller()

2012-08-21 Thread Sergei Shtylyov
Some parameter names in this function's kernel-doc don't match the real parameters. While at it, give the 'nIrq' parameter slightly more verbose description... Signed-off-by: Sergei Shtylyov --- This patch is atop of 'musb' branch of Felipe's tree... drivers/usb/musb/musb_core.c |6 +++---

Re: [PATCH] usb: gadget: bcm63xx UDC driver

2012-08-21 Thread Felipe Balbi
On Tue, Aug 21, 2012 at 08:20:43AM -0700, Kevin Cernekee wrote: > On Tue, Aug 21, 2012 at 5:04 AM, Felipe Balbi wrote: > > On Mon, Aug 20, 2012 at 08:48:11PM -0700, Kevin Cernekee wrote: > >> On Mon, Aug 20, 2012 at 12:40 AM, Felipe Balbi wrote: > >> > no workqueues, please either handle the IRQ

Re: [PATCH] usb: gadget: bcm63xx UDC driver

2012-08-21 Thread Kevin Cernekee
On Tue, Aug 21, 2012 at 11:08 AM, Felipe Balbi wrote: > Then stick to a workqueue... but could you let me know why exactly you > have to fake SET_CONFIGURATION/SET_INTERFACE requests ? Is this a > silicon bug or a silicon feature ? That's quite weird to me. It is a silicon feature: the core will

Re: [PATCH] usb: gadget: bcm63xx UDC driver

2012-08-21 Thread Alan Stern
On Tue, 21 Aug 2012, Kevin Cernekee wrote: > On Tue, Aug 21, 2012 at 11:08 AM, Felipe Balbi wrote: > > Then stick to a workqueue... but could you let me know why exactly you > > have to fake SET_CONFIGURATION/SET_INTERFACE requests ? Is this a > > silicon bug or a silicon feature ? That's quite w

[PATCHv3 7/9] arm: vt8500: doc: Add device tree bindings for arch-vt8500 devices

2012-08-21 Thread Tony Prisk
Bindings for gpio, interrupt controller, power management controller, timer, realtime clock, serial uart, ehci and uhci controllers and framebuffer controllers used on the arch-vt8500 platform. Framebuffer binding also specifies a 'display' node which is required for determining the lcd panel data

[PATCHv3 9/9] arm: vt8500: clk: Add Common Clock Framework support

2012-08-21 Thread Tony Prisk
This patch adds common clock framework support for arch-vt8500. Support for PLL and device clocks on VT8500, WM8505 and WM8650 are included. Signed-off-by: Tony Prisk --- drivers/clk/Makefile |1 + drivers/clk/clk-vt8500.c | 496 ++ 2 files ch

[PATCHv3 2/9] rtc: vt8500: Add devicetree support for vt8500-rtc

2012-08-21 Thread Tony Prisk
Signed-off-by: Tony Prisk --- drivers/rtc/rtc-vt8500.c |9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-vt8500.c b/drivers/rtc/rtc-vt8500.c index 9e94fb1..07bf193 100644 --- a/drivers/rtc/rtc-vt8500.c +++ b/drivers/rtc/rtc-vt8500.c @@ -23,6 +23,7 @@

[PATCHv3 5/9] video: vt8500: Add devicetree support for vt8500-fb and wm8505-fb

2012-08-21 Thread Tony Prisk
Update vt8500-fb, wm8505-fb and wmt-ge-rops to support device tree bindings. Small change in wm8505-fb.c to support WM8650 framebuffer color format. Signed-off-by: Tony Prisk --- drivers/video/Kconfig |6 +-- drivers/video/vt8500lcdfb.c | 79 ++- drive

[PATCHv3 4/9] usb: vt8500: Add devicetree support for vt8500-ehci and -uhci.

2012-08-21 Thread Tony Prisk
Add devicetree support for vt8500-ehci. Convert vt8500-uhci to a generic non-pci platform-uhci with device tree support. Signed-off-by: Tony Prisk --- drivers/usb/host/Kconfig |4 +- drivers/usb/host/ehci-vt8500.c | 25 -- drivers/usb/host/uhci-hcd.c |5 ++ drivers/u

[PATCHv3 3/9] serial: vt8500: Add devicetree support for vt8500-serial

2012-08-21 Thread Tony Prisk
Signed-off-by: Tony Prisk --- drivers/tty/serial/vt8500_serial.c | 37 1 file changed, 33 insertions(+), 4 deletions(-) diff --git a/drivers/tty/serial/vt8500_serial.c b/drivers/tty/serial/vt8500_serial.c index 2be006f..72e32db 100644 --- a/drivers/tty/ser

[PATCHv3 0/9] *** ARM: Update arch-vt8500 to Devicetree ***

2012-08-21 Thread Tony Prisk
This patchset updates arch-vt8500 to devicetree and removes all the old-style code. Support for WM8650 has also been added. Example dts/dtsi files are given for the three currently supported models. Major changes: GPIO code has been converted to a platform_device and rewritten as WM8505 support

[PATCHv3 8/9] arm: vt8500: gpio: Devicetree support for arch-vt8500

2012-08-21 Thread Tony Prisk
Converted the existing arch-vt8500 gpio to a platform_device. Added support for WM8505 and WM8650 GPIO controllers. Signed-off-by: Tony Prisk --- drivers/gpio/Kconfig |6 + drivers/gpio/Makefile |1 + drivers/gpio/gpio-vt8500.c | 313 ++

[PATCHv3 1/9] arm: vt8500: Add device tree files for VIA/Wondermedia SoC's

2012-08-21 Thread Tony Prisk
Add device tree files for VT8500, WM8505 and WM8650 SoC's and reference boards. Signed-off-by: Tony Prisk --- arch/arm/boot/dts/vt8500-bv07.dts | 31 + arch/arm/boot/dts/vt8500.dtsi | 100 +++ arch/arm/boot/dts/wm8505-ref.dts | 31 + arch/arm/boo

Re: [PATCH] usb: gadget: bcm63xx UDC driver

2012-08-21 Thread Kevin Cernekee
On Tue, Aug 21, 2012 at 1:34 PM, Alan Stern wrote: >> It is a silicon feature: the core will intercept SET_CONFIGURATION / >> SET_INTERFACE requests, store wValue/wIndex in the appropriate >> USBD_STATUS_REG field (cfg/intf/altintf), send an acknowledgement to >> the host, and raise a control inte

Re: [PATCH V2] usb: gadget: bcm63xx UDC driver

2012-08-21 Thread Sebastian Andrzej Siewior
On Mon, Aug 20, 2012 at 06:49:36PM -0700, Kevin Cernekee wrote: > Driver for the "USB20D" / "USBD" block on BCM6328, BCM6368, BCM6816, > BCM6362, BCM3383, and others. looks good btw. > diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig > index 51ab5fd..01efd9d 100644 > --- a/dri

Re: [PATCH] usb: gadget: bcm63xx UDC driver

2012-08-21 Thread Alan Stern
On Tue, 21 Aug 2012, Kevin Cernekee wrote: > On Tue, Aug 21, 2012 at 1:34 PM, Alan Stern wrote: > >> It is a silicon feature: the core will intercept SET_CONFIGURATION / > >> SET_INTERFACE requests, store wValue/wIndex in the appropriate > >> USBD_STATUS_REG field (cfg/intf/altintf), send an ackn

Re: [PATCH] usb: gadget: bcm63xx UDC driver

2012-08-21 Thread Kevin Cernekee
On Tue, Aug 21, 2012 at 2:34 PM, Alan Stern wrote: >> But some requests are handled entirely in hardware, including the status >> phase: >> >> SET_ADDRESS >> SET_CONFIGURATION >> SET_INTERFACE >> SET_FEATURE >> CLEAR_FEATURE >> GET_FEATURE > > I assume the features in question are endpoint-halts

Re: [PATCHv3 3/9] serial: vt8500: Add devicetree support for vt8500-serial

2012-08-21 Thread Alan Cox
On Wed, 22 Aug 2012 08:47:32 +1200 Tony Prisk wrote: > Signed-off-by: Tony Prisk > --- > drivers/tty/serial/vt8500_serial.c | 37 > > 1 file changed, 33 insertions(+), 4 deletions(-) Can we have a comment attached to a change this size. In particular one

Re: [PATCH V2] usb: gadget: bcm63xx UDC driver

2012-08-21 Thread Kevin Cernekee
On Tue, Aug 21, 2012 at 2:13 PM, Sebastian Andrzej Siewior wrote: > please drop the "force all gadget drivers to also be dynamically linked" part. > We may want to change this one day :) Done in V3 >> + if (!pd->use_fullspeed && !use_fullspeed) > so it is a good advice to have pd not set to

RE: [PATCH 1/4] g_file_storage: implement ->reset method

2012-08-21 Thread Chen Peter-B29397
> > > Unfortunately the driver already contains an FSG_STATE_RESET symbol. > > > The patch renames it to FSG_STATE_CLASS_RESET, because it refers to a > > > class-specific reset event rather than a general USB port reset, and > > > uses FSG_STATE_RESET for port resets. The g_mass_storage driver

Re: [PATCH 1/1] xhci: Unconditionally switch ports to xHCI on powerup

2012-08-21 Thread Andiry Xu
On Wed, Aug 22, 2012 at 12:16 AM, Manoj Iyer wrote: > > Looks like in pci-quirks.c, we enter the do() while() loop, reach the end of > extended capabilities and goto hc_init: label, skipping the switch. Probably > moving the switch under the hc_init label might work? Currently we switch > uncondit

[PATCH 0/5] usb: gadget: s3c2410_udc: Fixes and cleanup

2012-08-21 Thread Sachin Kamat
This patch series fixes several errors and warnings related to coding style and compilation in s3c2410_udc driver. It is compile tested using s3c2410_defconfig based on linux-next tree. Sachin Kamat (5): usb: gadget: s3c2410_udc: Replace with usb: gadget: s3c2410_udc: Use pr_* functions us

[PATCH 1/5] usb: gadget: s3c2410_udc: Replace with

2012-08-21 Thread Sachin Kamat
Fixes the following warning: WARNING: Use #include instead of Signed-off-by: Sachin Kamat --- drivers/usb/gadget/s3c2410_udc.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/usb/gadget/s3c2410_udc.c b/drivers/usb/gadget/s3c2410_udc.c index f2e51f5..7acecc0 10

[PATCH 2/5] usb: gadget: s3c2410_udc: Use pr_* functions

2012-08-21 Thread Sachin Kamat
Replace printk with corresponding pr_* functions. Signed-off-by: Sachin Kamat --- drivers/usb/gadget/s3c2410_udc.c | 12 +++- 1 files changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/usb/gadget/s3c2410_udc.c b/drivers/usb/gadget/s3c2410_udc.c index 7acecc0..7e2ce44 100644

[PATCH 3/5] usb: gadget: s3c2410_udc: Silence checkpatch errors and warnings

2012-08-21 Thread Sachin Kamat
Silences about 75 errors and warnings related to - Spacing - Alignment of braces - Line over 80 characters Signed-off-by: Sachin Kamat --- drivers/usb/gadget/s3c2410_udc.c | 126 ++--- 1 files changed, 61 insertions(+), 65 deletions(-) diff --git a/drivers/usb/g

[PATCH 4/5] usb: gadget: s3c2410_udc: Move assignment outside if condition

2012-08-21 Thread Sachin Kamat
Fixes the following checkpatch errors: ERROR: do not use assignment in if condition Signed-off-by: Sachin Kamat --- drivers/usb/gadget/s3c2410_udc.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/usb/gadget/s3c2410_udc.c b/drivers/usb/gadget/s3c2410_udc.c i

[PATCH 5/5] usb: gadget: s3c2410_udc: Do not use integer for NULL

2012-08-21 Thread Sachin Kamat
'req' being a pointer shouldn't be equated with 0. Fixes the following compilation warning: drivers/usb/gadget/s3c2410_udc.c:1299:13: warning: Using plain integer as NULL pointer Signed-off-by: Sachin Kamat --- drivers/usb/gadget/s3c2410_udc.c |2 +- 1 files changed, 1 insertions(+), 1 dele

Re: [RFC PATCH 2/2] USB: Set usb port's DevicerRemovable according acpi information in EHCI

2012-08-21 Thread Lan Tianyu
On 2012年08月21日 22:56, Alan Stern wrote: > On Tue, 21 Aug 2012, Lan Tianyu wrote: > >> From: "Signed-off-by: Lan Tianyu" > > What happened here? That's not right. > This was added by git sendmail... I have no idea. >> ACPI provide "_PLD" and "_UPC" aml methods to describe usb port >> visibilit

Re: [RFC PATCH 1/2] usb: usb port power off mechanism add "auto" option

2012-08-21 Thread Lan Tianyu
On 2012年08月21日 23:03, Alan Stern wrote: > On Tue, 21 Aug 2012, Lan Tianyu wrote: > >> This patch is to add "auto" option to attribute portX/control. >> When echo "auto", the port's feature PORT_POWER would be clear >> if the port's connect type was mark not-used(connectability and >> visibility ar

Re: [PATCH 2/5] usb: gadget: s3c2410_udc: Use pr_* functions

2012-08-21 Thread ABRAHAM, KISHON VIJAY
Hi, On Wed, Aug 22, 2012 at 11:13 AM, Sachin Kamat wrote: > Replace printk with corresponding pr_* functions. > > Signed-off-by: Sachin Kamat > --- > drivers/usb/gadget/s3c2410_udc.c | 12 +++- > 1 files changed, 7 insertions(+), 5 deletions(-) > > diff --git a/drivers/usb/gadget/s3c2

Re: [PATCH 2/5] usb: gadget: s3c2410_udc: Use pr_* functions

2012-08-21 Thread Sachin Kamat
On 22 August 2012 11:43, ABRAHAM, KISHON VIJAY wrote: > Hi, > > On Wed, Aug 22, 2012 at 11:13 AM, Sachin Kamat > wrote: >> Replace printk with corresponding pr_* functions. >> >> Signed-off-by: Sachin Kamat >> --- >> drivers/usb/gadget/s3c2410_udc.c | 12 +++- >> 1 files changed, 7 i

Re: [PATCH 2/5] usb: gadget: s3c2410_udc: Use pr_* functions

2012-08-21 Thread Felipe Balbi
Hi, On Wed, Aug 22, 2012 at 11:13:16AM +0530, Sachin Kamat wrote: > Replace printk with corresponding pr_* functions. > > Signed-off-by: Sachin Kamat > --- > drivers/usb/gadget/s3c2410_udc.c | 12 +++- > 1 files changed, 7 insertions(+), 5 deletions(-) > > diff --git a/drivers/usb/ga

Re: [PATCH 2/5] usb: gadget: s3c2410_udc: Use pr_* functions

2012-08-21 Thread ABRAHAM, KISHON VIJAY
On Wed, Aug 22, 2012 at 11:50 AM, Sachin Kamat wrote: > On 22 August 2012 11:43, ABRAHAM, KISHON VIJAY wrote: >> Hi, >> >> On Wed, Aug 22, 2012 at 11:13 AM, Sachin Kamat >> wrote: >>> Replace printk with corresponding pr_* functions. >>> >>> Signed-off-by: Sachin Kamat >>> --- >>> drivers/usb

Re: [PATCHv3 3/9] serial: vt8500: Add devicetree support for

2012-08-21 Thread Tony Prisk
On Tue, 2012-08-21 at 23:12 +0100, Alan Cox wrote: > On Wed, 22 Aug 2012 08:47:32 +1200 > Tony Prisk wrote: > > > Signed-off-by: Tony Prisk > > --- > > drivers/tty/serial/vt8500_serial.c | 37 > > > > 1 file changed, 33 insertions(+), 4 deletions(-) > >

Re: [PATCHv3 3/9] serial: vt8500: Add devicetree support for

2012-08-21 Thread Arnd Bergmann
On Wednesday 22 August 2012, Tony Prisk wrote: > The original patch was very simple, but I revisited it to fix other > issues and forgot to add the relevant comments. > > Port size is changed to fix a problem - WM8505 actually had 6 uart's > defined in platform data but the vt8500_ports variable w