Hi,

On Wed, Aug 22, 2012 at 11:13:16AM +0530, Sachin Kamat wrote:
> Replace printk with corresponding pr_* functions.
> 
> Signed-off-by: Sachin Kamat <sachin.ka...@linaro.org>
> ---
>  drivers/usb/gadget/s3c2410_udc.c |   12 +++++++-----
>  1 files changed, 7 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/usb/gadget/s3c2410_udc.c 
> b/drivers/usb/gadget/s3c2410_udc.c
> index 7acecc0..7e2ce44 100644
> --- a/drivers/usb/gadget/s3c2410_udc.c
> +++ b/drivers/usb/gadget/s3c2410_udc.c
> @@ -12,6 +12,8 @@
>   * (at your option) any later version.
>   */
>  
> +#define pr_fmt(fmt) "s3c2410_udc: " fmt
> +
>  #include <linux/module.h>
>  #include <linux/kernel.h>
>  #include <linux/delay.h>
> @@ -115,7 +117,7 @@ static int dprintk(int level, const char *fmt, ...)
>                       sizeof(printk_buf)-len, fmt, args);
>       va_end(args);
>  
> -     return printk(KERN_DEBUG "%s", printk_buf);
> +     return pr_debug("%s", printk_buf);
>  }
>  #else
>  static int dprintk(int level, const char *fmt, ...)
> @@ -1683,13 +1685,13 @@ static int s3c2410_udc_start(struct usb_gadget_driver 
> *driver,
>               return -EBUSY;
>  
>       if (!bind || !driver->setup || driver->max_speed < USB_SPEED_FULL) {
> -             printk(KERN_ERR "Invalid driver: bind %p setup %p speed %d\n",
> +             pr_err("Invalid driver: bind %p setup %p speed %d\n",
>                       bind, driver->setup, driver->max_speed);

you have access to a struct device *. Please use dev_* instead.

-- 
balbi

Attachment: signature.asc
Description: Digital signature

Reply via email to