On 08/19/2012 02:33 PM, Roland Stigge wrote:
On 17/08/12 11:42, Sebastian Andrzej Siewior wrote:
Some minor things:
- please use to_udc() in start then
- would it make sense to use platform_get_drvdata() in
lpc32xx_udc_shutdown() ?
- could you please remove struct usb_endpoint_descriptor from
On Sun, Aug 19, 2012 at 01:53:26PM -0700, Kevin Cernekee wrote:
> On Sun, Aug 19, 2012 at 1:17 PM, Sebastian Andrzej Siewior
> wrote:
> > On Sat, Aug 18, 2012 at 10:18:01AM -0700, Kevin Cernekee wrote:
> >
> > This is a quick look :)
>
> Thanks for the review.
>
> >> + for (i = 0; i < NUM_IU
I'm not going to swear here. The Android gadget includes composite.c
from the main tree and overwrites functions. This would still work if I
rename it and remove the const attribute but the problem rises again
once we stop including composite.c and use it as a library function.
Cc: de...@driverdev
Hi,
On 08/20/2012 09:07 AM, Sebastian Andrzej Siewior wrote:
>> I merged these changes into the patch set, and will repost it tomorrow
>> after I can test it more thoroughly.
>
> Thanks.
> While you are playing with it, I saw that you handle vbus (->pull())
> manually. This was the case in the "o
This patch adjusts the LPC32xx USB gadget driver to the new udc_start /
udc_stop interface.
Signed-off-by: Roland Stigge
---
Applies to v3.6-rc2
drivers/usb/gadget/lpc32xx_udc.c | 49 +++
1 file changed, 14 insertions(+), 35 deletions(-)
--- linux-2.6.or
This patch removes the utilization of struct usb_endpoint_descriptor, as done
by other drivers also. This was done on request by the USB gadget maintainers,
since this API is obsoleted.
Signed-off-by: Roland Stigge
---
drivers/usb/gadget/lpc32xx_udc.c | 23 +++
1 file cha
The lpc32xx_udc driver supported only one controller by defining a global
static struct for it. This patch enables multiple instances of the controller
by dynamic allocation of the struct at probe(). A static struct is kept as a
template on initialization since it does some complex preset, reflecti
On 08/20/2012 10:11 AM, Roland Stigge wrote:
--- linux-2.6.orig/drivers/usb/gadget/lpc32xx_udc.c
+++ linux-2.6/drivers/usb/gadget/lpc32xx_udc.c
@@ -2608,10 +2608,9 @@ static void nop_release(struct device *d
/* nothing to free */
}
-static struct lpc32xx_udc controller = {
+static stru
On 08/20/2012 10:11 AM, Roland Stigge wrote:
This patch removes the utilization of struct usb_endpoint_descriptor, as done
by other drivers also. This was done on request by the USB gadget maintainers,
since this API is obsoleted.
#1 and #2 look good. #3 could use a const besides that it looks
On 08/20/2012 10:19 AM, Sebastian Andrzej Siewior wrote:
> On 08/20/2012 10:11 AM, Roland Stigge wrote:
>> This patch removes the utilization of struct usb_endpoint_descriptor,
>> as done
>> by other drivers also. This was done on request by the USB gadget
>> maintainers,
>> since this API is obsol
This patch adjusts the LPC32xx USB gadget driver to the new udc_start /
udc_stop interface.
Signed-off-by: Roland Stigge
---
Applies to v3.6-rc2
Changes since v1:
* None
drivers/usb/gadget/lpc32xx_udc.c | 49 +++
1 file changed, 14 insertions(+), 35 dele
This patch removes the utilization of struct usb_endpoint_descriptor, as done
by other drivers also. This was done on request by the USB gadget maintainers,
since this API is obsoleted.
Signed-off-by: Roland Stigge
---
Changes since v1:
* None
drivers/usb/gadget/lpc32xx_udc.c | 23 +++--
The lpc32xx_udc driver supported only one controller by defining a global
static struct for it. This patch enables multiple instances of the controller
by dynamic allocation of the struct at probe(). A static struct is kept as a
template on initialization since it does some complex preset, reflecti
- Ursprüngliche Mail -
> On Fri, Aug 03, 2012 at 05:06:27PM +0200, René Bürgel wrote:
> > Hello,
> >
> > this is a patches-series for controllers using the ezusb-functions.
> >
> > ezusb: remove dependency to usb_serial interface
> > euzsb: add support for Cypress FX2LP
> > ezusb: add fu
Hello Joel,
Thanks for your reply.
On Monday, August 20, 2012 8:00 AM Joel Becker wrote:
>
> I think what you want here is a symlink. Create a directory
> high in the tree called 'ready' or 'available', and when you want to
> lock the device in place, symlink it into that directory. This
From: Bjørn Mork
Date: Wed, 15 Aug 2012 15:42:57 +0200
> Newer firmware versions for the Pantech UML290 use a different
> subclass ID. The Windows driver match on both IDs, so we do
> that as well.
>
> The ZTE (Vodafone) K5006-Z is a new device.
>
> Cc: Dan Williams
> Cc: Thomas Schäfer
> Si
Hello,
I just noticed that /dev/ttyUSBx devices are not destroyed and released
on USB device disconnect if some process keeps the file open, and
reading from the file does not return an error - it successfully reads 0
bytes instead.
This affects my gpsd usage, so I believe it must be a recent reg
When IORESOURCE_IRQ_SHAREABLE is set, the irq handler may be called
even if the interupt of the USB module doesn't happen. So, it may
clear the interrupt flags by mistake. This patch fixes it.
Signed-off-by: Yoshihiro Shimoda
---
drivers/usb/renesas_usbhs/mod.c | 25 ++---
On Mon, Aug 20, 2012 at 11:06:34AM +0530, ABRAHAM, KISHON VIJAY wrote:
> Hi,
>
> On Sat, Aug 18, 2012 at 9:34 PM, Peter Meerwald wrote:
> >
> > 3.6-rc2 fails to compile with
> > CONFIG_USB_MUSB_HDRC=m
> > CONFIG_USB_MUSB_OMAP2PLUS=m
> >
> > LD init/built-in.o
> > drivers/built-in.o: In fun
Hi,
On Mon, Aug 20, 2012 at 3:24 PM, Felipe Balbi wrote:
> On Mon, Aug 20, 2012 at 11:06:34AM +0530, ABRAHAM, KISHON VIJAY wrote:
>> Hi,
>>
>> On Sat, Aug 18, 2012 at 9:34 PM, Peter Meerwald wrote:
>> >
>> > 3.6-rc2 fails to compile with
>> > CONFIG_USB_MUSB_HDRC=m
>> > CONFIG_USB_MUSB_OMAP2PLUS
On Mon, Aug 20, 2012 at 03:46:07PM +0530, ABRAHAM, KISHON VIJAY wrote:
> Hi,
>
> On Mon, Aug 20, 2012 at 3:24 PM, Felipe Balbi wrote:
> > On Mon, Aug 20, 2012 at 11:06:34AM +0530, ABRAHAM, KISHON VIJAY wrote:
> >> Hi,
> >>
> >> On Sat, Aug 18, 2012 at 9:34 PM, Peter Meerwald wrote:
> >> >
> >> >
[2.911499] hub 1-0:1.0: usb_probe_interface
[2.911529] hub 1-0:1.0: usb_probe_interface - got id
[2.911621] hub 1-0:1.0: USB hub found
[2.915893] hub 1-0:1.0: 3 ports detected
[2.920135] hub 1-0:1.0: standalone hub
[2.920135] hub 1-0:1.0: individual port power switching
[
On Monday 20 August 2012 11:32:48 Bjørn Mork wrote:
> Hello,
>
> I just noticed that /dev/ttyUSBx devices are not destroyed and released
> on USB device disconnect if some process keeps the file open, and
Well, we have to return some error code. So the device cannot just go away.
> reading from
On 08/20/2012 07:59 AM, Joel Becker wrote:
I think what you want here is a symlink. Create a directory
high in the tree called 'ready' or 'available', and when you want to
lock the device in place, symlink it into that directory. This will pin
the item. You can also make use of the ->a
Hi,
On Mon, Aug 20, 2012 at 3:56 PM, Felipe Balbi wrote:
> On Mon, Aug 20, 2012 at 03:46:07PM +0530, ABRAHAM, KISHON VIJAY wrote:
>> Hi,
>>
>> On Mon, Aug 20, 2012 at 3:24 PM, Felipe Balbi wrote:
>> > On Mon, Aug 20, 2012 at 11:06:34AM +0530, ABRAHAM, KISHON VIJAY wrote:
>> >> Hi,
>> >>
>> >> On
On Mon, Aug 20, 2012 at 10:53:42AM +0200, Andrzej Pietrasiewicz wrote:
> Hello Joel,
>
> Thanks for your reply.
>
> On Monday, August 20, 2012 8:00 AM Joel Becker wrote:
> >
> > I think what you want here is a symlink. Create a directory
> > high in the tree called 'ready' or 'available', a
On Mon, Aug 20, 2012 at 01:01:03PM +0200, Sebastian Andrzej Siewior wrote:
> On 08/20/2012 07:59 AM, Joel Becker wrote:
> > I think what you want here is a symlink. Create a directory
> >high in the tree called 'ready' or 'available', and when you want to
> >lock the device in place, symlink i
Oliver Neukum writes:
> On Monday 20 August 2012 11:32:48 Bjørn Mork wrote:
>> Hello,
>>
>> I just noticed that /dev/ttyUSBx devices are not destroyed and released
>> on USB device disconnect if some process keeps the file open, and
>
> Well, we have to return some error code. So the device canno
Please, forget about post above - I use
git://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-omap-pm.git
and it was fixed >3.5
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger
On Mon, Aug 20, 2012 at 04:37:28PM +0530, ABRAHAM, KISHON VIJAY wrote:
> Hi,
>
> On Mon, Aug 20, 2012 at 3:56 PM, Felipe Balbi wrote:
> > On Mon, Aug 20, 2012 at 03:46:07PM +0530, ABRAHAM, KISHON VIJAY wrote:
> >> Hi,
> >>
> >> On Mon, Aug 20, 2012 at 3:24 PM, Felipe Balbi wrote:
> >> > On Mon,
On 08/20/2012 08:53 AM, VIKAS SAJJAN C wrote:
After this 3.0 port becomes DEAD, it does not detect any attach /detach.
even i tired with another hub, same is the issue...
all the cases of suspend / resume works except this case, by that i mean
1. USB 3.0 Device on 3.0 port - Works fine.
2. US
Sebastian Andrzej Siewior writes:
> I'm not going to swear here. The Android gadget includes composite.c
> from the main tree and overwrites functions. This would still work if I
> rename it and remove the const attribute but the problem rises again
> once we stop including composite.c and use it
On 08/20/2012 01:47 PM, Michal Nazarewicz wrote:
diff --git a/drivers/usb/gadget/composite.c b/drivers/usb/gadget/composite.c
index 598df69..790fc4d 100644
--- a/drivers/usb/gadget/composite.c
+++ b/drivers/usb/gadget/composite.c
@@ -1598,9 +1598,18 @@ static const struct usb_gadget_driver
compo
On Mon, 20 Aug 2012, Bjørn Mork wrote:
> Hello,
>
> I just noticed that /dev/ttyUSBx devices are not destroyed and released
> on USB device disconnect if some process keeps the file open, and
> reading from the file does not return an error - it successfully reads 0
> bytes instead.
I could be w
Alan Stern writes:
> On Mon, 20 Aug 2012, Bjørn Mork wrote:
>
>> I just noticed that /dev/ttyUSBx devices are not destroyed and released
>> on USB device disconnect if some process keeps the file open, and
>> reading from the file does not return an error - it successfully reads 0
>> bytes instead
> On 08/20/2012 01:47 PM, Michal Nazarewicz wrote:
>> Would it make sense to instead of doing that, wrap composite_setup() and
>> composite_disconnect() inside ifdef and make ccg.c define those two
>> functions?
Sebastian Andrzej Siewior writes:
> I hoped you suggest to move ccg's dependencies in
On Mon, Aug 20, 2012 at 03:12:25PM +0200, Bjørn Mork wrote:
> Alan Stern writes:
> > On Mon, 20 Aug 2012, Bjørn Mork wrote:
> >
> >> I just noticed that /dev/ttyUSBx devices are not destroyed and released
> >> on USB device disconnect if some process keeps the file open, and
> >> reading from the
On Mon, Aug 20, 2012 at 10:52:56AM +0200, Rene Buergel wrote:
> - Ursprüngliche Mail -
> > On Fri, Aug 03, 2012 at 05:06:27PM +0200, René Bürgel wrote:
> > > Hello,
> > >
> > > this is a patches-series for controllers using the ezusb-functions.
> > >
> > > ezusb: remove dependency to usb
Fix config warning:
warning: ( ... && DRM_USB) selects USB which has unmet direct dependencies
(USB_SUPPORT && USB_ARCH_HAS_HCD)
and build error:
ERROR: "usb_speed_string" [drivers/usb/core/usbcore.ko] undefined!
by adding the missing dependency on USB_ARCH_HAS_HCD to DRM_UDL and DRM_USB.
This
On Mon, Aug 20, 2012 at 11:23:16AM -0700, Guenter Roeck wrote:
> Fix config warning:
>
> warning: ( ... && DRM_USB) selects USB which has unmet direct dependencies
> (USB_SUPPORT && USB_ARCH_HAS_HCD)
>
> and build error:
> ERROR: "usb_speed_string" [drivers/usb/core/usbcore.ko] undefined!
>
> by
On platform_device_add() failure, the TUSB6010 glue layer forgets to call
platform_device_put() -- probably due to a typo...
Signed-off-by: Sergei Shtylyov
---
This patch is atop of 'musb' branch of Felipe's tree...
drivers/usb/musb/tusb6010.c |2 +-
1 file changed, 1 insertion(+), 1 delet
dma_controller_create() in this MUSB DMA driver only regards 0 as a wrong IRQ
number, despite platform_get_irq_byname() that it calls returns -EXDEV in that
case. It leads to calling request_irq() with a negative IRQ number, and when it
naturally fails, the following is printed to the console:
req
Hello.
On 08/20/2012 10:34 PM, Sergei Shtylyov wrote:
> dma_controller_create() in this MUSB DMA driver only regards 0 as a wrong IRQ
> number, despite platform_get_irq_byname() that it calls returns -EXDEV in that
Argh, dunno why I typed -EXDEV while actually it returns -ENXIO. Please fix
wh
The following changes since commit 731879f8e3d4c61220462160311fa650a8b96abf:
USB: qcserial: fix port handling on Gobi 1K and 2K+ (2012-08-16 09:48:03
-0700)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/ tags/usb-3.6-rc3
for you to fet
Anyone want to take this?
--
Matthew Garrett | mj...@srcf.ucam.org
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Andi Kleen
The usb core uses usb_speed_string(). But it's only selected
for USB_GADGET. Enable it unconditionally.
Fixes a lot of randconfig builds.
Cc: g...@kroah.com
Signed-off-by: Andi Kleen
---
drivers/usb/Makefile |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --
Please use Reply-To-All so that your messages get sent to the mailing
list as well as to me.
On Sun, 19 Aug 2012, Arnaud René Ober wrote:
> On 08/19/2012 03:53 PM, Alan Stern wrote:
> > On Sun, 19 Aug 2012, [ISO-8859-1] Arnaud Ren� Ober wrote:
> >
> >> Hello,
> >>
> >> I send you this mail becau
On Mon, Aug 20, 2012 at 08:36:56PM +0100, Matthew Garrett wrote:
> Anyone want to take this?
Sarah is on vacation until the end of this week, so I'd wait until then
to worry about it being lost.
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a mes
On 08/20/2012 09:39 PM, Alan Stern wrote:
Please use Reply-To-All so that your messages get sent to the mailing
list as well as to me.
On Sun, 19 Aug 2012, Arnaud René Ober wrote:
On 08/19/2012 03:53 PM, Alan Stern wrote:
On Sun, 19 Aug 2012, [ISO-8859-1] Arnaud Ren� Ober wrote:
Hello,
I s
On Mon, 20 Aug 2012, Andi Kleen wrote:
> From: Andi Kleen
>
> The usb core uses usb_speed_string(). But it's only selected
> for USB_GADGET. Enable it unconditionally.
What are you talking about? USB_COMMON isn't selected at all, but it
does get built whenever USB or USB_GAGDET is enabled. Fr
On Sun, Aug 19, 2012 at 01:53:26PM -0700, Kevin Cernekee wrote:
> > According to this code, i in iudma[] can be in 1..5. You could have more
> > than
> > one IRQ. The comment above this for loop is point less. So I think if you
> > can
> > only have _one_ idma irq than you could remove the for lo
On Mon, Aug 20, 2012 at 03:47:48PM -0400, Alan Stern wrote:
> On Mon, 20 Aug 2012, Andi Kleen wrote:
>
> > From: Andi Kleen
> >
> > The usb core uses usb_speed_string(). But it's only selected
> > for USB_GADGET. Enable it unconditionally.
>
> What are you talking about? USB_COMMON isn't selec
This patch (as1599) fixes dummy-hcd to make it update the appropriate
driver pointer when a new gadget driver is bound or unbound. Without
this change, the gadget driver's name doesn't appear in dev_printk
output.
Signed-off-by: Alan Stern
---
This is unrelated to the new ->reset callback stuf
This patch (as1598) adds support for the new "reset" callback to the
g_file_storage driver. Resets are handled slightly differently from
disconnects, in that the driver doesn't sync the backing storage file
during a reset but does during a disconnect.
The problem is that a file sync can take a lo
This patch (as1600) adds support for the new "reset" gadget callback
to the dummy-hcd driver.
Signed-off-by: Alan Stern
---
drivers/usb/gadget/dummy_hcd.c | 21 -
1 file changed, 12 insertions(+), 9 deletions(-)
Index: usb-3.5/drivers/usb/gadget/dummy_hcd.c
=
This patch (as1601) adds support for the new "reset" gadget callback
to the net2280 driver.
Signed-off-by: Alan Stern
---
drivers/usb/gadget/net2280.c | 42 --
1 file changed, 32 insertions(+), 10 deletions(-)
Index: usb-3.5/drivers/usb/gadget/net2280
This patch (as1602) adds support for the new "reset" gadget callback
to the net2272 driver.
Signed-off-by: Alan Stern
---
drivers/usb/gadget/net2272.c | 43 +--
1 file changed, 33 insertions(+), 10 deletions(-)
Index: usb-3.5/drivers/usb/gadget/net227
On 08/20/12 12:58, Andi Kleen wrote:
> On Mon, Aug 20, 2012 at 03:47:48PM -0400, Alan Stern wrote:
>> On Mon, 20 Aug 2012, Andi Kleen wrote:
>>
>>> From: Andi Kleen
>>>
>>> The usb core uses usb_speed_string(). But it's only selected
>>> for USB_GADGET. Enable it unconditionally.
>>
>> What are y
On Mon, 20 Aug 2012, Andi Kleen wrote:
> On Mon, Aug 20, 2012 at 03:47:48PM -0400, Alan Stern wrote:
> > On Mon, 20 Aug 2012, Andi Kleen wrote:
> >
> > > From: Andi Kleen
> > >
> > > The usb core uses usb_speed_string(). But it's only selected
> > > for USB_GADGET. Enable it unconditionally.
>
On Mon, Aug 20, 2012 at 04:42:44PM -0400, Alan Stern wrote:
> On Mon, 20 Aug 2012, Andi Kleen wrote:
>
> > On Mon, Aug 20, 2012 at 03:47:48PM -0400, Alan Stern wrote:
> > > On Mon, 20 Aug 2012, Andi Kleen wrote:
> > >
> > > > From: Andi Kleen
> > > >
> > > > The usb core uses usb_speed_string()
> Andi, care to try this again with this .config on Linus's tree to see if
> it all now works properly?
Works in mainline. Thanks.
-Andi
--
a...@linux.intel.com -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to major
On Aug 12, 2012, at 10:01 PM, Liu Shengzhou-B36685 wrote:
>
>
>> -Original Message-
>> From: Kumar Gala [mailto:ga...@kernel.crashing.org]
>> Sent: Friday, August 10, 2012 9:50 PM
>> To: Liu Shengzhou-B36685
>> Cc: linuxppc-...@lists.ozlabs.org list; linux-usb@vger.kernel.org;
>> gre...
On Fri, Aug 10, 2012 at 5:48 AM, Shengzhou Liu
wrote:
> + for (timeout = 1000; timeout > 0; timeout--) {
> + /* check PHY_CLK_VALID to get phy clk valid */
> + if (in_be32(non_ehci + FSL_SOC_USB_CTRL)
> +
From: Wei Yongjun
Since we will be removing items off the list using list_del() we need
to use a safer version of the list_for_each_entry() macro aptly named
list_for_each_entry_safe(). We should use the safe macro if the loop
involves deletions of items.
Signed-off-by: Wei Yongjun
---
drivers
On Mon, Aug 20, 2012 at 12:40 AM, Felipe Balbi wrote:
> no workqueues, please either handle the IRQ here or use threaded_irqs.
>
> again, no workqueues.
Felipe,
I am seeing all sorts of deadlocks now, after removing the workqueue
(patch V2). Some have easy fixes, but for others it is not as
obv
From: Fabio Estevam
Differently from mx28 and mx6q, the mx23 SoC has the following description
about ENHOSTDISCONDETECT bit in its Reference Manual:
"Due to a on chip issue (Errata #2791), software must pay attention to when
to assert the ENHOSTDISCONDETECT bit in HW_USBPHY_CTRL register:
1. Onl
From: Manoj Iyer
USB 3.0 devices show up as high-speed devices on powerup, after an
s3 cycle they are correctly recognized as SuperSpeed. At powerup
unconditionally switch the port to xHCI like we do when we resume
from suspend.
BugLink: http://bugs.launchpad.net/bugs/1000424
Test results:
This
From: Manoj Iyer
USB 3.0 devices show up as high-speed devices on powerup, after an
s3 cycle they are correctly recognized as SuperSpeed. At powerup
unconditionally switch the port to xHCI like we do when we resume
from suspend.
BugLink: http://bugs.launchpad.net/bugs/1000424
Signed-off-by: Man
On Tuesday, August 21, 2012 at 12:04 PM, Fabio Estevam wrote:
> From: Fabio Estevam (mailto:fabio.este...@freescale.com)>
>
> Differently from mx28 and mx6q, the mx23 SoC has the following description
> about ENHOSTDISCONDETECT bit in its Reference Manual:
>
> "Due to a on chip issue (Errata #27
Sean,
On Tue, Aug 21, 2012 at 1:38 AM, Sean Cross wrote:
> Do disconnect and reconnect still work? I was under the impression that this
> particular solution would allow the
Yes, disconnect/connect works fine. I tested the sequence several
times in a row.
The reason that it did not work on y
>
> drivers/usb/gadget/f_mass_storage.c |5 +++--
> drivers/usb/gadget/file_storage.c | 20
> drivers/usb/gadget/storage_common.c |3 ++-
> 3 files changed, 21 insertions(+), 7 deletions(-)
>
> Index: usb-3.5/drivers/usb/gadget/storage_common.c
>
71 matches
Mail list logo
