Re: infos about device ZTE MF821D 2G,3G,4G/LTE usb-modem/networkcard

2012-07-09 Thread Oliver Neukum
Am Sonntag, 8. Juli 2012, 13:32:42 schrieb Thomas Schäfer: > Not for kernel-code, but usefull for testers/users: > > > udev-rules/usb_modeswitch > > > /lib/udev/rules.d/40-usb_modeswitch.rules Thank you! Could you also post lsusb -v for the card? Regards Oliver -- To

[RFC PATCH 1/1] usb: phy: move usb_otg_state from struct usb_phy to struct usb_otg

2012-07-09 Thread Peter Chen
Since we will have a standalone USB PHY layer, the first step is to move some non-PHY related things out of struct usb_phy. It has lots of things need to do, this one is just the beginning. The enum usb_otg_state should be not relationship with USB PHY, so move it out. A formal patch should incl

Re: infos about device ZTE MF821D 2G,3G,4G/LTE usb-modem/networkcard

2012-07-09 Thread Bjørn Mork
Thomas Schäfer writes: > The modem works at /dev/USB2. > > In my point of view "19d2 0326" should/could be added to the option driver. Yes, that seems best at the moment given that the interface layout isn't Gobi so the qcserial driver cannot be used. You should match on class/subclass/protoco

Re: Infinite looping in omap2430.c USB driver

2012-07-09 Thread Tony Lindgren
* NeilBrown [120706 15:44]: > > Hello `./scripts/get_maintainer.pl -f drivers/usb/musb/omap2430.c` > > omap2430_musb_set_vbus in omap2430.c contains: > > while (musb_readb(musb->mregs, MUSB_DEVCTL) & 0x80) { > > cpu_relax(); > >

[PATCH v2] usb: host: Fix possible kernel crash

2012-07-09 Thread Venu Byravarasu
In functions itd_complete & sitd_complete, a pointer by name stream may get dereferenced after freeing it, when iso_stream_put is called with stream->refcount = 2. Hence fixing it. Signed-off-by: Venu Byravarasu --- In Patchset 1, modified parameter of iso_stream_put() to handle the crash. How

Re: [PATCH V7 2/9] usb: make usb port a real device

2012-07-09 Thread Sarah Sharp
On Sun, Jul 08, 2012 at 09:28:35AM -0700, Greg KH wrote: > On Sat, Jul 07, 2012 at 08:05:47PM -0400, Sarah Sharp wrote: > > On Fri, Jul 06, 2012 at 11:12:32AM -0700, Greg KH wrote: > > > On Fri, Jul 06, 2012 at 02:13:53PM +0800, Lan Tianyu wrote: > > > Don't split strings across a line, it makes it

Re: usb sound issue - any ideas?

2012-07-09 Thread Sarah Sharp
On Mon, Jul 09, 2012 at 02:07:42PM +0800, Andiry Xu wrote: > On 07/08/2012 08:50 PM, Dr. Ing. Dieter Jurzitza wrote: > >Dear listmembers, > >recently I switched to a new pc, making use of an external USB sound device. > >The problem: when I log off a kde-session and log in again, the sound device >

[PATCH v1] usb: host: Fix possible kernel crash

2012-07-09 Thread Venu Byravarasu
In functions itd_complete & sitd_complete, a pointer by name stream may get dereferenced after freeing it, when iso_stream_put is called with stream->refcount = 2. Hence fixing it. Signed-off-by: Venu Byravarasu --- By mistake sent incorrect patch set number as v2 earlier. Hence fixing it. dr

Re: [PATCH V7 2/9] usb: make usb port a real device

2012-07-09 Thread Bjørn Mork
Sarah Sharp writes: > On Sun, Jul 08, 2012 at 09:28:35AM -0700, Greg KH wrote: >> On Sat, Jul 07, 2012 at 08:05:47PM -0400, Sarah Sharp wrote: >> > On Fri, Jul 06, 2012 at 11:12:32AM -0700, Greg KH wrote: >> > > On Fri, Jul 06, 2012 at 02:13:53PM +0800, Lan Tianyu wrote: >> > > Don't split strings

Re: usb sound issue - any ideas?

2012-07-09 Thread dieter.jurzi...@t-online.de
Dear Sarah, dear Andiry, thank you very much for your inputs. If you, Sarah, could be a little more precise for a (nearly ) non programmer what you'd like to see in terms of code lines (WARN_ON(), but where ...) I could apply a corresponding patch and would gladly provide anything my kernel

Re: [PATCH 1/7] usb: gadget: mv_udc: reduce the delay time

2012-07-09 Thread Sergei Shtylyov
Hello. On 09-07-2012 6:27, Neil Zhang wrote: >> -Original Message- >> From: Sergei Shtylyov [mailto:sshtyl...@mvista.com] >> Sent: 2012年7月7日 1:34 >> To: Neil Zhang >> Cc: ba...@ti.com; gre...@linuxfoundation.org; Chao Xie; >> khoroshi...@ispras.ru; linux-usb@vger.kernel.org >> Subject: Re

USB: panic with printk

2012-07-09 Thread Manuel Lauss
Hello, Current 3.5-rc5-git panics on my MIPS targets during USB host controller initialization. Disabling CONFIG_PRINTK fixes it. ehci_hcd: USB 2.0 'Enhanced' Host Controller (EHCI) Driver au1xxx-ehci au1xxx-ehci.0: Au1xxx EHCI au1xxx-ehci au1xxx-ehci.0: new USB bus registered, assigned bus numbe

[PATCH 1/3] arm: omap: hwmod: add new memory resource for usb phy cont

2012-07-09 Thread Damodar Santhapuri
From: Ajay Kumar Gupta Added usb_ctrl0 and usb_ctrl1 base address as new memory resources which will be used at am335x musb driver glue layer to turn on or off builin PHY. This is needed untill we have a separate system control module driver. Signed-off-by: Ajay Kumar Gupta Signed-off-by: Damod

[PATCH 2/3] usb: musb: dsps: add phy control logic to glue

2012-07-09 Thread Damodar Santhapuri
From: Ajay Kumar Gupta AM335x uses NOP transceiver driver and need to enable builtin PHY by writing into usb_ctrl register available in system control module register space. This is being added at musb glue driver layer untill a separate system control module driver is available. Signed-off-by:

[PATCH 3/3] usb: musb: dsps: enable phy control for am335x

2012-07-09 Thread Damodar Santhapuri
From: Ajay Kumar Gupta Enabled the phy control logic for am335x also based on usbss revision register. Signed-off-by: Ajay Kumar Gupta Signed-off-by: Damodar Santhapuri --- Earlier version of this patch based on function pointer was submitted at http://marc.info/?l=linux-usb&m=133583281512646&

[PATCH] usb/hcd: Ensure scatter-gather is not used for isoc transfers

2012-07-09 Thread Hans de Goede
We don't support sg for isoc transfers, enforce this. Signed-off-by: Hans de Goede Acked-by: Alan Stern --- drivers/usb/core/hcd.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c index 140d3e1..f546102 100644 --- a/

Re: [PATCH v2 1/1] Input: xpad - Handle all variations of Mad Catz Beat Pad

2012-07-09 Thread Jiri Kosina
On Sun, 8 Jul 2012, Yuri Khan wrote: > * Add a quirk to usbhid to ignore this device > --- > drivers/hid/hid-ids.h |3 +++ > drivers/hid/usbhid/hid-quirks.c |2 ++ > drivers/input/joystick/xpad.c |1 + > 3 files changed, 6 insertions(+) > > diff --git a/drivers/hid/hid-id

[PATCH v2] usb: musb: implement (un)map_urb_for_dma hooks

2012-07-09 Thread Ruslan Bilovol
MUSB controller cannot work in DMA mode with misaligned buffers, switching in PIO mode. HCD core has hooks that allow to override the default DMA mapping and unmapping routines for host controllers that have special DMA requirements, such as alignment contraints. It is observed that work in PIO m

Re: [PATCH 1/2] usb: gadget: composite: Race between disconnect/unbind and setup

2012-07-09 Thread Alan Stern
On Sun, 8 Jul 2012, Kevin Cernekee wrote: > On Sun, Jul 8, 2012 at 5:33 PM, Alan Stern wrote: > > On Sun, 8 Jul 2012, Kevin Cernekee wrote: > > > >> usb_gadget_remove_driver() runs through a four-step sequence to shut down > >> the gadget driver.  For the case of a composite gadget + at91 UDC, th

Re: [PATCH] From 2.6.39-rc1 onward, the Logitech Quickcam Fusion webcam (046d:08c1) stops

2012-07-09 Thread Alan Stern
On Sun, 8 Jul 2012, Jonathan Nieder wrote: > Eric Ding wrote: > > > So it looks like you'd have to both look for USB_CLASS_VIDEO and check > > uvc_ids[] too... which becomes somewhat hairy, since I assume you don't > > realy want usb_detect_quirks() to reference UVC-specific structs... > > which

Re: USB: panic with printk

2012-07-09 Thread Alan Stern
On Mon, 9 Jul 2012, Manuel Lauss wrote: > Hello, > > Current 3.5-rc5-git panics on my MIPS targets during USB host > controller initialization. > Disabling CONFIG_PRINTK fixes it. > > ehci_hcd: USB 2.0 'Enhanced' Host Controller (EHCI) Driver > au1xxx-ehci au1xxx-ehci.0: Au1xxx EHCI > au1xxx-ehc

Re: [PATCH v1] usb: host: Fix possible kernel crash

2012-07-09 Thread Alan Stern
On Mon, 9 Jul 2012, Venu Byravarasu wrote: > In functions itd_complete & sitd_complete, a pointer > by name stream may get dereferenced after freeing it, when > iso_stream_put is called with stream->refcount = 2. I don't understand the problem. Did you actually see this happen or is it only th

Re: [PATCH 2/3] usb: musb: dsps: add phy control logic to glue

2012-07-09 Thread ABRAHAM, KISHON VIJAY
Hi, On Mon, Jul 9, 2012 at 7:18 PM, Damodar Santhapuri wrote: > From: Ajay Kumar Gupta > > AM335x uses NOP transceiver driver and need to enable builtin PHY > by writing into usb_ctrl register available in system control > module register space. This is being added at musb glue driver > layer un

[PATCH] PCI: EHCI: fix crash during suspend on ASUS computers

2012-07-09 Thread Alan Stern
Quite a few ASUS computers experience a nasty problem, related to the EHCI controllers, when going into system suspend. It was observed that the problem didn't occur if the controllers were not put into the D3 power state before starting the suspend, and commit 151b61284776be2d6f02d48c23c362567896

Re: usbutils 006 release

2012-07-09 Thread Alan Stern
On Fri, 6 Jul 2012, Greg KH wrote: > Here's the 006 release of usbutils. > > Some USB 3.0 updates, a new usb.ids file update, and a number of other > fixes and updates for annoying problems that people had reported. Full > shortlog information is below if people are curious. > > The package can

Re: infos about device ZTE MF821D 2G,3G,4G/LTE usb-modem/networkcard

2012-07-09 Thread Thomas Schäfer
Am 09.07.2012 10:22, schrieb Oliver Neukum: Am Sonntag, 8. Juli 2012, 13:32:42 schrieb Thomas Schäfer: Not for kernel-code, but usefull for testers/users: udev-rules/usb_modeswitch /lib/udev/rules.d/40-usb_modeswitch.rules Be careful. The expert from draisberghof told me yesterday that is

Re: [PATCH v2 1/1] Input: xpad - Handle all variations of Mad Catz Beat Pad

2012-07-09 Thread Yuri Khan
On Mon, Jul 9, 2012 at 9:08 PM, Jiri Kosina wrote: >> --- a/drivers/hid/usbhid/hid-quirks.c >> +++ b/drivers/hid/usbhid/hid-quirks.c >> + { USB_VENDOR_ID_MADCATZ, USB_DEVICE_ID_MADCATZ_BEATPAD, >> HID_QUIRK_IGNORE }, > > Please put it in drivers/hid/hid-core.c, hid_ignore_list[] array instea

Re: [PATCH 2/2 ver. 2] EHCI: centralize controller initialization

2012-07-09 Thread Greg KH
On Fri, Jun 29, 2012 at 11:42:46AM -0400, Alan Stern wrote: > This patch (as1564b) converts the EHCI platform drivers to use the > central ehci_setup() routine for generic controller initialization > rather than each having its own idiosyncratic approach. > > The major point of difficulty lies in

Re: Bug#677472: [3.1->3.2 regression] Immediate wake on suspend, associated with OHCI on MCP51

2012-07-09 Thread Octavio Alvarez
On Sun, 08 Jul 2012 17:28:25 -0700, Alan Stern wrote: >> Removing my pen drive cleared CCS on [6]. > > Okay, that explains that. More or less. Is this an old USB-1.1 pen > drive? If it is USB-2.0 then I would expect it to connect to the EHCI > controller, not the OHCI controller. I don't

Re: [PATCH] PCI: EHCI: fix crash during suspend on ASUS computers

2012-07-09 Thread Rafael J. Wysocki
On Monday, July 09, 2012, Alan Stern wrote: > Quite a few ASUS computers experience a nasty problem, related to the > EHCI controllers, when going into system suspend. It was observed > that the problem didn't occur if the controllers were not put into the > D3 power state before starting the susp

Re: [PATCH] PCI: EHCI: fix crash during suspend on ASUS computers

2012-07-09 Thread Greg KH
On Mon, Jul 09, 2012 at 06:50:24PM +0200, Rafael J. Wysocki wrote: > On Monday, July 09, 2012, Alan Stern wrote: > > Quite a few ASUS computers experience a nasty problem, related to the > > EHCI controllers, when going into system suspend. It was observed > > that the problem didn't occur if the

Re: [PATCH v9 REBASE 6/9] USB: notify phy when root hub port connect change

2012-07-09 Thread Greg KH
On Sat, Jul 07, 2012 at 10:56:45PM +0800, Richard Zhao wrote: > Phy may need to change settings when port connect change. > > Signed-off-by: Richard Zhao > Tested-by: Subodh Nijsure > --- > drivers/usb/core/hub.c |8 > 1 file changed, 8 insertions(+) > > diff --git a/drivers/usb/c

Re: [PATCH v9 REBASE 0/9] add imx usb driver based on Greg next tree

2012-07-09 Thread Greg KH
On Sat, Jul 07, 2012 at 10:56:39PM +0800, Richard Zhao wrote: > The work is based on ci13xxx rework done by Alexander Shishkin. > > To let Greg pick up, I also added patches Alex queued that I depends on. I've applied everything but patch number 6, which I've responded to with some questions abo

Re: 3.4.4: disabling irq

2012-07-09 Thread Udo van den Heuvel
On 2012-07-09 15:54, Clemens Ladisch wrote: > (forwarded to linux-usb) > > Udo van den Heuvel wrote: >> Hello, >> >> One moment the box is runing OK. >> One moment the 3.4.4 kernel decides to disable an interrupt. >> Why? >> >> Jul 8 07:43:49 box3 ntpd[5067]: parse: convert_rawdcf: INCOMPLETE DAT

[PATCH RESEND] usb: gadget: composite: parse dt values

2012-07-09 Thread Alexandre Pereira da Silva
Grab the devicetree node properties to override VendorId, ProductId, bcdDevice, Manucacturer, Product and SerialNumber Signed-off-by: Alexandre Pereira da Silva Acked-by: Michal Nazarewicz Acked-by: Rob Herring --- Documentation/devicetree/bindings/usb/gadget.txt | 20 +++ drivers/us

Re: [PATCH] USB: maintainers: change of mail

2012-07-09 Thread Greg Kroah-Hartman
On Thu, Jul 05, 2012 at 09:44:18AM +0200, Oliver Neukum wrote: > From 36847fa21bbbe1b2164b7376a0ed73c33374cc78 Mon Sep 17 00:00:00 2001 > From: Oliver Neukum > Date: Thu, 5 Jul 2012 09:42:41 +0200 > Subject: [PATCH] maintainers: change of mail Please don't embed git patches with this header withi

Re: [PATCH 2/2 ver. 2] EHCI: centralize controller initialization

2012-07-09 Thread Alan Stern
On Mon, 9 Jul 2012, Greg KH wrote: > On Fri, Jun 29, 2012 at 11:42:46AM -0400, Alan Stern wrote: > > This patch (as1564b) converts the EHCI platform drivers to use the > > central ehci_setup() routine for generic controller initialization > > rather than each having its own idiosyncratic approach.

[PATCH] usb: gadget: udc-core: Race between disconnect/unbind and setup

2012-07-09 Thread Kevin Cernekee
On Mon, Jul 9, 2012 at 7:15 AM, Alan Stern wrote: > > What I see is that usb_gadget_disconnect() does tell the UDC driver to > > stop activity on the port, but that only happens after > > composite_disconnect() was called. Can you confirm that the order of > > the calls in usb_gadget_remove_drive

Re: [PATCH 2/2 ver. 2] EHCI: centralize controller initialization

2012-07-09 Thread Greg KH
On Mon, Jul 09, 2012 at 02:39:42PM -0400, Alan Stern wrote: > On Mon, 9 Jul 2012, Greg KH wrote: > > > On Fri, Jun 29, 2012 at 11:42:46AM -0400, Alan Stern wrote: > > > This patch (as1564b) converts the EHCI platform drivers to use the > > > central ehci_setup() routine for generic controller init

Re: 3.4.4: disabling irq

2012-07-09 Thread Alan Stern
On Mon, 9 Jul 2012, Clemens Ladisch wrote: > (forwarded to linux-usb) > > Udo van den Heuvel wrote: > > Hello, > > > > One moment the box is runing OK. > > One moment the 3.4.4 kernel decides to disable an interrupt. > > Why? The kernel disables IRQs when too many interrupts arrive too quickly.

Re: Bug#677472: [3.1->3.2 regression] Immediate wake on suspend, associated with OHCI on MCP51

2012-07-09 Thread Alan Stern
On Mon, 9 Jul 2012, Octavio Alvarez wrote: > On Sun, 08 Jul 2012 17:28:25 -0700, Alan Stern > wrote: > > >> >> Removing my pen drive cleared CCS on [6]. > >> > > >> > Okay, that explains that. More or less. Is this an old USB-1.1 pen > >> > drive? If it is USB-2.0 then I would expect it to

Re: [PATCH 2/2 ver. 2] EHCI: centralize controller initialization

2012-07-09 Thread Alan Stern
On Mon, 9 Jul 2012, Greg KH wrote: > > > > Ver. 2: Rebased on top of Russ Dill's changes to ehci-omap.c. > > > > Fixed several mistakes involving unused local variables and calls to > > > > ehci_setup(ehci) rather than ehci_setup(hcd). > > > > > > I'm getting a conflict when trying to apply this

[PATCH 2/2 ver. 3] EHCI: centralize controller initialization

2012-07-09 Thread Alan Stern
This patch (as1564c) converts the EHCI platform drivers to use the central ehci_setup() routine for generic controller initialization rather than each having its own idiosyncratic approach. The major point of difficulty lies in ehci-pci's many vendor- and device-specific workarounds. Some of them

Re: infos about device ZTE MF821D 2G,3G,4G/LTE usb-modem/networkcard

2012-07-09 Thread Thomas Schäfer
Am Montag, 9. Juli 2012, 10:25:27 schrieben Sie: > Thomas Schäfer writes: > > The modem works at /dev/USB2. > posted: > | diag 19d2:0326 MI00\6 > | nema 19d2:0326 MI01\6 > | at- 19d2:0326 MI02\6 > | modem 19d2:0326 MI03\6 > | ndis 19d2:0326 MI04\6 > > I am wondering a bit about the "modem"

[PATCH] maintainers: change of mail

2012-07-09 Thread Oliver Neukum
>From 36847fa21bbbe1b2164b7376a0ed73c33374cc78 Mon Sep 17 00:00:00 2001 From: Oliver Neukum Date: Thu, 5 Jul 2012 09:42:41 +0200 Subject: [PATCH] maintainers: change of mail The .name package has run out Signed-off-by: Oliver Neukum --- MAINTAINERS | 10 +- 1 files changed, 5 inserti

Re: infos about device ZTE MF821D 2G,3G,4G/LTE usb-modem/networkcard

2012-07-09 Thread Thomas Schäfer
I wrote: > Be careful. The expert from draisberghof told me yesterday that is only > the SCSI-command for eject and > can have collateral damage. The latter is rubbish I misunderstood his statement: > http://www.draisberghof.de/usb_modeswitch/bb/viewtopic.php?t=946 Sorry, for confusion.

Re: [PATCH] maintainers: change of mail

2012-07-09 Thread Greg Kroah-Hartman
On Mon, Jul 09, 2012 at 11:41:55PM +0200, Oliver Neukum wrote: > From 36847fa21bbbe1b2164b7376a0ed73c33374cc78 Mon Sep 17 00:00:00 2001 > From: Oliver Neukum > Date: Thu, 5 Jul 2012 09:42:41 +0200 > Subject: [PATCH] maintainers: change of mail > > The .name package has run out > > Signed-off-by:

Re: Mac USB 3.0 Linux support Fwd: [tova-technical-support] Request 2012/06/14/00000005 from Nancy Blum (SN: 20051 )

2012-07-09 Thread Ian Osgood
Sarah, Here is the latest. We intercepted a MacBookPro10,1 for testing (what our CEO doesn't know won't hurt him) and reconfigured our 3.4.2 kernel with CONFIG_USB_XHCI_HCD_DEBUGGING. Here are notes on what happens when we boot it: Symptoms: MacBookPro10,1 (two USB 3.0 ports, Retina display

Re: Mac USB 3.0 Linux support Fwd: [tova-technical-support] Request 2012/06/14/00000005 from Nancy Blum (SN: 20051 )

2012-07-09 Thread Peter Stuge
Ian Osgood wrote: > dmesg errors: > xhci_hcd :00:14.0: xhci_run > xhci_hcd :00:14.0: Failed to enable MSI-X > xhci_hcd :00:14.0: failed to allocate MSI entry > xhci_hcd :00:14.0: No msi-x/msi found and no IRQ in BIOS > xhci_hcd :00:14.0: startup error -22 > xhci_hcd :00:14.0

Re: [PATCH 1/2] usb: gadget: composite: Race between disconnect/unbind and setup

2012-07-09 Thread Peter Chen
> > They might need to be changed. It does seems like a bad idea to tell > the gadget driver that a disconnect occurred before the host knows > about it. > Yes, it should pull down dp first, then, tell class driver, it has been disconnected. > If you change the order of those two calls, does that

Re: [PATCH] usb: gadget: udc-core: Race between disconnect/unbind and setup

2012-07-09 Thread Peter Chen
> Some gadget drivers, such as composite, assume this will never happen > and crash as a result. > > The fix is to quiesce the UDC hardware (via usb_gadget_disconnect) > before running the gadget driver through the disconnect/unbind sequence. > > Signed-off-by: Kevin Cernekee > --- > drivers/usb/

Re: [PATCH v9 REBASE 6/9] USB: notify phy when root hub port connect change

2012-07-09 Thread Richard Zhao
On Mon, Jul 09, 2012 at 09:57:57AM -0700, Greg KH wrote: > On Sat, Jul 07, 2012 at 10:56:45PM +0800, Richard Zhao wrote: > > Phy may need to change settings when port connect change. > > > > Signed-off-by: Richard Zhao > > Tested-by: Subodh Nijsure > > --- > > drivers/usb/core/hub.c |8

Re: Mac USB 3.0 Linux support Fwd: [tova-technical-support] Request 2012/06/14/00000005 from Nancy Blum (SN: 20051 )

2012-07-09 Thread Ian Osgood
On Jul 9, 2012, at 5:59 PM, Peter Stuge wrote: > Ian Osgood wrote: >> dmesg errors: >> xhci_hcd :00:14.0: xhci_run >> xhci_hcd :00:14.0: Failed to enable MSI-X >> xhci_hcd :00:14.0: failed to allocate MSI entry >> xhci_hcd :00:14.0: No msi-x/msi found and no IRQ in BIOS >> xhci_hc

[PATCH 1/7 v2] usb: gadget: mv_udc: reduce the delay interval

2012-07-09 Thread Neil Zhang
There are several places use udelay(LOOPS_USEC) to wait the status to be changed, but the delay interval is a bit too long, so reduce it to enhance the performance. Signed-off-by: Neil Zhang --- drivers/usb/gadget/mv_udc_core.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --

[PATCH 0/7 v2] usb: gadget: mv_udc: bug fix and feature add

2012-07-09 Thread Neil Zhang
This patch set will add ISO support for mv_udc and do some bug fix. ChangeLog: V2: 1. Fix some syntax error in comments. 2. Use usb_endpoint_xfer_isoc instead of redundant code, thanks Sergei. Chao Xie (1): usb: gadget: mv_udc: add iso support Neil Zhang (5): usb: gadget: mv_udc: reduce the

[PATCH 3/7 v2] usb: gadget: mv_udc: avoid sleeping on spinlock

2012-07-09 Thread Neil Zhang
build_dtd() can be called when hold a spinlock, but GFP_KERNEL may cause dma_pool_alloc() sleep, So we need use GFP_ATOMIC instead of GFP_KERNEL. But using GFP_ATOMIC may cause failure when allocating memory, add error handler to handle it. Signed-off-by: Alexey Khoroshilov Signed-off-by: Neil Zh

[PATCH 2/7 v2] usb: gadget: mv_udc: remove unused code

2012-07-09 Thread Neil Zhang
Clean unused code for mv_udc driver. Signed-off-by: Neil Zhang --- drivers/usb/gadget/mv_udc_core.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/usb/gadget/mv_udc_core.c b/drivers/usb/gadget/mv_udc_core.c index 9e40f89..c05d340 100644 --- a/drivers/usb/gadget

[PATCH 5/7 v2] usb: gadget: mv_udc: add iso support

2012-07-09 Thread Neil Zhang
From: Chao Xie In order to support iso, we need do the following things: 1. fix length for one dtd 2. allow req contains multiple packets for a ISO transfer Signed-off-by: Chao Xie Signed-off-by: Yu Xu Signed-off-by: Neil Zhang --- drivers/usb/gadget/mv_udc_core.c | 21 +---

[PATCH 4/7 v2] usb: gadget: mv_udc: enable stream mode

2012-07-09 Thread Neil Zhang
According to ChipIdea's reference manual in section 8.5.2 "Non-streaming operational mode in device mode", we'd better enable stream mode, especially that ISO endpoints are not supported when the SDIS bit is set. Signed-off-by: Neil Zhang --- drivers/usb/gadget/mv_udc_core.c |2 +- 1 files c

[PATCH 7/7 v2] usb: gadget: mv_udc: fix boot up hang

2012-07-09 Thread Neil Zhang
Fix boot up hang when enable udc without otg enabled. The root cause is that the clock will be shut down when probe routine is finished because of clock gating. When a gadget driver is registered at this time, it will call mv_udc_start which in turn will call mv_udc_vbus_session. If there is no cab

[PATCH 6/7 v2] usb: gadget: mv_udc: fix hang when shutdown

2012-07-09 Thread Neil Zhang
From: Yunfan Zhang Fix system hang in udc shutdown routine which caused by accessing usb register when clock is disabled. So enable usb clock before access register. Signed-off-by: Yunfan Zhang Signed-off-by: Neil Zhang --- drivers/usb/gadget/mv_udc_core.c |2 ++ 1 files changed, 2 insert

Re: [PATCH v9 REBASE 0/9] add imx usb driver based on Greg next tree

2012-07-09 Thread Marek Vasut
Dear Greg KH, > On Sat, Jul 07, 2012 at 10:56:39PM +0800, Richard Zhao wrote: > > The work is based on ci13xxx rework done by Alexander Shishkin. > > > > To let Greg pick up, I also added patches Alex queued that I depends on. > > I've applied everything but patch number 6, which I've responded

Re: [PATCH v9 REBASE 6/9] USB: notify phy when root hub port connect change

2012-07-09 Thread Richard Zhao
On Sat, Jul 07, 2012 at 10:56:45PM +0800, Richard Zhao wrote: > Phy may need to change settings when port connect change. > > Signed-off-by: Richard Zhao > Tested-by: Subodh Nijsure > --- > drivers/usb/core/hub.c |8 > 1 file changed, 8 insertions(+) > > diff --git a/drivers/usb/c

Re: [PATCH v9 REBASE 6/9] USB: notify phy when root hub port connect change

2012-07-09 Thread Marek Vasut
Dear Richard Zhao, > On Sat, Jul 07, 2012 at 10:56:45PM +0800, Richard Zhao wrote: > > Phy may need to change settings when port connect change. > > > > Signed-off-by: Richard Zhao > > Tested-by: Subodh Nijsure > > --- > > > > drivers/usb/core/hub.c |8 > > 1 file changed, 8 inse

Re: [PATCH v1] usb: host: Fix possible kernel crash

2012-07-09 Thread Venu Byravarasu
Thanks Alan for your comments. On Monday 09 July 2012 08:04 PM, Alan Stern wrote: On Mon, 9 Jul 2012, Venu Byravarasu wrote: In functions itd_complete & sitd_complete, a pointer by name stream may get dereferenced after freeing it, when iso_stream_put is called with stream->refcount = 2. I d

Re: [PATCH v1 01/11] drivers: usb: otg: add a new driver for omap usb2 phy

2012-07-09 Thread Rajendra Nayak
diff --git a/Documentation/devicetree/bindings/usb/omap-usb.txt b/Documentation/devicetree/bindings/usb/omap-usb.txt new file mode 100644 index 000..80a28c9 --- /dev/null +++ b/Documentation/devicetree/bindings/usb/omap-usb.txt @@ -0,0 +1,16 @@ +OMAP USB PHY + +OMAP USB2 PHY + +Required prope

Re: [PATCH v1 05/11] drivers: usb: twl6030: Add dt support for twl6030 usb

2012-07-09 Thread Rajendra Nayak
On Thursday 28 June 2012 05:21 PM, Kishon Vijay Abraham I wrote: Add device tree support for twl6030 usb driver. Update the Documentation with device tree binding information. Signed-off-by: Kishon Vijay Abraham I --- .../devicetree/bindings/usb/twl-usb.txt| 18 drivers

Re: [PATCH v1 07/11] drivers: usb: twl4030: Add device tree support for twl4030 usb

2012-07-09 Thread Rajendra Nayak
On Thursday 28 June 2012 05:21 PM, Kishon Vijay Abraham I wrote: Add device tree support for twl6030 usb driver. twl4030? Update the Documentation with device tree binding information. Signed-off-by: Kishon Vijay Abraham I --- .../devicetree/bindings/usb/twl-usb.txt| 19 +

RE: [PATCH v1 01/11] drivers: usb: otg: add a new driver for omap usb2 phy

2012-07-09 Thread Venu Byravarasu
> > + > > +#ifdef CONFIG_PM Should it not be CONFIG_PM_SLEEP instead of just CONFIG_PM? > > + > > +static int omap_usb2_runtime_suspend(struct device *dev) > > +{ > > + struct platform_device *pdev = to_platform_device(dev); > > + struct omap_usb *phy = platform_get_drvdata(pdev); > > + >

RE: [PATCH 2/3] usb: musb: dsps: add phy control logic to glue

2012-07-09 Thread Gupta, Ajay Kumar
Hi, > > On Mon, Jul 9, 2012 at 7:18 PM, Damodar Santhapuri > wrote: > > From: Ajay Kumar Gupta > > > > AM335x uses NOP transceiver driver and need to enable builtin PHY > > by writing into usb_ctrl register available in system control > > module register space. This is being added at musb glue d

Re: [PATCH 2/3] usb: musb: dsps: add phy control logic to glue

2012-07-09 Thread ABRAHAM, KISHON VIJAY
Hi, On Tue, Jul 10, 2012 at 11:35 AM, Gupta, Ajay Kumar wrote: > Hi, >> >> On Mon, Jul 9, 2012 at 7:18 PM, Damodar Santhapuri >> wrote: >> > From: Ajay Kumar Gupta >> > >> > AM335x uses NOP transceiver driver and need to enable builtin PHY >> > by writing into usb_ctrl register available in sys

Re: [PATCH v1 08/11] arm/dts: Add twl4030-usb data

2012-07-09 Thread Rajendra Nayak
On Thursday 28 June 2012 05:21 PM, Kishon Vijay Abraham I wrote: Add twl4030-usb data node in twl4030 device tree file. Signed-off-by: Kishon Vijay Abraham I --- arch/arm/boot/dts/twl4030.dtsi | 21 + 1 files changed, 21 insertions(+), 0 deletions(-) diff --git a/arch/a

RE: [PATCH 2/3] usb: musb: dsps: add phy control logic to glue

2012-07-09 Thread Gupta, Ajay Kumar
Hi, > On Tue, Jul 10, 2012 at 11:35 AM, Gupta, Ajay Kumar > wrote: > > Hi, > >> > >> On Mon, Jul 9, 2012 at 7:18 PM, Damodar Santhapuri > >> wrote: > >> > From: Ajay Kumar Gupta > >> > > >> > AM335x uses NOP transceiver driver and need to enable builtin PHY > >> > by writing into usb_ctrl regist

Re: [PATCH v1 10/11] arm/dts: omap: Add usb_otg and glue data

2012-07-09 Thread Rajendra Nayak
On Thursday 28 June 2012 05:21 PM, Kishon Vijay Abraham I wrote: Add usb otg data node in omap4/omap3 device tree file. Also update the node with board specific setting in omapx-.dts file. Signed-off-by: Kishon Vijay Abraham I --- arch/arm/boot/dts/omap3-beagle.dts |6 ++ arch/arm/boo

Re: [PATCH v1 05/11] drivers: usb: twl6030: Add dt support for twl6030 usb

2012-07-09 Thread ABRAHAM, KISHON VIJAY
Hi, On Tue, Jul 10, 2012 at 11:28 AM, Rajendra Nayak wrote: > On Thursday 28 June 2012 05:21 PM, Kishon Vijay Abraham I wrote: >> >> Add device tree support for twl6030 usb driver. >> Update the Documentation with device tree binding information. >> >> Signed-off-by: Kishon Vijay Abraham I >> ---

Re: [PATCH v1 11/11] arm: omap: phy: remove unused functions from omap-phy-internal.c

2012-07-09 Thread Rajendra Nayak
On Thursday 28 June 2012 05:21 PM, Kishon Vijay Abraham I wrote: All the unnessary functions in omap-phy-internal is removed. These functionality are now handled by omap-usb2 phy driver. Cc: Felipe Balbi Signed-off-by: Kishon Vijay Abraham I Acked-by: Tony Lindgren --- arch/arm/mach-omap2/omap

[PATCH] usb: twl6030-usb: variable otg not declared in twl6030_usbotg_irq() in linux-next

2012-07-09 Thread Gerard Snitselaar
commit ff9cce82 added back 2 lines that were removed by commit c83a8542 causing build of twl6030-usb to get an error due to otg being referenced, but not declared. This patch removes those 2 lines again to restore intent of commit c83a8542. Signed-off-by: Gerard Snitselaar --- drivers/usb/otg/tw

Re: [PATCH v1 01/11] drivers: usb: otg: add a new driver for omap usb2 phy

2012-07-09 Thread ABRAHAM, KISHON VIJAY
Hi, On Tue, Jul 10, 2012 at 11:16 AM, Rajendra Nayak wrote: >> diff --git a/Documentation/devicetree/bindings/usb/omap-usb.txt >> b/Documentation/devicetree/bindings/usb/omap-usb.txt >> new file mode 100644 >> index 000..80a28c9 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/usb/

Re: [PATCH v1 05/11] drivers: usb: twl6030: Add dt support for twl6030 usb

2012-07-09 Thread Rajendra Nayak
On Tuesday 10 July 2012 11:58 AM, ABRAHAM, KISHON VIJAY wrote: Hi, On Tue, Jul 10, 2012 at 11:28 AM, Rajendra Nayak wrote: On Thursday 28 June 2012 05:21 PM, Kishon Vijay Abraham I wrote: Add device tree support for twl6030 usb driver. Update the Documentation with device tree binding inform

Re: [PATCH v1 01/11] drivers: usb: otg: add a new driver for omap usb2 phy

2012-07-09 Thread ABRAHAM, KISHON VIJAY
Hi, On Tue, Jul 10, 2012 at 11:33 AM, Venu Byravarasu wrote: >> > + >> > +#ifdef CONFIG_PM > > Should it not be CONFIG_PM_SLEEP instead of just CONFIG_PM? Why? I think we should have CONFIG_PM_SLEEP only when we have *suspend*, *resume* hooks. But this driver has only *runtime_suspend* and *runt

Re: [PATCH v1 01/11] drivers: usb: otg: add a new driver for omap usb2 phy

2012-07-09 Thread Rajendra Nayak
+ +static int __devinit omap_usb2_probe(struct platform_device *pdev) +{ + struct omap_usb *phy; + struct usb_otg *otg; + struct resource *res; + + phy = devm_kzalloc(&pdev->dev, sizeof(*phy), GFP_KERNEL); + if (!phy)

Re: [PATCH v1 07/11] drivers: usb: twl4030: Add device tree support for twl4030 usb

2012-07-09 Thread ABRAHAM, KISHON VIJAY
Hi, On Tue, Jul 10, 2012 at 11:32 AM, Rajendra Nayak wrote: > On Thursday 28 June 2012 05:21 PM, Kishon Vijay Abraham I wrote: >> >> Add device tree support for twl6030 usb driver. > > > twl4030? My bad. Will fix it. > > >> Update the Documentation with device tree binding information. >> >> Sign

Re: [PATCH v1 08/11] arm/dts: Add twl4030-usb data

2012-07-09 Thread ABRAHAM, KISHON VIJAY
Hi, On Tue, Jul 10, 2012 at 11:43 AM, Rajendra Nayak wrote: > On Thursday 28 June 2012 05:21 PM, Kishon Vijay Abraham I wrote: >> >> Add twl4030-usb data node in twl4030 device tree file. >> >> Signed-off-by: Kishon Vijay Abraham I >> --- >> arch/arm/boot/dts/twl4030.dtsi | 21 +++