Re: [PATCH] USB: mark USB drivers as being GPL only

2008-02-08 Thread Diego Zuccato
Lee Mathers ha scritto: Now we have hardware ASIC that depend on the most part a (dll in windows) or .ko .o file under linux to provide the entire instruction set. Think Winmodems, Winprinters etc Well, winmodem case is the only I could *almost* understand closed-source drivers: the al

Re: [PATCH] USB: mark USB drivers as being GPL only

2008-02-08 Thread Diego Zuccato
David Newall ha scritto: Precisely: One purpose of the driver is to enforce local compliance. It can't *enforce* it anyway, at least if the users are all around the world. Yes it can. You're confusing the software with different or modified software. Different things. And by the way, if you

Re: [PATCH] USB: mark USB drivers as being GPL only

2008-02-08 Thread Marcel Holtmann
Hi David, > > I think you're missing my point: as long as the license stays the way > > it is now, you can never distribute proprietary code unless you've > > consulted a lawyer and even then you run the risk of being sued for > > infringement if the copyright holder thinks what yo

Re: [PATCH] USB: mark USB drivers as being GPL only

2008-02-08 Thread Alan Cox
> Well, winmodem case is the only I could *almost* understand > closed-source drivers: the algorithms used *are* the modem. It's not a > simple firmware upload. Winmodem is all about patents, the modem standards come from ISO so are created by all out corporate warfare with the winner getting th

Re: [PATCH][2/4] usb: only set URB_NO_TRANSFER_DMA_MAP when dma is enabled

2008-02-08 Thread Magnus Damm
Alan, thanks again for your comments, [moved to the linux-usb list] On Jan 26, 2008 1:55 AM, Alan Stern <[EMAIL PROTECTED]> wrote: > On Sat, 26 Jan 2008, Magnus Damm wrote: > > > Alan and David, thanks for your comments. > > > > The HCD_LOCAL_MEM code only copies data into the bounce buffers if >

[PATCH] [RESEND] Fix the pxa2xx_udc to balance calls to clk_enable/clk_disable

2008-02-08 Thread Dmitry Baryshkov
Signed-off-by: Dmitry Baryshkov [EMAIL PROTECTED] --- drivers/usb/gadget/pxa2xx_udc.c | 72 ++- drivers/usb/gadget/pxa2xx_udc.h |6 +++- 2 files changed, 46 insertions(+), 32 deletions(-) diff --git a/drivers/usb/gadget/pxa2xx_udc.c b/drivers/usb/gadget/p

Re: USB device doesn't get address

2008-02-08 Thread Alan Stern
On Fri, 8 Feb 2008, Fabio Venturi wrote: > > Can you post the usb-storage debugging log? It should indicate how > > things are getting "stuck". > This is the relevant part of dmesg (I think). > I cut it because it's very long, if you need more details let me know. You posted the debugging log

Re: [PATCH] bugfix for an underflow condition in usb storage & isd200.c

2008-02-08 Thread Alan Stern
On Tue, 5 Feb 2008, Matthew Dharm wrote: > We both agree that the code shouldn't run off the end of the s-g list. Incidentally, if people want a simple bugfix patch for 2.6.24.stable, this should do it. Mark, can you confirm that this patch alone fixes the problem? Alan Stern Index: 2.6.24

Re: More than one isoc transfers with usb 2.0 hardware

2008-02-08 Thread Alan Stern
On Fri, 8 Feb 2008, Mauro Carvalho Chehab wrote: > Hi Guys, > > There's currently an issue with isoc transfers made by em28xx driver[1] and > ehcd_hci. If I try to start isoc transfers on more than one hardware, the > second hardware fails at usb_submit_urb() with -ENOSPC. ENOSPC means that you

Re: USB device doesn't get address

2008-02-08 Thread Fabio Venturi
On Fri, Feb 08, 2008 at 10:24:35AM -0500, Alan Stern wrote: > On Fri, 8 Feb 2008, Fabio Venturi wrote: > > > > Can you post the usb-storage debugging log? It should indicate how > > > things are getting "stuck". > > > This is the relevant part of dmesg (I think). > > I cut it because it's very

Re: [GADGET] file_storage: what's 'stall' module parameter for ?

2008-02-08 Thread Francis Moreau
On Feb 7, 2008 7:27 PM, Alan Stern <[EMAIL PROTECTED]> wrote: > On Thu, 7 Feb 2008, Francis Moreau wrote: > > > Just to be sure I'm understanding you: > > > > This is a bulk-in transfer which is going to fail: > > > >usb-storage: Bulk Command S 0x43425355 T 0x6 L 192 F 128 Trg 0 LUN 0 CL 6 > >

Re: USB device doesn't get address

2008-02-08 Thread Alan Stern
On Fri, 8 Feb 2008, Fabio Venturi wrote: > On Fri, Feb 08, 2008 at 10:24:35AM -0500, Alan Stern wrote: > > On Fri, 8 Feb 2008, Fabio Venturi wrote: > > > > > > Can you post the usb-storage debugging log? It should indicate how > > > > things are getting "stuck". > > > > > This is the relevant

Re: [PATCH] bugfix for an underflow condition in usb storage & isd200.c

2008-02-08 Thread Mark Glines
On Fri, 8 Feb 2008 11:46:13 -0500 (EST) Alan Stern <[EMAIL PROTECTED]> wrote: > On Tue, 5 Feb 2008, Matthew Dharm wrote: > > > We both agree that the code shouldn't run off the end of the s-g > > list. > > Incidentally, if people want a simple bugfix patch for 2.6.24.stable, > this should do it

RE: [patch 13/45] USB: sierra: add support for Onda H600/ZteMF330datacard to USB Driver for Sierra Wireless

2008-02-08 Thread Kevin Lloyd
> For now, yes, we should mirror what is going to be in the 2.6.25 kernel > release. I see the split happening for 2.6.26. So I say leave this for > now, it adds support for users of these devices. It's not that big a of a deal and I'm not sure how much of a pain it would be to change it, but if

Re: More than one isoc transfers with usb 2.0 hardware

2008-02-08 Thread Mauro Carvalho Chehab
On Fri, 8 Feb 2008 10:48:54 -0500 (EST) Alan Stern <[EMAIL PROTECTED]> wrote: > On Fri, 8 Feb 2008, Mauro Carvalho Chehab wrote: > > > Hi Guys, > > > > There's currently an issue with isoc transfers made by em28xx driver[1] and > > ehcd_hci. If I try to start isoc transfers on more than one hard

Re: [PATCH][2/4] usb: only set URB_NO_TRANSFER_DMA_MAP when dma is enabled

2008-02-08 Thread Alan Stern
On Fri, 8 Feb 2008, Magnus Damm wrote: > > The documentation for URB_NO_TRANSFER_DMA_MAP and URB_NO_SETUP_DMA_MAP > > says only that the DMA handle must be valid; it doesn't say that the > > buffer had to allocated by usb_buffer_alloc(), hcd_buffer_alloc(), or > > dma_alloc_coherent(). > > But wh

Re: [PATCH] USB: mark USB drivers as being GPL only

2008-02-08 Thread David Newall
Alan Cox wrote: > On Fri, 08 Feb 2008 13:25:33 +1030 > David Newall <[EMAIL PROTECTED]> wrote: > > >> Alan Cox wrote: >> It would not be improper to say that "such and such a lawyer said this and that." I'm not proposing that you breach their copyright in their

Re: [patch 13/45] USB: sierra: add support for Onda H600/ZteMF330datacard to USB Driver for Sierra Wireless

2008-02-08 Thread Greg KH
On Fri, Feb 08, 2008 at 08:50:20AM -0800, Kevin Lloyd wrote: > > For now, yes, we should mirror what is going to be in the 2.6.25 > kernel > > release. I see the split happening for 2.6.26. So I say leave this > for > > now, it adds support for users of these devices. > > It's not that big a of

Re: [PATCH] USB: mark USB drivers as being GPL only

2008-02-08 Thread Daniel Hazelton
On Friday 08 February 2008 14:08:21 David Newall wrote: > I explained something poorly: > > Now, Alan has made a big issue over numerous legal opinions he has > > received, but he's been completely coy in the details. > > The point I wanted to make is that a few people have said that lawyers > say

Re: [PATCH] USB: mark USB drivers as being GPL only

2008-02-08 Thread David Newall
My, I am full of post scripts today. This one is a peace token for Alan. David Newall wrote: > there are more reliable and transparent sources [than Alan.] Don't take his > word on it. Take the words of real experts in the law, because instead > of a mere four word conclusion, they explain ever

Re: [Solved] Re: USB device doesn't get address

2008-02-08 Thread Fabio Venturi
On Fri, Feb 08, 2008 at 02:12:28PM -0500, Alan Stern wrote: > On Fri, 8 Feb 2008, Fabio Venturi wrote: > > > > Ah. I had overlooked another difference in the lsusb output. If you > > > compare the lines for bDeviceClass, you'll see that the > > > hotplugged-version says "Vendor Specific Class"

Re: [Solved] Re: USB device doesn't get address

2008-02-08 Thread Alan Stern
On Fri, 8 Feb 2008, Fabio Venturi wrote: > > Ah. I had overlooked another difference in the lsusb output. If you > > compare the lines for bDeviceClass, you'll see that the > > hotplugged-version says "Vendor Specific Class". That means you'll > > this additional patch to make it work with u

Re: [PATCH] USB: mark USB drivers as being GPL only

2008-02-08 Thread Greg KH
On Sat, Feb 09, 2008 at 05:10:04AM +1030, David Newall wrote: > The reasonable conclusion is that an original, non-derivative USB driver > can be written, and let's face it, a number of them have been referred > to in the course of this discussion. A "driver" is not an "application" as you tried t

Re: [PATCH] USB: mark USB drivers as being GPL only

2008-02-08 Thread David Newall
I explained something poorly: > Now, Alan has made a big issue over numerous legal opinions he has > received, but he's been completely coy in the details. The point I wanted to make is that a few people have said that lawyers say that kernel modules are derivative, but I only remember Alan saying

Re: [PATCH] USB: mark USB drivers as being GPL only

2008-02-08 Thread David Newall
Greg KH wrote: > A "driver" is not an "application" as you tried to reference in your > prior quotes. I think your treating what the learned Professors said to literally. > It is a tiny portion of the whole kernel, The Copyright Act draws no such a distinction. > and as such, > does fall under

[RFC/PATCH] make usbnet work with rndis_host

2008-02-08 Thread Jean-Christophe Dubois
Hi, While I was trying to make my WM5/smartphone work with Linux, I stumbled on problems as described in Bug 8094 (http://bugzilla.kernel.org/show_bug.cgi?id=8094). While studying this I think I found a problem in usbnet explaining why the synce WM5 patch (http://synce.svn.sourceforge.net/svn

Re: [PATCH] USB: mark USB drivers as being GPL only

2008-02-08 Thread Valdis . Kletnieks
On Fri, 08 Feb 2008 10:15:01 +0100, Marcel Holtmann said: > And while you are talking to a lawyer. Ask him/her if it is okay to > create a binary only application that uses a GPL library. Tell him/her It's perfectly legal to create such an application. It only gets interesting if you *distribute

[Solved] Re: USB device doesn't get address

2008-02-08 Thread Fabio Venturi
> Ah. I had overlooked another difference in the lsusb output. If you > compare the lines for bDeviceClass, you'll see that the > hotplugged-version says "Vendor Specific Class". That means you'll > this additional patch to make it work with usb-storage. > > Alan Stern Great shot! This patc

Re: [PATCH] USB: mark USB drivers as being GPL only

2008-02-08 Thread Alan Cox
> In other words "EXPORT_SYMBOL_GPL" isn't his idea of "a good legal idea", but > people ignoring this and doing things that circumvent this will, eventually, > have problems with the people who hold the copyright on the code. (In > addition, he stated that circumventing the "EXPORT_SYMBOL_GPL"

Re: [PATCH] USB: mark USB drivers as being GPL only

2008-02-08 Thread Alan Cox
On Fri, 08 Feb 2008 13:25:33 +1030 David Newall <[EMAIL PROTECTED]> wrote: > Alan Cox wrote: > >> It would not be improper to say that "such and such a lawyer said this > >> and that." I'm not proposing that you breach their copyright in their > >> > > > > It would be highly improper given t

More than one isoc transfers with usb 2.0 hardware

2008-02-08 Thread Mauro Carvalho Chehab
Hi Guys, There's currently an issue with isoc transfers made by em28xx driver[1] and ehcd_hci. If I try to start isoc transfers on more than one hardware, the second hardware fails at usb_submit_urb() with -ENOSPC. The current code that initializes isoc transfers looks like this (I've removed err

Re: EHCI shutdown question

2008-02-08 Thread David Brownell
On Friday 08 February 2008, Sarah Sharp wrote: > Ah, I see why you would want to turn off remote wakeup on those ports.   > However, > I don't see that function actually does what the comment says.  AFAIK, writing > 1 to the registers represented by PORT_RWC_BITS only clears the port status > bits

Re: [PATCH] USB: mark USB drivers as being GPL only

2008-02-08 Thread David Newall
Marcel Holtmann wrote: > Anyway you are still under the impression that a Linux kernel module can > be original work in the end. We keep telling you that could be a wrong > assumption which is based on the view of many of the kernel developers > and of most of the lawyers that looked at this specif

Re: How to debug EOVERFLOW errors

2008-02-08 Thread David Brownell
On Tuesday 05 February 2008, Alan Nisota wrote: > And as far as getting the vendor to fix the device, I've asked, but > they've been extremely reluctant to support Linux in the past. We'll > see what they say. Don't present it as "supporting Linux". Present it as: your device is blatantly NON

[patch 2.6.24-git] usb: ehci tolerates some buggy devices

2008-02-08 Thread David Brownell
This teaches EHCI how to to work around bugs in certain high speed devices, by accomodating "bulk" packets that exceed the 512 byte constant value required by the USB 2.0 specification. (Have a look at section 5.8.3, paragraphs 1 and 3.) It also makes the descriptor parsing code warn when it enco

Re: EHCI shutdown question

2008-02-08 Thread Sarah Sharp
On Tue, Feb 05, 2008 at 04:48:38PM -0500, Alan Stern wrote: > On Tue, 5 Feb 2008, David Brownell wrote: > > > The reason to try powering off the ports is that, well, the system is > > shutting down. Why waste (potentially battery) power? Whatever runs > > next can turn it back on if it wants. A

Re: [PATCH] USB: mark USB drivers as being GPL only

2008-02-08 Thread Marcel Holtmann
Hi David, > > Anyway you are still under the impression that a Linux kernel module can > > be original work in the end. We keep telling you that could be a wrong > > assumption which is based on the view of many of the kernel developers > > and of most of the lawyers that looked at this specific t

Re: How to debug EOVERFLOW errors

2008-02-08 Thread David Brownell
On Tuesday 05 February 2008, Alan Nisota wrote: > And as far as getting the vendor to fix the device, I've asked, but > they've been extremely reluctant to support Linux in the past. We'll > see what they say. Don't present it as "supporting Linux". Present it as: your device is blatantly con

Re: EHCI shutdown question

2008-02-08 Thread David Brownell
On Thursday 07 February 2008, Sarah Sharp wrote: > > Likewise ehci_shutdown() should kill those timers too, so they don't > > fire before this kernel stops. > > Is ehci_shutdown called in interrupt context? You could easily find the answer to that. :) Grep for ">shutdown" in drivers/base/*c ..

Re: EHCI shutdown question

2008-02-08 Thread Sarah Sharp
On Fri, Feb 08, 2008 at 02:48:30PM -0800, David Brownell wrote: > On Friday 08 February 2008, Sarah Sharp wrote: > > Ah, I see why you would want to turn off remote wakeup on those ports.   > > However, > > I don't see that function actually does what the comment says.  AFAIK, > > writing > > 1 to

Re: [PATCH] Possible bug fix in the ehci-hcd

2008-02-08 Thread Greg KH
On Thu, Feb 07, 2008 at 06:48:32PM +0200, Andy Shevchenko wrote: > Hi! > > The Sequans company who produce WiMAX chips provides the USB driver and kthp > addon driver. However the USB device doesn't work correctly. > > Here is more true hack for Sequans SQN11x0 based modem. > > P.S. For more det

Re: [PATCH] USB: mark USB drivers as being GPL only

2008-02-08 Thread Marcel Holtmann
Hi Valdis, > > And while you are talking to a lawyer. Ask him/her if it is okay to > > create a binary only application that uses a GPL library. Tell him/her > > It's perfectly legal to create such an application. > > It only gets interesting if you *distribute* it... > > (And yes, this is wher

Re: Belkin USB Host-to-Host cable with Prolific 25A1 chip in it under Linux

2008-02-08 Thread tony_gibbs
Dear Greg and Dave, Thanks for your mails, both of you, and for your advice about how to submit the patch, Greg. It feels welcoming for me as a kernel newbie. I agree with you Dave that usbnet comes up quite easily once the correct VID and PID are put in plusb.c. However, once I got two machines

Re: [PATCH] USB: mark USB drivers as being GPL only

2008-02-08 Thread Daniel Hazelton
On Friday 08 February 2008 16:36:37 Alan Cox wrote: > > In other words "EXPORT_SYMBOL_GPL" isn't his idea of "a good legal idea", > > but people ignoring this and doing things that circumvent this will, > > eventually, have problems with the people who hold the copyright on the > > code. (In additi

Re: EHCI shutdown question

2008-02-08 Thread David Brownell
On Friday 08 February 2008, Sarah Sharp wrote: > > > Were you going to develop a patch to resolve those issues? > > I'm working on a patch to share code between ehci_stop() and ehci_shutdown() > with the changes we discussed.  I just wanted to understand what was going on > in > both functions b

Re: How to debug EOVERFLOW errors

2008-02-08 Thread Greg KH
On Fri, Feb 08, 2008 at 03:03:57PM -0800, David Brownell wrote: > On Tuesday 05 February 2008, Alan Nisota wrote: > > And as far as getting the vendor to fix the device, I've asked, but > > they've been extremely reluctant to support Linux in the past. We'll > > see what they say. > > Don't pre

Re: How to debug EOVERFLOW errors

2008-02-08 Thread David Brownell
On Friday 08 February 2008, Greg KH wrote: > On Fri, Feb 08, 2008 at 03:03:57PM -0800, David Brownell wrote: > > On Tuesday 05 February 2008, Alan Nisota wrote: > > > And as far as getting the vendor to fix the device, I've asked, but > > > they've been extremely reluctant to support Linux in the

Re: How to debug EOVERFLOW errors

2008-02-08 Thread David Brownell
On Friday 08 February 2008, David Brownell wrote: > > If the vendor is using the official USB markings on their device, they > > would also be in trademark violation with the usb.org working group, a > > body that takes these things very seriously. Specifically any of the conformance logos visible

Re: Belkin USB Host-to-Host cable with Prolific 25A1 chip in it under Linux

2008-02-08 Thread David Brownell
On Friday 08 February 2008, tony_gibbs wrote: > I also downloaded and ran the USB test suite from the USB specification > body, Nicely done. :) > and this seemed to show some issues, especially with the maximum > packet size, in the device. > - Do you know where I can set this in the usb

Re: [2.6 patch] usb/gadget/printer.c: fix an if()

2008-02-08 Thread Craig W. Nadler
A bug every C programmer makes at some point in time... Signed-off-by: Craig W. Nadler <[EMAIL PROTECTED]> Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- diff --git a/drivers/usb/gadget/printer.c b/drivers/usb/gadget/printer.c index 9fdabc8..4f6bfa1 100644 --- a/drivers/usb/gadget/printer.c

Re: [2.6.24 REGRESSION] BUG: Soft lockup - with VFS

2008-02-08 Thread Pete Zaitcev
On Tue, 5 Feb 2008 14:05:06 -0800, Andrew Morton <[EMAIL PROTECTED]> wrote: > > > http://students.zipernowsky.hu/~oliverp/kernel/regression_2624/ > I think ub.c is basically abandoned in favour of usb-storage. > If so, perhaps we should remove or disble ub.c? Looks like it's just Tomo or Jens ma