Re: [PATCH v2 1/2] USB: chipidea: add imx usbmisc support

2012-07-23 Thread Richard Zhao
On Mon, Jul 23, 2012 at 02:21:06PM +0300, Felipe Balbi wrote: > On Mon, Jul 23, 2012 at 07:13:52PM +0800, Richard Zhao wrote: > > On Mon, Jul 23, 2012 at 01:51:55PM +0300, Felipe Balbi wrote: > > > On Mon, Jul 23, 2012 at 11:30:18AM +0200, Marc Kleine-Budde wrote: > > > > On 07/23/2012 11:27 AM, Ri

Re: [PATCH v2 1/2] USB: chipidea: add imx usbmisc support

2012-07-23 Thread Felipe Balbi
On Mon, Jul 23, 2012 at 07:13:52PM +0800, Richard Zhao wrote: > On Mon, Jul 23, 2012 at 01:51:55PM +0300, Felipe Balbi wrote: > > On Mon, Jul 23, 2012 at 11:30:18AM +0200, Marc Kleine-Budde wrote: > > > On 07/23/2012 11:27 AM, Richard Zhao wrote: > > > >> This patch looks like a recipe for disaster

Re: [PATCH v2 1/2] USB: chipidea: add imx usbmisc support

2012-07-23 Thread Richard Zhao
On Mon, Jul 23, 2012 at 01:51:55PM +0300, Felipe Balbi wrote: > On Mon, Jul 23, 2012 at 11:30:18AM +0200, Marc Kleine-Budde wrote: > > On 07/23/2012 11:27 AM, Richard Zhao wrote: > > >> This patch looks like a recipe for disaster IMHO, but it's Alex's call. > > > Well, if there's any better place t

Re: [PATCH v2 1/2] USB: chipidea: add imx usbmisc support

2012-07-23 Thread Felipe Balbi
On Mon, Jul 23, 2012 at 11:30:18AM +0200, Marc Kleine-Budde wrote: > On 07/23/2012 11:27 AM, Richard Zhao wrote: > >> This patch looks like a recipe for disaster IMHO, but it's Alex's call. > > Well, if there's any better place to hold it, I'd like to move there. > > Another place is arch/arm/mach-

Re: [PATCH v2 1/2] USB: chipidea: add imx usbmisc support

2012-07-23 Thread Marc Kleine-Budde
On 07/23/2012 11:27 AM, Richard Zhao wrote: >> This patch looks like a recipe for disaster IMHO, but it's Alex's call. > Well, if there's any better place to hold it, I'd like to move there. > Another place is arch/arm/mach-imx. Sascha/Shawn who are maintainers of > imx are also in cc list. IMHO i

Re: [PATCH v2 1/2] USB: chipidea: add imx usbmisc support

2012-07-23 Thread Richard Zhao
> > This patch looks like a recipe for disaster IMHO, but it's Alex's call. Well, if there's any better place to hold it, I'd like to move there. Another place is arch/arm/mach-imx. Sascha/Shawn who are maintainers of imx are also in cc list. Thanks Richard > > -- > balbi -- To unsubscribe f

Re: [PATCH v2 1/2] USB: chipidea: add imx usbmisc support

2012-07-23 Thread Felipe Balbi
Hi, On Wed, Jul 18, 2012 at 06:29:06PM +0800, Richard Zhao wrote: > i.MX usb controllers shares non-core registers, which may include > SoC specific controls. We take it as a usbmisc device and usbmisc > driver set operations needed by ci13xxx_imx driver. > > For example, Sabrelite board has bad

Re: [PATCH v2 1/2] USB: chipidea: add imx usbmisc support

2012-07-18 Thread Richard Zhao
On Wed, Jul 18, 2012 at 03:43:00PM +0200, Marc Kleine-Budde wrote: > On 07/18/2012 03:39 PM, Richard Zhao wrote: > > [snip] > static struct ci13xxx_platform_data ci13xxx_imx_platdata __devinitdata > = { > .name = "ci13xxx_imx", > .flags

Re: [PATCH v2 1/2] USB: chipidea: add imx usbmisc support

2012-07-18 Thread Marc Kleine-Budde
On 07/18/2012 03:39 PM, Richard Zhao wrote: > [snip] static struct ci13xxx_platform_data ci13xxx_imx_platdata __devinitdata = { .name = "ci13xxx_imx", .flags = CI13XXX_REQUIRE_TRANSCEIVER | @@ -120,6 +140,9 @@ static int __devinit

Re: [PATCH v2 1/2] USB: chipidea: add imx usbmisc support

2012-07-18 Thread Richard Zhao
[snip] > > > static struct ci13xxx_platform_data ci13xxx_imx_platdata __devinitdata > > > = { > > > .name = "ci13xxx_imx", > > > .flags = CI13XXX_REQUIRE_TRANSCEIVER | > > > @@ -120,6 +140,9 @@ static int __devinit ci13xxx_imx_probe(struct > > > platform_d

Re: [PATCH v2 1/2] USB: chipidea: add imx usbmisc support

2012-07-18 Thread Sascha Hauer
On Wed, Jul 18, 2012 at 07:19:17PM +0800, Richard Zhao wrote: > > > + > > > +struct imx6q_usbmisc { > > > + void __iomem *base; > > > + struct clk *clk; > > > + struct device *usb_dev[USB_DEV_MAX]; > > > + spinlock_t lock; > > > + > > > + int disable_oc:USB_DEV_MAX; > > > +}; > > > > Please add a

Re: [PATCH v2 1/2] USB: chipidea: add imx usbmisc support

2012-07-18 Thread Richard Zhao
On Wed, Jul 18, 2012 at 12:52:04PM +0200, Sascha Hauer wrote: > On Wed, Jul 18, 2012 at 06:29:06PM +0800, Richard Zhao wrote: > > i.MX usb controllers shares non-core registers, which may include > > SoC specific controls. We take it as a usbmisc device and usbmisc > > driver set operations needed

Re: [PATCH v2 1/2] USB: chipidea: add imx usbmisc support

2012-07-18 Thread Sascha Hauer
On Wed, Jul 18, 2012 at 06:29:06PM +0800, Richard Zhao wrote: > i.MX usb controllers shares non-core registers, which may include > SoC specific controls. We take it as a usbmisc device and usbmisc > driver set operations needed by ci13xxx_imx driver. > > For example, Sabrelite board has bad over-