RE: [PATCH] usb: ohci: remove ep93xx bus glue platform driver

2013-10-16 Thread Alan Stern
On Tue, 15 Oct 2013, Hartley Sweeten wrote: > > This is definitely not a show-stopper in any way, but since this is > > just standard clock management, could you even move these clock ops > > into the driver? Are any other platforms already doing similar things > > so you could remove code from th

RE: [PATCH] usb: ohci: remove ep93xx bus glue platform driver

2013-10-15 Thread Hartley Sweeten
On Tuesday, October 15, 2013 8:50 AM, Olof Johansson wrote: > On Mon, Oct 14, 2013 at 2:35 PM, H Hartley Sweeten > wrote: >> Convert ep93xx to use the OHCI platform driver and remove the >> ohci-ep93xx bus glue driver. >> >> Signed-off-by: H Hartley Sweeten >> Cc: Alan Stern >> Cc: Greg Kroah-H

Re: [PATCH] usb: ohci: remove ep93xx bus glue platform driver

2013-10-15 Thread Olof Johansson
Hi, On Mon, Oct 14, 2013 at 2:35 PM, H Hartley Sweeten wrote: > Convert ep93xx to use the OHCI platform driver and remove the > ohci-ep93xx bus glue driver. > > Signed-off-by: H Hartley Sweeten > Cc: Alan Stern > Cc: Greg Kroah-Hartman > Cc: Ryan Mallon > --- > arch/arm/mach-ep93xx/clock.c

Re: [PATCH] usb: ohci: remove ep93xx bus glue platform driver

2013-10-15 Thread Alan Stern
On Mon, 14 Oct 2013, H Hartley Sweeten wrote: > Convert ep93xx to use the OHCI platform driver and remove the > ohci-ep93xx bus glue driver. > > Signed-off-by: H Hartley Sweeten > Cc: Alan Stern > Cc: Greg Kroah-Hartman > Cc: Ryan Mallon ... > @@ -297,22 +298,58 @@ static struct platform_de

RE: [PATCH] usb: ohci: remove ep93xx bus glue platform driver

2013-10-15 Thread Alan Stern
On Mon, 14 Oct 2013, Hartley Sweeten wrote: > >> config USB_OHCI_HCD_PLATFORM > >>tristate "Generic OHCI driver for a platform device" > >> - default n > >> + default y if ARCH_EP93XX > > > > Shouldn't we select USB_OHCI_HCD_PLATFORM, e.g. something like: > > > > config ARCH_EP93XX_USB

Re: [PATCH] usb: ohci: remove ep93xx bus glue platform driver

2013-10-14 Thread Ryan Mallon
On 15/10/13 08:35, H Hartley Sweeten wrote: > Convert ep93xx to use the OHCI platform driver and remove the > ohci-ep93xx bus glue driver. > > Signed-off-by: H Hartley Sweeten > Cc: Alan Stern > Cc: Greg Kroah-Hartman > Cc: Ryan Mallon Cc'ed Olof, who wanted to see what the patches looked lik

RE: [PATCH] usb: ohci: remove ep93xx bus glue platform driver

2013-10-14 Thread Hartley Sweeten
On Monday, October 14, 2013 3:01 PM, Ryan Mallon wrote: > On 15/10/13 08:35, H Hartley Sweeten wrote: >> Convert ep93xx to use the OHCI platform driver and remove the >> ohci-ep93xx bus glue driver. >> >> Signed-off-by: H Hartley Sweeten >> Cc: Alan Stern >> Cc: Greg Kroah-Hartman >> Cc: Ryan M

Re: [PATCH] usb: ohci: remove ep93xx bus glue platform driver

2013-10-14 Thread Ryan Mallon
On 15/10/13 08:35, H Hartley Sweeten wrote: > Convert ep93xx to use the OHCI platform driver and remove the > ohci-ep93xx bus glue driver. > > Signed-off-by: H Hartley Sweeten > Cc: Alan Stern > Cc: Greg Kroah-Hartman > Cc: Ryan Mallon > --- > diff --git a/drivers/usb/host/Kconfig b/drivers/u