Re: [PATCH] usb: ehci: Enable support for 64bit EHCI host controllers in arm64

2014-05-22 Thread Jon Medhurst (Tixy)
On Thu, 2014-05-22 at 16:59 +0100, Catalin Marinas wrote: > On Mon, May 19, 2014 at 09:21:17AM +0100, Jon Medhurst (Tixy) wrote: > > On Fri, 2014-05-16 at 18:40 +0100, Catalin Marinas wrote: > > > On Fri, May 16, 2014 at 06:08:45PM +0100, Jon Medhurst (Tixy) wrote: > > > > On Fri, 2014-05-16 at 13:

Re: [PATCH] usb: ehci: Enable support for 64bit EHCI host controllers in arm64

2014-05-22 Thread Catalin Marinas
On Mon, May 19, 2014 at 09:21:17AM +0100, Jon Medhurst (Tixy) wrote: > On Fri, 2014-05-16 at 18:40 +0100, Catalin Marinas wrote: > > On Fri, May 16, 2014 at 06:08:45PM +0100, Jon Medhurst (Tixy) wrote: > > > On Fri, 2014-05-16 at 13:55 +0100, Catalin Marinas wrote: > > > [...] > > > > > It could if

Re: [PATCH] usb: ehci: Enable support for 64bit EHCI host controllers in arm64

2014-05-21 Thread Arnd Bergmann
On Wednesday 21 May 2014 12:01:29 Rob Herring wrote: > On Wed, May 21, 2014 at 11:35 AM, Catalin Marinas > wrote: > > On Wed, May 21, 2014 at 05:15:06PM +0100, Rob Herring wrote: > >> On Wed, May 21, 2014 at 10:48 AM, Arnd Bergmann wrote: > >> > On Wednesday 21 May 2014 10:26:01 Rob Herring wrote

Re: [PATCH] usb: ehci: Enable support for 64bit EHCI host controllers in arm64

2014-05-21 Thread Rob Herring
On Wed, May 21, 2014 at 11:35 AM, Catalin Marinas wrote: > On Wed, May 21, 2014 at 05:15:06PM +0100, Rob Herring wrote: >> On Wed, May 21, 2014 at 10:48 AM, Arnd Bergmann wrote: >> > On Wednesday 21 May 2014 10:26:01 Rob Herring wrote: >> >> What are you checking against to cause a failure and wh

Re: [PATCH] usb: ehci: Enable support for 64bit EHCI host controllers in arm64

2014-05-21 Thread Catalin Marinas
On Wed, May 21, 2014 at 05:15:06PM +0100, Rob Herring wrote: > On Wed, May 21, 2014 at 10:48 AM, Arnd Bergmann wrote: > > On Wednesday 21 May 2014 10:26:01 Rob Herring wrote: > >> What are you checking against to cause a failure and what do you do on > >> failure? I'm guessing that PCI masks are c

Re: [PATCH] usb: ehci: Enable support for 64bit EHCI host controllers in arm64

2014-05-21 Thread Rob Herring
On Wed, May 21, 2014 at 10:48 AM, Arnd Bergmann wrote: > On Wednesday 21 May 2014 10:26:01 Rob Herring wrote: >> On Wed, May 21, 2014 at 9:43 AM, Arnd Bergmann wrote: >> > On Wednesday 21 May 2014 14:56:36 Catalin Marinas wrote: >> >> On Tue, May 20, 2014 at 08:37:10PM +0100, Arnd Bergmann wrote:

Re: [PATCH] usb: ehci: Enable support for 64bit EHCI host controllers in arm64

2014-05-21 Thread Arnd Bergmann
On Wednesday 21 May 2014 16:32:16 Catalin Marinas wrote: > On Wed, May 21, 2014 at 03:43:39PM +0100, Arnd Bergmann wrote: > > On Wednesday 21 May 2014 14:56:36 Catalin Marinas wrote: > > > On Tue, May 20, 2014 at 08:37:10PM +0100, Arnd Bergmann wrote: > > > > On Tuesday 20 May 2014 15:12:49 Catalin

Re: [PATCH] usb: ehci: Enable support for 64bit EHCI host controllers in arm64

2014-05-21 Thread Arnd Bergmann
On Wednesday 21 May 2014 10:26:01 Rob Herring wrote: > On Wed, May 21, 2014 at 9:43 AM, Arnd Bergmann wrote: > > On Wednesday 21 May 2014 14:56:36 Catalin Marinas wrote: > >> On Tue, May 20, 2014 at 08:37:10PM +0100, Arnd Bergmann wrote: > >> > On Tuesday 20 May 2014 15:12:49 Catalin Marinas wrote

Re: [PATCH] usb: ehci: Enable support for 64bit EHCI host controllers in arm64

2014-05-21 Thread Catalin Marinas
On Wed, May 21, 2014 at 03:43:39PM +0100, Arnd Bergmann wrote: > On Wednesday 21 May 2014 14:56:36 Catalin Marinas wrote: > > On Tue, May 20, 2014 at 08:37:10PM +0100, Arnd Bergmann wrote: > > > On Tuesday 20 May 2014 15:12:49 Catalin Marinas wrote: > > > > So what we need is setting the default dm

Re: [PATCH] usb: ehci: Enable support for 64bit EHCI host controllers in arm64

2014-05-21 Thread Rob Herring
On Wed, May 21, 2014 at 9:43 AM, Arnd Bergmann wrote: > On Wednesday 21 May 2014 14:56:36 Catalin Marinas wrote: >> On Tue, May 20, 2014 at 08:37:10PM +0100, Arnd Bergmann wrote: >> > On Tuesday 20 May 2014 15:12:49 Catalin Marinas wrote: >> > > On Tue, May 20, 2014 at 12:08:58PM +0100, Arnd Bergm

Re: [PATCH] usb: ehci: Enable support for 64bit EHCI host controllers in arm64

2014-05-21 Thread Arnd Bergmann
On Wednesday 21 May 2014 14:56:36 Catalin Marinas wrote: > On Tue, May 20, 2014 at 08:37:10PM +0100, Arnd Bergmann wrote: > > On Tuesday 20 May 2014 15:12:49 Catalin Marinas wrote: > > > On Tue, May 20, 2014 at 12:08:58PM +0100, Arnd Bergmann wrote: > > > > On Tuesday 20 May 2014 12:02:46 Catalin M

Re: [PATCH] usb: ehci: Enable support for 64bit EHCI host controllers in arm64

2014-05-21 Thread Catalin Marinas
On Tue, May 20, 2014 at 08:37:10PM +0100, Arnd Bergmann wrote: > On Tuesday 20 May 2014 15:12:49 Catalin Marinas wrote: > > On Tue, May 20, 2014 at 12:08:58PM +0100, Arnd Bergmann wrote: > > > On Tuesday 20 May 2014 12:02:46 Catalin Marinas wrote: > > > > On Mon, May 19, 2014 at 05:55:56PM +0100, A

Re: [PATCH] usb: ehci: Enable support for 64bit EHCI host controllers in arm64

2014-05-20 Thread Arnd Bergmann
On Tuesday 20 May 2014 15:12:49 Catalin Marinas wrote: > On Tue, May 20, 2014 at 12:08:58PM +0100, Arnd Bergmann wrote: > > On Tuesday 20 May 2014 12:02:46 Catalin Marinas wrote: > > > On Mon, May 19, 2014 at 05:55:56PM +0100, Arnd Bergmann wrote: > > > > On Monday 19 May 2014 16:56:08 Catalin Mari

Re: [PATCH] usb: ehci: Enable support for 64bit EHCI host controllers in arm64

2014-05-20 Thread Rob Herring
On Tue, May 20, 2014 at 3:01 AM, Arnd Bergmann wrote: > On Monday 19 May 2014 16:42:18 Rob Herring wrote: >> On Mon, May 19, 2014 at 10:56 AM, Catalin Marinas >> wrote: >> > On Mon, May 19, 2014 at 10:44:51AM +0100, Arnd Bergmann wrote: >> > > On Monday 19 May 2014 10:03:40 Catalin Marinas wrote:

Re: [PATCH] usb: ehci: Enable support for 64bit EHCI host controllers in arm64

2014-05-20 Thread Catalin Marinas
On Tue, May 20, 2014 at 12:08:58PM +0100, Arnd Bergmann wrote: > On Tuesday 20 May 2014 12:02:46 Catalin Marinas wrote: > > On Mon, May 19, 2014 at 05:55:56PM +0100, Arnd Bergmann wrote: > > > On Monday 19 May 2014 16:56:08 Catalin Marinas wrote: > > > > On Mon, May 19, 2014 at 10:44:51AM +0100, Ar

Re: [PATCH] usb: ehci: Enable support for 64bit EHCI host controllers in arm64

2014-05-20 Thread Arnd Bergmann
On Tuesday 20 May 2014 12:02:46 Catalin Marinas wrote: > On Mon, May 19, 2014 at 05:55:56PM +0100, Arnd Bergmann wrote: > > On Monday 19 May 2014 16:56:08 Catalin Marinas wrote: > > > On Mon, May 19, 2014 at 10:44:51AM +0100, Arnd Bergmann wrote: > > > > On Monday 19 May 2014 10:03:40 Catalin Marin

Re: [PATCH] usb: ehci: Enable support for 64bit EHCI host controllers in arm64

2014-05-20 Thread Catalin Marinas
On Mon, May 19, 2014 at 05:55:56PM +0100, Arnd Bergmann wrote: > On Monday 19 May 2014 16:56:08 Catalin Marinas wrote: > > On Mon, May 19, 2014 at 10:44:51AM +0100, Arnd Bergmann wrote: > > > On Monday 19 May 2014 10:03:40 Catalin Marinas wrote: > > > > On Mon, May 19, 2014 at 09:32:43AM +0100, Arn

Re: [PATCH] usb: ehci: Enable support for 64bit EHCI host controllers in arm64

2014-05-20 Thread Arnd Bergmann
On Monday 19 May 2014 16:42:18 Rob Herring wrote: > On Mon, May 19, 2014 at 10:56 AM, Catalin Marinas > wrote: > > On Mon, May 19, 2014 at 10:44:51AM +0100, Arnd Bergmann wrote: > > > On Monday 19 May 2014 10:03:40 Catalin Marinas wrote: > > > > On Mon, May 19, 2014 at 09:32:43AM +0100, Arnd Bergm

Re: [PATCH] usb: ehci: Enable support for 64bit EHCI host controllers in arm64

2014-05-19 Thread Arnd Bergmann
On Monday 19 May 2014 16:56:08 Catalin Marinas wrote: > On Mon, May 19, 2014 at 10:44:51AM +0100, Arnd Bergmann wrote: > > On Monday 19 May 2014 10:03:40 Catalin Marinas wrote: > > > On Mon, May 19, 2014 at 09:32:43AM +0100, Arnd Bergmann wrote: > > > > The more important question is what happens t

Re: [PATCH] usb: ehci: Enable support for 64bit EHCI host controllers in arm64

2014-05-19 Thread Arnd Bergmann
On Monday 19 May 2014 10:16:57 Alan Stern wrote: > On Mon, 19 May 2014, Arnd Bergmann wrote: > > > > dma_alloc_coherent() on arm64 should return 32-bit addresses if the > > > coherent_dma_mask is set to 32-bit. Which kernel version is this? > > > > The more important question is what happens to h

Re: [PATCH] usb: ehci: Enable support for 64bit EHCI host controllers in arm64

2014-05-19 Thread Catalin Marinas
On Mon, May 19, 2014 at 10:44:51AM +0100, Arnd Bergmann wrote: > On Monday 19 May 2014 10:03:40 Catalin Marinas wrote: > > On Mon, May 19, 2014 at 09:32:43AM +0100, Arnd Bergmann wrote: > > > The more important question is what happens to high buffers allocated > > > elsewhere > > > that get passe

Re: [PATCH] usb: ehci: Enable support for 64bit EHCI host controllers in arm64

2014-05-19 Thread Alan Stern
On Mon, 19 May 2014, Arnd Bergmann wrote: > > dma_alloc_coherent() on arm64 should return 32-bit addresses if the > > coherent_dma_mask is set to 32-bit. Which kernel version is this? > > The more important question is what happens to high buffers allocated > elsewhere > that get passed into dma

Re: [PATCH] usb: ehci: Enable support for 64bit EHCI host controllers in arm64

2014-05-19 Thread Arnd Bergmann
On Monday 19 May 2014 10:03:40 Catalin Marinas wrote: > On Mon, May 19, 2014 at 09:32:43AM +0100, Arnd Bergmann wrote: > > On Friday 16 May 2014 13:55:01 Catalin Marinas wrote: > > > On Thu, May 15, 2014 at 05:53:53PM +0100, Liviu Dudau wrote: > > > > On Thu, May 15, 2014 at 04:36:25PM +0100, Alan

Re: [PATCH] usb: ehci: Enable support for 64bit EHCI host controllers in arm64

2014-05-19 Thread Catalin Marinas
On Mon, May 19, 2014 at 09:32:43AM +0100, Arnd Bergmann wrote: > On Friday 16 May 2014 13:55:01 Catalin Marinas wrote: > > On Thu, May 15, 2014 at 05:53:53PM +0100, Liviu Dudau wrote: > > > On Thu, May 15, 2014 at 04:36:25PM +0100, Alan Stern wrote: > > > > On Thu, 15 May 2014, Liviu Dudau wrote: >

Re: [PATCH] usb: ehci: Enable support for 64bit EHCI host controllers in arm64

2014-05-19 Thread Arnd Bergmann
On Friday 16 May 2014 13:55:01 Catalin Marinas wrote: > On Thu, May 15, 2014 at 05:53:53PM +0100, Liviu Dudau wrote: > > On Thu, May 15, 2014 at 04:36:25PM +0100, Alan Stern wrote: > > > On Thu, 15 May 2014, Liviu Dudau wrote: > > > > On Thu, May 15, 2014 at 03:11:48PM +0100, Alan Stern wrote: > >

Re: [PATCH] usb: ehci: Enable support for 64bit EHCI host controllers in arm64

2014-05-19 Thread Jon Medhurst (Tixy)
On Fri, 2014-05-16 at 18:40 +0100, Catalin Marinas wrote: > On Fri, May 16, 2014 at 06:08:45PM +0100, Jon Medhurst (Tixy) wrote: > > On Fri, 2014-05-16 at 13:55 +0100, Catalin Marinas wrote: > > [...] > > > > It could if arm64 would restrict the DMA addresses to 32-bit, but it > > > > doesn't > >

Re: [PATCH] usb: ehci: Enable support for 64bit EHCI host controllers in arm64

2014-05-16 Thread Jon Medhurst (Tixy)
On Fri, 2014-05-16 at 13:55 +0100, Catalin Marinas wrote: [...] > > It could if arm64 would restrict the DMA addresses to 32-bit, but it doesn't > > and I end up on my platform with USB DMA buffers allocated >4GB address. > > dma_alloc_coherent() on arm64 should return 32-bit addresses if the > co

Re: [PATCH] usb: ehci: Enable support for 64bit EHCI host controllers in arm64

2014-05-16 Thread Catalin Marinas
On Fri, May 16, 2014 at 06:08:45PM +0100, Jon Medhurst (Tixy) wrote: > On Fri, 2014-05-16 at 13:55 +0100, Catalin Marinas wrote: > [...] > > > It could if arm64 would restrict the DMA addresses to 32-bit, but it > > > doesn't > > > and I end up on my platform with USB DMA buffers allocated >4GB ad

Re: [PATCH] usb: ehci: Enable support for 64bit EHCI host controllers in arm64

2014-05-16 Thread Liviu Dudau
On Fri, May 16, 2014 at 01:55:01PM +0100, Catalin Marinas wrote: > On Thu, May 15, 2014 at 05:53:53PM +0100, Liviu Dudau wrote: > > On Thu, May 15, 2014 at 04:36:25PM +0100, Alan Stern wrote: > > > On Thu, 15 May 2014, Liviu Dudau wrote: > > > > On Thu, May 15, 2014 at 03:11:48PM +0100, Alan Stern

Re: [PATCH] usb: ehci: Enable support for 64bit EHCI host controllers in arm64

2014-05-16 Thread Catalin Marinas
On Thu, May 15, 2014 at 05:53:53PM +0100, Liviu Dudau wrote: > On Thu, May 15, 2014 at 04:36:25PM +0100, Alan Stern wrote: > > On Thu, 15 May 2014, Liviu Dudau wrote: > > > On Thu, May 15, 2014 at 03:11:48PM +0100, Alan Stern wrote: > > > > On Wed, 14 May 2014, Mark Brown wrote: > > > > > arm64 arc

Re: [PATCH] usb: ehci: Enable support for 64bit EHCI host controllers in arm64

2014-05-15 Thread Alan Stern
On Thu, 15 May 2014, Liviu Dudau wrote: > On Thu, May 15, 2014 at 04:36:25PM +0100, Alan Stern wrote: > > On Thu, 15 May 2014, Liviu Dudau wrote: > > > > > On Thu, May 15, 2014 at 03:11:48PM +0100, Alan Stern wrote: > > > > On Wed, 14 May 2014, Mark Brown wrote: > > > > > > > > > From: Liviu Dud

Re: [PATCH] usb: ehci: Enable support for 64bit EHCI host controllers in arm64

2014-05-15 Thread Liviu Dudau
On Thu, May 15, 2014 at 04:36:25PM +0100, Alan Stern wrote: > On Thu, 15 May 2014, Liviu Dudau wrote: > > > On Thu, May 15, 2014 at 03:11:48PM +0100, Alan Stern wrote: > > > On Wed, 14 May 2014, Mark Brown wrote: > > > > > > > From: Liviu Dudau > > > > > > > > arm64 architecture handles correct

Re: [PATCH] usb: ehci: Enable support for 64bit EHCI host controllers in arm64

2014-05-15 Thread Alan Stern
On Thu, 15 May 2014, Mark Brown wrote: > On Thu, May 15, 2014 at 04:17:44PM +0100, Liviu Dudau wrote: > > On Thu, May 15, 2014 at 03:11:48PM +0100, Alan Stern wrote: > > > On Wed, 14 May 2014, Mark Brown wrote: > > > > Did you folks tested this for all sorts of host controllers? I have no > > >

Re: [PATCH] usb: ehci: Enable support for 64bit EHCI host controllers in arm64

2014-05-15 Thread Alan Stern
On Thu, 15 May 2014, Liviu Dudau wrote: > On Thu, May 15, 2014 at 03:11:48PM +0100, Alan Stern wrote: > > On Wed, 14 May 2014, Mark Brown wrote: > > > > > From: Liviu Dudau > > > > > > arm64 architecture handles correctly 64bit DMAs and can enable support > > > for 64bit EHCI host controllers.

Re: [PATCH] usb: ehci: Enable support for 64bit EHCI host controllers in arm64

2014-05-15 Thread Mark Brown
On Thu, May 15, 2014 at 04:17:44PM +0100, Liviu Dudau wrote: > On Thu, May 15, 2014 at 03:11:48PM +0100, Alan Stern wrote: > > On Wed, 14 May 2014, Mark Brown wrote: > > Did you folks tested this for all sorts of host controllers? I have no > > way to verify that it works, and last I heard, many

Re: [PATCH] usb: ehci: Enable support for 64bit EHCI host controllers in arm64

2014-05-15 Thread Liviu Dudau
On Thu, May 15, 2014 at 03:11:48PM +0100, Alan Stern wrote: > On Wed, 14 May 2014, Mark Brown wrote: > > > From: Liviu Dudau > > > > arm64 architecture handles correctly 64bit DMAs and can enable support > > for 64bit EHCI host controllers. > > > > Signed-off-by: Liviu Dudau > > Signed-off-by:

Re: [PATCH] usb: ehci: Enable support for 64bit EHCI host controllers in arm64

2014-05-15 Thread Alan Stern
On Wed, 14 May 2014, Mark Brown wrote: > From: Liviu Dudau > > arm64 architecture handles correctly 64bit DMAs and can enable support > for 64bit EHCI host controllers. > > Signed-off-by: Liviu Dudau > Signed-off-by: Ryan Harkin > Signed-off-by: Mark Brown Did you folks tested this for all