Re: [PATCH] dmaengine: cppi41: Fix cppi41_dma_prep_slave_sg() when idle

2019-10-23 Thread Sergei Shtylyov
Hello! On 10/23/2019 09:58 PM, Andy Shevchenko wrote: >>> + int error; >>> + >>> + error = pm_runtime_get(cdd->ddev.dev); >>> + if (error < 0) { >> >>I'd call that variable 'status', comparison (error < 0) just doesn't look >> right. >> If it was *if* (error), it would have been

Re: [PATCH] dmaengine: cppi41: Fix cppi41_dma_prep_slave_sg() when idle

2019-10-23 Thread Tony Lindgren
* Peter Ujfalusi [191023 19:02]: > On 10/23/19 8:16 PM, Tony Lindgren wrote: > > * Peter Ujfalusi [191023 17:04]: > >> On 10/23/19 6:31 PM, Tony Lindgren wrote: > >>> diff --git a/drivers/dma/ti/cppi41.c b/drivers/dma/ti/cppi41.c > >>> --- a/drivers/dma/ti/cppi41.c > >>> +++ b/drivers/dma/ti/cppi

Re: [PATCH] dmaengine: cppi41: Fix cppi41_dma_prep_slave_sg() when idle

2019-10-23 Thread Peter Ujfalusi
On 10/23/19 8:16 PM, Tony Lindgren wrote: > * Peter Ujfalusi [191023 17:04]: >> On 10/23/19 6:31 PM, Tony Lindgren wrote: >>> diff --git a/drivers/dma/ti/cppi41.c b/drivers/dma/ti/cppi41.c >>> --- a/drivers/dma/ti/cppi41.c >>> +++ b/drivers/dma/ti/cppi41.c >>> @@ -586,9 +586,22 @@ static struct

Re: [PATCH] dmaengine: cppi41: Fix cppi41_dma_prep_slave_sg() when idle

2019-10-23 Thread Tony Lindgren
* Sergei Shtylyov [191023 18:56]: > On 10/23/2019 06:31 PM, Tony Lindgren wrote: > > --- a/drivers/dma/ti/cppi41.c > > +++ b/drivers/dma/ti/cppi41.c > > @@ -586,9 +586,22 @@ static struct dma_async_tx_descriptor > > *cppi41_dma_prep_slave_sg( > > enum dma_transfer_direction dir, unsigned long

Re: [PATCH] dmaengine: cppi41: Fix cppi41_dma_prep_slave_sg() when idle

2019-10-23 Thread Andy Shevchenko
On Wed, Oct 23, 2019 at 9:55 PM Sergei Shtylyov wrote: > On 10/23/2019 06:31 PM, Tony Lindgren wrote: > > + int error; > > + > > + error = pm_runtime_get(cdd->ddev.dev); > > + if (error < 0) { > >I'd call that variable 'status', comparison (error < 0) just doesn't look > right. >

Re: [PATCH] dmaengine: cppi41: Fix cppi41_dma_prep_slave_sg() when idle

2019-10-23 Thread Sergei Shtylyov
Hello! On 10/23/2019 06:31 PM, Tony Lindgren wrote: > Yegor Yefremov reported that musb and ftdi > uart can fail for the first open of the uart unless connected using > a hub. > > This is because the first dma call done by musb_ep_program() must wait > if cppi41 is PM runtime suspended. Otherwi

Re: [PATCH] dmaengine: cppi41: Fix cppi41_dma_prep_slave_sg() when idle

2019-10-23 Thread Tony Lindgren
* Peter Ujfalusi [191023 17:04]: > On 10/23/19 6:31 PM, Tony Lindgren wrote: > > diff --git a/drivers/dma/ti/cppi41.c b/drivers/dma/ti/cppi41.c > > --- a/drivers/dma/ti/cppi41.c > > +++ b/drivers/dma/ti/cppi41.c > > @@ -586,9 +586,22 @@ static struct dma_async_tx_descriptor > > *cppi41_dma_prep_s

Re: [PATCH] dmaengine: cppi41: Fix cppi41_dma_prep_slave_sg() when idle

2019-10-23 Thread Peter Ujfalusi
Hi Tony, On 10/23/19 6:31 PM, Tony Lindgren wrote: > Yegor Yefremov reported that musb and ftdi > uart can fail for the first open of the uart unless connected using > a hub. > > This is because the first dma call done by musb_ep_program() must wait > if cppi41 is PM runtime suspended. Otherwise

RE: [PATCH v2 13/18] usb: typec: ucsi: ccg: Move to the new API

2019-10-23 Thread Ajay Gupta
Hi Heikki > -Original Message- > From: Heikki Krogerus > Sent: Wednesday, October 23, 2019 7:40 AM > To: Greg Kroah-Hartman > Cc: Guenter Roeck ; Ajay Gupta ; > linux-usb@vger.kernel.org > Subject: [PATCH v2 13/18] usb: typec: ucsi: ccg: Move to the new API > > Replacing the old "cmd" a

RE: [PATCH 00/18] usb: typec: API improvements

2019-10-23 Thread Ajay Gupta
Hi Heikki > -Original Message- > From: linux-usb-ow...@vger.kernel.org > On Behalf Of Heikki Krogerus > Sent: Wednesday, October 23, 2019 1:06 AM > To: Ajay Gupta > Cc: Greg Kroah-Hartman ; Guenter Roeck > ; linux-usb@vger.kernel.org > Subject: Re: [PATC

Re: [PATCH] dmaengine: cppi41: Fix cppi41_dma_prep_slave_sg() when idle

2019-10-23 Thread Vinod Koul
On 23-10-19, 08:31, Tony Lindgren wrote: > Yegor Yefremov reported that musb and ftdi > uart can fail for the first open of the uart unless connected using > a hub. > > This is because the first dma call done by musb_ep_program() must wait > if cppi41 is PM runtime suspended. Otherwise musb_ep_pr

Re: [PATCH] dmaengine: cppi41: Fix issue with musb and ftdi uart

2019-10-23 Thread Tony Lindgren
* Vinod Koul [191023 04:54]: > Hi Tony, > > On 22-10-19, 07:55, Tony Lindgren wrote: > > Patch subject should reflect the patch changes not the fix. The patch > title here is not telling me anything about the change below. Pls > consider updating the title. Sure, I'll resend with updated descri

Re: [PATCH] usb-storage: Revert commit 747668dbc061 ("usb-storage: Set virt_boundary_mask to avoid SG overflows")

2019-10-23 Thread Alan Stern
On Wed, 23 Oct 2019, Christoph Hellwig wrote: > On Mon, Oct 21, 2019 at 11:48:06AM -0400, Alan Stern wrote: > > There is no longer any reason to keep the virt_boundary_mask setting > > for usb-storage. It was needed in the first place only for handling > > devices with a block size smaller than t

Re: BUG report: usb: dwc3: Link TRB triggered an intterupt without IOC being setted

2019-10-23 Thread Felipe Balbi
Hi, (please don't top-post) alex zheng writes: > Hi, all > > We found that this is a known issue of synopsys DWC3 USB controller, > when the PARKMODE_SS of DWC3 is enable, the controller may hang or do > wrong TRB schedule in some heavy load conditions. > > Setting DISABLE_PARKMODE_SS to 1 can

Re: BUG report: usb: dwc3: Link TRB triggered an intterupt without IOC being setted

2019-10-23 Thread alex zheng
Hi, all We found that this is a known issue of synopsys DWC3 USB controller, when the PARKMODE_SS of DWC3 is enable, the controller may hang or do wrong TRB schedule in some heavy load conditions. Setting DISABLE_PARKMODE_SS to 1 can work around this bug. Thank you for your help. alex zheng 于2

Re: [PATCH] [PATCH v8] USB: serial: pl2303: Add new PID to support PL2303HXN (TYPE_HXN)

2019-10-23 Thread Johan Hovold
On Tue, Sep 24, 2019 at 08:14:00PM +0800, Charles Yeh wrote: > Prolific has developed a new USB to UART chip: PL2303HXN > PL2303HXN : PL2303GC/PL2303GS/PL2303GT/PL2303GL/PL2303GE/PL2303GB > The Vendor request used by the PL2303HXN (TYPE_HXN) is different from > the existing PL2303 series (TYPE_HX &

Re: [PATCH 2/2] usb: gadget: composite: Support more than 500mA MaxPower

2019-10-23 Thread jackp
On 2019-10-23 00:49, Felipe Balbi wrote: Hi, Jack Pham writes: USB 3.x SuperSpeed peripherals can draw up to 900mA of VBUS power when in configured state. However, if a configuration wanting to take advantage of this is added with MaxPower greater than 500 (currently possible if using a Config

Re: [PATCH 00/18] usb: typec: API improvements

2019-10-23 Thread Heikki Krogerus
gt; Cc: Greg Kroah-Hartman ; Guenter Roeck > > ; linux-usb@vger.kernel.org > > Subject: Re: [PATCH 00/18] usb: typec: API improvements > > > > On Mon, Oct 21, 2019 at 08:41:16PM +, Ajay Gupta wrote: > > > Hi Heikki, > > > > > > > -Original

Re: [PATCH] net: usb: lan78xx: Use phy_mac_interrupt() for interrupt handling

2019-10-23 Thread Daniel Wagner
Sebastian suggested to try this here: --- a/drivers/net/usb/lan78xx.c +++ b/drivers/net/usb/lan78xx.c @@ -1264,8 +1264,11 @@ static void lan78xx_status(struct lan78xx_net *dev, struct urb *urb) netif_dbg(dev, link, dev->net, "PHY INTR: 0x%08x\n", intdata); lan78xx_

Re: [PATCH 2/2] usb: gadget: composite: Support more than 500mA MaxPower

2019-10-23 Thread Felipe Balbi
Hi, Jack Pham writes: > USB 3.x SuperSpeed peripherals can draw up to 900mA of VBUS power > when in configured state. However, if a configuration wanting to > take advantage of this is added with MaxPower greater than 500 > (currently possible if using a ConfigFS gadget) the composite > driver f

Re: [PATCH 2/2] usb: gadget: composite: Support more than 500mA MaxPower

2019-10-23 Thread Jack Pham
On Tue, Oct 22, 2019 at 11:57:53PM -0700, Jack Pham wrote: > USB 3.x SuperSpeed peripherals can draw up to 900mA of VBUS power > when in configured state. However, if a configuration wanting to > take advantage of this is added with MaxPower greater than 500 > (currently possible if using a ConfigF

Re: [PATCH] usb: dwc3: Add shutdown to platform_driver

2019-10-22 Thread Felipe Balbi
rs (instead of remove). Because of this the dwc3 >> device keeps doing things like DMA. >> While the second kernel is taking over, it gets its memory corrupted with >> such DMA accesses from the device. When the second kernel reaches the point >> of taking over the dwc

Re: [PATCH 1/4] usb: dwc3: gadget: Don't send unintended link state change

2019-10-22 Thread Felipe Balbi
Hi Thinh, Thinh Nguyen writes: > DCTL.ULSTCHNGREQ is a write-only field. When doing a read-modify-write > to DCTL, the driver must make sure that there's no unintended link state > change request from whatever is read from DCTL.ULSTCHNGREQ. Set link > state change to no-action when the driver wr

Re: [PATCH] dmaengine: cppi41: Fix issue with musb and ftdi uart

2019-10-22 Thread Vinod Koul
Hi Tony, On 22-10-19, 07:55, Tony Lindgren wrote: Patch subject should reflect the patch changes not the fix. The patch title here is not telling me anything about the change below. Pls consider updating the title. > The first dma call done by musb_ep_program() must wait if cppi41 is PM > runtim

Re: [PATCH] usb-storage: Revert commit 747668dbc061 ("usb-storage: Set virt_boundary_mask to avoid SG overflows")

2019-10-22 Thread Christoph Hellwig
On Mon, Oct 21, 2019 at 11:48:06AM -0400, Alan Stern wrote: > There is no longer any reason to keep the virt_boundary_mask setting > for usb-storage. It was needed in the first place only for handling > devices with a block size smaller than the maxpacket size and where > the host controller was n

RE: [PATCH 00/18] usb: typec: API improvements

2019-10-22 Thread Ajay Gupta
Hi Heikki, > -Original Message- > From: linux-usb-ow...@vger.kernel.org > On Behalf Of Heikki Krogerus > Sent: Tuesday, October 22, 2019 12:41 AM > To: Ajay Gupta > Cc: Greg Kroah-Hartman ; Guenter Roeck > ; linux-usb@vger.kernel.org > Subject: Re: [PATC

Re: 5.3.6: I/O error on writing SD card via USB3

2019-10-22 Thread Alan Stern
On Tue, 22 Oct 2019, Harald Dunkel wrote: > Hi Alan, > > On 10/21/19 7:48 PM, Alan Stern wrote: > > On Mon, 21 Oct 2019, Harald Dunkel wrote: > > > >> > >> The USB2 cable worked, too. Actually I had expected that the speed is > >> reduced automatically according to the specs of the card. ??? > >

Re: 5.3.6: I/O error on writing SD card via USB3

2019-10-22 Thread Harald Dunkel
Hi Alan, On 10/21/19 7:48 PM, Alan Stern wrote: On Mon, 21 Oct 2019, Harald Dunkel wrote: The USB2 cable worked, too. Actually I had expected that the speed is reduced automatically according to the specs of the card. ??? That is doubtful. The speed of the connection is determined when the

Re: [PATCH 14/18] usb: typec: ucsi: Remove the old API

2019-10-22 Thread Ajay Gupta
Hi Heikki, > On Oct 22, 2019, at 12:04 AM, Heikki Krogerus > wrote: > > Hi Ajay, > >> On Mon, Oct 21, 2019 at 07:28:36PM +, Ajay Gupta wrote: >> Hi Heikki, >> >>> -Original Message- >>> From: linux-usb-ow...@vger.kernel.org >>> On Behalf Of Heikki Krogerus >>> Sent: Monday, Octob

Re: musb: cppi41: broken high speed FTDI functionality when connected to musb directly

2019-10-22 Thread Tony Lindgren
* Yegor Yefremov [191021 01:40]: > Hi Tony, > > On Thu, Oct 3, 2019 at 10:39 AM Yegor Yefremov > wrote: > > > > Hi Tony, > > > > On Wed, Oct 2, 2019 at 6:52 PM Tony Lindgren wrote: > > > > > > * Yegor Yefremov [191002 06:57]: > > > > On Wed, Oct 2, 2019 at 12:03 AM Tony Lindgren wrote: > > >

Re: [PATCH] PCI: increase D3 delay for AMD Ryzen5/7 XHCI controllers

2019-10-22 Thread Mika Westerberg
On Tue, Oct 22, 2019 at 10:40:00AM +0800, Daniel Drake wrote: > On Mon, Oct 21, 2019 at 7:33 PM Mika Westerberg > wrote: > > Just to be sure, did you try the patch or just looked at it? Because > > what the patch does is that it does the delay when the downstream/root > > port is resumed, not the

Re: [PATCH 00/18] usb: typec: API improvements

2019-10-22 Thread Heikki Krogerus
On Mon, Oct 21, 2019 at 08:41:16PM +, Ajay Gupta wrote: > Hi Heikki, > > > -Original Message- > > From: linux-usb-ow...@vger.kernel.org > > On Behalf Of Heikki Krogerus > > Sent: Monday, October 21, 2019 4:25 AM > > To: Greg Kroah-Hartman > > Cc: Guenter Roeck ; Ajay Gupta ; > > linu

Re: [PATCH 14/18] usb: typec: ucsi: Remove the old API

2019-10-22 Thread Heikki Krogerus
Hi Ajay, On Mon, Oct 21, 2019 at 07:28:36PM +, Ajay Gupta wrote: > Hi Heikki, > > > -Original Message- > > From: linux-usb-ow...@vger.kernel.org > > On Behalf Of Heikki Krogerus > > Sent: Monday, October 21, 2019 4:25 AM > > To: Greg Kroah-Hartman > > Cc: Guenter Roeck ; Ajay Gupta

Re: [PATCH] USB/Gadget: Fix race between gether_disconnect and rx_submit

2019-10-21 Thread Felipe Balbi
Hi, kvaradarajan writes: > From: Kiruthika Varadarajan > > During gadget connection/disconnect several times panic observed. > > [ 64.723260] BUG: unable to handle kernel NULL pointer dereference at > 00f0 > [ 64.732040] IP: [] rx_fill+0x1ed/0x3b0 > [ 64.737984] PGD 6bece067 PUD

Re: NEC Corporation uPD720200 regression: intermittent WARN: xHC CMD_RUN timeout during suspend

2019-10-21 Thread Julian Sikorski
W dniu 20.10.2019 o 15:41, Julian Sikorski pisze: > Hi list, > > the issue was originally investigated at kernel bugzilla: > https://bugzilla.kernel.org/show_bug.cgi?id=204529 > > In brief, my laptop has started having issues suspending a few months > back. I have eventually managed to produce us

Re: problem with XHCI_SPURIOUS_WAKEUP quirk

2019-10-21 Thread Takashi Iwai
On Mon, 21 Oct 2019 20:14:19 +0200, Ross Zwisler wrote: > > Hi, > > I'm hitting an issue on a Broadwell based Chromebox that appears to be > related to the XHCI_SPURIOUS_WAKEUP quirk. > > Here are the reproduction steps: > > 1) Start with a fully booted system on a recent kernel. I've been > t

Re: [PATCH] PCI: increase D3 delay for AMD Ryzen5/7 XHCI controllers

2019-10-21 Thread Daniel Drake
On Mon, Oct 21, 2019 at 7:33 PM Mika Westerberg wrote: > Just to be sure, did you try the patch or just looked at it? Because > what the patch does is that it does the delay when the downstream/root > port is resumed, not the xHCI itself. I tried it, it didn't fix the problem. Daniel

Re: [PATCH 12/18] usb: typec: ucsi: acpi: Move to the new API

2019-10-21 Thread kbuild test robot
Hi Heikki, I love your patch! Perhaps something to improve: [auto build test WARNING on usb/usb-testing] [cannot apply to v5.4-rc4 next-20191021] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to speci

RE: [PATCH 00/18] usb: typec: API improvements

2019-10-21 Thread Ajay Gupta
Hi Heikki, > -Original Message- > From: linux-usb-ow...@vger.kernel.org > On Behalf Of Heikki Krogerus > Sent: Monday, October 21, 2019 4:25 AM > To: Greg Kroah-Hartman > Cc: Guenter Roeck ; Ajay Gupta ; > linux-usb@vger.kernel.org > Subject: [PATCH 00/18] usb: typec: API improvements >

RE: [PATCH 14/18] usb: typec: ucsi: Remove the old API

2019-10-21 Thread Ajay Gupta
Hi Heikki, > -Original Message- > From: linux-usb-ow...@vger.kernel.org > On Behalf Of Heikki Krogerus > Sent: Monday, October 21, 2019 4:25 AM > To: Greg Kroah-Hartman > Cc: Guenter Roeck ; Ajay Gupta ; > linux-usb@vger.kernel.org > Subject: [PATCH 14/18] usb: typec: ucsi: Remove the ol

Re: [PATCH v3] usbip: tools: Fix read_usb_vudc_device() error path handling

2019-10-21 Thread shuah
On 10/17/19 9:22 PM, GwanYeong Kim wrote: This isn't really accurate right. fread() doesn't always return 0 in error. It could return < number of elements and set errno. Signed-off-by: GwanYeong Kim --- tools/usb/usbip/libsrc/usbip_device_driver.c | 6 -- 1 file changed, 4 insertions(+),

Re: 5.3.6: I/O error on writing SD card via USB3

2019-10-21 Thread Alan Stern
On Mon, 21 Oct 2019, Harald Dunkel wrote: > Hi Alan, > > On 10/19/19 4:57 PM, Alan Stern wrote: > > > > What happens if you don't use that rather slow 133x SD card? Do other > > cards work better? > > > > No problem with a 32 GByte SDHC card (U1). > > > Another possibility: If you attach the

Re: 5.3.6: I/O error on writing SD card via USB3

2019-10-21 Thread Harald Dunkel
Hi Alan, On 10/19/19 4:57 PM, Alan Stern wrote: What happens if you don't use that rather slow 133x SD card? Do other cards work better? No problem with a 32 GByte SDHC card (U1). Another possibility: If you attach the card adapter by a USB-2 cable then it will run as a USB-2 device (even

Re: [USB EHCI DRIVER] [Regression] EHCI no longer working in 5.4 series kernel

2019-10-21 Thread Arvind Sankar
On Mon, Oct 21, 2019 at 07:04:45AM +0200, Ben wrote: > Thanks, > > I could have sworn I checked lkml. Thanks for the fix! > > Any idea why only ehci is affected? > > Seems a bit odd, that's why I thought it would be a problem with usb driver. > I'm not sure -- in theory at least, it should aff

Re: [PATCH 11/18] usb: typec: ucsi: Simplified registration and I/O API

2019-10-21 Thread Heikki Krogerus
On Mon, Oct 21, 2019 at 06:17:30AM -0700, Guenter Roeck wrote: > On 10/21/19 4:25 AM, Heikki Krogerus wrote: > > Adding more simplified API for interface registration and > > read and write operations. > > > > The registration is split into separate creation and > > registration phases. That allow

RE: [PATCH 10/18] usb: typec: hd3ss3220: Give the connector fwnode to the port device

2019-10-21 Thread Biju Das
Hi Heikki, Thanks for the patch. > -Original Message- > From: Heikki Krogerus > Sent: Monday, October 21, 2019 12:25 PM > To: Greg Kroah-Hartman > Cc: Guenter Roeck ; Ajay Gupta ; > linux-usb@vger.kernel.org; Biju Das > Subject: [PATCH 10/18] usb: typec: hd3ss3220: Give the connector f

Re: [PATCH 11/18] usb: typec: ucsi: Simplified registration and I/O API

2019-10-21 Thread Guenter Roeck
On 10/21/19 4:25 AM, Heikki Krogerus wrote: Adding more simplified API for interface registration and read and write operations. The registration is split into separate creation and registration phases. That allows the drivers to properly initialize the interface before registering it if necessa

Re: [PATCH] PCI: increase D3 delay for AMD Ryzen5/7 XHCI controllers

2019-10-21 Thread Mika Westerberg
Hi, Sorry for the delay. I was on vacation last week. On Tue, Oct 15, 2019 at 01:31:32PM +0800, Daniel Drake wrote: > On Mon, Oct 14, 2019 at 11:43 PM Bjorn Helgaas wrote: > > Can you tell if this is because the Ryzen7 XHCI controller is out of > > spec, or is the Linux PCI core missing some del

Re: musb: cppi41: broken high speed FTDI functionality when connected to musb directly

2019-10-21 Thread Yegor Yefremov
Hi Tony, On Thu, Oct 3, 2019 at 10:39 AM Yegor Yefremov wrote: > > Hi Tony, > > On Wed, Oct 2, 2019 at 6:52 PM Tony Lindgren wrote: > > > > * Yegor Yefremov [191002 06:57]: > > > On Wed, Oct 2, 2019 at 12:03 AM Tony Lindgren wrote: > > > > The other way to fix this would be to just wake up cpp

Re: [PATCH 2/3] usb: typec: tcpm: Add support for configuring DP altmode through device-properties

2019-10-20 Thread Heikki Krogerus
Hi Hans, On Fri, Oct 18, 2019 at 09:57:18PM +0200, Hans de Goede wrote: > Add support for configuring display-port altmode through device-properties. > > We could try to add a generic mechanism for describing altmodes in > device-properties, but various altmodes will likely need altmode specific

Re: [USB EHCI DRIVER] [Regression] EHCI no longer working in 5.4 series kernel

2019-10-20 Thread Ben
Thanks, I could have sworn I checked lkml. Thanks for the fix! Any idea why only ehci is affected? Seems a bit odd, that's why I thought it would be a problem with usb driver. Cheers, Benedikt Am 20.10.19 um 22:55 schrieb Arvind Sankar: On Sat, Oct 19, 2019 at 02:52:16PM +0200, Benedikt Sche

Re: [PATCH] usb: mtu3: fix missing include of mtu3_dr.h

2019-10-20 Thread Chunfeng Yun
On Thu, 2019-10-17 at 18:27 +0100, Ben Dooks (Codethink) wrote: > The declarations of ssusb_gadget_{init,exit} are > in the mtu3_dr.h file but the code does that implements > them does not include this. Add the include to fix the > following sparse warnigns: > > drivers/usb/mtu3/mtu3_core.c:825:5:

Re: [PATCH 2/3] usb: typec: tcpm: Add support for configuring DP altmode through device-properties

2019-10-20 Thread Guenter Roeck
On 10/18/19 12:57 PM, Hans de Goede wrote: Add support for configuring display-port altmode through device-properties. We could try to add a generic mechanism for describing altmodes in device-properties, but various altmodes will likely need altmode specific configuration. E.g. the display-port

Re: [PATCH 1/3] usb: typec: tcpm: Remove tcpc_config configuration mechanism

2019-10-20 Thread Guenter Roeck
On Fri, Oct 18, 2019 at 09:57:17PM +0200, Hans de Goede wrote: > All configuration can and should be done through fwnodes instead of > through the tcpc_config struct and there are no existing users left of > struct tcpc_config, so lets remove it. > > Signed-off-by: Hans de Goede Reviewed-by: Gue

Re: [USB EHCI DRIVER] [Regression] EHCI no longer working in 5.4 series kernel

2019-10-20 Thread Arvind Sankar
On Sat, Oct 19, 2019 at 02:52:16PM +0200, Benedikt Schemmer wrote: > reverting that specific commit on top of todays linux git (d418d070057c) > produces a good kernel Hi Ben, the fix is in https://lore.kernel.org/lkml/20191008143357.ga599...@rani.riverdale.lan/ > > Am 18.10.19 um 00:31 schrieb

Re: 5.3.6: I/O error on writing SD card via USB3

2019-10-19 Thread Alan Stern
On Sat, 19 Oct 2019, Harald Dunkel wrote: > Hi folks, > > I've got an USB3 SD card adapter (device info attached). Problem: > Writing a (rather slow 133x) SD card via an USB3 slot I get I/O errors, > see attached kern.log. If I use an USB2 slot, then there is no problem > (not shown here). > > T

Re: [USB EHCI DRIVER] [Regression] EHCI no longer working in 5.4 series kernel

2019-10-19 Thread Benedikt Schemmer
reverting that specific commit on top of todays linux git (d418d070057c) produces a good kernel Am 18.10.19 um 00:31 schrieb Alan Stern: > On Thu, 17 Oct 2019, Benedikt Schemmer wrote: > >> Hi all, >> >> I recently started compiling the 5.4. kernel starting with rc3 and noticed >> that both my

Re: [USB EHCI DRIVER] [Regression] EHCI no longer working in 5.4 series kernel

2019-10-19 Thread Benedikt Schemmer
Beschreibung: DVD-RAM writer Produkt: BD-RE BH10LS30 Hersteller: HL-DT-ST Physische ID: 0.0.0 Bus-Informationen: scsi@4:0.0.0 Logischer Name: /dev/cdrom Logischer Name: /dev/cdrw Logischer Name: /dev/d

Re: [USB EHCI DRIVER] [Regression] EHCI no longer working in 5.4 series kernel

2019-10-19 Thread Benedikt Schemmer
Hello Alan, hello Christoph, >> I recently started compiling the 5.4. kernel starting with rc3 and noticed >> that both my keyboard and mouse aren't working >> when connected to the motherboards USB ports (they work fine when connected >> to an xhci extension card) and they work fine >> with the

Re: [USB EHCI DRIVER] [Regression] EHCI no longer working in 5.4 series kernel

2019-10-18 Thread Benedikt Schemmer
Hi Alan, of course I can. It just takes ages on the machine I'm using. The problem seems to be with one of the commits in 671df1895378 ("Merge tag 'dma-mapping-5.4' of git://git.infradead.org/users/hch/dma-mapping", 2019-09-19) right at the beginning of 5.4 before rc1 I will have the exact commi

Re: [GIT PULL] USB-serial fixes for 5.4-rc4

2019-10-18 Thread Greg Kroah-Hartman
On Fri, Oct 18, 2019 at 05:39:53PM +0200, Johan Hovold wrote: > The following changes since commit 4f5cafb5cb8471e54afdc9054d973535614f7675: > > Linux 5.4-rc3 (2019-10-13 16:37:36 -0700) > > are available in the Git repository at: > > https://git.kernel.org/pub/scm/linux/kernel/git/johan/usb

Re: [PATCH 1/3] usb: chipidea: imx: change hsic power regulator as optional

2019-10-18 Thread André Draszik
Peter, Thank you for this series, I was out so I will test it early next week and report. Cheers, Andre' On Fri, 2019-10-11 at 05:42 +, Peter Chen wrote: > Not every platform needs this regulator. > > Signed-off-by: Peter Chen > --- > drivers/usb/chipidea/ci_hdrc_imx.c | 3 ++- > 1 file

Re: [PATCH] usb: cdns3: include host-export,h for cdns3_host_init

2019-10-18 Thread Ben Dooks
On 18/10/2019 04:45, Pawel Laszczak wrote: Hi The cdns3_host_init() function is declared in host-export.h but host.c does not include it. Add the include to have the declaration present (and remove the declaration of cdns3_host_exit which is now static). Fixes the following sparse warning: dr

RE: [PATCH] usb: cdns3: include host-export,h for cdns3_host_init

2019-10-17 Thread Pawel Laszczak
Hi >The cdns3_host_init() function is declared in host-export.h >but host.c does not include it. Add the include to have >the declaration present (and remove the declaration of >cdns3_host_exit which is now static). > >Fixes the following sparse warning: > >drivers/usb/cdns3/host.c:58:5: warning:

Re: [USB EHCI DRIVER] [Regression] EHCI no longer working in 5.4 series kernel

2019-10-17 Thread Alan Stern
On Thu, 17 Oct 2019, Benedikt Schemmer wrote: > Hi all, > > I recently started compiling the 5.4. kernel starting with rc3 and noticed > that both my keyboard and mouse aren't working > when connected to the motherboards USB ports (they work fine when connected > to an xhci extension card) and

Re: [PATCH v2] usbip: tools: Fix read_usb_vudc_device() error path handling

2019-10-17 Thread shuah
On 10/16/19 11:26 PM, GwanYeong Kim wrote: On Wed, 16 Oct 2019 20:33:39 -0600 shuah wrote: On 10/16/19 8:25 PM, GwanYeong Kim wrote: cannot be less than 0 - fread() returns 0 on error. This isn't really accurate right. fread() doesn't always return 0 in error. It could return < number of e

Re: [PATCH v2] usbip: tools: Fix read_usb_vudc_device() error path handling

2019-10-16 Thread GwanYeong Kim
On Wed, 16 Oct 2019 20:33:39 -0600 shuah wrote: > On 10/16/19 8:25 PM, GwanYeong Kim wrote: > > cannot be less than 0 - fread() returns 0 on error. > > > > This isn't really accurate right. fread() doesn't always > return 0 in error. It could return < number of elements > and set errno. > > Pl

Re: [PATCH v2] usbip: tools: Fix read_usb_vudc_device() error path handling

2019-10-16 Thread shuah
On 10/16/19 8:25 PM, GwanYeong Kim wrote: cannot be less than 0 - fread() returns 0 on error. This isn't really accurate right. fread() doesn't always return 0 in error. It could return < number of elements and set errno. Please make changes to reflect that. Signed-off-by: GwanYeong Kim --

Re: [PATCH 2/7] usb: musb: omap2430: Wait on enable to avoid babble

2019-10-16 Thread Tony Lindgren
* Sergei Shtylyov [191010 09:46]: > Hello! > > On 10.10.2019 0:21, Tony Lindgren wrote: > > > We can babble interrupt if we attempt to switch to USB host mode too > ^ verb missing? Thanks for catching it, it should say "We can get babble...". Bin, do you need a resend of the whole seri

Re: [PATCH] usbip: tools: Fix read_usb_vudc_device() error path handling

2019-10-16 Thread Greg KH
On Wed, Oct 16, 2019 at 01:38:25PM +0900, GwanYeong Kim wrote: > On Tue, 15 Oct 2019 17:14:32 -0600 > shuah wrote: > > > On 10/15/19 7:14 AM, GwanYeong Kim wrote: > > > cannot be less than 0 - fread() returns 0 on error. > > > > > > Signed-off-by: GwanYeong Kim > > > --- > > > tools/usb/usbip

Re: how to test g_webcam

2019-10-16 Thread Roger Quadros
Hi, On 15/10/2019 18:26, Gopal, Saranya wrote: Hi Quadros, I used the a different uvc-gadget application from this location [1] and it seems to work quite fine with builtin video pattern and jpg image but not with V4L2 capture source. So something is broken in uvc-gadget at [2] [1] https://

Re: [PATCH] PCI: increase D3 delay for AMD Ryzen5/7 XHCI controllers

2019-10-15 Thread Daniel Drake
On Wed, Oct 16, 2019 at 1:52 AM Rafael J. Wysocki wrote: > On Tue, Oct 15, 2019 at 7:31 AM Daniel Drake wrote: > > It's actually coming out of D3cold here, however what happens right > > before this is that __pci_start_power_transition() calls > > pci_platform_power_transition(D0) to leave D3cold

Re: [PATCH] usbip: tools: Fix read_usb_vudc_device() error path handling

2019-10-15 Thread GwanYeong Kim
On Tue, 15 Oct 2019 17:14:32 -0600 shuah wrote: > On 10/15/19 7:14 AM, GwanYeong Kim wrote: > > cannot be less than 0 - fread() returns 0 on error. > > > > Signed-off-by: GwanYeong Kim > > --- > > tools/usb/usbip/libsrc/usbip_device_driver.c | 2 +- > > 1 file changed, 1 insertion(+), 1 dele

Re: [PATCH] usbip: tools: Fix read_usb_vudc_device() error path handling

2019-10-15 Thread shuah
On 10/15/19 7:14 AM, GwanYeong Kim wrote: cannot be less than 0 - fread() returns 0 on error. Signed-off-by: GwanYeong Kim --- tools/usb/usbip/libsrc/usbip_device_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/usb/usbip/libsrc/usbip_device_driver.c b/tool

Re: USB-C dock ethernet port issue

2019-10-15 Thread Marc Fauvain
with extract from dmesg : usb 4-2-port3: Cannot enable. Maybe the USB cable is bad? usb 4-2-port3: Cannot enable. Maybe the USB cable is bad? usb 1-8.3: new high-speed USB device number 26 using xhci_hcd usb 4-2-port3: Cannot enable. Maybe the USB cable is bad? usb 4-2-port3: Cannot enable. Maybe

Re: [PATCH v2 3/6] USB: Implement usb_device_match_id()

2019-10-15 Thread Alan Stern
On Tue, 15 Oct 2019, Bastien Nocera wrote: > Match a usb_device with a table of IDs. > > Signed-off-by: Bastien Nocera > --- > drivers/usb/core/driver.c | 15 +++ > include/linux/usb.h | 2 ++ > 2 files changed, 17 insertions(+) > > diff --git a/drivers/usb/core/driver.c b/d

Re: [PATCH v2] usb: usbfs: Suppress problematic bind and unbind uevents.

2019-10-15 Thread Greg KH
On Fri, Oct 11, 2019 at 01:55:18PM +0200, Ingo Rohloff wrote: > commit 1455cf8dbfd0 ("driver core: emit uevents when device is bound > to a driver") added bind and unbind uevents when a driver is bound or > unbound to a physical device. > > For USB devices which are handled via the generic usbfs l

Re: [PATCH] PCI: increase D3 delay for AMD Ryzen5/7 XHCI controllers

2019-10-15 Thread Rafael J. Wysocki
On Tue, Oct 15, 2019 at 7:31 AM Daniel Drake wrote: > > On Mon, Oct 14, 2019 at 11:43 PM Bjorn Helgaas wrote: > > Can you tell if this is because the Ryzen7 XHCI controller is out of > > spec, or is the Linux PCI core missing some delay? If the latter, > > fixing the core might fix other devices

RE: how to test g_webcam

2019-10-15 Thread Gopal, Saranya
Hi Quadros, > I used the a different uvc-gadget application from this location [1] and it > seems > to > work quite fine with builtin video pattern and jpg image but not with V4L2 > capture source. > > So something is broken in uvc-gadget at [2] > > [1] https://github.com/wlhe/uvc-gadget > [2]

Re: [PATCH v2 0/6] Add Apple MFi fastcharge USB device driver

2019-10-15 Thread Bastien Nocera
On Tue, 2019-10-15 at 16:27 +0200, Bastien Nocera wrote: > This is version 2 of the patch set. > > - checkpatch.pl is now quiet > - fallback to the generic driver when driver ->probe() fails And I'll send a v3 because all the patches got mangled by my mail client.

Re: how to test g_webcam

2019-10-15 Thread Roger Quadros
Hi, On 14/10/2019 17:22, Felipe Balbi wrote: Hi, Roger Quadros writes: Hmm, Link Change is disabled by default upstream, unless you're running on anything older than 2.50a. I don't remember the version you're using, though :-p 2.02a Thanks :-) irq/170-dwc3-270 [000] d... 173

Re: [PATCH] PCI: increase D3 delay for AMD Ryzen5/7 XHCI controllers

2019-10-14 Thread Daniel Drake
On Mon, Oct 14, 2019 at 11:43 PM Bjorn Helgaas wrote: > Can you tell if this is because the Ryzen7 XHCI controller is out of > spec, or is the Linux PCI core missing some delay? If the latter, > fixing the core might fix other devices as well. > > Mika has this patch: > https://lore.kernel.org/r/

Re: [PATCH] PCI: increase D3 delay for AMD Ryzen5/7 XHCI controllers

2019-10-14 Thread Bjorn Helgaas
[+cc Mika] On Mon, Oct 14, 2019 at 02:13:55PM +0800, Daniel Drake wrote: > On Asus laptops with AMD Ryzen7 3700U and AMD Ryzen5 3500U, > the XHCI controller fails to resume from runtime suspend or s2idle, > and USB becomes unusable from that point. > > xhci_hcd :03:00.4: Refused to change pow

Re: how to test g_webcam

2019-10-14 Thread Felipe Balbi
Hi, Roger Quadros writes: >> Hmm, Link Change is disabled by default upstream, unless you're running >> on anything older than 2.50a. I don't remember the version you're using, >> though :-p > > 2.02a Thanks :-) >>> irq/170-dwc3-270 [000] d... 173.408918: dwc3_event: event >>> (000

Re: how to test g_webcam

2019-10-14 Thread Roger Quadros
On 14/10/2019 15:38, Felipe Balbi wrote: Hi, Roger Quadros writes: I'm having a hard time to figure out how to get g_webcam working with the tip of http://git.ideasonboard.org/uvc-gadget.git Platform I'm using is dra7-evm with dwc3 controller. which arguments are you passing to g_webcam

Re: [RFT PATCH] xhci: Fix use-after-free regression in xhci clear hub TT implementation

2019-10-14 Thread Mathias Nyman
On 14.10.2019 13.16, Johan Hovold wrote: On Fri, Oct 11, 2019 at 03:58:42PM +0300, Mathias Nyman wrote: commit ef513be0a905 ("usb: xhci: Add Clear_TT_Buffer") schedules work to clear TT buffer, but causes a use-after-free regression at the same time Make sure hub_tt_work finishes before endpoin

Re: Regression: USB/xhci issues on some systems with newer kernel versions

2019-10-14 Thread Mathias Nyman
On 3.10.2019 18.13, Bernhard Gebetsberger wrote: I sent the instructions to one of the users in the bug tracker. Here is the download link for his logs: https://www.sendspace.com/file/413hlj Thanks. Traces show driver handles the Transaction error normally by issuing a endpoint reset, which i

Re: how to test g_webcam

2019-10-14 Thread Felipe Balbi
Hi, Roger Quadros writes: >>> I'm having a hard time to figure out how to get g_webcam working with >>> the tip of http://git.ideasonboard.org/uvc-gadget.git >>> >>> Platform I'm using is dra7-evm with dwc3 controller. >> >> which arguments are you passing to g_webcam? > > I've tried a couple

Re: Etron EJ168A controller

2019-10-14 Thread Oliver Neukum
Am Mittwoch, den 09.10.2019, 11:57 -0700 schrieb Kenneth: > Hi, > > I was informed that there were bug fixes for the Etron EJ168A controller in > kernel 5.2 and 5.3 > > While I can read most USB sticks, if I connect an android phone to this port, > applications hang trying to access the phone.

Re: how to test g_webcam

2019-10-14 Thread Roger Quadros
+Bin Hi, On 11/10/2019 16:06, Felipe Balbi wrote: Hi, Roger Quadros writes: Hi, I'm having a hard time to figure out how to get g_webcam working with the tip of http://git.ideasonboard.org/uvc-gadget.git Platform I'm using is dra7-evm with dwc3 controller. which arguments are you passi

Re: [PATCH v2] usb: typec: fix an IS_ERR() vs NULL bug in hd3ss3220_probe()

2019-10-14 Thread Heikki Krogerus
On Fri, Oct 11, 2019 at 09:50:55PM +0300, Dan Carpenter wrote: > The device_get_named_child_node() function doesn't return error > pointers, it returns NULL on error. > > Fixes: 1c48c759ef4b ("usb: typec: driver for TI HD3SS3220 USB Type-C DRP port > controller") > Signed-off-by: Dan Carpenter

Re: [RFT PATCH] xhci: Fix use-after-free regression in xhci clear hub TT implementation

2019-10-14 Thread Johan Hovold
On Fri, Oct 11, 2019 at 03:58:42PM +0300, Mathias Nyman wrote: > commit ef513be0a905 ("usb: xhci: Add Clear_TT_Buffer") schedules work > to clear TT buffer, but causes a use-after-free regression at the same time > > Make sure hub_tt_work finishes before endpoint is disabled, otherwise > the work

Re: Possible bug with cdc_ether, triggers NETDEV WATCHDOG

2019-10-14 Thread Oliver Neukum
Am Mittwoch, den 09.10.2019, 09:27 -0400 schrieb Adam Bennett: > On 10/9/19 4:53 AM, Bjørn Mork wrote: > > This warning means that the gadget doesn't accept the packets we send > > it. There isn't much the host can do about that, except dropping > > packets on the floor. Which is why the warning

Re: Re: usb: dwc2: Re: Maximum packet size in dwc2 gadget HS mode < 1024

2019-10-13 Thread Pavel Hofman
Hi Minas Dne 11. 10. 19 v 9:45 Minas Harutyunyan napsal(a): Hi Pavel, Could you please send regdump and debug log for failing case. Thanks a lot for your reply. Attaching regdump-960bytes.txt for 32kHz/16b/15ch both playback and capture, bInterval=4 in https://github.com/torvalds/linux

Re: [PATCH 7/7] usb: musb: Get rid of omap2430_musb_set_vbus()

2019-10-13 Thread Pavel Machek
On Wed 2019-10-09 14:21:44, Tony Lindgren wrote: > Now that we've removed direct calls from interrupt handler to > omap2430_musb_set_vbus(), let's make things less confusing and > configure VBUS directly in omap_musb_set_mailbox(). > > We have omap_musb_set_mailbox() called from the PHYs, and that

Re: [PATCH 3/7] usb: musb: omap2430: Handle multiple ID ground interrupts

2019-10-13 Thread Pavel Machek
On Wed 2019-10-09 14:21:40, Tony Lindgren wrote: > We currently get "unhandled DISCONNECT transition" warnings from musb core > on device disconnect as things are wrongly set to OTG_STATE_A_IDLE in > host mode when enumerating devices. We can also get "Failed to write reg > index" errors after enum

Re: [PATCH v4 1/9] usb: typec: Copy everything from struct typec_capability during registration

2019-10-11 Thread Guenter Roeck
On Fri, Oct 11, 2019 at 06:32:11PM +0300, Heikki Krogerus wrote: > Copying everything from struct typec_capability to struct > typec_port during port registration. This will make sure > that under no circumstances the driver can change the values > in the struct typec_capability that the port uses.

Re: [PATCH v2] USB: legousbtower: fix a signedness bug in tower_probe()

2019-10-11 Thread Johan Hovold
On Fri, Oct 11, 2019 at 05:11:15PM +0300, Dan Carpenter wrote: > The problem is that sizeof() is unsigned long so negative error codes > are type promoted to high positive values and the condition becomes > false. > > Fixes: 1d427be4a39d ("USB: legousbtower: fix slab info leak at probe") > Signed-

Re: [PATCH] USB: legousbtower: fix a signedness bug in tower_probe()

2019-10-11 Thread Johan Hovold
On Fri, Oct 11, 2019 at 04:58:56PM +0300, Dan Carpenter wrote: > On Fri, Oct 11, 2019 at 03:51:26PM +0200, walter harms wrote: > > > > > > Am 11.10.2019 15:35, schrieb Dan Carpenter: > > > The problem is that sizeof() is unsigned long so negative error codes > > > are type promoted to high positi

Re: [PATCH] USB: legousbtower: fix a signedness bug in tower_probe()

2019-10-11 Thread Johan Hovold
On Fri, Oct 11, 2019 at 04:35:25PM +0300, Dan Carpenter wrote: > The problem is that sizeof() is unsigned long so negative error codes > are type promoted to high positive values and the condition becomes > false. > > Fixes: 1d427be4a39d ("USB: legousbtower: fix slab info leak at probe") > Signed-

  1   2   3   4   5   6   7   8   9   10   >