Re: Ejected Nook (usb mass storage) prevents suspend

2013-09-13 Thread Oliver Neukum
On Fri, 2013-09-13 at 06:37 -0700, Andy Lutomirski wrote: > What's the status of this? Do I still need to test it? > > I won't have access to the Nook that triggered it the first time for a > couple weeks, but I could try to find another device like that. It works for me. I'll push upstream in a

Re: Ejected Nook (usb mass storage) prevents suspend

2013-09-13 Thread Andy Lutomirski
What's the status of this? Do I still need to test it? I won't have access to the Nook that triggered it the first time for a couple weeks, but I could try to find another device like that. --Andy On Fri, Aug 2, 2013 at 7:18 AM, Alan Stern wrote: > On Fri, 2 Aug 2013, Oliver Neukum wrote: > >>

Re: Ejected Nook (usb mass storage) prevents suspend

2013-08-02 Thread Alan Stern
On Fri, 2 Aug 2013, Oliver Neukum wrote: > On Fri, 2013-08-02 at 09:54 -0400, Alan Stern wrote: > > On Fri, 2 Aug 2013, Oliver Neukum wrote: > > > > > On Thu, 2013-08-01 at 11:53 -0400, Alan Stern wrote: > > > > On Thu, 1 Aug 2013, Oliver Neukum wrote: > > > > > > > > > On Wed, 2013-07-31 at 11:

Re: Ejected Nook (usb mass storage) prevents suspend

2013-08-02 Thread Oliver Neukum
On Fri, 2013-08-02 at 09:54 -0400, Alan Stern wrote: > On Fri, 2 Aug 2013, Oliver Neukum wrote: > > > On Thu, 2013-08-01 at 11:53 -0400, Alan Stern wrote: > > > On Thu, 1 Aug 2013, Oliver Neukum wrote: > > > > > > > On Wed, 2013-07-31 at 11:13 -0400, Alan Stern wrote: > > > > > > > > > More impo

Re: Ejected Nook (usb mass storage) prevents suspend

2013-08-02 Thread Alan Stern
On Fri, 2 Aug 2013, Oliver Neukum wrote: > On Thu, 2013-08-01 at 11:53 -0400, Alan Stern wrote: > > On Thu, 1 Aug 2013, Oliver Neukum wrote: > > > > > On Wed, 2013-07-31 at 11:13 -0400, Alan Stern wrote: > > > > > > > More importantly, if we already know that the medium is not present or > > > >

Re: Ejected Nook (usb mass storage) prevents suspend

2013-08-02 Thread Oliver Neukum
On Thu, 2013-08-01 at 11:53 -0400, Alan Stern wrote: > On Thu, 1 Aug 2013, Oliver Neukum wrote: > > > On Wed, 2013-07-31 at 11:13 -0400, Alan Stern wrote: > > > > > More importantly, if we already know that the medium is not present or > > > has been changed since it was last used, then there's n

Re: Ejected Nook (usb mass storage) prevents suspend

2013-08-01 Thread Alan Stern
On Thu, 1 Aug 2013, Oliver Neukum wrote: > On Wed, 2013-07-31 at 11:13 -0400, Alan Stern wrote: > > > More importantly, if we already know that the medium is not present or > > has been changed since it was last used, then there's no reason to call > > sd_sync_cache() at all. > > Like this? Yes

Re: Ejected Nook (usb mass storage) prevents suspend

2013-08-01 Thread Oliver Neukum
On Wed, 2013-07-31 at 11:13 -0400, Alan Stern wrote: > More importantly, if we already know that the medium is not present or > has been changed since it was last used, then there's no reason to call > sd_sync_cache() at all. Like this? Regards Oliver >From 8c90d860652

Re: Ejected Nook (usb mass storage) prevents suspend

2013-07-31 Thread Alan Stern
On Wed, 31 Jul 2013, Oliver Neukum wrote: > These errors should be handled cleanly. How about this patch? > From 76a377d9894dc8945e9afecc7f9864e6dc3156b1 Mon Sep 17 00:00:00 2001 > From: Oliver Neukum > Date: Wed, 31 Jul 2013 13:32:51 +0200 > Subject: [PATCH] sd: handle errors during suspend >

Re: Ejected Nook (usb mass storage) prevents suspend

2013-07-31 Thread Oliver Neukum
On Mon, 2013-07-29 at 10:21 -0400, Alan Stern wrote: > On Mon, 29 Jul 2013, Oliver Neukum wrote: > > > On Fri, 2013-07-26 at 16:31 -0400, Alan Stern wrote: > > > > > In addition to my earlier comment, the patch below should be applied. > > > It will fix your immediate problem, although not in t

Re: Ejected Nook (usb mass storage) prevents suspend

2013-07-30 Thread Oliver Neukum
On Tue, 2013-07-30 at 13:00 -0400, Alan Stern wrote: > That's why I said the patch would fix the immediate problem but it > wasn't the best solution. You do agree that the patch is correct, as > far as it goes? It will allow the system to sleep. But it seems to me that a genuine error while flus

Re: Ejected Nook (usb mass storage) prevents suspend

2013-07-30 Thread Alan Stern
On Tue, 30 Jul 2013, Oliver Neukum wrote: > On Mon, 2013-07-29 at 10:21 -0400, Alan Stern wrote: > > On Mon, 29 Jul 2013, Oliver Neukum wrote: > > > > > On Fri, 2013-07-26 at 16:31 -0400, Alan Stern wrote: > > > > > > > In addition to my earlier comment, the patch below should be applied. > >

Re: Ejected Nook (usb mass storage) prevents suspend

2013-07-30 Thread Oliver Neukum
On Mon, 2013-07-29 at 10:21 -0400, Alan Stern wrote: > On Mon, 29 Jul 2013, Oliver Neukum wrote: > > > On Fri, 2013-07-26 at 16:31 -0400, Alan Stern wrote: > > > > > In addition to my earlier comment, the patch below should be applied. > > > It will fix your immediate problem, although not in t

Re: Ejected Nook (usb mass storage) prevents suspend

2013-07-29 Thread Alan Stern
On Mon, 29 Jul 2013, Oliver Neukum wrote: > On Fri, 2013-07-26 at 16:31 -0400, Alan Stern wrote: > > > In addition to my earlier comment, the patch below should be applied. > > It will fix your immediate problem, although not in the best way. > > Alan, > > I think your diagnosis is correct, b

Re: Ejected Nook (usb mass storage) prevents suspend

2013-07-28 Thread Oliver Neukum
On Fri, 2013-07-26 at 16:31 -0400, Alan Stern wrote: > In addition to my earlier comment, the patch below should be applied. > It will fix your immediate problem, although not in the best way. Alan, I think your diagnosis is correct, but not the fix. This is run even in the runtime case. We mi

Re: Ejected Nook (usb mass storage) prevents suspend

2013-07-28 Thread Oliver Neukum
On Fri, 2013-07-26 at 09:54 -0700, Andy Lutomirski wrote: > This is kernel 3.9.9-302.fc19.x86_64. > > I plugged in a BN Nook (a usb mass storage device), used it, and > ejected it. This makes suspend fail: > > [50135.265514] PM: Entering freeze sleep > [50135.265517] Suspending console(s) (use n

Re: Ejected Nook (usb mass storage) prevents suspend

2013-07-26 Thread Alan Stern
On Fri, 26 Jul 2013, Andy Lutomirski wrote: > This is kernel 3.9.9-302.fc19.x86_64. > > I plugged in a BN Nook (a usb mass storage device), used it, and > ejected it. This makes suspend fail: > > [50135.265514] PM: Entering freeze sleep > [50135.265517] Suspending console(s) (use no_console_sus

Re: Ejected Nook (usb mass storage) prevents suspend

2013-07-26 Thread Alan Stern
On Fri, 26 Jul 2013, Andy Lutomirski wrote: > This is kernel 3.9.9-302.fc19.x86_64. > > I plugged in a BN Nook (a usb mass storage device), used it, and > ejected it. This makes suspend fail: > > [50135.265514] PM: Entering freeze sleep > [50135.265517] Suspending console(s) (use no_console_sus

Ejected Nook (usb mass storage) prevents suspend

2013-07-26 Thread Andy Lutomirski
This is kernel 3.9.9-302.fc19.x86_64. I plugged in a BN Nook (a usb mass storage device), used it, and ejected it. This makes suspend fail: [50135.265514] PM: Entering freeze sleep [50135.265517] Suspending console(s) (use no_console_suspend to debug) [50135.287724] sd 7:0:0:0: [sdb] Synchronizi