Re: [RFC PATCH] usb: Change persist_enabled when attribute avoid_reset_quirk is changed

2012-07-24 Thread Alan Stern
On Tue, 24 Jul 2012, Lan Tianyu wrote: > 于 2012/7/24 22:59, Alan Stern 写道: > > Yes, good idea. > > > > When you do this, you should also add another little paragraph to > > Documentation/usb/persist.txt. At the end of the "What is the > > solution?" section, explain why the persist attribute cann

Re: [RFC PATCH] usb: Change persist_enabled when attribute avoid_reset_quirk is changed

2012-07-24 Thread Lan Tianyu
于 2012/7/24 22:59, Alan Stern 写道: Yes, good idea. When you do this, you should also add another little paragraph to Documentation/usb/persist.txt. At the end of the "What is the solution?" section, explain why the persist attribute cannot be set if the avoid_reset_quirk attribute is on. Hmmm,

Re: [RFC PATCH] usb: Change persist_enabled when attribute avoid_reset_quirk is changed

2012-07-24 Thread Lan Tianyu
于 2012/7/24 22:59, Alan Stern 写道: On Tue, 24 Jul 2012, Lan Tianyu wrote: 于 2012/7/24 22:21, Alan Stern 写道: On Tue, 24 Jul 2012, Lan Tianyu wrote: @@ -209,10 +209,13 @@ set_avoid_reset_quirk(struct device *dev, struct device_attribute *attr, if (sscanf(buf, "%d", &config) != 1 || conf

Re: [RFC PATCH] usb: Change persist_enabled when attribute avoid_reset_quirk is changed

2012-07-24 Thread Alan Stern
On Tue, 24 Jul 2012, Lan Tianyu wrote: > 于 2012/7/24 22:21, Alan Stern 写道: > > On Tue, 24 Jul 2012, Lan Tianyu wrote: > >> @@ -209,10 +209,13 @@ set_avoid_reset_quirk(struct device *dev, struct > >> device_attribute *attr, > >>if (sscanf(buf, "%d", &config) != 1 || config < 0 || config > 1) >

Re: [RFC PATCH] usb: Change persist_enabled when attribute avoid_reset_quirk is changed

2012-07-24 Thread Lan Tianyu
于 2012/7/24 22:21, Alan Stern 写道: On Tue, 24 Jul 2012, Lan Tianyu wrote: @@ -209,10 +209,13 @@ set_avoid_reset_quirk(struct device *dev, struct device_attribute *attr, if (sscanf(buf, "%d", &config) != 1 || config < 0 || config > 1) Please do me a favor: Rename the "config" variable t

Re: [RFC PATCH] usb: Change persist_enabled when attribute avoid_reset_quirk is changed

2012-07-24 Thread Alan Stern
On Tue, 24 Jul 2012, Lan Tianyu wrote: > The quirk USB_QUIRK_RESET_MORPHS means the device can't be reset > and reset-resume. So persist_enabled also should be set simultaneously > with USB_QUIRK_RESET_MORPHS flag. But Currently in the attribute > avoid_reset_quirk store callback just set USB_QUIR

Re: [RFC PATCH] usb: Change persist_enabled when attribute avoid_reset_quirk is changed

2012-07-24 Thread Oliver Neukum
On Tuesday 24 July 2012 21:48:37 Lan Tianyu wrote: > 于 2012/7/24 21:35, Oliver Neukum 写道: > > On Tuesday 24 July 2012 21:28:30 Lan Tianyu wrote: > >> Current only in the usb_detect_quirks(), persist_enabled will > >> be set to 0 depending on whether the dev's flag USB_QUIRK_RESET_MORPHS > >> is se

Re: [RFC PATCH] usb: Change persist_enabled when attribute avoid_reset_quirk is changed

2012-07-24 Thread Lan Tianyu
于 2012/7/24 21:35, Oliver Neukum 写道: On Tuesday 24 July 2012 21:28:30 Lan Tianyu wrote: Current only in the usb_detect_quirks(), persist_enabled will be set to 0 depending on whether the dev's flag USB_QUIRK_RESET_MORPHS is set or not. And usb_detect_quirks() is only called in the hub_port_conn

Re: [RFC PATCH] usb: Change persist_enabled when attribute avoid_reset_quirk is changed

2012-07-24 Thread Oliver Neukum
On Tuesday 24 July 2012 21:28:30 Lan Tianyu wrote: > Current only in the usb_detect_quirks(), persist_enabled will > be set to 0 depending on whether the dev's flag USB_QUIRK_RESET_MORPHS > is set or not. And usb_detect_quirks() is only called in the > hub_port_connect_change() when a new device

Re: [RFC PATCH] usb: Change persist_enabled when attribute avoid_reset_quirk is changed

2012-07-24 Thread Lan Tianyu
于 2012/7/24 16:57, Oliver Neukum 写道: On Tuesday 24 July 2012 16:39:37 Lan Tianyu wrote: The quirk USB_QUIRK_RESET_MORPHS means the device can't be reset and reset-resume. So persist_enabled also should be set simultaneously Set? Why bother? If anything reset_resume() is hopeless, so why delay

Re: [RFC PATCH] usb: Change persist_enabled when attribute avoid_reset_quirk is changed

2012-07-24 Thread Oliver Neukum
On Tuesday 24 July 2012 16:39:37 Lan Tianyu wrote: > The quirk USB_QUIRK_RESET_MORPHS means the device can't be reset > and reset-resume. So persist_enabled also should be set simultaneously Set? Why bother? If anything reset_resume() is hopeless, so why delay the resume by trying? Regard

[RFC PATCH] usb: Change persist_enabled when attribute avoid_reset_quirk is changed

2012-07-24 Thread Lan Tianyu
The quirk USB_QUIRK_RESET_MORPHS means the device can't be reset and reset-resume. So persist_enabled also should be set simultaneously with USB_QUIRK_RESET_MORPHS flag. But Currently in the attribute avoid_reset_quirk store callback just set USB_QUIRK_RESET_MORPHS. The persist_enabled will only be