Re: [RFC PATCH] usb: Change persist_enabled when attribute avoid_reset_quirk is changed

[Lan Tianyu]

于 2012/7/24 16:57, Oliver Neukum 写道:
On Tuesday 24 July 2012 16:39:37 Lan Tianyu wrote:
The quirk USB_QUIRK_RESET_MORPHS means the device can't be reset
and reset-resume. So persist_enabled also should be set simultaneously

Set? Why bother? If anything reset_resume() is hopeless, so why
delay the resume by trying?
hi Oliver:

	Maybe my change log confuse you.I mean the persist_enabled should be 
changed when USB_QUIRK_RESET_MORPHS is changed, right?

When USB_QUIRK_RESET_MORPHS is set, persist_enabled should be set to 0 
to prevent reset-resume() when the device resumes.

Current only in the usb_detect_quirks(),  persist_enabled will
be set to 0 depending on whether the dev's flag USB_QUIRK_RESET_MORPHS 
is set or not. And usb_detect_quirks() is only called in the 
hub_port_connect_change() when a new device is found.

So after a device being enumerated, Changing attribute avod_reset_quirk 
will not set persist_enabled to 0 to prevent reset-resume.

If something wrong, please help me to correct. Thanks.



        Regards
                Oliver

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html