Re: [PATCH v2 05/22] doc: dt-binding: usb: add otg related properties

2015-06-15 Thread Li Jun
On Mon, Jun 15, 2015 at 03:25:48PM +0300, Sergei Shtylyov wrote: > Hello. > > On 6/15/2015 10:41 AM, Li Jun wrote: > > [...] > > >Regarding use of "xyz-disable" flags: > >After more thinking this, I just realize that we can use "otg-rev" property > >to handle the case of none of xyz-disable prop

Re: [PATCH v2 05/22] doc: dt-binding: usb: add otg related properties

2015-06-15 Thread Sergei Shtylyov
Hello. On 6/15/2015 10:41 AM, Li Jun wrote: [...] Regarding use of "xyz-disable" flags: After more thinking this, I just realize that we can use "otg-rev" property to handle the case of none of xyz-disable properties passed, for legacy platforms, the new "otg-rev" not passed either, so it's a

Re: [PATCH v2 05/22] doc: dt-binding: usb: add otg related properties

2015-06-15 Thread Roger Quadros
On Mon, 15 Jun 2015 15:41:02 +0800 Li Jun wrote: > On Fri, Jun 12, 2015 at 11:31:02AM +0300, Roger Quadros wrote: > > > > > > > > Agreed. We still need to determine legacy platform if > > none of the features are set. > > > > How about defining the followong enum for gadget->xyz_support > >

Re: [PATCH v2 05/22] doc: dt-binding: usb: add otg related properties

2015-06-15 Thread Roger Quadros
On Mon, 15 Jun 2015 14:32:46 +0800 Li Jun wrote: > On Fri, Jun 12, 2015 at 11:31:02AM +0300, Roger Quadros wrote: > > > > > > On Fri, 12 Jun 2015 11:09:17 +0800 > > Li Jun wrote: > > > [...] > > > > Other than those new flags, I have not found other good way to judge > > > whether some platf

Re: [PATCH v2 05/22] doc: dt-binding: usb: add otg related properties

2015-06-15 Thread Li Jun
On Fri, Jun 12, 2015 at 11:31:02AM +0300, Roger Quadros wrote: > > > > Agreed. We still need to determine legacy platform if > none of the features are set. > > How about defining the followong enum for gadget->xyz_support > > enum otg_feature { > OTG_FEATURE_UNDEFINED = 0, > OTG_F

Re: [PATCH v2 05/22] doc: dt-binding: usb: add otg related properties

2015-06-14 Thread Li Jun
On Fri, Jun 12, 2015 at 11:31:02AM +0300, Roger Quadros wrote: > > > On Fri, 12 Jun 2015 11:09:17 +0800 > Li Jun wrote: > [...] > > Other than those new flags, I have not found other good way to judge > > whether some platform is a legacy one. > > Directly use dt property? Then above code has

Re: [PATCH v2 05/22] doc: dt-binding: usb: add otg related properties

2015-06-12 Thread Li Jun
On Fri, Jun 12, 2015 at 11:41:40AM +0300, Roger Quadros wrote: > > > On Fri, 12 Jun 2015 16:23:59 +0800 > Li Jun wrote: > > > On Fri, Jun 12, 2015 at 11:02:13AM +0300, Roger Quadros wrote: > > > > > > On Fri, 12 Jun 2015 09:42:04 +0800 > > > Li Jun wrote: > > > > > > > On Thu, Jun 11, 2015 a

Re: [PATCH v2 05/22] doc: dt-binding: usb: add otg related properties

2015-06-12 Thread Roger Quadros
On Fri, 12 Jun 2015 16:23:59 +0800 Li Jun wrote: > On Fri, Jun 12, 2015 at 11:02:13AM +0300, Roger Quadros wrote: > > > > On Fri, 12 Jun 2015 09:42:04 +0800 > > Li Jun wrote: > > > > > On Thu, Jun 11, 2015 at 05:55:57PM +0300, Roger Quadros wrote: > > > > > > drivers/usb/core/hub.c > > > > >

Re: [PATCH v2 05/22] doc: dt-binding: usb: add otg related properties

2015-06-12 Thread Roger Quadros
On Fri, 12 Jun 2015 16:23:59 +0800 Li Jun wrote: > On Fri, Jun 12, 2015 at 11:02:13AM +0300, Roger Quadros wrote: > > > > On Fri, 12 Jun 2015 09:42:04 +0800 > > Li Jun wrote: > > > > > On Thu, Jun 11, 2015 at 05:55:57PM +0300, Roger Quadros wrote: > > > > > > drivers/usb/core/hub.c > > > > >

Re: [PATCH v2 05/22] doc: dt-binding: usb: add otg related properties

2015-06-12 Thread Roger Quadros
On Fri, 12 Jun 2015 11:09:17 +0800 Li Jun wrote: > On Thu, Jun 11, 2015 at 05:52:15PM +0300, Roger Quadros wrote: > > > > On Thu, 11 Jun 2015 22:11:22 +0800 > > Li Jun wrote: > > > > > On Thu, Jun 11, 2015 at 03:37:03PM +0300, Roger Quadros wrote: > > > > > > > > On Thu, 11 Jun 2015 16:20:1

Re: [PATCH v2 05/22] doc: dt-binding: usb: add otg related properties

2015-06-12 Thread Li Jun
On Fri, Jun 12, 2015 at 11:02:13AM +0300, Roger Quadros wrote: > > On Fri, 12 Jun 2015 09:42:04 +0800 > Li Jun wrote: > > > On Thu, Jun 11, 2015 at 05:55:57PM +0300, Roger Quadros wrote: > > > > > drivers/usb/core/hub.c > > > > > > > > > > static int usb_enumerate_device_otg(struct usb_device *

Re: [PATCH v2 05/22] doc: dt-binding: usb: add otg related properties

2015-06-12 Thread Roger Quadros
On Fri, 12 Jun 2015 09:42:04 +0800 Li Jun wrote: > On Thu, Jun 11, 2015 at 05:55:57PM +0300, Roger Quadros wrote: > > > > drivers/usb/core/hub.c > > > > > > > > static int usb_enumerate_device_otg(struct usb_device *udev) > > > > { > > > > int err = 0; > > > > > > > > #ifdef CONFIG_US

Re: [PATCH v2 05/22] doc: dt-binding: usb: add otg related properties

2015-06-11 Thread Li Jun
On Thu, Jun 11, 2015 at 05:52:15PM +0300, Roger Quadros wrote: > > On Thu, 11 Jun 2015 22:11:22 +0800 > Li Jun wrote: > > > On Thu, Jun 11, 2015 at 03:37:03PM +0300, Roger Quadros wrote: > > > > > > On Thu, 11 Jun 2015 16:20:13 +0800 > > > Li Jun wrote: > > > > > > > On Thu, Jun 11, 2015 at 1

Re: [PATCH v2 05/22] doc: dt-binding: usb: add otg related properties

2015-06-11 Thread Peter Chen
On Tue, Jun 09, 2015 at 06:29:31PM +0300, Roger Quadros wrote: > Rob, > > On Tue, 9 Jun 2015 08:26:20 -0500 > Rob Herring wrote: > > > On Mon, Jun 8, 2015 at 8:18 PM, Li Jun wrote: > > > On Mon, Jun 08, 2015 at 11:06:49AM -0500, Rob Herring wrote: > > >> On Mon, Jun 8, 2015 at 10:02 AM, Li Jun

Re: [PATCH v2 05/22] doc: dt-binding: usb: add otg related properties

2015-06-11 Thread Li Jun
On Thu, Jun 11, 2015 at 05:55:57PM +0300, Roger Quadros wrote: > > > drivers/usb/core/hub.c > > > > > > static int usb_enumerate_device_otg(struct usb_device *udev) > > > { > > > int err = 0; > > > > > > #ifdefCONFIG_USB_OTG > > > /* > > >* OTG-aware devices on OTG-capable root hubs m

Re: [PATCH v2 05/22] doc: dt-binding: usb: add otg related properties

2015-06-11 Thread Roger Quadros
On Thu, 11 Jun 2015 22:22:09 +0800 Li Jun wrote: > On Thu, Jun 11, 2015 at 03:51:02PM +0300, Roger Quadros wrote: > > > > On Thu, 11 Jun 2015 16:38:52 +0800 > > Li Jun wrote: > > > > > On Thu, Jun 11, 2015 at 10:30:35AM +0300, Roger Quadros wrote: > > > > > > > > On Wed, 10 Jun 2015 20:06:25

Re: [PATCH v2 05/22] doc: dt-binding: usb: add otg related properties

2015-06-11 Thread Roger Quadros
On Thu, 11 Jun 2015 22:11:22 +0800 Li Jun wrote: > On Thu, Jun 11, 2015 at 03:37:03PM +0300, Roger Quadros wrote: > > > > On Thu, 11 Jun 2015 16:20:13 +0800 > > Li Jun wrote: > > > > > On Thu, Jun 11, 2015 at 10:18:53AM +0300, Roger Quadros wrote: > > > > > > > > On Wed, 10 Jun 2015 21:47:51

Re: [PATCH v2 05/22] doc: dt-binding: usb: add otg related properties

2015-06-11 Thread Li Jun
On Thu, Jun 11, 2015 at 03:51:02PM +0300, Roger Quadros wrote: > > On Thu, 11 Jun 2015 16:38:52 +0800 > Li Jun wrote: > > > On Thu, Jun 11, 2015 at 10:30:35AM +0300, Roger Quadros wrote: > > > > > > On Wed, 10 Jun 2015 20:06:25 +0800 > > > Li Jun wrote: > > > > > > > On Tue, Jun 09, 2015 at 1

Re: [PATCH v2 05/22] doc: dt-binding: usb: add otg related properties

2015-06-11 Thread Li Jun
On Thu, Jun 11, 2015 at 03:37:03PM +0300, Roger Quadros wrote: > > On Thu, 11 Jun 2015 16:20:13 +0800 > Li Jun wrote: > > > On Thu, Jun 11, 2015 at 10:18:53AM +0300, Roger Quadros wrote: > > > > > > On Wed, 10 Jun 2015 21:47:51 +0800 > > > Li Jun wrote: > > > > > > > On Wed, Jun 10, 2015 at 0

Re: [PATCH v2 05/22] doc: dt-binding: usb: add otg related properties

2015-06-11 Thread Roger Quadros
On Thu, 11 Jun 2015 16:38:52 +0800 Li Jun wrote: > On Thu, Jun 11, 2015 at 10:30:35AM +0300, Roger Quadros wrote: > > > > On Wed, 10 Jun 2015 20:06:25 +0800 > > Li Jun wrote: > > > > > On Tue, Jun 09, 2015 at 11:29:31PM +0800, Roger Quadros wrote: > > > > Rob, > > > > > > > > On Tue, 9 Jun 2

Re: [PATCH v2 05/22] doc: dt-binding: usb: add otg related properties

2015-06-11 Thread Roger Quadros
On Thu, 11 Jun 2015 16:20:13 +0800 Li Jun wrote: > On Thu, Jun 11, 2015 at 10:18:53AM +0300, Roger Quadros wrote: > > > > On Wed, 10 Jun 2015 21:47:51 +0800 > > Li Jun wrote: > > > > > On Wed, Jun 10, 2015 at 03:37:37PM +0800, Roger Quadros wrote: > > > > On Tue, 9 Jun 2015 11:33:11 -0500 > >

Re: [PATCH v2 05/22] doc: dt-binding: usb: add otg related properties

2015-06-11 Thread Li Jun
On Thu, Jun 11, 2015 at 10:30:35AM +0300, Roger Quadros wrote: > > On Wed, 10 Jun 2015 20:06:25 +0800 > Li Jun wrote: > > > On Tue, Jun 09, 2015 at 11:29:31PM +0800, Roger Quadros wrote: > > > Rob, > > > > > > On Tue, 9 Jun 2015 08:26:20 -0500 > > > Rob Herring wrote: > > > > > > > On Mon, Ju

Re: [PATCH v2 05/22] doc: dt-binding: usb: add otg related properties

2015-06-11 Thread Li Jun
On Thu, Jun 11, 2015 at 10:18:53AM +0300, Roger Quadros wrote: > > On Wed, 10 Jun 2015 21:47:51 +0800 > Li Jun wrote: > > > On Wed, Jun 10, 2015 at 03:37:37PM +0800, Roger Quadros wrote: > > > On Tue, 9 Jun 2015 11:33:11 -0500 > > > Rob Herring wrote: > > > > > > > On Tue, Jun 9, 2015 at 10:29

Re: [PATCH v2 05/22] doc: dt-binding: usb: add otg related properties

2015-06-11 Thread Roger Quadros
On Wed, 10 Jun 2015 20:06:25 +0800 Li Jun wrote: > On Tue, Jun 09, 2015 at 11:29:31PM +0800, Roger Quadros wrote: > > Rob, > > > > On Tue, 9 Jun 2015 08:26:20 -0500 > > Rob Herring wrote: > > > > > On Mon, Jun 8, 2015 at 8:18 PM, Li Jun wrote: > > > > On Mon, Jun 08, 2015 at 11:06:49AM -0500

Re: [PATCH v2 05/22] doc: dt-binding: usb: add otg related properties

2015-06-11 Thread Roger Quadros
On Wed, 10 Jun 2015 21:47:51 +0800 Li Jun wrote: > On Wed, Jun 10, 2015 at 03:37:37PM +0800, Roger Quadros wrote: > > On Tue, 9 Jun 2015 11:33:11 -0500 > > Rob Herring wrote: > > > > > On Tue, Jun 9, 2015 at 10:29 AM, Roger Quadros wrote: > > > > Rob, > > > > > > > > On Tue, 9 Jun 2015 08:26:

Re: [PATCH v2 05/22] doc: dt-binding: usb: add otg related properties

2015-06-10 Thread Li Jun
On Wed, Jun 10, 2015 at 03:37:37PM +0800, Roger Quadros wrote: > On Tue, 9 Jun 2015 11:33:11 -0500 > Rob Herring wrote: > > > On Tue, Jun 9, 2015 at 10:29 AM, Roger Quadros wrote: > > > Rob, > > > > > > On Tue, 9 Jun 2015 08:26:20 -0500 > > > Rob Herring wrote: > > > > > >> On Mon, Jun 8, 2015

Re: [PATCH v2 05/22] doc: dt-binding: usb: add otg related properties

2015-06-10 Thread Li Jun
On Tue, Jun 09, 2015 at 11:29:31PM +0800, Roger Quadros wrote: > Rob, > > On Tue, 9 Jun 2015 08:26:20 -0500 > Rob Herring wrote: > > > On Mon, Jun 8, 2015 at 8:18 PM, Li Jun wrote: > > > On Mon, Jun 08, 2015 at 11:06:49AM -0500, Rob Herring wrote: > > >> On Mon, Jun 8, 2015 at 10:02 AM, Li Jun

Re: [PATCH v2 05/22] doc: dt-binding: usb: add otg related properties

2015-06-10 Thread Li Jun
On Tue, Jun 09, 2015 at 09:26:20PM +0800, Rob Herring wrote: > On Mon, Jun 8, 2015 at 8:18 PM, Li Jun wrote: > > On Mon, Jun 08, 2015 at 11:06:49AM -0500, Rob Herring wrote: > >> On Mon, Jun 8, 2015 at 10:02 AM, Li Jun wrote: > >> > Add otg version, srp, hnp and adp support for usb OTG port, then

Re: [PATCH v2 05/22] doc: dt-binding: usb: add otg related properties

2015-06-10 Thread Roger Quadros
On Tue, 9 Jun 2015 11:33:11 -0500 Rob Herring wrote: > On Tue, Jun 9, 2015 at 10:29 AM, Roger Quadros wrote: > > Rob, > > > > On Tue, 9 Jun 2015 08:26:20 -0500 > > Rob Herring wrote: > > > >> On Mon, Jun 8, 2015 at 8:18 PM, Li Jun wrote: > >> > On Mon, Jun 08, 2015 at 11:06:49AM -0500, Rob Her

Re: [PATCH v2 05/22] doc: dt-binding: usb: add otg related properties

2015-06-09 Thread Rob Herring
On Tue, Jun 9, 2015 at 10:29 AM, Roger Quadros wrote: > Rob, > > On Tue, 9 Jun 2015 08:26:20 -0500 > Rob Herring wrote: > >> On Mon, Jun 8, 2015 at 8:18 PM, Li Jun wrote: >> > On Mon, Jun 08, 2015 at 11:06:49AM -0500, Rob Herring wrote: >> >> On Mon, Jun 8, 2015 at 10:02 AM, Li Jun wrote: >> >>

Re: [PATCH v2 05/22] doc: dt-binding: usb: add otg related properties

2015-06-09 Thread Roger Quadros
Rob, On Tue, 9 Jun 2015 08:26:20 -0500 Rob Herring wrote: > On Mon, Jun 8, 2015 at 8:18 PM, Li Jun wrote: > > On Mon, Jun 08, 2015 at 11:06:49AM -0500, Rob Herring wrote: > >> On Mon, Jun 8, 2015 at 10:02 AM, Li Jun wrote: > >> > Add otg version, srp, hnp and adp support for usb OTG port, then

Re: [PATCH v2 05/22] doc: dt-binding: usb: add otg related properties

2015-06-09 Thread Rob Herring
On Mon, Jun 8, 2015 at 8:18 PM, Li Jun wrote: > On Mon, Jun 08, 2015 at 11:06:49AM -0500, Rob Herring wrote: >> On Mon, Jun 8, 2015 at 10:02 AM, Li Jun wrote: >> > Add otg version, srp, hnp and adp support for usb OTG port, then those OTG >> > features don't have to be decided by usb gadget drive

Re: [PATCH v2 05/22] doc: dt-binding: usb: add otg related properties

2015-06-09 Thread Roger Quadros
On Mon, 8 Jun 2015 23:02:00 +0800 Li Jun wrote: > Add otg version, srp, hnp and adp support for usb OTG port, then those OTG > features don't have to be decided by usb gadget drivers. > > Signed-off-by: Li Jun > --- > Documentation/devicetree/bindings/usb/generic.txt | 10 ++ > 1 file

Re: [PATCH v2 05/22] doc: dt-binding: usb: add otg related properties

2015-06-08 Thread Li Jun
On Mon, Jun 08, 2015 at 11:06:49AM -0500, Rob Herring wrote: > On Mon, Jun 8, 2015 at 10:02 AM, Li Jun wrote: > > Add otg version, srp, hnp and adp support for usb OTG port, then those OTG > > features don't have to be decided by usb gadget drivers. > > > > Signed-off-by: Li Jun > > --- > > Docu

Re: [PATCH v2 05/22] doc: dt-binding: usb: add otg related properties

2015-06-08 Thread Rob Herring
On Mon, Jun 8, 2015 at 10:02 AM, Li Jun wrote: > Add otg version, srp, hnp and adp support for usb OTG port, then those OTG > features don't have to be decided by usb gadget drivers. > > Signed-off-by: Li Jun > --- > Documentation/devicetree/bindings/usb/generic.txt | 10 ++ > 1 file cha

[PATCH v2 05/22] doc: dt-binding: usb: add otg related properties

2015-06-08 Thread Li Jun
Add otg version, srp, hnp and adp support for usb OTG port, then those OTG features don't have to be decided by usb gadget drivers. Signed-off-by: Li Jun --- Documentation/devicetree/bindings/usb/generic.txt | 10 ++ 1 file changed, 10 insertions(+) diff --git a/Documentation/devicetree