On Fri, 2019-09-06 at 09:59 +0200, Bjørn Mork wrote:
> writes:
>
> > + if (strstr(dev->udev->product, "D6000")) {
>
> Huh? Can you please test that on all USB devices ever made?
Yeah. Can't VID/PID be used as the filter here instead?
Dan
+ if (strstr(dev->udev->product, "D6000")) {
+ sa.sa_family = dev->net->type;
+ if (get_acpi_mac_passthru(sa.sa_data)) {
+ if (!memcmp(dev->net->dev_addr, sa.sa_data,
+ ETH_ALEN)) {
+ if (!cdc_ncm_set_ethernet_address(dev, &sa))
How about use one if-statement instead of these three if-state
writes:
> + if (strstr(dev->udev->product, "D6000")) {
Huh? Can you please test that on all USB devices ever made?
Bjørn
On Thu, 2019-09-05 at 21:01 +, charles.h...@dellteam.com wrote:
> This change adds support to cdc_ncm for ACPI MAC address pass through
> functionality that also exists in the Realtek r8152 driver. This is in
> support of Dell's Universal Dock D6000, to give it the same feature
> capability as
This change adds support to cdc_ncm for ACPI MAC address pass through
functionality that also exists in the Realtek r8152 driver. This is in
support of Dell's Universal Dock D6000, to give it the same feature
capability as is currently available in Windows and advertized on Dell's
product web site
Subject: RE: [PATCH 3/3] net: cdc_ncm: Add ACPI MAC address pass through
> functionality
>
> > > This change adds support to cdc_ncm for ACPI MAC address pass through
> > > functionality that also exists in the Realtek r8152 driver. This is
> > > in support of
> > This change adds support to cdc_ncm for ACPI MAC address pass through
> > functionality that also exists in the Realtek r8152 driver. This is
> > in support of Dell's Universal Dock D6000, to give it the same feature
> > capability as is currently available in Windows and advertized on
> > Del
Am Freitag, den 30.08.2019, 19:38 + schrieb
charles.h...@dellteam.com:
> This change adds support to cdc_ncm for ACPI MAC address pass through
> functionality that also exists in the Realtek r8152 driver. This is in
> support of Dell's Universal Dock D6000, to give it the same feature
> capabi
This change adds support to cdc_ncm for ACPI MAC address pass through
functionality that also exists in the Realtek r8152 driver. This is in
support of Dell's Universal Dock D6000, to give it the same feature
capability as is currently available in Windows and advertized on Dell's
product web site
