Re: depmod warning: unknown symbol usb_stor_sense_invalidCDB in 5.4-rc1

2019-10-01 Thread Matthias Maennich
ce") makes the problem go away. Would be if someone can take care of it. Hi Stefan! Thanks for reporting this. I will take care of it! Cheers, Matthias

Re: [PATCH V3 3/3] arm64: dts: sdm845: Add interconnect properties for USB

2019-09-17 Thread Matthias Kaehlcke
dwc3: dwc3@a80 { > compatible = "snps,dwc3"; > reg = <0 0x0a80 0 0xcd00>; Please collect tags from earlier versions, unless the new version has 'major' changes (which is a bit of a judgement call). Reviewed-by: Matthias Kaehlcke

Re: [PATCH V3 2/3] usb: dwc3: qcom: Add interconnect support in dwc3 driver

2019-09-17 Thread Matthias Kaehlcke
On Tue, Sep 17, 2019 at 04:40:48PM +0530, Chandana Kishori Chiluveru wrote: > Add interconnect support in dwc3-qcom driver to vote for bus > bandwidth. > > This requires for two different paths - from USB master to > DDR slave. The other is from APPS master to USB slave. > > Signed-off-by: Chanda

Re: [PATCH V3 1/3] dt-bindings: Introduce interconnect properties for Qualcomm DWC3 driver

2019-09-17 Thread Matthias Kaehlcke
b-ddr", "apps-usb"; > interrupts = <0 131 0>, <0 486 0>, <0 488 0>, <0 489 0>; > interrupt-names = "hs_phy_irq", "ss_phy_irq", > "dm_hs_phy_irq", "dp_hs_phy_irq"; Reviewed-by: Matthias Kaehlcke

Re: [PATCH V2 2/3] usb: dwc3: qcom: Add interconnect support in dwc3 driver

2019-09-17 Thread Matthias Kaehlcke
Hi Chandana, On Tue, Sep 17, 2019 at 04:39:20PM +0530, cchil...@codeaurora.org wrote: > Hi Matthias, > > Thanks for the review. I Will address below comments and post changes in new > version. > > On 2019-09-17 03:54, Matthias Kaehlcke wrote: > > Hi Chandana, > >

Re: [PATCH V2 3/3] arm64: dts: sdm845: Add interconnect properties for USB

2019-09-16 Thread Matthias Kaehlcke
MASTER_USB3_1 > + &rsc_hlos SLAVE_EBI1>, > + <&rsc_hlos MASTER_APPSS_PROC > + &rsc_hlos SLAVE_USB3_1>; > + interconnect-names = "usb-ddr", "apps-usb"; > + > usb_2_dwc3: dwc3@a80 { > compatible = "snps,dwc3"; > reg = <0 0x0a80 0 0xcd00>; Besides the nits: Reviewed-by: Matthias Kaehlcke

Re: [PATCH V2 2/3] usb: dwc3: qcom: Add interconnect support in dwc3 driver

2019-09-16 Thread Matthias Kaehlcke
n, but didn't have a good suggestion for an alternative name. Moving the _enable() call into _init() would make _init() and actual init routine, besides removing clutter from _probe(). > + goto interconnect_exit; > + } > + > qcom->mode = usb_get_dr_mode(&qcom->dwc3->dev); > > /* enable vbus override for device mode */ > @@ -503,7 +641,7 @@ static int dwc3_qcom_probe(struct platform_device *pdev) > /* register extcon to override sw_vbus on Vbus change later */ > ret = dwc3_qcom_register_extcon(qcom); > if (ret) > - goto depopulate; > + goto interconnect_exit; > > device_init_wakeup(&pdev->dev, 1); > qcom->is_suspended = false; > @@ -513,6 +651,8 @@ static int dwc3_qcom_probe(struct platform_device *pdev) > > return 0; > > +interconnect_exit: > + usb_interconnect_exit(qcom); > depopulate: > of_platform_depopulate(&pdev->dev); > clk_disable: > @@ -540,6 +680,7 @@ static int dwc3_qcom_remove(struct platform_device *pdev) > } > qcom->num_clocks = 0; > > + usb_interconnect_exit(qcom); > reset_control_assert(qcom->resets); > > pm_runtime_allow(dev); Cheers Matthias

Re: [PATCH 1/3] dt-bindings: Introduce interconnect bindings for usb

2019-09-16 Thread Matthias Kaehlcke
On Wed, Sep 11, 2019 at 10:24:33AM +0530, Chandana Kishori Chiluveru wrote: > Add documentation for the interconnects and interconnect-names > bindings for USB as detailed by bindings/interconnect/interconnect.txt. This isn't a generic binding for USB, but for the qcom,dwc3, the commit message (in

Re: [PATCH v3 06/11] export: allow definition default namespaces in Makefiles or sources

2019-08-28 Thread Matthias Maennich
On Wed, Aug 28, 2019 at 12:49:51PM +0200, Jessica Yu wrote: +++ Matthias Maennich [21/08/19 12:49 +0100]: To avoid excessive usage of EXPORT_SYMBOL_NS(sym, MY_NAMESPACE), where MY_NAMESPACE will always be the namespace we are exporting to, allow exporting all definitions of EXPORT_SYMBOL() and

Re: [PATCH v3 03/11] module: add support for symbol namespaces.

2019-08-27 Thread Matthias Maennich
On Tue, Aug 27, 2019 at 05:37:18PM +0200, Jessica Yu wrote: +++ Matthias Maennich [21/08/19 12:49 +0100]: The EXPORT_SYMBOL_NS() and EXPORT_SYMBOL_NS_GPL() macros can be used to export a symbol to a specific namespace. There are no _GPL_FUTURE and _UNUSED variants because these are currently

Re: [PATCH v3 04/11] modpost: add support for symbol namespaces

2019-08-27 Thread Matthias Maennich
On Mon, Aug 26, 2019 at 06:21:38PM +0200, Jessica Yu wrote: +++ Matthias Maennich [21/08/19 12:49 +0100]: Add support for symbols that are exported into namespaces. For that, extract any namespace suffix from the symbol name. In addition, emit a warning whenever a module refers to an exported

Re: [RESEND PATCH v2 2/2] usb: xhci-mtk: add an optional xhci_ck clock

2019-08-23 Thread Matthias Brugger
On 23/08/2019 08:40, Chunfeng Yun wrote: > Some SoCs may have an optional clock xhci_ck (125M or 200M), it > usually uses the same PLL as sys_ck, so support it. > > Signed-off-by: Chunfeng Yun Reviewed-by: Matthias Brugger > --- > v2 no changes > --- > drivers/

Re: [v2 08/10] scripts: Coccinelle script for namespace dependencies

2019-08-22 Thread Matthias Maennich
of a temporary file next to the original source file and the reader of the code does not need to reason about the value of ${source_file_tmp}. Cheers, Matthias

Re: [PATCH v3 10/11] RFC: usb-storage: export symbols in USB_STORAGE namespace

2019-08-22 Thread Matthias Maennich
On Wed, Aug 21, 2019 at 04:13:29PM -0700, Christoph Hellwig wrote: On Wed, Aug 21, 2019 at 12:49:25PM +0100, Matthias Maennich wrote: Modules using these symbols are required to explicitly import the namespace. This patch was generated with the following steps and serves as a reference to use

[PATCH v3 07/11] modpost: add support for generating namespace dependencies

2019-08-21 Thread Matthias Maennich
g Kroah-Hartman Signed-off-by: Matthias Maennich --- .gitignore| 1 + Makefile | 2 +- scripts/mod/modpost.c | 54 +++ scripts/mod/modpost.h | 2 ++ 4 files changed, 53 insertions(+), 6 deletions(-) diff --git a/.gitignore b/.

[PATCH v3 09/11] usb-storage: remove single-use define for debugging

2019-08-21 Thread Matthias Maennich
USB_STORAGE was defined as "usb-storage: " and used in a single location as argument to printk. In order to be able to use the name 'USB_STORAGE', drop the definition and use the string directly for the printk call. Signed-off-by: Matthias Maennich --- drivers/usb/st

[PATCH v3 10/11] RFC: usb-storage: export symbols in USB_STORAGE namespace

2019-08-21 Thread Matthias Maennich
touching their respective EXPORT_SYMBOL macro expansion. Signed-off-by: Matthias Maennich --- drivers/usb/storage/Makefile| 2 ++ drivers/usb/storage/alauda.c| 1 + drivers/usb/storage/cypress_atacb.c | 1 + drivers/usb/storage/datafab.c | 1 + drivers/usb/storage/ene_ub6250

[PATCH v3 08/11] scripts: Coccinelle script for namespace dependencies.

2019-08-21 Thread Matthias Maennich
eloped-by: Martijn Coenen Signed-off-by: Martijn Coenen Acked-by: Julia Lawall Reviewed-by: Greg Kroah-Hartman Signed-off-by: Matthias Maennich --- MAINTAINERS | 5 ++ Makefile| 12 + scripts/Makefile.modpost

[PATCH v3 02/11] export: explicitly align struct kernel_symbol

2019-08-21 Thread Matthias Maennich
ected, the section contents didn't change, and the ELF section alignment only changed on x86_64 and m68k. Feedback from other archs more than welcome. Co-developed-by: Martijn Coenen Signed-off-by: Martijn Coenen Reviewed-by: Greg Kroah-Hartman Signed-off-by: Matthias Maennich --- arch/m

[PATCH v3 01/11] module: support reading multiple values per modinfo tag

2019-08-21 Thread Matthias Maennich
t of the symbol namespaces patch series to read the (potentially) multiple namespaces a module is importing. Reviewed-by: Joel Fernandes (Google) Reviewed-by: Martijn Coenen Reviewed-by: Greg Kroah-Hartman Signed-off-by: Matthias Maennich --- kernel/module.c | 17 +++-- 1 f

[PATCH v3 06/11] export: allow definition default namespaces in Makefiles or sources

2019-08-21 Thread Matthias Maennich
-by: Greg Kroah-Hartman Signed-off-by: Matthias Maennich --- include/linux/export.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/include/linux/export.h b/include/linux/export.h index 8e12e05444d1..1fb243abdbc4 100644 --- a/include/linux/export.h +++ b/include/linux/export.h @@ -166,6

[PATCH v3 04/11] modpost: add support for symbol namespaces

2019-08-21 Thread Matthias Maennich
Reviewed-by: Joel Fernandes (Google) Reviewed-by: Greg Kroah-Hartman Signed-off-by: Matthias Maennich --- scripts/mod/modpost.c | 91 +-- scripts/mod/modpost.h | 7 2 files changed, 87 insertions(+), 11 deletions(-) diff --git a/scripts/mod

[PATCH v3 03/11] module: add support for symbol namespaces.

2019-08-21 Thread Matthias Maennich
mbols in their own section and use a separate 'struct namespaced_kernel_symbol' for that section, at the cost of making the module loader more complex. Co-developed-by: Martijn Coenen Signed-off-by: Martijn Coenen Reviewed-by: Greg Kroah-Hartman Signed-off-by: Matthias Maennich --- includ

[PATCH v3 05/11] module: add config option MODULE_ALLOW_MISSING_NAMESPACE_IMPORTS

2019-08-21 Thread Matthias Maennich
enforcement at module loading time and loading is denied if the module's imports are not satisfactory. Reviewed-by: Martijn Coenen Reviewed-by: Greg Kroah-Hartman Signed-off-by: Matthias Maennich --- init/Kconfig| 13 + kernel/module.c | 11 +-- 2 files change

Re: [PATCH v2 05/10] module: add config option MODULE_ALLOW_MISSING_NAMESPACE_IMPORTS

2019-08-14 Thread Matthias Maennich
On Tue, Aug 13, 2019 at 01:15:44PM -0700, Saravana Kannan wrote: On Tue, Aug 13, 2019 at 5:19 AM 'Matthias Maennich' via kernel-team wrote: If MODULE_ALLOW_MISSING_NAMESPACE_IMPORTS is enabled (default=n), the requirement for modules to import all namespaces that are used by the

Re: [Cocci] [PATCH v2 08/10] scripts: Coccinelle script for namespace dependencies.

2019-08-14 Thread Matthias Maennich
On Wed, Aug 14, 2019 at 12:06:11PM +0530, Himanshu Jha wrote: On Tue, Aug 13, 2019 at 01:17:05PM +0100, Matthias Maennich wrote: A script that uses the '.ns_deps' file generated by modpost to automatically add the required symbol namespace dependencies to each module. Usage: 1)

Re: [PATCH v2 10/10] RFC: usb-storage: export symbols in USB_STORAGE namespace

2019-08-13 Thread Matthias Maennich
On Tue, Aug 13, 2019 at 02:47:08PM +0200, Greg KH wrote: On Tue, Aug 13, 2019 at 01:17:07PM +0100, Matthias Maennich wrote: Modules using these symbols are required to explicitly import the namespace. This patch was generated with the following steps and serves as a reference to use the symbol

[PATCH v2 10/10] RFC: usb-storage: export symbols in USB_STORAGE namespace

2019-08-13 Thread Matthias Maennich
touching their respective EXPORT_SYMBOL macro expansion. Signed-off-by: Matthias Maennich --- drivers/usb/storage/Makefile| 2 ++ drivers/usb/storage/alauda.c| 1 + drivers/usb/storage/cypress_atacb.c | 1 + drivers/usb/storage/datafab.c | 1 + drivers/usb/storage/ene_ub6250

[PATCH v2 08/10] scripts: Coccinelle script for namespace dependencies.

2019-08-13 Thread Matthias Maennich
eloped-by: Martijn Coenen Signed-off-by: Martijn Coenen Signed-off-by: Matthias Maennich --- MAINTAINERS | 5 ++ Makefile| 12 + scripts/Makefile.modpost| 4 +- scripts/coccinelle/misc/add_namesp

[PATCH v2 09/10] usb-storage: remove single-use define for debugging

2019-08-13 Thread Matthias Maennich
USB_STORAGE was defined as "usb-storage: " and used in a single location as argument to printk. In order to be able to use the name 'USB_STORAGE', drop the definition and use the string directly for the printk call. Signed-off-by: Matthias Maennich --- drivers/usb/st

[PATCH v2 0/10] Symbol namespaces - RFC

2019-08-13 Thread Matthias Maennich
been simplified by using DEFAULT_SYMBOL_NAMESPACE=USB_STORAGE rather than explicitly exporting each and every symbol into that new namespace. This patch series was developed against v5.3-rc4. [1] git grep "^EXPORT_SYMBOL\w*(" v5.3-rc4 | wc -l [2] git grep "^EXPORT_SYMBOL\w*(" v4.17

[PATCH v2 07/10] modpost: add support for generating namespace dependencies

2019-08-13 Thread Matthias Maennich
'nsdeps' and a corresponding make target to automatically add missing MODULE_IMPORT_NS() definitions to the module's sources. For that it uses the information provided in the generated .ns_deps files. Co-developed-by: Martijn Coenen Signed-off-by: Martijn Coenen Signed-off-by: Ma

[PATCH v2 04/10] modpost: add support for symbol namespaces

2019-08-13 Thread Matthias Maennich
Reviewed-by: Joel Fernandes (Google) Signed-off-by: Matthias Maennich --- scripts/mod/modpost.c | 91 +-- scripts/mod/modpost.h | 7 2 files changed, 87 insertions(+), 11 deletions(-) diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c index

[PATCH v2 06/10] export: allow definition default namespaces in Makefiles or sources

2019-08-13 Thread Matthias Maennich
-by: Matthias Maennich --- include/linux/export.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/include/linux/export.h b/include/linux/export.h index 8e12e05444d1..1fb243abdbc4 100644 --- a/include/linux/export.h +++ b/include/linux/export.h @@ -166,6 +166,12 @@ struct kernel_symbol

[PATCH v2 05/10] module: add config option MODULE_ALLOW_MISSING_NAMESPACE_IMPORTS

2019-08-13 Thread Matthias Maennich
enforcement at module loading time and loading is denied if the module's imports are not satisfactory. Reviewed-by: Martijn Coenen Signed-off-by: Matthias Maennich --- init/Kconfig| 14 ++ kernel/module.c | 11 +-- 2 files changed, 23 insertions(+), 2 deletions(-)

[PATCH v2 02/10] export: explicitly align struct kernel_symbol

2019-08-13 Thread Matthias Maennich
ected, the section contents didn't change, and the ELF section alignment only changed on x86_64 and m68k. Feedback from other archs more than welcome. Co-developed-by: Martijn Coenen Signed-off-by: Martijn Coenen Signed-off-by: Matthias Maennich --- arch/m68k/include/asm/export.h | 1 - incl

[PATCH v2 03/10] module: add support for symbol namespaces.

2019-08-13 Thread Matthias Maennich
mbols in their own section and use a separate 'struct namespaced_kernel_symbol' for that section, at the cost of making the module loader more complex. Co-developed-by: Martijn Coenen Signed-off-by: Martijn Coenen Signed-off-by: Matthias Maennich --- include/asm-gener

[PATCH v2 01/10] module: support reading multiple values per modinfo tag

2019-08-13 Thread Matthias Maennich
t of the symbol namespaces patch series to read the (potentially) multiple namespaces a module is importing. Reviewed-by: Joel Fernandes (Google) Reviewed-by: Martijn Coenen Signed-off-by: Matthias Maennich --- kernel/module.c | 17 +++-- 1 file changed, 15 insertions(+), 2 del

Re: [v2 PATCH 6/6] usb: mtu3: get optional clock by devm_clk_get_optional()

2019-04-12 Thread Matthias Brugger
On 10/04/2019 08:47, Chunfeng Yun wrote: > Use devm_clk_get_optional() to get optional clock > > Signed-off-by: Chunfeng Yun Reviewed-by: Matthias Brugger > --- > v2: new patch, merged into this series from > https://patchwork.kernel.org/patch/10878235/ > --

Re: [PATCH v2 3/4] usb: musb: Extract set toggle as a separate interface

2019-01-15 Thread Matthias Brugger
MUSB_TXCSR_H_DATATOGGLE) > + : MUSB_TXCSR_CLRDATATOG; Can we switch the if and use is_out logic as function parameter. This would make the code easier to understand. Regards, Matthias > + > + return csr; > +} > + > /* > * Advance t

Re: usb/serial - pl2303 module - buffer overflow

2018-06-25 Thread Matthias Dieter Wallnöfer
cost to much and offers enough features for 99% of the various use cases. I could try to do a test against the Windows driver, but it will probably not change in behaviour, when you are saying that this is about a design limitation. Thanks again, Matthias Wallnöfer Greg KH wrote: > On Sun, Jun

usb/serial - pl2303 module - buffer overflow

2018-06-24 Thread Matthias Dieter Wallnöfer
n I have also no idea how the chip informs the host that it buffers had been filled on (where is a protocol description?). I have only found this old driver code, no idea if it is of any use: http://www.madingley.org/james/pl2303/index.html Did anyone have a similar experience to me? Thanks, M

Re: [PATCH v2 3/3] dt-bindings: phy-mtk-tphy: add properties for U2 slew rate calibrate

2018-03-13 Thread Matthias Brugger
On 03/12/2018 06:25 AM, Chunfeng Yun wrote: > Add two properties of ref_clk and coefficient used by U2 slew rate > calibrate which may vary on different SoCs > > Signed-off-by: Chunfeng Yun Reviewed-by: Matthias Brugger > --- > Documentation/devicetree/bindings/phy/ph

Re: [PATCH v2 2/3] phy: phy-mtk-tphy: add configurable parameters for slew rate calibrate

2018-03-13 Thread Matthias Brugger
On 03/12/2018 06:25 AM, Chunfeng Yun wrote: > There are two parameters, ref_clk and coefficient, for U2 slew rate > calibrate which may vary on different SoCs, here allow them to be > configurable > > Signed-off-by: Chunfeng Yun Reviewed-by: Matthias Brugger > --- >

Re: [PATCH v2 9/9] dt-bindings: usb: mtk-xhci: remove dummy clocks and add optional ones

2017-10-13 Thread Matthias Brugger
On 10/13/2017 10:26 AM, Chunfeng Yun wrote: Remove dummy clocks for usb wakeup and add optional ones for MCU_BUS_CK and DMA_BUS_CK. Signed-off-by: Chunfeng Yun Acked-by: Rob Herring --- Reviewed-by: .../devicetree/bindings/usb/mediatek,mtk-xhci.txt | 18 -- 1 file

Re: [PATCH v2 6/9] usb: xhci-mtk: add optional mcu and dma bus clocks

2017-10-13 Thread Matthias Brugger
On 10/13/2017 10:26 AM, Chunfeng Yun wrote: There are mcu_bus and dma_bus clocks needed to be controlled by driver on some SoCs, so add them as optional ones Signed-off-by: Chunfeng Yun --- Reviewed-by: Matthias Brugger drivers/usb/host/xhci-mtk.c | 79

Re: [PATCH v2 5/9] usb: xhci-mtk: remove dummy wakeup debounce clocks

2017-10-13 Thread Matthias Brugger
On 10/13/2017 10:26 AM, Chunfeng Yun wrote: The wakeup debounce clocks for each ports in fact are not needed, so remove them. Signed-off-by: Chunfeng Yun --- Reviewed-by: Matthias Brugger drivers/usb/host/xhci-mtk.c | 33 - drivers/usb/host/xhci

Re: HP Thunderbolt 3 Dock (90W): USB does not work

2017-09-16 Thread Matthias Lohr
here: https://pastebin.com/1bqtgDJ3) Best regards Matthias 2017-09-14 19:41 GMT+02:00 Greg KH : > On Wed, Sep 13, 2017 at 07:54:21AM +0200, Matthias Lohr wrote: >> Hello, >> >> i'm using a Lenovo Carbon x1 (5th generation) with a HP Thunderbolt 3 >> dock (90W versio

HP Thunderbolt 3 Dock (90W): USB does not work

2017-09-12 Thread Matthias Lohr
ps://nopaste.me/view/602c66d6 Best regards Matthias -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 3/4] dt-bindings: mt8173-mtu3: add generic compatible and rename file

2017-08-14 Thread Matthias Brugger
eatures that can be found in the future for a specific SoC. The driver can match just against the generic binding and will only implement a match against the SoC specific one if a bug/feature is present. Makes sense? Regards, Matthias -- To unsubscribe from this list: send the line "unsub

pixart optical mouse dont work

2017-07-25 Thread Matthias Holl
dear kernel hackers, with the new kernel 4.13 my optical mouse from pixart dont work but i can show it with lsusb bus 007 device 003: id 093a:2510 pixart imaging,inc optical mouse i changed nothing in my kernel .conf with kernel 4.12, 4.11...i had no problems i guess its something with the gener

Re: [PATCH] usb: mtu3: Handle return value of clk_prepare_enable

2017-06-10 Thread Matthias Brugger
On 09/06/17 14:03, Arvind Yadav wrote: clk_prepare_enable() can fail here and we must check its return value. Signed-off-by: Arvind Yadav --- drivers/usb/mtu3/mtu3_plat.c | 23 --- 1 file changed, 20 insertions(+), 3 deletions(-) Reviewed-by: Matthias Brugger

[PATCH] net1080: Remove unused function nc_dump_ttl()

2017-05-18 Thread Matthias Kaehlcke
The function is not used, removing it fixes the following warning when building with clang: drivers/net/usb/net1080.c:271:20: error: unused function 'nc_dump_ttl' [-Werror,-Wunused-function] Also remove the definition of TTL_THIS, which is only used in nc_dump_ttl() Signed-off-by

[PATCH] r8152: Remove unused function usb_ocp_read()

2017-05-18 Thread Matthias Kaehlcke
The function is not used, removing it fixes the following warning when building with clang: drivers/net/usb/r8152.c:825:5: error: unused function 'usb_ocp_read' [-Werror,-Wunused-function] Signed-off-by: Matthias Kaehlcke --- drivers/net/usb/r8152.c | 6 -- 1 file changed, 6

Re: [PATCH] net1080: Mark nc_dump_ttl() as __maybe_unused

2017-05-18 Thread Matthias Kaehlcke
Hi David, El Thu, May 18, 2017 at 10:48:08AM -0400 David Miller ha dit: > From: Matthias Kaehlcke > Date: Wed, 17 May 2017 15:17:08 -0700 > > > The function is not used, but it looks useful for debugging. Adding the > > attribute fixes the following clang warning: >

[PATCH] r8152: Mark usb_ocp_read() as __maybe_unused

2017-05-17 Thread Matthias Kaehlcke
The function is not used, but is probably kept around for debugging and symmetry with usb_ocp_write(). Adding the attribute fixes the following clang warning: drivers/net/usb/r8152.c:825:5: error: unused function 'usb_ocp_read' [-Werror,-Wunused-function] Signed-off-by: Matthia

[PATCH] net1080: Mark nc_dump_ttl() as __maybe_unused

2017-05-17 Thread Matthias Kaehlcke
The function is not used, but it looks useful for debugging. Adding the attribute fixes the following clang warning: drivers/net/usb/net1080.c:271:20: error: unused function 'nc_dump_ttl' [-Werror,-Wunused-function] Signed-off-by: Matthias Kaehlcke --- drivers/net/usb/net1080.c

Re: [PATCH v5 1/9] phy: phy-mt65xx-usb3: improve RX detection stable time

2017-05-10 Thread Matthias Brugger
I took DTS parts for v4.12-next. Sorry for the late response. Matthias On 06/04/17 12:28, Kishon Vijay Abraham I wrote: On Friday 31 March 2017 01:05 PM, Chunfeng Yun wrote: The default value of RX detection stable time is 10us, and this margin is too big for some critical cases which cause

[PATCH] xhci: remove GFP_DMA flag from allocation

2017-05-05 Thread Matthias Lange
There is no reason to restrict allocations to the first 16MB ISA DMA addresses. Signed-off-by: Matthias Lange --- drivers/usb/host/xhci-mem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/xhci-mem.c b/drivers/usb/host/xhci-mem.c index bbe22bc..2f4445d

Re: GFP_DMA flag in xhci_segment_alloc

2017-05-05 Thread Matthias Lange
Hi, On 05/05/2017 10:39 AM, Mathias Nyman wrote: > Hi > > On 04.05.2017 22:13, Matthias Lange wrote: >> Hi, >> >> I am wondering what the reason for the GFP_DMA flag in >> xhci_segment_alloc() (drivers/usb/host/xhci-mem.c:59) is. >> >> It is causi

GFP_DMA flag in xhci_segment_alloc

2017-05-04 Thread Matthias Lange
? Please CC me as I am not subscribed to this list. Thanks, Matthias. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/6] usb: mtu3: add reference clock

2017-01-24 Thread Matthias Brugger
On 01/20/2017 03:20 AM, Chunfeng Yun wrote: On Thu, 2017-01-19 at 13:22 +0100, Matthias Brugger wrote: On 18/01/17 07:08, Chunfeng Yun wrote: usually, the reference clock comes from 26M oscillator directly, but some SoCs are not, add it for compatibility. Signed-off-by: Chunfeng Yun

Re: [PATCH v2, 6/6] dt-bindings: phy-mt65xx-usb: add support for new version phy

2017-01-24 Thread Matthias Brugger
hy type from: - PHY_TYPE_USB2 The old bindings will need to be supported by the driver, they have to stay here with a comment that they are deprecated. Regards, Matthias @@ -31,21 +37,31 @@ Example: u3phy: usb-phy@1129 { compatible = "m

Re: [PATCH 4/6] arm64: dts: mt8173: add reference clock for usb

2017-01-19 Thread Matthias Brugger
(-) This patch doesn't apply to my tree :( This patch should go through my tree, but take into account my comment on patch 3/6. From my point of view this series is not ready to be merged. Regards, Matthias -- To unsubscribe from this list: send the line "unsubscribe linux-usb"

Re: [PATCH 2/6] usb: mtu3: add reference clock

2017-01-19 Thread Matthias Brugger
b->ref_clk)) { + dev_err(dev, "failed to get ref clock\n"); + return PTR_ERR(ssusb->ref_clk); + } + That would break older dts bindings, right? ref_ck must be optional for the code. Regards, Matthias -- To unsubscribe from this list: send the line "

Re: [PATCH 1/1] usb: return error code when platform_get_irq fails

2016-11-30 Thread Matthias Brugger
= platform_get_irq(pdev, 0); - if (irq < 0) + if (irq < 0) { + ret = irq; goto disable_clk; + } /* Initialize dma_mask and coherent_dma_mask to 32-bits */ ret = dma_set_coherent_mask(dev, DMA_BIT_MASK(32)); Reviewed-by: Ma

Re: [PATCH 6/6] pinctrl: mt8173: set GPIO16 to usb iddig mode

2016-11-23 Thread Matthias Brugger
ling list. Regards, Matthias -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v7, 0/8] Add MediaTek USB3 DRD Driver

2016-10-28 Thread Matthias Brugger
I can see that the mt6397 regulater get's initialized *after* the mtu3 driver: [0.505166] mt6397-regulator mt6397-regulator: Chip ID = 0x4097 Not sure if this is related. Any idea whats going wrong here? Cheers, Matthias -- To unsubscribe from this list: send the line "unsubscrib

Re: [RESEND PATCH v6, 4/5] usb: Add MediaTek USB3 DRD Driver

2016-10-11 Thread Matthias Brugger
On 10/11/2016 05:14 AM, Chunfeng Yun wrote: On Mon, 2016-10-10 at 13:00 +0200, Matthias Brugger wrote: On 09/21/2016 07:54 AM, Chunfeng Yun wrote: This patch adds support for the MediaTek USB3 controller integrated into MT8173. It can be configured as Dual-Role Device (DRD), Peripheral Only

Re: [RESEND PATCH v6, 3/5] usb: xhci-mtk: make IPPC register optional

2016-10-10 Thread Matthias Brugger
three functions. Regards, Matthias /* reset whole ip */ value = readl(&ippc->ip_pw_ctr0); value |= CTRL0_IP_SW_RST; @@ -475,6 +484,7 @@ static void xhci_mtk_quirks(struct device *dev, struct xhci_hcd *xhci) /* called during probe() after chip reset completes */ static

Re: [PATCH RFC V3.5] leds: trigger: Introduce an USB port trigger

2016-08-25 Thread Matthias Brugger
ks Jacek!) Use "ports" sysfs file for adding and removing USB ports (thx Jacek) Check if there is USB device connected after adding new USB port Fix memory leak or two V3.5: Fix e-mail address (thanks Matthias) Simplify conditions in usbport_trig_notify (thx Matthias)

Re: [PATCH V3] leds: trigger: Introduce an USB port trigger

2016-08-24 Thread Matthias Brugger
On 24/08/16 13:02, Rafał Miłecki wrote: On 24 August 2016 at 12:49, Matthias Brugger wrote: On 24/08/16 00:03, Rafał Miłecki wrote: [...] +static int usbport_trig_notify(struct notifier_block *nb, unsigned long action, + void *data) +{ + struct

Re: [PATCH V3] leds: trigger: Introduce an USB port trigger

2016-08-24 Thread Matthias Brugger
ta); + + led_cdev->activated = false; +} + +static struct led_trigger usbport_led_trigger = { + .name = "usbport", + .activate = usbport_trig_activate, + .deactivate = usbport_trig_deactivate, +}; + +static int __init usbport_trig_init(void) +{ + retu

Re: [PATCH v5 2/6] power: add power sequence library

2016-08-08 Thread Matthias Kaehlcke
d-off-by: Peter Chen > Tested-by Joshua Clayton Reviewed-by: Matthias Kaehlcke Tested-by: Matthias Kaehlcke -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v4 2/6] power: add power sequence library

2016-08-03 Thread Matthias Kaehlcke
What is the purpose of pwrseq_register/unregister()? The pwrseq structs are added and removed from pwrseq_list, but besides that pwrseq_list is not used. Looks like this is a remainder from the ancestor of this code (drivers/mmc/core/pwrseq.c) which uses the list to avoid having multiple pwrseq instances for the same device. Matthias -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [v3,2/6] power: add power sequence library

2016-07-29 Thread Matthias Kaehlcke
Hi Peter, Thanks for your work on this, a few comments inline On 07/20/2016 02:40 AM, Peter Chen wrote: ... +static int pwrseq_generic_on(struct device_node *np, struct pwrseq *pwrseq) +{ ... + if (gpiod_reset) { + u32 duration_us = 50; + + of_property_rea

Re: [PATCH v2,3/5] dt-bindings: mtu3: add devicetree bindings

2016-06-03 Thread Matthias Brugger
es : a pinctrl state named "default" must be defined, + "id_float" and "id_ground" are optinal which depends on + "mediatek,enable-manual-drd" So pinctrl is optional, but if you put it, you need at least "default"? Apart from t

Re: [PATCH v2 1/2] dt-bindings: phy-mt65xx-usb: add support for mt2701 platform

2016-04-13 Thread Matthias Brugger
On 11/04/16 09:41, Chunfeng Yun wrote: A new compatible string, "mediatek,mt2701-u3phy", is added. Signed-off-by: Chunfeng Yun --- .../devicetree/bindings/phy/phy-mt65xx-usb.txt |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) Reviewed-by: Matthias Brugger

Re: [PATCH] phy: phy-mt65xx-usb3: add support for mt2701 platform

2016-04-08 Thread Matthias Brugger
e should be only one compatible. Apart from that normally the dts documentation parts are separate patches. Regards, Matthias -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/6] usb: xhci-mtk: use __maybe_unused to hide pm functions

2016-03-04 Thread Matthias Brugger
id defining the structure when CONFIG_PM is not set without the #ifdef. Signed-off-by: Arnd Bergmann --- Reviewed-by: Matthias Brugger drivers/usb/host/xhci-mtk.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/usb/host/xhci-mtk.c b/drivers/usb/host

Re: Repeatedly connect/disconnect events for USB devices

2015-04-11 Thread Matthias Nagel
relation between these messages and the USB problem? Perhaps someone could point my in the correct direction what I should do about these messages. Thanks, Matthias Am Mittwoch, 8. April 2015, 18:04:27 schrieb Matthias Nagel: > Am Mittwoch, 8. April 2015, 10:40:39 schrieb Greg KH: > > &

Re: Repeatedly connect/disconnect events for USB devices

2015-04-08 Thread Matthias Nagel
only USB 2.0 ports. The affacted machine has a ASUS P9D WS motherboard and a mix of USB 2.0 and 3.0 ports. Unfortunately, I am to little of a kernel hacker to investigate the problem any further without external advice. Matthias [0.00] Initializing cgroup subsys cpuset [

Repeatedly connect/disconnect events for USB devices

2015-04-07 Thread Matthias Nagel
computer has only an eHCI controller. Matthias [1] https://bugzilla.kernel.org/show_bug.cgi?id=96291 -- Matthias Nagel Parkstraße 27, 76131 Karlsruhe, Deuschland Festnetz: +49-721-96869289, Mobil: +49-151-15998774 e-Mail: matthias.h.na...@gmail.com, Skype: nagmat84 -- To unsubscribe from this list: s

Re: [PATCH] usb: option: Add ID for Peiker LTE NAD

2014-11-02 Thread Matthias Klein
Am 02.11.2014 um 04:35 schrieb Lars Melin: On 2014-11-01 23:01, Matthias Klein wrote: Add ID of the Peiker LTE NAD for legacy serial interface Signed-off-by: Matthias Klein --- drivers/usb/serial/option.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/serial/option.c b

[PATCH] usb: option: Add ID for Peiker LTE NAD

2014-11-01 Thread Matthias Klein
Add ID of the Peiker LTE NAD for legacy serial interface Signed-off-by: Matthias Klein --- drivers/usb/serial/option.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c index d1a3f60..d7f1042 100644 --- a/drivers/usb/serial/option.c

Re: [PATCH] MAINTAINERS: drop two usb-serial subdriver entries

2014-06-03 Thread Matthias Urlichs
Hi, Matthias Urlichs: > Fine by me. or, in other words: Signed-Off-By: Matthias Urlichs -- -- Matthias Urlichs signature.asc Description: Digital signature

Re: [PATCH] MAINTAINERS: drop two usb-serial subdriver entries

2014-06-02 Thread Matthias Urlichs
Hi, Johan Hovold: > > > -USB OPTION-CARD DRIVER > > > -M: Matthias Urlichs > > > -L: linux-usb@vger.kernel.org > > > -S: Maintained > > > -F: drivers/usb/serial/option.c > > > > Why are we taking away the

Re: xhci_hcd and Canon Lide 110 not playing well together

2013-12-25 Thread Matthias Bläsing
Hey Alan, On Mo, 2013-12-23 at 15:38 -0500, Alan Stern wrote: > On Mon, 23 Dec 2013, Matthias [ISO-8859-1] Blsing wrote: > > Looking at the strace alone, I see, that the USBDEVFS_SETCONFIGURATION > > ioctl calls take excessive time. > > > > You're right; thos

Re: xhci_hcd and Canon Lide 110 not playing well together

2013-12-18 Thread Matthias Bläsing
hysical ports I can access are either connected to Bus 03 (I suspect, that Bus 04 and Bus 03 are the same, only differing in their speed) or Bus 02. Bus 02 (Driver=ehci-pci/2p, 480M) works, Bus 03 (Driver=xhci_hcd/4p, 480M) fails. Any ideas? Greetings Matthias PS: I removed my subscription of linux-us

Re: Scanner works on EHCI port, fails on XHCI Port

2013-12-10 Thread Matthias Bläsing
Hey, On Mo, 2013-12-09 at 21:07 +0100, Matthias Bläsing wrote: > [USB Scanner working on EHCI port, but not on XHCI] some more info - sorry I should have provided that in the first place. The USB Host is a DELL E 5530 Notebook, with this hardware: matthias@athena:~$ lspci 00:00.0 Host bri

Scanner works on EHCI port, fails on XHCI Port

2013-12-09 Thread Matthias Bläsing
Hello, I hope this is the right place to ask. I own a Canon CanoScan LiDE 25. The scanner worked well the last few years and with my new notebook it only works in one port. From the tree it seems to be tied to the controller: This works: matthias@athena:~$ lsusb -t /: Bus 04.Port 1: Dev 1

[PATCH v2 1/5] drivers: usb: core: devio.c: Spaces to tabs for proc_reapurbnonblock()

2013-10-14 Thread Matthias Beyer
Replaced spaces by tabs for proc_reapurbnonblock() function. Signed-off-by: Matthias Beyer --- drivers/usb/core/devio.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c index 71dc5d7..6a2e567 100644 --- a

[PATCH v2 0/5] Coding style fixes

2013-10-14 Thread Matthias Beyer
ve not to apply 5/6 and 6/6 from the origin patch series (I would be confused if it still works)! Btw: If you are stressed out by me sending coding style fixes, I wouldn't take it wrong if you would redirect me to a submaintainer or so! Best regards! Matthias Beyer (5): drivers: usb: core

[PATCH v2 5/5] drivers: usb: core: devio.c: Put arguments on new line

2013-10-14 Thread Matthias Beyer
To fit the 80-cols convention, this patch moves the arguments (the second and third one) for driver->unlocked_ioctl() onto a new line. Signed-off-by: Matthias Beyer --- drivers/usb/core/devio.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/core/devio.

[PATCH v2 3/5] drivers: usb: core: devio.c: Braces around if-elseif-else

2013-10-14 Thread Matthias Beyer
, which needs a reindent after adding the braces. Signed-off-by: Matthias Beyer --- drivers/usb/core/devio.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c index d15aa51..dd8701b 100644 --- a/drivers/usb/core/devio.c

[PATCH v2 4/5] drivers: usb: core: devio.c: Reindented switch-block

2013-10-14 Thread Matthias Beyer
Reindented the switch-block. Signed-off-by: Matthias Beyer --- drivers/usb/core/devio.c | 56 1 file changed, 28 insertions(+), 28 deletions(-) diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c index dd8701b..9761a27 100644 --- a

[PATCH v2 2/5] drivers: usb: core: devio.c: Spaces to tabs for proc_control_compat()

2013-10-14 Thread Matthias Beyer
Replaced spaces by tabs for proc_control_compat() function. Signed-off-by: Matthias Beyer --- drivers/usb/core/devio.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c index 6a2e567..d15aa51 100644

[PATCH 1/1] drivers: usb: core: devio.c: Braces around switch (updated)

2013-10-12 Thread Matthias Beyer
Added braces around switch statement as the styleguide tells us. Indented the switch-block for it and split a function call (driver->unlocked_ioctl() on line 1876) arguments to several lines to fit the 80-column convention. Signed-off-by: Matthias Beyer --- drivers/usb/core/devio.c |

[PATCH 1/1] drivers: usb: core: devio.c: Coding style fixes

2013-10-12 Thread Matthias Beyer
Whitespace fixes, including: - Whitespace after if-keyword - Spaces to Tabs Other coding style fixes: - Added braces for if-else blocks where missing Signed-off-by: Matthias Beyer --- drivers/usb/core/devio.c | 40 +--- 1 file changed, 21 insertions(+), 19

[PATCH 1/6] drivers: usb: core: {file,hub,sysfs,usb}.c: Whitespace fixes

2013-10-10 Thread Matthias Beyer
including: - removing of trailing whitespace - removing spaces before array indexing (foo [] to foo[]) - reindention of a switch-case block - spaces to tabs Signed-off-by: Matthias Beyer --- drivers/usb/core/file.c | 6 +-- drivers/usb/core/hub.c | 111

  1   2   >