Hi Marek,
On 19/07/19 5:51 PM, Marek Szyprowski wrote:
> Hi Kishon,
>
> On 2019-07-19 12:04, Kishon Vijay Abraham I wrote:
>> Hi Marek,
>>
>> On 19/07/19 3:22 PM, Marek Szyprowski wrote:
>>> Commit 36914111e682 ("drivers: phy: add calibrate method"
re.c before phy_calibrate()? We could
add a separate section in Documentation/phy.txt to document these phy_ops.
Thanks
Kishon
Hi,
On 16/01/19 8:58 PM, Jeffrey Hugo wrote:
> On 1/16/2019 1:58 AM, Kishon Vijay Abraham I wrote:
>> Hi,
>>
>> On 16/01/19 2:20 PM, Kishon Vijay Abraham I wrote:
>>>
>>>
>>> On 15/01/19 11:41 PM, Bjorn Andersson wrote:
>>>> On Mon 1
TABLE(of, mvebu_a3700_utmi_of_match);
>> +
>> +static int mvebu_a3700_utmi_phy_probe(struct platform_device *pdev)
>> +{
>> +const struct of_device_id *dev_id;
>> +struct device *dev = &pdev->dev;
>> +struct mvebu_a3700_utmi *utmi;
>> +struct phy_provider
Hi,
On 16/01/19 2:20 PM, Kishon Vijay Abraham I wrote:
>
>
> On 15/01/19 11:41 PM, Bjorn Andersson wrote:
>> On Mon 14 Jan 08:36 PST 2019, Jeffrey Hugo wrote:
>>
>>> MSM8998 contains one QUSB2 PHY which is very similar to the existing
>>> sdm845 suppor
For "qcom,sdm845-qmp-usb3-uni-phy" must contain:
>> @@ -60,6 +63,8 @@ Required properties:
>> For "qcom,msm8996-qmp-pcie-phy" must contain:
>> "phy", "common", "cfg".
>> For "qcom,msm8996-qmp-usb3-phy" must contain
>> + "phy", "common".
>
> Odd indentation.
>
>
> Apart from this, you have my
>
> Reviewed-by: Bjorn Andersson
Fixed the indentation and merged it.
Thanks
Kishon
On 15/01/19 11:41 PM, Bjorn Andersson wrote:
> On Mon 14 Jan 08:36 PST 2019, Jeffrey Hugo wrote:
>
>> MSM8998 contains one QUSB2 PHY which is very similar to the existing
>> sdm845 support.
>>
>
I don't seem to have the dt-binding patch in my inbox. Can you se
e can be returned by related to phy function if
>> CONFIG_GENERIC_PHY is disabled.
>>
>> I have seen this warning in output of checkpatch --strict .
>
> Kishon, seems like you shouldn't be using that error value.
hmm, yeah should change the return value to -ENODEV
Hi,
On 15/10/18 8:15 PM, Lubomir Rintel wrote:
> Turned from arch/arm/mach-mmp/devices.c into a proper PHY driver, so
> that in can be instantiated from a DT.
>
> Acked-by: Kishon Vijay Abraham I
> Signed-off-by: Lubomir Rintel
I'm unable to apply this patch as the raw for
> + /* Allow aggressive PM for USB, it's only needed for n_gsm port */
> + if (phy_pm_runtime_enabled(ddata->generic_phy))
> + phy_pm_runtime_put(ddata->generic_phy);
phy_*() API's are generally added to be used by the consumer driver. I guess in
this case we can directly use pm_runtime_enabled(x).
Thanks
Kishon
Hi,
On 27/10/18 3:28 PM, Yu Chen wrote:
> This driver handles usb phy power on and shutdown for hi3660 Soc of
> Hisilicon.
>
> Cc: Kishon Vijay Abraham I
> Cc: "David S. Miller"
> Cc: Greg Kroah-Hartman
> Cc: Mauro Carvalho Chehab
> Cc: Andrew Morton
&g
On Thursday 23 August 2018 02:12 AM, Lubomir Rintel wrote:
> Turned from arch/arm/mach-mmp/devices.c into a proper PHY driver, so
> that in can be instantiated from a DT.
>
> Signed-off-by: Lubomir Rintel
Acked-by: Kishon Vijay Abraham I
If this has to be merged via linux-phy
link active.
> Documentation/devicetree/bindings/usb/mediatek,mtu3.txt indeed shows
> that the parent of the USB controller can be marked as "wakeup-source"
>
>> 2) TI's case: low power important: USB context is lost, OK to re-enumerate.
>> phy_exit()/phy_init() must be called during suspend/resume.
> ACK
>
>>>> With that there is nothing else being done here. Shouldn't we be doing the
>>>> equivalent of
>>>> usb_phy_roothub_del_phy() and usb_phy_roothub_free() here?
>>>>
>>>>> +
>>>>> + return ret;
>>>>> +}
>>>>> +EXPORT_SYMBOL_GPL(usb_phy_roothub_exit);
>>>>> +
>>>>> +int usb_phy_roothub_power_on(struct usb_phy_roothub *phy_roothub)
>>>>> +{
>>>>> + struct usb_phy_roothub *roothub_entry;
>>>>> + struct list_head *head;
>>>>> + int err;
>>>>> +
>>>>> + if (!phy_roothub)
>>>>> + return 0;
>>>>> +
>>>>> + head = &phy_roothub->list;
>>>>> +
>>>>> + list_for_each_entry(roothub_entry, head, list) {
>>>>> + err = phy_power_on(roothub_entry->phy);
>>>>> + if (err)
>>>>> + goto err_out;
>>>>> + }
>>>>> +
>>>>> + return 0;
>>>>> +
>>>>> +err_out:
>>>>> + list_for_each_entry_continue_reverse(roothub_entry, head, list)
>>>>> + phy_power_off(roothub_entry->phy);
>>>>> +
>>>>> + return err;
>>>>> +}
>>>>> +EXPORT_SYMBOL_GPL(usb_phy_roothub_power_on);
>>>>> +
>>>>> +void usb_phy_roothub_power_off(struct usb_phy_roothub *phy_roothub)
>>>>> +{
>>>>> + struct usb_phy_roothub *roothub_entry;
>>>>> +
>>>>> + if (!phy_roothub)
>>>>> + return;
>>>>> +
>>>>> + list_for_each_entry_reverse(roothub_entry, &phy_roothub->list, list)
>>>>> + phy_power_off(roothub_entry->phy);
>>>>
>>>> Not doing the phy_exit() here leaves the clocks enabled on our SoC and
>>>> we're no longer able to reach low power states on system suspend.
>>> I'm not sure where this problem should be solved:
>>> - set skip_phy_initialization in struct usb_hcd to 1 for the affected
>>> TI platforms
>>
>> Many TI platforms are affected, omap5*, dra7*, am43*
>>
>>> - fix this in the usb_phy_roothub code
>>
>> I'd vote for fixing it in the usb_phy_roothub code. How?
>> How about using the device_can_wakeup() to decide if we should call
>> phy_exit()/init() or not?
>> If the USB device can't wakeup the system there is no point in keeping it
>> powered/clocked right?
> @Chunfeng: can you confirm Roger's idea that we could call phy_exit if
> the controller is *NOT* marked as "wakeup-source"?
> I am also not sure if it would work, since the "wakeup-source"
> property is defined on the USB controller's parent node in case of the
> Mediatek MTU3 (Mediatek USB3.0 DRD) controller
>
>>> - fix this in the PHY driver
>>
>> There is nothing to fix in the PHY driver. It is doing what it is supposed
>> to do.
> I actually wonder if phy_ops should have explicit suspend/resume support:
Not in favor of adding explicit suspend/resume ops since PM framework already
has those. I think we should let PHY drivers manage suspend/resume on its own
(after creating the dependency between the controller device and PHY using
device_link_add).
Thanks
Kishon
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
c: Marcel Partap
> Cc: Michael Scott
> Cc: Rob Herring
> Reviewed-by: Rob Herring
> Signed-off-by: Tony Lindgren
> ---
>
> Changes since v2:
> - Dropped OTG as suggested by Kishon
> - Added Rob's Reviewed-by
>
> Changes since v1:
> - Fixed u
s/phy/motorola/Makefile
> +++ b/drivers/phy/motorola/Makefile
> @@ -3,3 +3,4 @@
> #
>
> obj-$(CONFIG_PHY_CPCAP_USB) += phy-cpcap-usb.o
> +obj-$(CONFIG_PHY_MAPPHONE_MDM6600) += phy-mapphone-mdm6600.o
> diff --git a/drivers/phy/motorola/phy-mapphone-mdm6600.c
> b/drivers/phy/motorola/phy-mapphone-mdm6600.c
> new file mode 100644
> --- /dev/null
> +++ b/drivers/phy/motorola/phy-mapphone-mdm6600.c
.
.
.
.
> +
> +static int phy_mdm6600_probe(struct platform_device *pdev)
> +{
> + struct phy_mdm6600 *ddata;
> + struct usb_otg *otg;
Since it is connected to a OHCI, not sure if we really need to add usb_otg here.
Thanks
Kishon
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thursday 01 February 2018 06:08 PM, Kishon Vijay Abraham I wrote:
> Hi,
>
> On Wednesday 31 January 2018 10:51 AM, Manu Gautam wrote:
>> Hi Kishon,
>>
>>
>> On 1/16/2018 4:26 PM, Manu Gautam wrote:
>>> QUSB-v2 and QMP-v3 USB PHYs are present on Q
Hi,
On Wednesday 31 January 2018 10:51 AM, Manu Gautam wrote:
> Hi Kishon,
>
>
> On 1/16/2018 4:26 PM, Manu Gautam wrote:
>> QUSB-v2 and QMP-v3 USB PHYs are present on Qualcomm's 14nm
>> and 10nm SOCs.
>> This patch series adds support for runtime PM for
Hi Arnd,
On Thursday 11 January 2018 11:46 PM, Eric Anholt wrote:
> Arnd Bergmann writes:
>
>> On Thu, Jan 11, 2018 at 2:30 PM, Kishon Vijay Abraham I
>> wrote:
>>> On Thursday 11 January 2018 02:27 AM, Arnd Bergmann wrote:
>>>> On Mon, Jan 8,
Hi Arnd,
On Thursday 11 January 2018 02:27 AM, Arnd Bergmann wrote:
> On Mon, Jan 8, 2018 at 7:32 PM, Kishon Vijay Abraham I wrote:
>> Hi Arnd,
>>
>> On Monday 08 January 2018 06:31 PM, Arnd Bergmann wrote:
>>> Stefan Wahren reports a problem with a warning fix tha
;nvidia,tegra20-usb-phy" },
> + { .compatible = "nvidia,tegra30-usb-phy" },
> + { .compatible = "nxp,isp1301" },
> + { .compatible = "ti,am335x-usb-ctrl-module" },
> + { .compatible = "ti,am335x-usb-phy" },
> + { .compatib
ce get_mode only has to return the phy mode, there is no need for an ops
here. Just add phy_mode in phy_attrs in set_mode and return it here.
Thanks
Kishon
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi,
On Friday 29 December 2017 09:54 AM, Manu Gautam wrote:
> Hi,
>
>
> On 12/28/2017 4:34 PM, Kishon Vijay Abraham I wrote:
>> Hi,
>>
> [snip]
>>
>>>> I'd prefer adding modes in enum phy_mode according to speed and using
>>>>
automatically if no device attached for normal flow.
> But keep the force mode to fix RX sensitivity degradation issue.
>
> Signed-off-by: Chunfeng Yun
merged this series.
Thanks
Kishon
> ---
> drivers/phy/mediatek/phy-mtk-tphy.c | 19 +++
> 1 file cha
Hi,
On Wednesday 20 December 2017 02:11 PM, Manu Gautam wrote:
> Hi
>
>
> On 12/20/2017 12:47 PM, Kishon Vijay Abraham I wrote:
>> Hi,
>>
> [snip]
>>>> Why not use a notification mechanism instead of adding new APIs in
>>>> phy-core.
Hi,
On Wednesday 20 December 2017 11:59 AM, Manu Gautam wrote:
> Hi,
>
>
> On 12/20/2017 11:19 AM, Kishon Vijay Abraham I wrote:
>> Hi,
>>
>> On Tuesday 12 December 2017 08:54 PM, Manu Gautam wrote:
>>> Hi,
>>>
>>>
>>> On 12/12
Hi,
On Tuesday 12 December 2017 08:54 PM, Manu Gautam wrote:
> Hi,
>
>
> On 12/12/2017 5:13 PM, Kishon Vijay Abraham I wrote:
>> Hi,
>>
>> On Tuesday 21 November 2017 02:53 PM, Manu Gautam wrote:
>>> QCOM USB PHYs can monitor resume/remote-wakeup event in
; +
> + return ret;
> +}
> +EXPORT_SYMBOL_GPL(phy_get_speed);
So this is equivalent to set_speed (why notify?) and get_speed. set_speed will
most likely be invoked by USB driver? who will invoke get_speed?
Thanks
Kishon
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
m
> [adapted to use phy_calibrate as entry point]
> Signed-off-by: Andrzej Pietrasiewicz
> ---
> drivers/phy/samsung/phy-exynos5-usbdrd.c | 183
> +++
> drivers/usb/dwc3/core.c | 7 +-
are you okay with this patch?
Thanks
Kishon
--
To
On Wednesday 18 October 2017 07:44 AM, Chanwoo Choi wrote:
> Gently Ping.
>
> Dear Kishon,
>
> Could you please review this patch for 'drivers/phy/*'?
sorry for the delay.. here it is
Acked-by: Kishon Vijay Abraham I
>
> Regards,
> Chanwoo Choi
>
&
patch enumeration happens correctly and a super speed device
> is recognized as such.
>
> Changes since v3:
>
> - improved the commit message in phy_calibrate() commit
> (as suggested by Kishon)
> - rebased onto v4.14-rc4
merged, thanks!
-Kishon
>
> Changes since
27;s is not sufficient for initializing/calibrating the phy.
Thanks
Kishon
>
> Signed-off-by: Andrzej Pietrasiewicz
> ---
> drivers/phy/phy-core.c | 15 +++
> include/linux/phy/phy.h | 10 ++
> 2 files changed, 25 insertions(+)
>
> diff --git a/drivers/phy/
patch enumeration happens correctly and a super speed device
> is recognized as such.
>
> @Kishon:
>
> As far as I understand what you suggest is to move phy_init() and
> phy_power_on() invocations from dwc3/core.c to xhci-plat, but,
> to the best of my knowledge, th
add_hcd() indirectly triggers overwriting the effects of calibration.
>>
>> in that case, you should do that from xhci-plat indeed. I think the
>> whole idea with init_count is just to make sure you don't initialize it
>> twice.
>
> As far as I understand the code
On Thursday 21 September 2017 04:01 PM, Chunfeng Yun wrote:
> Chip bank of version-1 is initialized as NULL, but it's used
> by pcie_phy_instance_power_on/off(), so assign it a right
> address.
merged. How was this not noticed before?
Thanks
Kishon
>
> Signed-
c int exynos5_usbdrd_phy_reset(struct phy *phy)
>> +{
>> +struct phy_usb_instance *inst = phy_get_drvdata(phy);
>> +struct exynos5_usbdrd_phy *phy_drd = to_usbdrd_phy(inst);
>> +
>> +return exynos5420_usbdrd_phy_calibrate(phy_drd);
>> +}
>> +
>> static const struct phy_ops exynos5_usbdrd_phy_ops = {
>> .init = exynos5_usbdrd_phy_init,
>> .exit = exynos5_usbdrd_phy_exit,
>> .power_on = exynos5_usbdrd_phy_power_on,
>> .power_off = exynos5_usbdrd_phy_power_off,
>> +.reset = exynos5_usbdrd_phy_reset,
>> .owner = THIS_MODULE,
>> };
>>
>> diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
>> index 03474d3..1d5836e 100644
>> --- a/drivers/usb/dwc3/core.c
>> +++ b/drivers/usb/dwc3/core.c
>> @@ -156,9 +156,10 @@ static void __dwc3_set_mode(struct work_struct *work)
>> } else {
>> if (dwc->usb2_phy)
>> otg_set_vbus(dwc->usb2_phy->otg, true);
>> -if (dwc->usb2_generic_phy)
>> +if (dwc->usb2_generic_phy) {
>> phy_set_mode(dwc->usb2_generic_phy,
>> PHY_MODE_USB_HOST);
>> -
>> +phy_reset(dwc->usb2_generic_phy);
>
> it doesn't look like this is the best place to reset the phy. Also,
right, phy_reset is done during initialization before phy_power_on/phy_init or
in error cases.
> ->reset() doesn't seem to match correctly with a calibration. That seems
> to be more fitting to a ->power_on() or ->init() implementation.
yeah, the initial patch seems to calibrate in phy_init(). Not sure why it's
modified.
Thanks
Kishon
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Chunfeng
On Thursday 03 August 2017 03:50 PM, Chunfeng Yun wrote:
> hi,
>
> I made a mistake, please ignore the patches with Change-Id, very sorry
No problem. However can you resend the series after fixing all checkpatch
warnings?
Thanks
Kishon
--
To unsubscribe from this list: send
On Monday 17 July 2017 06:50 AM, Chanwoo Choi wrote:
> This patch replaces the deprecated extcon API as following:
> - extcon_set_cable_state_() -> extcon_get_state()
>
> Cc: Kishon Vijay Abraham I
> Cc: Raviteja Garimella
> Signed-off-by: Chanwoo Choi
Acked-by: K
con_set_state_sync()
>
> Cc: linux-rockc...@lists.infradead.org
> acked-by: Kishon Vijay Abraham I
^
should be 'A' here.
-Kishon
> Signed-off-by: Chanwoo Choi
> ---
> drivers/phy/rockchip/phy-rockchip-inno-usb2.c | 10 +-
> 1 file changed, 5 insertions
Vivek,
On Monday 31 July 2017 10:58 AM, Vivek Gautam wrote:
> Hi Kishon,
>
>
> On Tue, Jun 20, 2017 at 11:27 AM, Vivek Gautam
> wrote:
>> Fixing the clk enable failure path in qcom_qmp_phy_init()
>> and cleanup the reset control deassertion failure path
to configure the pins.
>
> Fixes: 8ae904e3c236 ("phy: cpcap-usb: Add CPCAP PMIC USB support")
> Reported-by: Colin Ian King
> Signed-off-by: Tony Lindgren
merged, thanks!
-Kishon
> ---
> drivers/phy/motorola/phy-cpcap-usb.c | 2 ++
> 1 file changed, 2 insertion
ebase on PHY -next
removed this changelog and merged,
Thanks
Kishon
>
>
> ---
> drivers/phy/ti/phy-tusb1210.c | 35 +++
> 1 file changed, 35 insertions(+)
>
> diff --git a/drivers/phy/ti/phy-tusb1210.c b/drivers/phy/ti/phy-tusb1210.c
> ind
erged this series, thanks!
-Kishon
> ---
>
> changes since v1:
> - rebase on PHY -next
>
> drivers/phy/ti/phy-tusb1210.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/phy/ti/phy-tusb1210.c b/drivers/phy/ti/phy-tusb1210.c
> inde
Hi,
On Friday 09 June 2017 03:27 PM, Felipe Balbi wrote:
>
> Hi,
>
> Kishon Vijay Abraham I writes:
>> On Thursday 08 June 2017 05:19 PM, Felipe Balbi wrote:
>>> TUSB1211 is software compatible with TUSB1210 and as such we don't
>>> need an entir
e Balbi
> ---
> drivers/phy/phy-tusb1210.c | 3 ++-
The directory structure in phy has changed a bit. phy-tusb1210.c is now in
drivers/phy/ti/.
Thanks
Kishon
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vge
Herring
> Tested-by: Sebastian Reichel
> Signed-off-by: Tony Lindgren
merged, thanks.
-Kishon
> ---
>
> Changes since v3:
> - Dropped extcon based on what was discussed with Kishon as
> we're better off with using IIO directly as we need the values
> for VBUS a
On Monday 22 May 2017 03:32 AM, Wolfram Sang wrote:
> include/linux/i2c is not for client devices. Move the header file to a
> more appropriate location.
>
> Signed-off-by: Wolfram Sang
Acked-by: Kishon Vijay Abraham I
> ---
> arch/arm/mach-omap2/common.h| 2 +
Signed-off-by: Vivek Gautam
> Acked-by: Heiko Stuebner
> Acked-by: Viresh Kumar
> Acked-by: Krzysztof Kozlowski
> Acked-by: Yoshihiro Shimoda
> Reviewed-by: Jaehoon Chung
> Cc: Kishon Vijay Abraham I
> Cc: David S. Miller
> Cc: Geert Uytterhoeven
> Cc: Yos
Hi Vivek,
On Thursday 11 May 2017 12:17 PM, Vivek Gautam wrote:
> Ulpi phy header is not used for anything. Remove the same
> from qcom-hs and qcom-hsic phy drivers.
>
> Signed-off-by: Vivek Gautam
> Suggested-by: Stephen Boyd
> Cc: Kishon Vijay Abraham I
&
Signed-off-by: Vivek Gautam
> Acked-by: Heiko Stuebner
> Acked-by: Viresh Kumar
> Acked-by: Krzysztof Kozlowski
> Acked-by: Yoshihiro Shimoda
> Reviewed-by: Jaehoon Chung
> Cc: Kishon Vijay Abraham I
> Cc: David S. Miller
> Cc: Geert Uytterhoeven
> Cc: Yos
't simple then we should stick to your patch
version 2 since extcon support in this version is not useful IMO.
>
> Cc: devicet...@vger.kernel.org
> Cc: Marcel Partap
> Cc: Michael Scott
> Acked-by: Rob Herring
> Tested-by: Sebastian Reichel
> Signed-off-by: Tony Lindgr
Fengguang Wu
> Cc: Kishon Vijay Abraham I
> Signed-off-by: Vivek Gautam
> ---
>
> Hi Kishon,
>
> This patch is fixing the build failures for architectures
> such as, tile, and ia64, that don't enable COMMON_CLK by default.
> You can either squash this into the qmp
ches in this series to linux-phy -next.
Thanks
Kishon
> Signed-off-by: Chunfeng Yun
> ---
> drivers/phy/phy-mt65xx-usb3.c | 18 ++
> 1 file changed, 18 insertions(+)
>
> diff --git a/drivers/phy/phy-mt65xx-usb3.c b/drivers/phy/phy-mt65xx-usb3.c
> index d97206
On Thursday 06 April 2017 11:21 AM, Vivek Gautam wrote:
> Hi Kishon,
> Here's the series with fixed checkpatch warnings/checks.
> Please pick it for phy/next.
>
> This patch series adds couple of PHY drivers for Qualcomm chipsets.
> a) qcom-qusb2 phy driver: that
fixing DMA config for XHCI are also
> pulled in for testing.
> A branch based on torvald's master is available in github [3].
I get a bunch of checkpatch errors/warnings when I run checkpatch with --strict
option. Those look simple enough to be fixed. Can you respin your series fixing
tho
Hi Vivek,
On Wednesday 05 April 2017 05:07 PM, Vivek Gautam wrote:
> Hi Kishon,
>
>
> On 04/05/2017 04:34 PM, Kishon Vijay Abraham I wrote:
>> Hi Vivek,
>>
>> On Monday 20 March 2017 06:49 PM, Vivek Gautam wrote:
>>> This is the next version to an earli
history in commit log and merged the series.
Thanks
Kishon
>
> Meng Dongyang (3):
> dt-bindings: phy: add assign clock property in usb2-phy node
> dt-bindings: phy: add DT bindings for usb2-phy grf
> phy: rockchip-inno-usb2: add support of usb2-phy for rk3328
>
>
ed 'Acked-by' and 'Reviewed-by'
> tags.
>
> This series is based on linux-phy/next branch.
>
> [1] https://www.spinics.net/lists/arm-kernel/msg568370.html
>
> Signed-off-by: Vivek Gautam
> Cc: Kishon Vijay Abraham I
> Cc: linux-arm-ker...@lists.i
Hi Tony,
On Monday 27 March 2017 08:35 PM, Tony Lindgren wrote:
> * Kishon Vijay Abraham I [170326 23:27]:
>> On Thursday 23 March 2017 05:16 AM, Tony Lindgren wrote:
>>> +static const struct phy_ops ops = {
>>> + .owner = THIS_MODULE,
>>> +};
&g
rged, thanks.
-Kishon
>
> Meng Dongyang (2):
> Documentation: bindings: add DT documentation for u2phy and u2phy grf
> phy: rockchip-inno-usb2: add support of u2phy for rk3328
>
> .../bindings/phy/phy-rockchip-inno-usb2.txt| 47
> ++
>
t;no mode change GPIO%i: %li\n",
> + i, PTR_ERR(ddata->gpio[i]));
> + ddata->gpio[i] = NULL;
> + }
> + }
> +}
> +
> +static int cpcap_usb_init_iio(struct cpcap_phy_ddata *ddata)
> +{
> + enum iio_chan_type type;
> + int error;
> +
> + ddata->vbus = devm_iio_channel_get(ddata->dev, "vbus");
> + if (IS_ERR(ddata->vbus)) {
> + error = PTR_ERR(ddata->vbus);
> + goto out_err;
> + }
> +
> + if (!ddata->vbus->indio_dev) {
> + error = -ENXIO;
> + goto out_err;
> + }
> +
> + error = iio_get_channel_type(ddata->vbus, &type);
> + if (error < 0)
> + goto out_err;
> +
> + if (type != IIO_VOLTAGE) {
> + error = -EINVAL;
> + goto out_err;
> + }
> +
> + return 0;
> +
> +out_err:
> + dev_err(ddata->dev, "could not initialize VBUS or ID IIO: %i\n",
> + error);
> +
> + return error;
> +}
> +
> +#ifdef CONFIG_OF
> +static const struct of_device_id cpcap_usb_phy_id_table[] = {
> + {
> + .compatible = "motorola,cpcap-usb-phy",
> + },
> + {
> + .compatible = "motorola,mapphone-cpcap-usb-phy",
> + },
> + {},
> +};
> +MODULE_DEVICE_TABLE(of, cpcap_usb_phy_id_table);
> +#endif
> +
> +static int cpcap_usb_phy_probe(struct platform_device *pdev)
> +{
> + struct cpcap_phy_ddata *ddata;
> + struct phy *generic_phy;
> + struct phy_provider *phy_provider;
> + struct usb_otg *otg;
> + const struct of_device_id *of_id;
> + int error;
> +
> + of_id = of_match_device(of_match_ptr(cpcap_usb_phy_id_table),
> + &pdev->dev);
> + if (!of_id)
> + return -EINVAL;
> +
> + ddata = devm_kzalloc(&pdev->dev, sizeof(*ddata), GFP_KERNEL);
> + if (!ddata)
> + return -ENOMEM;
> +
> + ddata->reg = dev_get_regmap(pdev->dev.parent, NULL);
> + if (!ddata->reg)
> + return -ENODEV;
> +
> + otg = devm_kzalloc(&pdev->dev, sizeof(*otg), GFP_KERNEL);
> + if (!otg)
> + return -ENOMEM;
> +
> + ddata->dev = &pdev->dev;
> + ddata->phy.dev = ddata->dev;
> + ddata->phy.label = "cpcap_usb_phy";
> + ddata->phy.otg = otg;
> + ddata->phy.type = USB_PHY_TYPE_USB2;
> + INIT_LIST_HEAD(&ddata->irq_list);
> + otg->set_host = cpcap_usb_phy_set_host;
> + otg->set_peripheral = cpcap_usb_phy_set_peripheral;
> + otg->usb_phy = &ddata->phy;
> + mutex_init(&ddata->lock);
> + INIT_DELAYED_WORK(&ddata->detect_work, cpcap_usb_detect);
> + platform_set_drvdata(pdev, ddata);
> +
> + ddata->vusb = devm_regulator_get(&pdev->dev, "vusb");
> + if (IS_ERR(ddata->vusb))
> + return PTR_ERR(ddata->vusb);
> +
> + error = regulator_enable(ddata->vusb);
> + if (error)
> + return error;
Maybe we should create power_on ops and do regulator enable there?
Thanks
Kishon
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
ut them into port node for flexibility.
Won't this break the old dt compatiblity? Making change in dt is fine as long
as older dtb's are still supported.
Thanks
Kishon
>
> Signed-off-by: Chunfeng Yun
> ---
> drivers/phy/phy-mt65xx-usb3.c | 21 +++--
>
g any dependency with the phy tree.
merged the phy patches. Please send a patch updating the MAINTAINERS for the
phy driver.
Thanks
Kishon
>
> Patches based on v4.10-rc1 + first 22 patches from v5. Full
> branch is here[1].
>
> Changes from v7:
> * Dropped set_vbus()
Hi,
On Tuesday 24 January 2017 01:28 AM, Stephen Boyd wrote:
> Quoting Kishon Vijay Abraham I (2017-01-22 00:46:21)
>> Hi,
>>
>> On Saturday 21 January 2017 12:20 AM, Stephen Boyd wrote:
>>> Some USB PHYs need to be told about vbus changing state
>>> expl
struct phy_ops {
> int (*power_on)(struct phy *phy);
> int (*power_off)(struct phy *phy);
> int (*set_mode)(struct phy *phy, enum phy_mode mode);
> + int (*set_vbus)(struct phy *phy, int on);
please avoid adding usb specific ops in generic phy ops.
Thanks
Kishon
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
;
>> Signed-off-by: Icenowy Zheng
>
> Acked-by: Maxime Ripard
merged, thanks!
-Kishon
>
> Thanks,
> Maxime
>
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
ample.
>
> Cc: Wei Xu
> Cc: Guodong Xu
> Cc: Amit Pundir
> Cc: Rob Herring
> Cc: John Youn
> Cc: Douglas Anderson
> Cc: Chen Yu
> Cc: Kishon Vijay Abraham I
> Cc: Felipe Balbi
> Cc: Greg Kroah-Hartman
> Cc: linux-usb@vger.kernel.org
> Signed-off-
un4i_usb_phy_set_mode to force
> end the current session without changing the mode, to fixup the stuck
> state after a babble error.
>
> Signed-off-by: Hans de Goede
merged, thanks.
-Kishon
> ---
> Changes in v2:
> -New patch in v2 of this series replacing the
> "phy-su
nted their own PM.
>>
>> Fixes: 467d5c980709 ("usb: musb: Implement session bit based
>> runtime PM for musb-core")
>> Tested-by: Ladislav Michl
>> Tested-by: Laurent Pinchart
>> Signed-off-by: Tony Lindgren
>
> I would need Kishon's Acked
A-Device keeps to act as
> peripheral.)
> # echo host > /sys/devices/platform/soc/ee080200.usb-phy/role
>
> Signed-off-by: Yoshihiro Shimoda
> Reviewed-by: Peter Chen
merged to phy -next.
Thanks
Kishon
> ---
> This patch is based on the latest linux-phy.git / next bra
Hi,
On Saturday 12 November 2016 04:09 PM, Nicolae Rosia wrote:
> All users are DT-only and it makes no sense to keep
> unused code
Are you sure about this? I still see a bunch of board files in mach-omap2 using
twl4030.
Thanks
Kishon
>
> Signed-off-by: Nicolae Rosia
> ---
e limitation, the da8xx glue implement a
> workaround.
> But to work, the workaround require the VBUS sense and the session end
> comparator to enabled.
> Enable them if the phy is configured in OTG mode.
>
> Signed-off-by: Alexandre Bailon
merged this to phy -next.
Thanks
Kishon
On Thursday 03 November 2016 09:33 PM, Axel Haslam wrote:
> The ohci device name has changed in the board configuraion files,
> hence, change the phy lookup table to match the new name.
>
> Signed-off-by: Axel Haslam
merged, thanks.
-Kishon
> ---
> drivers/phy/phy-da8xx-us
On Friday 04 November 2016 11:04 AM, Sekhar Nori wrote:
> Hi Kishon,
>
> On Thursday 03 November 2016 10:20 PM, Kishon Vijay Abraham I wrote:
>>
>>
>> On Wednesday 02 November 2016 06:14 PM, Axel Haslam wrote:
>>> There is only one ohci on the da8xx series o
Hi,
On Thursday 03 November 2016 10:56 PM, Alexandre Bailon wrote:
> On 11/03/2016 05:34 PM, Kishon Vijay Abraham I wrote:
>> Hi,
>>
>> On Thursday 03 November 2016 08:56 PM, Alexandre Bailon wrote:
>>> The USB PHY is able to operate in OTG, host or peripheral.
>&
On Wednesday 02 November 2016 06:14 PM, Axel Haslam wrote:
> There is only one ohci on the da8xx series of chips,
> so remove the ".0" when creating the phy. Also add
> the "-da8xx" postfix to be consistent across davinci
> usb drivers.
>
> Signed-off-by
+ It should only be defined if the hardware is not capable
> correctly
> + detect the role of USB by using VBUS and ID pin.
>From what I understand from the previous patch, if VBUS sense and the session
end comparator is enabled, the controller can w
back")
> Tested-by: John Youn
>
> Hi Kishon,
>
> Can you take this for 4.9-rc?
sure, merged now.
Thanks
Kishon
>
> Thanks,
> John
>
>
>
>> ---
>> include/linux/phy/phy.h | 7 +++
>> 1 file changed, 7 insertions(+)
>>
>>
for a nop-phy driver.
> This can be further extended to add required features.
>
> Inspired by phy-generic driver in drivers/usb/phy.
>
> Signed-off-by: Vivek Gautam
> Cc: Kishon Vijay Abraham I
> Cc: Felipe Balbi
> ---
>
> Hi Kishon, Felipe,
>
> This patch has
On Monday 19 September 2016 10:12 PM, Kevin Hilman wrote:
> Kishon Vijay Abraham I writes:
>
>> Hi Kevin,
>>
>> On Wednesday 14 September 2016 09:36 PM, Kevin Hilman wrote:
>>> Kishon,
>>>
>>> Martin Blumenstingl writes:
>>>
>>
**
> + * sun4i_usb_force_session_end() - Force the current session to end
> + * by reporting VBus low for 200+ ms
> + * @phy: reference to a sun4i usb phy
> + */
> +void sun4i_usb_phy_force_session_end(struct phy *phy);
Should we include a static
Hi,
On Monday 19 September 2016 01:26 AM, Martin Blumenstingl wrote:
> Hi Kishon,
>
> On Fri, Sep 16, 2016 at 10:19 AM, Kishon Vijay Abraham I
> wrote:
>> Hi,
>>
>> On Friday 09 September 2016 09:44 PM, Martin Blumenstingl wrote:
>>> On Fri, Sep
Hi Kevin,
On Wednesday 14 September 2016 09:36 PM, Kevin Hilman wrote:
> Kishon,
>
> Martin Blumenstingl writes:
>
>> This is a new driver for the USB PHY found in Meson8b and GXBB SoCs.
>>
>> Signed-off-by: Martin Blumenstingl
>> Signed-off-by: Jerom
uot;usb";
status = "disabled";
};
};
This way the driver will be probed only once (the reset can be done during
probe). The phy driver should scan the dt node and for every sub-node it
invokes phy_create?
Thanks
Kishon
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Saturday 10 September 2016 05:48 PM, Kishon Vijay Abraham I wrote:
>
> On Wed, Sep 07, 2016 at 02:35:19PM -0700, Stephen Boyd wrote:
>> The high-speed phy on qcom SoCs is controlled via the ULPI
>> viewport.
>>
>> Cc: Kishon Vijay Abraham I
>>
we can do
> + */
> + if (of_device_is_compatible(np, "rockchip,rk3288-usb")
> + && (NULL != hsotg->phy->ops->reset))
> + hsotg->phy->ops->reset(hsotg->
> + *without specific prior written permission.
> + *
> + * THIS SOFTWARE IS PROVIDED BY THE PROJECT AND CONTRIBUTORS ``AS IS'' AND
> + * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
> + * IMPLIED WARRANTIES OF MERCHANTABILITY AND
Hi,
On Monday 22 August 2016 06:30 PM, Heiko Stübner wrote:
> Am Montag, 22. August 2016, 17:17:41 schrieb Kishon Vijay Abraham I:
>> Hi,
>>
>> On Sunday 21 August 2016 02:02 AM, Randy Li wrote:
>>> It is a hardware bug in RK3288, the only way to solve it is to
>
.power_on = rockchip_usb_phy_power_on,
> .power_off = rockchip_usb_phy_power_off,
> + .reset = rockchip_usb_phy_reset,
why not just reuse the .init ops? reset can be done during initialization right?
Thanks
Kishon
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi,
On Monday 22 August 2016 01:44 PM, Jisheng Zhang wrote:
> + Kishon
>
> Hi Peter, Kishon,
>
> On Mon, 22 Aug 2016 15:29:07 +0800 Peter Chen wrote:
>
>> On Mon, Aug 22, 2016 at 02:39:21PM +0800, Jisheng Zhang wrote:
>>> Hi Peter,
>>>
>>>
t / device / dual-role. For some reason the musb code has
>> 2 all of its own and then there is "enum phy_mode".
>>
>> Anyways let me know if you want a v3 with check-patch warnings
>> fixed.
>
> I see it's somewhat common even in drivers/usb:
>
>
in mainline yet.
>
> Any update?
phy driver is already merged which actually introduced a compilation error. The
fix for it is currently queued in linux-phy -fixes and it should be merged in
this -rc cycle.
I think it would be better if David Lechner re-spins the series re-based on top
of
Rockchip USB 2.0 PHY.
>
> +config PHY_ROCKCHIP_INNO_USB2
> + tristate "Rockchip INNO USB2PHY Driver"
> + depends on ARCH_ROCKCHIP && OF
changed this to
depends on (ARCH_ROCKCHIP || COMPILE_TEST) && OF
and merged it.
Thanks
Kishon
> + select G
On Friday 12 August 2016 08:36 AM, Icenowy Zheng wrote:
> Signed-off-by: Icenowy Zheng
Added "Update sun4i usb phy dt binding documentation to include support for
Allwinner A64 usb phy." and then merged this.
Thanks
Kishon
> ---
> Documentation/devicetree/bindings/phy/su
e.
WARNING: line over 80 characters
#311: FILE: drivers/phy/phy-sun4i-usb.c:794:
+ { .compatible = "allwinner,sun50i-a64-usb-phy", .data =
&sun50i_a64_cfg},
Thanks
Kishon
> ---
> drivers/phy/phy-sun4i-usb.c | 34 --
> 1 file change
_mng_write32(usb3, 0x587e8040);
> +
> + bcm_ns_usb3_mii_mng_write32(usb3, 0x580a21d3);
> +
> + bcm_ns_usb3_mii_mng_write32(usb3, 0x58061003);
> +
> + /* Waiting MII Mgt interface idle */
> + bcm_ns_usb3_mii_mng_wait_idle(usb3);
> +
> + /* Deasserti
On Tuesday 09 August 2016 01:25 AM, Hans de Goede wrote:
> Hi Kishon,
>
> As discussed before, here is a resend now that rc1 is out (and includes
> the new of_usb_get_dr_mode_by_phy helper this patch needs).
>
> Please merge this for 4.9-rcX some of the musb-sunxi glue change
part that adds da8xx-cfgchip.h. The part that removes macros from usb-davinci.h
can go along with the USB patch series.
Thanks
Kishon
> 2 files changed, 153 insertions(+), 22 deletions(-)
> create mode 100644 include/linux/mfd/da8xx-cfgchip.h
>
> diff --git a/include/linux/mfd/da8x
Hi,
On Tuesday 05 July 2016 02:47 AM, Hans de Goede wrote:
> Hi Kishon,
>
> Thanks for merging one of the 2 pending phy-sun4i-usb patches, I see
> that the other one actually has a conflict after merging in
> linux-phy/fixes. So here is a rebased version of it.
>
> Note can
Hi Hans,
On Tuesday 05 July 2016 02:47 AM, Hans de Goede wrote:
> Use the new of_usb_get_dr_mode_by_phy() function to get the dr_mode
This API in linux-phy -next still takes a single argument. This patch can go
probably in the next -rc cycle.
Thanks
Kishon
> from the musb controlle
Hi Bin,
On Monday 27 June 2016 06:17 PM, Kishon Vijay Abraham I wrote:
> Hi,
>
> On Tuesday 10 May 2016 05:09 AM, David Lechner wrote:
>> The initial use for this is for PHYs that have a mode related to USB OTG.
>> There are several SoCs (e.g. TI OMAP and DA8xx) that have
1 - 100 of 1344 matches
Mail list logo
