Re: [PATCH v3 1/2] usb: host: ehci-tegra: Grab the correct UTMI pads reset

2016-05-05 Thread Tuomas Tynkkynen
On 05/04/2016 06:26 PM, Thierry Reding wrote: On Wed, May 04, 2016 at 07:57:10AM -0700, Greg Kroah-Hartman wrote: On Wed, May 04, 2016 at 04:39:59PM +0200, Thierry Reding wrote: From: Thierry Reding There are three EHCI controllers on Tegra SoCs, each with its own reset line. However, the fir

Re: [PATCH v2 2/4] ARM: tegra: Add resets & has-utmi-pad-registers flag to all USB PHYs

2014-07-10 Thread Tuomas Tynkkynen
Thierry, Since Stephen's on a vacation, I'd like to double-check with you that the DT changes looks good. Greg has applied these to the USB tree today. Thanks, Tuomas On 04/07/14 04:09, Tuomas Tynkkynen wrote: Add new properties to all of the Tegra PHYs that are now required ac

Re: [PATCH v2 4/4] USB: PHY: tegra: Call tegra_usb_phy_close only on device removal

2014-07-10 Thread Tuomas Tynkkynen
On 10/07/14 16:48, Felipe Balbi wrote: * PGP Signed by an unknown key Hi, On Fri, Jul 04, 2014 at 04:09:39AM +0300, Tuomas Tynkkynen wrote: tegra_usb_phy_close() is supposed to undo the effects of tegra_usb_phy_init(). It is also currently added as the USB PHY shutdown callback, which is

[PATCH v2 0/4] Tegra USB probe order issue fix

2014-07-03 Thread Tuomas Tynkkynen
is is fixed in patch 4. Thanks, Tuomas. Tuomas Tynkkynen (4): USB: tegra: Add resets & has-utmi-pad-registers flag to the PHY binding ARM: tegra: Add resets & has-utmi-pad-registers flag to all USB PHYs USB: EHCI: tegra: Fix probe order issue leading to broken USB USB: PHY: teg

[PATCH v2 3/4] USB: EHCI: tegra: Fix probe order issue leading to broken USB

2014-07-03 Thread Tuomas Tynkkynen
t fix from this commit, so we'll dev_warn() them, but the driver will still keep probing successfully. Signed-off-by: Tuomas Tynkkynen --- v2 changes: assume we can find the usb1 reset from the PHY DT node, don't fail if it's not found but just issue a warning drivers/usb

[PATCH v2 4/4] USB: PHY: tegra: Call tegra_usb_phy_close only on device removal

2014-07-03 Thread Tuomas Tynkkynen
warnings about unbalanced regulator_disable if the EHCI driver is unbound and bound again at runtime. Signed-off-by: Tuomas Tynkkynen --- v2 changes: none drivers/usb/phy/phy-tegra-usb.c |8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/usb/phy/phy-tegra-usb.c b

[PATCH v2 2/4] ARM: tegra: Add resets & has-utmi-pad-registers flag to all USB PHYs

2014-07-03 Thread Tuomas Tynkkynen
Add new properties to all of the Tegra PHYs that are now required according to the binding. In order to stay compatible with old device trees, the USB drivers will still function without these reset properties but with the old, potentially buggy behaviour. Signed-off-by: Tuomas Tynkkynen --- v2

[PATCH v2 1/4] USB: tegra: Add resets & has-utmi-pad-registers flag to the PHY binding

2014-07-03 Thread Tuomas Tynkkynen
, potentially buggy behaviour. Signed-off-by: Tuomas Tynkkynen --- v2 changes: new patch, didn't exist in v1 .../bindings/usb/nvidia,tegra20-usb-phy.txt|8 1 file changed, 8 insertions(+) diff --git a/Documentation/devicetree/bindings/usb/nvidia,tegra20-usb-phy.t

[PATCH 1/3] reset: Re-export of_reset_control_get

2014-07-01 Thread Tuomas Tynkkynen
Commit b424080a9e086e683ad5fdc624a7cf3c024e0c0f (reset: Add optional resets and stubs) accidentally dropped the declaration of of_reset_control_get from include/linux/reset.h. Add it back to the header. Signed-off-by: Tuomas Tynkkynen --- include/linux/reset.h | 8 1 file changed, 8

[PATCH 2/3] USB: EHCI: tegra: Fix probe order issue leading to broken USB

2014-07-01 Thread Tuomas Tynkkynen
oller again. The really ugly part is that the EHCI controllers don't have a reset control phandle to the 1st controller, so we have to do some device tree groveling to find the phandle to the 1st controller. Signed-off-by: Tuomas Tynkkynen --- drivers/usb/host/ehci-teg

[PATCH 3/3] USB: PHY: tegra: Call tegra_usb_phy_close only on device removal

2014-07-01 Thread Tuomas Tynkkynen
warnings about unbalanced regulator_disable if the EHCI driver is unbound and bound again at runtime. Signed-off-by: Tuomas Tynkkynen --- drivers/usb/phy/phy-tegra-usb.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/usb/phy/phy-tegra-usb.c b/drivers/usb/phy/phy

[PATCH 0/3] Tegra USB probe order issue fix

2014-07-01 Thread Tuomas Tynkkynen
resetted during the probe. Thanks, Tuomas Tuomas Tynkkynen (3): reset: Re-export of_reset_control_get USB: EHCI: tegra: Fix probe order issue leading to broken USB USB: PHY: tegra: Call tegra_usb_phy_close only on device removal drivers/usb/host/ehci-tegra.c | 111

[PATCH] USB: EHCI: tegra: Fix use-after-free in .remove()

2014-06-17 Thread Tuomas Tynkkynen
The tegra_ehci_hcd structure is located in the private space allocated by the core USB code so it must not be accessed after the HCD is freed. Signed-off-by: Tuomas Tynkkynen --- drivers/usb/host/ehci-tegra.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/host

[PATCH 2nd RESEND] Clock changes for Tegra30 USB Host support

2013-08-28 Thread Tuomas Tynkkynen
: Added swarren's Tested-by & Acked-by. Tuomas Tynkkynen (1): clk: tegra30: Don't wait for PLL_U lock bit drivers/clk/tegra/clk-tegra30.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 1.8.1.5 -- To unsubscribe from this list: send the line "unsubscribe linux-us

[PATCH 2nd RESEND] clk: tegra30: Don't wait for PLL_U lock bit

2013-08-28 Thread Tuomas Tynkkynen
The lock bit on PLL_U does not seem to be working correctly and sometimes never gets set when waiting for the PLL to come up. Remove the TEGRA_PLL_USE_LOCK flag to use a constant delay. Signed-off-by: Tuomas Tynkkynen Tested-by: Stephen Warren Acked-by: Stephen Warren --- drivers/clk/tegra

[PATCH RESEND] Clock changes for Tegra30 USB Host support

2013-08-14 Thread Tuomas Tynkkynen
this patch? Tuomas Tynkkynen (1): clk: tegra30: Don't wait for PLL_U lock bit drivers/clk/tegra/clk-tegra30.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 1.8.1.5 -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a me

[PATCH RESEND] clk: tegra30: Don't wait for PLL_U lock bit

2013-08-14 Thread Tuomas Tynkkynen
The lock bit on PLL_U does not seem to be working correctly and sometimes never gets set when waiting for the PLL to come up. Remove the TEGRA_PLL_USE_LOCK flag to use a constant delay. Signed-off-by: Tuomas Tynkkynen --- drivers/clk/tegra/clk-tegra30.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH v3 3/6] usb: phy: tegra: Tegra30 support

2013-08-12 Thread Tuomas Tynkkynen
this will be added in the next patch. The new tegra_phy_soc_config structure is added to describe the differences between the SoCs. Signed-off-by: Tuomas Tynkkynen Tested-by: Stephen Warren Reviewed-by: Stephen Warren --- drivers/usb/phy/phy-tegra-usb.c | 121

[PATCH v3 0/6] USB tree changes for Tegra30 and Tegra114 USB Host support

2013-08-12 Thread Tuomas Tynkkynen
bitmasks to not contain shifted-out bits Changed the order of patches 4 & 5 Patch 5: Don't touch new PHY params under T20 v3 diff: Patch 6: Removed useless cast Added Stephen's Reviewed-by & Tested-by to all patches Tuomas Tynkkynen (6): usb: host: add has_tdi_phy_lpm capab

[PATCH v3 1/6] usb: host: add has_tdi_phy_lpm capability bit

2013-08-12 Thread Tuomas Tynkkynen
erged ("disociate chipidea PHY low power suspend control from hostpc") Inspired-by: Matthieu CASTET Signed-off-by: Tuomas Tynkkynen Acked-by: Alan Stern Tested-by: Stephen Warren Reviewed-by: Stephen Warren --- v2: Add Alan's ack drivers/usb/chipidea/host.c | 1 + drivers/usb/

[PATCH v3 2/6] usb: phy: tegra: Fix wrong PHY parameters

2013-08-12 Thread Tuomas Tynkkynen
set properly Signed-off-by: Tuomas Tynkkynen Tested-by: Stephen Warren Reviewed-by: Stephen Warren --- v2: Change register bitmasks to not contain shifted-out bits drivers/usb/phy/phy-tegra-usb.c | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/drivers

[PATCH v3 4/6] Documentation: New DT parameters for tegra30-usb-phy

2013-08-12 Thread Tuomas Tynkkynen
Document the new device tree parameters for Tegra30 USB PHY. Signed-off-by: Tuomas Tynkkynen Tested-by: Stephen Warren Reviewed-by: Stephen Warren --- .../devicetree/bindings/usb/nvidia,tegra20-usb-phy.txt| 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a

[PATCH v3 6/6] usb: host: tegra: Tegra30 support

2013-08-12 Thread Tuomas Tynkkynen
describe the differences between the SoCs. Signed-off-by: Tuomas Tynkkynen Tested-by: Stephen Warren Reviewed-by: Stephen Warren --- v3: Removed useless cast drivers/usb/host/ehci-tegra.c | 34 +- 1 file changed, 29 insertions(+), 5 deletions(-) diff --git a/drivers

[PATCH v3 5/6] usb: phy: tegra: Program new PHY parameters

2013-08-12 Thread Tuomas Tynkkynen
he optimal value can vary between invidual boards. The boolean property nvidia,xcvr-setup-use-fuses can be used to enable this behaviour. Signed-off-by: Tuomas Tynkkynen Tested-by: Stephen Warren Reviewed-by: Stephen Warren --- v2: Don't touch new PHY params under T20 v2: Change register

Re: [PATCH v2 6/6] usb: host: tegra: Tegra30 support

2013-08-06 Thread Tuomas Tynkkynen
On 08/06/2013 09:35 PM, Sergei Shtylyov wrote: > Hello. > [...] >> >> +match = of_match_device(tegra_ehci_of_match, &pdev->dev); >> +if (!match) { >> +dev_err(&pdev->dev, "Error: No device match found\n"); >> +return -ENODEV; >> +} >> +soc_config = (struct t

[PATCH v2 1/6] usb: host: add has_tdi_phy_lpm capability bit

2013-08-06 Thread Tuomas Tynkkynen
erged ("disociate chipidea PHY low power suspend control from hostpc") Inspired-by: Matthieu CASTET Signed-off-by: Tuomas Tynkkynen Acked-by: Alan Stern --- v2: Add Alan's ack drivers/usb/chipidea/host.c | 1 + drivers/usb/host/ehci-hub.c | 14 +++--- drivers/usb/host/ehci.h

[PATCH v2 2/6] usb: phy: tegra: Fix wrong PHY parameters

2013-08-06 Thread Tuomas Tynkkynen
set properly Signed-off-by: Tuomas Tynkkynen --- v2: Change register bitmasks to not contain shifted-out bits drivers/usb/phy/phy-tegra-usb.c | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/drivers/usb/phy/phy-tegra-usb.c b/drivers/usb/phy/phy-tegra

[PATCH v2 4/6] Documentation: New DT parameters for tegra30-usb-phy

2013-08-06 Thread Tuomas Tynkkynen
Document the new device tree parameters for Tegra30 USB PHY. Signed-off-by: Tuomas Tynkkynen --- .../devicetree/bindings/usb/nvidia,tegra20-usb-phy.txt| 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/usb/nvidia,tegra20

[PATCH v2 0/6] USB tree changes for Tegra30 and Tegra114 USB Host support

2013-08-06 Thread Tuomas Tynkkynen
bitmasks to not contain shifted-out bits Changed the order of patches 4 & 5 Patch 5: Don't touch new PHY params under T20 Tuomas Tynkkynen (6): usb: host: add has_tdi_phy_lpm capability bit usb: phy: tegra: Fix wrong PHY parameters usb: phy: tegra: Tegra30 support Documentation: New

[PATCH v2 3/6] usb: phy: tegra: Tegra30 support

2013-08-06 Thread Tuomas Tynkkynen
this will be added in the next patch. The new tegra_phy_soc_config structure is added to describe the differences between the SoCs. Signed-off-by: Tuomas Tynkkynen --- drivers/usb/phy/phy-tegra-usb.c | 121 +- include/linux/usb/tegra_usb_phy.h | 19 ++ 2

[PATCH v2 6/6] usb: host: tegra: Tegra30 support

2013-08-06 Thread Tuomas Tynkkynen
describe the differences between the SoCs. Signed-off-by: Tuomas Tynkkynen --- drivers/usb/host/ehci-tegra.c | 34 +- 1 file changed, 29 insertions(+), 5 deletions(-) diff --git a/drivers/usb/host/ehci-tegra.c b/drivers/usb/host/ehci-tegra.c index db8031f..c0d1f27

[PATCH v2 5/6] usb: phy: tegra: Program new PHY parameters

2013-08-06 Thread Tuomas Tynkkynen
he optimal value can vary between invidual boards. The boolean property nvidia,xcvr-setup-use-fuses can be used to enable this behaviour. Signed-off-by: Tuomas Tynkkynen --- v2: Don't touch new PHY params under T20 v2: Change register bitmasks to not contain shifted-out bits drivers/usb/phy/

Re: [PATCH] clk: tegra30: Don't wait for PLL_U lock bit

2013-08-05 Thread Tuomas Tynkkynen
On 08/05/2013 09:38 AM, Prashant Gaikwad wrote: > On Thursday 01 August 2013 02:34 AM, Stephen Warren wrote: >> On 07/31/2013 11:42 AM, Tuomas Tynkkynen wrote: >>> The lock bit on PLL_U does not seem to be working correctly and >>> sometimes never gets set when wai

Re: [PATCH 1/6] usb: host: add has_tdi_phy_lpm capability bit

2013-08-02 Thread Tuomas Tynkkynen
On 08/01/2013 11:05 AM, Matthieu CASTET wrote: > Hi, > > Le Wed, 31 Jul 2013 18:41:57 +0100, > Tuomas Tynkkynen a écrit : > >> The has_hostpc capability bit indicates that the host controller has >> the HOSTPC register extensions, but at the same time enables cloc

Re: [PATCH 2/6] usb: phy: tegra: Fix wrong PHY parameters

2013-08-02 Thread Tuomas Tynkkynen
On 08/02/2013 12:09 AM, Stephen Warren wrote: > On 07/31/2013 11:41 AM, Tuomas Tynkkynen wrote: >> Some of the PHY parameters are not set according to the TRMs: >> >> - UTMIP_FS_PREABMLE_J should be set, not cleared >> - UTMIP_XCVR_LSBIAS_SEL should be cleared, not set &

Re: [PATCH 4/6] usb: phy: tegra: Program new PHY parameters

2013-08-02 Thread Tuomas Tynkkynen
On 08/02/2013 12:16 AM, Stephen Warren wrote: > On 07/31/2013 11:42 AM, Tuomas Tynkkynen wrote: >> The Tegra30 TRM recommends configuration of certain PHY parameters for >> optimal quality. Program the following registers based on device tree >> parameters: >> >>

Re: [PATCH 1/2] ARM: DTS: tegra: Add USB entries for Tegra30

2013-08-01 Thread Tuomas Tynkkynen
On 08/01/2013 01:13 AM, Stephen Warren wrote: > On 07/31/2013 11:42 AM, Tuomas Tynkkynen wrote: >> Add device tree entries for the 3 USB controllers and PHYs and >> enable the third controller on Cardhu and Beaver boards. >> >> Fix VBUS regulator entries on Beave

[PATCH v2 1/2] ARM: DTS: tegra: Add USB entries for Tegra30

2013-08-01 Thread Tuomas Tynkkynen
Add device tree entries for the 3 USB controllers and PHYs and enable the third controller on Cardhu and Beaver boards. Fix VBUS regulator entries on Beaver. The GPIO pins were wrong. Also, internal pullups need to be enabled on those pins. Signed-off-by: Tuomas Tynkkynen --- v2: Use internal

[PATCH v2 0/2] Device tree changes for Tegra30 and Tegra114 USB Host support

2013-08-01 Thread Tuomas Tynkkynen
er. Mikko Perttunen (1): ARM: dts: USB for Tegra114 Dalmore Tuomas Tynkkynen (1): ARM: DTS: tegra: Add USB entries for Tegra30 arch/arm/boot/dts/tegra114-dalmore.dts | 9 arch/arm/boot/dts/tegra114.dtsi| 62 arch/arm/boot/dts/tegra30-beaver.

[PATCH v2 2/2] ARM: dts: USB for Tegra114 Dalmore

2013-08-01 Thread Tuomas Tynkkynen
From: Mikko Perttunen Device tree entries for the three EHCI controllers on Tegra114. Enables the the third controller (USB host) on Dalmore. Signed-off-by: Mikko Perttunen --- arch/arm/boot/dts/tegra114-dalmore.dts | 9 + arch/arm/boot/dts/tegra114.dtsi| 62 ++

Re: [PATCH 0/6] USB tree changes for Tegra30 and Tegra114 USB Host support

2013-08-01 Thread Tuomas Tynkkynen
On 08/01/2013 02:22 AM, Stephen Warren wrote: > On 07/31/2013 11:41 AM, Tuomas Tynkkynen wrote: >> Hi all, >> >> Here are the patches for the USB tree to enable USB Host support on Tegra30 >> and >> Tegra114. These are based on my and Mikko's cleanup patch

Re: [PATCH 2/2] ARM: dts: USB for Tegra114 Dalmore

2013-07-31 Thread Tuomas Tynkkynen
Hello, On 31/07/13 21:18, Sergei Shtylyov wrote: Hello. On 07/31/2013 09:42 PM, Tuomas Tynkkynen wrote: From: Mikko Perttunen Device tree entries for the three EHCI controllers on Tegra114. Enables the the third controller (USB host) on Dalmore. I would have done the board patch

[PATCH 0/6] USB tree changes for Tegra30 and Tegra114 USB Host support

2013-07-31 Thread Tuomas Tynkkynen
res as our controller doesn't support those. The rest are changes to our PHY and EHCI drivers to deal with a few changed register addresses and a few additional PHY parameters that need to be set for proper signal quality. Tuomas Tynkkynen (6): usb: host: add has_tdi_phy_lpm capability bit usb:

[PATCH 3/6] usb: phy: tegra: Tegra30 support

2013-07-31 Thread Tuomas Tynkkynen
this will be added in the next patch. The new tegra_phy_soc_config structure is added to describe the differences between the SoCs. Signed-off-by: Tuomas Tynkkynen --- drivers/usb/phy/phy-tegra-usb.c | 121 +- include/linux/usb/tegra_usb_phy.h | 19 ++ 2

[PATCH 4/6] usb: phy: tegra: Program new PHY parameters

2013-07-31 Thread Tuomas Tynkkynen
he optimal value can vary between invidual boards. The boolean property nvidia,xcvr-setup-use-fuses can be used to enable this behaviour. Signed-off-by: Tuomas Tynkkynen --- drivers/usb/phy/phy-tegra-usb.c | 75 +-- include/linux/usb/tegra_usb_phy.h | 4 ++

[PATCH 5/6] Documentation: New DT parameters for tegra30-usb-phy

2013-07-31 Thread Tuomas Tynkkynen
Document the new device tree parameters for Tegra30 USB PHY. Signed-off-by: Tuomas Tynkkynen --- .../devicetree/bindings/usb/nvidia,tegra20-usb-phy.txt| 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/usb/nvidia,tegra20

[PATCH 2/6] usb: phy: tegra: Fix wrong PHY parameters

2013-07-31 Thread Tuomas Tynkkynen
set properly Signed-off-by: Tuomas Tynkkynen --- drivers/usb/phy/phy-tegra-usb.c | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/drivers/usb/phy/phy-tegra-usb.c b/drivers/usb/phy/phy-tegra-usb.c index 01c30ff..936b4a2 100644 --- a/drivers/usb/phy/phy

[PATCH 1/2] ARM: DTS: tegra: Add USB entries for Tegra30

2013-07-31 Thread Tuomas Tynkkynen
regulator entry for that. Signed-off-by: Tuomas Tynkkynen --- arch/arm/boot/dts/tegra30-beaver.dts | 23 +- arch/arm/boot/dts/tegra30-cardhu.dtsi | 9 arch/arm/boot/dts/tegra30.dtsi| 86 +++ 3 files changed, 116 insertions(+), 2 deletions

[PATCH 6/6] usb: host: tegra: Tegra30 support

2013-07-31 Thread Tuomas Tynkkynen
describe the differences between the SoCs. Signed-off-by: Tuomas Tynkkynen --- drivers/usb/host/ehci-tegra.c | 34 +- 1 file changed, 29 insertions(+), 5 deletions(-) diff --git a/drivers/usb/host/ehci-tegra.c b/drivers/usb/host/ehci-tegra.c index db8031f..c0d1f27

[PATCH 0/2] Device tree changes for Tegra30 and Tegra114 USB Host support

2013-07-31 Thread Tuomas Tynkkynen
Hi all, Here's the device tree changes required for USB Host support on Tegra30 and Tegra114. This enables USB Host on the Cardhu's dock connector port and on the single built-in A-ports on Dalmore and Beaver, Mikko Perttunen (1): ARM: dts: USB for Tegra114 Dalmore Tuomas Tynkkynen

[PATCH 2/2] ARM: dts: USB for Tegra114 Dalmore

2013-07-31 Thread Tuomas Tynkkynen
From: Mikko Perttunen Device tree entries for the three EHCI controllers on Tegra114. Enables the the third controller (USB host) on Dalmore. Signed-off-by: Mikko Perttunen --- arch/arm/boot/dts/tegra114-dalmore.dts | 9 + arch/arm/boot/dts/tegra114.dtsi| 62 ++

[PATCH] Clock changes for Tegra30 USB Host support

2013-07-31 Thread Tuomas Tynkkynen
Hi all, This patch is required for USB support on Tegra30 due to a likely hardware bug in the PLL_U oscillator which clocks the USB complex. Tuomas Tynkkynen (1): clk: tegra30: Don't wait for PLL_U lock bit drivers/clk/tegra/clk-tegra30.c | 2 +- 1 file changed, 1 insertion(+), 1 del

[PATCH] clk: tegra30: Don't wait for PLL_U lock bit

2013-07-31 Thread Tuomas Tynkkynen
The lock bit on PLL_U does not seem to be working correctly and sometimes never gets set when waiting for the PLL to come up. Remove the TEGRA_PLL_USE_LOCK flag to use a constant delay. Signed-off-by: Tuomas Tynkkynen --- drivers/clk/tegra/clk-tegra30.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 1/6] usb: host: add has_tdi_phy_lpm capability bit

2013-07-31 Thread Tuomas Tynkkynen
erged ("disociate chipidea PHY low power suspend control from hostpc") Inspired-by: Matthieu CASTET Signed-off-by: Tuomas Tynkkynen --- drivers/usb/chipidea/host.c | 1 + drivers/usb/host/ehci-hub.c | 14 +++--- drivers/usb/host/ehci.h | 1 + 3 files changed, 9 insertions(

[PATCH] usb: phy: tegra: Use switch instead of if-else

2013-07-25 Thread Tuomas Tynkkynen
Use switch() instead of if-else when checking for the PHY type. Signed-off-by: Tuomas Tynkkynen --- Ah :). Here. drivers/usb/phy/phy-tegra-usb.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/usb/phy/phy-tegra-usb.c b/drivers/usb/phy/phy-tegra-usb.c

Re: [PATCH v3 8/9] usb: phy: tegra: Use DT helpers for phy_type

2013-07-25 Thread Tuomas Tynkkynen
Use the new of_usb_get_phy_mode helper function for parsing phy_type from the device tree. Signed-off-by: Tuomas Tynkkynen Reviewed-by: Stephen Warren Tested-by: Stephen Warren --- Here's the version with switch(). drivers/usb/phy/phy-tegra-usb.c | 17 + 1 file change

[PATCH v3 5/9] usb: phy: tegra: Register as an USB PHY.

2013-07-25 Thread Tuomas Tynkkynen
Register the Tegra PHY device instances with the PHY subsystem so that the Tegra EHCI driver can locate a PHY via the standard APIs. Signed-off-by: Tuomas Tynkkynen Reviewed-by: Stephen Warren Tested-by: Stephen Warren --- v2 diff: Do the usb_add_phy_dev as the very last thing in .probe

[PATCH v3 2/9] usb: host: tegra: Remove leftover code

2013-07-25 Thread Tuomas Tynkkynen
safe to do so. Signed-off-by: Tuomas Tynkkynen Reviewed-by: Stephen Warren Tested-by: Stephen Warren --- drivers/usb/host/ehci-tegra.c | 20 +--- 1 file changed, 5 insertions(+), 15 deletions(-) diff --git a/drivers/usb/host/ehci-tegra.c b/drivers/usb/host/ehci-tegra.c index

[PATCH v3 1/9] usb: phy: tegra: Remove unnecessary 'dev' field

2013-07-25 Thread Tuomas Tynkkynen
struct usb_phy already has a field for the device pointer, so this unnecessary field can be removed. Signed-off-by: Tuomas Tynkkynen Reviewed-by: Stephen Warren Tested-by: Stephen Warren --- v3 diff: A whitespace change in v3 of Mikko's regulator patch drivers/usb/phy/phy-tegra-usb.c

[PATCH v3 0/9] Tegra USB cleanup series

2013-07-25 Thread Tuomas Tynkkynen
x27;s regulator patch (just a whitespace change) Added Stephen's Reviewed & Tested-bys & Ack to Patch 4 v2 diff: Patch 5: Do the usb_add_phy_dev as the very last thing in .probe Patch 9: Default to host mode if the property didn't exist Tuomas Tynkkynen (9): usb: ph

[PATCH v3 8/9] usb: phy: tegra: Use DT helpers for phy_type

2013-07-25 Thread Tuomas Tynkkynen
Use the new of_usb_get_phy_mode helper function for parsing phy_type from the device tree. Signed-off-by: Tuomas Tynkkynen Reviewed-by: Stephen Warren Tested-by: Stephen Warren --- drivers/usb/phy/phy-tegra-usb.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a

[PATCH v3 4/9] ARM: tegra: Remove USB platform data

2013-07-25 Thread Tuomas Tynkkynen
USB-related platform data is not used anymore in the Tegra USB drivers, so remove all of it. Signed-off-by: Tuomas Tynkkynen Reviewed-by: Stephen Warren Tested-by: Stephen Warren Acked-by: Stephen Warren --- arch/arm/mach-tegra/tegra.c | 38

[PATCH v3 7/9] usb: phy: tegra: Remove custom PHY locating APIs

2013-07-25 Thread Tuomas Tynkkynen
The Tegra EHCI driver is no longer using these custom functions, so they can be removed. Signed-off-by: Tuomas Tynkkynen Reviewed-by: Stephen Warren Tested-by: Stephen Warren --- drivers/usb/phy/phy-tegra-usb.c | 24 include/linux/usb/tegra_usb_phy.h | 2 -- 2

[PATCH v3 6/9] usb: host: tegra: Locate a PHY via standard API

2013-07-25 Thread Tuomas Tynkkynen
Use devm_get_phy_by_phandle to get a PHY device instead of the custom Tegra functions. Signed-off-by: Tuomas Tynkkynen Reviewed-by: Stephen Warren Tested-by: Stephen Warren --- drivers/usb/host/ehci-tegra.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers

[PATCH v3 3/9] usb: tegra: host: Remove references to plat data

2013-07-25 Thread Tuomas Tynkkynen
Platform data is not used in tegra-ehci anymore, so remove all references to it. Signed-off-by: Tuomas Tynkkynen Reviewed-by: Stephen Warren Tested-by: Stephen Warren --- drivers/usb/host/ehci-tegra.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/usb/host/ehci-tegra.c b

[PATCH v3 9/9] usb: phy: tegra: Use DT helpers for dr_mode

2013-07-25 Thread Tuomas Tynkkynen
Use the new of_usb_get_dr_mode helper function for parsing dr_mode from the device tree. Also replace the usage of the custom tegra_usb_phy_mode enum with the standard enum. Signed-off-by: Tuomas Tynkkynen Reviewed-by: Stephen Warren Tested-by: Stephen Warren --- v2 diff: Default to host mode

Re: [PATCH v2 0/9] Tegra USB cleanup series

2013-07-25 Thread Tuomas Tynkkynen
On 07/25/2013 08:51 PM, Felipe Balbi wrote: > > series doesn't apply on top of Mikko's patches. Please rebase on my > testing branch on kernel.org. Ah, the regulator patch got a v3 after I sent out these. Will do. > > When resending, please put Stephen's reviewed-by, tested-by and acked-by > i

[PATCH v2 3/9] usb: tegra: host: Remove references to plat data

2013-07-15 Thread Tuomas Tynkkynen
Platform data is not used in tegra-ehci anymore, so remove all references to it. Signed-off-by: Tuomas Tynkkynen --- drivers/usb/host/ehci-tegra.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/usb/host/ehci-tegra.c b/drivers/usb/host/ehci-tegra.c index 06e8feb..a208cea

[PATCH v2 5/9] usb: phy: tegra: Register as an USB PHY.

2013-07-15 Thread Tuomas Tynkkynen
Register the Tegra PHY device instances with the PHY subsystem so that the Tegra EHCI driver can locate a PHY via the standard APIs. Signed-off-by: Tuomas Tynkkynen --- drivers/usb/phy/phy-tegra-usb.c | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers/usb/phy/phy

[PATCH v2 1/9] usb: phy: tegra: Remove unnecessary 'dev' field

2013-07-15 Thread Tuomas Tynkkynen
struct usb_phy already has a field for the device pointer, so this unnecessary field can be removed. Signed-off-by: Tuomas Tynkkynen --- drivers/usb/phy/phy-tegra-usb.c | 27 +++ include/linux/usb/tegra_usb_phy.h | 1 - 2 files changed, 15 insertions(+), 13 deletions

[PATCH v2 2/9] usb: host: tegra: Remove leftover code

2013-07-15 Thread Tuomas Tynkkynen
safe to do so. Signed-off-by: Tuomas Tynkkynen --- drivers/usb/host/ehci-tegra.c | 20 +--- 1 file changed, 5 insertions(+), 15 deletions(-) diff --git a/drivers/usb/host/ehci-tegra.c b/drivers/usb/host/ehci-tegra.c index 14c1f35..06e8feb 100644 --- a/drivers/usb/host/ehci

[PATCH v2 4/9] ARM: tegra: Remove USB platform data

2013-07-15 Thread Tuomas Tynkkynen
USB-related platform data is not used anymore in the Tegra USB drivers, so remove all of it. Signed-off-by: Tuomas Tynkkynen --- arch/arm/mach-tegra/tegra.c | 38 + include/linux/platform_data/tegra_usb.h | 32 --- include

[PATCH v2 8/9] usb: phy: tegra: Use DT helpers for phy_type

2013-07-15 Thread Tuomas Tynkkynen
Use the new of_usb_get_phy_mode helper function for parsing phy_type from the device tree. Signed-off-by: Tuomas Tynkkynen --- drivers/usb/phy/phy-tegra-usb.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/usb/phy/phy-tegra-usb.c b/drivers/usb/phy/phy

[PATCH v2 9/9] usb: phy: tegra: Use DT helpers for dr_mode

2013-07-15 Thread Tuomas Tynkkynen
Use the new of_usb_get_dr_mode helper function for parsing dr_mode from the device tree. Also replace the usage of the custom tegra_usb_phy_mode enum with the standard enum. Signed-off-by: Tuomas Tynkkynen --- drivers/usb/phy/phy-tegra-usb.c | 24 include/linux/usb

[PATCH v2 7/9] usb: phy: tegra: Remove custom PHY locating APIs

2013-07-15 Thread Tuomas Tynkkynen
The Tegra EHCI driver is no longer using these custom functions, so they can be removed. Signed-off-by: Tuomas Tynkkynen --- drivers/usb/phy/phy-tegra-usb.c | 24 include/linux/usb/tegra_usb_phy.h | 2 -- 2 files changed, 26 deletions(-) diff --git a/drivers/usb/phy

[PATCH v2 6/9] usb: host: tegra: Locate a PHY via standard API

2013-07-15 Thread Tuomas Tynkkynen
Use devm_get_phy_by_phandle to get a PHY device instead of the custom Tegra functions. Signed-off-by: Tuomas Tynkkynen --- drivers/usb/host/ehci-tegra.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/usb/host/ehci-tegra.c b/drivers/usb/host/ehci-tegra.c

[PATCH v2 0/9] Tegra USB cleanup series

2013-07-15 Thread Tuomas Tynkkynen
s the very last thing in .probe Patch 9: Default to host mode if the property didn't exist Tuomas Tynkkynen (9): usb: phy: tegra: Remove unnecessary 'dev' field usb: host: tegra: Remove leftover code usb: tegra: host: Remove references to plat data ARM: tegra: Remove USB

[PATCH 6/9] usb: host: tegra: Locate a PHY via standard API

2013-06-28 Thread Tuomas Tynkkynen
Use devm_get_phy_by_phandle to get a PHY device instead of the custom Tegra functions. Signed-off-by: Tuomas Tynkkynen --- drivers/usb/host/ehci-tegra.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/usb/host/ehci-tegra.c b/drivers/usb/host/ehci-tegra.c

[PATCH 7/9] usb: phy: tegra: Remove custom PHY locating APIs

2013-06-28 Thread Tuomas Tynkkynen
The Tegra EHCI driver is no longer using these custom functions, so they can be removed. Signed-off-by: Tuomas Tynkkynen --- drivers/usb/phy/phy-tegra-usb.c | 24 include/linux/usb/tegra_usb_phy.h | 2 -- 2 files changed, 26 deletions(-) diff --git a/drivers/usb/phy

[PATCH 2/9] usb: host: tegra: Remove leftover code

2013-06-28 Thread Tuomas Tynkkynen
safe to do so. Signed-off-by: Tuomas Tynkkynen --- drivers/usb/host/ehci-tegra.c | 20 +--- 1 file changed, 5 insertions(+), 15 deletions(-) diff --git a/drivers/usb/host/ehci-tegra.c b/drivers/usb/host/ehci-tegra.c index 14c1f35..06e8feb 100644 --- a/drivers/usb/host/ehci

[PATCH 4/9] ARM: tegra: Remove USB platform data

2013-06-28 Thread Tuomas Tynkkynen
USB-related platform data is not used anymore in the Tegra USB drivers, so remove all of it. Signed-off-by: Tuomas Tynkkynen --- arch/arm/mach-tegra/tegra.c | 38 + include/linux/platform_data/tegra_usb.h | 32 --- include

[PATCH 9/9] usb: phy: tegra: Use DT helpers for dr_mode

2013-06-28 Thread Tuomas Tynkkynen
Use the new of_usb_get_dr_mode helper function for parsing dr_mode from the device tree. Also replace the usage of the custom tegra_usb_phy_mode enum with the standard enum. Signed-off-by: Tuomas Tynkkynen --- drivers/usb/phy/phy-tegra-usb.c | 20 include/linux/usb

[PATCH 3/9] usb: tegra: host: Remove references to plat data

2013-06-28 Thread Tuomas Tynkkynen
Platform data is not used in tegra-ehci anymore, so remove all references to it. Signed-off-by: Tuomas Tynkkynen --- drivers/usb/host/ehci-tegra.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/usb/host/ehci-tegra.c b/drivers/usb/host/ehci-tegra.c index 06e8feb..a208cea

[PATCH 1/9] usb: phy: tegra: Remove unnecessary 'dev' field

2013-06-28 Thread Tuomas Tynkkynen
struct usb_phy already has a field for the device pointer, so this unnecessary field can be removed. Signed-off-by: Tuomas Tynkkynen --- drivers/usb/phy/phy-tegra-usb.c | 27 +++ include/linux/usb/tegra_usb_phy.h | 1 - 2 files changed, 15 insertions(+), 13 deletions

[PATCH 8/9] usb: phy: tegra: Use DT helpers for phy_type

2013-06-28 Thread Tuomas Tynkkynen
Use the new of_usb_get_phy_mode helper function for parsing phy_type from the device tree. Signed-off-by: Tuomas Tynkkynen --- drivers/usb/phy/phy-tegra-usb.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/usb/phy/phy-tegra-usb.c b/drivers/usb/phy/phy

[PATCH 5/9] usb: phy: tegra: Register as an USB PHY.

2013-06-28 Thread Tuomas Tynkkynen
Register the Tegra PHY device instances with the PHY subsystem so that the Tegra EHCI driver can locate a PHY via the standard APIs. Signed-off-by: Tuomas Tynkkynen --- drivers/usb/phy/phy-tegra-usb.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/usb/phy/phy-tegra

[PATCH 0/9] Tegra USB cleanup series

2013-06-28 Thread Tuomas Tynkkynen
Hi, Here's a few cleanup patches for the Tegra USB drivers, to be applied on top of Mikko's two patch sets. It mostly deals with removing all usage of platform data and using standard helpers and enums instead of Tegra-specific ones. Tuomas Tynkkynen (9): usb: phy: tegra: Remove u