depmod warning: unknown symbol usb_stor_sense_invalidCDB in 5.4-rc1

2019-09-30 Thread Stefan Wahren
Hi, during make modules_install for arm/multi_v7_defconfig on current Linux 5.4-rc1, i'm getting the following warnings: depmod: WARNING: /media/stefan/rootfs//lib/modules/5.4.0-rc1-6-g4a80125-dirty/kernel/drivers/usb/storage/uas.ko needs unknown symbol usb_stor_sense_invalidCDB depmod: WARNI

Re: usb: dwc2: RODATA_FULL_DEFAULT_ENABLED causes kernel oops

2019-05-29 Thread Stefan Wahren
Hi Minas, hi Felipe, Am 26.05.19 um 21:58 schrieb Stefan Wahren: > Hi, > > Am 26.05.19 um 12:44 schrieb Antti Seppälä: >> Hello. >> >> This is just a shot in the dark but have you tried to apply DMA cache >> alignment issue fix [1] as a third workaround alternati

Re: usb: dwc2: RODATA_FULL_DEFAULT_ENABLED causes kernel oops

2019-05-26 Thread Stefan Wahren
Hi, Am 26.05.19 um 12:44 schrieb Antti Seppälä: > > Hello. > > This is just a shot in the dark but have you tried to apply DMA cache > alignment issue fix [1] as a third workaround alternative? > If it helps the fix should be merged upstream. yes. After applying Martin's patch, i wasn't able to r

usb: dwc2: RODATA_FULL_DEFAULT_ENABLED causes kernel oops

2019-05-26 Thread Stefan Wahren
Hi, i want to remind about an issue which was originally reported by Wayne Piekarski [1]. I'm able to reproduce this oops with Mainline Linux 5.0.2 on a Raspberry Pi 3B+ (arm64/defconfig) and according to Jan Kratochvil [2] this applies to 5.1.0 and 5.2.0. The crash is reproducible since commit c

lan78xx: About 8000 usb interrupts per second when idle

2019-04-09 Thread Stefan Wahren
Hi Minas, Am 09.04.19 um 08:54 schrieb Jisheng Zhang: > On Mon, 8 Apr 2019 16:05:51 +0800 Jisheng Zhang wrote: > >> Hi Stefan, >> >> On Mon, 8 Apr 2019 09:57:14 +0200 Stefan Wahren wrote: >> >>> >>> Hi Jisheng, >>> >>> >>&

Re: [BUG] mt76x0u: Probing issues on Raspberry Pi 3 B+

2019-03-03 Thread Stefan Wahren
Hi, > Stanislaw Gruszka hat am 20. Februar 2019 um 17:32 > geschrieben: > > > On Wed, Feb 20, 2019 at 05:22:18PM +0100, Lorenzo Bianconi wrote: > > > On Wed, Feb 20, 2019 at 02:22:08PM +0100, Lorenzo Bianconi wrote: > > > > > On Tue, Feb 19, 2019 at 01:19:26PM +0100, Felix Fietkau wrote: > > >

Re: [PATCH] usb: dwc2: suppress confusing warnings on BCM2835

2019-03-01 Thread Stefan Wahren
Hi Minas, sorry for the delay, i was too busy with other issues. > Minas Harutyunyan hat am 21. Februar 2019 um > 08:34 geschrieben: > > > Hi Stefan, > > On 2/19/2019 10:23 PM, Stefan Wahren wrote: > > According to the BCM2835 datasheet the used Synopsys IP isn&#

[PATCH] usb: dwc2: suppress confusing warnings on BCM2835

2019-02-19 Thread Stefan Wahren
8.usb: dwc2_check_params: Invalid parameter besl=1 dwc2 3f98.usb: dwc2_check_params: Invalid parameter hird_threshold_en=1 Signed-off-by: Stefan Wahren --- drivers/usb/dwc2/params.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/par

Re: [BUG] mt76x0u: Probing issues on Raspberry Pi 3 B+

2019-02-19 Thread Stefan Wahren
Am 19.02.19 um 11:59 schrieb Stanislaw Gruszka: > On Mon, Feb 18, 2019 at 11:19:40PM +0100, Stefan Wahren wrote: >> Hi, >> >>> Stanislaw Gruszka hat am 18. Februar 2019 um 14:52 >>> geschrieben: >>> >>> >>> On Sat, Feb 16, 2019 at 08

Re: [BUG] mt76x0u: Probing issues on Raspberry Pi 3 B+

2019-02-18 Thread Stefan Wahren
Hi, > Stanislaw Gruszka hat am 18. Februar 2019 um 14:52 > geschrieben: > > > On Sat, Feb 16, 2019 at 08:17:07PM +0100, Stefan Wahren wrote: > > this is a misunderstanding. The warning is about memory alignment to 32 bit > > addresses, not about page align

Re: [BUG] mt76x0u: Probing issues on Raspberry Pi 3 B+

2019-02-16 Thread Stefan Wahren
Hi Stanislaw, > Stanislaw Gruszka hat am 16. Februar 2019 um 15:07 > geschrieben: > > > On Sat, Feb 16, 2019 at 12:05:18PM +0100, Stefan Wahren wrote: > > sorry for the delay, but i do this all in my spare time. > > Stefan, thanks for sacrifing your spare time f

Re: [BUG] mt76x0u: Probing issues on Raspberry Pi 3 B+

2019-02-16 Thread Stefan Wahren
Hi Stanislaw, > Stanislaw Gruszka hat am 15. Februar 2019 um 08:12 > geschrieben: > > > On Thu, Feb 14, 2019 at 10:48:15AM +0100, Stefan Wahren wrote: > > Hi Stanislaw, > > > > Am 14.02.19 um 10:25 schrieb Stanislaw Gruszka: > > > On Thu, Feb 14, 201

Re: [BUG] mt76x0u: Probing issues on Raspberry Pi 3 B+

2019-02-14 Thread Stefan Wahren
Hi Stanislaw, Am 14.02.19 um 10:25 schrieb Stanislaw Gruszka: > On Thu, Feb 14, 2019 at 07:49:57AM +0100, Stefan Wahren wrote: >> Hi Stanislaw, >> >>> Stanislaw Gruszka hat am 12. Februar 2019 um 10:30 >>> geschrieben: >>> >>> >>> >

Re: [BUG] mt76x0u: Probing issues on Raspberry Pi 3 B+

2019-02-13 Thread Stefan Wahren
Hi Stanislaw, > Stanislaw Gruszka hat am 12. Februar 2019 um 10:30 > geschrieben: > > > > In usb_sg_init() urb->num_sgs is set 0 for sg_tablesize = 0 controllers. > In mt76 we set urb->num_sgs to 1. I thought it is fine, but now I think > this is bug. We can fix that without changing allocati

Re: [BUG] mt76x0u: Probing issues on Raspberry Pi 3 B+

2019-02-12 Thread Stefan Wahren
Hi, > Lorenzo Bianconi hat am 11. Februar 2019 um > 16:57 geschrieben: > > > > > > Compiling the mainline kernel with arm/multi_v7_defconfig it works. > > Using the same kernel but with arm64/defconfig doesn't work. But i don't > > think this is a 32/64 bit issue. The arm64 defconfig is much

[BUG] mt76x0u: Probing issues on Raspberry Pi 3 B+

2019-02-11 Thread Stefan Wahren
AM +0100, Lorenzo Bianconi wrote: >>>>>>>> On Sat, Feb 09, 2019 at 09:29:05PM +0100, Stefan Wahren wrote: >>>>>>>>>> could you please test the following series: >>>>>>>>>> https://patchwork.kernel.org/cover/1076

[BUG] mt76x0u: Probing issues on Raspberry Pi 3 B+

2019-02-11 Thread Stefan Wahren
Hi Lorenzo, Am 11.02.19 um 12:06 schrieb Lorenzo Bianconi: >> Hi, >> >> Am 11.02.19 um 11:04 schrieb Lorenzo Bianconi: >>>> On Sun, Feb 10, 2019 at 11:22:25AM +0100, Lorenzo Bianconi wrote: >>>>>> On Sat, Feb 09, 2019 at 09:29:05PM +0100, Stefan

Re: [BUG] mt76x0u: Probing issues on Raspberry Pi 3 B+

2019-02-11 Thread Stefan Wahren
Hi, Am 11.02.19 um 11:04 schrieb Lorenzo Bianconi: >> On Sun, Feb 10, 2019 at 11:22:25AM +0100, Lorenzo Bianconi wrote: >>>> On Sat, Feb 09, 2019 at 09:29:05PM +0100, Stefan Wahren wrote: >>>>>> could you please test the following series: >>>&g

Re: [BUG] mt76x0u: Probing issues on Raspberry Pi 3 B+

2019-02-11 Thread Stefan Wahren
Hi, Am 11.02.19 um 08:50 schrieb Stanislaw Gruszka: > On Sun, Feb 10, 2019 at 05:52:30PM +0100, Lorenzo Bianconi wrote: >> Anyway we will need to avoid SG since dwc_otg controller does not support it this isn't correct. AFAIK the dwc2 host driver doesn't implement it, which doesn't mean the contr

Re: [BUG] mt76x0u: Probing issues on Raspberry Pi 3 B+

2019-02-10 Thread Stefan Wahren
Hi, > Stanislaw Gruszka hat am 10. Februar 2019 um 10:29 > geschrieben: > > > On Sat, Feb 09, 2019 at 07:46:37PM +0100, Lorenzo Bianconi wrote: > > > as already reported here [1], that there are probing issues of mt76 using > > > TP-Link Archer T2UH (wifi USB dongle) on Raspberry Pi 3 B+. > >

Re: [BUG] mt76x0u: Probing issues on Raspberry Pi 3 B+

2019-02-09 Thread Stefan Wahren
Hi Lorenzo, > Lorenzo Bianconi hat am 9. Februar 2019 um > 21:33 geschrieben: > > > > > > Hi Lorenzo, > > > > > Lorenzo Bianconi hat am 9. Februar 2019 um > > > 19:46 geschrieben: > > > > > > > > > > > > > > Hi, > > > > > > > > as already reported here [1], that there are probing issues of m

Re: [BUG] mt76x0u: Probing issues on Raspberry Pi 3 B+

2019-02-09 Thread Stefan Wahren
Hi Lorenzo, > Lorenzo Bianconi hat am 9. Februar 2019 um > 19:46 geschrieben: > > > > > > Hi, > > > > as already reported here [1], that there are probing issues of mt76 using > > TP-Link Archer T2UH (wifi USB dongle) on Raspberry Pi 3 B+. > > > > I retested it with recent linux-next 20190208

[BUG] mt76x0u: Probing issues on Raspberry Pi 3 B+

2019-02-09 Thread Stefan Wahren
Hi, as already reported here [1], that there are probing issues of mt76 using TP-Link Archer T2UH (wifi USB dongle) on Raspberry Pi 3 B+. I retested it with recent linux-next 20190208 (aarch64 defconfig + enabling mt76 driver) and got the following output after plugin the wifi dongle: [ 29.7

mt76x0: probing issues on Raspberry Pi

2019-01-29 Thread Stefan Wahren
Hi, recently i discovered a bug report about probing issues of the mt76x0 driver using T2U Archer on the Raspberry Pi 3 B (Linux 4.19.14, Aarch64) [1]. Also i tried a T2UH Archer on my Raspberry Pi 3 B+ with a recent Linux-Next and i'm getting the following output: Vendor request req:07 off:0404

Re: [PATCH v3 1/3] usb: chipidea: imx: support configuring for active low oc signal

2018-12-04 Thread Stefan Wahren
Am 04.12.18 um 09:52 schrieb Uwe Kleine-König: > Hello Stefan, > > On Tue, Dec 04, 2018 at 09:40:26AM +0100, Stefan Wahren wrote: >> Am 04.12.18 um 09:31 schrieb Uwe Kleine-König: >>> The status quo on i.MX6 is that if "over-current-active-high" is >&g

Re: [PATCH v3 1/3] usb: chipidea: imx: support configuring for active low oc signal

2018-12-04 Thread Stefan Wahren
Hi Uwe, Am 04.12.18 um 09:31 schrieb Uwe Kleine-König: > The status quo on i.MX6 is that if "over-current-active-high" is > specified in the device tree this is configured as expected. If > the property is missing polarity isn't changed and so the > polarity is kept as setup by the bootloader. Res

[PATCH] net: smsc95xx: Fix MTU range

2018-11-08 Thread Stefan Wahren
("net: use core MTU range checking in USB NIC drivers") Signed-off-by: Stefan Wahren --- drivers/net/usb/smsc95xx.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/usb/smsc95xx.c b/drivers/net/usb/smsc95xx.c index 262e7a3..5974478 100644 --- a/drivers/net/usb/smsc95x

Re: [PATCH RFC] usb: dwc2: power off during shutdown

2018-09-05 Thread Stefan Wahren
Hi Minas, > Minas Harutyunyan hat am 5. September 2018 > um 10:37 geschrieben: > > > Hi Stefan, > > On 9/1/2018 1:55 PM, Stefan Wahren wrote: > > Currently USB consumes a lot of power after shutting down a Raspberry Pi 3 > > (example setup with Ethernet an

[PATCH V2 3/4 next] net: lan78xx: Switch to SPDX identifier

2018-09-04 Thread Stefan Wahren
Adopt the SPDX license identifier headers to ease license compliance management. Signed-off-by: Stefan Wahren --- drivers/net/usb/lan78xx.c | 14 +- drivers/net/usb/lan78xx.h | 14 +- 2 files changed, 2 insertions(+), 26 deletions(-) diff --git a/drivers/net/usb

[PATCH V2 0/4 next] net: lan78xx: Minor improvements

2018-09-04 Thread Stefan Wahren
This patch series contains some minor improvements for the lan78xx driver. Changes in V2: - Keep Copyright comment as multi-line - Add Raghuram's Reviewed-by Stefan Wahren (4): net: lan78xx: Bail out if lan78xx_get_endpoints fails net: lan78xx: Drop unnecessary strcpy in lan78xx_probe

[PATCH V2 1/4 next] net: lan78xx: Bail out if lan78xx_get_endpoints fails

2018-09-04 Thread Stefan Wahren
We need to bail out if lan78xx_get_endpoints() fails, otherwise the result is overwritten. Fixes: 55d7de9de6c3 ("Microchip's LAN7800 family USB 2/3 to 10/100/1000 Ethernet") Signed-off-by: Stefan Wahren Reviewed-by: Raghuram Chary Jallipalli --- drivers/net/usb/lan78xx.c |

[PATCH V2 4/4 next] net: lan78xx: Make declaration style consistent

2018-09-04 Thread Stefan Wahren
This patch makes some declaration more consistent. Signed-off-by: Stefan Wahren Reviewed-by: Raghuram Chary Jallipalli --- drivers/net/usb/lan78xx.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c index

[PATCH V2 2/4 next] net: lan78xx: Drop unnecessary strcpy in lan78xx_probe

2018-09-04 Thread Stefan Wahren
There is no need for this strcpy because alloc_etherdev() already does this job. Signed-off-by: Stefan Wahren Reviewed-by: Raghuram Chary Jallipalli --- drivers/net/usb/lan78xx.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c index

Re: [PATCH 3/4 next] net: lan78xx: Switch to SPDX identifier

2018-09-04 Thread Stefan Wahren
Hi Raghu, Am 04.09.2018 um 06:29 schrieb raghuramchary.jallipa...@microchip.com: >> +// SPDX-License-Identifier: GPL-2.0+ >> +/* Copyright (C) 2015 Microchip Technology */ > Can we merge both in single comment line? i don't think we can do this. I'm simply following this guideline [1]. How abou

[PATCH 1/4 next] net: lan78xx: Bail out if lan78xx_get_endpoints fails

2018-09-03 Thread Stefan Wahren
We need to bail out if lan78xx_get_endpoints() fails, otherwise the result is overwritten. Fixes: 55d7de9de6c3 ("Microchip's LAN7800 family USB 2/3 to 10/100/1000 Ethernet") Signed-off-by: Stefan Wahren --- drivers/net/usb/lan78xx.c | 5 + 1 file changed, 5 insertions(+

[PATCH 0/4 next] net: lan78xx: Minor improvements

2018-09-03 Thread Stefan Wahren
This patch series contains some minor improvements for the lan78xx driver. Stefan Wahren (4): net: lan78xx: Bail out if lan78xx_get_endpoints fails net: lan78xx: Drop unnecessary strcpy in lan78xx_probe net: lan78xx: Switch to SPDX identifier net: lan78xx: Make declaration style

[PATCH 3/4 next] net: lan78xx: Switch to SPDX identifier

2018-09-03 Thread Stefan Wahren
Adopt the SPDX license identifier headers to ease license compliance management. Signed-off-by: Stefan Wahren --- drivers/net/usb/lan78xx.c | 18 ++ drivers/net/usb/lan78xx.h | 18 ++ 2 files changed, 4 insertions(+), 32 deletions(-) diff --git a/drivers/net/usb

[PATCH 2/4 next] net: lan78xx: Drop unnecessary strcpy in lan78xx_probe

2018-09-03 Thread Stefan Wahren
There is no need for this strcpy because alloc_etherdev() already does this job. Signed-off-by: Stefan Wahren --- drivers/net/usb/lan78xx.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c index 3f70b94..3d505c2 100644 --- a/drivers/net

[PATCH 4/4 next] net: lan78xx: Make declaration style consistent

2018-09-03 Thread Stefan Wahren
This patch makes some declaration more consistent. Signed-off-by: Stefan Wahren --- drivers/net/usb/lan78xx.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c index a6e88a4..143091a 100644 --- a/drivers/net

[PATCH RFC] usb: dwc2: power off during shutdown

2018-09-01 Thread Stefan Wahren
: 2.090 W Signed-off-by: Stefan Wahren --- drivers/usb/dwc2/platform.c | 31 +++ 1 file changed, 11 insertions(+), 20 deletions(-) diff --git a/drivers/usb/dwc2/platform.c b/drivers/usb/dwc2/platform.c index 9a53a58..eeba40a 100644 --- a/drivers/usb/dwc2/platform.c

dwc2: scatter-gather support?

2018-07-29 Thread Stefan Wahren
Hi, if i connect a UAS capable storage device to the Raspberry Pi, i'm getting the following output on 4.18rc: The driver for the USB controller dwc2_hsotg does not support scatter-gather which is required by the UAS driver. Please try an other USB controller if you wish to use UAS

Re: dwc2: enumeration issue with audio dongle connected to USB hub

2018-06-16 Thread Stefan Wahren
Hi, > Stefan Wahren hat am 2. Mai 2018 um 18:49 > geschrieben: > > > Hi Minas, > > > Minas Harutyunyan hat am 2. Mai 2018 um > > 10:54 geschrieben: > > > > > > Hi, > > > > On 4/27/2018 10:03 AM, Stefan Wahren wrote: > > &

Re: [PATCH] usb: gadget: dwc2: fix memory leak in gadget_init()

2018-05-24 Thread Stefan Wahren
Hi Grigor, > Grigor Tovmasyan hat am 24. Mai 2018 um 16:22 > geschrieben: > > > Freed allocated request for ep0 to prevent memory leak in case when > dwc2_driver_probe() failed. > > Signed-off-by: Grigor Tovmasyan > Cc: Stefan Wahren > Cc: Marek Szyprowski

Re: [PATCH v1 0/2] usb: dwc2: gadget: Fixes for LPM

2018-05-07 Thread Stefan Wahren
:31 PM, Simon Shields wrote: Hi all, On 10/04/2018 10:21 PM, Grigor Tovmasyan wrote: Here are two little fixes for LPM feature. First one is coverity warning fix. The Second one was asserted by Stefan Wahren. Changes from version 0: 1/2: - Instead of converting parameter in the

[PATCH] usb: dwc2: debugfs: Don't touch RX FIFO during register dump

2018-05-04 Thread Stefan Wahren
kab Fixes: 563cf017c443 ("usb: dwc2: debugfs: add support for complete register dump") Signed-off-by: Stefan Wahren --- drivers/usb/dwc2/debugfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/dwc2/debugfs.c b/drivers/usb/dwc2/debugfs.c index 58c691f..

Re: dwc2: enumeration issue with audio dongle connected to USB hub

2018-05-02 Thread Stefan Wahren
Hi Minas, > Minas Harutyunyan hat am 2. Mai 2018 um > 10:54 geschrieben: > > > Hi, > > On 4/27/2018 10:03 AM, Stefan Wahren wrote: > > Hi, > > during my tests with a Raspberry Pi 2 B with an C-Media audio dongle > > connected to a powered USB hub, i no

net: smsc95xx: aligment issues

2018-04-28 Thread Stefan Wahren
Hi, after connecting a Raspberry Pi 1 B to my local network i'm seeing aligment issues under /proc/cpu/alignment: User: 0 System: 142 (_decode_session4+0x12c/0x3c8) Skipped:0 Half: 0 Word: 0 DWord: 127 Multi: 15 User faults:2 (fi

dwc2: enumeration issue with audio dongle connected to USB hub

2018-04-26 Thread Stefan Wahren
Hi, during my tests with a Raspberry Pi 2 B with an C-Media audio dongle connected to a powered USB hub, i noticed the enumeration errors below (the device gets finally ernumerated). I tested yesterdays linux-next, 4.17-rc2 and 4.14 but all of them show this behavior, if i plugin the audio dongl

Re: [PATCH] usb: dwc2: gadget: Fix memory leak in dwc2_gadget_init()

2018-04-23 Thread Stefan Wahren
Am 23.04.2018 um 09:05 schrieb Grigor Tovmasyan: Hi Stefan, On 4/18/2018 1:11 AM, Stefan Wahren wrote: Hi Grigor, Grigor Tovmasyan hat am 16. April 2018 um 12:16 geschrieben: In dwc2_gadget_init() we allocate EP0 request via dwc2_hsotg_ep_alloc_request(). After that there are

Re: [PATCH] usb: dwc2: gadget: Fix memory leak in dwc2_gadget_init()

2018-04-17 Thread Stefan Wahren
Hi Grigor, > Grigor Tovmasyan hat am 16. April 2018 um > 12:16 geschrieben: > > > In dwc2_gadget_init() we allocate EP0 request via > dwc2_hsotg_ep_alloc_request(). After that there are > usb_add_gadget_udc() call and if it failed, then > ctrl_req will not be freed and will cause memory leak.

Re: dwc2: Memory leak in dwc2_gadget_init

2018-04-09 Thread Stefan Wahren
Hi Grigor, > Grigor Tovmasyan hat am 9. April 2018 um > 18:42 geschrieben: > > > Hi Stefan, > > On 4/2/2018 12:59 PM, Stefan Wahren wrote: > > Hi Minas, > > > > i noticed that in opposite to all allocations in dwc2_gadget_init() the > > functi

Re: [PATCH 0/2] usb: dwc2: gadget: Fixes for LPM

2018-04-03 Thread Stefan Wahren
Hi Grigor, Am 03.04.2018 um 13:21 schrieb Grigor Tovmasyan: Here are two little fixes for LPM feature. First one is coverity warning fix. The Second one was asserted by Stefan Wahren. AFAIK Minas Harutyunyan is the new maintainer of dwc2. So this series should go to him. Regards Stefan

Re: [PATCH] usb: core: phy: Fix usb_phy_roothub_add_phy if GENERIC_PHY=n

2018-04-02 Thread Stefan Wahren
Hi Martin, > Martin Blumenstingl hat am 31. März 2018 > um 22:12 geschrieben: > > > Hello Stefan, > > On Sat, Mar 31, 2018 at 9:28 PM, Stefan Wahren wrote: > > If the generic PHY support is disabled the stub of devm_of_phy_get_by_index > > returns ENOSY

Re: dwc2: Confusing warnings in next-20180327 on Raspberry Pi

2018-04-02 Thread Stefan Wahren
Hi Grigor, > Grigor Tovmasyan hat am 2. April 2018 um > 18:00 geschrieben: > > > Hi Stefan, > > On 4/2/2018 7:47 PM, Stefan Wahren wrote: > > Hi Minas, > > > > in linux-next-20180327 i will get the following confusing warnings on the > > Raspbe

dwc2: Confusing warnings in next-20180327 on Raspberry Pi

2018-04-02 Thread Stefan Wahren
Hi Minas, in linux-next-20180327 i will get the following confusing warnings on the Raspberry Pi: Linux raspberrypi 4.16.0-rc7-next-20180327+ #2 SMP PREEMPT Sat Mar 31 13:24:47 CEST 2018 armv6l GNU/Linux [6.809185] dwc2 2098.usb: dwc2_check_params: Invalid parameter lpm=1 [6.816741

dwc2: Memory leak in dwc2_gadget_init

2018-04-02 Thread Stefan Wahren
Hi Minas, i noticed that in opposite to all allocations in dwc2_gadget_init() the function dwc2_hsotg_ep_alloc_request() uses kzalloc. So in case usb_add_gadget_udc() would fail, the memory of the USB request would be leaked: Linux raspberrypi 4.16.0-rc7-next-20180327+ #2 SMP PREEMPT Sat Mar 31

[PATCH] usb: core: phy: Fix usb_phy_roothub_add_phy if GENERIC_PHY=n

2018-03-31 Thread Stefan Wahren
dwc2: probe of 2098.usb failed with error -38 Fixes: 07dbff0ddbd8 ("usb: core: add a wrapper for the USB PHYs on the HCD") Signed-off-by: Stefan Wahren --- drivers/usb/core/phy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/core/phy.c b/drivers

Re: [PATCH] usb: dwc2: Print error if unable to set DMA coherent mask

2018-03-08 Thread Stefan Wahren
> Stefan Wahren hat am 12. Februar 2018 um 21:20 > geschrieben: > > > We better print an error in case probing of dwc2 fails on > setting the DMA coherent mask. > > Signed-off-by: Stefan Wahren > --- > drivers/usb/dwc2/platform.c | 4 +++- > 1 file cha

Re: Continuous USB resets on NXP i.MX 6ULL device

2018-03-02 Thread Stefan Wahren
Am 02.03.2018 um 04:03 schrieb Peter Chen: For non-core registers, i.mx6ull can use i.mx6q as its base setting, the bits you mentioned may also be reserved at imx6qdl RM. just for my understanding: MX6_BM_NON_BURST_SETTING is a no-op on i.MX6ULL or not properly documented in reference manual

Re: Continuous USB resets on NXP i.MX 6ULL device

2018-03-01 Thread Stefan Wahren
Hi Peter, Am 01.03.2018 um 03:00 schrieb Peter Chen: > On Wed, Feb 28, 2018 at 06:08:20PM +0100, Stefan Wahren wrote: >> Hi, >> >> i'm not sure this is related, but i noticed something ugly in >> driver/usb/chipidea/usbmisc_imx.c. >> >> The compatible

Re: Continuous USB resets on NXP i.MX 6ULL device

2018-02-28 Thread Stefan Wahren
Hi, i'm not sure this is related, but i noticed something ugly in driver/usb/chipidea/usbmisc_imx.c. The compatible "fsl,imx6ul-usbmisc" uses imx6sx_usbmisc_ops, which uses usbmisc_imx6sx_init (which also calls usbmisc_imx6q_init). Within usbmisc_imx6q_init the flag MX6_BM_NON_BURST_SETTING is en

[PATCH] usb: dwc2: Print error if unable to set DMA coherent mask

2018-02-12 Thread Stefan Wahren
We better print an error in case probing of dwc2 fails on setting the DMA coherent mask. Signed-off-by: Stefan Wahren --- drivers/usb/dwc2/platform.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/usb/dwc2/platform.c b/drivers/usb/dwc2/platform.c index 4703478

Re: [PATCH] usb: dwc2: Fix endless deferral probe

2018-01-12 Thread Stefan Wahren
Am 12.01.2018 um 00:32 schrieb Arnd Bergmann: On Wed, Jan 10, 2018 at 1:15 PM, Stefan Wahren wrote: Hi Arnd, Am 09.01.2018 um 22:33 schrieb Arnd Bergmann: On Tue, Jan 9, 2018 at 8:28 PM, Stefan Wahren wrote: The dwc2 USB driver tries to find a generic PHY first and then look for an old

Re: [PATCH] usb: dwc2: Fix endless deferral probe

2018-01-10 Thread Stefan Wahren
Hi Arnd, Am 09.01.2018 um 22:33 schrieb Arnd Bergmann: On Tue, Jan 9, 2018 at 8:28 PM, Stefan Wahren wrote: The dwc2 USB driver tries to find a generic PHY first and then look for an old style USB PHY. In case of a valid generic PHY node without a PHY driver, the PHY layer will return

Re: [PATCH v3 00/49] usb: dwc2: fixes, enhancements and new features

2018-01-09 Thread Stefan Wahren
Hi Razmik, > Razmik Karapetyan hat am 8. Januar 2018 um > 13:40 geschrieben: > > > On 12/31/2017 9:19 PM, Stefan Wahren wrote: > > Hi Stefan, > > >> > >> Razmik Karapetyan (10): > >>usb: dwc2: Set AHB burst size to INCR > > >

[PATCH] usb: dwc2: Fix endless deferral probe

2018-01-09 Thread Stefan Wahren
style USB PHY at once. Fixes: 6c2dad69163f ("usb: dwc2: Return errors from PHY") Link: https://marc.info/?l=linux-usb&m=151518314314753&w=2 Signed-off-by: Stefan Wahren --- drivers/usb/dwc2/platform.c | 42 -- 1 file changed, 24 insertion

[Bug] Endless deferred probe of dwc2 on RPi 3

2018-01-05 Thread Stefan Wahren
Hi, i noticed on my Raspberry Pi 3 (Linux 4.15rc6, ARM64, defconfig) that probing of dwc2 driver is deferred endlessly. This issue is triggered by a recent DT clean up 014d6da6cb25 ("ARM: dts: bcm283x: Fix DTC warnings about missing phy-cells") which is correct according to Documentation/device

Re: [PATCH v3 00/49] usb: dwc2: fixes, enhancements and new features

2017-12-31 Thread Stefan Wahren
Hi Grigor, sorry for misusing the cover letter for my comments, but i didn't received all patches. > Grigor Tovmasyan hat am 26. Dezember 2017 um > 12:21 geschrieben: > > > ... > > Gevorg Sahakyan (1): > usb: dwc2: Remove version check in GSNPSID > > Grigor Tovmasyan (4): > usb: dwc2:

Re: [PATCH v3 00/49] usb: dwc2: fixes, enhancements and new features

2017-12-26 Thread Stefan Wahren
Hi Grigor, > Grigor Tovmasyan hat am 26. Dezember 2017 um > 12:21 geschrieben: > > > This patch series includes new features such us Active Clock Gating(ACG), > LPM and Hibernation, enhancements and fixes for already existing features. > All this patches were already sent to lkml separately.

Re: [PATCH v4] usb: dwc2: host: Don't retry NAKed transactions right away

2017-12-19 Thread Stefan Wahren
Hi Doug, > Doug Anderson hat am 19. Dezember 2017 um 16:57 > geschrieben: > > > Felipe, > > On Tue, Dec 12, 2017 at 10:30 AM, Douglas Anderson > wrote: > ... > > I don't mean to be a pest, but I'm hoping that we can land this > somewhere (if nothing else in your /next tree) just so it doesn

Re: [PATCH] usb: dwc2: Change TxFIFO and RxFIFO flushing flow

2017-12-11 Thread Stefan Wahren
Hi Minas, Am 11.12.2017 um 11:45 schrieb Minas Harutyunyan: > Hi Stefan, > On 12/8/2017 8:25 PM, Stefan Wahren wrote: >> Hi Minas, >> >> Am 07.12.2017 um 17:51 schrieb Stefan Wahren: >>> Hi Minas, >>> >>> Am 07.12.2017 um 09:40 schrieb Stefan W

Re: [PATCH] usb: dwc2: Change TxFIFO and RxFIFO flushing flow

2017-12-08 Thread Stefan Wahren
Hi Minas, Am 07.12.2017 um 17:51 schrieb Stefan Wahren: Hi Minas, Am 07.12.2017 um 09:40 schrieb Stefan Wahren: Before flushing fifos required to check AHB master state and flush when AHB master is in IDLE state. Signed-off-by: Minas Harutyunyan --- drivers/usb/dwc2/core.c | 27

Re: [PATCH] usb: dwc2: hcd: Fix host channel halt flow

2017-12-07 Thread Stefan Wahren
Hi Minas, Am 07.12.2017 um 18:08 schrieb Stefan Wahren: > According databook in Buffer and External DMA mode > non-split periodic channels can't be halted. do you know of any consequences not having this patch applied? > > Signed-off-by: Minas Harutyunyan Please add a f

Re: [PATCH] usb: dwc2: host: Setting TOUTCAL and USBTRDTIM fields in host mode

2017-12-07 Thread Stefan Wahren
Hi Minas, Am 07.12.2017 um 17:56 schrieb Stefan Wahren: > Added missing GUSBCFG programming in host mode. > > These fields even if was programmed in device mode (in function > dwc2_hsotg_core_init_disconnected()) will be resetting to POR values > after core soft reset applied.

Re: [PATCH] usb: dwc2: Change TxFIFO and RxFIFO flushing flow

2017-12-07 Thread Stefan Wahren
Hi Minas, Am 07.12.2017 um 09:40 schrieb Stefan Wahren: > Before flushing fifos required to check AHB master state and > flush when AHB master is in IDLE state. > > Signed-off-by: Minas Harutyunyan > --- > drivers/usb/dwc2/core.c | 27 +++ > 1 file c

Re: [PATCH v3 1/2] usb: dwc2: host: Don't retry NAKed transactions right away

2017-12-05 Thread Stefan Wahren
ith a NAK when they have nothing to say and thus we end with this same sequence. Signed-off-by: Douglas Anderson Cc: sta...@vger.kernel.org Reviewed-by: Julius Werner Tested-by: Stefan Wahren --- Changes in v3: - Add tested-by for Stefan Wahren - Sent to Felipe Balbi as candiate to land this. - A

Re: [PATCH] ARM: dts: bcm283x: Fix fifo size for EP 6,7

2017-11-23 Thread Stefan Wahren
Hi Minas, > Minas Harutyunyan hat am 23. November 2017 > um 11:00 geschrieben: > > > Hi Stefan, > > ... > > In addition to above patches please apply this one: > > diff --git a/drivers/usb/dwc2/core.c b/drivers/usb/dwc2/core.c > index 42ac47f85bb4..7db50c27c061 100644 > --- a/drivers/usb/dw

Re: [PATCH] ARM: dts: bcm283x: Fix fifo size for EP 6,7

2017-11-22 Thread Stefan Wahren
Hi Minas, > Stefan Wahren hat am 22. November 2017 um 12:21 > geschrieben: > > > Hi Minas, > > > Minas Harutyunyan hat am 21. November 2017 > > um 13:02 geschrieben: > > > > Hi Stefan, > > > > We have prepared patch for this issue in J

Re: [PATCH] ARM: dts: bcm283x: Fix fifo size for EP 6,7

2017-11-22 Thread Stefan Wahren
ifo_sizes function accordingly. Change-Id: I61d3db753b1bc06f0f2caf40df350a09655f18fd Signed-off-by: Gevorg Sahakyan Signed-off-by: Stefan Wahren --- drivers/usb/dwc2/core.h | 1 + drivers/usb/dwc2/params.c | 11 +-- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/usb/dwc2/core.h b/drivers/usb/dwc2/

Re: [PATCH] ARM: dts: bcm283x: Fix fifo size for EP 6,7

2017-11-20 Thread Stefan Wahren
Hi Minas, Am 20.11.2017 um 12:59 schrieb Minas Harutyunyan: > Hi Stefan, > Looks like I know cause of issue... but I'm overloaded today and will able to > check it tomorrow. Sorry for delay. thanks for your reply. There is no need to hurry, because the merge window isn't open yet, but i like to

Re: [PATCH] ARM: dts: bcm283x: Fix fifo size for EP 6,7

2017-11-18 Thread Stefan Wahren
Hi Minas, > Minas Harutyunyan hat am 17. November 2017 > um 08:48 geschrieben: > > > On 11/17/2017 2:35 AM, Stefan Wahren wrote: > > Hi Eric, > > > >> Stefan Wahren hat am 31. Oktober 2017 um 09:43 > >> geschrieben: > >> > >> &

Re: [PATCH] ARM: dts: bcm283x: Fix fifo size for EP 6,7

2017-11-16 Thread Stefan Wahren
Hi Eric, > Stefan Wahren hat am 31. Oktober 2017 um 09:43 > geschrieben: > > > Hi Eric, > > > Eric Anholt hat am 31. Oktober 2017 um 01:40 geschrieben: > > > > > > Stefan Wahren writes: > > > > >> Stefan

Re: [1/2] mm: drop migrate type checks from has_unmovable_pages

2017-11-06 Thread Stefan Wahren
Am 06.11.2017 um 09:14 schrieb Michal Hocko: > On Sun 05-11-17 22:56:32, Stefan Wahren wrote: >> Hi Michal, >> >> the dwc2 USB driver on BCM2835 in linux-next is affected by the CMA >> allocation issue. A quick web search guide me to your patch, which >> avoid the

Re: [1/2] mm: drop migrate type checks from has_unmovable_pages

2017-11-05 Thread Stefan Wahren
Hi Michal, the dwc2 USB driver on BCM2835 in linux-next is affected by the CMA allocation issue. A quick web search guide me to your patch, which avoid the issue. Since the patch wasn't accepted, i want to know is there another solution? Is this an issue in dwc2? Best regards Stefan -- To unsub

Re: [PATCH] ARM: dts: bcm283x: Fix fifo size for EP 6,7

2017-10-31 Thread Stefan Wahren
Hi Eric, > Eric Anholt hat am 31. Oktober 2017 um 01:40 geschrieben: > > > Stefan Wahren writes: > > >> Stefan Wahren hat am 7. Oktober 2017 um 12:16 > >> geschrieben: > >> > >> > >> In case the RPi Zero has at least a device

Re: [PATCH v2] usb: dwc2: host: Don't retry NAKed transactions right away

2017-10-28 Thread Stefan Wahren
303 serial adapters tend to respond with a NAK when they have > nothing to say and thus we end with this same sequence. This patch fixes "dwc2: NMI watchdog: BUG: soft lockup - CPU#0 stuck for 146s" on bcm2835. After applying your patch on linux-next plus "mm: drop migrate type ch

Re: [PATCH v3] dma-mapping: skip USB devices when configuring DMA during probe

2017-08-10 Thread Stefan Wahren
Hi Robin, Am 08.08.2017 um 20:03 schrieb Johan Hovold: > On Sat, Aug 05, 2017 at 10:38:07AM +0200, Christoph Hellwig wrote: >> I think the root problem is that the code added by >> " of/acpi: Configure dma operations at probe time for platform/amba/pci bus >> devices" >> >> is completely bogus and

Re: Rpi3: no ethernet in 4.13: bisected to patch 'USB: of: fix root-hub device-tree node handling'

2017-08-02 Thread Stefan Wahren
> Johan Hovold hat am 2. August 2017 um 13:45 geschrieben: > > > On Wed, Aug 02, 2017 at 01:10:33PM +0200, Stefan Wahren wrote: > > Am 02.08.2017 um 09:03 schrieb Hans Verkuil: > > > When testing with my Raspberry Pi 3 and the 4.13-rcX mainline kernel > >

Re: Rpi3: no ethernet in 4.13: bisected to patch 'USB: of: fix root-hub device-tree node handling'

2017-08-02 Thread Stefan Wahren
Am 02.08.2017 um 09:03 schrieb Hans Verkuil: > When testing with my Raspberry Pi 3 and the 4.13-rcX mainline kernel > I discovered that there was no ethernet. After bisecting I got to commit > 2bf69867 ('USB: of: fix root-hub device-tree node handling'). > > With that commit lsusb outputs: > > rpi3

Re: No Ethernet on Raspberry Pi 3 in v4.13-rc1

2017-07-25 Thread Stefan Wahren
> Robin Murphy hat am 25. Juli 2017 um 15:21 geschrieben: > > > Hi Stefan, > > On 25/07/17 06:19, Stefan Wahren wrote: > >>> With arm64 4.13-rc1 I get no eth0 device on Pi3 (openSUSE Tumbleweed). > >>> The v4.13-rc1 DT works okay with a

Re: No Ethernet on Raspberry Pi 3 in v4.13-rc1

2017-07-25 Thread Stefan Wahren
> Robin Murphy hat am 25. Juli 2017 um 15:21 geschrieben: > > From the subsequent fallout (which on closer inspection looks more to do > with calling into uninitialised SWIOTLB state than the arm64 DMA code > actually doing anything wrong), I'd guess dev->dma_pfn_offset is > probably 0 as well,

Re: No Ethernet on Raspberry Pi 3 in v4.13-rc1

2017-07-24 Thread Stefan Wahren
Hi Robin, > Robin Murphy hat am 24. Juli 2017 um 13:22 geschrieben: > > > Hi Andreas, > > On 22/07/17 13:29, Andreas Färber wrote: > > Hello, > > > > With arm64 4.13-rc1 I get no eth0 device on Pi3 (openSUSE Tumbleweed). > > The v4.13-rc1 DT works okay with a 4.12 kernel. > > > > Possibly re

dwc2: g-tx-fifo-size configuration on bcm2835

2017-05-18 Thread Stefan Wahren
Hi, since the dwc2 should be able to properly setup its fifos, i want to enable otg mode for Raspberry Pi Zero (BCM2835). According to the BCM2835 datasheet [1] it has 7 device EPs with a max FIFO depth for EP1..5 = 512 and EP6,7 = 768. This makes in sum 4096, which also seems to be okay regard

Re: usb: dwc2: NMI watchdog: BUG: soft lockup - CPU#0 stuck for 146s

2017-05-13 Thread Stefan Wahren
> Doug Anderson hat am 11. Mai 2017 um 01:50 > geschrieben: > > > Hi, > > On Wed, May 10, 2017 at 9:31 AM, Johan Hovold wrote: > > On Mon, May 08, 2017 at 10:22:08PM +0200, Stefan Wahren wrote: > >> @Doug, @John Y., @Johan: Any further ideas to narrow dow

Re: usb: dwc2: NMI watchdog: BUG: soft lockup - CPU#0 stuck for 146s

2017-05-08 Thread Stefan Wahren
> Stefan Wahren hat am 25. April 2017 um 20:11 > geschrieben: > > > > Stefan Wahren hat am 22. April 2017 um 22:50 > > geschrieben: > > > > > > Hi, > > > > > Eric Anholt hat am 20. April 2017 um 20:54 geschrieben: >

Re: usb: dwc2: NMI watchdog: BUG: soft lockup - CPU#0 stuck for 146s

2017-04-25 Thread Stefan Wahren
> Stefan Wahren hat am 22. April 2017 um 22:50 > geschrieben: > > > Hi, > > > Eric Anholt hat am 20. April 2017 um 20:54 geschrieben: > > > > > > Stefan Wahren writes: > > > > > Hi, > > > > &

Re: [PATCH] usb: chipidea: udc: fix NULL pointer dereference if udc_start failed

2017-04-25 Thread Stefan Wahren
Am 25.04.2017 um 11:20 schrieb Peter Chen: > diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c index f88e9157fad0..60a786c87c06 100644 --- a/drivers/usb/chipidea/udc.c +++ b/drivers/usb/chipidea/udc.c @@ -1984,6 +1984,7 @@ static void udc_id_switch_for_

Re: usb: dwc2: NMI watchdog: BUG: soft lockup - CPU#0 stuck for 146s

2017-04-22 Thread Stefan Wahren
Hi, > Eric Anholt hat am 20. April 2017 um 20:54 geschrieben: > > > Stefan Wahren writes: > > > Hi, > > > >> Doug Anderson hat am 18. April 2017 um 22:41 > >> geschrieben: > >> > >> > >> It's hard to know for s

Re: usb: dwc2: NMI watchdog: BUG: soft lockup - CPU#0 stuck for 146s

2017-04-20 Thread Stefan Wahren
Am 19.04.2017 um 23:47 schrieb Doug Anderson: > Hi, > > On Wed, Apr 19, 2017 at 1:25 PM, Stefan Wahren wrote: >> Hi, >> >>> Doug Anderson hat am 18. April 2017 um 22:41 >>> geschrieben: >>> >>> >>> It's hard to know for

Re: usb: dwc2: NMI watchdog: BUG: soft lockup - CPU#0 stuck for 146s

2017-04-19 Thread Stefan Wahren
Hi, > Doug Anderson hat am 18. April 2017 um 22:41 > geschrieben: > > > It's hard to know for sure that all of this time is really in > urb_enqueue(). Possible we could have task switched out and been > blocked elsewhere. Using ftrace to get more fine-grained timings > would be useful. ktim

  1   2   3   >