Re: [PATCH] usb: gadget: functions: add ftrace export over USB

2017-07-13 Thread Pratyush Anand
Hi Felipe, On Friday 09 June 2017 03:58 PM, Felipe Balbi wrote: Felipe Balbi writes: Allow for ftrace data to be exported over a USB Gadget Controller. With this, we have a potentially very fast pipe for transmitting ftrace data to a Host PC for further analysis. Note that in order to decode

Re: [PATCH] usb: gadget: functions: add ftrace export over USB

2017-07-13 Thread Pratyush Anand
Hi Felipe, On Friday 09 June 2017 11:43 AM, Felipe Balbi wrote: +static void notrace ftrace_write(struct trace_export *ftrace, const void *buf, +unsigned int len) +{ + struct usb_ftrace *trace = ftrace_to_trace(ftrace); + struct usb_reque

Re: [PATCH 18/23] spear13xx_pcie_gadget: use per-attribute show and store methods

2015-10-06 Thread Pratyush Anand
On Sat, Oct 3, 2015 at 7:02 PM, Christoph Hellwig wrote: > Signed-off-by: Christoph Hellwig Acked-by: Pratyush Anand -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vg

Re: [Regression][v3.17][v3.18] USB: Fix persist resume of some SS USB devices

2014-11-05 Thread Pratyush Anand
On Wed, Nov 05, 2014 at 10:53:35AM +0530, Pratyush Anand wrote: > Hello Joe, > > On Wed, Nov 05, 2014 at 06:20:06AM +0800, Joseph Salisbury wrote: > > Hello Pratyush, > > > > A kernel bug report was opened against Ubuntu [0]. After a kernel > > bisect, it was f

Re: [Regression][v3.17][v3.18] USB: Fix persist resume of some SS USB devices

2014-11-04 Thread Pratyush Anand
5fa4024db00c149629 > Author: Pratyush Anand > Date: Fri Jul 18 12:37:10 2014 +0530 > > USB: Fix persist resume of some SS USB devices > > The regression was introduced as of v3.17-rc1. The regression still > exists in the 3.18-rc3 mainline kernel, and has made i

Re: [PATCH 4/4] usb: dwc3: add tracepoints to aid debugging

2014-09-08 Thread Pratyush Anand
On Mon, Sep 08, 2014 at 09:35:33PM +0800, Felipe Balbi wrote: > Hi, > > On Mon, Sep 08, 2014 at 09:30:27AM +0530, Pratyush Anand wrote: > > On Fri, Sep 05, 2014 at 10:56:26PM +0800, Felipe Balbi wrote: > > > When we're debugging hard-to-reproduce and time-sensitive &g

Re: [PATCH 4/4] usb: dwc3: add tracepoints to aid debugging

2014-09-07 Thread Pratyush Anand
ew initial tracepoints for the > dwc3 driver. More traces can be added as necessary in order > to ease the task of debugging dwc3. > > Reviewed-by: Paul Zimmerman > Signed-off-by: Felipe Balbi > --- Reviewed-by: Pratyush Anand -- To unsubscribe from this list: send the line &qu

Re: [PATCH v2] usb: dwc3: add tracepoints to aid debugging

2014-09-02 Thread Pratyush Anand
On Wed, Aug 27, 2014 at 05:26:37AM +0800, Felipe Balbi wrote: Hi Felipe, > Hi, > > On Tue, Aug 26, 2014 at 09:21:55PM +, Paul Zimmerman wrote: > > > From: Felipe Balbi [mailto:ba...@ti.com] > > > Sent: Tuesday, August 26, 2014 1:42 PM > > > > > > On Fri, Aug 22, 2014 at 04:56:46PM -0500, Fe

Re: [PATCH v3 0/6] usb: host: change TPL support behaviour

2014-08-22 Thread Pratyush Anand
b/core/hub.c | 33 > +--- > drivers/usb/core/otg_whitelist.h | 13 ++-- > include/linux/usb/chipidea.h |1 + > include/linux/usb/hcd.h|1 + > include/linux/usb/of.h

Re: [PATCH 2/6] usb: core: TPL should apply for both OTG and EH

2014-08-10 Thread Pratyush Anand
Hi Peter, On Thu, Aug 07, 2014 at 02:45:15PM +0800, Peter Chen wrote: > According to On-The-Go and Embedded Host Supplement to the USB Revision > 2.0 Specification, the targeted hosts (non-PC hosts) include both > embedded hosts and otg, and each targeted host product defines the > set of supporte

[Resend PATCH V2] usb: lvstest: Fix sparse warnings generated by kbuild test bot

2014-07-20 Thread Pratyush Anand
:got restricted __le16 [usertype] wPortChange drivers/usb/misc/lvstest.c:332:40: sparse: restricted __le16 degrades to integer This patch fixes above warnings. Reported-by: kbuild test robot Signed-off-by: Pratyush Anand --- drivers/usb/misc/lvstest.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH V2] usb: lvstest: Fix sparse warnings generated by kbuild test bot

2014-07-20 Thread Pratyush Anand
:got restricted __le16 [usertype] wPortChange drivers/usb/misc/lvstest.c:332:40: sparse: restricted __le16 degrades to integer This patch fixes above warnings. Signed-off-by: Pratyush Anand --- drivers/usb/misc/lvstest.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a

[PATCH V2] USB: Fix persist resume of some SS USB devices

2014-07-18 Thread Pratyush Anand
n Stern Signed-off-by: Pratyush Anand --- Changes since RFC: -- Loop implementation updated as per Alan's comment -- Commit log updated as per observation with different failing devices. drivers/usb/core/hub.c | 41 + 1 file changed, 41 inserti

[PATCH] usb: lvstest: Fix sparse warnings generated by kbuild test bot

2014-07-17 Thread Pratyush Anand
:got restricted __le16 [usertype] wPortChange drivers/usb/misc/lvstest.c:332:40: sparse: restricted __le16 degrades to integer This patch fixes above warnings. Signed-off-by: Pratyush Anand --- drivers/usb/misc/lvstest.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff

Re: [RFC] USB: Fix persist resume of some SS USB devices

2014-07-17 Thread Pratyush Anand
On Thu, Jul 17, 2014 at 05:55:22PM +0800, Pratyush Anand wrote: > Hi David, > > On Thu, Jul 17, 2014 at 05:37:44PM +0800, David Laight wrote: > > From: Pratyush Anand > > ... > > > Only side effect of long timeout: If a device was connected before > > > su

Re: [RFC] USB: Fix persist resume of some SS USB devices

2014-07-17 Thread Pratyush Anand
Hi David, On Thu, Jul 17, 2014 at 05:37:44PM +0800, David Laight wrote: > From: Pratyush Anand > ... > > Only side effect of long timeout: If a device was connected before > > suspend, and was removed while system was asleep, then the penalty > > would be the timeout ie

Re: [RFC] USB: Fix persist resume of some SS USB devices

2014-07-17 Thread Pratyush Anand
Hi Alan, On Wed, Jul 16, 2014 at 10:05:57PM +0800, Alan Stern wrote: > On Wed, 16 Jul 2014, Pratyush Anand wrote: > > > Hu..May be this solution is not perfect. Have been reported with > > at least one device which failed with this patch too. A print of > > link_sta

Re: [RFC] USB: Fix persist resume of some SS USB devices

2014-07-16 Thread Pratyush Anand
On Wed, Jul 16, 2014 at 01:25:21PM +0800, Pratyush Anand wrote: > Hi Alan, > > Thanks a lot for your review. > > On Tue, Jul 15, 2014 at 10:46:00PM +0800, Alan Stern wrote: > > On Tue, 15 Jul 2014, Pratyush Anand wrote: > > > > > Problem Summary: Problem

Re: [RFC] USB: Fix persist resume of some SS USB devices

2014-07-15 Thread Pratyush Anand
Hi David, Thanks for your review. On Tue, Jul 15, 2014 at 10:58:03PM +0800, David Laight wrote: > From: Alan Stern > > On Tue, 15 Jul 2014, Pratyush Anand wrote: > ... > > > +static int wait_for_ss_port_enable(struct usb_device *udev, > > > +

Re: [RFC] USB: Fix persist resume of some SS USB devices

2014-07-15 Thread Pratyush Anand
Hi Alan, Thanks a lot for your review. On Tue, Jul 15, 2014 at 10:46:00PM +0800, Alan Stern wrote: > On Tue, 15 Jul 2014, Pratyush Anand wrote: > > > Problem Summary: Problem has been observed generally with PM states > > where VBUS goes off during suspend. There are some SS

[RFC] USB: Fix persist resume of some SS USB devices

2014-07-15 Thread Pratyush Anand
s patch, but with old device address. Signed-off-by: Pratyush Anand --- drivers/usb/core/hub.c | 37 + 1 file changed, 37 insertions(+) diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c index 21b99b4..93495b7 100644 --- a/drivers/usb/core/hub.c +++

[PATCH 2/2] USB: Add LVS Test device driver

2014-07-14 Thread Pratyush Anand
\:1.0/u2_timeout 4. To issue "Hot Reset" for TD.7.29 echo > /sys/bus/usb/devices/2-0\:1.0/hot_reset 5. To issue "U3 Entry" for TD.7.35 echo > /sys/bus/usb/devices/2-0\:1.0/u3_entry 6. To issue "U3 Exit" for TD.7.36 echo > /sys/bus/usb/devices/2-0\:1.0/

[PATCH 0/2] LVS Test device driver support

2014-07-14 Thread Pratyush Anand
1st patch exports usb_alloc_dev symbol so that lvstest driver in second patch can be compiled as module. Pratyush Anand (2): USB: Add EXPORT_SYMBOL for usb_alloc_dev USB: Add LVS Test device driver Documentation/ABI/testing/sysfs-bus-usb-lvstest | 47 +++ drivers/usb/core/usb.c

[PATCH 1/2] USB: Add EXPORT_SYMBOL for usb_alloc_dev

2014-07-14 Thread Pratyush Anand
usb_alloc_dev is used by lvstest driver now which can be built as module. Therefore export usb_alloc_dev symbol. Signed-off-by: Pratyush Anand --- drivers/usb/core/usb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/core/usb.c b/drivers/usb/core/usb.c index 4d11449..2dd2362

Re: [PATCH V4] USB: Add LVS Test device driver

2014-07-10 Thread Pratyush Anand
On Thu, Jul 10, 2014 at 06:40:43AM +0800, Greg KH wrote: > On Thu, May 29, 2014 at 10:03:42AM +0530, Pratyush Anand wrote: > > OTG3 and EH Compliance Plan 1.0 talks about Super Speed OTG Verification > > system (SS-OVS) which consists of an excersizer and analyzer. > > >

Re: [PATCH V4] USB: Add LVS Test device driver

2014-06-24 Thread Pratyush Anand
Hi Greg, On Thu, May 29, 2014 at 12:33:42PM +0800, Pratyush ANAND wrote: > OTG3 and EH Compliance Plan 1.0 talks about Super Speed OTG Verification > system (SS-OVS) which consists of an excersizer and analyzer. > > [...] > Signed-off-by: Pratyush Anand > Acked-by: Alan St

Re: [PATCH 1/4] phy: Add provision for calibrating phy.

2014-06-08 Thread Pratyush Anand
On Fri, Jun 06, 2014 at 08:12:12PM +0800, Vivek Gautam wrote: > Some PHY controllers may need to calibrate certain > PHY settings after initialization of the controller and > sometimes even after initializing the PHY-consumer too. > Add support for the same in order to let consumers do so in need.

Re: [PATCH V3 0/5] Enable U1/U2 initiation from dwc3 xhci host

2014-05-28 Thread Pratyush Anand
Hi Mathias, On Tue, May 06, 2014 at 11:54:15AM +0800, Pratyush ANAND wrote: > These patches provide support of LPM capability to the dwc3 xhci hosts. > Patches have been tested on STih407. > > Changes since V2: > -- checkpatch warning removed. > -- xhci pdata ini

[PATCH V4] USB: Add LVS Test device driver

2014-05-28 Thread Pratyush Anand
\:1.0/u2_timeout 4. To issue "Hot Reset" for TD.7.29 echo > /sys/bus/usb/devices/2-0\:1.0/hot_reset 5. To issue "U3 Entry" for TD.7.35 echo > /sys/bus/usb/devices/2-0\:1.0/u3_entry 6. To issue "U3 Exit" for TD.7.36 echo > /sys/bus/usb/devices/2-0\:

Re: [PATCH V3] USB: Add LVS Test device driver

2014-05-28 Thread Pratyush Anand
On Tue, May 27, 2014 at 10:04:37PM +0800, Alan Stern wrote: > On Sat, 24 May 2014, Pratyush Anand wrote: > > > OTG3 and EH Compliance Plan 1.0 talks about Super Speed OTG Verification > > + ret = usb_control_msg(hdev, usb_rcvctrlpipe(hdev, 0), > > +

Re: [PATCH V3] USB: Add LVS Test device driver

2014-05-28 Thread Pratyush Anand
On Wed, May 28, 2014 at 06:48:16AM +0800, Greg KH wrote: > On Sat, May 24, 2014 at 05:09:02PM +0530, Pratyush Anand wrote: > > OTG3 and EH Compliance Plan 1.0 talks about Super Speed OTG Verification > > system (SS-OVS) which consists of an excersizer and analyzer. > > >

Re: [PATCH V3] USB: Add LVS Test device driver

2014-05-27 Thread Pratyush Anand
Hi Greg, On Wed, May 28, 2014 at 4:18 AM, Greg KH wrote: > > On Sat, May 24, 2014 at 05:09:02PM +0530, Pratyush Anand wrote: > > OTG3 and EH Compliance Plan 1.0 talks about Super Speed OTG Verification > > system (SS-OVS) which consists of an excersizer and analyzer. >

[PATCH V3] USB: Add LVS Test device driver

2014-05-24 Thread Pratyush Anand
\:1.0/u2_timeout 4. To issue "Hot Reset" for TD.7.29 echo > /sys/bus/usb/devices/2-0\:1.0/hot_reset 5. To issue "U3 Entry" for TD.7.35 echo > /sys/bus/usb/devices/2-0\:1.0/u3_entry 6. To issue "U3 Exit" for TD.7.36 echo > /sys/bus/usb/devices/2-0\:1.0/

Re: [PATCH V2] USB: Add LVS Test device driver

2014-05-22 Thread Pratyush Anand
Hi Alan, On Fri, May 23, 2014 at 01:54:01AM +0800, Alan Stern wrote: > On Thu, 22 May 2014, Pratyush Anand wrote: > > > OTG3 and EH Compliance Plan 1.0 talks about Super Speed OTG Verification > > system (SS-OVS) which consists of an excersizer and analyzer. > > >

[PATCH V2] USB: Add LVS Test device driver

2014-05-22 Thread Pratyush Anand
t_reset 5. To issue "U3 Entry" for TD.7.35 echo 1 > /sys/bus/usb/devices/2-0\:1.0/u3_entry 6. To issue "U3 Exit" for TD.7.36 echo 1 > /sys/bus/usb/devices/2-0\:1.0/u3_exit Signed-off-by: Pratyush Anand --- Documentation/ABI/testing/sysfs-bus-usb-lvstest | 47 +++

Re: USB 3.0 - Synopsis DWC Host-AHB - on Linux Kernel 3.10.28

2014-05-22 Thread Pratyush Anand
On Wed, May 21, 2014 at 05:23:33PM +0800, krishnamurthy holla wrote: > Hello, > > I am using Linux kernel 3.10.28 - MIPS processor (BIG Endian) > > I see that XHCI fails during xhci_device_alloc() because of > wait_for_completion_interruptible_timeout () when I connect a device. > > So, I though

Re: [PATCH] usb: dwc3: gadget: check link trb after free_slot is increased

2014-05-19 Thread Pratyush Anand
see that bug even in other case, like submit 31 back to back ep_queue request from gadget and then wait as if no application data is available. They all have been transmitted to host and callback has been called for all of them. After some time application is ready with new data. So when

Re: Driver probing defaults (was: Re: [PATCH] USB: Add LVS Test device driver)

2014-05-15 Thread Pratyush Anand
Hi Greg, On Thu, May 15, 2014 at 12:47:34AM +0800, Greg KH wrote: > On Wed, May 14, 2014 at 12:41:44PM -0400, Alan Stern wrote: > > On Wed, 14 May 2014, Greg KH wrote: > > > > > > > Or just make the lvstest driver have to be "manually" bound to the > > > > > device through the bind file in sysfs,

Re: [PATCH V3 4/5] dwc3: host: Enable USB3 LPM capability

2014-05-14 Thread Pratyush Anand
On Wed, May 14, 2014 at 10:45:55PM +0800, Felipe Balbi wrote: > On Wed, May 14, 2014 at 12:13:08PM +0530, Pratyush Anand wrote: > > Hi Paul/Felip, > > > > On Wed, May 07, 2014 at 11:15:33AM +0530, Pratyush Anand wrote: > > > Hi Paul, > > > > > > On

Re: [PATCH] USB: Add LVS Test device driver

2014-05-14 Thread Pratyush Anand
On Thu, May 15, 2014 at 12:07:19AM +0800, Greg KH wrote: > On Mon, May 12, 2014 at 11:45:23AM +0530, Pratyush Anand wrote: > > +static DEVICE_ATTR(u3_entry, S_IWUSR, NULL, issue_u3_entry); > > For this, and the other DEVICE_ATTR() entries, please use > DEVICE_ATTR_RO(

Re: [PATCH V3 4/5] dwc3: host: Enable USB3 LPM capability

2014-05-13 Thread Pratyush Anand
Hi Paul/Felip, On Wed, May 07, 2014 at 11:15:33AM +0530, Pratyush Anand wrote: > Hi Paul, > > On Tue, May 06, 2014 at 11:54:19AM +0800, Pratyush ANAND wrote: > > All dwc3 based xhci host controller supports USB3.0 LPM functionality. > > Therefore enable it in platform da

Re: [PATCH 8/8] usb: dwc3: gadget: always enable IOC on bulk/interrupt transfers

2014-05-13 Thread Pratyush Anand
Hi Balbi, On Tue, May 13, 2014 at 11:17:02PM +0800, Felipe Balbi wrote: > Hi, > > On Fri, May 09, 2014 at 11:25:46AM +0530, Pratyush Anand wrote: > > On Tue, May 06, 2014 at 02:22:12PM +0800, Amit VIRDI wrote: > > > On 5/6/2014 12:56 AM, Felipe Balbi wrote: > > &

Re: [PATCH] USB: Add LVS Test device driver

2014-05-13 Thread Pratyush Anand
Hi Alan, PS: For all other comments, will do as you suggested. On Tue, May 13, 2014 at 10:28:11PM +0800, Alan Stern wrote: > On Tue, 13 May 2014, Pratyush Anand wrote: > > > > The biggest bug may not be an obvious one. Suppose the lvstest driver > > > has been built in

Re: [PATCH] USB: Add LVS Test device driver

2014-05-12 Thread Pratyush Anand
Hi Alan, On Mon, May 12, 2014 at 11:19:33PM +0800, Alan Stern wrote: > On Mon, 12 May 2014, Pratyush Anand wrote: > > > OTG3 and EH Compliance Plan 1.0 talks about Super Speed OTG Verification > > system (SS-OVS) which consists of an excersizer and analyzer. > > >

[PATCH] USB: Add LVS Test device driver

2014-05-11 Thread Pratyush Anand
-0\:1.0/u2_timeout 4. To issue "Hot Reset" for TD.7.29 echo 1 > /sys/bus/usb/devices/2-0\:1.0/hot_reset 5. To issue "U3 Entry" for TD.7.35 echo 1 > /sys/bus/usb/devices/2-0\:1.0/u3_entry 6. To issue "U3 Exit" for TD.7.36 echo 1 > /sys/bus/usb/devices/2-0

Re: [PATCH 8/8] usb: dwc3: gadget: always enable IOC on bulk/interrupt transfers

2014-05-08 Thread Pratyush Anand
Hi Amit, On Tue, May 06, 2014 at 02:22:12PM +0800, Amit VIRDI wrote: > On 5/6/2014 12:56 AM, Felipe Balbi wrote: > >> I understand that enabling XferInProgress event for bulk/interrupt > >> >transfers will completely > >> >change the design of the dwc3 driver and hence is not the viable solution >

Re: [PATCH V3 4/5] dwc3: host: Enable USB3 LPM capability

2014-05-06 Thread Pratyush Anand
Hi Paul, On Tue, May 06, 2014 at 11:54:19AM +0800, Pratyush ANAND wrote: > All dwc3 based xhci host controller supports USB3.0 LPM functionality. > Therefore enable it in platform data for all dwc3 based xhci device. > > Signed-off-by: Pratyush Anand > --- > drivers/us

[PATCH V3 0/5] Enable U1/U2 initiation from dwc3 xhci host

2014-05-05 Thread Pratyush Anand
x27;s comment -- A new patch added for allowing lpm (en/dis)able only if device is atleast in default state Pratyush Anand (5): xhci: A default implementation for Ux timeout calculation and tier policy check xhci: Platform: Add (en/dis)able_usb3_lpm_timeout xhci: Pla

[PATCH V3 1/5] xhci: A default implementation for Ux timeout calculation and tier policy check

2014-05-05 Thread Pratyush Anand
calculated as per definition of system exit latency defined in C.1.5.2. Therefore xhci_calculate_ux_timeout returns ux_params.sel as the default implementation. Use default calculation in absence of any vendor specific limitations. Signed-off-by: Pratyush Anand Tested-by: Aymen Bouattay

[PATCH V3 5/5] usb: allow lpm (en/dis)able only if device is atleast in default state

2014-05-05 Thread Pratyush Anand
returns from usb_(en/dis)able_lpm, if device was not in default state atleast. Signed-off-by: Pratyush Anand Tested-by: Aymen Bouattay --- drivers/usb/core/hub.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c index 090469e

[PATCH V3 4/5] dwc3: host: Enable USB3 LPM capability

2014-05-05 Thread Pratyush Anand
All dwc3 based xhci host controller supports USB3.0 LPM functionality. Therefore enable it in platform data for all dwc3 based xhci device. Signed-off-by: Pratyush Anand --- drivers/usb/dwc3/host.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/usb/dwc3/host.c b

[PATCH V3 2/5] xhci: Platform: Add (en/dis)able_usb3_lpm_timeout

2014-05-05 Thread Pratyush Anand
To use auto U0-U1/U2 transition by xhci platform device add (en/dis)able_usb3_lpm_timeout function to the xhci_plat_xhci_driver struct. Signed-off-by: Pratyush Anand Tested-by: Aymen Bouattay --- drivers/usb/host/xhci-plat.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb

[PATCH V3 3/5] xhci: Platform: Set xhci lpm support quirk based on platform data

2014-05-05 Thread Pratyush Anand
If an xhci platform supports USB3 LPM capability then enable XHCI_LPM_SUPPORT quirk flag. Signed-off-by: Pratyush Anand --- Documentation/devicetree/bindings/usb/usb-xhci.txt | 2 ++ drivers/usb/host/xhci-plat.c | 6 + include/linux/usb/xhci_pdriver.h

Re: [PATCH V2 4/5] dwc3: host: Enable USB3 LPM capability

2014-05-05 Thread Pratyush Anand
On Mon, May 05, 2014 at 11:35:57PM +0800, Felipe Balbi wrote: > On Mon, May 05, 2014 at 03:30:08PM +0530, Pratyush Anand wrote: > > All dwc3 based xhci host controller supports USB3.0 LPM functionality. > > Therefore enable it in platform data for all dwc3 based xhci device. > &g

[PATCH V2 3/5] xhci: Platform: Set xhci lpm support quirk based on platform data

2014-05-05 Thread Pratyush Anand
If an xhci platform supports USB3 LPM capability then enable XHCI_LPM_SUPPORT quirk flag. Signed-off-by: Pratyush Anand --- Documentation/devicetree/bindings/usb/usb-xhci.txt | 2 ++ drivers/usb/host/xhci-plat.c | 6 + include/linux/usb/xhci_pdriver.h

[PATCH V2 4/5] dwc3: host: Enable USB3 LPM capability

2014-05-05 Thread Pratyush Anand
All dwc3 based xhci host controller supports USB3.0 LPM functionality. Therefore enable it in platform data for all dwc3 based xhci device. Signed-off-by: Pratyush Anand --- drivers/usb/dwc3/host.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/usb/dwc3/host.c b/drivers

[PATCH V2 5/5] usb: allow lpm (en/dis)able only if device is atleast in default state

2014-05-05 Thread Pratyush Anand
returns from usb_(en/dis)able_lpm, if device was not in default state atleast. Signed-off-by: Pratyush Anand Tested-by: Aymen Bouattay --- drivers/usb/core/hub.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c index 090469e

[PATCH V2 1/5] xhci: A default implementation for Ux timeout calculation and tier policy check

2014-05-05 Thread Pratyush Anand
calculated as per definition of system exit latency defined in C.1.5.2. Therefore xhci_calculate_ux_timeout returns ux_params.sel as the default implementation. Use default calculation in absence of any vendor specific limitations. Signed-off-by: Pratyush Anand Tested-by: Aymen Bouattay

[PATCH V2 0/5] Enable U1/U2 initiation from dwc3 xhci host

2014-05-05 Thread Pratyush Anand
st in default state Pratyush Anand (5): xhci: A default implementation for Ux timeout calculation and tier policy check xhci: Platform: Add (en/dis)able_usb3_lpm_timeout xhci: Platform: Set xhci lpm support quirk based on platform data dwc3: host: Enable USB3 LPM capability usb: allow lp

[PATCH V2 2/5] xhci: Platform: Add (en/dis)able_usb3_lpm_timeout

2014-05-05 Thread Pratyush Anand
To use auto U0-U1/U2 transition by xhci platform device add (en/dis)able_usb3_lpm_timeout function to the xhci_plat_xhci_driver struct. Signed-off-by: Pratyush Anand Tested-by: Aymen Bouattay --- drivers/usb/host/xhci-plat.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb

Re: [PATCH 3/4] dwc3: host: Set xhci lpm support quirk

2014-04-28 Thread Pratyush Anand
On Sat, Apr 26, 2014 at 02:10:21AM +0800, Felipe Balbi wrote: > On Fri, Apr 25, 2014 at 02:27:11PM +0530, Pratyush Anand wrote: > > On Tue, Apr 22, 2014 at 10:41:06PM +0800, Felipe Balbi wrote: > > > On Tue, Apr 22, 2014 at 10:46:13AM +0530, Pratyush Anand wrote: > > > &

Re: [PATCH 1/4] xhci: A default implementation for Ux timeout calculation and tier policy check

2014-04-25 Thread Pratyush Anand
On Thu, Apr 24, 2014 at 11:01:58PM +0800, Mathias Nyman wrote: > On 04/22/2014 07:27 AM, Pratyush Anand wrote: > > As best case, a host controller should support U0 to U1 switching for > > the devices connected below any tier of hub level supported by usb > > spe

Re: [PATCH 3/4] dwc3: host: Set xhci lpm support quirk

2014-04-25 Thread Pratyush Anand
On Tue, Apr 22, 2014 at 10:41:06PM +0800, Felipe Balbi wrote: > On Tue, Apr 22, 2014 at 10:46:13AM +0530, Pratyush Anand wrote: > > On Tue, Apr 22, 2014 at 12:43:55PM +0800, Felipe Balbi wrote: > > > On Tue, Apr 22, 2014 at 09:57:29AM +0530, Pratyush Anand wrote: > > >

Re: [PATCH 3/4] dwc3: host: Set xhci lpm support quirk

2014-04-21 Thread Pratyush Anand
On Tue, Apr 22, 2014 at 12:43:55PM +0800, Felipe Balbi wrote: > On Tue, Apr 22, 2014 at 09:57:29AM +0530, Pratyush Anand wrote: > > All dwc3 based xhci host controller supports USB3.0 LPM functionality. > > Therefore enable quirk flag to support it for dwc3 xhci host driver. > &g

[PATCH 1/4] xhci: A default implementation for Ux timeout calculation and tier policy check

2014-04-21 Thread Pratyush Anand
calculated as per definition of system exit latency defined in C.1.5.2. Therefore xhci_calculate_ux_timeout returns ux_params.sel as the default implementation. Use default calculation in absence of any vendor specific limitations. Signed-off-by: Pratyush Anand Tested-by: Aymen Bouattay

[PATCH 2/4] xhci: Platform: Add (en/dis)able_usb3_lpm_timeout

2014-04-21 Thread Pratyush Anand
To use auto U0-U1/U2 transition by xhci platform device add (en/dis)able_usb3_lpm_timeout function to the xhci_plat_xhci_driver struct. Signed-off-by: Pratyush Anand Tested-by: Aymen Bouattay --- drivers/usb/host/xhci-plat.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb

[PATCH 3/4] dwc3: host: Set xhci lpm support quirk

2014-04-21 Thread Pratyush Anand
All dwc3 based xhci host controller supports USB3.0 LPM functionality. Therefore enable quirk flag to support it for dwc3 xhci host driver. Signed-off-by: Pratyush Anand Tested-by: Aymen Bouattay --- drivers/usb/dwc3/host.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/dwc3

[PATCH 4/4] usb: allow lpm (en/dis)able only if device is atleast in default state

2014-04-21 Thread Pratyush Anand
returns from usb_(en/dis)able_lpm, if device was not in default state atleast. Signed-off-by: Pratyush Anand Tested-by: Aymen Bouattay --- drivers/usb/core/hub.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c index 5edcfb2

[PATCH 0/4] Enable U1/U2 initiation from dwc3 xhci host

2014-04-21 Thread Pratyush Anand
d for allowing lpm (en/dis)able only if device is atleast in default state. Pratyush Anand (4): xhci: A default implementation for Ux timeout calculation and tier policy check xhci: Platform: Add (en/dis)able_usb3_lpm_timeout dwc3: host: Set xhci lpm support quirk usb: allow lpm (en/dis)able

Re: [RFC 0/2] Support for Super Speed Link Layer Test

2014-04-16 Thread Pratyush Anand
On Tue, Apr 15, 2014 at 10:05:42PM +0800, Alan Stern wrote: > On Tue, 15 Apr 2014, Pratyush Anand wrote: > > > > How about just creating a normal USB device instead of a platform > > > device? I think all you have to do is make usb_new_device() avoid > > > ca

Re: [RFC 0/2] Support for Super Speed Link Layer Test

2014-04-15 Thread Pratyush Anand
On Tue, Apr 15, 2014 at 02:20:13AM +0800, Alan Stern wrote: > On Mon, 14 Apr 2014, Pratyush Anand wrote: > > > Hi Alan, > > > > On Fri, Apr 11, 2014 at 06:56:37PM +0800, Pratyush ANAND wrote: > > > Lecroy's USB Compliance suites provide option to test

Re: [RFC 1/4] dwc3: dts: Binding information for an optional property lpm_capable

2014-04-15 Thread Pratyush Anand
On Tue, Apr 15, 2014 at 01:48:00AM +0800, Paul Zimmerman wrote: > > From: linux-usb-ow...@vger.kernel.org > > [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Pratyush Anand > > Sent: Monday, April 14, 2014 1:48 AM > > > > On Mon, Apr 14, 2014 at 09:42:25

Re: [RFC 3/4] xhci: A default implementation for Ux timeout calculation and tier policy check

2014-04-15 Thread Pratyush Anand
On Mon, Apr 14, 2014 at 11:24:18PM +0800, Mathias Nyman wrote: > Hi > > On 04/11/2014 01:20 PM, Pratyush Anand wrote: > > As best case, a host controller should support U0 to U1 switching for > > the devices connected below any tier of hub level supported by usb > &g

Re: [RFC 1/4] dwc3: dts: Binding information for an optional property lpm_capable

2014-04-14 Thread Pratyush Anand
On Mon, Apr 14, 2014 at 09:42:25AM +0530, Pratyush Anand wrote: > Hi Paul, > > On Sat, Apr 12, 2014 at 02:25:27AM +0800, Paul Zimmerman wrote: > > > From: Pratyush Anand [mailto:pratyush.an...@gmail.com] > > > Sent: Friday, April 11, 2014 11:06 AM > > > &g

Re: [RFC 0/2] Support for Super Speed Link Layer Test

2014-04-13 Thread Pratyush Anand
Hi Alan, On Fri, Apr 11, 2014 at 06:56:37PM +0800, Pratyush ANAND wrote: > Lecroy's USB Compliance suites provide option to test Link Layer Tests > for Super Speed device as well as host. > > As of now there is no standard way to test embedded host for these > tests. > &

Re: [RFC 3/4] xhci: A default implementation for Ux timeout calculation and tier policy check

2014-04-13 Thread Pratyush Anand
On Sat, Apr 12, 2014 at 02:54:22AM +0800, Felipe Balbi wrote: > Hi, > > On Sat, Apr 12, 2014 at 12:04:27AM +0530, Pratyush Anand wrote: > > >> +static u16 xhci_calculate_default_u1_timeout(struct usb_device *udev, > > >> + str

Re: [RFC 1/4] dwc3: dts: Binding information for an optional property lpm_capable

2014-04-13 Thread Pratyush Anand
Hi Paul, On Sat, Apr 12, 2014 at 02:25:27AM +0800, Paul Zimmerman wrote: > > From: Pratyush Anand [mailto:pratyush.an...@gmail.com] > > Sent: Friday, April 11, 2014 11:06 AM > > > > On Fri, Apr 11, 2014 at 11:24 PM, Felipe Balbi wrote: > > > On Fri, Apr 11, 2

Re: [RFC 3/4] xhci: A default implementation for Ux timeout calculation and tier policy check

2014-04-11 Thread Pratyush Anand
On Fri, Apr 11, 2014 at 11:29 PM, Felipe Balbi wrote: > On Fri, Apr 11, 2014 at 03:50:05PM +0530, Pratyush Anand wrote: >> As best case, a host controller should support U0 to U1 switching for >> the devices connected below any tier of hub level supported by usb >> spe

Re: [RFC 2/4] dwc3: host: Set xhci quirk for LPM if a platform supports it

2014-04-11 Thread Pratyush Anand
On Fri, Apr 11, 2014 at 11:26 PM, Felipe Balbi wrote: > On Fri, Apr 11, 2014 at 03:50:04PM +0530, Pratyush Anand wrote: >> If a platform supports LPM then enable quirk in XHCI for the same. >> >> Signed-off-by: Pratyush Anand >> --- >> drivers/usb/dwc3/core.c

Re: [RFC 1/4] dwc3: dts: Binding information for an optional property lpm_capable

2014-04-11 Thread Pratyush Anand
On Fri, Apr 11, 2014 at 11:24 PM, Felipe Balbi wrote: > On Fri, Apr 11, 2014 at 03:50:03PM +0530, Pratyush Anand wrote: >> If a dwc3 host implementation is lpm capable then enable lpm_capable in >> device tree. >> >> Signed-off-by: Pratyush Anand >> --- >>

[RFC 1/2] USB: Core: Quirk to prevent enumeration of LVS devices

2014-04-11 Thread Pratyush Anand
eral usb device to root hub n), do following: echo 0 > /sys/bus/usb/devices/usbn/avoid_enum_quirk Signed-off-by: Pratyush Anand --- Documentation/ABI/testing/sysfs-bus-usb | 10 +++ drivers/usb/core/hub.c | 105 +++- drivers/usb/core/hub.h

[RFC 0/2] Support for Super Speed Link Layer Test

2014-04-11 Thread Pratyush Anand
s are still not complete. Patch 2 will have few more sysfs nodes to support some failing tests. I am sending these as RFC for mainly to have your comment on framework modifications. Please let me know, if there could be any better way to do it. Pratyush Anand (2): USB: Core: Quirk to prevent enumer

[RFC 2/2] USB: Add LVS Test device driver

2014-04-11 Thread Pratyush Anand
t;Hot Reset" for TD.7.29 echo 1 > /sys/devices/platform/lvstestdev.n.auto/hot_reset Signed-off-by: Pratyush Anand --- .../ABI/testing/sysfs-devices-platform-lvstestdev | 32 drivers/usb/misc/Kconfig | 6 + drivers/usb/misc/Makefile

[RFC 3/4] xhci: A default implementation for Ux timeout calculation and tier policy check

2014-04-11 Thread Pratyush Anand
definition of system exit latency defined in C.1.5.2. Therefore xhci_calculate_default_ux_timeout returns ux_params.sel as the default implementation. Use default calculation in absence of any vendor specific limitations. Signed-off-by: Pratyush Anand --- drivers/usb/host/xhci.c | 61

[RFC 2/4] dwc3: host: Set xhci quirk for LPM if a platform supports it

2014-04-11 Thread Pratyush Anand
If a platform supports LPM then enable quirk in XHCI for the same. Signed-off-by: Pratyush Anand --- drivers/usb/dwc3/core.c | 1 + drivers/usb/dwc3/core.h | 1 + drivers/usb/dwc3/host.c | 2 ++ 3 files changed, 4 insertions(+) diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c

[RFC 0/4] Enable U1/U2 initiation from dwc3 xhci host

2014-04-11 Thread Pratyush Anand
These patches provides support of LPM capability to the dwc3 xhci hosts. LPM capability is disabled by default. Any dwc3 based platform can enable it through device tree. Patches have been tested on STih407 by Aymen BOUATTAY. Pratyush Anand (4): dwc3: dts: Binding information for an optional

[RFC 1/4] dwc3: dts: Binding information for an optional property lpm_capable

2014-04-11 Thread Pratyush Anand
If a dwc3 host implementation is lpm capable then enable lpm_capable in device tree. Signed-off-by: Pratyush Anand --- Documentation/devicetree/bindings/usb/dwc3.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/usb/dwc3.txt b/Documentation/devicetree

[RFC 4/4] xhci: Platform: Add (en/dis)able_usb3_lpm_timeout

2014-04-11 Thread Pratyush Anand
To use auto U0-U1/U2 transition by xhci platform device add (en/dis)able_usb3_lpm_timeout function to the xhci_plat_xhci_driver struct. Signed-off-by: Pratyush Anand --- drivers/usb/host/xhci-plat.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/host/xhci-plat.c b/drivers

Re: Discussion: Link Layer Test implementation strategy for Linux Embedded Host

2014-03-31 Thread Pratyush Anand
Hi Alan, On Tue, Apr 1, 2014 at 4:19 AM, Alan Stern wrote: > On Mon, 31 Mar 2014, Greg KH wrote: > >> On Mon, Mar 31, 2014 at 05:14:31PM +0530, Pratyush Anand wrote: >> > Hi Alan/Greg, >> > >> > I was starting some work for running "Lecroy USB

Discussion: Link Layer Test implementation strategy for Linux Embedded Host

2014-03-31 Thread Pratyush Anand
Hi Alan/Greg, I was starting some work for running "Lecroy USB Compliance Suite Link Layer Tests" with embedded xhci host, which runs Linux. I thought, its wise to discuss my test strategy before I start implementing it, as in long run I would like to push them to mainline. These tests have been

Re: Query: Link Power management support for xhci platform driver

2014-03-23 Thread Pratyush Anand
Hi Sarah, Thanks a lot for replying back. On Sat, Mar 22, 2014 at 12:17:49AM +0800, Sarah Sharp wrote: > Cc-ing Mathias Nyman, who is taking over as xHCI driver maintainer. > > On Fri, Mar 21, 2014 at 02:37:22PM +0530, Pratyush Anand wrote: > > Hi Sarah, > > > > I h

Query: Link Power management support for xhci platform driver

2014-03-21 Thread Pratyush Anand
Hi Sarah, I have to implement dynamic U1/U2 initiation on a dwc3 based xhci platform. I can see that my host starts sending LGO_U1 (when idle) by enabling XHCI_LPM_SUPPORT & XHCI_INTEL_HOST quirk in xhci_plat_quirks and using xhci_enable/disable_usb3_lpm_timeout in xhci_plat_xhci_driver. But offc

Re: What to use for usb transfer from gadget to host?

2014-03-20 Thread Pratyush Anand
On Thu, Mar 20, 2014 at 10:11:42PM +0800, tzi...@me.com wrote: > Hello! > > I am developing on a phyFlex iMx.6 and want to send data via USB to a > Host connected via the OTG port. > The data is images from an image sensor, so I need a high performance (USB > 2.0). How is your image sensor drive

Re: [PATCH 04/11] usb: dwc3: gadget: implement dwc3_gadget_get_link_state

2014-02-26 Thread Pratyush Anand
On Wed, Feb 26, 2014 at 03:40:36AM +0800, Felipe Balbi wrote: > From: Paul Zimmerman > > This function will be used during hibernation to get > the current link state. It will be needed at least > for Hibernation support. > Since we do receive linksts_change_interrupt, where we already update d

Re: [PATCH 00/11] usb: dwc3: more hibernation helpers

2014-02-26 Thread Pratyush Anand
On Wed, Feb 26, 2014 at 03:40:32AM +0800, Felipe Balbi wrote: Adding Amit for whome it will be very useful as he was about to start some work related to hibernation. Regards Pratyush > Hi, > > these series cleans up dwc3 a little bit and adds more > boiler plate code for hibernation support. Not

Re: EG20T USB Gadget Performance

2014-01-13 Thread Pratyush Anand
On Tue, Jan 14, 2014 at 02:06:13PM +0800, Alan Ott wrote: > On 01/14/2014 12:08 AM, Rajaram R wrote: > > I guess it is something to do with the buffer size of the gadget > > driver. Could you please try change the buffer size to 16K and confirm > > if the delay is shifting ? In this case your delay

Re: Asymmetric speed results with testusb/usbtest/g_zero

2014-01-07 Thread Pratyush Anand
On Tue, Jan 07, 2014 at 07:41:27PM +0800, Conor O'Gorman wrote: > Hi, > > I'm seeing peak rates of about 50 Mbps write speeds, and 150 Mbps read. > Setup is host AMD SB700/SB800/Hudson-2/3 and Atheros SoC, using testusb > tool with usbtest module and g_zero gadget module on TI AM335x. > > Is th

Re: [PATCH] usb: dwc3: ep0: Handle variable-length Data Stage

2013-12-18 Thread Pratyush Anand
Hi Anton, On Wed, Dec 18, 2013 at 12:11:33PM +0800, Felipe Balbi wrote: > Hi, > > On Tue, Dec 17, 2013 at 03:59:31PM +0900, Anton Tikhomirov wrote: > > In accordance with specification, when sent data length is > > please mention section of specification. > > > an exact multiple of wMaxPacketSi

Re: Xhci Host not allowed to send get device desc at addr zero

2013-11-26 Thread Pratyush Anand
Hi Aymen On Tue, Nov 26, 2013 at 4:31 PM, Aymen BOUATTAY wrote: > Hi, > > I'm using Kernel release 3.4 with an embedded xhci host controller > Seems USB core driver does not allow xhci controller to send a get device > descriptor at address zero > As when a device is attached to the root hub,

Re: Query: DWC3: PHY Suspend bit behavior

2013-11-18 Thread Pratyush Anand
On Tue, Nov 19, 2013 at 03:12:36AM +0800, Paul Zimmerman wrote: > > From: Pratyush Anand [mailto:pratyush.an...@st.com] > > Sent: Sunday, November 17, 2013 8:24 PM > > > > Hi Paul/Felipe, > > > > Any comment? > > > > Regards > > Prat

  1   2   3   >