Re: [PATCH] hso: fix refcnt leak in recent patch.

kref_put(&serial->parent->ref, hso_serial_ref_free); > > > > after hso_serial_ref_free has been called, which dereferences a freed > > pointer. > > > > This patch adds the missing kref_get(). > > > > Fixes: commit 29bd3bc1194c624ce863cab2a7d

Re: [PATCH] hso: fix refcnt leak in recent patch.

in calls to > >kref_put(&serial->parent->ref, hso_serial_ref_free); > > > > after hso_serial_ref_free has been called, which dereferences a freed > > pointer. > > > > This patch adds the missing kref_get(). > > > > Fixes: commit 29bd3bc1194c6

Re: [PATCH v2 11/11] hso: fix rfkill name conflicts

Hello Dan, On Fri, Jan 30, 2015 at 09:47:59AM -0600, Dan Williams wrote: > On Fri, 2015-01-30 at 13:22 +0100, Olivier Sobrie wrote: > > By using only the usb interface number for the rfkill name, we might > > have a name conflicts in case two similar hso devices are connected. &

[PATCH v2 00/11] hso: fix some problems in the disconnect path

fix the issue. See http://marc.info/?l=linux-usb&m=142186699418489 for more info. - Added an extra patch avoiding name conflicts for the rfkill interface. Olivier Sobrie (11): hso: remove useless header file timer.h hso: fix crash when device disappears while serial port is open

[PATCH v2 02/11] hso: fix crash when device disappears while serial port is open

is called at the end of the hangup process and we drop the last kref in this function when all the ports have been closed, when tty_port is no more needed and when it is safe to free the structure containing the tty_port structure. Signed-off-by: Olivier Sobrie --- drivers/net/usb/hso.c | 17

[PATCH v2 01/11] hso: remove useless header file timer.h

No timer related function is used in this driver. Signed-off-by: Olivier Sobrie --- drivers/net/usb/hso.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c index babda7d..cb0bcc1 100644 --- a/drivers/net/usb/hso.c +++ b/drivers/net/usb/hso.c

[PATCH v2 04/11] hso: fix memory leak in hso_create_rfkill()

When the rfkill interface was created, a buffer containing the name of the rfkill node was allocated. This buffer was never freed when the device disappears. To fix the problem, we put the name given to rfkill_alloc() in the hso_net structure. Signed-off-by: Olivier Sobrie --- drivers/net/usb

[PATCH v2 03/11] hso: fix memory leak when device disconnects

In the disconnect path, tx_buffer should freed like tx_data to avoid a memory leak when the device disconnects. Signed-off-by: Olivier Sobrie --- drivers/net/usb/hso.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c index 3a6c630..470ef9e 100644

[PATCH v2 05/11] hso: fix small indentation error

Simply remove the useless extra tab. Signed-off-by: Olivier Sobrie --- drivers/net/usb/hso.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c index a49ac2e..2f2343d 100644 --- a/drivers/net/usb/hso.c +++ b/drivers/net/usb

[PATCH v2 08/11] hso: move tty_unregister outside hso_serial_common_free()

x3d8/0x560) [] (worker_thread) from [] (kthread+0xc0/0xcc) [] (kthread) from [] (ret_from_fork+0x14/0x24) ---[ end trace cb88537fdc8fa208 ]--- Signed-off-by: Olivier Sobrie --- drivers/net/usb/hso.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/net/usb/hso.c

[PATCH v2 07/11] hso: replace reset_device work by usb_queue_reset_device()

There is no need for a dedicated reset work in the hso driver since there is already a reset work foreseen in usb_interface that does the same. Signed-off-by: Olivier Sobrie --- drivers/net/usb/hso.c | 25 + 1 file changed, 1 insertion(+), 24 deletions(-) diff --git a

[PATCH v2 06/11] hso: rename hso_dev into serial in hso_free_interface()

In other functions of the driver, variables of type "struct hso_serial" are denoted by "serial" and variables of type "struct hso_device" are denoted by "hso_dev". This patch makes the hso_free_interface() consistent with these notations. Signed-off-by: Ol

[PATCH v2 10/11] hso: add missing cancel_work_sync in disconnect()

For hso serial devices, two cancel_work_sync were missing in the disconnect method. Signed-off-by: Olivier Sobrie --- drivers/net/usb/hso.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c index c916ab5..c14fc80 100644 --- a/drivers/net/usb

[PATCH v2 09/11] hso: update serial_table in usb disconnect method

for serial port linked to usb interface "x" and possibly crash because the tty_port structure contained in the hso_device structure has been freed. Signed-off-by: Olivier Sobrie --- drivers/net/usb/hso.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/us

[PATCH v2 11/11] hso: fix rfkill name conflicts

: Dan Williams Signed-off-by: Olivier Sobrie --- drivers/net/usb/hso.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c index c14fc80..d31a165 100644 --- a/drivers/net/usb/hso.c +++ b/drivers/net/usb/hso.c @@ -153,7 +153,7

Re: [PATCH 11/11] usb: core: fix a race with usb_queue_reset_device()

Hello Alan, On Tue, Jan 20, 2015 at 10:26:30AM -0500, Alan Stern wrote: > On Tue, 20 Jan 2015, Olivier Sobrie wrote: > > > When usb_queue_reset() is called it schedules a work in view of > > resetting the usb interface. When the reset work is running, it > > can be sche

Re: [PATCH 11/11] usb: core: fix a race with usb_queue_reset_device()

On Tue, Jan 20, 2015 at 10:26:30AM -0500, Alan Stern wrote: > On Tue, 20 Jan 2015, Olivier Sobrie wrote: > > > When usb_queue_reset() is called it schedules a work in view of > > resetting the usb interface. When the reset work is running, it > > can be scheduled again (e.

Re: [PATCH 04/11] hso: fix memory leak in hso_create_rfkill()

On Tue, Jan 20, 2015 at 02:13:17PM +0100, Oliver Neukum wrote: > On Tue, 2015-01-20 at 13:29 +0100, Olivier Sobrie wrote: > > When the rfkill interface was created, a buffer containing the name > > of the rfkill node was allocated. This buffer was never freed when the > &

Re: [PATCH 11/11] usb: core: fix a race with usb_queue_reset_device()

Hi Oliver, On Tue, Jan 20, 2015 at 02:48:37PM +0100, Oliver Neukum wrote: > On Tue, 2015-01-20 at 13:29 +0100, Olivier Sobrie wrote: > > When usb_queue_reset() is called it schedules a work in view of > > resetting the usb interface. When the reset work is running, it > > c

[PATCH 00/11] hso: fix some problems with reset/disconnect path

queued on an usb interface. This serie of patches is based on v3.18. Olivier Sobrie (11): hso: remove useless header file timer.h hso: fix crash when device disappears while serial port is open hso: fix memory leak when device disconnects hso: fix memory leak in hso_create_rfkill() hso: fix

[PATCH 02/11] hso: fix crash when device disappears while serial port is open

is called at the end of the hangup process and we drop the last kref in this function when all the ports have been closed, when tty_port is no more needed and when it is safe to free the structure containing the tty_port structure. Signed-off-by: Olivier Sobrie --- drivers/net/usb/hso.c | 17

[PATCH 04/11] hso: fix memory leak in hso_create_rfkill()

When the rfkill interface was created, a buffer containing the name of the rfkill node was allocated. This buffer was never freed when the device disappears. To fix the problem, we put the name given to rfkill_alloc() in the hso_net structure. Signed-off-by: Olivier Sobrie --- drivers/net/usb

[PATCH 03/11] hso: fix memory leak when device disconnects

In the disconnect path, tx_buffer should freed like tx_data to avoid a memory leak when the device disconnects. Signed-off-by: Olivier Sobrie --- drivers/net/usb/hso.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c index 3a6c630..470ef9e 100644

[PATCH 01/11] hso: remove useless header file timer.h

No timer related function is used in this driver. Signed-off-by: Olivier Sobrie --- drivers/net/usb/hso.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c index babda7d..cb0bcc1 100644 --- a/drivers/net/usb/hso.c +++ b/drivers/net/usb/hso.c

[PATCH 08/11] hso: move tty_unregister outside hso_serial_common_free()

x3d8/0x560) [] (worker_thread) from [] (kthread+0xc0/0xcc) [] (kthread) from [] (ret_from_fork+0x14/0x24) ---[ end trace cb88537fdc8fa208 ]--- Signed-off-by: Olivier Sobrie --- drivers/net/usb/hso.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/net/usb/hso.c

[PATCH 07/11] hso: replace reset_device work by usb_queue_reset_device()

There is no need for a dedicated reset work in the hso driver since there is already a reset work foreseen in usb_interface that does the same. Signed-off-by: Olivier Sobrie --- drivers/net/usb/hso.c | 25 + 1 file changed, 1 insertion(+), 24 deletions(-) diff --git a

[PATCH 09/11] hso: update serial_table in usb disconnect method

for serial port linked to usb interface "x" and possibly crash because the tty_port structure contained in the hso_device structure has been freed. Signed-off-by: Olivier Sobrie --- drivers/net/usb/hso.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/us

[PATCH 11/11] usb: core: fix a race with usb_queue_reset_device()

work that should be run To avoid this problem, we use a delayed work so that if the reset work is currently run, we can avoid further call to __usb_queue_reset_device() work by using cancel_delayed_work(). Unfortunately it increases the size of the usb_interface structure... Signed-off-by: O

[PATCH 05/11] hso: fix small indentation error

Simply remove the useless extra tab. Signed-off-by: Olivier Sobrie --- drivers/net/usb/hso.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c index a49ac2e..2f2343d 100644 --- a/drivers/net/usb/hso.c +++ b/drivers/net/usb

[PATCH 10/11] hso: add missing cancel_work_sync in disconnect()

For hso serial devices, two cancel_work_sync were missing in the disconnect method. Signed-off-by: Olivier Sobrie --- drivers/net/usb/hso.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c index c916ab5..c14fc80 100644 --- a/drivers/net/usb

[PATCH 06/11] hso: rename hso_dev into serial in hso_free_interface()

In other functions of the driver, variables of type "struct hso_serial" are denoted by "serial" and variables of type "struct hso_device" are denoted by "hso_dev". This patch makes the hso_free_interface() consistent with these notations. Signed-off-by: Ol

Re: [PATCH v4 4/4] can: kvaser_usb: Retry first bulk transfer on -ETIMEDOUT

Hello, On Mon, Jan 12, 2015 at 05:14:07AM -0500, Ahmed S. Darwish wrote: > On Sun, Jan 11, 2015 at 09:51:10PM +0100, Marc Kleine-Budde wrote: > > On 01/11/2015 09:45 PM, Ahmed S. Darwish wrote: > > > From: Ahmed S. Darwish > > > > > > (This is a draft patch, I'm not sure if this fixes the USB >

[PATCH v2 2/2] hso: fix deadlock when receiving bursts of data

oom in the tty buffer, discards all the data received in the URB. Cc: David Miller Cc: David Laight Cc: One Thousand Gnomes Cc: Dan Williams Cc: Jan Dumon Signed-off-by: Olivier Sobrie --- Changes in v2: - remove the unthrottle timer added in the previous patch version - drop entire rx u

[PATCH v2 1/2] hso: remove unused workqueue

The workqueue "retry_unthrottle_workqueue" is not scheduled anywhere in the code. So, remove it. Signed-off-by: Olivier Sobrie --- drivers/net/usb/hso.c | 12 1 file changed, 12 deletions(-) diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c index a3a0586..9ca2

[PATCH v2 2/2] hso: fix deadlock when receiving bursts of data

oom in the tty buffer, discards all the data received in the URB. Cc: David Miller Cc: David Laight Cc: One Thousand Gnomes Cc: Dan Williams Cc: Jan Dumon Signed-off-by: Olivier Sobrie --- Changes in v2: - remove the unthrottle timer added in the previous patch version - drop entire rx u

Re: [PATCH 2/2] hso: fix deadlock when receiving bursts of data

On Fri, Jul 11, 2014 at 09:28:47AM +, David Laight wrote: > From: Olivier Sobrie Olivier Sobrie > > Hi Alan and Davids, > > > > On Thu, Jul 10, 2014 at 04:50:03PM +0100, One Thousand Gnomes wrote: > > > On Thu, 10 Jul 2014 14:37:37 + > > > David Lai

Re: [PATCH 2/2] hso: fix deadlock when receiving bursts of data

Hi Alan and Davids, On Thu, Jul 10, 2014 at 04:50:03PM +0100, One Thousand Gnomes wrote: > On Thu, 10 Jul 2014 14:37:37 + > David Laight wrote: > > > From: Olivier Sobrie > > ... > > > The function put_rxbuf_data() is called from the urb completion handler. >

Re: [PATCH 2/2] hso: fix deadlock when receiving bursts of data

Hi David, On Tue, Jul 08, 2014 at 04:16:33PM -0700, David Miller wrote: > From: Olivier Sobrie > Date: Mon, 7 Jul 2014 11:06:07 +0200 > > > When the module sends bursts of data, sometimes a deadlock happens in > > the hso driver when the tty buffer doesn't ge

Re: [PATCH 2/2] hso: fix deadlock when receiving bursts of data

Hi Dan, On Mon, Jul 07, 2014 at 11:41:20AM -0500, Dan Williams wrote: > On Mon, 2014-07-07 at 11:06 +0200, Olivier Sobrie wrote: > > When the module sends bursts of data, sometimes a deadlock happens in > > the hso driver when the tty buffer doesn't get the chance to be flushe

Re: [PATCH 2/2] hso: fix deadlock when receiving bursts of data

On Mon, Jul 07, 2014 at 12:55:44PM +, David Laight wrote: > From: Olivier Sobrie > > Hi David, > > > > On Mon, Jul 07, 2014 at 09:13:53AM +, David Laight wrote: > > > From: Olivier Sobrie > > > > When the module sends bursts of data, sometimes a

Re: [PATCH 2/2] hso: fix deadlock when receiving bursts of data

Hi David, On Mon, Jul 07, 2014 at 09:13:53AM +, David Laight wrote: > From: Olivier Sobrie > > When the module sends bursts of data, sometimes a deadlock happens in > > the hso driver when the tty buffer doesn't get the chance to be flushed > > quickly enough. >

[PATCH 2/2] hso: fix deadlock when receiving bursts of data

re is no room anymore in the tty buffer, we set up a timer of 100 msecs to give a chance to the upper layer to flush the tty buffer and make room for new data. Signed-off-by: Olivier Sobrie --- drivers/net/usb/hso.c | 51 + 1 file change

[PATCH 1/2] hso: remove unused workqueue

The workqueue "retry_unthrottle_workqueue" is not scheduled anywhere in the code. So, remove it. Signed-off-by: Olivier Sobrie --- drivers/net/usb/hso.c | 12 1 file changed, 12 deletions(-) diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c index a3a0586..9ca2

[PATCH] esd_usb2: Do not do dma on the stack

e stack (&msg) See "Documentation/DMA-API-HOWTO.txt" section "What memory is DMA'able?" Signed-off-by: Olivier Sobrie Cc: Matthias Fuchs --- drivers/net/can/usb/esd_usb2.c | 127 1 file changed, 76 insertions(+), 51 deletions(

Re: [PATCH v2] kvaser_usb: fix "dma on the stack" errors

On Fri, Nov 23, 2012 at 03:08:08PM +0100, Marc Kleine-Budde wrote: > On 11/23/2012 02:54 PM, Olivier Sobrie wrote: > > The dma buffer given to usb_bulk_msg() must be allocated and not on > > the stack. > > See Documentation/DMA-API-HOWTO.txt section "What memory is DMA&

[PATCH v2] kvaser_usb: fix "dma on the stack" errors

The dma buffer given to usb_bulk_msg() must be allocated and not on the stack. See Documentation/DMA-API-HOWTO.txt section "What memory is DMA'able?" Signed-off-by: Olivier Sobrie --- drivers/net/can/usb/kvaser_usb.c | 111 -- 1 file changed

Re: [PATCH] kvaser_usb: fix "dma on the stack" errors

On Fri, Nov 23, 2012 at 02:30:28PM +0100, Olivier Sobrie wrote: > The dma buffer given to usb_bulk_msg() must be allocated and not on > the stack. > See Documentation/DMA-API-HOWTO.txt section "What memory is DMA'able?" > > Signed-off-by: Olivier Sobrie > --

[PATCH] kvaser_usb: fix "dma on the stack" errors

The dma buffer given to usb_bulk_msg() must be allocated and not on the stack. See Documentation/DMA-API-HOWTO.txt section "What memory is DMA'able?" Signed-off-by: Olivier Sobrie --- Here is the incremental patch. Thank you Greg ! Olivier drivers/net/can/usb/kvas

Re: [PATCH v6] can: kvaser_usb: Add support for Kvaser CAN/USB devices

g/?p=linux/kernel/git/torvalds/linux.git;a=commitdiff;h=32ec4576c3fb37316b1d11a04b220527822f3f0d Thanks, Olivier On Wed, Nov 21, 2012 at 08:11:13AM +0100, Olivier Sobrie wrote: > This driver provides support for several Kvaser CAN/USB devices. > Such kind of devices supports up to three C

[PATCH v6] can: kvaser_usb: Add support for Kvaser CAN/USB devices

f this driver are based on the following: + * - Kvaser linux leaf driver (version 4.78) + * - CAN driver for esd CAN-USB/2 + * + * Copyright (C) 2002-2006 KVASER AB, Sweden. All rights reserved. + * Copyright (C) 2010 Matthias Fuchs , esd gmbh + * Copyright (C) 2012 Olivier Sobrie + */ + +#include +#

Re: [PATCH v5] can: kvaser_usb: Add support for Kvaser CAN/USB devices

Hi Marc, On Wed, Nov 07, 2012 at 09:29:05PM +0100, Marc Kleine-Budde wrote: > On 10/02/2012 09:16 AM, Olivier Sobrie wrote: > > This driver provides support for several Kvaser CAN/USB devices. > > Such kind of devices supports up to three CAN network interfaces. > > > >

[PATCH v5] can: kvaser_usb: Add support for Kvaser CAN/USB devices

6 KVASER AB, Sweden. All rights reserved. + * Copyright (C) 2010 Matthias Fuchs , esd gmbh + * Copyright (C) 2012 Olivier Sobrie + */ + +#include +#include +#include +#include +#include + +#include +#include +#include + +#define MAX_TX_URBS16 +#define MAX_RX_URBS

Re: [PATCH v4] can: kvaser_usb: Add support for Kvaser CAN/USB devices

Hi Marc and Wolfgang, On Sat, Sep 22, 2012 at 06:02:14PM +0200, Wolfgang Grandegger wrote: > On 09/21/2012 11:54 AM, Marc Kleine-Budde wrote: > > On 09/20/2012 07:06 AM, Olivier Sobrie wrote: > >> This driver provides support for several Kvaser CAN/USB devices. > >> Su

[PATCH v4] can: kvaser_usb: Add support for Kvaser CAN/USB devices

BlackBird SemiPro - Kvaser OEM Mercury - Kvaser OEM Leaf - Kvaser USBcan R Signed-off-by: Olivier Sobrie --- Changes since v3: - add support for CMD_LOG_MESSAGE drivers/net/can/usb/Kconfig | 33 + drivers/net/can/usb/Makefile |1 + drivers/net/can/usb/kvaser_us

[PATCH v3] can: kvaser_usb: Add support for Kvaser CAN/USB devices

BlackBird SemiPro - Kvaser OEM Mercury - Kvaser OEM Leaf - Kvaser USBcan R Signed-off-by: Olivier Sobrie --- Changes since v2: - update of error handling - add method do_get_berr_counter if hardware support it - fix race condition in probe function - ... Here is the behavior in case

Re: [PATCH v2] can: kvaser_usb: Add support for Kvaser CAN/USB devices

On Wed, Aug 08, 2012 at 10:25:35AM +0200, Wolfgang Grandegger wrote: > Hi Oliver, > > On 08/08/2012 08:14 AM, Olivier Sobrie wrote: > > Hi Wolfgang, > > > > On Tue, Aug 07, 2012 at 08:26:38AM +0200, Wolfgang Grandegger wrote: > >> On 08/06/2012 07:21 AM, Oli

Re: [PATCH v2] can: kvaser_usb: Add support for Kvaser CAN/USB devices

Hi Wolfgang, On Tue, Aug 07, 2012 at 08:26:38AM +0200, Wolfgang Grandegger wrote: > On 08/06/2012 07:21 AM, Olivier Sobrie wrote: > > This driver provides support for several Kvaser CAN/USB devices. > > Such kind of devices supports up to three can network interfaces. > >

Re: [PATCH v2] can: kvaser_usb: Add support for Kvaser CAN/USB devices

Hi Oliver, On Mon, Aug 06, 2012 at 10:10:43AM +0200, Oliver Neukum wrote: > On Monday 06 August 2012 07:21:29 Olivier Sobrie wrote: > > This driver provides support for several Kvaser CAN/USB devices. > > Such kind of devices supports up to three can network interfaces. >

[PATCH v2] can: kvaser_usb: Add support for Kvaser CAN/USB devices

BlackBird SemiPro - Kvaser OEM Mercury - Kvaser OEM Leaf - Kvaser USBcan R Signed-off-by: Olivier Sobrie --- Changes since v1: - added copyrights - kvaser_usb.h merged into kvaser.c - added kvaser_usb_get_endpoints to find eindpoints instead of hardcoding their address - some c