Re: [PATCH V3 3/3] arm64: dts: sdm845: Add interconnect properties for USB

dwc3: dwc3@a80 { > compatible = "snps,dwc3"; > reg = <0 0x0a80 0 0xcd00>; Please collect tags from earlier versions, unless the new version has 'major' changes (which is a bit of a judgement call). Reviewed-by: Matthias Kaehlcke

Re: [PATCH V3 2/3] usb: dwc3: qcom: Add interconnect support in dwc3 driver

On Tue, Sep 17, 2019 at 04:40:48PM +0530, Chandana Kishori Chiluveru wrote: > Add interconnect support in dwc3-qcom driver to vote for bus > bandwidth. > > This requires for two different paths - from USB master to > DDR slave. The other is from APPS master to USB slave. > > Signed-off-by: Chanda

Re: [PATCH V3 1/3] dt-bindings: Introduce interconnect properties for Qualcomm DWC3 driver

b-ddr", "apps-usb"; > interrupts = <0 131 0>, <0 486 0>, <0 488 0>, <0 489 0>; > interrupt-names = "hs_phy_irq", "ss_phy_irq", > "dm_hs_phy_irq", "dp_hs_phy_irq"; Reviewed-by: Matthias Kaehlcke

Re: [PATCH V2 2/3] usb: dwc3: qcom: Add interconnect support in dwc3 driver

Hi Chandana, On Tue, Sep 17, 2019 at 04:39:20PM +0530, cchil...@codeaurora.org wrote: > Hi Matthias, > > Thanks for the review. I Will address below comments and post changes in new > version. > > On 2019-09-17 03:54, Matthias Kaehlcke wrote: > > Hi Chandana, > >

Re: [PATCH V2 3/3] arm64: dts: sdm845: Add interconnect properties for USB

MASTER_USB3_1 > + &rsc_hlos SLAVE_EBI1>, > + <&rsc_hlos MASTER_APPSS_PROC > + &rsc_hlos SLAVE_USB3_1>; > + interconnect-names = "usb-ddr", "apps-usb"; > + > usb_2_dwc3: dwc3@a80 { > compatible = "snps,dwc3"; > reg = <0 0x0a80 0 0xcd00>; Besides the nits: Reviewed-by: Matthias Kaehlcke

Re: [PATCH V2 2/3] usb: dwc3: qcom: Add interconnect support in dwc3 driver

Hi Chandana, On Mon, Sep 16, 2019 at 05:11:00PM +0530, Chandana Kishori Chiluveru wrote: > Add interconnect support in dwc3-qcom driver to vote for bus > bandwidth. > > This requires for two different paths - from USB master to > DDR slave. The other is from APPS master to USB slave. > > Signed-

Re: [PATCH 1/3] dt-bindings: Introduce interconnect bindings for usb

On Wed, Sep 11, 2019 at 10:24:33AM +0530, Chandana Kishori Chiluveru wrote: > Add documentation for the interconnects and interconnect-names > bindings for USB as detailed by bindings/interconnect/interconnect.txt. This isn't a generic binding for USB, but for the qcom,dwc3, the commit message (in

[PATCH] net1080: Remove unused function nc_dump_ttl()

The function is not used, removing it fixes the following warning when building with clang: drivers/net/usb/net1080.c:271:20: error: unused function 'nc_dump_ttl' [-Werror,-Wunused-function] Also remove the definition of TTL_THIS, which is only used in nc_dump_ttl() Signed-off-by

[PATCH] r8152: Remove unused function usb_ocp_read()

The function is not used, removing it fixes the following warning when building with clang: drivers/net/usb/r8152.c:825:5: error: unused function 'usb_ocp_read' [-Werror,-Wunused-function] Signed-off-by: Matthias Kaehlcke --- drivers/net/usb/r8152.c | 6 -- 1 file changed, 6

Re: [PATCH] net1080: Mark nc_dump_ttl() as __maybe_unused

Hi David, El Thu, May 18, 2017 at 10:48:08AM -0400 David Miller ha dit: > From: Matthias Kaehlcke > Date: Wed, 17 May 2017 15:17:08 -0700 > > > The function is not used, but it looks useful for debugging. Adding the > > attribute fixes the following clang warning: >

[PATCH] r8152: Mark usb_ocp_read() as __maybe_unused

The function is not used, but is probably kept around for debugging and symmetry with usb_ocp_write(). Adding the attribute fixes the following clang warning: drivers/net/usb/r8152.c:825:5: error: unused function 'usb_ocp_read' [-Werror,-Wunused-function] Signed-off-by: Matthia

[PATCH] net1080: Mark nc_dump_ttl() as __maybe_unused

The function is not used, but it looks useful for debugging. Adding the attribute fixes the following clang warning: drivers/net/usb/net1080.c:271:20: error: unused function 'nc_dump_ttl' [-Werror,-Wunused-function] Signed-off-by: Matthias Kaehlcke --- drivers/net/usb/net1080.c

Re: [PATCH v5 2/6] power: add power sequence library

d-off-by: Peter Chen > Tested-by Joshua Clayton Reviewed-by: Matthias Kaehlcke Tested-by: Matthias Kaehlcke -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v4 2/6] power: add power sequence library

El Tue, Aug 02, 2016 at 11:30:48AM +0800 Peter Chen ha dit: > diff --git a/drivers/power/pwrseq/core.c b/drivers/power/pwrseq/core.c > > ... > > +static DEFINE_MUTEX(pwrseq_list_mutex); > +static LIST_HEAD(pwrseq_list); > + > +int pwrseq_get(struct device_node *np, struct pwrseq *p) > +{ > + i

Re: [v3,2/6] power: add power sequence library

Hi Peter, Thanks for your work on this, a few comments inline On 07/20/2016 02:40 AM, Peter Chen wrote: ... +static int pwrseq_generic_on(struct device_node *np, struct pwrseq *pwrseq) +{ ... + if (gpiod_reset) { + u32 duration_us = 50; + + of_property_rea