[PATCH v2 3/3] ARM: dts: exynos: Rename power domain nodes to "power-domain" in Exynos4

2019-10-02 Thread Krzysztof Kozlowski
The device node name should reflect generic class of a device so rename power domain nodes to "power-domain". No functional change. Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/exynos4.dtsi| 14 +++--- arch/arm/boot/dts/exynos4210.dtsi | 2 +- arch/ar

[PATCH v2 1/3] dt-bindings: power: Convert Generic Power Domain bindings to json-schema

2019-10-02 Thread Krzysztof Kozlowski
Convert Generic Power Domain bindings to DT schema format using json-schema. The consumer bindings are split to separate file. Signed-off-by: Krzysztof Kozlowski --- Changes since v1: 1. Select all nodes for consumers, 2. Remove from consumers duplicated properties with dt-schema, 3. Fix

Re: [PATCH] ARM: s3c64xx: squash samsung_usb_phy.h into setup-usb-phy.c

2019-08-21 Thread Krzysztof Kozlowski
On Tue, Aug 20, 2019 at 12:56:02AM +0900, Masahiro Yamada wrote: > This is only used by arch/arm/mach-s3c64xx/setup-usb-phy.c > > $ git grep samsung_usb_phy_type > include/linux/usb/samsung_usb_phy.h:enum samsung_usb_phy_type { > $ git grep USB_PHY_TYPE_DEVICE > arch/arm/mach-s3c64xx/setup-usb-phy

Re: [PATCH v2 3/3] ARM: dts: exynos: Use standard arrays of generic PHYs for EHCI/OHCI devices

2019-07-26 Thread Krzysztof Kozlowski
On Fri, 26 Jul 2019 at 10:15, Marek Szyprowski wrote: > > Move USB PHYs to a standard arrays for Exynos EHCI/OHCI devices. This > resolves the conflict between Exynos EHCI/OHCI sub-nodes and generic USB > device bindings. Once the Exynos EHCI/OHCI sub-nodes are removed, the > boards can finally pr

Re: [PATCH v2 2/3] usb: exynos: add support for getting PHYs from the standard dt array

2019-07-26 Thread Krzysztof Kozlowski
drivers/usb/host/ehci-exynos.c | 23 +++ > drivers/usb/host/ohci-exynos.c | 23 +++ > 2 files changed, 38 insertions(+), 8 deletions(-) Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v2 1/3] dt-bindings: switch Exynos EHCI/OHCI bindings to use array of generic PHYs

2019-07-26 Thread Krzysztof Kozlowski
ed-by: Rob Herring > Signed-off-by: Marek Szyprowski > --- > .../devicetree/bindings/usb/exynos-usb.txt| 41 +++---- > 1 file changed, 14 insertions(+), 27 deletions(-) Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 4/4] arm64: dts: exynos: Update DWC3 modules on Exynos5433 SoCs

2018-11-13 Thread Krzysztof Kozlowski
On Tue, Sep 18, 2018 at 10:16:53AM +0200, Marek Szyprowski wrote: > Update DWC3 hardware modules to Exynos5433 specific variant: change > compatible name and add all required clocks (both to the glue node and > DWC3 core node). > > Signed-off-by: Marek Szyprowski > --- > arch/arm64/boot/dts/exyn

Re: [PATCH v3] arm64: dts: exynos: add OF graph between USB-PHY and MUIC

2018-09-21 Thread Krzysztof Kozlowski
On Fri, Sep 21, 2018 at 03:13:55PM +0200, Andrzej Hajda wrote: > OF graph describes USB data lanes between USB-PHY and respective MUIC. > Since graph is present and DWC driver can use it to get extcon, obsolete > extcon property can be removed. > > Signed-off-by: Andrzej Hajda > --- > v3: > - re

Re: [PATCH 4/4] arm64: dts: exynos: Update DWC3 modules on Exynos5433 SoCs

2018-09-19 Thread Krzysztof Kozlowski
On Tue, Sep 18, 2018 at 10:16:53AM +0200, Marek Szyprowski wrote: > Update DWC3 hardware modules to Exynos5433 specific variant: change > compatible name and add all required clocks (both to the glue node and > DWC3 core node). > > Signed-off-by: Marek Szyprowski > --- > arch/arm64/boot/dts/exyn

Re: [PATCH v2 2/2] arm64: dts: exynos: add OF graph between USB-PHY and MUIC

2018-05-15 Thread Krzysztof Kozlowski
On Tue, May 15, 2018 at 2:12 PM, Andrzej Hajda wrote: > OF graph describes USB data lanes between USB-PHY and respective MUIC. > Since graph is present and DWC driver can use it to get extcon, obsolete > extcon property can be removed. > > Signed-off-by: Andrzej Hajda > --- > .../dts/exynos/exyn

Re: [PATCH 1/2] USB: dwc3: get extcon device by OF graph bindings

2018-05-15 Thread Krzysztof Kozlowski
On Tue, May 15, 2018 at 9:26 AM, Felipe Balbi wrote: > Andrzej Hajda writes: > >> extcon device is used to detect host/device connection. Since extcon >> OF property is deprecated, alternative method should be added. >> This method uses OF graph bindings to locate extcon. >> >> Signed-off-by: And

Re: [RFC 07/10] pinctrl: samsung: Remove support for Exynos5440

2018-05-02 Thread Krzysztof Kozlowski
On Tue, Apr 24, 2018 at 10:32:36PM +0200, Krzysztof Kozlowski wrote: > The Exynos5440 is not actively developed, there are no development > boards available and probably there are no real products with it. > Remove wide-tree support for Exynos5440. > > Signed-off-by: Krzy

Re: [RFC 01/10] ARM: dts: exynos: Remove Exynos5440

2018-05-02 Thread Krzysztof Kozlowski
On Tue, Apr 24, 2018 at 10:32:30PM +0200, Krzysztof Kozlowski wrote: > The Exynos5440 (quad-core A15 with GMAC, PCIe, SATA) was targeting > server platforms but it did not make it to the market really. There are > no development boards with it and probably there are no real products

Re: [RFC 10/10] ARM: exynos: Remove support for Exynos5440

2018-05-02 Thread Krzysztof Kozlowski
On Tue, Apr 24, 2018 at 10:32:39PM +0200, Krzysztof Kozlowski wrote: > The Exynos5440 is not actively developed, there are no development > boards available and probably there are no real products with it. > Remove wide-tree support for Exynos5440. > > Signed-off-by: Krzy

Re: [RFC 06/10] thermal: samsung: Remove support for Exynos5440

2018-04-26 Thread Krzysztof Kozlowski
On Thu, Apr 26, 2018 at 3:41 AM, Chanwoo Choi wrote: > Hi Krzysztof, > > On 2018년 04월 25일 05:32, Krzysztof Kozlowski wrote: >> The Exynos5440 is not actively developed, there are no development >> boards available and probably there are no real products with it. >> R

Re: [PATCH stable v4.4+] r8152: add Linksys USB3GIGV1 id

2018-04-26 Thread Krzysztof Kozlowski
On Thu, Apr 26, 2018 at 2:40 AM, Grant Grundler wrote: > On Wed, Apr 25, 2018 at 2:54 AM, Krzysztof Kozlowski > wrote: >> >> commit 90841047a01b452cc8c3f9b990698b264143334a upstream >> >> This linksys dongle by default comes up in cdc_ether mode. >> This pa

Re: [RFC 08/10] spi: s3c64xx: samsung: Remove support for Exynos5440

2018-04-25 Thread Krzysztof Kozlowski
On Wed, Apr 25, 2018 at 2:49 PM, Sylwester Nawrocki wrote: > On 04/24/2018 10:32 PM, Krzysztof Kozlowski wrote: >> The Exynos5440 is not actively developed, there are no development >> boards available and probably there are no real products with it. >> Remove wide-tree s

[PATCH stable v4.4+] r8152: add Linksys USB3GIGV1 id

2018-04-25 Thread Krzysztof Kozlowski
. Miller [krzk: Rebase on v4.4] Signed-off-by: Krzysztof Kozlowski --- drivers/net/usb/cdc_ether.c | 10 ++ drivers/net/usb/r8152.c | 2 ++ 2 files changed, 12 insertions(+) diff --git a/drivers/net/usb/cdc_ether.c b/drivers/net/usb/cdc_ether.c index 6578127db847..f71abe50ea6f 100644 --- a

Re: [RFC 00/10] ARM: Remove support for Exynos5440

2018-04-24 Thread Krzysztof Kozlowski
On Tue, Apr 24, 2018 at 10:50:58PM +0200, Arnd Bergmann wrote: > On Tue, Apr 24, 2018 at 10:32 PM, Krzysztof Kozlowski wrote: > > Hi, > > > > > > Overview > > > > Let's continue the removal of old platforms. We already get rid of >

[RFC 04/10] clk: samsung: Remove support for Exynos5440

2018-04-24 Thread Krzysztof Kozlowski
The Exynos5440 is not actively developed, there are no development boards available and probably there are no real products with it. Remove wide-tree support for Exynos5440. Signed-off-by: Krzysztof Kozlowski --- .../devicetree/bindings/clock/exynos5440-clock.txt | 28 drivers/clk/samsung

[RFC 03/10] cpufreq: exynos: Remove support for Exynos5440

2018-04-24 Thread Krzysztof Kozlowski
The Exynos5440 is not actively developed, there are no development boards available and probably there are no real products with it. Remove wide-tree support for Exynos5440. Signed-off-by: Krzysztof Kozlowski --- .../bindings/cpufreq/cpufreq-exynos5440.txt| 28 -- drivers/cpufreq

[RFC 06/10] thermal: samsung: Remove support for Exynos5440

2018-04-24 Thread Krzysztof Kozlowski
The Exynos5440 is not actively developed, there are no development boards available and probably there are no real products with it. Remove wide-tree support for Exynos5440. Signed-off-by: Krzysztof Kozlowski --- .../devicetree/bindings/thermal/exynos-thermal.txt | 14 +- drivers/thermal

[RFC 02/10] ata: ahci-platform: Remove support for Exynos5440

2018-04-24 Thread Krzysztof Kozlowski
The Exynos5440 is not actively developed, there are no development boards available and probably there are no real products with it. Remove wide-tree support for Exynos5440. Signed-off-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/ata/ahci-platform.txt | 1 - drivers/ata

[RFC 07/10] pinctrl: samsung: Remove support for Exynos5440

2018-04-24 Thread Krzysztof Kozlowski
The Exynos5440 is not actively developed, there are no development boards available and probably there are no real products with it. Remove wide-tree support for Exynos5440. Signed-off-by: Krzysztof Kozlowski --- drivers/pinctrl/samsung/Kconfig | 10 +- drivers/pinctrl/samsung

[RFC 10/10] ARM: exynos: Remove support for Exynos5440

2018-04-24 Thread Krzysztof Kozlowski
The Exynos5440 is not actively developed, there are no development boards available and probably there are no real products with it. Remove wide-tree support for Exynos5440. Signed-off-by: Krzysztof Kozlowski --- arch/arm/mach-exynos/Kconfig | 12 arch/arm/mach-exynos/common.h

[RFC 09/10] usb: host: exynos: Remove support for Exynos5440

2018-04-24 Thread Krzysztof Kozlowski
The Exynos5440 is not actively developed, there are no development boards available and probably there are no real products with it. Remove wide-tree support for Exynos5440. Signed-off-by: Krzysztof Kozlowski --- drivers/usb/host/ehci-exynos.c | 7 --- drivers/usb/host/ohci-exynos.c | 6

[RFC 08/10] spi: s3c64xx: samsung: Remove support for Exynos5440

2018-04-24 Thread Krzysztof Kozlowski
The Exynos5440 is not actively developed, there are no development boards available and probably there are no real products with it. Remove wide-tree support for Exynos5440. Signed-off-by: Krzysztof Kozlowski --- drivers/spi/spi-s3c64xx.c | 12 1 file changed, 12 deletions(-) diff

[RFC 05/10] i2c: s3c2410: Remove support for Exynos5440

2018-04-24 Thread Krzysztof Kozlowski
The Exynos5440 is not actively developed, there are no development boards available and probably there are no real products with it. Remove wide-tree support for Exynos5440. Signed-off-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/i2c/i2c-s3c2410.txt | 4 +--- drivers/i2c/busses

[RFC 01/10] ARM: dts: exynos: Remove Exynos5440

2018-04-24 Thread Krzysztof Kozlowski
maintenance mode. Remove all Device Tree sources for Exynos5440, as first step of removal of the platform to simplify the code and drivers. Signed-off-by: Krzysztof Kozlowski --- .../bindings/arm/samsung/samsung-boards.txt| 2 - arch/arm/boot/dts/Makefile | 2

[RFC 00/10] ARM: Remove support for Exynos5440

2018-04-24 Thread Krzysztof Kozlowski
st regards, Krzysztof [1] https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1569919.html Krzysztof Kozlowski (10): ARM: dts: exynos: Remove Exynos5440 ata: ahci-platform: Remove support for Exynos5440 cpufreq: exynos: Remove support for Exynos5440 clk: samsung: Remove support for

Re: [PATCH v5 0/6] dt-bindings: add bindings for USB physical connector

2018-03-07 Thread Krzysztof Kozlowski
On Wed, Mar 7, 2018 at 12:13 PM, Andrzej Hajda wrote: > Hi Chanwoo, Archit, > > On 07.03.2018 05:48, Chanwoo Choi wrote: >> On 2018년 03월 07일 11:12, Chanwoo Choi wrote: >>> Hi Rob and Andrzej, >>> >>> On 2018년 03월 06일 21:53, Andrzej Hajda wrote: Hi Rob, Chanwoo, Krzysztof, On 27

Re: [PATCH v5 4/6] arm64: dts: exynos: add OF graph between MHL and USB connector

2018-03-06 Thread Krzysztof Kozlowski
On Tue, Feb 27, 2018 at 08:11:32AM +0100, Andrzej Hajda wrote: > OF graph describes MHL data lanes between MHL and respective USB > connector. > > Signed-off-by: Andrzej Hajda > --- > v5: removed extra parenthesis (kbuild test robot) > v4: added missing reg property in connector's port node (Krzy

Re: [PATCH v5 3/6] arm64: dts: exynos: add micro-USB connector node to TM2 platforms

2018-03-06 Thread Krzysztof Kozlowski
On Tue, Feb 27, 2018 at 08:11:31AM +0100, Andrzej Hajda wrote: > Since USB connector bindings are available we can describe it on TM2(e). > > Signed-off-by: Andrzej Hajda > --- > arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi | 7 +++ > 1 file changed, 7 insertions(+) > Thanks, appl

Re: [PATCH v5 0/6] dt-bindings: add bindings for USB physical connector

2018-03-06 Thread Krzysztof Kozlowski
On Tue, Mar 6, 2018 at 1:53 PM, Andrzej Hajda wrote: > Hi Rob, Chanwoo, Krzysztof, > > > On 27.02.2018 08:11, Andrzej Hajda wrote: >> Hi, >> >> Thanks for reviews of previous iterations. >> >> This patchset introduces USB physical connector bindings, together with >> working example. >> I have rem

Re: [PATCH v4 4/6] arm64: dts: exynos: add OF graph between MHL and USB connector

2018-02-26 Thread Krzysztof Kozlowski
On Wed, Feb 21, 2018 at 9:55 AM, Andrzej Hajda wrote: > OF graph describes MHL data lanes between MHL and respective USB > connector. > > Signed-off-by: Andrzej Hajda > --- > v4: > - added missing reg property in connector's port node (Krzysztof) > --- > .../boot/dts/exynos/exynos5433-tm2-common

Re: [RFC PATCH v2 4/6] arm64: dts: exynos: add OF graph between MHL and USB connector

2018-02-15 Thread Krzysztof Kozlowski
On Thu, Feb 15, 2018 at 11:39 AM, Andrzej Hajda wrote: > OF graph describes MHL data lanes between MHL and respective USB > connector. > > Signed-off-by: Andrzej Hajda > --- > .../boot/dts/exynos/exynos5433-tm2-common.dtsi | 31 > +++--- > 1 file changed, 28 insertions(+), 3

Re: [PATCH 2/2] arm64: dts: exynos: add OF graph between USB-PHY and MUIC

2018-02-01 Thread Krzysztof Kozlowski
On Thu, Feb 1, 2018 at 9:19 AM, Andrzej Hajda wrote: > On 01.02.2018 08:50, Krzysztof Kozlowski wrote: >> On Wed, Jan 31, 2018 at 4:57 PM, Andrzej Hajda wrote: >>> OF graph describes USB data lanes between USB-PHY and respective MUIC. >>> Since graph is present and D

Re: [PATCH 2/2] arm64: dts: exynos: add OF graph between USB-PHY and MUIC

2018-01-31 Thread Krzysztof Kozlowski
On Wed, Jan 31, 2018 at 4:57 PM, Andrzej Hajda wrote: > OF graph describes USB data lanes between USB-PHY and respective MUIC. > Since graph is present and DWC driver can use it to get extcon, obsolete > extcon property can be removed. > > Signed-off-by: Andrzej Hajda > --- > arch/arm64/boot/dts

Re: [PATCH 1/2] ARM: dts: exynos: Add dwc3 SUSPHY quirk

2017-09-25 Thread Krzysztof Kozlowski
On Fri, Sep 22, 2017 at 10:18:54AM +0200, Andrzej Pietrasiewicz wrote: > Hi, > > W dniu 19.09.2017 o 20:10, Robin Murphy pisze: > > On 19/09/17 18:40, Krzysztof Kozlowski wrote: > > > On Mon, Sep 18, 2017 at 12:02:13PM +0200, Andrzej Pietrasiewicz wrote: > >

Re: [PATCH 1/2] ARM: dts: exynos: Add dwc3 SUSPHY quirk

2017-09-19 Thread Krzysztof Kozlowski
On Mon, Sep 18, 2017 at 12:02:13PM +0200, Andrzej Pietrasiewicz wrote: > Odroid XU4 board does not enumerate SuperSpeed devices. > This patch makes exynos5 series chips use USB SUSPHY quirk, > which solves the problem. > > Signed-off-by: Andrzej Pietrasiewicz > --- > arch/arm/boot/dts/exynos54xx

Re: USB 3.0 is broken on Odroid Xu4 on latest kernel

2017-07-19 Thread Krzysztof Kozlowski
On Wed, Jul 19, 2017 at 09:13:29PM +0300, Felipe Balbi wrote: > > Hi, > > Anand Moon writes: > > Hi Krzysztof, > > > > Today I tried to compile the latest kernel for Odroid xu4. > > using exynos_defconfig I build and loaded the kernel. > > but to my surprise usb 3.0 device and missing. > > > > o

[PATCH] dt-bindings: usb: exynos-usb: Add missing required VDD properties

2017-06-13 Thread Krzysztof Kozlowski
Since commit bd8ce544ec35 ("usb: dwc3: exynos: Make provision for vdd regulators") vdd33-supply and vdd10-supply are required so document them in bindings. Signed-off-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/usb/exynos-usb.txt | 4 1 file changed, 4 insertion

Re: [PATCH] usb: dwc3: exynos: Handle return value of clk_prepare_enable

2017-06-12 Thread Krzysztof Kozlowski
-) > Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] usb: host: ehci-exynos: Handle return value of clk_prepare_enable

2017-06-12 Thread Krzysztof Kozlowski
On Mon, Jun 12, 2017 at 04:45:14PM +0530, Arvind Yadav wrote: > clk_prepare_enable() can fail here and we must check its return value. > > Signed-off-by: Arvind Yadav > --- > drivers/usb/host/ehci-exynos.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > R

Re: [PATCH 2/3] mfd: tps65010: move header file out of I2C realm

2017-05-22 Thread Krzysztof Kozlowski
ard-h2.c | 2 +- > arch/arm/mach-omap1/board-h3-mmc.c | 2 +- > arch/arm/mach-omap1/board-h3.c | 2 +- > arch/arm/mach-omap1/board-osk.c | 2 +- > arch/arm/mach-s3c24xx/mach-osiris-dvs.c | 2 +- > arch/arm/mach-s3c24xx/mach-osiris.c | 2 +- For s3c24xx:

Re: Microchip USB Hub Driver Harmonization

2017-05-18 Thread Krzysztof Kozlowski
On Thu, May 18, 2017 at 7:33 AM, Richard Leitner wrote: >>> 2. What would be a good prefix for common headers/functions/macros/etc.? >>> I thought of "mcusbhub"... Would that be OK? Or are there any >>> conventions/better proposals on that? >> >> >> If you are going to develop one driver for entir

Re: Microchip USB Hub Driver Harmonization

2017-05-17 Thread Krzysztof Kozlowski
On Wed, May 17, 2017 at 12:58:38PM +0200, Richard Leitner wrote: > Hello, > due to the fact (all?) the Microchip (former SMSC) USB hubs share the > same I2C configuration interface, I'm currently working on harmonizing > those USB Hub drivers. Currently this affects the usb251xb, usb3503 and > usb4

Re: [PATCH v13 00/12] power: add power sequence library

2017-05-16 Thread Krzysztof Kozlowski
On Wed, Feb 15, 2017 at 09:38:09AM +0800, Peter Chen wrote: > On Tue, Feb 14, 2017 at 12:21:48PM +0200, Roger Quadros wrote: > > Peter, > > > > On 11/02/17 03:27, Peter Chen wrote: > > > Hi all, > > > > > > This is a follow-up for my last power sequence framework patch set [1]. > > > According to

Re: [RESEND PATCH v3 2/2] phy: Group vendor specific phy drivers

2017-03-13 Thread Krzysztof Kozlowski
; @@ -10637,7 +10637,7 @@ RENESAS USB2 PHY DRIVER > M: Yoshihiro Shimoda > L: linux-renesas-...@vger.kernel.org > S: Maintained > -F: drivers/phy/phy-rcar-gen3-usb2.c > +F: drivers/phy/renesas/phy-rcar-gen3-usb2.c > > RESET CONTROLLER FRAMEWORK >

Re: [PATCH] ARM: dts: Odroid XU4: fix USB3.0 ports

2017-02-10 Thread Krzysztof Kozlowski
On Thu, Feb 09, 2017 at 11:26:48AM +0100, Richard Genoud wrote: > I did some tests with XU3 and XU4, playing with USB2 and USB3 quirks > (snps,dis_u{2,3}_susphy_quirk) > > kernel for the tests: next-20170206 > DTBs: exynos5422-odroidxu3-lite.dtb exynos5422-odroidxu4.dtb > > USB devices used for t

Exynos5422 EHCI (USB 2.0) - Odroid XU4 - port 1 resume error -110

2017-01-29 Thread Krzysztof Kozlowski
Hi, On Odroid XU4 with an external usb2514 hub (evaluation board from SMSC or TI) connected to the USB2.0 port of EHCI controller, whenever I plug some USB device into the usb2514 hub I see errors like: [ 73.969179] exynos-ehci 1211.usb: port 1 resume error -110 [ 74.003259] usb 1-1: USB d

Re: [PATCH] ARM: dts: Odroid XU4: fix USB3.0 ports

2017-01-25 Thread Krzysztof Kozlowski
On Wed, Jan 25, 2017 at 3:48 PM, Marek Szyprowski wrote: > Hi Krzysztof, > > On 2017-01-25 08:55, Krzysztof Kozlowski wrote: >> >> On Wed, Jan 25, 2017 at 7:51 AM, Anand Moon wrote: >>> >>> On 24 January 2017 at 19:18, Richard Genoud >>> wrote: &

Re: [PATCH] ARM: dts: Odroid XU4: fix USB3.0 ports

2017-01-24 Thread Krzysztof Kozlowski
On Wed, Jan 25, 2017 at 7:51 AM, Anand Moon wrote: > Hi Richard, > > On 24 January 2017 at 19:18, Richard Genoud wrote: >> Since commit 2164a476205ccc ("usb: dwc3: set SUSPHY bit for all cores"), >> the USB ports on odroid-XU4 don't work anymore. >> >> Inserting an usb key (USB2.0) on the USB3.0

Re: [PATCH] ARM: dts: Odroid XU4: fix USB3.0 ports

2017-01-24 Thread Krzysztof Kozlowski
On Tue, Jan 24, 2017 at 02:48:09PM +0100, Richard Genoud wrote: > Since commit 2164a476205ccc ("usb: dwc3: set SUSPHY bit for all cores"), > the USB ports on odroid-XU4 don't work anymore. Hi, Thanks for the patch. Please: 1. Use recent kernel to test it, which could be one of: mainline (Linus

Re: [PATCH] usb: dwc3-exynos fix unspecified suspend clk error handling

2017-01-10 Thread Krzysztof Kozlowski
On Tue, Jan 10, 2017 at 11:37:24AM -0700, Shuah Khan wrote: > On 01/10/2017 11:23 AM, Bartlomiej Zolnierkiewicz wrote: > > I also think that regardless of what is decided on making susp_clk > > non-optional for some Exynos SoCs we should probably remove the debug > > message as it doesn't bring use

Re: [PATCH] usb: dwc3-exynos fix unspecified suspend clk error handling

2017-01-10 Thread Krzysztof Kozlowski
On Tue, Jan 10, 2017 at 06:09:40PM +0100, Bartlomiej Zolnierkiewicz wrote: > BTW What is interesting is that the Exynos7 dts patch [2] has never > made it into upstream for some reason. In the meantime however > Exynos5433 (similar to Exynos7 to some degree) became the user of > susp_clk. > > [1]

Re: [PATCH 0/4] ARM: exynos: Fix Odroid U3 USB/LAN when TFTP booting (power sequence)

2017-01-09 Thread Krzysztof Kozlowski
On Mon, Jan 09, 2017 at 11:56:41PM +0530, Anand Moon wrote: > Hi Krzysztof, > > On 9 January 2017 at 23:47, Krzysztof Kozlowski wrote: > > On Mon, Jan 09, 2017 at 11:34:48PM +0530, Anand Moon wrote: > >> Hi Krzysztof, > >> > >> On 7 January 2017 at 14

Re: [PATCH 0/4] ARM: exynos: Fix Odroid U3 USB/LAN when TFTP booting (power sequence)

2017-01-09 Thread Krzysztof Kozlowski
On Mon, Jan 09, 2017 at 11:34:48PM +0530, Anand Moon wrote: > Hi Krzysztof, > > On 7 January 2017 at 14:21, Krzysztof Kozlowski wrote: > > Hi, > > > > Thanks to Markus Reichl, I got an Odroid U3 to work with. Thanks to Peter > > Chen, we got a power sequence gen

Re: [PATCH v1.1] ARM: multi_v7_defconfig: Enable power sequence for Odroid U3

2017-01-09 Thread Krzysztof Kozlowski
On Mon, Jan 9, 2017 at 6:24 PM, Javier Martinez Canillas wrote: > Hello Krzysztof, > > I think it would had been clearer if the subject prefix was "[PATCH v1.1 > 4/4]" :) Ah, yes. > > On 01/07/2017 06:16 AM, Krzysztof Kozlowski wrote: >> Odroid U3 needs a pow

[PATCH v1.1] ARM: multi_v7_defconfig: Enable power sequence for Odroid U3

2017-01-07 Thread Krzysztof Kozlowski
Odroid U3 needs a power sequence for lan9730, if it was enabled by bootloader. Also enable the USB3503 HSCI to USB2.0 driver (device is present on Odroid U3). Signed-off-by: Krzysztof Kozlowski --- Changes since v1 (v1 -> v1.1): 1. Enable also usb3503 driver. --- arch/arm/conf

Re: [PATCH v11 4/8] usb: core: add power sequence handling for USB devices

2017-01-07 Thread Krzysztof Kozlowski
t; drivers/usb/Kconfig| 1 + > drivers/usb/core/hub.c | 48 > drivers/usb/core/hub.h | 1 + > 3 files changed, 46 insertions(+), 4 deletions(-) > Acked-by: Krzysztof Kozlowski Tested on Odroid U3 (reset sequence for LAN9730): Tested-by: Krzysztof Kozlows

Re: [PATCH v11 3/8] binding-doc: usb: usb-device: add optional properties for power sequence

2017-01-07 Thread Krzysztof Kozlowski
rtions(+), 1 deletion(-) > Acked-by: Krzysztof Kozlowski Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v11 2/8] power: add power sequence library

2017-01-07 Thread Krzysztof Kozlowski
create mode 100644 drivers/power/pwrseq/core.c > create mode 100644 drivers/power/pwrseq/pwrseq_generic.c > create mode 100644 include/linux/power/pwrseq.h > Acked-by: Krzysztof Kozlowski Tested on Odroid U3 (reset sequence for LAN9730): Tested-by: Krzysztof Kozlowski Best regards,

[PATCH 3/4] ARM: exynos_defconfig: Enable power sequence for Odroid U3

2017-01-07 Thread Krzysztof Kozlowski
Odroid U3 needs a power sequence for lan9730, if it was enabled by bootloader. Enable also GPIO_SYSFS which is useful for playing with GPIO during debug process. Signed-off-by: Krzysztof Kozlowski --- arch/arm/configs/exynos_defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch

Re: [PATCH v11 1/8] binding-doc: power: pwrseq-generic: add binding doc for generic power sequence library

2017-01-07 Thread Krzysztof Kozlowski
++ > 1 file changed, 48 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/power/pwrseq/pwrseq-generic.txt Acked-by: Krzysztof Kozlowski Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-u

[PATCH 2/4] ARM: dts: exynos: Fix LAN9730 on Odroid U3 after tftpboot

2017-01-07 Thread Krzysztof Kozlowski
e the generic power sequence driver and toggle the ENB8 (buck8) pin. Reset duration of 500 us was chosen by experiments (shortest working time was 400 us). This is an easiest way to fix the long standing LAN9730 reset issue. Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/exynos4412-odr

[PATCH 0/4] ARM: exynos: Fix Odroid U3 USB/LAN when TFTP booting (power sequence)

2017-01-07 Thread Krzysztof Kozlowski
https://lwn.net/Articles/710736/ [2] https://github.com/krzk/linux/commits/for-next/odroid-u3-usb3503-pwrseq Krzysztof Kozlowski (4): ARM: dts: exynos: Fix indentation of EHCI and OHCI ports ARM: dts: exynos: Fix LAN9730 on Odroid U3 after tftpboot ARM: exynos_defconfig: Enable power sequenc

[PATCH 1/4] ARM: dts: exynos: Fix indentation of EHCI and OHCI ports

2017-01-07 Thread Krzysztof Kozlowski
Replace spaces with tabs in EHCI and OHCI ports indentation. Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/exynos4.dtsi | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi index

[PATCH 4/4] ARM: multi_v7_defconfig: Enable power sequence for Odroid U3

2017-01-07 Thread Krzysztof Kozlowski
Odroid U3 needs a power sequence for lan9730, if it was enabled by bootloader. Signed-off-by: Krzysztof Kozlowski --- arch/arm/configs/multi_v7_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig index

[PATCH 1/2] usb: host: ehci-exynos: Decrese node refcount on exynos_ehci_get_phy() error paths

2017-01-07 Thread Krzysztof Kozlowski
PHYs") Signed-off-by: Krzysztof Kozlowski --- drivers/usb/host/ehci-exynos.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/host/ehci-exynos.c b/drivers/usb/host/ehci-exynos.c index 42e5b66353ef..7a603f66a9bc 100644 --- a/drivers/usb/host/ehci-exynos.c +++ b/drivers/usb

[PATCH 2/2] usb: host: ohci-exynos: Decrese node refcount on exynos_ehci_get_phy() error paths

2017-01-07 Thread Krzysztof Kozlowski
PHYs") Signed-off-by: Krzysztof Kozlowski --- drivers/usb/host/ohci-exynos.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/host/ohci-exynos.c b/drivers/usb/host/ohci-exynos.c index 2cd105be7319..6865b919403f 100644 --- a/drivers/usb/host/ohci-exynos.c +++ b/drivers/usb

Re: [PATCH v11 0/8] power: add power sequence library

2017-01-06 Thread Krzysztof Kozlowski
On Fri, Jan 06, 2017 at 05:18:41PM +0200, Krzysztof Kozlowski wrote: > On Thu, Jan 05, 2017 at 02:01:51PM +0800, Peter Chen wrote: > > Hi all, > > > > This is a follow-up for my last power sequence framework patch set [1]. > > According to Rob Herring and Ulf Hansson&

Re: [PATCH v11 0/8] power: add power sequence library

2017-01-06 Thread Krzysztof Kozlowski
On Thu, Jan 05, 2017 at 02:01:51PM +0800, Peter Chen wrote: > Hi all, > > This is a follow-up for my last power sequence framework patch set [1]. > According to Rob Herring and Ulf Hansson's comments[2]. The kinds of > power sequence instances will be added at postcore_initcall, the match > criter

Re: [PATCH v10 0/8] power: add power sequence library

2016-12-19 Thread Krzysztof Kozlowski
On Mon, Nov 14, 2016 at 09:35:51AM +0800, Peter Chen wrote: > Hi all, > > This is a follow-up for my last power sequence framework patch set [1]. > According to Rob Herring and Ulf Hansson's comments[2]. The kinds of > power sequence instances will be added at postcore_initcall, the match > criter

Re: [RFC v2 00/13] usb/mmc/power: Fix USB/LAN when TFTP booting

2016-12-13 Thread Krzysztof Kozlowski
On Tue, Dec 13, 2016 at 2:34 PM, Hans Verkuil wrote: > Try again, this time with Krzysztof's new email address... > > > On 13/12/16 13:20, Hans Verkuil wrote: >> >> Hi Krzysztof, >> >> This still seems to be broken with the latest 4.9 kernel, right? >> >> Has there been any progress on this? Do yo

Re: [PATCH 2/2] usb: ohci: s3c2410: allow probing from device tree

2016-11-27 Thread Krzysztof Kozlowski
esume(struct device > *dev) > .resume = ohci_hcd_s3c2410_drv_resume, > }; > > +static const struct of_device_id ohci_hcd_s3c2410_dt_ids[] = { > + { .compatible = "samsung,s3c2410-ohci" }, > + { /* sentinel */ } > +}; > + A nit, usually MODULE_DEVICE_TABLE com

Re: [PATCH 1/2] dt-bindings: usb: add DT binding for s3c2410 USB OHCI controller

2016-11-27 Thread Krzysztof Kozlowski
s3c2410-ohci" for USB host controller > + - reg: address and lenght of the controller memory mapped region s/lenght/length/ Acked-by: Krzysztof Kozlowski Best regards, Krzysztof > + - interrupts: interrupt number for the USB OHCI controller > + - clocks: Should reference the bus and host

Re: [PATCH 1/2] host: ehci-exynos: Convert to use the SET_SYSTEM_SLEEP_PM_OPS

2016-10-09 Thread Krzysztof Kozlowski
On Sun, Oct 09, 2016 at 11:57:59PM +0530, Anand Moon wrote: > hi Krzysztof, > > On 9 October 2016 at 22:57, Krzysztof Kozlowski wrote: > > On Sun, Oct 09, 2016 at 10:45:40PM +0530, Anand Moon wrote: > >> Hi Krzysztof, > >> > >> On 9 October 2016 at 22

Re: [PATCH 1/2] host: ehci-exynos: Convert to use the SET_SYSTEM_SLEEP_PM_OPS

2016-10-09 Thread Krzysztof Kozlowski
On Sun, Oct 09, 2016 at 10:45:40PM +0530, Anand Moon wrote: > Hi Krzysztof, > > On 9 October 2016 at 22:04, Krzysztof Kozlowski wrote: > > On Sun, Oct 09, 2016 at 02:34:14PM +, Anand Moon wrote: > >> Move the ehci-exynos system PM callbacks within #ifdef CONFIG_PM_SLE

Re: [PATCH 1/2] host: ehci-exynos: Convert to use the SET_SYSTEM_SLEEP_PM_OPS

2016-10-09 Thread Krzysztof Kozlowski
On Sun, Oct 09, 2016 at 02:34:14PM +, Anand Moon wrote: > Move the ehci-exynos system PM callbacks within #ifdef CONFIG_PM_SLEEP > as to avoid them being build when not used. This also allows us to use the > SET_SYSTEM_SLEEP_PM_OPS macro which simplifies the code. > > Signed-off-by: Anand Moon

Re: [BUG] Regression, usb-dwc3 not working, Odroid XU3, usb 3.0

2016-07-04 Thread Krzysztof Kozlowski
On 07/04/2016 01:33 PM, Felipe Balbi wrote: > > Hi, > > Krzysztof Kozlowski writes: > >> Hi, >> >> >> Since three recent next releases (first on 20160630), on Odroid XU3 board >> the USB 3.0 host port (the only one) stopped working. >> >>

[BUG] Regression, usb-dwc3 not working, Odroid XU3, usb 3.0

2016-07-04 Thread Krzysztof Kozlowski
Hi, Since three recent next releases (first on 20160630), on Odroid XU3 board the USB 3.0 host port (the only one) stopped working. This is a "samsung,exynos5250-dwusb3" (drivers/usb/dwc3/dwc3-exynos.c). Two issues here: 1. The port does not show up as USB 3.0 device. This one device is missing

Re: [PATCH 07/12] power: pwrseq: rename file name for generic driver

2016-06-20 Thread Krzysztof Kozlowski
On 06/17/2016 12:09 PM, Peter Chen wrote: > The individual driver file name is better to contain module name. > > Signed-off-by: Peter Chen > --- > .../power/pwrseq/{pwrseq-simple.txt => mmc-pwrseq-simple.txt} | 0 > drivers/power/pwrseq/Makefile |

Re: [RFC v4 01/14] regulator: of: Add helper for getting all supplies

2016-06-09 Thread Krzysztof Kozlowski
On 06/09/2016 12:29 PM, Mark Brown wrote: > On Thu, Jun 09, 2016 at 11:44:18AM +0200, Krzysztof Kozlowski wrote: >> Few drivers have a need of getting regulator supplies without knowing >> their names: >> 1. The Simple Framebuffer driver works on setup provided by bootloa

[RFC v4 01/14] regulator: of: Add helper for getting all supplies

2016-06-09 Thread Krzysztof Kozlowski
"-supply" properties and returning allocated bulk regulator consumers. Signed-off-by: Krzysztof Kozlowski --- drivers/regulator/of_regulator.c | 86 ++ include/linux/regulator/of_regulator.h | 13 + 2 files changed, 99 insertions(+) diff --git

[RFC v4 03/14] power/mmc: Move pwrseq drivers to power/pwrseq

2016-06-09 Thread Krzysztof Kozlowski
are prefixed with "mmc_pwrseq". However the MMC-specific pwrseq functions has to be now exported and everything is hidden not by CONFIG_OF but by new CONFIG_POWER_SEQ option. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Javier Martinez Canillas --- .../pwrseq/pwrse

[RFC v4 07/14] power: pwrseq: Generalize mmc_pwrseq operations by removing mmc prefix

2016-06-09 Thread Krzysztof Kozlowski
ot; prefix and use the pointer to struct pwrseq as argument. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Javier Martinez Canillas --- drivers/mmc/core/core.c | 6 +++--- drivers/power/pwrseq/pwrseq.c| 24 +--- drivers/power/pwrseq/pwrseq_emm

[RFC v4 04/14] MAINTAINERS: Retain Ulf Hansson as the same maintainer of pwrseq

2016-06-09 Thread Krzysztof Kozlowski
Before moving pwrseq drivers from drivers/mmc/core/ to drivers/power/, they were maintained by Ulf Hansson. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Javier Martinez Canillas --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index

[RFC v4 09/14] power: pwrseq: Add support for USB hubs with external power

2016-06-09 Thread Krzysztof Kozlowski
Some USB devices on embedded boards have external power supply which has to be reset in certain conditions. Add pwrseq interface for this. Signed-off-by: Krzysztof Kozlowski --- drivers/power/pwrseq/pwrseq.c | 47 ++- include/linux/pwrseq.h| 11

[RFC v4 08/14] power: pwrseq: simple: Add support for regulators and generic property

2016-06-09 Thread Krzysztof Kozlowski
e property and parse the node's properties like reset-gpios, supplies etc. Signed-off-by: Krzysztof Kozlowski --- .../bindings/power/pwrseq/pwrseq-simple.txt| 30 +- drivers/power/pwrseq/pwrseq_simple.c | 113 - 2 files changed, 136 insertions(

[RFC v4 05/14] power: pwrseq: Enable COMPILE_TEST for drivers

2016-06-09 Thread Krzysztof Kozlowski
Allow build testing for power sequence drivers. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Javier Martinez Canillas --- drivers/power/pwrseq/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/power/pwrseq/Kconfig b/drivers/power/pwrseq/Kconfig index

[RFC v4 12/14] EXAMPLE CODE: usb: hub: Power sequence the ports on activation

2016-06-09 Thread Krzysztof Kozlowski
The autodetection of attached USB device might not work on certain boards where the power is delivered externally. These devices also might require a hard reset. Use pwrseq for that in USB hub. Signed-off-by: Krzysztof Kozlowski --- drivers/usb/core/hub.c | 10 ++ 1 file changed, 10

[RFC v4 00/14] usb/mmc/power: Generic power sequence (and fix USB/LAN when TFTP booting)

2016-06-09 Thread Krzysztof Kozlowski
milar to the MMC pwrseq behavior so the idea is to: 1. Move MMC pwrseq drivers to generic place, 2. Extend the pwrseq-simple with regulator toggling, 3. Add support to USB hub and port core for pwrseq, 4. Toggle the regulator when needed. Best regards, Krzysztof Krzysztof Kozlowski

[RFC v4 13/14] ARM: dts: exynos: Switch the buck8 to GPIO mode on Odroid U3

2016-06-09 Thread Krzysztof Kozlowski
Switch the control of buck8 to GPIO mode. It is faster than I2C/register mode and it is the easiest way to disable it (regulator state is a logical OR state of GPIO and register value). Signed-off-by: Krzysztof Kozlowski Reviewed-by: Javier Martinez Canillas --- arch/arm/boot/dts/exynos4412

[RFC v4 10/14] usb: hub: Handle deferred probe

2016-06-09 Thread Krzysztof Kozlowski
Add support for deferred probing to the usb hub. Currently EPROBE_DEFER does not exist in usb hub path but future patches will add it on the port level. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Javier Martinez Canillas --- drivers/usb/core/hub.c | 6 -- 1 file changed, 4 insertions

[RFC v4 06/14] power: pwrseq: Remove mmc prefix from mmc_pwrseq

2016-06-09 Thread Krzysztof Kozlowski
The "mmc" prefix is no longer needed after moving the pwrseq core code from mmc/ to power/. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Javier Martinez Canillas --- drivers/power/pwrseq/pwrseq.c| 18 +- drivers/power/pwrseq/pwrseq_emmc.c | 8 ---

[RFC v4 14/14] ARM: dts: exynos: Fix LAN and HUB after bootloader initialization on Odroid U3

2016-06-09 Thread Krzysztof Kozlowski
t before configuring. Reset by GPIO (called RESET_N pin) and by RESET field in STCD register in usb3503 HUB are not sufficient. Instead full reset has to be done by disabling and enabling regulator. Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/exynos4412-odroidu3.dts | 4 1 file c

[RFC v4 02/14] simplefb: Use new devm_of_regulator_all_get helper and bulk API

2016-06-09 Thread Krzysztof Kozlowski
bulk API does everything atomically. Signed-off-by: Krzysztof Kozlowski --- Not tested. --- drivers/video/fbdev/simplefb.c | 71 +- 1 file changed, 14 insertions(+), 57 deletions(-) diff --git a/drivers/video/fbdev/simplefb.c b/drivers/video/fbdev

[RFC v4 11/14] EXAMPLE CODE: usb: port: Parse pwrseq phandle from Device Tree

2016-06-09 Thread Krzysztof Kozlowski
Parse usb-pwrseq property from Device Tree to get the phandle to pwrseq device. The pwrseq device will be used by USB hub to cycle the power before activating ports. Signed-off-by: Krzysztof Kozlowski --- drivers/usb/core/hub.h | 3 +++ drivers/usb/core/port.c | 16 2 files

Re: [PATCH v3 06/12] power: pwrseq: simple: Add support for regulator and generic property

2016-06-08 Thread Krzysztof Kozlowski
On 06/09/2016 04:34 AM, Chen-Yu Tsai wrote: > Hi > > On Thu, Jun 9, 2016 at 3:03 AM, Rob Herring wrote: >> On Tue, Jun 07, 2016 at 11:29:02AM +0200, Krzysztof Kozlowski wrote: >>> On 06/03/2016 04:02 AM, Rob Herring wrote: >>>>> Optional properties: &g

  1   2   3   >