On Thu, Aug 15, 2019 at 3:52 PM Oliver Neukum wrote:
> > The UVC driver passes in offsets into a struct uvc_control as the
> > "buffer" that usb_control_msg() fills.
>
> Not quite that bad. It passes a pointer into the middle of a buffer
> used at different offsets for the transfer. This is techni
On Thu, Aug 15, 2019 at 1:51 PM Lars Melin wrote:
>
> On 8/14/2019 22:59, Jonathan Bell wrote:
> > There is a bug when the dwc2 core receives USB data packets that are
> > between 1 and 4 bytes in length - 4 bytes are always written to memory
> > where the non-packet byte
On Thu, Aug 15, 2019 at 11:55 AM Oliver Neukum wrote:
>
> Am Mittwoch, den 14.08.2019, 16:59 +0100 schrieb Jonathan Bell:
> > As reported by one of our users here:
> > https://github.com/raspberrypi/linux/issues/3148
> >
> > There is a bug when the dwc2 core rece
As reported by one of our users here:
https://github.com/raspberrypi/linux/issues/3148
There is a bug when the dwc2 core receives USB data packets that are
between 1 and 4 bytes in length - 4 bytes are always written to memory
where the non-packet bytes are garbage.
This is easily reproducible by
27;ve eyeballed it rather than testing the results
Acked-by: Jonathan Cameron
18.8%
200 1984127 0.8%
500 2985075 40.3%
Measurements and working as a libre/open office document can be found at
https://jontio.github.io/linux_kernel_work/ch43x_tests.ods
Signed-off-by: Jonathan Olds
---
drivers/usb/serial/ch341.c | 46 ++
1 file chan
e
possible to estimate the percentage error and if it was beyond a certain
threshold send something to dmesg. For example the ch34x can't produce
1843200 baud with an acceptable accuracy but the driver will happily
calculate the best possible "a". The user could read dmesg and adjust their
ha
27 0.8%
500 2985075 40.3%
The patch will fix 256000, 133 and 921600 but not 1843200 and 500.
Cheers,
Jonti
-Original Message-
From: Johan Hovold [mailto:jo...@kernel.org]
Sent: Monday, 3 June 2019 7:24 p.m.
To: Jonathan Olds
Cc: jo...@kernel.org; fr...@kingswood-consultin
With apologies for the fake "Re:"- I can't easily reply to the
original thread, since I wasn't subscribed at the time. I'm referring
to Robert Bielik's thread from February 2018.
I'm trying to develop an audio device using the USB Gadget system.
f_uac1 works with stereo, but breaks when I try to u
For whatever it's worth, I've tested this on 4.18.9 and can verify that
there are no regressions there.
Tested-by: Jonathan Dieter
checked all these drivers to ensure that all ioctl arguments
> are used as pointers or are ignored, but are not interpreted as integer
> values.
>
> Signed-off-by: Arnd Bergmann
> ---
For IIO part.
Acked-by: Jonathan Cameron
Thanks,
> diff --git a/drivers/iio/industri
On Wed, 25 Apr 2018 16:47:01 +0300
Jani Nikula wrote:
> On Fri, 06 Apr 2018, Heikki Krogerus wrote:
> > Using reStructuredText literal-block element with ascii-art.
> > That prevents the ascii art from being processed as
> > reStructuredText.
> >
> > Reported-by: Masanari Iida
> > Fixes: bdecb3
Hi,
On 25 March 2018 at 12:21, Jonathan Liu wrote:
> On 8 February 2018 at 14:55, Jeffy Chen wrote:
>> From: AMAN DEEP
>>
>> There is a race condition between finish_unlinks->finish_urb() function
>> and usb_kill_urb() in ohci controller case. The finish_urb ca
Hi,
On 25 March 2018 at 12:21, Jonathan Liu wrote:
> Hi,
>
> On 8 February 2018 at 14:55, Jeffy Chen wrote:
>> From: AMAN DEEP
>>
>> There is a race condition between finish_unlinks->finish_urb() function
>> and usb_kill_urb() in ohci controller case. The f
[] (SyS_ioctl) from [] (ret_fast_syscall+0x0/0x54)
include/linux/file.h:39
Afterwards the kernel is unresponsive to disconnect/connect of the
full speed USB device but I can connect/disconnect a high speed USB
device to the same port and communicate to it without problem since it
uses EHCI (OHCI is companion controller). If I try to connect the full
speed USB device again it is still unresponsive. The userspace
application is still hanging after all this.
Could this commit be causing the issue?
Thanks.
Regards,
Jonathan
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Any extcon events between the initial state read and ci_extcon_register are
"lost". This patch doesn't fix the issue entirely but reduces the chance of
the controller entering a bad state.
Signed-off-by: Jonathan Marek
---
drivers/usb/chipidea/core.c | 35 +++
On Wed, 13 Dec 2017 13:07:44 +0800
Lu Baolu wrote:
> Update Documentation/driver-api/usb/usb3-debug-port.rst. This update
> includes the guide for using xHCI debug capability based TTY serial
> link.
>
> Cc: Mathias Nyman
> Cc: Greg Kroah-Hartman
> Signed-off-by: Lu Baolu
Applied to the docs
On Fri, 8 Dec 2017 11:53:37 -0200
Fabio Estevam wrote:
> Fix the spelling of 'enumerate' in this document.
Applied to the docs tree, thanks.
jon
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at
st as they are either passed to
>the functions having the argument as const or they are
>stored in the const "ci_type" field of a config_item structure.
>
>Signed-off-by: Bhumika Goyal
Acked-by: Jonathan Cameron
>---
>* Changes in v2- Combine all the followup patch
On 16 October 2017 at 23:49, Bin Liu wrote:
> On Mon, Oct 16, 2017 at 04:13:51PM +1100, Jonathan Liu wrote:
>> On 10 October 2017 at 14:22, Bin Liu wrote:
>> > On Tue, Oct 10, 2017 at 01:45:25PM +1100, Jonathan Liu wrote:
>> >> This fixes a kernel oops wh
On 10 October 2017 at 14:22, Bin Liu wrote:
> On Tue, Oct 10, 2017 at 01:45:25PM +1100, Jonathan Liu wrote:
>> This fixes a kernel oops when unloading the driver due to usb_put_phy
>> being called after usb_phy_generic_unregister when the device is
>> detached. Calling usb_p
el.org # v4.3+
Signed-off-by: Jonathan Liu
---
Changes for v2:
- Use devm_usb_put_phy instead of usb_put_phy
drivers/usb/musb/sunxi.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/musb/sunxi.c b/drivers/usb/musb/sunxi.c
index c9a09b5bb6e5..dc353e24d53c 100644
--- a/drivers/us
Hi,
On 10 October 2017 at 13:14, Bin Liu wrote:
> On Tue, Oct 10, 2017 at 08:17:34AM +1100, Jonathan Liu wrote:
>> Hi,
>>
>> On 10 October 2017 at 01:23, Bin Liu wrote:
>> > Hi,
>> >
>> > On Tue, Sep 26, 2017 at 09:39:23PM +1000, Jonathan Liu wrot
Hi,
On 10 October 2017 at 01:23, Bin Liu wrote:
> Hi,
>
> On Tue, Sep 26, 2017 at 09:39:23PM +1000, Jonathan Liu wrote:
>> This fixes a kernel oops when unloading the driver due to usb_put_phy
>> being called after usb_phy_generic_unregister when the device is
the driver logic
and does not rely on register contents.
Cc: sta...@vger.kernel.org # v4.1+
Signed-off-by: Jonathan Liu
---
drivers/usb/musb/musb_core.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
index 02969205
Hi,
On 26 September 2017 at 21:39, Jonathan Liu wrote:
> This fixes a kernel oops when unloading the driver due to usb_put_phy
> being called after usb_phy_generic_unregister when the device is
> detached. Calling usb_phy_generic_unregister causes x->dev->driver to
> be NULL
icitly managing the lifetime of usb_phy,
devm_usb_get_phy is changed to usb_get_phy and we call usb_put_phy in
the probe error path.
Cc: sta...@vger.kernel.org # v4.3+
Signed-off-by: Jonathan Liu
---
drivers/usb/musb/sunxi.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff -
found for parameter
'quirk_zlp_not_supp'
Document those fields to make the warnings go away.
Signed-off-by: Jonathan Corbet
---
include/linux/usb/gadget.h | 5 +
1 file changed, 5 insertions(+)
diff --git a/include/linux/usb/gadget.h b/include/linux/usb/gadget.h
index 1a4a4bacfae6..49
ap_twl.c | 2 +-
> drivers/gpio/gpio-twl4030.c | 2 +-
> drivers/iio/adc/twl4030-madc.c | 2 +-
> drivers/iio/adc/twl6030-gpadc.c | 2 +-
Acked-by: Jonathan Cameron
Thanks,
> drivers/input/keyboard/twl4030_keypad.c | 2 +-
> drivers/input/misc/tw
On Sun, 16 Apr 2017 21:51:05 -0300
Mauro Carvalho Chehab wrote:
> When we got rid of usbfs, the old /proc/bus/usb stuff got moved
> to two different places:
> usb/devices is now at /sys/kernel/debug
> /proc/bus/usb/BBB/DDD are not at /dev/bus/usb/BBB/DDD
>
> However, the documentati
On Sun, 16 Apr 2017 13:04:36 -0300
Mauro Carvalho Chehab wrote:
> There's no usbfs anymore. The old features are now either
> exported to /dev/bus/usb or via debugfs.
>
> Update documentation accordingly, pointing to the new
> places where the character devices and usb/devices are
> now placed.
On Tue, 11 Apr 2017 16:58:40 +0200
Greg Kroah-Hartman wrote:
> Nope, they don't apply to my tree, it was probably based on yours. And
> the first two are ones I shouldn't be taking.
>
> So, feel free to take all of these with a:
> Acked-by: Greg Kroah-Hartman
> for the USB-related patche
On Wed, 5 Apr 2017 10:22:54 -0300
Mauro Carvalho Chehab wrote:
> Currently, there are several USB core documents that are at either
> written in plain text or in DocBook format. Convert them to ReST
> and add to the driver-api book.
Greg, do you see any reason not to apply these for 4.12? A fe
On Thu, 30 Mar 2017 07:45:35 -0300
Mauro Carvalho Chehab wrote:
> Currently, the script just assumes to be called at
> Documentation/sphinx/. Change it to work on any directory,
> and make it abort if something gets wrong.
>
> Also, be sure that both parameters are specified.
>
> That should av
On Thu, 30 Mar 2017 11:20:14 +0200
Markus Heiser wrote:
> @Jon: what do you think about a bulk conversion?
I'm a bit leery of it, to tell the truth. We're trying to create a
better set of kernel docs, and I'm far from convinced that dumping a
bunch of unloved stuff there in a mechanical way wil
On Mon, 2017-02-27 at 10:31 +0200, Jonathan Dieter wrote:
> The usbip userspace tools call sprintf()/snprintf() and don't check for
> the return value which can lead the paths to overflow, truncating the
> final file in the path.
>
> More urgently, GCC 7 now warns that these
: Jonathan Dieter
---
tools/usb/usbip/src/usbip.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/usb/usbip/src/usbip.c b/tools/usb/usbip/src/usbip.c
index d7599d9..73d8eee 100644
--- a/tools/usb/usbip/src/usbip.c
+++ b/tools/usb/usbip/src/usbip.c
@@ -176,6 +176,8 @@ int main(int argc, char
e.ac, that makes
these tools unbuildable.
This patch fixes these problems by replacing sprintf() with snprintf() in
one place and adding checks for the return value of snprintf().
Reviewed-by: Peter Senna Tschudin
Signed-off-by: Jonathan Dieter
---
Changes since v3
* Cast sizeof to long uns
e.ac, that makes
these tools unbuildable.
This patch fixes these problems by replacing sprintf() with snprintf() in
one place and adding checks for the return value of snprintf().
Reviewed-by: Peter Senna Tschudin
Signed-off-by: Jonathan Dieter
---
Changes since v2
* Converted size back to i
: Jonathan Dieter
---
tools/usb/usbip/src/usbip.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/usb/usbip/src/usbip.c b/tools/usb/usbip/src/usbip.c
index d7599d9..73d8eee 100644
--- a/tools/usb/usbip/src/usbip.c
+++ b/tools/usb/usbip/src/usbip.c
@@ -176,6 +176,8 @@ int main(int argc, char
On Wed, 2017-02-22 at 06:49 +0100, Krzysztof Opasiak wrote:
> Hi,
>
> W dniu 2017-02-21 o 18:57, Jonathan Dieter pisze:
> > char busid[SYSFS_BUS_ID_SIZE];
> > + unsigned int size;
>
> I'm not really convinced to use unsigned here. snprintf() is declared
>
e.ac, that makes
these tools unbuildable.
This patch fixes these problems by replacing sprintf() with snprintf() in
one place and adding checks for the return value of snprintf().
Reviewed-by: Peter Senna Tschudin
Signed-off-by: Jonathan Dieter
---
tools/usb/usbip/libsrc/usbip_common.c
: Jonathan Dieter
---
tools/usb/usbip/src/usbip.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/usb/usbip/src/usbip.c b/tools/usb/usbip/src/usbip.c
index d7599d9..73d8eee 100644
--- a/tools/usb/usbip/src/usbip.c
+++ b/tools/usb/usbip/src/usbip.c
@@ -176,6 +176,8 @@ int main(int argc, char
On Tue, 2017-02-21 at 08:48 +0200, Jonathan Dieter wrote:
> On Tue, 2017-02-21 at 07:12 +0100, Krzysztof Opasiak wrote:
> > Hi,
> >
> > W dniu 2017-02-20 o 21:51, Jonathan Dieter pisze:
> > > + err("busid length %i >= SYSFS_BUS_ID_SIZE",
>
Thanks for looking at this. One quick question before I put out
version two with your corrections:
On Tue, 2017-02-21 at 07:12 +0100, Krzysztof Opasiak wrote:
> Hi,
>
> W dniu 2017-02-20 o 21:51, Jonathan Dieter pisze:
> > The usbip userspace tools call sprintf()/snprintf()
: Jonathan Dieter
---
tools/usb/usbip/src/usbip.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/usb/usbip/src/usbip.c b/tools/usb/usbip/src/usbip.c
index d7599d9..73d8eee 100644
--- a/tools/usb/usbip/src/usbip.c
+++ b/tools/usb/usbip/src/usbip.c
@@ -176,6 +176,8 @@ int main(int argc, char
e.ac, that makes
these tools unbuildable.
This patch fixes these problems by replacing sprintf() with snprintf() in
one place and adding checks for the return value of snprintf().
Reviewed-by: Peter Senna Tschudin
Signed-off-by: Jonathan Dieter
---
tools/usb/usbip/libsrc/usbip_common.c
On Mon, 24 Oct 2016 14:25:27 +0200
Greg KH wrote:
> I don't have any objection to the changes, please take them through your
> documentation tree:
I have now done so.
Thanks,
jon
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.
On Thu, 20 Oct 2016 15:15:00 +0200
Oliver Neukum wrote:
> It does no good to mention The 2.4 kernel series and neglect
> USB 3.x and XHCI. Also with type C and micro/mini USB we better
> not talk about the shape of connectors.
...except that USB 2 connectors will be with us for some time yet. I
On Thu, 20 Oct 2016 18:22:28 +0200
Oliver Neukum wrote:
> > Why does this not remove the .tmpl file?
>
> 1. We might want to keep it
> 2. It is an operation beyond the scope of this patch.
I have to disagree with this part; the last thing we want is two copies of
the documentation to get out
On Tue, 12 Apr 2016 18:13:27 +0100
Diego Herranz wrote:
> It tries to "match" drivers for each interface (not "much").
Indeed. Applied to the docs tree, thanks.
jon
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
Mor
On Thu, 21 Jan 2016 22:18:30 -0300
"Geyslan G. Bem" wrote:
> This patch does use of more emacs functionalities which deliver to the
> user indentation, commenting and white space highlighting.
So perhaps it's just me, but that's an awful lot of elisp code for readers
to wade through; many of tho
e annoying
message, I will try to resubmit the patch with another email
account. Thanks.
Jonathan
*
This email message, including any attachments, is for the sole
use of the intended recipient(s) and may contain confidenti
on EXTCON
select GENERIC_PHY
help
Enable this to support the transceiver that is part of Allwinner
Should probably add CONFIG_EXTCON=y to arch/arm/configs/sunxi_defconfig
so that CONFIG_PHY_SUN4I_USB=y works out of the box.
Regards,
Jonathan
--
To unsubscribe from this list:
On Thu, 2 Apr 2015 12:35:09 +0200
Johan Hovold wrote:
> This patch was incorrect and needed to be updated as discussed in the
> thread. Can you drop it or is your tree immutable?
Sigh...and I thought I was on top of that. Dropped, sorry for the
confusion.
jon
--
To unsubscribe from this list:
On Sat, 28 Mar 2015 14:37:57 +0100
Marek Belisko wrote:
> This patch changes the documentation file as needed.
Applied to the docs tree (with the changelog typo fixed).
Thanks,
jon
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vge
sidering QTDs in this
QH for execution (i.e. submission to the otg core) based on the microframe
number of the last nak_frame received.
In the case where FIQ support is not provided, then the SOF interrupt will
have to be unmasked as long as there are QHs with nak_frame set.
Regards
://bugzilla.kernel.org/show_bug.cgi?id=80101
Regards,
Jonathan
On Mon, 14 Jul 2014 21:48:15 +0200
Julian Sikorski wrote:
>
>
> Hello,
>
> the same happens to me on an up-to-date Fedora 20 installation with
> Lacie Rugged USB3:
>
> [ 217.024320] usb 4-2: new SuperSpeed U
My drive is working again with:
options usb-storage quirks=174c:55aa:u
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Additional affected hardware:
us 002 Device 004: ID 0bc2:3312 Seagate RSS LLC
Couldn't open device, some information will be missing
Device Descriptor:
bLength18
bDescriptorType 1
bcdUSB 2.10
bDeviceClass0 (Defined at Interface level)
bD
Here are some reports of this regression affecting other hardware:
https://bbs.archlinux.org/viewtopic.php?id=183190
lsusb -v output:
Bus 003 Device 003: ID 4971:8017 SimpleTech
Device Descriptor:
bLength18
bDescriptorType 1
bcdUSB 3.00
bDeviceClass
Fri, 20 Jun 2014 22:44:35 -0400 (GMT-04:00)
Jonathan wrote:
> After upgrading to kernel 3.15 my USB 3.0 HDD dock no longer works. In fact,
> as soon as I connect and power up a drive with the uas module loaded, I get a
> hard lockup and have to restart the system. Without the uas modu
After upgrading to kernel 3.15 my USB 3.0 HDD dock no longer works. In fact, as
soon as I connect and power up a drive with the uas module loaded, I get a hard
lockup and have to restart the system. Without the uas module loaded, the dock
is detected but the drive is not, rendering it unusable.
v3.8-rc4~17 (the above commit). Reverting that
commit on top of current "master" (d92581fcad18, 2013-08-10) produces
a working kernel. dmesg output from that working kernel attached.
More details, including .config, at [2].
Any ideas for tracking this down?
Thanks,
Jonathan
[1] Scree
nd what
> exactly is failing with it.
Note that Holger ran into the same problem using a mainline (3.8-rc5)
kernel.
Thanks,
Jonathan
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at
0
> disconnection/power-off device removal work again. Verified both on the
> bisection box and by now also the original machine.
Thanks for tracking this down. Forwarding to relevant people.
Hope that helps,
Jonathan
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
de or configuration.
Addresses http://bugs.debian.org/664068
Reported-and-tested-by: David Banks # Oxygen 49
Reported-and-tested-by: Olivier MATZ # KeyRig 49
Signed-off-by: Jonathan Nieder
Cc: sta...@vger.kernel.org
---
Thoughts?
drivers/usb/core/quirks.c | 6 ++
1 file changed, 6 insertions(+)
diff
f you try a 2.6.39
kernel from [1] and explicitly enable wakeup with
echo enabled >/sys/devices/pci:00/:00:0b.0/power/wakeup
does the bug occur?
[...]
>> a. Somehow "blacklist" power/wakeup for this device and call it a day.
I think we should try some more to figure o
; hardware...
Thanks, that's interesting. If you have time to test connecting the
old keyboard and mouse through a hub, that would still be useful.
Jonathan
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.ke
xHCI: store ring's type, 2012-03-05)
consumer was replaced by the boolean value (ring->type == TYPE_EVENT).
In b63f4053 the ring is xhci->cmd_ring which has type TYPE_COMMAND, so
consumer should be false.
Thanks,
Jonathan
--
To unsubscribe from this list: send the line "unsubs
cp /boot/config-$(uname -r) .config; # current configuration
scripts/config --disable DEBUG_INFO
make localmodconfig; # optional: minimize configuration
scripts/config --enable USB_DEBUG
# build, test
make deb-pkg; # can use -j for parallel build
dpkg -i ../;
undry list approach of naming
> several affected webcams explicitly, no?
Why wouldn't I want usb_detect_quirks() to reference UVC-specific
structs?
Jonathan
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger
the linux-acpi mailing list.
The Debian bug for this one is <http://bugs.debian.org/680707>.
Please cc me or 680...@bugs.debian.org if bringing it up with ACPI
folks so we can track the discussion.
Thanks again for your hard work.
Ciao,
Jonathan
--
To unsubscribe from this list: send the lin
73 matches
Mail list logo
