On Thu, 2019-08-08 at 13:23 +0200, Greg Kroah-Hartman wrote:
> On Thu, Aug 08, 2019 at 04:15:44AM -0700, Joe Perches wrote:
> > On Thu, 2019-08-08 at 11:41 +0200, Greg Kroah-Hartman wrote:
> > > On Thu, Aug 08, 2019 at 11:25:09AM +0200, Greg Kroah-Hartman wrote:
> > > &g
On Thu, 2019-08-08 at 11:41 +0200, Greg Kroah-Hartman wrote:
> On Thu, Aug 08, 2019 at 11:25:09AM +0200, Greg Kroah-Hartman wrote:
> > Joe rightly points out that we should be using the "Obsolete" status for
> > these two subsystems.
>
> Even with that change, I don't see get_maintainers.pl tell m
On Tue, 2019-08-06 at 12:15 +0200, Greg Kroah-Hartman wrote:
> The UWB and wusbcore code is long obsolete, so let us just move the code
> out of the real part of the kernel and into the drivers/staging/
> location with plans to remove it entirely in a few releases.
[]
> MAINTAINERS
On Sun, 2019-07-21 at 16:45 -0400, Alan Stern wrote:
> On Sun, 21 Jul 2019, Joe Perches wrote:
>
> > On Sun, 2019-07-21 at 19:32 +0100, Pawel Laszczak wrote:
> > > Patch moves some decoding functions from driver/usb/dwc3/debug.h driver
> > > to driver/usb/co
On Sun, 2019-07-21 at 19:32 +0100, Pawel Laszczak wrote:
> Patch adds usb_decode_test_mode and usb_decode_device_feature functions,
> which allow to make more readable and simplify the
> usb_decode_set_clear_feature function.
I need to read entire patch series before
commenting more I guess...
On Sun, 2019-07-21 at 19:32 +0100, Pawel Laszczak wrote:
> Patch moves some decoding functions from driver/usb/dwc3/debug.h driver
> to driver/usb/common/debug.c file. These moved functions include:
[]
> diff --git a/drivers/usb/common/debug.c b/drivers/usb/common/debug.c
[]
> +static void usb_deco
This static inline is unnecessary and can be removed
by using the vsprintf %ph extension.
This reduces overall object size by more than 2K.
Signed-off-by: Joe Perches
---
drivers/usb/wusbcore/cbaf.c | 15 ---
drivers/usb/wusbcore/dev-sysfs.c | 5 ++---
drivers/usb/wusbcore
On Thu, 2019-02-28 at 14:23 -0800, Jon Flatley wrote:
> Thanks for the patch and comments.
>
> On Thu, Feb 28, 2019 at 1:53 PM Joe Perches wrote:
> > On Thu, 2019-02-28 at 12:24 +, Louis Taylor wrote:
> > > When compiling with -Wformat, clang warns:
> > >
On Thu, 2019-02-28 at 12:24 +, Louis Taylor wrote:
> When compiling with -Wformat, clang warns:
> ./include/linux/usb/wusb.h:245:5: warning: format specifies type
> 'unsigned short' but the argument has type 'u8' (aka 'unsigned char')
> [-Wformat]
> ckhdid->data[0], ckhdid->data[1],
> ^~~~
On Tue, 2019-01-22 at 16:12 +0100, Jiri Slaby wrote:
> Remove macros which are only wrappers around standard operations. When
> we expand them into code, we see that sisusbcon_memsetw can simply use
> memset16 and sisusbcon_putcs can just call memcpy. So make the code
> compact.
[]
> diff --git a/d
On Sat, 2018-11-03 at 17:51 +, Pawel Laszczak wrote:
> Patch implements some function used for debugging driver.
[]
> +static inline char *cdns3_decode_ep_irq(u32 ep_sts, const char *ep_name)
> +{
> + static char str[256];
> + int ret;
> +
> + ret = sprintf(str, "IRQ for %s: %08x ",
On Thu, 2018-06-07 at 20:05 +, Corentin Labbe wrote:
> It's dangerous to use empty code define.
> Furthermore it lead to the following warning:
> "suggest braces around empty body in an « else » statement"
>
> So let's replace emptyness by "do {} while(0)"
I also suggest renaming COUNT to som
Using octal and not symbolic permissions is preferred by many as
more readable.
https://lkml.org/lkml/2016/8/2/1945
Rather than getting these piecemeal, just do them all.
Done with checkpatch and some typing.
Joe Perches (4):
ethernet: Use octal not symbolic permissions
wireless: Use octal
Prefer the direct use of octal for permissions.
Done with checkpatch -f --types=SYMBOLIC_PERMS --fix-inplace
and some typing.
Miscellanea:
o Whitespace neatening around these conversions.
Signed-off-by: Joe Perches
---
drivers/net/bonding/bond_procfs.c | 2 +-
drivers/net/bonding
On Thu, 2018-03-15 at 10:08 -0700, Matthew Wilcox wrote:
> On Thu, Mar 15, 2018 at 09:56:46AM -0700, Joe Perches wrote:
> > I have a patchset that creates a vsprintf extension for
> > print_vma_addr and removes all the uses similar to the
> > print_symbol() removal.
> &g
On Thu, 2018-03-15 at 10:48 +0100, Geert Uytterhoeven wrote:
> Hi David,
>
> On Thu, Mar 15, 2018 at 10:42 AM, David Howells wrote:
> > Do we have anything left that still implements NOMMU?
>
> Sure: arm, c6x, m68k, microblaze, and sh.
I have a patchset that creates a vsprintf extension for
pr
skb_copy_expand without __GFP_NOWARN already does a dump_stack
on OOM so these messages are redundant.
Signed-off-by: Joe Perches
---
drivers/net/ethernet/qualcomm/qca_spi.c | 1 -
drivers/net/usb/lg-vl600.c | 6 +-
drivers/net/wimax/i2400m/usb-rx.c | 3 ---
drivers/net
On Sat, 2018-03-10 at 19:24 +0100, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Sat, 10 Mar 2018 18:22:43 +0100
>
> Adjust a jump target so that a bit of common code can be better reused
> at the end of this function.
Please stop mindlessly sending patching Markus.
How about looking
On Wed, 2017-12-20 at 10:59 +0100, Greg Kroah-Hartman wrote:
> > > Why you didn't send that patch to the sysfs maintainer is a bit odd... :)
> >
> > So here's an opportunity for you:
> >
> > The sysfs maintainer hasn't added include/linux/sysfs.h to
> > the list of maintained files...
> >
> > D
On Wed, 2017-12-20 at 10:32 +0100, Greg Kroah-Hartman wrote:
> On Wed, Dec 20, 2017 at 01:24:44AM -0800, Joe Perches wrote:
> > On Wed, 2017-12-20 at 10:34 +0200, Jarkko Nikula wrote:
> > > On Tue, Dec 19, 2017 at 10:15:07AM -0800, Joe Perches wrote:
> > > &g
On Wed, 2017-12-20 at 10:34 +0200, Jarkko Nikula wrote:
> On Tue, Dec 19, 2017 at 10:15:07AM -0800, Joe Perches wrote:
> > Convert DEVICE_ATTR uses to DEVICE_ATTR_RW where possible.
[]
> > diff --git a/sound/soc/omap/mcbsp.c b/sound/soc/omap/mcbsp.c
[]
> > @@ -854,7 +85
Joe Perches (4):
sysfs.h: Use octal permissions
treewide: Use DEVICE_ATTR_RW
treewide: Use DEVICE_ATTR_RO
treewide: Use DEVICE_ATTR_WO
arch/arm/mach-pxa/sharpsl_pm.c | 4 +-
arch/s390/kernel/smp.c | 2 +-
arch/s390/kernel/topology.c
_show\s*,\s*\1_store\s*\)/DEVICE_ATTR_RW(\1)/g;
print;}'
Signed-off-by: Joe Perches
---
arch/s390/kernel/topology.c | 3 +--
arch/tile/kernel/sysfs.c | 2 +-
drivers/gpu/drm/i915/i915_sysfs.c| 6 ++---
drivers/platform/x86/compal-laptop.c | 18 +--
On Mon, 2017-12-11 at 14:43 -0800, Matthew Wilcox wrote:
> - There's no warning for the first paragraph of section 6:
>
> 6) Functions
>
>
> Functions should be short and sweet, and do just one thing. They should
> fit on one or two screenfuls of text (the ISO/ANSI screen size is 8
On Mon, 2017-12-11 at 14:43 -0800, Matthew Wilcox wrote:
> On Mon, Dec 11, 2017 at 02:12:28PM -0800, Joe Perches wrote:
> > Completely reasonable. Thanks.
>
> If we're doing "completely reasonable" complaints, then ...
>
> - I don't understand why pl
On Tue, 2017-12-12 at 08:43 +1100, Dave Chinner wrote:
> On Sat, Dec 09, 2017 at 09:00:18AM -0800, Joe Perches wrote:
> > On Sat, 2017-12-09 at 09:36 +1100, Dave Chinner wrote:
> > > 1. Using lockdep_set_novalidate_class() for anything other
> > > than device-&
On Sat, 2017-12-09 at 09:36 +1100, Dave Chinner wrote:
> 1. Using lockdep_set_novalidate_class() for anything other
> than device->mutex will throw checkpatch warnings. Nice. (*)
[]
> (*) checkpatch.pl is considered mostly harmful round here, too,
> but that's another rant
How so?
On Thu, 2017-12-07 at 11:17 -0800, Joe Perches wrote:
> On Wed, 2017-12-06 at 17:57 +0400, Razmik Karapetyan wrote:
> > Removed unnecessary debug prints about DMA mode for host side
> > from dwc2_gahbcfg_init() function.
>
> What other functionality makes these unnecessary?
&
On Wed, 2017-12-06 at 17:57 +0400, Razmik Karapetyan wrote:
> Removed unnecessary debug prints about DMA mode for host side
> from dwc2_gahbcfg_init() function.
What other functionality makes these unnecessary?
If any, it's nice to de
--
To unsubscribe from this list: send the line "unsubscribe li
On Thu, 2017-12-07 at 10:12 -0500, Alan Stern wrote:
> The real problem is that the kernel development community doesn't have
> a fixed policy on how to handle memory allocation errors.
[]
> If there was one agreed-upon policy, then we could definitively point
> to old code and say "That's wrong,
On Wed, 2017-12-06 at 11:45 -0500, Alan Stern wrote:
> On Wed, 6 Dec 2017, SF Markus Elfring wrote:
> > Omit an extra message for a memory allocation failure in this function.
Markus' typical terrible commit message.
> > diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
[]
> > @@ -829,
On Wed, 2017-12-06 at 07:27 +0100, Greg Kroah-Hartman wrote:
> On Tue, Dec 05, 2017 at 10:22:05PM -0800, Joe Perches wrote:
> > Using a period after a newline causes bad output.
>
> Nice catch, how did you find that?
$ git grep '\\n\."'
--
To unsubscribe
Using a period after a newline causes bad output.
Miscellanea:
o Coalesce formats too
Signed-off-by: Joe Perches
---
drivers/usb/core/driver.c | 8
drivers/usb/core/hub.c | 17 +++--
drivers/usb/core/message.c | 6 +++---
3 files changed, 14 insertions(+), 17
On Thu, 2017-11-23 at 15:30 -0800, Joe Perches wrote:
> --- /dev/null 2017-11-23 06:19:12.943046739 -0800
> +++ single_use_module.pl 2017-11-23 15:23:11.729812156 -0800
> @@ -0,0 +1,15 @@
[]
> +$data =~ s~$var~$string~;
this needs to be:
$data =~ s~\b$var\b~$string~;
--
To unsu
On Wed, 2017-11-22 at 18:12 +0100, Greg Kroah-Hartman wrote:
> On Wed, Nov 22, 2017 at 09:05:36AM -0800, Joe Perches wrote:
> > On Fri, 2017-11-17 at 15:19 +0100, Greg Kroah-Hartman wrote:
> > > There is no need to #define the license of the driver, just put it in
> > >
On Fri, 2017-11-17 at 15:19 +0100, Greg Kroah-Hartman wrote:
> There is no need to #define the license of the driver, just put it in
> the MODULE_LICENSE() line directly as a text string.
>
> This allows tools that check that the module license matches the source
> code license to work properly, a
On Sun, 2017-09-10 at 13:37 -0700, Guenter Roeck wrote:
> Move tcpm (USB Type-C Port Manager) out of staging.
git format-patch -M
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kerne
On Tue, 2017-08-29 at 07:35 +0200, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Mon, 28 Aug 2017 22:46:30 +0200
>
> Fix a word in this description.
>
> Signed-off-by: Markus Elfring
> ---
> drivers/media/usb/zr364xx/zr364xx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Move the inline/asmlinkage keywords before the return types
Add a checkpatch test for this too.
Joe Perches (18):
checkpatch: improve the STORAGE_CLASS test
ARM: KVM: Move asmlinkage before type
ARM: HP Jornada 7XX: Move inline before return type
CRIS: gpio: Move inline before return type
Make the code like the rest of the kernel.
Also use inline instead of __inline__.
Signed-off-by: Joe Perches
---
drivers/usb/serial/safe_serial.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/serial/safe_serial.c b/drivers/usb/serial/safe_serial.c
index
On Mon, 2017-06-12 at 22:51 +0200, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki
>
> Avoid printing the device suspend/resume timing information if
> CONFIG_PM_DEBUG is not set to reduce the log noise level.
>
> Signed-off-by: Rafael J. Wysocki
> ---
> drivers/base/power/main.c |4 +++
On Wed, 2017-05-10 at 12:07 -0500, Bin Liu wrote:
> On Wed, May 10, 2017 at 11:42:27AM +0300, Peter Ujfalusi wrote:
> > We have one register for each EP to set the maximum packet size for both
> > TX and RX.
> > If for example an RX programming would happen before the previous TX
> > transfer finis
On Wed, 2017-04-19 at 15:16 +0400, Razmik Karapetyan wrote:
> Removed unnecessary debug prints about DMA mode for host side
> from dwc2_gahbcfg_init() function.
Why are these unnecessary? Are these emitted elsewhere?
and...
> diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c
[]
> @@
On Sun, 2017-04-02 at 18:57 +0200, Leif Neland wrote:
> There is a patch
> https://github.com/karlp/ch341-linux/blob/master/0001-usb-serial-ch341-Add-parity-support.patch
> which enables parity selection for the ch341 USB-RS485 adapter.
>
> From: Karl Palsson Date: Tue, 18 Mar 2014 23:33:27
> +00
Use a more common logging style and remove the unnecessary
OOM messages as there is default dump_stack when OOM.
Miscellanea:
o Hoist an assignment in an if
o Realign arguments
o Realign a deeply indented if descendent above a printk
Signed-off-by: Joe Perches
---
drivers/hid/usbhid/hid
On Wed, 2017-03-01 at 21:59 +0200, Avraham Shukron wrote:
> >
> > This kind of change is definitely not helpful. The original table was
> > Nx16, you converted it to Nx14. Why do you think original table used 16
> > columns?
> >
> > Regardless, it's a very old driver, just let it be.
> >
> > Tha
On Wed, 2017-03-01 at 16:55 +0100, Romain Perier wrote:
> support to warn about this old API in checkpath.pl
checkpatch
This part isn't true anymore, but it seems sensible enough, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord..
On Mon, 2017-02-27 at 13:52 +0100, Romain Perier wrote:
> > I also wonder if you've in fact converted all of the
> > pci_pool struct and function uses why a new checkpatch
> > test is needed at all.
>
> That's just to avoid futures mistakes/uses.
When all instances and macro definitions are remo
s
> > > in the DMA pool API. This adds support to check for use of these pci
> > > functions and display a warning when it is the case.
> > >
> >
> > I guess Joe Perches did sent some comments for this one, did you address
> > them?
>
> See the
t; > functions and display a warning when it is the case.
> >
>
> I guess Joe Perches did sent some comments for this one, did you address
> them?
> Reviewed-by: Peter Senna Tschudin
> > Signed-off-by: Romain Perier
> > ---
> > scripts/checkpatch.pl | 9 +
On Wed, 2017-02-08 at 19:55 +0100, Peter Senna Tschudin wrote:
> On Wed, Feb 08, 2017 at 05:34:57PM +0100, Romain Perier wrote:
> > pci_pool_*() functions should be replaced by the corresponding functions
> > in the DMA pool API. This adds support to check for use of these pci
> > functions and dis
On Fri, 2016-09-30 at 13:57 -0700, Guenter Roeck wrote:
> Code now looks as follows.
>
> #define PDO_VAR_MIN_VOLT(mv) mv) / 50) & PDO_VAR_MIN_VOLT_MASK) << \
> PDO_VAR_MIN_VOLT_SHIFT)
> #define PDO_VAR_MAX_VOLT(mv) mv) / 50) & PDO_VAR_MAX_VOLT_MASK) << \
>
On Fri, 2016-09-30 at 12:06 -0700, Guenter Roeck wrote:
> On Thu, Sep 29, 2016 at 11:37 PM, Jun Li wrote:
[]
> > diff --git a/include/linux/usb/pd.h b/include/linux/usb/pd.h
[]
> > +#define PDO_VAR(min_mv, max_mv, max_ma)
> > \
> > + ((PDO_TYPE_VAR << PDO_
Use the more common logging mechanism.
Miscellanea:
o Realign multiline statements
o Coalesce format
Signed-off-by: Joe Perches
---
drivers/usb/gadget/function/rndis.c | 9 -
drivers/usb/gadget/function/u_serial.c | 4 ++--
drivers/usb/gadget/udc/at91_udc.h | 2
On Mon, 2016-09-19 at 12:18 +0200, Fabien Lahoudere wrote:
> Each USB controller have different behaviour, so in order to avoid to have
> several "swicth(data->index)" and lock/unlock, we prefer to get the index
> and then test for features if they exist for this index.
[]
> diff --git a/drivers/us
On Sun, 2016-09-11 at 15:05 +0200, Julia Lawall wrote:
> Constify local structures.
Thanks Julia.
A few suggestions & questions:
Perhaps the script should go into scripts/coccinelle/
so that future cases could be caught by the robot
and commit message referenced by the patch instances.
Can you
On Wed, 2016-09-07 at 02:00 +, ronnie.ku...@microchip.com wrote:
> Microchip's internal convention is for register (offset) definitions
> to be capitalized (i.e.: MY_REGISTER). Our convention for bits
> (position) definitions within a register is to carry as a prefix the
> name of the register
On Tue, 2016-09-06 at 23:19 +, woojung@microchip.com wrote:
> > Joe Perches (2):
> > lan78xx: Remove locally defined trailing underscores from defines and uses
> > microchipphy.h and uses: Remove trailing underscores from defines and
> > uses
> >
&g
;s/\b(?!LAN88XX_)([A-Z0-9_][A-Za-z0-9_]+)_\b/\U\1\E/g' \
drivers/net/usb/lan78xx.[ch]
and some editing to realign columns in the .h file.
No change in defconfig object.
Signed-off-by: Joe Perches
---
drivers/net/usb/lan78xx.c | 340 +++
drivers/net/usb/lan78x
Joe Perches (2):
lan78xx: Remove locally defined trailing underscores from defines and uses
microchipphy.h and uses: Remove trailing underscores from defines and uses
drivers/net/phy/microchip.c |4 +-
drivers/net/usb/lan78xx.c| 368 +++
drivers/net/usb/lan78xx.h
rs/net/usb/lan78xx.c \
drivers/net/phy/microchip.c
and some editing to realign columns in the .h file.
No change in defconfig objects.
Signed-off-by: Joe Perches
---
drivers/net/phy/microchip.c | 4 +--
drivers/net/usb/lan78xx.c| 28 -
include/linux/microchip
change in defconfig objects.
Signed-off-by: Joe Perches
---
drivers/net/usb/smsc95xx.c | 198 +--
drivers/net/usb/smsc95xx.h | 330 ++---
2 files changed, 264 insertions(+), 264 deletions(-)
diff --git a/drivers/net/usb/smsc95xx.c b/d
Use a more common logging style
Miscellanea:
o Add pr_fmt to prefix each output message
o Realign arguments
Signed-off-by: Joe Perches
---
drivers/net/usb/hso.c | 21 +++--
1 file changed, 11 insertions(+), 10 deletions(-)
diff --git a/drivers/net/usb/hso.c b/drivers/net/usb
This seems to be the only code in the kernel that uses
macro defines with a trailing underscore. Fix that.
Joe Perches (2):
hso: Use a more common logging style
hso: Convert printk to pr_
drivers/net/usb/hso.c | 118 +++---
1 file changed, 55
.
Signed-off-by: Joe Perches
---
drivers/net/usb/hso.c | 97 +++
1 file changed, 44 insertions(+), 53 deletions(-)
diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c
index c5544d3..6c37512 100644
--- a/drivers/net/usb/hso.c
+++ b/drivers/net/usb
On Thu, 2016-06-09 at 10:55 +0300, Roger Quadros wrote:
> Now that we have a device reference in struct usb_otg
> let's use dev_vdbg() for debug messages instead of VDBG().
>
> Signed-off-by: Roger Quadros
> Acked-by: Peter Chen
> ---
> v10:
> - in the commit message say dev_vdbg() instead of de
On Wed, 2016-06-08 at 12:03 +0300, Roger Quadros wrote:
> Now that we have a device reference in struct usb_otg
> let's use dev_dbg() for debug messages.
dev_vdbg vs dev_dbg
The patch subject and commit message don't match the code changes.
> diff --git a/drivers/usb/common/usb-otg-fsm.c
> b/dr
On Sat, 2016-04-02 at 19:07 +0200, Grigori Goronzy wrote:
> No functional change. The following adjustments were made to be more in
> line with official coding style and to be more consistent.
>
> Stop mixing tabs and spaces for alignment. Align continuations in
> function prototypes correctly.
On Tue, 2016-03-08 at 21:40 +0100, Rasmus Villemoes wrote:
> Passing overlapping source and destination is fragile, and in this
> case we can even simplify the code and avoid the huge stack buffer by
> using the %p extension for printing a small hex dump.
[]
> diff --git a/drivers/usb/atm/usbatm.c
On Wed, 2016-01-06 at 16:30 +0100, Peter Senna Tschudin wrote:
> is it ok to fix horizontal issues caused by vertical changes in the
> vertical changes patch?
Yes.
> Is it reasonable to respin if other issues are
> reported for this series?
Your choice.
I think it'd be better to respin in any ca
On Tue, 2016-01-05 at 17:54 +0100, Peter Senna Tschudin wrote:
[]
> Patch 1 is the biggest and fix only whitespace, tab and newline issues. I used
>
> $ git diff -w --word-diff=porcelain drivers/usb/misc/sisusbvga/sisusb.c
>
> to verify that this patch do not change any visible character. If the
On Tue, 2016-01-05 at 11:06 -0500, Alan Stern wrote:
> Trying to come up with hard-and-fast rules for this sort of thing is
> pretty hopeless. Even "Maximize readability" doesn't work too well,
> because different people find different things most readable.
Readability is mostly habituation.
A
On Tue, 2016-01-05 at 10:12 -0500, Alan Stern wrote:
> On Mon, 4 Jan 2016, Geyslan G. Bem wrote:
>
> > >> @@ -404,12 +422,8 @@ static inline char token_mark(struct ehci_hcd
> > >> *ehci, __hc32 token)
> > >> return '/';
> > >> }
> > >>
> > >> -static void qh_lines(
> > >> - struct ehci
On Tue, 2016-01-05 at 10:12 -0500, Alan Stern wrote:
> On Mon, 4 Jan 2016, Geyslan G. Bem wrote:
>
> > >> @@ -404,12 +422,8 @@ static inline char token_mark(struct
> ehci_hcd *ehci, __hc32 token)
> > >> return '/';
> > >> }
> > >>
> > >> -static void qh_lines(
> > >> - struct ehci_hcd *
On Mon, 2016-01-04 at 19:07 -0300, Geyslan G. Bem wrote:
> 2016-01-04 18:52 GMT-03:00 Sergei Shtylyov :
> > > > > > This patch fixes coding style issues reported by checkpatch
> > > > > > concerning
> > > > > > to unnecessary space after a cast.
> > > > > This is a case where checkpatch is wrong,
On Mon, 2015-10-12 at 23:22 +0200, Peter Senna Tschudin wrote:
> This patch remove an else statement after a return to make the code
> easier to understand.
[]
> diff --git a/drivers/usb/host/fotg210-hcd.c b/drivers/usb/host/fotg210-hcd.c
[]
> @@ -1402,10 +1402,9 @@ static int check_reset_complete(
On Mon, 2015-08-24 at 00:18 +0530, Muhammad Falak R Wani wrote:
> This patch introduces the use of function kmalloc_array(), instead
> of using kmalloc(), for allocating memory for an array and removes
> the corresponding call to kmalloc().
[]
> diff --git a/drivers/usb/core/driver.c b/drivers/usb/
On Sun, 2015-05-31 at 15:50 +0900, Greg KH wrote:
> On Tue, May 26, 2015 at 05:15:48PM +0530, Nikhil Badola wrote:
> > Replace macros with enumerated type to represent usb ip
> > controller version
> >
> > Signed-off-by: Nikhil Badola
> > ---
> > include/linux/fsl_devices.h | 13 -
>
Single transform macros with hidden arguments are not
particularly useful. Just use seq_printf directly instead.
Signed-off-by: Joe Perches
---
drivers/usb/storage/scsiglue.c | 18 +++---
1 file changed, 7 insertions(+), 11 deletions(-)
diff --git a/drivers/usb/storage/scsiglue.c
On Sat, 2015-04-11 at 00:53 -0700, Chase Metzger wrote:
> Fixed several errors and warnings.
[]
> Lines 1040 and 1591: changed dev_printk(KERN_DEBUG, ...) to dev_dbg(...).
These changes hav the possibly undesired effect of
removing these messages completely when DEBUG is not
#defined or when CONFI
On Sat, 2015-04-11 at 03:04 -0700, Chase Metzger wrote:
> Removed all(except false positives, from calculations) space prohibited
> warnings generated by
> checkpatch.pl.
False positives? Please describe them.
The only thing I believe you elided was the
use of a BitTime macro which in my opinio
Using unnecessary static char buffers isn't good.
Use the %pV extension instead.
Miscellanea:
o the dprintk return value is unused, make it void
o add __printf format and argument verification
Signed-off-by: Joe Perches
---
This doesn't matter much as it is pretty unusual to ena
ate static functions for statement expression macros
o Use c90 style comments instead of c99
Signed-off-by: Joe Perches
---
compiled/untested
drivers/usb/gadget/udc/goku_udc.c | 233 --
1 file changed, 122 insertions(+), 111 deletions(-)
diff --git a/drivers/
Joe Perches (14):
etherdevice: Add eth__addr CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS code
ethernet: Use eth__addr instead of memset
net: usb: Use eth__addr instead of memset
wireless: Use eth__addr instead of memset
netconsole: Use eth__addr instead of memset
xen: Use eth__addr instead
Use the built-in function instead of memset.
Signed-off-by: Joe Perches
---
drivers/net/usb/catc.c | 4 ++--
drivers/net/usb/cdc_mbim.c | 2 +-
drivers/net/usb/lg-vl600.c | 2 +-
drivers/net/usb/qmi_wwan.c | 2 +-
4 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/net
etter replaced with
not doing that. And "must check return value and Do Something(tm)" is too
strong habit for enough people to cause recurring trouble.
Joe Perches (27):
staging: lustre: Convert "return seq_printf(...)" uses
staging: lustre: Convert seq_ hash functions to retu
and remove the unnecessary labels.
Signed-off-by: Joe Perches
---
drivers/usb/gadget/udc/pxa27x_udc.c | 132
1 file changed, 60 insertions(+), 72 deletions(-)
diff --git a/drivers/usb/gadget/udc/pxa27x_udc.c
b/drivers/usb/gadget/udc/pxa27x_udc.c
index 6a855fc.
Use the normal {} instead of a macro to terminate an array.
Remove the macro too.
Signed-off-by: Joe Perches
---
drivers/net/ethernet/broadcom/b44.c | 2 +-
drivers/net/wireless/b43/main.c | 2 +-
drivers/net/wireless/b43legacy/main.c | 2 +-
drivers/ssb/driver_gige.c | 2
Use the normal {} instead of a macro to terminate an array.
Remove the macro too.
Signed-off-by: Joe Perches
---
drivers/net/ethernet/broadcom/bgmac.c | 2 +-
drivers/net/wireless/b43/main.c | 2 +-
drivers/net/wireless/brcm80211/brcmsmac/mac80211_if.c | 2
On Wed, 2014-12-24 at 14:48 +0530, Rohith Seelaboyina wrote:
> Dynamic memory allocation through kcalloc is more safer
> than declaring variable array size, Fix this error by
> using kcalloc for memory allocation, Check if memory
> allocation is successful and return -ENOMEM on failure.
>
> Signed
On Wed, 2014-12-24 at 10:59 +0530, Rohith Seelaboyina wrote:
> Dynamic memory allocation through kmalloc is more safer
> than declaring variable array size, Fix this error by
> using kmalloc for memory allocation, Check if memory
> allocation is successful and return -ENOMEM on failure.
[]
> diff -
On Sun, 2014-12-07 at 20:20 +0100, Julia Lawall wrote:
> These patches replace what appears to be a reference to the name of the
> current function but is misspelled in some way by either the name of the
> function itself, or by %s and then __func__ in an argument list.
At least a few of these see
These are error prone, so return void adn use seq_has_overflowed instead
Joe Perches (2):
seq_puts: Convert to return void and convert uses too.
seq_putc: Convert to return void and convert uses too.
drivers/char/ipmi/ipmi_msghandler.c| 4 +-
drivers/parisc/ccio-dma.c
Using the return value of seq_puts is error-prone, so
make it return void instead.
Use seq_has_overflowed where appropriate instead of the
old return value.
Signed-off-by: Joe Perches
---
drivers/parisc/ccio-dma.c | 7 ++--
drivers/regulator/dbx500-prcmu.c | 21 --
drivers
Use #defines instead of magic values.
Signed-off-by: Joe Perches
---
drivers/usb/storage/debug.c | 2 +-
include/linux/kern_levels.h | 13 +
kernel/printk/printk.c | 28 +---
lib/dynamic_debug.c | 4 ++--
4 files changed, 29 insertions(+), 18
On Mon, 2014-10-27 at 18:31 +0200, Octavian Purdila wrote:
> This patch implements the USB part of the Diolan USB-I2C/SPI/GPIO
> Master Adapter DLN-2. Details about the device can be found here:
trivia:
> diff --git a/drivers/mfd/dln2.c b/drivers/mfd/dln2.c
[]
> +static int _dln2_transfer(struct
logical mask has lower precedence than shift but should be
done before the shift so parentheses are generally required.
And when masking with a fixed value after a shift, normal kernel
style has the shift on the left, then the shift on the right so
convert a few non-conforming uses.
Joe Perches
Precedence of & and >> is not the same and is not left to right.
shift has higher precedence and should be done after the mask.
Add parentheses around the mask.
Signed-off-by: Joe Perches
---
drivers/usb/host/hwa-hc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
On Wed, 2014-10-22 at 06:26 -0400, Peter Hurley wrote:
> On 10/22/2014 04:20 AM, Johan Hovold wrote:
> > On Thu, Oct 16, 2014 at 01:59:22PM -0400, Peter Hurley wrote:
> >> Commit 90419cfcb5d9c889b10dc51363c56a4d394d670e,
> >> "USB: kobil_sct: fix control requests without data stage", removed
> >
>
No caller or macro uses the return value so make it void.
Signed-off-by: Joe Perches
---
This change is associated to a desire to eventually
change printk to return void.
drivers/usb/storage/debug.c | 7 ++-
drivers/usb/storage/debug.h | 10 ++
2 files changed, 8 insertions(+), 9
1 - 100 of 225 matches
Mail list logo
