[PATCH v2] carl9170: fix misuse of device driver API

2019-06-08 Thread Christian Lamparter
fter-free bugs by explicitly setting the driver context to NULL after signaling the completion. Cc: Cc: Alan Stern Signed-off-by: Christian Lamparter --- v2: Alan Stern's comments - fixed possible use-after-free --- drivers/net/wireless/ath/carl9170/usb.c | 39 +++

[PATCH] carl9170: Fix misuse of device driver API

2019-06-02 Thread Christian Lamparter
fter-free bugs by explicitly setting the driver context to NULL after signaling the completion. Cc: Cc: Alan Stern Signed-off-by: Christian Lamparter --- drivers/net/wireless/ath/carl9170/usb.c | 26 - 1 file changed, 12 insertions(+), 14 deletions(-) diff --git a

[PATCH v2] leds: fix regression in usbport led trigger

2019-01-11 Thread Christian Lamparter
e it so that the sysfs "ports" group was only being added after the activate() callback succeeded. This version of the patch reverts parts of the "usb: simplify usbport trigger" patch and restores usbport trigger's functionality. Fixes: 6f7b0bad8839 ("usb: simplify

Re: [RFC PATCH v1] leds: fix regression in usbport led trigger

2019-01-01 Thread Christian Lamparter
Hello Jacek, On Friday, December 28, 2018 5:29:56 PM CET Jacek Anaszewski wrote: > On 12/25/18 9:49 PM, Christian Lamparter wrote: > > The patch "usb: simplify usbport trigger" together with > > "leds: triggers: add device attribute support" caused an > &g

[RFC PATCH v1] leds: fix regression in usbport led trigger

2018-12-25 Thread Christian Lamparter
ine-König Cc: Rafał Miłecki Fixes: 6f7b0bad8839 ("usb: simplify usbport trigger") Signed-off-by: Christian Lamparter --- This version of the patch ... of which will be many more?! yeah, device_add_groups() in front of activate() works for the usbport driver since it dynamically registers t

[PATCH] usb: core: usbport: fix "BUG: key not in .data" when lockdep is enabled

2017-08-28 Thread Christian Lamparter
[ledtrig_usbport]) [ 61.060685] [] (led_trigger_set) from [] [...] Signed-off-by: Christian Lamparter --- drivers/usb/core/ledtrig-usbport.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/core/ledtrig-usbport.c b/drivers/usb/core/ledtrig-usbport.c index 16c19a31dad1..910ea063caf8

Re: [PATCH v2 2/4] usb: dwc2: Add binding for AHB burst

2017-01-11 Thread Christian Lamparter
On Tuesday, January 10, 2017 3:23:24 PM CET John Youn wrote: > On 1/10/2017 3:03 PM, Christian Lamparter wrote: > > On Tuesday, January 10, 2017 1:46:56 PM CET John Youn wrote: > >> On 12/19/2016 6:49 AM, Christian Lamparter wrote: > >>> (Lot's of old

Re: [PATCH v2 2/4] usb: dwc2: Add binding for AHB burst

2017-01-10 Thread Christian Lamparter
On Tuesday, January 10, 2017 1:46:56 PM CET John Youn wrote: > On 12/19/2016 6:49 AM, Christian Lamparter wrote: > > (Lot's of old stuff, that doesn't matter anymore) Hello John, > This should be fixed against the latest dwc2 param rework series [1] > which i hope to ge

Re: [PATCH v2 2/4] usb: dwc2: Add binding for AHB burst

2016-12-19 Thread Christian Lamparter
Hello John, hello Felipe On Monday, November 28, 2016 7:32:20 PM CET John Youn wrote: > On 11/22/2016 12:51 PM, Christian Lamparter wrote: > > On Monday, November 21, 2016 7:32:30 PM CET John Youn wrote: > >> On 11/21/2016 1:10 PM, Christian Lamparter wrote: > >>> O

Re: [PATCH v2 2/4] usb: dwc2: Add binding for AHB burst

2016-11-22 Thread Christian Lamparter
On Monday, November 21, 2016 7:32:30 PM CET John Youn wrote: > On 11/21/2016 1:10 PM, Christian Lamparter wrote: > > On Monday, November 21, 2016 12:16:31 PM CET John Youn wrote: > >> On 11/18/2016 12:18 PM, Christian Lamparter wrote: > >>> On Friday, November 18, 2

Re: [PATCH v2 2/4] usb: dwc2: Add binding for AHB burst

2016-11-21 Thread Christian Lamparter
Hello John, On Monday, November 21, 2016 12:16:31 PM CET John Youn wrote: > On 11/18/2016 12:18 PM, Christian Lamparter wrote: > > On Friday, November 18, 2016 8:16:08 AM CET Rob Herring wrote: > >> On Thu, Nov 17, 2016 at 04:35:10PM +0100, Stefan Wahren wrote: > >&g

Re: [PATCH v3 0/4] usb: dwc2: Add AHB burst configuration

2016-11-18 Thread Christian Lamparter
| 2 +- > drivers/usb/dwc2/hcd.c | 8 +-- > drivers/usb/dwc2/params.c | 79 > ++ > drivers/usb/dwc2/pci.c | 1 + > 6 files changed, 85 insertions(+), 16 deletions(-) > Tested-b

Re: [PATCH v2 2/4] usb: dwc2: Add binding for AHB burst

2016-11-18 Thread Christian Lamparter
tforms may see better or worse performance based on this > > > value. The HAPS platform is one example where all INCRx have worse > > > performance than INCR. > > > > > > Other platforms (such as the Canyonlands board) report that the default > > > value cause

Re: [PATCH 1/2] usb: dwc2: add amcc,dwc-otg support

2016-11-11 Thread Christian Lamparter
On Friday, November 11, 2016 2:20:42 PM CET John Youn wrote: > On 11/11/2016 2:05 PM, Christian Lamparter wrote: > > On Friday, November 11, 2016 1:22:16 PM CET John Youn wrote: > >> On 11/11/2016 12:59 PM, Christian Lamparter wrote: > >>> This patch adds support

Re: [PATCH 1/2] usb: dwc2: add amcc,dwc-otg support

2016-11-11 Thread Christian Lamparter
Hello, On Friday, November 11, 2016 1:22:16 PM CET John Youn wrote: > On 11/11/2016 12:59 PM, Christian Lamparter wrote: > > This patch adds support for the "amcc,usb-otg" device > > which is found in the PowerPC Canyonlands' dts. > > > > The

[PATCH 2/2] usb: dwc2: fixes host_dma logic

2016-11-11 Thread Christian Lamparter
ned-off-by: Christian Lamparter --- drivers/usb/dwc2/params.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c index 5d822c5..222a83c 100644 --- a/drivers/usb/dwc2/params.c +++ b/drivers/usb/dwc2/params.c @@ -1157,9 +1157,6 @@ s

[PATCH 1/2] usb: dwc2: add amcc,dwc-otg support

2016-11-11 Thread Christian Lamparter
river wasn't available at that time. Note: The system can't use the generic "snps,dwc2" compatible because of the special ahbcfg configuration. The default GAHBCFG_HBSTLEN_INCR4 of snps,dwc2 can cause a system hang when the USB and SATA is used concurrently. Cc: Felipe Balbi

[PATCH] usb: dwc2: add amcc,dwc-otg device tree definition

2016-11-05 Thread Christian Lamparter
ent to the linuxppc-dev at the time. However, it was never integrated. Signed-off-by: Christian Lamparter --- For anyone interested: the driver was sent to the ML multiple times back in 2012 [0], [1]. [0] <https://lists.ozlabs.org/pipermail/linuxppc-dev/2012-May/097847.html> [1] <https://

Re: [PATCH] usb: xhci: handle uPD720201 and uPD720202 w/o ROM

2016-06-23 Thread Christian Lamparter
Hello, On Tuesday, June 21, 2016 05:56:58 AM Yoshihiro Shimoda wrote: > > From: Christian Lamparter > > Sent: Tuesday, June 21, 2016 12:32 AM > > > > On Wednesday, June 08, 2016 12:14:57 AM Christian Lamparter wrote: > > > This patch adds a firmware check for th

Re: [PATCH] usb: xhci: handle uPD720201 and uPD720202 w/o ROM

2016-06-20 Thread Christian Lamparter
On Wednesday, June 08, 2016 12:14:57 AM Christian Lamparter wrote: > This patch adds a firmware check for the uPD720201K8-711-BAC-A > and uPD720202K8-711-BAA-A variant. Both of these chips are listed > in Renesas' R19UH0078EJ0500 Rev.5.00 "User's Manual: Hardware&qu

[PATCH] usb: xhci: handle uPD720201 and uPD720202 w/o ROM

2016-06-07 Thread Christian Lamparter
45:00.0: can't setup: -110 [ 32.340179] xhci_hcd :45:00.0: USB bus 2 deregistered [ 32.345587] xhci_hcd :45:00.0: init :45:00.0 fail, -110 [ 32.351496] xhci_hcd: probe of :45:00.0 failed with error -110 Cc: Yoshihiro Shimoda Signed-off-by: Christian Lamparter --- drivers

Re: usb: dwc2: regression on MyBook Live Duo / Canyonlands since 4.3.0-rc4

2016-05-18 Thread Christian Lamparter
On Tuesday, May 17, 2016 04:50:48 PM John Youn wrote: > On 5/14/2016 6:11 AM, Christian Lamparter wrote: > > On Thursday, May 12, 2016 11:40:28 AM John Youn wrote: > >> On 5/12/2016 6:30 AM, Christian Lamparter wrote: > >>> On Thursday, May 12, 2016 01:55:44 PM

Re: usb: dwc2: regression on MyBook Live Duo / Canyonlands since 4.3.0-rc4

2016-05-14 Thread Christian Lamparter
On Thursday, May 12, 2016 11:40:28 AM John Youn wrote: > On 5/12/2016 6:30 AM, Christian Lamparter wrote: > > On Thursday, May 12, 2016 01:55:44 PM Arnd Bergmann wrote: > >> On Thursday 12 May 2016 11:58:18 Christian Lamparter wrote: > >>>>>> Detecting

Re: [PATCH v4] usb: dwc2: fix regression on big-endian PowerPC/ARM systems

2016-05-14 Thread Christian Lamparter
On Friday, May 13, 2016 03:52:27 PM Arnd Bergmann wrote: > A patch that went into Linux-4.4 to fix big-endian mode on a Lantiq > MIPS system unfortunately broke big-endian operation on PowerPC > APM82181 as reported by Christian Lamparter, and likely other > systems. > > It a

Re: usb: dwc2: regression on MyBook Live Duo / Canyonlands since 4.3.0-rc4

2016-05-12 Thread Christian Lamparter
On Thursday, May 12, 2016 11:40:28 AM John Youn wrote: > On 5/12/2016 6:30 AM, Christian Lamparter wrote: > > On Thursday, May 12, 2016 01:55:44 PM Arnd Bergmann wrote: > >> On Thursday 12 May 2016 11:58:18 Christian Lamparter wrote: > >>>>>> Detecting

Re: usb: dwc2: regression on MyBook Live Duo / Canyonlands since 4.3.0-rc4

2016-05-12 Thread Christian Lamparter
On Thursday, May 12, 2016 01:55:44 PM Arnd Bergmann wrote: > On Thursday 12 May 2016 11:58:18 Christian Lamparter wrote: > > > > > Detecting the endianess of the > > > > > device is probably the best future-proof solution, but it's also > > > >

Re: usb: dwc2: regression on MyBook Live Duo / Canyonlands since 4.3.0-rc4

2016-05-12 Thread Christian Lamparter
inal > patch would be even easier, but that would break the one big-endian > MIPS machine we know about. > > > > Detecting the endianess of the > > > device is probably the best future-proof solution, but it's also > > > considerably more work to do in the dri

Re: usb: dwc2: regression on MyBook Live Duo / Canyonlands since 4.3.0-rc4

2016-05-09 Thread Christian Lamparter
Uh, Thanks for the participation! On Monday, May 09, 2016 05:08:48 PM Arnd Bergmann wrote: > On Monday 09 May 2016 13:39:50 Felipe Balbi wrote: > > Arnd Bergmann writes: > > > On Monday 09 May 2016 10:23:22 Benjamin Herrenschmidt wrote: > > >> On Sun, 2016-0

Re: usb: dwc2: regression on MyBook Live Duo / Canyonlands since 4.3.0-rc4

2016-05-08 Thread Christian Lamparter
On Sunday, May 08, 2016 08:40:55 PM Benjamin Herrenschmidt wrote: > On Sun, 2016-05-08 at 00:54 +0200, Christian Lamparter via Linuxppc-dev > wrote: > > I've been looking in getting the MyBook Live Duo's USB OTG port > > to function. The SoC is a APM82181. Which ha

usb: dwc2: regression on MyBook Live Duo / Canyonlands since 4.3.0-rc4

2016-05-07 Thread Christian Lamparter
Hello, I've been looking in getting the MyBook Live Duo's USB OTG port to function. The SoC is a APM82181. Which has a PowerPC 464 core and related to the supported canyonlands architecture in arch/powerpc/. Currently in -next the dwc2 module doesn't load: dwc2 4bff8.usbotg: dwc2_core_reset

[PATCH v1.1] usbip: move usbip_protocol.txt to Documentation

2016-02-24 Thread Christian Lamparter
. For anyone interested: support is available with the latest wireshark master/dev tree. Simply select a packet from the usbip's tcp-stream you are intrested on and select the USBIP as the protocol in the "Decode As" dialog box [1]. Signed-off-by: Christian Lamparter [0] <htt

[PATCH] usbip: move usbip_protocol.txt to Documentation

2016-02-24 Thread Christian Lamparter
. For anyone interested: support is available with the latest wireshark master/dev tree. Simply select a packet from the usbip's tcp-stream you are intrested on and select the USBIP as the protocol in the "Decode As" dialog box [1]. Signed-off-by: Christian Lamparter [0] <htt

Re: FUSB200 xhci issue

2013-08-08 Thread Christian Lamparter
On Thursday 08 August 2013 22:19:32 Alan Stern wrote: > On Thu, 8 Aug 2013, Christian Lamparter wrote: > > > Anyway, I do have a question about something else too. > > > > in ath9k_htc's hif_usb: > > > > > struct usb_host_interface *alt = &

Re: FUSB200 xhci issue

2013-08-08 Thread Christian Lamparter
On Thursday 08 August 2013 17:35:34 Oleksij Rempel wrote: > Am 31.07.2013 08:52, schrieb Oleksij Rempel: > > Am 28.07.2013 22:41, schrieb Christian Lamparter: > >> On Sunday, July 28, 2013 04:28:25 PM Oleksij Rempel wrote: > >>> Am 28.07.2013 14:12, schrieb Oleksij R

Re: FUSB200 xhci issue

2013-07-28 Thread Christian Lamparter
On Sunday, July 28, 2013 04:28:25 PM Oleksij Rempel wrote: > Am 28.07.2013 14:12, schrieb Oleksij Rempel: > > Am 28.07.2013 13:38, schrieb Christian Lamparter: > > > >>>> > >>>> Anyway, I tried the -next branch. > >>>> > >>>

Re: FUSB200 xhci issue

2013-07-27 Thread Christian Lamparter
On Wednesday, July 24, 2013 12:37:55 PM Oleksij Rempel wrote: > Am 23.07.2013 20:26, schrieb Christian Lamparter: > > On Tuesday, July 23, 2013 06:59:46 AM Oleksij Rempel wrote: > >> Am 22.07.2013 23:23, schrieb Christian Lamparter: > >>> On Monday, July 22, 2013 10

Re: FUSB200 xhci issue

2013-07-23 Thread Christian Lamparter
On Tuesday, July 23, 2013 06:59:46 AM Oleksij Rempel wrote: > Am 22.07.2013 23:23, schrieb Christian Lamparter: > > On Monday, July 22, 2013 10:47:41 PM Oleksij Rempel wrote: > >> Am 22.07.2013 21:54, schrieb Christian Lamparter: > >>> Hello! > >>>

Re: carl9170 A-MPDU transmit problem

2013-02-25 Thread Christian Lamparter
On Monday, February 25, 2013 09:19:03 PM Alan Stern wrote: > On Mon, 25 Feb 2013, Seth Forshee wrote: > > > > >88012fe19500 1519981417 S Bo:3:003:1 -115 126 = 7e00 ... <-- > > > > >DATA > > > > > > > > > > [... long period where the device receives commands on EP4 and sends > > > > > wifi

Re: carl9170 A-MPDU transmit problem

2013-02-25 Thread Christian Lamparter
On Monday, February 25, 2013 08:46:23 PM Seth Forshee wrote: > On Mon, Feb 25, 2013 at 11:13:57AM -0800, Sarah Sharp wrote: > > Hmm, yeah, that kind of points to an Intel xHCI hardware issue. It's > > too bad you don't have a USB analyzer (the high speed ones are about > > $480). Can you send me

Re: carl9170 A-MPDU transmit problem

2013-02-25 Thread Christian Lamparter
On Monday, February 25, 2013 04:29:55 PM Alan Stern wrote: > On Mon, 25 Feb 2013, Christian Lamparter wrote: > > > In fact this is both normal and required. Packets to any particular > > > endpoint must always be delivered in order. Therefore the URBs have > > > to

Re: carl9170 A-MPDU transmit problem

2013-02-25 Thread Christian Lamparter
On Monday, February 25, 2013 12:41:06 AM Alan Stern wrote: > On Sun, 24 Feb 2013, Christian Lamparter wrote: > > > > The usbmon trace indicates that the data gets delivered to the device > > > as it should, but the device doesn't accept it for several seconds. > &g

Re: carl9170 A-MPDU transmit problem

2013-02-24 Thread Christian Lamparter
On Sunday, February 24, 2013 04:54:26 PM Alan Stern wrote: > On Sat, 23 Feb 2013, Seth Forshee wrote: > > On Sat, Feb 23, 2013 at 03:07:08PM +0100, Christian Lamparter wrote: > > > usb_submit_urb() is async, so unless the URB data structure is > > > bogus, the device is

Re: carl9170 A-MPDU transmit problem

2013-02-23 Thread Christian Lamparter
at 12:48:51AM +0100, Christian Lamparter wrote: > > So it looks like we need to ask whenever the USB transport > > is reliable or not. Did you (by any change) also monitor > > "usb_tx_anch_urbs" [And does it get stuck at some > 1 value > > as well?]. I