> static int cdc_ncm_init(struct usbnet *dev) {
> struct cdc_ncm_ctx *ctx = (struct cdc_ncm_ctx *)dev->data[0];
> u8 iface_no = ctx->control->cur_altsetting->desc.bInterfaceNumber;
> int err;
>
> err = usbnet_read_cmd(dev, USB_CDC_GET_NTB_PARAMETERS,
>
> > What better suggestion do folks have, instead of using
> USB_REQ_SET_ADDRESS?
>
> The spec is clear: wIndex is supposed to be 'NCM Communications Interface'.
> That's how you address a specific NCM function (a USB device can have more
> than one...), and that's what you'll see in all the other
> >
> > > > + ret = usbnet_read_cmd(dev, USB_CDC_GET_NET_ADDRESS,
> > > > + USB_DIR_IN | USB_TYPE_CLASS
> > > > + | USB_RECIP_INTERFACE, 0,
> > > > + USB_REQ_SET_ADDRESS, buf, ETH_ALEN);
> > >
> > > Where did
> > + ret = usbnet_read_cmd(dev, USB_CDC_GET_NET_ADDRESS,
> > + USB_DIR_IN | USB_TYPE_CLASS
> > + | USB_RECIP_INTERFACE, 0,
> > + USB_REQ_SET_ADDRESS, buf, ETH_ALEN);
>
> Where did that USB_REQ_SET_ADDRESS come from? Did y
> > -Original Message-
> > From: Hyde, Charles - Dell Team
> > Sent: Thursday, September 5, 2019 4:02 PM
> > To: Oliver Neukum; "Rafael J. Wysocki"; Len Brown
> > Cc: Limonciello, Mario; chip.program...@gmail.com; Realtek linux nic
> > maintainers; linux-usb@vger.kernel.org; linux-a...@vger
This change adds support to cdc_ncm for ACPI MAC address pass through
functionality that also exists in the Realtek r8152 driver. This is in
support of Dell's Universal Dock D6000, to give it the same feature
capability as is currently available in Windows and advertized on Dell's
product web site
In recent testing of a Dell Universal Dock D6000, I found that MAC
address pass through is not supported in the Linux drivers. However,
this same device is supported in Windows 10 (Pro) on my personal
computer, in as much as I was able to tell Windows to assign a new MAC
address of my choosing, an
This patch adds support for pushing a MAC address out to USB based
ethernet controllers driven by cdc_ncm. With this change, ifconfig can
now set the device's MAC address. For example, the Dell Universal Dock
D6000 is driven by cdc_ncm. The D6000 can now have its MAC address set
by ifconfig, as
This change moves ACPI functionality out of the Realtek r8152 driver to
its own source and header file, making it available to other drivers as
needed now and into the future. At the time this ACPI snippet was
introduced in 2016, only the Realtek driver made use of it in support of
Dell's enterpri
> > This change adds support to cdc_ncm for ACPI MAC address pass through
> > functionality that also exists in the Realtek r8152 driver. This is
> > in support of Dell's Universal Dock D6000, to give it the same feature
> > capability as is currently available in Windows and advertized on
> > Del
> > This patch adds support for pushing a MAC address out to USB based
> > ethernet controllers driven by cdc_ncm. With this change, ifconfig
> > can now set the device's MAC address. For example, the Dell Universal
> > Dock
> > D6000 is driven by cdc_ncm. The D6000 can now have its MAC address
This change adds support to cdc_ncm for ACPI MAC address pass through
functionality that also exists in the Realtek r8152 driver. This is in
support of Dell's Universal Dock D6000, to give it the same feature
capability as is currently available in Windows and advertized on Dell's
product web site
This change moves ACPI functionality out of the Realtek r8152 driver to
its own source and header file, making it available to other drivers as
needed now and into the future. At the time this ACPI snippet was
introduced in 2016, only the Realtek driver made use of it in support of
Dell's enterpri
This patch adds support for pushing a MAC address out to USB based
ethernet controllers driven by cdc_ncm. With this change, ifconfig can
now set the device's MAC address. For example, the Dell Universal Dock
D6000 is driven by cdc_ncm. The D6000 can now have its MAC address set
by ifconfig, as
In recent testing of a Dell Universal Dock D6000, I found that MAC
address pass through is not supported in the Linux drivers. However,
this same device is supported in Windows 10 (Pro) on my personal
computer, in as much as I was able to tell Windows to assign a new MAC
address of my choosing
> > > >
> > > > If you really want to have this policy in the driver(s), then
> > > > please consider extending eth_platform_get_mac_address() with an
> > > > x86/acpi method. This will make the device driver code support
> > > > fetching the mac address from device tree and Sparc idproms too.
>
> > > This change moves ACPI functionality out of the Realtek r8152 driver
> > > to its own source and header file, making it available to other
> > > drivers as needed now and into the future. At the time this ACPI
> > > snippet was introduced in 2016, only the Realtek driver made use of
> > > i
This change adds support to cdc_ncm for ACPI MAC address pass through
functionality that also exists in the Realtek r8152 driver. This is in
support of Dell's Universal Dock D6000, to give it the same feature
capability as is currently available in Windows and advertized on Dell's
product web site
This change moves ACPI functionality out of the Realtek r8152 driver to
its own source and header file, making it available to other drivers as
needed now and into the future. At the time this ACPI snippet was
introduced in 2016, only the Realtek driver made use of it in support of
Dell's enterpri
This patch adds support for pushing a MAC address out to USB based
ethernet controllers driven by cdc_ncm. With this change, ifconfig can
now set the device's MAC address. For example, the Dell Universal Dock
D6000 is driven by cdc_ncm. The D6000 can now have its MAC address set
by ifconfig, as
This is my second iteration of proposed code changes, based on feedback from
the first iteration. I dropped my original changes to usb/core and usbnet, in
favor of keeping the needed get/set ethernet address functions in cdc_ncm
driver. The changes in cdc_ncm driver reflect similar code in at
> >
> > >
> > > This is a VERY cdc-net-specific function. It is not a "generic" USB
> > > function at all. Why does it belong in the USB core? Shouldn't it
> > > live in the code that handles the other cdc-net-specific logic?
> > >
> > > thanks,
> > >
> > > greg k-h
> >
> >
> > Thank you for th
>> The core USB driver message.c is missing get/set address functionality
>> that stops ifconfig from being able to push MAC addresses out to USB
>> based ethernet devices. Without this functionality, some USB devices
>> stop responding to ethernet packets when using ifconfig to change MAC
>> addr
>
> This is a VERY cdc-net-specific function. It is not a "generic" USB
> function at all. Why does it belong in the USB core? Shouldn't it live
> in the code that handles the other cdc-net-specific logic?
>
> thanks,
>
> greg k-h
Thank you for this feedback, Greg. I was not sure about addin
This change adds support to cdc_ncm for ACPI MAC address pass through
functionality that also exists in the Realtek r8152 driver. This is in
support of Dell's Universal Dock D6000, to give it the same feature
capability as is currently available in Windows and advertized on Dell's
product web site
This change moves ACPI functionality out of the Realtek r8152 driver to
its own source and header file, making it available to other drivers as
needed now and into the future. At the time this ACPI snippet was
introduced in 2016, only the Realtek driver made use of it in support of
Dell's enterpri
This patch adds support for pushing a MAC address out to USB based
ethernet controllers driven by cdc_ncm. With this change, ifconfig can
now set the device's MAC address. For example, the Dell Universal Dock
D6000 is driven by cdc_ncm. The D6000 can now have its MAC address set
by ifconfig, as
The core USB driver message.c is missing get/set address functionality
that stops ifconfig from being able to push MAC addresses out to USB
based ethernet devices. Without this functionality, some USB devices
stop responding to ethernet packets when using ifconfig to change MAC
addresses. This ha
In recent testing of a Dell Universal Dock D6000, I found that MAC address pass
through is not supported in the Linux drivers. However, this same device is
supported in Windows 10 (Pro) on my personal computer, in as much as I was able
to tell Windows to assign a new MAC address of my choosing,
29 matches
Mail list logo
