RE: [PATCH v3] usb: dwc3: Fix assignment of EP transfer resources

2016-02-17 Thread B, Ravi
Hi John >Fixes: aebda6187181 ("usb: dwc3: Reset the transfer resource index on >SET_INTERFACE") >Cc: # v3.2+ >Reported-by: Ravi Babu >Signed-off-by: John Youn >--- >Hi Ravi, >Could you verify that it works with your test scenario? Yes, it is working fine for me. >Thanks, >John >+static

RE: [PATCH] usb: dwc3: Fix assignment of EP transfer resources

2016-02-09 Thread B, Ravi
Hi John >-Original Message- >From: John Youn [mailto:john.y...@synopsys.com] >Sent: Wednesday, February 10, 2016 1:25 AM >To: Felipe Balbi; B, Ravi >Cc: john.y...@synopsys.com; linux-usb@vger.kernel.org >Subject: [PATCH] usb: dwc3: Fix assignment of EP transf

RE: [PATCH] dwc3: gadget: fix for no-resource condition in dwc3 device controller

2016-01-29 Thread B, Ravi
Felipe >hi, >Ravi Babu writes: >> The "no-resource" error occurs when the driver issues DEPSTRTXFER >> command to start data transfer on specific endpoint, and dwc3 >this seems to imply that simply sending Start Transfer command would trigger >no-resource which is untrue. The error you mentio

RE: musb - babble interrupt recovery

2014-03-03 Thread B, Ravi
> Hello, > > On 21.2.2014 15:09, Michal Å mucr wrote: > > > > I tried both patches separately on 3.14-rc3 and second patch alone > > helped here. I wasn't able to reproduce babble interrupt anymore, no > > matter, what i did with my hub and USB peripherals. Great! > > > > Unfortunately i found ano

RE: [PATCH v1 2/3] usb: musb: core: added babble recovery func-ptr to musb->ops

2013-06-26 Thread B, Ravi
Hi Felipe > > > > @@ -213,6 +213,8 @@ struct musb_platform_ops { > > > > int (*adjust_channel_params)(struct dma_channel *channel, > > > > u16 packet_sz, u8 *mode, > > > > dma_addr_t *dma_addr, u32 *len); > > > > + > > > >

RE: [PATCH v1 2/3] usb: musb: core: added babble recovery func-ptr to musb->ops

2013-06-26 Thread B, Ravi
Felipe > > On Wed, May 29, 2013 at 06:37:03PM +0530, Ravi Babu wrote: > > Adding babble_recovery operation as part of musb->ops, used to recover > > from babble condition during babble interrupt. > > > > Signed-off-by: Ravi Babu > > --- > > drivers/usb/musb/musb_core.c |6 ++ > > driver

RE: [PATCH v2 2/7] usb: phy: dsps: adding usbphy driver for am33xx platform

2013-06-12 Thread B, Ravi
Typo.. corrected "The /proc/iomem does not show this common register" -Original Message- From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of B, Ravi Sent: Wednesday, June 12, 2013 12:51 PM To: Sergei Shtylyov Cc: ABRAHAM, KISHON VIJAY;

RE: [PATCH v2 2/7] usb: phy: dsps: adding usbphy driver for am33xx platform

2013-06-12 Thread B, Ravi
+ + res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "phy_wkup"); + phy->phy_wkup = ioremap(res->start, resource_size(res)); >>> devm_ioremap? >> The phy_wakeup register is common across two instances of phy, >> devm_ioremap_resource() will fail to map for twice for same

RE: [PATCH v2 2/7] usb: phy: dsps: adding usbphy driver for am33xx platform

2013-06-11 Thread B, Ravi
Kishon > Cc: linux-usb@vger.kernel.org; linux-ker...@vger.kernel.org; Balbi, Felipe > Subject: Re: [PATCH v2 2/7] usb: phy: dsps: adding usbphy driver for am33xx > platform >> + >> +res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "phy_wkup"); >> +phy->phy_wkup = ioremap(res->sta

RE: [PATCH v1 0/9] adding dual instance and usb-phy support for am335x platform

2013-05-28 Thread B, Ravi
Felipe > Subject: Re: [PATCH v1 0/9] adding dual instance and usb-phy support for > am335x platform > Hi, >On Thu, May 23, 2013 at 11:31:19AM +0530, Ravi Babu wrote: >> This patch set series >> - adds dual musb instances support for am335x platform >> - adds phy-dsps-usb driver

RE: [PATCH v1 2/9] usb: musb: nop: remove unused nop_xceiv_(un)register APIs from glue

2013-05-23 Thread B, Ravi
Subject: Re: [PATCH v1 2/9] usb: musb: nop: remove unused nop_xceiv_(un)register APIs from glue Hello. On 05/23/2013 09:07 PM, B, Ravi wrote: >>> removed unused nop xceiv (un_)register API's from all musb platform >>> drivers >> Since when are they unused

RE: [PATCH v1 8/9] usb: phy: dts: Adding usbphy DT bindings for am33xx

2013-05-23 Thread B, Ravi
Subject: Re: [PATCH v1 8/9] usb: phy: dts: Adding usbphy DT bindings for am33xx Hello. On 05/23/2013 09:13 PM, B, Ravi wrote: > >>> + phy1: usbphy-gs70@44e10620 { >>> + compatible = "ti,dsps-usbphy"; >>> +

RE: [PATCH v1 8/9] usb: phy: dts: Adding usbphy DT bindings for am33xx

2013-05-23 Thread B, Ravi
Sergei >> >> +phy1: usbphy-gs70@44e10620 { >> +compatible = "ti,dsps-usbphy"; >> +reg = <0x44e10620 0x8 >> + 0x44e10648 0x4>; >> +reg-names = "phy_ctrl","phy_wkup"; >> +id = <0>; >

RE: [PATCH v1 7/9] usb: musb: dsps: use get-usb-phy by phandle for multi instance

2013-05-23 Thread B, Ravi
> Subject: Re: [PATCH v1 7/9] usb: musb: dsps: use get-usb-phy by phandle for > multi instance > On 23-05-2013 10:01, Ravi Babu wrote: >> In case of mutli instance support, use get-phy object using phandle to >> return to repsective phy xceiv object for each instance > Only "respective" and

RE: [PATCH v1 2/9] usb: musb: nop: remove unused nop_xceiv_(un)register APIs from glue

2013-05-23 Thread B, Ravi
Sergei > Subject: Re: [PATCH v1 2/9] usb: musb: nop: remove unused > nop_xceiv_(un)register APIs from glue > Hello. > On 23-05-2013 10:01, Ravi Babu wrote: >> removed unused nop xceiv (un_)register API's from all musb >> platform drivers >Since when are they unused? Please refer to commit

RE: [PATCH] usb: musb: gadget: fix enumeration on heavy-loaded systems

2013-04-17 Thread B, Ravi
Ruslan > >> Subject: [PATCH] usb: musb: gadget: fix enumeration on heavy-loaded > >> systems > >> > >> From musb point of view, the Address Assignment sequence during > >> device enumeration is next: > >> - first ep0 interrupt: > >> * read the address from USB_REQ_SET_ADDRESS request > >>

RE: [PATCH] usb: musb: gadget: fix enumeration on heavy-loaded systems

2013-04-16 Thread B, Ravi
> -Original Message- > From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb- > ow...@vger.kernel.org] On Behalf Of Bilovol, Ruslan > Sent: Tuesday, April 16, 2013 9:12 PM > To: Balbi, Felipe; gre...@linuxfoundation.org; linux-usb@vger.kernel.org; > linux-ker...@vger.kernel.org > Subject:

RE: [PATCH v2 09/11] usb: musb: re-introduce musb->port_mode

2013-04-08 Thread B, Ravi
Daniel > On 08.04.2013 12:39, B, Ravi wrote: > >> Subject: [PATCH v2 09/11] usb: musb: re-introduce musb->port_mode > >> > >> Define MUSB_PORT_MODE_{HOST,GADGET,DUAL_ROLE} and store the > >> platform-specified value in struct musb. > >> >

RE: [PATCH v2 07/11] usb: musb: add Kconfig options for HOST, GAGDET or DUAL_ROLE modes

2013-04-08 Thread B, Ravi
Hi Daniel > > On 08.04.2013 12:42, B, Ravi wrote: > >> Subject: [PATCH v2 07/11] usb: musb: add Kconfig options for HOST, > GAGDET > >> or DUAL_ROLE modes > >> > >> This makes building the actual object files optional to the selected > >> m

RE: [PATCH v2 07/11] usb: musb: add Kconfig options for HOST, GAGDET or DUAL_ROLE modes

2013-04-08 Thread B, Ravi
Daniel > Subject: [PATCH v2 07/11] usb: musb: add Kconfig options for HOST, GAGDET > or DUAL_ROLE modes > > This makes building the actual object files optional to the selected > mode, which saves users who know which kind of USB mode support they > need some binary size. > > Unimplemented funct

RE: [PATCH v2 09/11] usb: musb: re-introduce musb->port_mode

2013-04-08 Thread B, Ravi
Daniel > Subject: [PATCH v2 09/11] usb: musb: re-introduce musb->port_mode > > Define MUSB_PORT_MODE_{HOST,GADGET,DUAL_ROLE} and store the > platform-specified value in struct musb. > > Note that MUSB_PORT_MODE_HOST has to be set to 1 in order to match > existing device tree bindings which are a

RE: [PATCH v2 00/11] usb: musb: add back support for host mode

2013-04-08 Thread B, Ravi
Felipe > Hi, > > On Mon, Apr 08, 2013 at 12:25:38PM +0200, B, Ravi wrote: > > Daniel > > > > > On 08.04.2013 09:57, B, Ravi wrote: > > > >> Hi all, > > > >> > > > >> here are some patches to separate the HCD and gadget pa

RE: [PATCH v2 00/11] usb: musb: add back support for host mode

2013-04-08 Thread B, Ravi
Daniel > On 08.04.2013 09:57, B, Ravi wrote: > >> Hi all, > >> > >> here are some patches to separate the HCD and gadget part of the musb > >> driver so they can be deselected in Kconfig. They also make the driver > >> keep track of the configured p

RE: [PATCH v2 00/11] usb: musb: add back support for host mode

2013-04-08 Thread B, Ravi
Daniel > Hi all, > > here are some patches to separate the HCD and gadget part of the musb > driver so they can be deselected in Kconfig. They also make the driver > keep track of the configured port mode that is set from DT, so the > actual runtime configuration can be selected dynamically. > >

RE: [PATCH 0/5] usb: musb: am335x support

2013-04-03 Thread B, Ravi
Felipe > > Hi, > > On Wed, Apr 03, 2013 at 02:43:00PM +0200, Daniel Mack wrote: > > On 03.04.2013 14:04, Felipe Balbi wrote: > > > On Wed, Apr 03, 2013 at 02:00:23PM +0200, Daniel Mack wrote: > > > > >> Felipe, could you explain the background on how the dsps driver is > > >> supposed to work in

RE: usb video capture issue due to uvc_complete callback spends more time

2013-03-29 Thread B, Ravi
Laurent/Ming Lei > > > > > > Since the uvc_video_complete() callback handler called from > > interrupt > > > > > context, video post processing or memcpy can be deferred to > tasklet > > or > > > > > bottom half, rather than doing it in interrupt context. > > > > > > > > If that's the only way to

RE: usb video capture issue due to uvc_complete callback spends more time

2013-03-29 Thread B, Ravi
Laurent > > > > Since the uvc_video_complete() callback handler called from > interrupt > > > > context, video post processing or memcpy can be deferred to tasklet > or > > > > bottom half, rather than doing it in interrupt context. > > > > > > If that's the only way to fix the issue, yes. Howeve

RE: usb video capture issue due to uvc_complete callback spends more time

2013-03-29 Thread B, Ravi
> > Laurent > > > > > On Thu, Mar 28, 2013 at 08:53:03PM +0800, Ming Lei wrote: > > > > > On Thu, Mar 28, 2013 at 8:30 PM, B, Ravi wrote: > > > > > > For example, in one iteration I have observed, the time taken by > > > > &g

RE: usb video capture issue due to uvc_complete callback spends more time

2013-03-29 Thread B, Ravi
Laurent > > > On Thu, Mar 28, 2013 at 08:53:03PM +0800, Ming Lei wrote: > > > > On Thu, Mar 28, 2013 at 8:30 PM, B, Ravi wrote: > > > > > For example, in one iteration I have observed, the time taken by > > > > > uvc_video_decode_isoc() was 2175

RE: usb video capture issue due to uvc_complete callback spends more time

2013-03-28 Thread B, Ravi
Hi, On Thu, Mar 28, 2013 at 9:27 PM, Felipe Balbi wrote: On Thu, Mar 28, 2013 at 03:23:46PM +0200, Felipe Balbi wrote: > Hi, > > On Thu, Mar 28, 2013 at 08:53:03PM +0800, Ming Lei wrote: > > On Thu, Mar 28, 2013 at 8:30 PM, B, Ravi wrote: > > > > > > For

RE: usb video capture issue due to uvc_complete callback spends more time

2013-03-28 Thread B, Ravi
Laurent > > > > > > Some more debugging, Most of the time spend in stream->decode() > function > > > > That points to uvc_video_decode_isoc(). > > You are correct, that points to uvc_video_decode_isoc() > > > > > > in uvc_video_complete() callback handler. > > > > It's not very surprising, but d

RE: usb video capture issue due to uvc_complete callback spends more time

2013-03-28 Thread B, Ravi
Laurent > On Thursday 28 March 2013 06:48:09 B, Ravi wrote: > > >> On Wednesday 27 March 2013 10:43:24 B, Ravi wrote: > > >>> Hi > > >>> > > >>> I am observing issue while streaming video from usb camera connected > to > > &

RE: usb video capture issue due to uvc_complete callback spends more time

2013-03-27 Thread B, Ravi
> > Laurent > > > > > Hi Ravi, > > > > On Wednesday 27 March 2013 10:43:24 B, Ravi wrote: > > > Hi > > > > > > I am observing issue while streaming video from usb camera connected > to > > host > > > controller base

RE: usb video capture issue due to uvc_complete callback spends more time

2013-03-27 Thread B, Ravi
Laurent > > Hi Ravi, > > On Wednesday 27 March 2013 10:43:24 B, Ravi wrote: > > Hi > > > > I am observing issue while streaming video from usb camera connected to > host > > controller based on mentor graphics. The issue is root caused that there >

usb video capture issue due to uvc_complete callback spends more time

2013-03-27 Thread B, Ravi
Hi I am observing issue while streaming video from usb camera connected to host controller based on mentor graphics. The issue is root caused that there are huge SOF gaps seen between the two isochronous IN token issued by host controller. This is due to fact, significant amount of time is spen

RE: [RFC PATCH 0/7] usb: musb: add driver for control module

2013-01-15 Thread B, Ravi
> Hi, > > On Tue, Jan 15, 2013 at 08:09:22PM +0530, kishon wrote: > > Hi Arnd, > > > > On Tuesday 15 January 2013 07:11 PM, Arnd Bergmann wrote: > > >On Tuesday 15 January 2013, Kishon Vijay Abraham I wrote: > > >>Added a new driver for the usb part of control module. > This has an > > >>API to

RE: [PATCH 0/5] usb: musb: am335x support

2012-11-02 Thread B, Ravi
> > On 02.11.2012 17:31, Afzal Mohammed wrote: > > This series adds usb support to am335x SoC's found on boards like > > Beagle Bone. Here only first instance is supported, as currently > > multiple phy's of same type is not supported (am335x has two USB2 > > phy's). > > I'm testing these patc

RE: XHCI: URB not cancelled during disconnect of a MSC device

2012-09-12 Thread B, Ravi
> > I am using v3.5 kernel and running a test where I disconnect > a SS MSC device while a big file is being written to it. I am > also watching the lsusb output in parallel. Expectation is > that SS MSC device should immediately disappear from lsusb > output but sometime I see that SS MSC is

RE: [PATCH v9 00/13] usb: musb: adding multi instance support

2012-09-11 Thread B, Ravi
> > > > > > On Fri, Aug 31, 2012 at 04:39:46PM +0530, Ravi Babu wrote: > > > > This series of patches adds, > > > > a) Multi instances support in musb driver > > > > b) DT support for musb_dsps glue layer > > > > c) DT support for NOP transceiver > > > > > > > > AM33xx and TI81xx has dual musb co

RE: [PATCH v9 00/13] usb: musb: adding multi instance support

2012-09-11 Thread B, Ravi
> > Hi, > > On Fri, Aug 31, 2012 at 04:39:46PM +0530, Ravi Babu wrote: > > This series of patches adds, > > a) Multi instances support in musb driver > > b) DT support for musb_dsps glue layer > > c) DT support for NOP transceiver > > > > AM33xx and TI81xx has dual musb controller and has two us

RE: [PATCH v9 01/13] usb: musb: dsps: add phy control logic to glue

2012-09-04 Thread B, Ravi
Hi > > > > >> AM335x uses NOP transceiver driver and need to enable > > > builtin PHY > > > > >> by writing into usb_ctrl register available in > system control > > > > >> module register space. This is being added at musb > glue driver > > > > >> layer untill a separate system control module

RE: [PATCH v9 01/13] usb: musb: dsps: add phy control logic to glue

2012-09-04 Thread B, Ravi
> On Fri, Aug 31, 2012 at 06:51:04PM +0530, ABRAHAM, KISHON VIJAY wrote: > > Hi, > > > > On Fri, Aug 31, 2012 at 5:53 PM, Felipe Balbi wrote: > > > Hi, > > > > > > On Fri, Aug 31, 2012 at 04:39:47PM +0530, Ravi Babu wrote: > > >> From: Santhapuri, Damodar > > >> > > >> AM335x uses NOP transceive

RE: [PATCH v8 08/13] arm/dts: am33xx: Add dt data for usbss

2012-08-31 Thread B, Ravi
> On Thu, Aug 30, 2012 at 4:20 PM, Ravi Babu wrote: > > From: Ajay Kumar Gupta > > > > Added device tree data for usbss on am33xx. There are two musb > > controllers on am33xx platform so have port0_mode and > port1_mode additional data. > > > > Signed-off-by: Ajay Kumar Gupta > > Signed-off

RE: [PATCH v8 08/13] arm/dts: am33xx: Add dt data for usbss

2012-08-31 Thread B, Ravi
> On Thu, Aug 30, 2012 at 03:39:40PM +0400, Sergei Shtylyov wrote: > > Hello. > > > > On 30-08-2012 14:50, Ravi Babu wrote: > > > > >From: Ajay Kumar Gupta > > > > >Added device tree data for usbss on am33xx. There are two musb > > >controllers on am33xx platform so have port0_mode and > port

RE: [PATCH] usb: storage: stop all current urbs when device is disconnected

2012-08-03 Thread B, Ravi
> > On Fri, 3 Aug 2012, B, Ravi wrote: > > > Alan, I did not understand, if the driver has unbound from > the device, > > what is the need to wait for 30seconds timeout to cancel the URB. > > Can you explain in detail. > > Consider a disk drive with a large

RE: [PATCH v7 00/11] usb: musb: adding multi instance support

2012-08-03 Thread B, Ravi
> On 03.08.2012 11:07, Hiremath, Vaibhav wrote: > > I have just pushed the code (V7 which Ravi submitted), so can you > > please try with below branch? > > > > > https://github.com/hvaibhav/am335x-linux/tree/am335x-upstream-staging- > > usb > > Thanks for doing this, but I'm unfortunately get

RE: [PATCH v7 00/11] usb: musb: adding multi instance support

2012-08-03 Thread B, Ravi
Hi Daniel > > >>> This series of patches adds, > > >>> a) Multi instances support in musb driver > > >>> b) DT support for musb_dsps glue layer > > >>> c) DT support for NOP transceiver > > >>> > > >>> AM33xx and TI81xx has dual musb controller and has two usb > > >> PHY of same type. > > >>> This

RE: [PATCH] usb: storage: stop all current urbs when device is disconnected

2012-08-02 Thread B, Ravi
> -Original Message- > From: Alan Stern [mailto:st...@rowland.harvard.edu] > Sent: Friday, August 03, 2012 7:15 AM > To: B, Ravi > Cc: Matthew Dharm; Greg Kroah-Hartman; > linux-usb@vger.kernel.org; usb-stor...@lists.one-eyed-alien.net > Subject: RE: [PATCH] u

RE: [PATCH v7 00/11] usb: musb: adding multi instance support

2012-08-02 Thread B, Ravi
Hi > > On 02.08.2012 14:12, Ravi Babu wrote: > > This series of patches adds, > > a) Multi instances support in musb driver > > b) DT support for musb_dsps glue layer > > c) DT support for NOP transceiver > > > > AM33xx and TI81xx has dual musb controller and has two usb > PHY of same type. > >

RE: [PATCH] usb: storage: stop all current urbs when device is disconnected

2012-08-02 Thread B, Ravi
Hi Thanks for the quick response. > > > > > Alan you may be correct. Let me explain, the issue occurs while > > > unplugging the device during Tx transfer, > > > 1) During Tx transfer, TX-DMA is programmed to transfer the data. > > > 2) The TX-DMA completes the transfer and generates > compl

RE: [PATCH] usb: storage: stop all current urbs when device is disconnected

2012-08-02 Thread B, Ravi
Hi > On Thu, 2 Aug 2012, B, Ravi wrote: > > > > > --- a/drivers/usb/storage/usb.c > > > > +++ b/drivers/usb/storage/usb.c > > > > @@ -844,6 +844,8 @@ static void > > > quiesce_and_remove_host(struct us_data *us) > > > >

RE: [PATCH] usb: storage: stop all current urbs when device is disconnected

2012-08-02 Thread B, Ravi
Hi Alan > > On Wed, 1 Aug 2012, Ravi Babu wrote: > > > When the scsi mass storage device is disconnected, the current urbs > > queued to hcd driver must be cancelled, otherwise the > current urbs are > > pending at hcd driver and the active urb programmed at host > controller > > will nev

RE: [PATCH v6 04/11] usb: otg: nop: add support for multiple tranceiver

2012-08-01 Thread B, Ravi
Hi > Subject: Re: [PATCH v6 04/11] usb: otg: nop: add support for > multiple tranceiver > > On Fri, Jul 27, 2012 at 02:02:00PM +0530, Ravi B wrote: > > +static void nop_put_id(int id) > > +{ > > + > > + pr_info("removing id %d\n", id); > > not pr_info. I guess pr_vdebug() is better. We don'

RE: [PATCH v6 03/11] usb: musb: am335x: add support for dual instance

2012-07-31 Thread B, Ravi
> Hi, > > On Fri, Jul 27, 2012 at 02:01:59PM +0530, Ravi B wrote: > > From: Ajay Kumar Gupta > > > > AM335x and TI81xx platform has dual musb controller so updating the > > musb_dspc.c to support the same. > > > > Changes: > > - Moved otg_workaround timer to glue structure > > - Moved