Re: [PATCH RFC] ehci-omap: simple suspend implementation

2018-02-25 Thread Andreas Kemnade
Hi, On Mon, 19 Feb 2018 11:41:36 +0200 Roger Quadros wrote: > Andreas, > > On 16/02/18 20:35, Andreas Kemnade wrote: > > On Fri, 16 Feb 2018 13:13:11 -0500 (EST) > > Alan Stern wrote: > > > >> On Fri, 16 Feb 2018, Andreas Kemnade wrote: > >>

Re: [PATCH RFC] ehci-omap: simple suspend implementation

2018-02-20 Thread Andreas Kemnade
On Mon, 19 Feb 2018 11:41:36 +0200 Roger Quadros wrote: [...] > If the Hardware SAR (Save and restore) functionality is enabled then > everything will be restored by hardware after a sleep to wake transition. > > But you will need this patch to enable SAR for the USB power domain. > https://lkml

Re: [PATCH RFC] ehci-omap: simple suspend implementation

2018-02-16 Thread Andreas Kemnade
On Fri, 16 Feb 2018 13:13:11 -0500 (EST) Alan Stern wrote: > On Fri, 16 Feb 2018, Andreas Kemnade wrote: > > > This powers down the phy and on a gta04 it reduces > > suspend current by 13 mA. > > For unknown reasons usb does not power on properly. > > Also calling

[PATCH RFC] ehci-omap: simple suspend implementation

2018-02-16 Thread Andreas Kemnade
approximately the same as without any patch. With a device connected the device does not enumerate after resume. A rmmod ehci-omap ; modprobe ehci-omap does not make it reenumerade. So there is still something wrong here. Signed-off-by: Andreas Kemnade --- drivers/usb/host/ehci-omap.c | 59

Re: [PATCH] usb: musb: fix enumeration after resume

2018-02-15 Thread Andreas Kemnade
On Wed, 7 Feb 2018 14:37:00 -0600 Bin Liu wrote: > On Tue, Feb 06, 2018 at 08:00:24PM +0100, Andreas Kemnade wrote: > > Hi, > > > > On Tue, 6 Feb 2018 12:46:05 -0600 > > Bin Liu wrote: > > > > > Hi, > > > > > > On Sat, Jan 27, 2

Re: [PATCH] usb: musb: fix enumeration after resume

2018-02-06 Thread Andreas Kemnade
Hi, On Tue, 6 Feb 2018 10:47:25 -0800 Tony Lindgren wrote: > * Andreas Kemnade [180127 08:34]: > > On dm3730 there are enumeration problems after resume. > > Investigation led to the cause that the MUSB_POWER_SOFTCONN > > bit is not set. If it was set before suspend (becau

Re: [PATCH] usb: musb: fix enumeration after resume

2018-02-06 Thread Andreas Kemnade
Hi, On Tue, 6 Feb 2018 12:46:05 -0600 Bin Liu wrote: > Hi, > > On Sat, Jan 27, 2018 at 09:34:03AM +0100, Andreas Kemnade wrote: > > On dm3730 there are enumeration problems after resume. > > Investigation led to the cause that the MUSB_POWER_SOFTCONN > > bit is no

Re: power management problems in ehci-omap

2018-02-06 Thread Andreas Kemnade
On Tue, 6 Feb 2018 10:16:23 -0800 Tony Lindgren wrote: > * Andreas Kemnade [180206 18:04]: > > On Tue, 6 Feb 2018 09:17:37 -0800 > > Tony Lindgren wrote: > > > uarts=$(find /sys/class/tty/tty[SO]*/power/ -type d 2>/dev/null) > > > for uart in $uarts; do &

Re: power management problems in ehci-omap

2018-02-06 Thread Andreas Kemnade
On Tue, 6 Feb 2018 09:17:37 -0800 Tony Lindgren wrote: > * Andreas Kemnade [180206 16:56]: > > On Tue, 6 Feb 2018 08:04:52 -0800 > > Tony Lindgren wrote: > > > > > * Andreas Kemnade [180206 06:42]: > > > > rechecked with a board with really noth

Re: power management problems in ehci-omap

2018-02-06 Thread Andreas Kemnade
On Tue, 6 Feb 2018 08:04:52 -0800 Tony Lindgren wrote: > * Andreas Kemnade [180206 06:42]: > > rechecked with a board with really nothing connected there > > Same behaviour > > I've just verified that my test board power consumption goes > back to normal aft

Re: power management problems in ehci-omap

2018-02-05 Thread Andreas Kemnade
On Sun, 4 Feb 2018 09:43:45 +0100 Michael Nazzareno Trimarchi wrote: > Hi Andreas > > On Sun, Feb 4, 2018 at 9:38 AM, Andreas Kemnade wrote: > > On Sun, 4 Feb 2018 00:10:50 +0100 > > Michael Nazzareno Trimarchi wrote: > > > >> Hi > >> > >

Re: power management problems in ehci-omap

2018-02-05 Thread Andreas Kemnade
On Sun, 4 Feb 2018 11:55:02 +0100 Michael Nazzareno Trimarchi wrote: > Hi Andreas > > On Sun, Feb 4, 2018 at 11:50 AM, Andreas Kemnade wrote: > > Hi, > > > > On Sun, 4 Feb 2018 09:43:45 +0100 > > Michael Nazzareno Trimarchi wrote: > > > >> Hi

Re: power management problems in ehci-omap

2018-02-04 Thread Andreas Kemnade
Hi, On Sun, 4 Feb 2018 09:43:45 +0100 Michael Nazzareno Trimarchi wrote: > Hi Andreas > > On Sun, Feb 4, 2018 at 9:38 AM, Andreas Kemnade wrote: > > On Sun, 4 Feb 2018 00:10:50 +0100 > > Michael Nazzareno Trimarchi wrote: > > > >> Hi > >>

Re: power management problems in ehci-omap

2018-02-04 Thread Andreas Kemnade
On Sun, 4 Feb 2018 00:10:50 +0100 Michael Nazzareno Trimarchi wrote: > Hi > > On Sun, Feb 4, 2018 at 12:03 AM, Andreas Kemnade wrote: > > Hi, > > > > I booted a 4.15 kernel without udev and loaded modules piece by piece to > > analyze > > pm problems.

power management problems in ehci-omap

2018-02-03 Thread Andreas Kemnade
Hi, I booted a 4.15 kernel without udev and loaded modules piece by piece to analyze pm problems. modprobe ehci-omap increases current by around 35mA and also rmmod ehci-omap does not let it go down at all. I expect that removing hardware does the same thing Also suspend current increases by aro

[PATCH] usb: musb: fix enumeration after resume

2018-01-27 Thread Andreas Kemnade
lated stuff which needs to be enabled. Also interrupts are enabled, as it was the original idea of calling musb_start() in musb_resume() according to Commit 6fc6f4b87cb3 ("usb: musb: Disable interrupts on suspend, enable them on resume") Signed-off-by: Andreas Kemnade --- drivers/usb/musb/

Re: [PATCH] net: hso: register netdev later to avoid a race condition

2017-04-28 Thread Andreas Kemnade
On Thu, 27 Apr 2017 10:44:01 +0200 Johan Hovold wrote: > On Wed, Apr 26, 2017 at 07:26:40PM +0200, Andreas Kemnade wrote: > > If the netdev is accessed before the urbs are initialized, > > there will be NULL pointer dereferences. That is avoided by > > registering it when it

[PATCH] net: hso: register netdev later to avoid a race condition

2017-04-26 Thread Andreas Kemnade
e3822080 e1822781 e5981014 (e5832030) [ 1514.510833] ---[ end trace dfb3e53c657f34a0 ]--- Reported-by: H. Nikolaus Schaller Signed-off-by: Andreas Kemnade --- drivers/net/usb/hso.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/net/usb/hso.c b/drivers/net/usb

[PATCH] net: hso: fix module unloading

2017-04-24 Thread Andreas Kemnade
[] (SyS_delete_module+0x160/0x1dc) [40265.985443] [] (SyS_delete_module) from [] (ret_fast_syscall+0x0/0x1c) [40265.994171] Code: c1458d54 e59f3020 e92d4010 e1a04000 (e5941034) [40266.016693] ---[ end trace 9d5ac43c7e41075c ]--- Signed-off-by: Andreas Kemnade --- drivers/net/usb/hso.c | 2 +- 1

Re: [PATCHv2] usb: musb: Fix unbalanced platform_disable

2016-09-19 Thread Andreas Kemnade
On Mon, 19 Sep 2016 09:02:50 -0700 Tony Lindgren wrote: > * Andreas Kemnade [160918 23:00]: > > On Sun, 18 Sep 2016 08:19:02 -0700 > > Tony Lindgren wrote: > > > > > * Laurent Pinchart [160918 > > > 05:13]: > > > > > > > >

Re: [PATCHv2] usb: musb: Fix unbalanced platform_disable

2016-09-18 Thread Andreas Kemnade
On Sun, 18 Sep 2016 08:19:02 -0700 Tony Lindgren wrote: > * Laurent Pinchart [160918 05:13]: > > > > FYI, while this patch allows me to boot my Panda board with NFS > > over usbnet, it only works with cold boots. A warm reboot results > > in the following warning, and no ethernet traffic going

Re: [PATCHv2] usb: musb: Fix unbalanced platform_disable

2016-09-12 Thread Andreas Kemnade
> > > > never enable it. > > > > > > > > The root cause of the problem is unpaired calls from > > > > musb_core.c to musb_platform_enable/disable in musb_core.c as > > > > reported by Andreas Kemnade . > > > > > > > > As musb_p

Re: [v2] musb: omap2430: do not assume balanced enable()/disable()

2016-09-10 Thread Andreas Kemnade
On Fri, 9 Sep 2016 16:40:15 -0700 Tony Lindgren wrote: > * Tony Lindgren [160909 14:33]: > > * Andreas Kemnade [160909 14:22]: > > > We have two independant things: > > > 1. phy-twl4030-usb (and perhaps others) do not enable > > > the phy enough

Re: [v2] musb: omap2430: do not assume balanced enable()/disable()

2016-09-09 Thread Andreas Kemnade
unbalanced way by fixing musb_core.c Fixing 1. is enough on gta04 to fix charging and hide 2. enough to have gadget working for the most common usecases. (not using twl4030-charger would not work yet) But in the longer term 2. has to be fixed too. Regards, Andreas Kemnade -- To uns

Re: [v2] musb: omap2430: do not assume balanced enable()/disable()

2016-09-09 Thread Andreas Kemnade
On Fri, 09 Sep 2016 23:21:50 +0300 Laurent Pinchart wrote: > Hi Tony, > > On Friday 09 Sep 2016 13:08:03 Tony Lindgren wrote: > > * Laurent Pinchart [160909 > > 12:27]: > > > On Wednesday 03 Aug 2016 17:38:51 Andreas Kemnade wrote: > > >> The co

Re: [PATCH 0/4] Implement PM runtime for musb-core based on session bit

2016-08-21 Thread Andreas Kemnade
Hi, On Thu, 18 Aug 2016 15:46:46 -0700 Tony Lindgren wrote: > Hi all, > > Here's a series of patches to simplify musb PM runtime support > further. > > I finally figured out that we can get rid of most of the glue layer > specific workarounds by following the devctl session bit in musb core. >

Re: [Letux-kernel] [PATCH v2] musb: omap2430: do not assume balanced enable()/disable()

2016-08-08 Thread Andreas Kemnade
On Fri, 5 Aug 2016 23:21:35 -0700 Tony Lindgren wrote: > * Andreas Kemnade [160805 08:35]: > > I repeat the subject line of the patch: > > [PATCH v2] musb: omap2430: do not assume balanced enable()/disable() > > It is *not* fix charging. > > > > So you mean t

Re: [Letux-kernel] [PATCH v2] musb: omap2430: do not assume balanced enable()/disable()

2016-08-05 Thread Andreas Kemnade
On Fri, 5 Aug 2016 06:55:01 -0700 Tony Lindgren wrote: > * Andreas Kemnade [160804 09:44]: > > Nothing happens here, so the previous state of the phy remains. > > It would be disabled by the generic phy layer in > > drivers/phy/phy-core.c > > > > > gadget dri

Re: [Letux-kernel] [PATCH v2] musb: omap2430: do not assume balanced enable()/disable()

2016-08-04 Thread Andreas Kemnade
On Thu, 4 Aug 2016 16:49:30 +0200 "H. Nikolaus Schaller" wrote: > > Rationale: > > > > The charger driver calls pm_runtime_get_sync(bci->transceiver->dev); > > which should indirectly call twl4030_usb_set_mode to set the > > POWER_CTRL_OTG_ENAB bit. This enables the prescaler hardware > > for AD

Re: [Letux-kernel] [PATCH v2] musb: omap2430: do not assume balanced enable()/disable()

2016-08-04 Thread Andreas Kemnade
On Thu, 4 Aug 2016 18:31:29 +0200 Andreas Kemnade wrote: > Hi, > > On Thu, 4 Aug 2016 07:29:19 -0700 > Tony Lindgren wrote: > > > Hi, > > > > * H. Nikolaus Schaller [160803 10:07]: > > > All this prevents detection of cable plugin-events and VBUS &

Re: [Letux-kernel] [PATCH v2] musb: omap2430: do not assume balanced enable()/disable()

2016-08-04 Thread Andreas Kemnade
Hi, On Thu, 4 Aug 2016 07:29:19 -0700 Tony Lindgren wrote: > Hi, > > * H. Nikolaus Schaller [160803 10:07]: > > All this prevents detection of cable plugin-events and VBUS > > measurement and setting OTG_EN before charging is attempted. > > So I gave this patch a try but it now blocks all dee

[PATCH v2] musb: omap2430: do not assume balanced enable()/disable()

2016-08-03 Thread Andreas Kemnade
events phy_power_off() from being called when it is already off. Signed-off-by: Andreas Kemnade --- changes in v2: improved commit message drivers/usb/musb/omap2430.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap

Re: [PATCH] musb: omap2430: do not assume balanced enable()/disable()

2016-08-03 Thread Andreas Kemnade
On Tue, 2 Aug 2016 23:30:16 -0700 Tony Lindgren wrote: > * Andreas Kemnade [160802 08:14]: > > On Tue, 2 Aug 2016 03:33:34 -0700 > > Tony Lindgren wrote: > > > > > * Andreas Kemnade [160729 11:14]: > > > > The code assumes that omap2430_musb_enabl

Re: [PATCH] musb: omap2430: do not assume balanced enable()/disable()

2016-08-02 Thread Andreas Kemnade
On Tue, 2 Aug 2016 03:33:34 -0700 Tony Lindgren wrote: > * Andreas Kemnade [160729 11:14]: > > The code assumes that omap2430_musb_enable() and > > omap2430_musb_disable() is called in a balanced way. The > > That fact is broken by the fact that musb_in

[PATCH] musb: omap2430: do not assume balanced enable()/disable()

2016-07-29 Thread Andreas Kemnade
-by: Andreas Kemnade --- drivers/usb/musb/omap2430.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c index aecb934..c7ae117 100644 --- a/drivers/usb/musb/omap2430.c +++ b/drivers/usb/musb/omap2430.c @@ -415,9 +415